Yakov Olkhovskiy
43fcea64b6
Merge pull request #57186 from chenlx0/bytes_uncompressed
...
Show uncompressed data size in system.tables
2023-12-19 19:04:47 -05:00
Jordi Villar
7c281d9a6f
Allow max_size_to_drop settings in query time ( #57452 )
2023-12-19 23:16:03 +01:00
jsc0218
0a9475abc7
Merge pull request #57874 from joelynch/joelynch/host-psql
...
bugfix: addresses_expr ignored for psql named collections
2023-12-19 15:24:23 -05:00
Julia Kartseva
c7eff0e573
Merge pull request #58015 from jkartseva/fix-fuzzjson-segfault
...
Fix segfault in FuzzJSON engine
2023-12-19 11:19:20 -08:00
Julia Kartseva
58f75c9679
Update src/Storages/StorageFuzzJSON.cpp
...
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
2023-12-19 10:17:15 -08:00
Sema Checherinda
802ad4ec47
Merge pull request #57523 from ClickHouse/remove-the-limit-for-connections-per-endpoint
...
Remove the limit for the number of connections per endpoint for background fetches + small refactoring
2023-12-19 19:16:01 +01:00
Nikita Taranov
a375b1eab8
Fix handling of unavailable replicas before first request happened ( #57933 )
2023-12-19 16:41:51 +01:00
Raúl Marín
b458c77340
Fix integration test
2023-12-19 14:36:03 +01:00
Antonio Andelic
52b3caec90
Revert "Add system.dropped_tables_parts table"
2023-12-19 10:36:22 +01:00
Shani Elharrar
679a0e1300
StorageS3 / TableFunctionS3: Allow passing session_token to AuthSettings
...
This can help users that want to pass temporary credentials that
issued by AWS in order to load data from S3 without changing
configuration or creating an IAM User.
Fixes #57848
2023-12-19 08:06:36 +02:00
Julia Kartseva
6014dca114
Allow multiple columns in StorageFuzzJSON
2023-12-19 02:34:23 +00:00
Julia Kartseva
0fc402c106
Fix segfault in FuzzJSON engine
...
Allow only String type for FuzzJSON engine table columns.
Fixes: https://github.com/ClickHouse/ClickHouse/issues/57858
2023-12-19 02:20:37 +00:00
Anton Popov
bfd403cc8c
Merge pull request #57996 from CurtizJ/better-trivial-count-merge
...
Better trivial count optimization for storage `Merge`
2023-12-19 02:25:58 +01:00
Yakov Olkhovskiy
fd460566f6
fix setting description
2023-12-18 19:34:08 -05:00
Han Fei
032fd08559
Merge pull request #57991 from hanfei1991/hanfei/refine-err-msg
...
refine error message
2023-12-19 01:14:18 +01:00
Nikita Mikhaylov
6360b76792
Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint
2023-12-18 21:49:31 +00:00
Alexey Milovidov
1a7de9158f
Merge pull request #57979 from ClickHouse/add-test-49708
...
Add a test for #49708
2023-12-18 21:29:11 +01:00
Alexey Milovidov
7178bd5c88
Merge pull request #57910 from Algunenano/log_message_string
...
Improvements for 00002_log_and_exception_messages_formatting
2023-12-18 21:02:23 +01:00
Alexander Tokmakov
de7a349f0d
Update MergeTreeData.cpp
2023-12-18 20:44:50 +01:00
Raúl Marín
46067adce8
Improve ZooKeeperRetriesControl so it's easier to reuse
2023-12-18 17:43:10 +01:00
Yakov Olkhovskiy
8e39c61401
Merge remote-tracking branch 'origin/master' into ft-dropped_tables_parts
2023-12-18 15:40:07 +00:00
Anton Popov
7ebb7d2955
better trivial count optimization for storage Merge
2023-12-18 15:13:43 +00:00
Anton Popov
10bc2db56d
add setting
2023-12-18 13:57:07 +00:00
Raúl Marín
88dcaefde8
Style
2023-12-18 14:51:46 +01:00
Han Fei
028d1c9478
refine error message
2023-12-18 14:47:54 +01:00
Raúl Marín
0346850897
Support keeper failures in quorum check
2023-12-18 12:54:15 +01:00
Raúl Marín
2639d0715f
Merge remote-tracking branch 'blessed/master' into log_message_string
2023-12-18 10:40:18 +01:00
vdimir
f024e39e3b
Merge pull request #57888 from ucasfl/fix-transfer-external-query
...
Fix transform query for external database
2023-12-18 10:28:32 +01:00
Raúl Marín
f10dae4761
Merge pull request #56917 from Algunenano/backup_1
...
Prepare the introduction of more keeper faults
2023-12-18 10:27:48 +01:00
Alexey Milovidov
69e6e59e96
Add a test for #49708
2023-12-18 08:34:53 +01:00
Alexey Milovidov
b0eb670776
Merge pull request #57974 from ClickHouse/revert-stack-trace-changes
...
Revert "Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo"
2023-12-18 04:50:12 +01:00
Alexey Milovidov
58396c5546
Merge pull request #57218 from tntnatbry/issue-43666
...
Issue 43666: Add skip_unavailable_shards as a setting for Distributed table.
2023-12-18 04:48:57 +01:00
Alexey Milovidov
2859ac08c9
Revert "Merge pull request #57907 from azat/system.stack_trace-rt_tgsigqueueinfo"
...
This reverts commit a33d6b0c96
, reversing
changes made to cf031a1b8e
.
2023-12-18 02:01:14 +01:00
Robert Schulze
7f675ddf80
Merge pull request #57878 from Jpnock/master
...
Apply full-text skipping index when using `hasAny()`
2023-12-17 11:06:29 +01:00
Robert Schulze
fc67d2c0e9
Merge pull request #57867 from skyoct/read_code
...
Support trivial count optimization for `Merge`-engine tables
2023-12-17 10:45:21 +01:00
Shani Elharrar
c696c0bfe7
S3Common.AuthSettings: Allow passing SESSION_TOKEN to AWSCredentials
...
This sets the infrastructure of loading session_token and passing it directly
to all AWSCredentials instances that are created using the AuthSettings.
The default SESSION_TOKEN is set to an empty string as documented in AWS SDK
reference: https://sdk.amazonaws.com/cpp/api/0.12.9/d4/d27/class_aws_1_1_auth_1_1_a_w_s_credentials.html
2023-12-17 10:29:15 +02:00
Sergei Trifonov
3634b949a8
Merge pull request #57793 from ClickHouse/rename-system-table
...
Rename `system.async_loader` into `system.asynchronous_loader`
2023-12-16 17:33:04 +01:00
Sergei Trifonov
37a01bc109
Merge branch 'master' into ft-dropped_tables_parts
2023-12-16 11:53:37 +01:00
Kseniia Sumarokova
4279dd2bf1
Merge pull request #57687 from ClickHouse/make-system-filesystem-cache-query-no-memory-intensive
...
Make querying system.filesystem_cache not memory intensive
2023-12-16 11:28:28 +01:00
Alexey Milovidov
ee502ef6b9
Remove trash (OPTIMIZE CLEANUP)
2023-12-15 22:41:58 +01:00
Raúl Marín
6cf8c9b607
Review improvements
2023-12-15 19:44:13 +01:00
Raúl Marín
b269f87f4c
Better text_log with ErrnoException
2023-12-15 19:27:56 +01:00
James Nock
9aa1ec488c
Apply full-text skipping index when using hasAll()
2023-12-15 17:28:33 +00:00
Azat Khuzhin
106042cf41
Fix system.stack_trace for threads with blocked SIGRTMIN
...
Some third-party libraries (i.e. librdkafka) could block it, and in this
case system.stack_trace will return stacktrace for the main process
(usually, basically it could be any thread with non blocked signal).
By replacing sigqueue() with more precise rt_tgsigqueueinfo(), other
threads will not respond to the signal.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-15 17:47:01 +01:00
flynn
82fc51ffa6
add test
2023-12-15 15:29:15 +00:00
Robert Schulze
066579f7d7
Improve code aesthetics
2023-12-15 15:07:40 +00:00
Nikita Mikhaylov
1780671443
ClickHouse Cloud promotion ( #57638 )
...
Co-authored-by: Alexander Sapin <alesapin@gmail.com>
2023-12-15 15:23:23 +01:00
Raúl Marín
946defa8a6
Merge pull request #57860 from zvonand/zvonand-fix-57819
...
Try to fix memory leak in StorageHDFS
2023-12-15 11:50:17 +01:00
kssenii
7bbb456ae9
Fix style check
2023-12-15 11:32:26 +01:00
kssenii
5de9c143a5
Merge remote-tracking branch 'origin/master' into make-system-filesystem-cache-query-no-memory-intensive
2023-12-15 11:32:14 +01:00
Kseniia Sumarokova
f285a01b17
Merge pull request #57863 from ClickHouse/fix-flaky-pg-test
...
Follow up to #57568
2023-12-15 11:29:32 +01:00
Kseniia Sumarokova
06438cc17b
Merge pull request #57578 from ClickHouse/allow-to-change-some-cache-settings-without-restart
...
Allow to apply some fs cache config settings changes without server restart
2023-12-15 11:18:19 +01:00
flynn
2d45213f70
Fix transform query for external database
2023-12-15 08:34:58 +00:00
skyoct
3319934055
reafactor function
2023-12-15 04:49:38 +00:00
Alexey Milovidov
23cee7ef37
Merge pull request #57851 from azat/revert-55271-local-lazy-database
...
Revert "Replace --no-system-tables with loading virtual tables of system database lazily"
2023-12-15 03:25:59 +01:00
Andrey Zvonov
0174b94469
Merge branch 'ClickHouse:master' into zvonand-fix-57819
2023-12-14 20:14:54 +01:00
Raúl Marín
546484d46b
Merge remote-tracking branch 'blessed/master' into backup_1
2023-12-14 19:03:59 +01:00
Duc Canh Le
93dd6b83e7
Do not allow creating replicated table with inconsistent merge params ( #56833 )
...
* save all merge params to zookeeper
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
* calculate hash for graphite merge params
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
* add graphite params hash to zookeeper + fix tests
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
* install new graphite for testing
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
* fix backward incompatibility
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
* minor fix test
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
* Update src/Storages/MergeTree/ReplicatedMergeTreeTableMetadata.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
* remove peekString and add more comments
- peekString doesn't always work even for ReadBufferFromString
- more comment re. backward compatibility
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
---------
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-12-14 17:26:35 +01:00
joelynch
b4bef78e63
bugfix: addresses_expr ignored for psql named collections
2023-12-14 17:17:14 +01:00
Andrey Zvonov
f9579580e9
Retrigger CI + make docs a bit better
2023-12-14 16:34:10 +01:00
kssenii
3605caa8d9
Fxi
2023-12-14 16:05:40 +01:00
kssenii
ea7e55b929
Simplify
2023-12-14 15:58:06 +01:00
skyoct
0a4882d781
feat: update style
2023-12-14 14:26:47 +00:00
skyoct
d700eb2501
feat: support trivial count optimization for Merge
2023-12-14 14:08:24 +00:00
kssenii
a4a264c785
Fix
2023-12-14 14:04:17 +01:00
Andrey Zvonov
7d7aea9826
try fix memory leak in StorageHDFS
2023-12-14 13:01:47 +01:00
Nikita Mikhaylov
a0af0392cd
Random changes in random files ( #57642 )
2023-12-14 12:47:11 +01:00
Igor Nikonov
42d0afef1f
Merge pull request #57749 from ClickHouse/pr-perf-improve-hope
...
Parallel replicas: announcement response handling improvement
2023-12-14 11:48:51 +01:00
Raúl Marín
efcacd3c34
Merge remote-tracking branch 'blessed/master' into backup_1
2023-12-14 11:08:50 +01:00
Azat Khuzhin
0e86e16a01
Revert "Replace --no-system-tables with loading virtual tables of system database lazily"
2023-12-14 09:07:47 +01:00
Alexey Milovidov
7a2edb4804
Merge pull request #57822 from azat/kafka-disable-stat
...
Disable system.kafka_consumers by default (due to possible live memory leak)
2023-12-14 04:37:50 +01:00
Yakov Olkhovskiy
9e1d583f54
fix style
2023-12-13 23:36:54 +00:00
Kseniia Sumarokova
79db3c66df
Merge branch 'master' into allow-to-change-some-cache-settings-without-restart
2023-12-13 23:33:59 +01:00
Yakov Olkhovskiy
441050adce
fix style, cleanup
2023-12-13 22:26:38 +00:00
Julia Kartseva
b8d274d070
Add malformed output generation to JSON fuzzer ( #57646 )
...
Randomly modify structural characters of a valid JSON ('{', '}', '[', ']',
':', '"', ',') to generate output that cannot be parsed as JSON.
Follow-up to https://github.com/ClickHouse/ClickHouse/pull/56490
2023-12-13 19:59:31 +01:00
Alexey Milovidov
bf4964b177
Merge pull request #57712 from ClickHouse/clickbench-ci
...
Add ClickBench to CI
2023-12-13 19:52:44 +01:00
Nikita Taranov
560e66f3ca
More respect to min_number_of_marks
in ParallelReplicasReadingCoordinator
( #57763 )
2023-12-13 19:51:49 +01:00
Nikita Mikhaylov
8372c70958
Merge branch 'master' of github.com:ClickHouse/ClickHouse into remove-the-limit-for-connections-per-endpoint
2023-12-13 18:29:56 +00:00
Yakov Olkhovskiy
f4e2933f5d
use storage uuid instead of table name as a key in storage info because there are can be multiple dropped table with the same name
2023-12-13 18:08:41 +00:00
Azat Khuzhin
055c231438
Disable system.kafka_consumers by default (due to possible live memory leak)
...
It is not safe to use statistics because of how KafkaEngine works - it
pre-creates consumers, and this leads to the situation when this
statistics entries generated (RD_KAFKA_OP_STATS), but never consumed.
Which creates a live memory leak for a server with Kafka tables, but
without materialized view attached to it (and no SELECT).
Another problem is that this makes shutdown very slow, because of how
pending queue entries are handled in librdkafka, it uses
TAILQ_INSERT_SORTED, which is sorted insert into linked list, which
works incredibly slow (likely you will never wait till it ends and kill
the server)
For instance in my production setup the server was running for ~67 days
with such table, and it got 1'942'233 `TAILQ_INSERT_SORTED` entries
(which perfectly matches by the way - `67*86400/3` = 1'929'600), and it
moved only 289'806 entries for a few hours, though I'm not sure how much
time the process was in the running state, since most of the time it was
with debugger attached.
So for now let's disable it, to make this patch easy for backporting,
and I will think about long term fix - do not pre-create consumers in
Kafka engine.
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-12-13 18:13:13 +01:00
Anton Popov
7598403f78
Merge remote-tracking branch 'upstream/master' into HEAD
2023-12-13 16:55:17 +00:00
Yakov Olkhovskiy
0ea4b16530
Merge branch 'master' into ft-dropped_tables_parts
2023-12-13 09:01:59 -05:00
Igor Nikonov
c165be76ab
Parallel replicas: friendly settings ( #57542 )
2023-12-13 14:42:06 +01:00
Raúl Marín
dd405a655e
Merge remote-tracking branch 'blessed/master' into backup_1
2023-12-13 13:39:58 +01:00
Kseniia Sumarokova
b1325450e9
Merge pull request #57754 from ClickHouse/fix-loading-dependent-table-materialized-postgresql
...
Table engine MaterializedPostgreSQL fix dependency loading
2023-12-13 12:17:01 +01:00
Yakov Olkhovskiy
5121bfcd78
major refactoring
2023-12-13 07:16:30 +00:00
Alexey Milovidov
62b6d1ef5e
iMerge branch 'master' of github.com:ClickHouse/ClickHouse into clickbench-ci
2023-12-13 01:41:27 +01:00
Alexey Milovidov
f11b90e7bb
Allow buckets without List access
2023-12-13 00:10:58 +01:00
Igor Nikonov
616d054dee
Merge remote-tracking branch 'origin/master' into pr-perf-improve-hope
2023-12-12 21:27:31 +00:00
Igor Nikonov
7f4a028196
Test and fix
2023-12-12 21:26:58 +00:00
serxa
57d7a58dbe
Rename system.async_loader
into system.asynchronous_loader
2023-12-12 16:55:27 +00:00
kssenii
cc71b40002
Merge remote-tracking branch 'origin/master' into make-system-filesystem-cache-query-no-memory-intensive
2023-12-12 16:40:04 +01:00
Alexander Gololobov
09d6e6b945
Merge pull request #57743 from ClickHouse/other_timeout_for_wait
...
Increase async block cache deduplication timeout
2023-12-12 15:40:04 +01:00
Raúl Marín
049fb60c73
Fix error on retries due to TABLE_IS_READ_ONLY
2023-12-12 15:37:28 +01:00
kssenii
fa0b2b9e50
Merge remote-tracking branch 'origin/master' into make-system-filesystem-cache-query-no-memory-intensive
2023-12-12 15:31:01 +01:00
Chen Lixiang
68af81196d
Merge branch 'ClickHouse:master' into bytes_uncompressed
2023-12-12 22:06:45 +08:00
Kruglov Pavel
8a447bf57c
Merge pull request #55892 from Avogar/schema-inference-union
...
Add 'union' mode for schema inference
2023-12-12 15:02:06 +01:00
Nikolai Kochetov
696a2d9f4f
Merge pull request #57614 from ClickHouse/vdimir/join_array_lowcard_totals_crash
...
Fix type correction in HashJoin for nested low cardinality
2023-12-12 14:56:41 +01:00
Raúl Marín
923c3b7b32
Implement retries when ZK connection fails without committing the transaction
2023-12-12 12:00:46 +01:00
Raúl Marín
9d8d5dfdf6
Partially revert "make stages commit"
...
This reverts commit e4becc01ba
.
2023-12-12 11:26:48 +01:00