Commit Graph

3644 Commits

Author SHA1 Message Date
alexey-milovidov
02937294ce
Merge pull request #5311 from azat-archive/SimpleAggregateFunction-Arena-fix
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
2019-05-19 13:12:38 +03:00
Danila Kutenin
295a4a8684
Merge pull request #5330 from yandex/format_function
Format function added
2019-05-19 12:07:57 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
alexey-milovidov
2254b171a7
Merge pull request #5313 from yandex/fix-external-query-in-with-single-element
Fix external queries with IN operator.
2019-05-19 03:12:57 +03:00
alexey-milovidov
e73fc1bd0f
Merge pull request #5320 from sundy-li/feature/funnel64
Make windowFunnel support other Unsigned Integer Types
2019-05-18 23:47:12 +03:00
Danila Kutenin
fca6e4fd38 constant string handling 2019-05-18 18:09:52 +03:00
Danila Kutenin
84b04dc8ea format function added 2019-05-18 15:29:10 +03:00
Danila Kutenin
a48cf9abe5 format function added 2019-05-18 14:30:50 +03:00
Danila Kutenin
4e3a607267 format function added 2019-05-18 14:30:36 +03:00
alexey-milovidov
24b16da9fd
Merge pull request #5235 from vitlibar/improve-new-json-functions
Improve new json functions
2019-05-18 12:51:41 +03:00
alexey-milovidov
8b9b305a5f
Merge pull request #5325 from abyss7/issue-5286
Allow to shadow virtual column '_table' in Merge engine
2019-05-18 00:17:34 +03:00
alexey-milovidov
34f36e2891
Merge pull request #5304 from 4ertus2/funcs
Support quantile(s) and median for Decimal
2019-05-17 23:03:27 +03:00
Danila Kutenin
e0b90de474
Merge pull request #5322 from yandex/to_valid_utf8
toValidUTF8 function added
2019-05-17 22:48:32 +03:00
Ivan Lezhankin
7b6c78402d Allow to shadow virtual column '_table' in Merge engine 2019-05-17 20:40:51 +03:00
Danila Kutenin
0d3422fa8a toValidUTF8 function added 2019-05-17 15:55:21 +03:00
alesapin
7a9dfbbb53 More stable perf tests 2019-05-17 14:42:41 +03:00
sundy-li
760bc5708d support unsigned integer type in windowFunnel Aggregate function 2019-05-17 19:17:52 +08:00
Alexey Milovidov
efd882aa29 Better logic 2019-05-16 22:55:18 +03:00
Vitaly Baranov
823d862ceb Add a setting to disable simdjson. 2019-05-16 22:39:49 +03:00
Alexey Milovidov
842d62463b Added more tests 2019-05-16 22:26:32 +03:00
Vitaly Baranov
cb459c79aa Add a test case with incorrect JSON. 2019-05-16 20:43:01 +03:00
Vitaly Baranov
8ab4e4dcfe Use rapidjson when AVX2 instructions are not available. 2019-05-16 20:40:24 +03:00
Artem Zuikov
c3588fd5da
Merge pull request #5291 from 4ertus2/nulls
Add toDecimalOrZero and toDecimalOrNull fuctions
2019-05-16 18:53:17 +03:00
chertus
fdcbf509bb support quantile(s)ExactWeighted for Decimal 2019-05-16 17:33:13 +03:00
Vitaly Baranov
ae4f472bc7 Add tests cases and fix documentation for JSON functions. 2019-05-16 16:48:19 +03:00
chertus
50c35a70db support quanitle, quantiles, median for Decimal 2019-05-16 15:53:33 +03:00
chertus
ab517cdf4d Merge branch 'master' into decimal 2019-05-16 14:22:52 +03:00
Vitaly Baranov
f4942007e1 Add function JSONExtractKeysAndValues(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
c93bd31695 Simplify template implementation. 2019-05-16 14:09:22 +03:00
Vitaly Baranov
76bda0342b Move ExtraArg to the end of arguments of JSONExtract(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
d003682626 Implement function JSONExtractRaw(). 2019-05-16 14:09:22 +03:00
Vitaly Baranov
8be2e728c0 Use capital letters in the names of json functions: jsonHas => JSONHas 2019-05-16 14:09:22 +03:00
Vitaly Baranov
0d26ac8583 Reimplement indices in objects in more straightforward way 2019-05-16 14:09:22 +03:00
chertus
2739a3f6d0 Merge branch 'master' into nulls 2019-05-16 14:02:12 +03:00
alexey-milovidov
dcc88f3a0c
Merge pull request #5284 from 4ertus2/bugs
fix decimal quoted csv input
2019-05-16 00:07:23 +03:00
chertus
5f19c0981d add toDecimalOrZero and toDecimalOrNull fuctions 2019-05-15 21:50:35 +03:00
alesapin
d477cc0df4 Fix incorrect performance tests 2019-05-15 19:44:25 +03:00
Yangkuan Liu
0760a3436f add AggregateFunction TSgroup{Rate}Sum (#4542) 2019-05-15 19:16:25 +03:00
chertus
720f8667e4 fix decimal quoted csv input 2019-05-15 16:51:17 +03:00
chertus
02f01a5104 throw Decimal overflow for Inf and NaN 2019-05-15 15:28:44 +03:00
Vitaly Baranov
9620e2e223
Merge pull request #5003 from Enmk/geohash_support
Implementation of geohashEncode and geohashDecode functions;
2019-05-14 20:01:22 +03:00
Artem Zuikov
aba710a70e
Merge pull request #5260 from 4ertus2/joins
Fix perf regression: do not add right join key to result if possible
2019-05-14 15:33:54 +03:00
chertus
ba202c2b06 fix whitespaces 2019-05-14 12:47:21 +03:00
Nikolai Kochetov
6165be54fc
Merge pull request #4943 from Quid37/master
Regression methods
2019-05-14 11:47:33 +03:00
chertus
20e7de7cce fix perf regression: do not add right join key to result if possible 2019-05-13 21:58:15 +03:00
Alexander Kozhikhov
003a0fbadf conflict fix 2019-05-13 17:43:47 +03:00
alesapin
5aec6dd011 Fix banch of flapping perf tests. Improve average speed calculation 2019-05-13 17:09:11 +03:00
Alexander Kozhikhov
9b4f322fd8 Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-13 16:50:56 +03:00
alexey-milovidov
9ce2dd8803
Merge pull request #5238 from janplus/if-nullable-bug
Fix if, multiIf's nullable bug.
2019-05-12 11:47:37 +03:00
alexey-milovidov
f7343ecb6f
Merge pull request #4639 from IvanKush/feat/parallel-alter-modify
feat alter:  parallelize processing of parts in alter modify
2019-05-12 00:39:46 +03:00