Nikolai Kochetov
333fd09dbf
Fixing build.
2022-05-24 19:29:00 +00:00
guyco87
ee33f95160
Merge branch 'master' into adjustable-query-block
2022-05-24 12:23:54 -04:00
guykohen
e8b329595e
Remove height restrictions from the query div in play web tool, and make sure width of the query box won't shrink below 100%.
2022-05-24 12:18:58 -04:00
Vitaly Baranov
497c70d786
Merge pull request #37269 from vitlibar/rework-access-control-notifications
...
Rework AccessControl's notifications.
2022-05-24 17:47:45 +02:00
Alexey Milovidov
fd7642b6aa
Fix "splitted" build
2022-05-24 06:04:48 +02:00
Alexey Milovidov
29e6a7ed8c
Keep controls in place when the page is scrolled horizontally
2022-05-24 04:11:32 +02:00
Alexey Milovidov
5b1bdfc353
Fix error
2022-05-24 02:02:18 +02:00
Alexey Milovidov
e8c08cda0d
Fix error in static-files-disk-uploader
2022-05-24 01:38:17 +02:00
Alexey Milovidov
ee0a8f3251
Fix exception messages
2022-05-24 01:37:17 +02:00
Dmitry Novik
e9187ec4b7
Overcommit: update defaults, exception message and add ProfileEvent
2022-05-23 14:35:09 +00:00
Alexey Milovidov
89c8d136c3
Fix error
2022-05-23 07:20:36 +02:00
Alexey Milovidov
03b118557c
Fix error
2022-05-23 03:52:44 +02:00
Alexey Milovidov
39d157b9fb
Fix error
2022-05-23 03:52:00 +02:00
Alexey Milovidov
b432ca93a1
Fix error
2022-05-23 03:11:12 +02:00
Alexey Milovidov
cc985d9b92
Fix error
2022-05-23 02:30:33 +02:00
Alexey Milovidov
2f93f11144
Maybe better
2022-05-23 02:03:13 +02:00
Alexey Milovidov
7ad8d48771
Merge branch 'master' into allow-setuid-inside-clickhouse
2022-05-23 01:09:08 +02:00
Vitaly Baranov
58f4a86ec7
Rework notifications used in access management.
2022-05-21 10:15:39 +02:00
Antonio Andelic
fc9beb2933
Merge branch 'master' into keeper-real-time-digest
2022-05-20 09:54:44 +00:00
Robert Schulze
b475fbc9a7
Merge pull request #37300 from ClickHouse/cmake-cleanup-pt3
...
Various cmake cleanups
2022-05-20 10:02:36 +02:00
Antonio Andelic
c133f815bd
Merge branch 'keeper-preprocess-operations' into keeper-real-time-digest
2022-05-20 07:57:47 +00:00
Sergei Trifonov
2450ab9079
Merge pull request #36686 from azat/disk-least-used
...
Implement least_used load balancing algorithm for disks inside volume
2022-05-20 09:16:07 +02:00
Alexey Milovidov
03e3be7b1a
Maybe fix error
2022-05-20 02:38:50 +02:00
Alexey Milovidov
d0d0807a10
Merge branch 'master' into allow-setuid-inside-clickhouse
2022-05-20 02:37:15 +02:00
Robert Schulze
c0d5705891
Merge pull request #37326 from ClickHouse/fix-marks-cache-size-cfg
...
Provide default value for mark_cache_size
2022-05-19 20:20:25 +02:00
Antonio Andelic
f5759e2d7e
Cache nodes latest state
2022-05-19 12:30:57 +00:00
Azat Khuzhin
ba26b3cf4c
Implement lead_used load balancing algorithm for disks inside volume
...
v2: rebase on top removed raid1
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-19 14:10:11 +03:00
Azat Khuzhin
456444eadb
Add storage_configuration example into config.xml
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-19 14:10:11 +03:00
Azat Khuzhin
29a8a00656
Add ability to pass QueryKind via clickhouse-client/local (useful for debugging)
...
v2: fix LocalConnection::sendQuery() for Suggest (comes w/o client_info) [1]
[1]: https://s3.amazonaws.com/clickhouse-test-reports/37290/7c85175963226ff78eec542efafcff4e650aa0f0/stateless_tests__ubsan__actions_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-19 07:19:27 +03:00
Robert Schulze
a2214760c6
Remove mark_cache_size from further files
...
- changed config.xml/yaml files used by CH's own internal tests which
are (hopefully) not sensitive to mark_cache_size being set or not
- further occurrences exist but changing them seems a bad idea (e.g.
because they are in customer-provided data)
2022-05-18 22:09:14 +02:00
Robert Schulze
8ca58cd5a5
Provide default value for mark_cache_size
...
I played around with my local config.xml file. The minimal working example is this:
<?xml version="1.0"?>
<clickhouse>
<mark_cache_size>5368709120</mark_cache_size>
<listen_host>localhost</listen_host>
<tcp_port>9000</tcp_port>
<users_config>users.xml</users_config>
<logger><console>true</console></logger>
</clickhouse>
Not specifying mark_cache_size made the server not start up:
2022.05.18 12:15:06.549078 [ 8728320 ] {} <Error> Application: Not found: mark_cache_size
Looking at ClickHouse's ca. 100 server configuration options +
sub-options, it seems that mark_cache_size is NOT special enough to
require explicit configuration but instead that the behavior was
unintended because no default value was provided.
2022-05-18 15:28:19 +02:00
Vitaly Baranov
f34a5cdee2
Merge branch 'master' into ON_CLUSTER-grant
2022-05-17 13:21:20 +02:00
Vitaly Baranov
23a61b1596
Merge pull request #36700 from azat/fix-server-reload
...
Fix server reload on port change (do not wait for current connections from query context)
2022-05-17 12:25:21 +02:00
Robert Schulze
43945cea1b
Fixing some warnings
2022-05-16 20:59:27 +02:00
Alexey Milovidov
434b8fbf14
Revert "Remove height restrictions from the query div in play web tool."
2022-05-16 19:20:30 +03:00
Azat Khuzhin
c8420c0dbe
Remove duplication for server connections check
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
e503f1f22c
Keep reloaded servers and currently active in one list
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
f15a5461be
Fix server reload on port change (do not wait for current connections)
...
If you will execute 'SYSTEM RELOAD CONFIG' via, i.e., TCP protocol, then
reload on port change will endlessly wait for connection from which this
query had been issued, and you will see the following message in the
logs:
2022.04.28 03:34:57.552513 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Debug> executeQuery: (from 127.0.0.1:11774) system reload config
...
2022.04.28 03:34:57.710640 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Information> Application: Stopped listening for http://127.0.0.1:18123
2022.04.28 03:34:57.798774 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Information> Application: Stopped listening for native protocol (tcp): 127.0.0.1:19000
...
2022.04.28 03:34:57.901375 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Debug> Application: Server finished: http://127.0.0.1:18123
2022.04.28 03:34:57.901455 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
2022.04.28 03:34:58.001717 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
2022.04.28 03:34:58.101881 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
...
2022.04.28 03:35:01.707951 [ 37101 ] {b41d855c-4dbf-470a-a144-c6ae5a1abda8} <Trace> Application: Waiting server to finish: native protocol (tcp): 127.0.0.1:19000
But waiting for the current connection will never ends.
So instead of waiting directly from the query context (SYSTEM RELOAD
CONFIG) do this in background (actually not even in background, but
check on server reload and on exit).
v0: just don't wait for the servers
v2: fix use-after-free by removing dependency from server in handlers
v3: wait servers in background to avoid use-after-free of the context
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 16:22:58 +03:00
Azat Khuzhin
01e1c5345a
Add separate CLUSTER grant
...
In case you have different roles for the same user on multiple clusters,
ON CLUSTER query can help to overcome some limitations.
Consider the following example:
- cluster_with_data, dev_user (readonly=2)
- stage_cluster, dev_user (readonly=0)
So when you will execute the following query from stage_cluster, it will
be successfully executed, since ON CLUSTER queries has different system
profile:
DROP DATABASE default ON CLUSTER cluster_with_data
This is not 100% safe, but at least something.
Note, that right now only ON CLUSTER query it self is supported, but
separate clusters are not (i.e. GRANT CLUSTER some_cluster_name TO
default), since right now grants sticked to database+.
v2: on_cluster_queries_require_cluster_grant
v3: fix test and process flags as bit mask
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-16 13:57:45 +03:00
Robert Schulze
e3cfec5b09
Merge remote-tracking branch 'origin/master' into clangtidies
2022-05-16 10:12:50 +02:00
Alexey Milovidov
7ce409da52
Merge branch 'master' into allow-setuid-inside-clickhouse
2022-05-15 04:33:59 +03:00
Azat Khuzhin
40f3dbb448
Ignore harmful env variables in clickhouse binaries (reexec w/o them)
...
Some environments may really require LD_LIBRARY_PATH (and some other
variables), so rejecting running clickhouse binaries in such envs is a
backward incompatible change.
So instead of rejecting, let's ignore those env variables, i.e. reexec
binaries without them.
Also note, that there is no messages in stderr in case of some of
variables set anymore, since this message may break some scripts.
Refs: #36340
Follow-up for: #36342
2022-05-14 12:08:48 +03:00
Azat Khuzhin
5086d8de29
Reload listen_reuse_port/listen_backlog from config
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-12 17:05:39 +03:00
Alexey Milovidov
7536e0cd25
Fix MSan
2022-05-11 03:16:10 +02:00
Alexey Milovidov
a8506f6604
Merge branch 'master' into allow-setuid-inside-clickhouse
2022-05-11 03:14:28 +02:00
kssenii
61f2737e17
Merge master
2022-05-10 19:31:22 +02:00
kssenii
0feda67ec4
Fix progress for insert select
2022-05-10 15:04:08 +02:00
Alexander Tokmakov
9346c9363a
Merge pull request #37052 from ClickHouse/fix_server_termination_stress_tests
...
Print stacks if we cannot terminate server in stress tests
2022-05-10 13:12:44 +03:00
Sergei Trifonov
9800d80a29
update sanity checks warning message text
2022-05-10 09:31:22 +02:00
Dmitry Novik
adcb792f0d
Merge pull request #35921 from ClickHouse/enable-memory-overcommit
...
Enable memory overcommit
2022-05-10 02:09:18 +02:00
Alexander Tokmakov
92d423c478
print stacks if wa cannot terminate server in stress tests
2022-05-09 19:43:51 +02:00
guykohen
34c494f403
Remove height restrictions from the query div in play web tool.
2022-05-09 13:32:26 -04:00
mergify[bot]
8ea87a3530
Merge branch 'master' into enable-memory-overcommit
2022-05-09 14:00:54 +00:00
Kruglov Pavel
23bd9390a6
Merge pull request #36997 from vitlibar/users-without-assigned-policies-can-view-rows
...
Users without assigned row policies can view rows
2022-05-09 12:04:50 +02:00
Robert Schulze
1b81bb49b4
Enable clang-tidy modernize-deprecated-headers & hicpp-deprecated-headers
...
Official docs:
Some headers from C library were deprecated in C++ and are no longer
welcome in C++ codebases. Some have no effect in C++. For more details
refer to the C++ 14 Standard [depr.c.headers] section. This check
replaces C standard library headers with their C++ alternatives and
removes redundant ones.
2022-05-09 08:23:33 +02:00
Vitaly Baranov
69bec2f377
Users without assigned row policies can view rows now.
2022-05-07 14:50:24 +02:00
Alexey Milovidov
a121155f0a
Fix conflict
2022-05-07 12:38:30 +02:00
Alexey Milovidov
1bdc51a496
Merge branch 'remind_for_external_option' of github.com:bigo-sg/ClickHouse into bigo-sg-remind_for_external_option
2022-05-07 12:36:57 +02:00
Alexey Milovidov
b2945766d0
Merge pull request #36988 from ClickHouse/handle-nullable-numbers-in-play-ui
...
Correct styling of Nullable numbers in PlayUI
2022-05-07 13:06:25 +03:00
Alexey Milovidov
c95f22e64d
Merge branch 'master' into allow-setuid-inside-clickhouse
2022-05-07 00:21:47 +03:00
Alexey Milovidov
a88e9b74a2
Correct styling of Nullable numbers in PlayUI
2022-05-06 21:50:28 +02:00
Alexey Milovidov
8b26c5fe02
Merge pull request #36838 from ClickHouse/config-update
...
Disable `merge_tree_metadata_cache` by default
2022-05-06 01:59:01 +03:00
Alexey Milovidov
1ba42076e5
Merge pull request #36778 from ClickHouse/init-thread-pools-local-server
...
Init thread pools for clickhouse-local
2022-05-06 01:52:55 +03:00
mergify[bot]
1a92a34514
Merge branch 'master' into enable-memory-overcommit
2022-05-02 17:04:08 +00:00
Alexey Milovidov
0b9f8d81e4
Add cool processing of empty resultsets
2022-05-02 03:48:48 +02:00
Alexey Milovidov
2f0c421d99
Update play.html
2022-05-02 04:24:40 +03:00
Alexey Milovidov
8b366cbb02
Update play.html
2022-05-02 04:23:52 +03:00
Alexey Milovidov
be7a4b8b30
Make it work automatically; unify the code
2022-05-02 03:19:57 +02:00
Alexey Milovidov
474a805ea7
Merge branch 'play-vertical-format' of github.com:vdimir/ClickHouse into vdimir-play
2022-05-02 02:44:09 +02:00
Nikita Mikhaylov
f2d73635ef
Disable
2022-05-01 17:14:52 +00:00
Alexey Milovidov
69ae22070f
Merge pull request #36824 from ClickHouse/log-test-sanity-check
...
Add sanity check for log level. Fix style.
2022-05-01 14:03:22 +03:00
Nikita Taranov
92f8244932
Fix certs (finishing pr #36457 ) ( #36747 )
2022-05-01 12:59:19 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone"
...
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"
About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.
About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.
Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
2022-04-30 19:40:28 +02:00
Alexey Milovidov
47988db1a5
Add sanity check for log level. Fix style.
2022-04-30 13:19:25 +02:00
Alexey Milovidov
e0b2365945
Merge pull request #36472 from ClickHouse/sanity-checks-message-fix
...
more specific warning text about low disk space
2022-04-30 09:44:21 +03:00
Alexey Milovidov
1ddb04b992
Merge pull request #36715 from amosbird/refactorbase
...
Reorganize source files so that base won't depend on Common
2022-04-30 09:40:58 +03:00
Alexey Milovidov
dc914c635c
Merge pull request #36497 from tonickkozlov/tonickkozlov/benchmark/allow-auth-env
...
Benchmark can read auth from environment variables
2022-04-30 08:55:15 +03:00
vdimir
ea4e9db3da
play.html: no header in transposed table
2022-04-29 20:05:03 +02:00
vdimir
277afd0c48
play.html: add button to transpose table
2022-04-29 20:01:24 +02:00
Nikolai Kochetov
5807ca47b0
Merge pull request #36425 from ClickHouse/pool-size-hot-reload
...
Allow to increase number of threads and tasks for background executors
2022-04-29 17:24:12 +02:00
Anton Kozlov
5cc78febde
[benchmark] Allow auth environment variables
2022-04-29 11:30:59 +00:00
Maksim Kita
5b9bb36f80
Merge pull request #36753 from kitaisreal/added-user-defined-path-config-setting
...
Added user_defined_path config setting
2022-04-29 11:10:51 +02:00
Antonio Andelic
45a72d9aa9
Init thread pools for clickhouse-local
2022-04-29 07:41:10 +00:00
Amos Bird
4a5e4274f0
base should not depend on Common
2022-04-29 10:26:35 +08:00
Alexey Milovidov
f200af5530
Merge pull request #36733 from ClickHouse/maven-clickhouse
...
Change Maven URL example for JDBC bridge in ClickHouse config
2022-04-29 00:12:53 +03:00
Maksim Kita
04429d85db
Added user_defined_path config setting
2022-04-28 22:13:33 +02:00
Vladimir C
d692dec635
Merge pull request #36473 from xinhuitian/fix-benchmark-json-report
...
Try to fix clickhouse-benchmark json report results
2022-04-28 14:50:10 +02:00
alesapin
8f1a0f6625
Merge pull request #36258 from ClickHouse/keeper-recovery-mode
...
clickhouse-keeper support for force recovery
2022-04-28 11:20:59 +02:00
Alexey Milovidov
770ce07b1a
Change Maven URL example for JDBC bridge in ClickHouse config
2022-04-28 05:54:39 +02:00
mergify[bot]
a13012e271
Merge branch 'master' into sanity-checks-message-fix
2022-04-28 02:50:16 +00:00
Antonio Andelic
cf022542bd
Merge branch 'master' into keeper-recovery-mode
2022-04-26 06:50:02 +00:00
Alexey Milovidov
39467ec4aa
Update play.html
2022-04-26 08:47:56 +03:00
mergify[bot]
7c32649014
Merge branch 'master' into cleanup-play-ui
2022-04-26 05:47:32 +00:00
mergify[bot]
74aa65e36e
Merge branch 'master' into sanity-checks-message-fix
2022-04-26 05:45:11 +00:00
Alexey Milovidov
c8db250c88
Merge pull request #36586 from azat/bash-complete-log-level
...
bash-completion: add completion for send_logs_level
2022-04-26 05:55:41 +03:00
mergify[bot]
9c3605712b
Merge branch 'master' into sanity-checks-message-fix
2022-04-25 17:37:55 +00:00
mergify[bot]
5bcba95e72
Merge branch 'master' into bash-complete-log-level
2022-04-25 17:36:43 +00:00
mergify[bot]
cc8513fb79
Merge branch 'master' into cleanup-play-ui
2022-04-25 17:15:08 +00:00
Azat Khuzhin
6df54611a9
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
(cherry picked from commit 2be022cb56
)
2022-04-25 07:56:54 +03:00
Alexey Milovidov
74bb6349c2
Revert "Strict taskstats parser"
2022-04-25 01:15:08 +03:00
mergify[bot]
989f7c76ab
Merge branch 'master' into cleanup-play-ui
2022-04-24 19:45:18 +00:00
Azat Khuzhin
fa657d1d7f
bash-completion: add completion for send_logs_level
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-24 22:36:27 +03:00
Alexey Milovidov
8af3159916
Merge pull request #36351 from azat/netlink-strict
...
Strict taskstats parser
2022-04-24 05:14:06 +03:00
Alexey Milovidov
a1eddd1be0
Cleanup CSS in Play UI
2022-04-23 20:42:10 +02:00
alesapin
f0f92341e0
Merge pull request #36492 from ClickHouse/fix-keeper-hostname-check
...
Fix hostname checks in clickhouse-keeper
2022-04-23 13:54:57 +02:00
alesapin
7380a71333
Merge pull request #31833 from ClickHouse/musl-check
...
Build clickhouse-keeper with Musl
2022-04-22 22:41:16 +02:00
mergify[bot]
eefc302779
Merge branch 'master' into fix-keeper-hostname-check
2022-04-22 14:07:53 +00:00
Nikita Mikhaylov
aaa7112405
Even better
2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
e475849761
Style and Docs update
2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
f95a63a7f0
Beautify
2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
36bdee0499
Deleted settings
2022-04-22 13:56:16 +00:00
Nikita Mikhaylov
31ccb9c1c3
Done
2022-04-22 13:56:16 +00:00
Tian Xinhui
164647cc05
Update programs/benchmark/Benchmark.cpp
...
Co-authored-by: Vladimir C <vdimir@clickhouse.com>
2022-04-22 18:31:07 +08:00
alesapin
f88f654798
Update programs/CMakeLists.txt
...
Co-authored-by: Mikhail f. Shiryaev <felixoid@clickhouse.com>
2022-04-22 11:30:35 +02:00
Antonio Andelic
4e389d8df1
Rename to hostname, add tests
2022-04-22 08:16:14 +00:00
Alexey Milovidov
143b67a790
Merge pull request #36397 from ClickHouse/changelog-22-4
...
Draft changelog for version 22.4
2022-04-22 04:37:03 +03:00
Alexey Milovidov
f31cad52ab
Preparation
2022-04-22 03:21:29 +02:00
Maksim Kita
57444fc7d3
Merge pull request #36444 from rschu1ze/clang-tidy-fixes
...
Clang tidy fixes
2022-04-21 16:11:27 +02:00
Antonio Andelic
6ac3784af7
Add config example
2022-04-21 13:49:36 +00:00
Antonio Andelic
03779fd463
Merge branch 'master' into keeper-recovery-mode
2022-04-21 12:34:18 +00:00
Mikhail f. Shiryaev
49a572e00c
Build only clickhouse-keeper with musl
2022-04-21 13:43:24 +02:00
xinhuitian
f261291fa6
fix benchmark json report info
2022-04-21 14:10:29 +08:00
Sergei Trifonov
cda9160c2f
fix build
2022-04-21 07:48:56 +02:00
Sergei Trifonov
69403840e2
add paths
2022-04-21 07:45:08 +02:00
Sergei Trifonov
a2365c5c83
more specific warning text about low disk space
2022-04-21 07:32:34 +02:00
Sergei Trifonov
2f38e7bc5c
Merge pull request #36400 from azat/dyn-linker-vars
...
Add more harmful variables for OSX
2022-04-21 00:02:51 +02:00
Azat Khuzhin
2be022cb56
Log which taskstats provider is in use
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
v2: add missing __builtin_unreachable() for gcc built [1]
[1]: https://s3.amazonaws.com/clickhouse-builds/36351/99e72a960325cc1fb3cd3d6a1b56cf2b1cc2d733/binary_gcc/build_log.log
2022-04-20 21:39:26 +03:00
alesapin
ba81816dc1
Better cmake
2022-04-20 12:11:55 +02:00
mergify[bot]
0df5fda6ed
Merge branch 'master' into musl-check
2022-04-20 09:28:40 +00:00
Suzy Wang
59f0e83c4b
fix clang tidy warning, add nullptr check ( #35540 )
...
update passing reference instead of pointer in queryHasWithClause based on recommandation
Co-authored-by: larryluogit <larry.luo@ca.ibm.com>
2022-04-20 11:26:44 +02:00
Robert Schulze
b24ca8de52
Fix various clang-tidy warnings
...
When I tried to add cool new clang-tidy 14 warnings, I noticed that the
current clang-tidy settings already produce a ton of warnings. This
commit addresses many of these. Almost all of them were non-critical,
i.e. C vs. C++ style casts.
2022-04-20 10:29:05 +02:00
Antonio Andelic
bbb0be6a44
Merge pull request #36402 from rschu1ze/clang-tidy-contains
...
Activate clang-tidy warning "readability-container-contains"
2022-04-20 08:15:46 +02:00
alesapin
ffca5c3cdc
Merge branch 'master' into musl-check
2022-04-19 17:51:54 +02:00
alesapin
44e5c55d19
Fix build
2022-04-19 17:44:28 +02:00
Alexey Milovidov
fb9545e0b4
Remove trash
2022-04-19 17:44:27 +02:00
Alexey Milovidov
23968142c1
Update main.cpp
2022-04-19 17:44:27 +02:00
Alexey Milovidov
d6d0e82741
Update main.cpp
2022-04-19 17:44:26 +02:00
Alexey Milovidov
86ae0c9763
Warn and exit if harmful environment variables are set
2022-04-19 17:44:26 +02:00
Antonio Andelic
70f3d3a863
Merge branch 'master' into keeper-recovery-mode
2022-04-19 12:32:48 +00:00
Antonio Andelic
3e77340a81
Allow clickhouse-keeper to serve 4-letter commands before quorum ( #35992 )
...
* Use async start for clichkouse-keeper
* Return non active server for 4lw commands if quorum not achieved
2022-04-19 14:03:00 +02:00
Antonio Andelic
cd548aeb30
Refactor test for multiple cluster size
2022-04-19 08:08:36 +00:00
Antonio Andelic
6c3bf0a5d3
Format files
2022-04-19 08:08:36 +00:00
Antonio Andelic
0e1ba927bd
Add argument for force recovery
2022-04-19 08:08:35 +00:00
Robert Schulze
118e94523c
Activate clang-tidy warning "readability-container-contains"
...
This check suggests replacing <Container>.count() by
<Container>.contains() which is more speaking and in case of
multimaps/multisets also faster.
2022-04-18 23:53:11 +02:00
Azat Khuzhin
828d23c933
Add more harmful variables for OSX
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-04-18 23:40:09 +03:00
Alexey Milovidov
88f98443bd
Merge branch 'master' into allow-setuid-inside-clickhouse
2022-04-18 07:06:02 +03:00
Alexey Milovidov
48fd09c7db
Merge pull request #36310 from ClickHouse/cpuid-remove-trash
...
Remove trash from CPUID
2022-04-18 07:01:23 +03:00
Alexey Milovidov
543e5d7242
Merge branch 'master' into musl-check
2022-04-18 02:40:13 +02:00
Alexey Milovidov
0fc61ea445
Update main.cpp
2022-04-18 03:16:30 +03:00
Alexey Milovidov
27afc08d8f
Merge branch 'master' into cpuid-remove-trash
2022-04-17 16:30:30 +02:00