thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-09-29 21:20:49 +00:00
Code Issues Packages Projects Releases Wiki Activity
75,943 Commits 8,956 Branches 1,767 Tags 1.8 GiB
5fe4bcd22e
Commit Graph

19370 Commits

Author SHA1 Message Date
Azat Khuzhin
fbf98bea0b Fix "Column is not under aggregate function and not in GROUP BY" with PREWHERE 
In 21.7 the function column type is unknown:

  (lldb) p tmp_actions_dag->dumpDAG()
  (std::string) $14 = "0 : INPUT () (no column) Int32 key\n1 : COLUMN () Const(UInt8) UInt8 1\n2 : FUNCTION (0) (no column) UInt8 ignore(key) [ignore]\n3 : FUNCTION (1, 2) (no column) UInt8 or(1, ignore(key)) [or]\nIndex: 0 1 2 3\n"
                                                                                                                                                                            ^^^^^^^^^^^

While in 21.8+ it is const:

  (lldb) p tmp_actions_dag->dumpDAG()
  (std::string) $22 = "0 : INPUT () (no column) Int32 key\n1 : COLUMN () Const(UInt8) UInt8 1\n2 : FUNCTION (0) (no column) UInt8 ignore(key) [ignore]\n3 : FUNCTION (1, 2) Const(UInt8) UInt8 or(1, ignore(key)) [or]\nIndex: 0 1 2 3\n"
                                                                                                                                                                            ^^^^^

This is after getRootActions() in SelectQueryExpressionAnalyzer::appendPrewhere()

v1: fix for SELECT only, but breaks virtual columns
v2: hacky fix, that also touches MergeTree code
v3: allow_remove_inputs=false
v4: allow_constant_folding=false instead
 2021-10-26 22:57:48 +03:00
Azat Khuzhin
dd7bffcaf9 ActionsDAG: add allow_constant_folding flag for removeUnusedActions() 2021-10-26 22:56:44 +03:00
Azat Khuzhin
248b689067 ActionsDag: add allow_remove_inputs for other variants of removeUnusedActions() 2021-10-26 22:56:44 +03:00
jasperzhu
fb31410926 change to inline for bitmask generator 2021-10-27 00:05:47 +05:30
Nikita Mikhaylov
aae30a9e37
Fix fuzzer build (#30344) 2021-10-26 20:30:34 +03:00
Nikolai Kochetov
403ff98baa
Revert "Improve usability of remote_url_allow_hosts" 2021-10-26 20:15:29 +03:00
jasperzhu
1caff8a81c fixed compile error 2021-10-26 22:12:21 +05:30
凌涛
d4d97d7b9a add new function mapContainsKeyLike 
fixed error because of inconsistent offsets
 2021-10-27 00:06:01 +08:00
Dmitry Novik
e971871a95
Merge pull request #30668 from azat/prewhere-always-true-where 
Fix PREWHERE with WHERE in case of always true PREWHERE
 2021-10-26 17:18:50 +03:00
Alexander Tokmakov
6be1e98342 fix 2021-10-26 17:06:48 +03:00
Maksim Kita
b58f819789
Merge pull request #30667 from kitaisreal/compiled-expression-cache-limit-elements-size 
CompiledExpressionCache limit elements size
 2021-10-26 16:43:49 +03:00
Nikolai Kochetov
b549bddc11
Merge pull request #29735 from ClickHouse/fix-backward-compatibility-after-21196 
Fix backward compatibility after #21196.
 2021-10-26 16:31:40 +03:00
Nikolai Kochetov
36c3b1d5b1
Merge pull request #30639 from ClickHouse/fix-30545 
Fix argument types for now and now64
 2021-10-26 16:29:18 +03:00
alexey-milovidov
329437abca
Merge pull request #30674 from ClickHouse/fix-indecency 
Fix indecency #30337
 2021-10-26 14:24:18 +03:00
mergify[bot]
ce88a84e88
Merge branch 'master' into nv/parts-uuid-move-shard-kill 2021-10-26 11:09:19 +00:00
alesapin
a679ece0fb Merge branch 'master' into fix_intersecting_parts_to_do 2021-10-26 14:02:05 +03:00
Alexander Tokmakov
2e7e195e77 change alter_lock to std::timed_mutex 2021-10-26 13:37:00 +03:00
Alexander Tokmakov
a1cab43feb fix five years old bug in StingSearcher 2021-10-26 13:32:07 +03:00
Maksim Kita
dbf4811029 Updated documentation 2021-10-26 13:00:42 +03:00
Maksim Kita
6cf16862ab Fixed style check 2021-10-26 12:57:49 +03:00
Maksim Kita
73bbf7549a HashedArrayDictionary optimize read multiple attributes 2021-10-26 12:57:49 +03:00
Alexey Milovidov
da3e13b730 Fix indecency #30337 2021-10-26 10:00:19 +03:00
Alexey Milovidov
97bcceca44 Improve usability of remote_url_allow_hosts 2021-10-26 09:49:12 +03:00
alexey-milovidov
5434f1d149
Merge pull request #30337 from ClickHouse/fix-memory-indication 
Fix consumed memory indication in clickhouse-client
 2021-10-26 09:48:03 +03:00
alexey-milovidov
e7751c59f6
Merge pull request #30456 from CurtizJ/async-inserts-values 
Support VALUES format in async inserts
 2021-10-26 09:47:27 +03:00
alexey-milovidov
e528bfdb1a
Merge pull request #30565 from ClickHouse/try-to-fix-30397 
Try to fix #30397
 2021-10-26 09:45:45 +03:00
jasperzhu
911b9c3973 Improve function defect 2021-10-26 06:02:57 +05:30
Azat Khuzhin
16cd70aee9 Fix PREWHERE with WHERE in case of always true PREWHERE 2021-10-26 00:02:41 +03:00
Maksim Kita
3810baf44c CompiledExpressionCache limit elements size 2021-10-26 00:00:57 +03:00
jasperzhu
3d115536f5 Improve filter bitmask generator function all in one with sse/avx2/avx512 2021-10-26 01:39:09 +05:30
Azat Khuzhin
f41cf281e4 Add QueryProfilerRuns profile event 
This will help to investigate query latency spikes.
 2021-10-25 21:14:16 +03:00
mergify[bot]
70097b5c4e
Merge branch 'master' into fix_intersecting_parts_to_do 2021-10-25 17:21:25 +00:00
Alexander Tokmakov
5cdd9a4b99 fix intersecting parts in parts_to_do 2021-10-25 19:00:55 +03:00
Alexander Tokmakov
94088f8197 minor fixes 2021-10-25 17:01:36 +03:00
Dmitry Novik
8e680b068a Add comment with fix explanation 2021-10-25 16:53:23 +03:00
Kseniia Sumarokova
377b937aa5
Merge pull request #30244 from evillique/fix_like_function 
Fix `LIKE` function
 2021-10-25 16:35:37 +03:00
Anton Popov
b87c819c10
Merge pull request #30566 from nickitat/nickitat_nullable_4_arrayStringConcat 
Support Nullable(String) type in arrayStringConcat
 2021-10-25 16:04:20 +03:00
Maksim Kita
772c326f2d
Merge pull request #30500 from kitaisreal/dictionaries-read-multiple-threads 
Dictionaries read support multiple threads
 2021-10-25 15:31:50 +03:00
Alexander Tokmakov
075c3a37f4 Merge branch 'master' into fix_some_fetches_may_stuck 2021-10-25 15:28:54 +03:00
Nikolai Kochetov
a0a5c1a21d Fix argument types for now and now64 2021-10-25 12:06:53 +03:00
alesapin
28bde879ed
Merge pull request #30455 from kssenii/deprecate-setting 
Deprecate write_final_mark setting
 2021-10-25 10:51:49 +03:00
alesapin
490ca93162
Merge pull request #30372 from ClickHouse/update_keeper_config 
Updatable keeper configuration.
 2021-10-25 10:37:03 +03:00
alesapin
aca3166a7c
Merge pull request #30550 from ClickHouse/fix_typo_update_nuraft 
Fix typo and update NuRaft
 2021-10-25 10:36:06 +03:00
kssenii
52296e8b04 Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-25 00:22:32 +03:00
alexey-milovidov
7200cb8bba
Merge pull request #30611 from azat/readbuffer-real-size 
Replace estimated_size with optional<size> for readFile/createReadBufferFromFileBase
 2021-10-24 23:37:30 +03:00
kssenii
13a2a3d307 Merge branch 'master' of github.com:ClickHouse/ClickHouse into deprecate-setting 2021-10-24 23:05:21 +03:00
Anton Popov
37de54937c fix use-after-free 2021-10-24 22:32:28 +03:00
Anton Popov
76cb191865
Merge pull request #30433 from kssenii/fix-positional 
More full support of positional arguments
 2021-10-24 21:48:17 +03:00
kssenii
658b33717f A little nicer 2021-10-24 20:43:34 +03:00
kssenii
5b15e2474c Checkout reading from local fs back to master version 2021-10-24 20:41:18 +03:00
Kruglov Pavel
855b10261c
Merge pull request #30285 from kssenii/fix-local-exceptions 
Fix printing stacktraces for clickhouse-local
 2021-10-24 19:54:59 +03:00
Kseniia Sumarokova
4667ea7883
Merge pull request #29774 from kssenii/remote-connection 
Predefined configuration for table function remote
 2021-10-24 19:38:01 +03:00
Azat Khuzhin
f9b27608f5 Fix reading of columns if offset_in_compressed_file is the same for mark range 
Fixes: 00078_group_by_arrays
 2021-10-24 18:58:22 +03:00
Azat Khuzhin
258b62d375 Remove one unused CompressedReadBufferFromFile ctor 2021-10-24 18:58:22 +03:00
Azat Khuzhin
34d8f78c33 Explictly pass size in DiskCacheWrapper::writeFile() 
v0: Add explicit default value for DiskLocal::readFile()
v2: Explictly pass size in DiskCacheWrapper::writeFile()
    (since v0 not google-default-arguments compatible)
 2021-10-24 18:58:22 +03:00
Azat Khuzhin
93c34824c0 Fix explicit 0 size for createReadBufferFromFileBase() 2021-10-24 18:58:22 +03:00
Azat Khuzhin
4599e9191b Fix explicit 0 size for readFile() 2021-10-24 18:58:22 +03:00
Azat Khuzhin
2b96433daf Replace estimated_size with optional<size> for IDisk::readFile() 
v2: rebase to fix conflicts in DiskEncrypted.cpp
 2021-10-24 18:58:11 +03:00
Vitaly Baranov
c0b01e7b0b
Merge pull request #30494 from vitlibar/fix-reading-from-empty-file-on-encrypted-disk 
Fix reading from empty file on encrypted disk
 2021-10-24 16:24:47 +03:00
Nickita Taranov
877e8b579b fix style 2021-10-24 14:45:12 +03:00
Kseniia Sumarokova
7383bdd5fa
Merge pull request #25969 from ucasfl/filelog-engine 
Implementation of a table engine to consume application log files in ClickHouse
 2021-10-24 10:14:05 +03:00
alexey-milovidov
f1e96ee9ac
Merge pull request #30594 from azat/fix-logical-error-on-connection-drain 
Fix LOGICAL_ERROR on connection draining in case of ECONNRESET
 2021-10-24 05:34:27 +03:00
alexey-milovidov
830b83218e
Merge pull request #30579 from azat/tsan-recursion 
Fix tests that relies on checking stack size under TSan
 2021-10-24 03:14:07 +03:00
alexey-milovidov
8c2413f6fe
Merge pull request #30562 from ClickHouse/fix-header-after-limit-push-down 
Fix LimitStep header after limit push down optimization.
 2021-10-24 00:19:02 +03:00
Azat Khuzhin
83d68246c3 Fix LOGICAL_ERROR on connection draining in case of ECONNRESET 
In case of ECONNRESET (Connection reset by peer) the "cancelled" will
not be set, and so drain() will fail with LOGICAL_ERROR:

<details>

    2021.10.16 04:10:55.054771 [ 7635 ] {882164e0-ca26-4955-8759-708ba1f6e85c} <Error> PullingAsyncPipelineExecutor: Code: 210. DB::NetException: Connection reset by peer, while writing to socket (127.0.0.2:9000). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):

    ...
    4. ./obj-x86_64-linux-gnu/../src/Common/NetException.h:12: DB::NetException::NetException(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, int) @ 0x20db5749 in /usr/bin/clickhouse
    5. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:56: DB::WriteBufferFromPocoSocket::nextImpl() @ 0x211d56bb in /usr/bin/clickhouse
    6. ./obj-x86_64-linux-gnu/../src/IO/WriteBuffer.h:47: DB::WriteBuffer::next() @ 0x14e4c874 in /usr/bin/clickhouse
    7. ./obj-x86_64-linux-gnu/../src/Client/Connection.cpp:560: DB::Connection::sendCancel() @ 0x227c0c22 in /usr/bin/clickhouse
    8. ./obj-x86_64-linux-gnu/../src/Client/HedgedConnections.cpp:242: DB::HedgedConnections::sendCancel() @ 0x227f1b53 in /usr/bin/clickhouse
    ...
    2021.10.16 04:12:35.555530 [ 5575 ] {} <Fatal> : Logical error: 'Cannot drain connections: cancel first.'.

</details>

Found by stress tests on CI [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/d3cb99701d4aaec384fd183168d10e0f650ecc1d/stress_test_(debug).html#fail1
 2021-10-23 22:44:32 +03:00
Vitaly Baranov
26cb62de32 Add more tests for the "encrypted" disk type. 2021-10-23 20:58:37 +03:00
Kseniia Sumarokova
00d0665bf2
Merge pull request #30477 from kssenii/postgres-fix-query 
More reliable fetch query in postgres database
 2021-10-23 19:07:34 +03:00
kssenii
e04e37916e Review fixes 2021-10-23 18:20:31 +03:00
Anton Popov
cdfa36a181
Merge pull request #30266 from CurtizJ/aggregation-in-order-4 
Improve performance of aggregation in order of primary key
 2021-10-23 18:09:17 +03:00
kssenii
36d0f67b38 Merge branch 'master' of github.com:ClickHouse/ClickHouse into remote-connection 2021-10-23 17:12:46 +03:00
Maksim Kita
4ccc619bd5 Added performance tests 2021-10-23 15:01:30 +03:00
Azat Khuzhin
b73092c169 Fix tests that relies on checking stack size under TSan 
Under TSan using too much stack requires too much RSS for shadow memory,
and neither of this TSAN_OPTIONS helps:
- history_size=2
- flush_memory_ms=2000
- memory_limit_mb=50000

So instead, decrease allowed limit of the stack size in checkStackSize()
under TSan, to address exessive memory usage for the server compiled
with TSan.

Note, that before this patch 01763_max_distributed_depth test can
increase RSS of the server to 70GiB.
 2021-10-23 14:09:19 +03:00
feng lv
235339d530 fix 2021-10-23 09:35:33 +00:00
Kseniia Sumarokova
05150f151c
Update ExpressionAnalyzer.cpp 2021-10-23 12:19:40 +03:00
Vladimir C
410624749e
Merge pull request #30492 from vdimir/fix-alter-scalar-deadlock 2021-10-23 12:01:00 +03:00
Kseniia Sumarokova
f362d420b8
Update fetchPostgreSQLTableStructure.cpp 2021-10-23 11:38:18 +03:00
kssenii
1fa123ee5c Properly done 2021-10-23 01:33:17 +03:00
Anton Popov
74cf57b4b0 fix for empty chunks 2021-10-22 21:48:03 +03:00
Nikolai Kochetov
ee6bc3883f Try to fix 30397 2021-10-22 19:25:48 +03:00
Nickita Taranov
2d23e3b17d support for ColumnString 2021-10-22 18:53:02 +03:00
Nickita Taranov
a211c9ecbc support nullable for ColumnConst 2021-10-22 18:52:59 +03:00
Anton Popov
7c458fbc4c fix style check 2021-10-22 18:04:11 +03:00
Nikolai Kochetov
e00d55c08d Try to fix 30397 2021-10-22 17:42:20 +03:00
Kseniia Sumarokova
153dd9a895
Update MergeTreeSettings.h 2021-10-22 16:27:01 +03:00
Nikolai Kochetov
54cc8e1d27 Fix LimitStep header after limit push down optimization. 2021-10-22 16:19:49 +03:00
kssenii
39b9e9c258 Merge branch 'master' of github.com:ClickHouse/ClickHouse into disk-async-read 2021-10-22 15:40:41 +03:00
kssenii
a1a2e276ae Review fixes 2021-10-22 12:26:28 +00:00
Filatenkov Artur
1c72421e53
Add columns in columns.sql for INFORMATION_SCHEMA (#29637) 
* add columns in columns.sql for INFORMATION_SCHEMA
 2021-10-22 15:18:16 +03:00
Kseniia Sumarokova
5a60d9a3a3
Merge pull request #30521 from azat/local-fix 
clickhouse-local: fix block lost in interactive mode
 2021-10-22 14:49:39 +03:00
Maksim Kita
3a6f55607d Fixed IPAddressDictionary tests 2021-10-22 14:18:45 +03:00
Maksim Kita
243be5028a
Merge pull request #30014 from jinjunzh/master 
add x86 feature avx2/avx512 support for accelerating filter operation
 2021-10-22 14:16:47 +03:00
Anton Popov
151daf61c1
Merge pull request #30522 from azat/remove-check_columns 
Remove check_columns argument from MergeTree code (false was never passed)
 2021-10-22 14:06:49 +03:00
Maksim Kita
fc8a515b42
Merge pull request #30431 from vesslanjin/remove-branchy-code-in-ColumnDecimal 
remove branch in ColumnDecimal, same as pull req #29881
 2021-10-22 13:24:44 +03:00
Kseniia Sumarokova
057fe51ec8
Update TableFunctionPostgreSQL.cpp 2021-10-22 13:08:38 +03:00
kssenii
c95a29edac Fix quoting 2021-10-22 10:07:23 +00:00
vdimir
cfb98d381c
Do not use default scalars in MutationsInterpreter::prepareInterpreterSelectQuery 2021-10-22 12:47:28 +03:00
Nikolai Kochetov
1533f4af57
Merge pull request #30335 from ClickHouse/single-sorting-step 
Single sorting step
 2021-10-22 11:34:29 +03:00
Vladimir C
d60f00bab8
Merge pull request #30520 from azat/fix-unary-postfix-rewrite 2021-10-22 11:31:36 +03:00
alesapin
d849f56cd4 Fix typo and update NuRaft 2021-10-22 11:24:18 +03:00
Maksim Kita
6561f9bed2
Merge pull request #30483 from kitaisreal/sql-user-defined-functions-composition-fix 
SQLUserDefinedFunctions composition fix
 2021-10-22 10:16:31 +03:00