Commit Graph

119498 Commits

Author SHA1 Message Date
Dmitry Novik
5c73a0b19c
Merge pull request #50926 from ClickHouse/analyzer-integration-tests
Add integration test check with enabled analyzer
2023-07-13 10:59:39 +02:00
robot-clickhouse
8916e7d69b Update version_date.tsv and changelogs after v23.3.8.21-lts 2023-07-13 08:49:48 +00:00
Han Fei
f3684f78b7
Merge pull request #51720 from arenadata/ADQM-970
Added a crash log flush to the disk after the unexpected crash.
2023-07-13 10:49:07 +02:00
robot-ch-test-poll2
9df928eb13
Merge pull request #52028 from nicelulu/master
Update CompletedPipelineExecutor exception log name
2023-07-13 00:18:09 +02:00
Alexey Milovidov
58877d796a
Merge pull request #52061 from ClickHouse/auto/v23.4.6.25-stable
Update version_date.tsv and changelogs after v23.4.6.25-stable
2023-07-13 01:15:01 +03:00
pufit
1f05e6b99f
Merge pull request #51359 from azat/keeper-client-fix-parser
Improve parsing of path in clickhouse-keeper-client
2023-07-12 12:23:25 -04:00
Lars Eidnes
d891c4c9a2 MaterializedMySQL: Delay disconnection of mysqlxx::Pool::Entry until refcount==0
If Entry::disconnect() is called, it is removed from its pool
and underlying mysqlxx::Connection is disconnected.

Since Entry objects are copyable and some of them could be alive when disconnect() is called
which would lead to undefined behavior.

Suggesting to disconnect it when the last object is being destroyed.
2023-07-12 15:22:19 +02:00
Yatsishin Ilya
2ee7a9846f fix 2023-07-12 12:47:24 +00:00
robot-clickhouse
798f31a612 Update version_date.tsv and changelogs after v23.4.6.25-stable 2023-07-12 12:36:57 +00:00
Yatsishin Ilya
31806d0b6c no style 2023-07-12 11:14:49 +00:00
Raúl Marín
09a6472874
Merge branch 'master' into async_to_query_log 2023-07-12 12:26:47 +02:00
Yatsishin Ilya
3bd9c57a8c allow to ignore CREATE INDEX query for better SQL syntax compatibility 2023-07-12 09:29:36 +00:00
robot-clickhouse
881a45ec83 Automatic style fix 2023-07-12 09:26:01 +00:00
Dmitry Novik
b4723ca8df Try to fix report 2023-07-12 09:16:13 +00:00
Dmitry Novik
8133a5960e Update tests/analyzer_integration_broken_tests.txt 2023-07-12 08:51:24 +00:00
robot-ch-test-poll3
484bf00c06
Merge pull request #52036 from ZhiguoZh/20230711-ontime-get128-inline
Inline SipHash::get128(char *)
2023-07-12 07:20:01 +02:00
robot-clickhouse-ci-2
6c0eed47eb
Merge pull request #52039 from johnspurlock/patch-1
Fix a few typos in docker readme.
2023-07-12 06:37:57 +02:00
Amos Bird
52246ab5b5
Ignore setting constraints for projection ASTs 2023-07-12 10:34:36 +08:00
pufit
e87e3f8678
Merge branch 'master' into keeper-client-fix-parser 2023-07-11 20:13:51 -04:00
pufit
12432ac582
Merge pull request #51290 from arenadata/Fix-formatDateTime-with-fractional-negative-datetime64
Fix formatDateTime() with fractional negative datetime64
2023-07-11 19:55:49 -04:00
robot-ch-test-poll3
ea7ff2f37e
Merge pull request #51723 from arenadata/ADQM-956
Added ASK_PASSWORD client constant instead of hardcoded '\n'
2023-07-12 00:37:59 +02:00
robot-ch-test-poll4
139f59f51f
Merge pull request #52038 from azat/s3-plain-send_metadata
Prohibit send_metadata for s3_plain disks
2023-07-12 00:37:50 +02:00
Dan Roscigno
7756620f15
Merge branch 'master' into docs-organize-user-profiles 2023-07-11 17:59:48 -04:00
DanRoscigno
46fd88dca4 add session setting 2023-07-11 17:50:52 -04:00
Alexey Milovidov
ea15825494
Merge pull request #51357 from ClickHouse/add-test-34626
Add a test for #34626
2023-07-12 00:47:07 +03:00
Alexey Gerasimchuck
7b4e7cd203
Merge branch 'master' into ADQM-970 2023-07-12 07:44:54 +10:00
robot-clickhouse-ci-1
1eef5086d4
Merge pull request #52030 from myrrc/feature/auto-reload-tls-certs
Watch for certificate files updates in ConfigReloader
2023-07-11 23:41:19 +02:00
Nikolai Kochetov
62b4b448da
Merge pull request #51954 from ClickHouse/vdimir/fix_race_in_remove_objects
Check refcount in `RemoveManyObjectStorageOperation::finalize` instead of `execute`
2023-07-11 23:17:50 +02:00
DanRoscigno
6086787957 add overview 2023-07-11 16:59:16 -04:00
Dmitry Kardymon
fdcf434b43 Merge remote-tracking branch 'origin/master' into ADQM-974 2023-07-11 19:57:43 +00:00
Dmitry Kardymon
2a7bbf5d48 Merge remote-tracking branch 'origin/master' into Fix-formatDateTime-with-fractional-negative-datetime64 2023-07-11 19:56:22 +00:00
HarryLeeIBM
1b403ab3e6 Fix crc32(WeakHash) issue for s390x 2023-07-11 14:15:33 -04:00
John Spurlock
7c7a447fd2
Fix a few typos in docker readme. 2023-07-11 12:16:55 -05:00
Azat Khuzhin
326d51c3fb Prohibit send_metadata for s3_plain disks
send_metadata changes the filenames (includes revision), while
s3_plain do not care about this, and expect that the file name
will not be changed.

So during initialization s3_plain will do some basic checks and will
write file clickhouse_access_check_e0f72fcc-d6f8-44fe-8997-96cb87767515, but instead
r0000000000000000000000000000000000000000000000000000000000000001-file-clickhouse_access_check_e0f72fcc-d6f8-44fe-8997-96cb87767515
will be written, later read will not find the file and it will fail:

    Application: Code: 33. DB::Exception: Cannot read all data. Bytes read: 0. Bytes expected: 4.: While checking access for disk s3_plain: Cannot attach table `system`.`crash_log` ...

And besides, send_metadata does not make sense for s3_plain.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-11 18:34:23 +02:00
Dmitry Kardymon
2eccead2d4 Fix const(Nullable) case, add test 2023-07-11 16:27:28 +00:00
Zhiguo Zhou
b0fb96c8b6 Inline SipHash::get128(char *)
The SipHash-128 values of the strings are calculated and stored in
a set when the UniqExact aggregate function is applied to a Column-
String, as the following snippet shows:

StringRef value = column.getDataAt(row_num);
UInt128 key;
SipHash hash;
hash.update(value.data, value.size);
hash.get128(key);

The implementation of SipHash requires an internal 8-byte buffer,
current_word (or current_bytes), for holding the input data in the
cross function calls of SipHash::update and SipHash::get128. But,
in the above situation, where the update and get128 only take place
once, the copy of input data to the buffer is unnecessary.

With get128 inlined, the compiler could optimize the code as a whole
and reduce the unexpected memory operations, and as a result, the
query performance is improved.
2023-07-11 23:17:55 +08:00
Mike Kot
d0f81fb1cd fix 2023-07-11 13:33:07 +00:00
Amos Bird
a33b90c648
Projection & optimize_group_by_function_keys 2023-07-11 21:11:28 +08:00
Amos Bird
1739bb306a
Projection & optimize_aggregators_of_group_by_keys
Fix projection with optimize_aggregators_of_group_by_keys = true
2023-07-11 21:11:27 +08:00
Yarik Briukhovetskyi
9afafa9554
Merge branch 'master' into add-index-bytes-to-system-parts 2023-07-11 14:51:46 +02:00
Mike Kot
da3de04470 fix 2023-07-11 12:27:23 +00:00
Alexey Gerasimchuck
49c1beb870
Used timeout function instead of undefined clickhouse_client_loop_timeout in functional tests (#51923)
* removed undefined clickhouse_client_loop_timeout

* test fix and improvement

* Changes after review iteration
2023-07-11 15:25:30 +03:00
Mike Kot
3e8906e5a2 fix build for non-ssl systems 2023-07-11 12:23:10 +00:00
Mike Kot
471e5a056d fix 2023-07-11 10:40:55 +00:00
Alexander Gololobov
9757e272b9 Check number of rows in the reader instead 2023-07-11 12:24:16 +02:00
Alexander Gololobov
6d712f595a Make sure that remote query has non-zero columns 2023-07-11 12:24:16 +02:00
Mike Kot
23e3c57a6a reload certificates for Keeper 2023-07-11 10:13:30 +00:00
Mike Kot
062b1c464c watch for certificate file updates in configreloader 2023-07-11 10:04:43 +00:00
Ilya Yatsishin
627e924a1b
Merge pull request #51696 from CheSema/write-to-finalized
fix write to finalized buffer
2023-07-11 11:48:49 +02:00
Nikolai Kochetov
ab6356f9bc
Merge branch 'master' into vdimir/fix_race_in_remove_objects 2023-07-11 11:22:04 +02:00