Commit Graph

126955 Commits

Author SHA1 Message Date
Mikhail f. Shiryaev
f96bda1deb
Merge pull request #55476 from ClickHouse/ci_scripts_tuning
Integration  check script fix ups
2023-10-16 17:06:19 +02:00
Max Kainov
4d1edc2780 return back unidiff module 2023-10-16 15:00:13 +00:00
Igor Nikonov
6abd1a6462
Merge branch 'master' into zk-retry-fix 2023-10-16 16:56:07 +02:00
Azat Khuzhin
0b2003cf27 Suppress data-race in rd_kafka_broker_set_nodename
Refs: https://github.com/ClickHouse/ClickHouse/issues/55629
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 16:12:21 +02:00
Azat Khuzhin
b0fbd79808 Fix test_system_merges after optimization for "x OR 1" conditions
After the previous patch "x OR 1" will not execute "x", and because of
this test_system_merges::test_mutation_simple started to fail since
"sleep" function did not executed.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-16 15:57:34 +02:00
Azat Khuzhin
96f2a46a66 Fix filtering by virtual columns with OR filter in query
The problem with the initial implementation #52653 was:
- OR can have multiple arguments
- It simply not correct to assume that if there are two arguments this is OK.
  Consider the following example:

    "WHERE (column_not_from_partition_by = 1) OR false OR false"

  Will be converted to:

    "WHERE false OR false"

And it will simply read nothing.

Yes, we could apply some optimization for bool, but this will not always
work, since to optimize things like "0 = 1" we need to execute it.

And the only way to make handle this correctly (with ability to ignore
some commands during filtering) is to make is_constant() function return
has it use something from the input block, so that we can be sure, that
we have some sensible, and not just "false".

Plus we cannot simply ignore the difference of the input and output
arguments of handling OR, we need to add always-true (1/true) if the
size is different, since otherwise it could break invariants (see
comment in the code).

This includes (but not limited to):
- _part* filtering for MergeTree
- _path/_file for various File/HDFS/... engines
- _table for Merge
- ...

P.S. analyzer does not have this bug, since it execute expression as
whole, and this is what filterBlockWithQuery() should do actually
instead, but this will be a more complex patch.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
(cherry picked from commit b107712e0c)
2023-10-16 15:42:10 +02:00
Raúl Marín
f799f5d7a1 Merge remote-tracking branch 'blessed/master' into parallel_replicas_row_estimation 2023-10-16 15:07:11 +02:00
Raúl Marín
51837eff33 Enable test_query_is_lock_free[detach table] for the analyzer 2023-10-16 12:49:17 +00:00
János Benjamin Antal
eeff98f3a3
Merge pull request #55373 from lingtaolf/enhancement/rename_without_keyword
Support rename table without keyword TABLE
2023-10-16 14:06:23 +02:00
alesapin
9a925a0802 Fix typo 2023-10-16 13:35:20 +02:00
Raúl Marín
478f635d60
Merge pull request #53792 from ClickHouse/revert-53782-revert-52762-planner-prepare-filters-for-analysis
Revert "Revert "Planner prepare filters for analysis""
2023-10-16 13:21:54 +02:00
Mikhail f. Shiryaev
a4fb143413
Merge pull request #50724 from AlexNik/docker-initialization-once
Initialization of the database only once in Docker.
2023-10-16 13:12:17 +02:00
helifu
dc0f8ed793 Add a new column 'is_hot_reloadable' to indicate whether hot loading is supported 2023-10-16 19:10:35 +08:00
alesapin
2eb1a05899 Fix 2023-10-16 13:07:41 +02:00
alesapin
31dc46a889 Better test 2023-10-16 13:04:45 +02:00
kssenii
34d804686a Fix black check 2023-10-16 13:03:12 +02:00
kssenii
3cd175d11d Fix test 2023-10-16 13:01:36 +02:00
vdimir
aae3894c23
Throw an exception in odbc-bridge if more than one table matched a single query 2023-10-16 10:43:36 +00:00
vdimir
cf1deb7bd5
Fix 'Invalid cursor state' in odbc interacting with MS SQL Server 2023-10-16 10:43:33 +00:00
Kruglov Pavel
6dcc756948
Fix for azure 2023-10-16 12:38:55 +02:00
Kruglov Pavel
836e35b6c4
Fix progress bar for s3 and azure Cluster functions with url without globs 2023-10-16 12:38:10 +02:00
Max Kainov
683437c61c fix docs and script 2023-10-16 10:35:14 +00:00
Max Kainov
b0b6e7fd47 fix docs 2023-10-16 10:35:14 +00:00
Max Kainov
60ad1c79bd fix docs 2023-10-16 10:35:14 +00:00
robot-clickhouse
7c2fee3280 Automatic style fix 2023-10-16 10:35:14 +00:00
Max Kainov
3f3fcce7e5 gh api request func update 2023-10-16 10:35:14 +00:00
Mikhail f. Shiryaev
c5ebd6f072 Use requests.gte in get_gh_api 2023-10-16 10:35:14 +00:00
Mikhail f. Shiryaev
346e8a0162 Remove recursion in favor of reset retry loop 2023-10-16 10:35:14 +00:00
Max Kainov
f1c316b79b ci script to use git hub api urls, readme for test 2023-10-16 10:35:13 +00:00
vdimir
d7c77420b6
QueryNormalizer only checks stack size 2023-10-16 10:33:04 +00:00
alesapin
8449e4c7b7
Merge pull request #55577 from ClickHouse/fix_max_execution_time_and_break_mode
Fix max execution time and 'break' overflow mode
2023-10-16 12:24:15 +02:00
Raúl Marín
4b62ff4ceb Merge remote-tracking branch 'blessed/master' into unused_protobuf 2023-10-16 11:59:38 +02:00
Kseniia Sumarokova
a4bd6891e1
Merge pull request #55164 from ClickHouse/vdimir/fix_file_cache_tmp_write_buffer
Fix file cache temporary file segment range in FileSegment::reserve
2023-10-16 11:44:46 +02:00
Antonio Andelic
6c543c730b
Merge pull request #55657 from ClickHouse/revert-55418-fix-OR
Revert "Fix filtering by virtual columns with OR filter in query"
2023-10-16 10:51:06 +02:00
alesapin
697c1e3bb0
Merge pull request #55604 from ClickHouse/evillique-partition-parameters
Implement query paramenters support in partition expression
2023-10-16 10:26:02 +02:00
Antonio Andelic
fb901c24a1
Revert "Fix filtering by virtual columns with OR filter in query" 2023-10-16 09:45:49 +02:00
Robert Schulze
f7cf512824
Merge pull request #55589 from rschu1ze/string-args-in-week-functions
MySQL compatibility: `toDayOfWeek()` now supports string arguments
2023-10-16 09:07:01 +02:00
Antonio Andelic
a3360cb3f5
Merge pull request #55485 from guoxiaolongzte/keeper_client_add_get_all_children_number_command
keeper_client add get_all_children_number command
2023-10-16 08:45:38 +02:00
Antonio Andelic
b6b92f46cc
Merge pull request #55541 from ClickHouse/sample-segfault
Better exception messages but without SEGFAULT
2023-10-16 08:43:52 +02:00
Antonio Andelic
c69838e052
Merge pull request #55591 from ClickHouse/fix-keeper-context
Apply Context changes to standalone Keeper
2023-10-16 08:41:17 +02:00
Alexey Milovidov
750d45bad3 Add support for touch devices 2023-10-16 05:26:14 +02:00
Alexey Milovidov
6d16a85364
Merge pull request #55648 from ClickHouse/reimplement-55639
Show move/maximize only if there is more than a single chart
2023-10-16 05:00:16 +02:00
Alexey Milovidov
95be5c7c07 Show move/maximize only if there is more than a single chart 2023-10-16 04:57:42 +02:00
guoxiaolong
98af58d7cf fix test error 2023-10-16 10:02:31 +08:00
alesapin
bdafe17e9a
Update src/Storages/MergeTree/ActiveDataPartSet.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-10-15 20:17:55 +02:00
alesapin
13ca296497
Update src/Storages/MergeTree/ActiveDataPartSet.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-10-15 20:17:50 +02:00
alesapin
6ac790e918
Update src/Storages/MergeTree/ActiveDataPartSet.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
2023-10-15 20:17:46 +02:00
alesapin
8a865cdfb2
Merge pull request #55646 from ClickHouse/fix_some_typos
Fix some typos
2023-10-15 18:28:33 +02:00
alesapin
441c039a3b Merge remote-tracking branch 'origin/test-merge-session-expired' into restore_top_level_parts 2023-10-15 18:27:27 +02:00
Alexey Milovidov
0f89b4aad6
Merge pull request #55640 from ClickHouse/preparation-key-condition-2
KeyCondition: small changes
2023-10-15 18:23:53 +02:00