Commit Graph

55894 Commits

Author SHA1 Message Date
Yarik Briukhovetskyi
9aa0fa11f8
IntervalKind -> IntervalKind::Kind 2024-04-10 14:01:53 +02:00
Yarik Briukhovetskyi
b8073a6667
Merge branch 'master' into time_buckets_impl 2024-04-10 13:21:42 +02:00
Robert Schulze
99cef9deee
Merge pull request #62376 from rschu1ze/qc-system-tables
Query cache: ignore results of queries against system tables
2024-04-10 11:03:31 +00:00
Robert Schulze
d1bd7e08e4
Merge remote-tracking branch 'rschu1ze/master' into qc-system-tables 2024-04-10 10:55:16 +00:00
Yarik Briukhovetskyi
957c58ce28
Merge pull request #62039 from zhongyuankai/memory_table_modify_setting
Support ALTER MODIFY SETTING for Memory tables
2024-04-10 10:55:01 +00:00
János Benjamin Antal
af6ded7382
Merge pull request #62221 from azat/pager-output_format_pretty_max_value_width
Unlimited output_format_pretty_max_value_width for --pager
2024-04-10 10:46:55 +00:00
Robert Schulze
fccfdc9edb
Merge pull request #62477 from loselarry/master
Docs: Minor grammar fixes
2024-04-10 10:35:23 +00:00
Dmitry Novik
443d3175af
Merge pull request #62433 from kitaisreal/optimize-group-by-injective-functions-pass-remove-unused-constant
OptimizeGroupByInjectiveFunctionsPass remove unused constant
2024-04-10 10:10:37 +00:00
Robert Schulze
1f48b97d23
Fix clang-tidy build 2024-04-10 09:56:54 +00:00
loselarry
7774a2a313 chore: fix some comments
Signed-off-by: loselarry <bikangning@yeah.net>
2024-04-10 17:21:25 +08:00
Nikolai Kochetov
25d64d490a
Merge pull request #62409 from ClickHouse/fix-global-in-table-with-analyzer
Fix GLOBAL IN table queries with analyzer.
2024-04-10 07:04:21 +00:00
Alexander Tokmakov
8a28cbc865
Merge pull request #62418 from azat/uncaught-exception-onFault
Avoid uncaught exception for onFault handler
2024-04-09 21:59:19 +00:00
Robert Schulze
8167b774b5
Merge pull request #62307 from rschu1ze/cleanup-ssh
Cleanup SSH-based authentication code
2024-04-09 21:10:09 +00:00
Alexander Tokmakov
8f423b9fd4
Merge pull request #62421 from ClickHouse/tavplubix-patch-13
Update StorageFileLog.cpp
2024-04-09 20:41:28 +00:00
Nikolai Kochetov
de2a5f018f
Update CollectSets.cpp 2024-04-09 20:40:40 +02:00
Robert Schulze
c7cb33d035
Better parsing 2024-04-09 15:43:08 +00:00
Robert Schulze
22e164c65d
Merge pull request #62375 from rschu1ze/static-instance2
Don't access static members through instance, pt. II
2024-04-09 14:37:24 +00:00
Kseniia Sumarokova
ebf4f79a34
Merge pull request #61723 from ClickHouse/better-dynamic-cache-resize-part-2
Speed up dynamic resize of filesystem cache
2024-04-09 13:54:07 +00:00
Nikita Taranov
d594cb2e41
Merge pull request #62208 from arthurpassos/s3_aws_private_link_style
Add support for S3 access through aws private link interface
2024-04-09 12:32:38 +00:00
Antonio Andelic
f6af63e133
Merge pull request #62332 from ClickHouse/more-complex-stacktrace-locking
More complex locking in `StackTrace::toString`
2024-04-09 12:30:59 +00:00
Nikolai Kochetov
bba66eb05a Review fixes. 2024-04-09 12:30:07 +00:00
Robert Schulze
4035334634
Merge remote-tracking branch 'rschu1ze/master' into static-instance2 2024-04-09 11:45:27 +00:00
Kruglov Pavel
6c952ce0f1
Merge pull request #62413 from Avogar/fix-numbers-zero-step
Fix logical error 'numbers_storage.step != UInt64{0}'
2024-04-09 10:54:36 +00:00
Kruglov Pavel
057efdb447
Merge pull request #62398 from Avogar/fix-analyzer-merge-push-down
Fix filter pushdown from additional_table_filters in Merge engine in analyzer
2024-04-09 10:54:06 +00:00
Sema Checherinda
04ea8a85f2
Merge pull request #62249 from ClickHouse/chesema-keep-alive-send-and-receive
several fixes for client's keep alive connections
2024-04-09 10:27:28 +00:00
Kruglov Pavel
49ba81a5f9
Merge pull request #62417 from Avogar/dot-product-overflow
Don't check overflow in  arrayDotProduct in undefined sanitizer
2024-04-09 10:17:58 +00:00
Maksim Kita
0543fc3263 OptimizeGroupByInjectiveFunctionsPass remove unused constant 2024-04-09 13:17:42 +03:00
Alexander Gololobov
b3dd5f519d
Merge pull request #62348 from ClickHouse/http_log_levels
Reduce log levels for ReadWriteBufferFromHTTP retries
2024-04-09 07:02:31 +00:00
Nikita Mikhaylov
6b3ed64d3e
Merge pull request #61232 from ClickHouse/optimize-wait-for-outdated-parts
Do nothing in `waitForOutdatedPartsToBeLoaded()` if loading is not required
2024-04-08 19:20:33 +00:00
Alexander Tokmakov
9a08f1ddd6
Update StorageFileLog.cpp 2024-04-08 20:53:19 +02:00
Alexey Milovidov
5db0df0bc1
Update BaseDaemon.cpp 2024-04-08 21:48:36 +03:00
Azat Khuzhin
75e46f865c Avoid uncaught exception for onFault handler
onFault() is called from the std::thread, and it should catch all
exceptions, otherwise you can unrelated fatal errors.

<details>

<summary>stacktrace</summary>

    2024.04.08 13:15:29.526847 [ 2067427 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7) (from thread 2118603) Terminate called for uncaught exception:
    2024.04.08 13:15:29.526904 [ 2067427 ] {} <Fatal> BaseDaemon: Code: 210. DB::NetException: I/O error: Broken pipe, while writing to socket (10.61.7.253:9000 -> 10.101.53.134:46036). (NETWORK_ERROR), Stack trace (when copying this message, always include the lines below):
    2024.04.08 13:15:29.526983 [ 2067427 ] {} <Fatal> BaseDaemon:
    2024.04.08 13:15:29.527042 [ 2067427 ] {} <Fatal> BaseDaemon: 0. ./build_docker/./src/Common/Exception.cpp:96: DB::Exception::Exception(DB::Exception::MessageMasked&&, int, bool) @ 0x000000000cf5af1b
    2024.04.08 13:15:29.527061 [ 2067427 ] {} <Fatal> BaseDaemon: 1. ./contrib/llvm-project/libcxx/include/string:1499: DB::NetException::NetException<String, String, String>(int, FormatStringHelperImpl<std::type_identity<String>::type, std::type_identity<String>::type, std::type_identity<String>::type>, String&&, String&&, String&&) @ 0x000000000d07dfe1
    2024.04.08 13:15:29.527082 [ 2067427 ] {} <Fatal> BaseDaemon: 2. ./build_docker/./src/IO/WriteBufferFromPocoSocket.cpp:0: DB::WriteBufferFromPocoSocket::nextImpl() @ 0x000000000d07e97e
    2024.04.08 13:15:29.527125 [ 2067427 ] {} <Fatal> BaseDaemon: 3. ./src/IO/WriteBuffer.h:65: DB::TCPHandler::sendLogs() @ 0x0000000012fd31c1
    2024.04.08 13:15:29.527144 [ 2067427 ] {} <Fatal> BaseDaemon: 4. ./contrib/llvm-project/libcxx/include/atomic:958: void std::__function::__policy_invoker<void ()>::__call_impl<std::__function::__default_alloc_func<DB::TCPHandler::runImpl()::$_0, void ()>>(std::__function::__policy_storage const*) @ 0x0000000012fdcc6e
    2024.04.08 13:15:29.527163 [ 2067427 ] {} <Fatal> BaseDaemon: 5. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x000000000d25c65b
    2024.04.08 13:15:29.527182 [ 2067427 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./src/Daemon/BaseDaemon.cpp:286: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000d25e775
    2024.04.08 13:15:29.527191 [ 2067427 ] {} <Fatal> BaseDaemon: 7. ? @ 0x00007f0fe4906609
    2024.04.08 13:15:29.527211 [ 2067427 ] {} <Fatal> BaseDaemon: 8. ? @ 0x00007f0fe482b353

    2024.04.08 13:15:29.534235 [ 2118604 ] {} <Fatal> BaseDaemon: ########## Short fault info ############
    2024.04.08 13:15:29.534347 [ 2118604 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7) (from thread 2118603) Received signal 6
    2024.04.08 13:15:29.534476 [ 2118604 ] {} <Fatal> BaseDaemon: Signal description: Aborted
    2024.04.08 13:15:29.534484 [ 2118604 ] {} <Fatal> BaseDaemon:
    2024.04.08 13:15:29.534510 [ 2118604 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f0fe474f00b 0x00007f0fe472e859 0x000000000d24f72e 0x0000000017d15be3 0x0000000017d15818 0x0000000012fd350d 0x0000000012fdcc6e 0x000000000d25c65b 0x000000000d25e775 0x00007f0fe4906609 0x00007f0fe482b353
    2024.04.08 13:15:29.534531 [ 2118604 ] {} <Fatal> BaseDaemon: ########################################
    2024.04.08 13:15:29.534609 [ 2118604 ] {} <Fatal> BaseDaemon: (version 24.2.2.71 (official build), build id: 57F857DCFE8BA6838F6463E4665CD700852BFF0E, git hash: 9293d361e7) (from thread 2118603) (no query) Received signal Aborted (6)
    2024.04.08 13:15:29.534638 [ 2118604 ] {} <Fatal> BaseDaemon:
    2024.04.08 13:15:29.534663 [ 2118604 ] {} <Fatal> BaseDaemon: Stack trace: 0x00007f0fe474f00b 0x00007f0fe472e859 0x000000000d24f72e 0x0000000017d15be3 0x0000000017d15818 0x0000000012fd350d 0x0000000012fdcc6e 0x000000000d25c65b 0x000000000d25e775 0x00007f0fe4906609 0x00007f0fe482b353
    2024.04.08 13:15:29.534711 [ 2118604 ] {} <Fatal> BaseDaemon: 2. ? @ 0x00007f0fe474f00b
    2024.04.08 13:15:29.534728 [ 2118604 ] {} <Fatal> BaseDaemon: 3. ? @ 0x00007f0fe472e859
    2024.04.08 13:15:29.613230 [ 2118604 ] {} <Fatal> BaseDaemon: 4.0. inlined from ./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:670: __cxa_decrement_exception_refcount
    2024.04.08 13:15:29.613283 [ 2118604 ] {} <Fatal> BaseDaemon: 4.1. inlined from ./contrib/llvm-project/libcxx/src/support/runtime/exception_pointer_cxxabi.ipp:17: ~exception_ptr
    2024.04.08 13:15:29.613311 [ 2118604 ] {} <Fatal> BaseDaemon: 4. ./build_docker/./src/Daemon/BaseDaemon.cpp:591: terminate_handler() @ 0x000000000d24f72e
    2024.04.08 13:15:29.617590 [ 2118604 ] {} <Fatal> BaseDaemon: 5. ./build_docker/./contrib/llvm-project/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x0000000017d15be3
    2024.04.08 13:15:29.619575 [ 2118604 ] {} <Fatal> BaseDaemon: 6. ./build_docker/./contrib/llvm-project/libcxxabi/src/cxa_exception.cpp:0: __cxa_rethrow @ 0x0000000017d15818
    2024.04.08 13:15:30.104097 [ 2118604 ] {} <Fatal> BaseDaemon: 7.0. inlined from ./src/IO/WriteBuffer.h:0: DB::WriteBuffer::next()
    2024.04.08 13:15:30.104331 [ 2118604 ] {} <Fatal> BaseDaemon: 7.1. inlined from ./build_docker/./src/Server/TCPHandler.cpp:2225: DB::TCPHandler::sendLogData(DB::Block const&)
    2024.04.08 13:15:30.104408 [ 2118604 ] {} <Fatal> BaseDaemon: 7. ./build_docker/./src/Server/TCPHandler.cpp:2303: DB::TCPHandler::sendLogs() @ 0x0000000012fd350d
    2024.04.08 13:15:30.217481 [ 2118604 ] {} <Fatal> BaseDaemon: 8.0. inlined from ./contrib/llvm-project/libcxx/include/atomic:958: double std::__cxx_atomic_load[abi:v15000]<double>(std::__cxx_atomic_base_impl<double> const*, std::memory_order)
    2024.04.08 13:15:30.217579 [ 2118604 ] {} <Fatal> BaseDaemon: 8.1. inlined from ./contrib/llvm-project/libcxx/include/atomic:1588: std::__atomic_base<double, false>::load[abi:v15000](std::memory_order) const
    2024.04.08 13:15:30.217617 [ 2118604 ] {} <Fatal> BaseDaemon: 8.2. inlined from ./src/Common/ThreadFuzzer.cpp:407: pthread_mutex_unlock
    2024.04.08 13:15:30.217644 [ 2118604 ] {} <Fatal> BaseDaemon: 8.3. inlined from ./contrib/llvm-project/libcxx/include/__threading_support:314: std::__libcpp_mutex_unlock[abi:v15000](pthread_mutex_t*)
    2024.04.08 13:15:30.217676 [ 2118604 ] {} <Fatal> BaseDaemon: 8.4. inlined from ./contrib/llvm-project/libcxx/src/mutex.cpp:52: std::mutex::unlock()
    2024.04.08 13:15:30.217699 [ 2118604 ] {} <Fatal> BaseDaemon: 8.5. inlined from ./contrib/llvm-project/libcxx/include/__mutex_base💯 ~lock_guard
    2024.04.08 13:15:30.217747 [ 2118604 ] {} <Fatal> BaseDaemon: 8.6. inlined from ./build_docker/./src/Server/TCPHandler.cpp:392: operator()
    2024.04.08 13:15:30.217776 [ 2118604 ] {} <Fatal> BaseDaemon: 8.7. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: ?
    2024.04.08 13:15:30.217796 [ 2118604 ] {} <Fatal> BaseDaemon: 8.8. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:479: ?
    2024.04.08 13:15:30.217859 [ 2118604 ] {} <Fatal> BaseDaemon: 8.9. inlined from ./contrib/llvm-project/libcxx/include/__functional/function.h:235: ?
    2024.04.08 13:15:30.217878 [ 2118604 ] {} <Fatal> BaseDaemon: 8. ./contrib/llvm-project/libcxx/include/__functional/function.h:716: ? @ 0x0000000012fdcc6e
    2024.04.08 13:15:30.240809 [ 2118604 ] {} <Fatal> BaseDaemon: 9. ./contrib/llvm-project/libcxx/include/__functional/function.h:0: ? @ 0x000000000d25c65b
    2024.04.08 13:15:30.283617 [ 2118604 ] {} <Fatal> BaseDaemon: 10.0. inlined from ./build_docker/./src/Daemon/BaseDaemon.cpp:286: operator()
    2024.04.08 13:15:30.283686 [ 2118604 ] {} <Fatal> BaseDaemon: 10.1. inlined from ./contrib/llvm-project/libcxx/include/__functional/invoke.h:394: ?
    2024.04.08 13:15:30.283725 [ 2118604 ] {} <Fatal> BaseDaemon: 10.2. inlined from ./contrib/llvm-project/libcxx/include/thread:284: void std::__thread_execute[abi:v15000]<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>(std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>&, std::__tuple_indices<>)
    2024.04.08 13:15:30.283755 [ 2118604 ] {} <Fatal> BaseDaemon: 10. ./contrib/llvm-project/libcxx/include/thread:295: void* std::__thread_proxy[abi:v15000]<std::tuple<std::unique_ptr<std::__thread_struct, std::default_delete<std::__thread_struct>>, SignalListener::run()::'lambda'()>>(void*) @ 0x000000000d25e775
    2024.04.08 13:15:30.283799 [ 2118604 ] {} <Fatal> BaseDaemon: 11. ? @ 0x00007f0fe4906609
    2024.04.08 13:15:30.283821 [ 2118604 ] {} <Fatal> BaseDaemon: 12. ? @ 0x00007f0fe482b353
    2024.04.08 13:15:30.574588 [ 2118604 ] {} <Fatal> BaseDaemon: Integrity check of the executable successfully passed (checksum: 3485110FABDB0C94202BD684999A9814)
    2024.04.08 13:15:30.574704 [ 2118604 ] {} <Fatal> BaseDaemon: Report this error to https://github.com/ClickHouse/ClickHouse/issues

</details>

v2: fatal logging

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-08 20:20:25 +02:00
avogar
b318091528 Don't check overflow in dotProduct in undefined sanitizer 2024-04-08 17:17:04 +00:00
Alexey Milovidov
ce4ab06d03
Merge pull request #62382 from ClickHouse/remove-insert-watch
Remove support for INSERT WATCH query
2024-04-08 16:58:27 +00:00
avogar
39c6188a2c Fix logical error 'numbers_storage.step != UInt64{0}' 2024-04-08 16:38:19 +00:00
Yarik Briukhovetskyi
6277deb166
small fixes 2024-04-08 17:59:54 +02:00
Nikita Taranov
5b4f67cc39
Merge pull request #62268 from nickitat/test_for_bug
Fix PartsSplitter
2024-04-08 15:11:25 +00:00
Nikolai Kochetov
b97e16f2b4
Merge bcccbe2b19 into c369d2171d 2024-04-08 16:54:43 +02:00
Nikolai Kochetov
bcccbe2b19 Fixing typo 2024-04-08 14:54:36 +00:00
Nikolai Kochetov
82b2adef97 Fix GLOBAL IN table queries with analyzer. 2024-04-08 14:50:13 +00:00
Alexander Tokmakov
a73d927990
Merge pull request #61882 from ClickHouse/less_unformatted_exceptions
Fix 00002_log_and_exception_messages_formatting
2024-04-08 14:44:32 +00:00
kssenii
44d3612d77 Review suggestion 2024-04-08 15:52:38 +02:00
Alexey Milovidov
c369d2171d
Merge pull request #62366 from ClickHouse/no-user-defined-directory
Do not create a directory for UDF in clickhouse-client if it does not exist
2024-04-08 15:24:24 +02:00
Nikolai Kochetov
3421135ff1
Merge pull request #62281 from ClickHouse/analyzer-fix-resolve-from-parent-scopes
Analyzer: Fix name resolution from parent scopes
2024-04-08 15:06:57 +02:00
avogar
e4b0ca5d83 Fix filter pushdown from additional_table_filters in Merge engine in analyzer 2024-04-08 12:59:20 +00:00
kssenii
259d50c57b Add more comments 2024-04-08 14:36:07 +02:00
vdimir
b0ede03bf1
Merge pull request #62318 from azat/mt/detached-const
Use DETACHED_DIR_NAME everywhere
2024-04-08 14:16:13 +02:00
divanik
1e8105fa7b
Merge pull request #62320 from seandhaynes/shaynes/dictionary-source-type
Fix small typo in Dictionary source loader
2024-04-08 14:13:06 +02:00
vdimir
35be12c184
Merge pull request #62325 from ClickHouse/vdimir/fix_optimize_uniq_to_count
Fix optimize_uniq_to_count when only prefix of key is matched
2024-04-08 14:11:39 +02:00
vdimir
eb7a74247d
Merge pull request #62336 from ClickHouse/vdimir/prewhere_lambda_function
Analyzer: Fix PREWHERE with lambda functions
2024-04-08 13:52:50 +02:00