Commit Graph

3 Commits

Author SHA1 Message Date
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Nikolai Kochetov
f739078ea5 Fixed IAST::clone() implementations which were without children deep copy. [#CLICKHOUSE-3735] 2018-05-18 21:28:11 +03:00
Alexey Milovidov
6be0428ffe Preparation [#CLICKHOUSE-31]. 2017-06-18 08:44:09 +03:00