Commit Graph

291 Commits

Author SHA1 Message Date
Alexander Tokmakov
dd626d51cb
Fix perf tests report when there are no tests (#56881)
* fix perf tests report when there are no tests

* Automatic style fix

* Update docker/test/performance-comparison/compare.sh

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2023-11-17 16:36:19 +01:00
Azat Khuzhin
ff7e9e16d5 Fix possible performance test error
CI [1]:

    2023-10-24 12:18:27	 ++ rg -c array_fill.xml changed-test-definitions.txt
    2023-10-24 12:18:27	 + '[' '' -gt 0 ']'
    2023-10-24 12:18:27	 right/scripts/compare.sh: line 288: [: : integer expression expected

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/55944/da408df4a7296835897d7cef80d63f252df79b75/performance_comparison_[2_4]/compare.log

v1: use --include-zero
v2: revert to grep
v3: check exit code
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-24 13:51:57 +02:00
bakam412
c5c3833a80 fix tests 2023-09-14 11:12:44 +08:00
Raúl Marín
333fc76300 Remove useless slow on client check 2023-08-22 16:30:57 +02:00
Alexey Milovidov
857856b8b6 Leave only simplifications 2023-08-17 03:58:32 +02:00
Alexey Milovidov
3c6af254bc Remove something 2023-08-14 01:26:04 +02:00
Alexey Milovidov
957045c70b Maybe fix error 2023-08-13 20:15:30 +02:00
Alexey Milovidov
d434e58eae Fix errors 2023-08-13 06:45:41 +02:00
Alexey Milovidov
8dc0884099 Fix error 2023-08-13 04:20:06 +02:00
Alexey Milovidov
ec779ca246 Export logs from CI in performance (part 2) 2023-08-13 00:32:55 +02:00
Alexey Milovidov
9f9b794feb Export logs from CI in performance (preparation) 2023-08-13 00:32:55 +02:00
Alexey Milovidov
f2621e70ae Remove unrecognizable garbage from the performance test 2023-08-10 03:27:07 +02:00
Alexey Milovidov
6edf4a777f Remove unrecognizable garbage from the performance test 2023-08-10 03:26:11 +02:00
Azat Khuzhin
5871ca0836 Fix performance tests due to warnings from jemalloc about Per-CPU arena disabled
jemalloc can show the following warning:

    Number of CPUs detected is not deterministic. Per-CPU arena disabled

It will be shown if one of the following returns different number of
CPUs:
- _SC_NPROCESSORS_ONLN
- _SC_NPROCESSORS_CONF
- sched_getaffinity()

And actually for my CPU linux returns different numbers, because there
are more possible CPUs then online, from dmesg:

    smpboot: Allowing 128 CPUs, 64 hotplug CPUs

And from sysfs:

    # grep . /sys/devices/system/cpu/{possible,online,offline}
    /sys/devices/system/cpu/possible:0-127
    /sys/devices/system/cpu/online:0-63
    /sys/devices/system/cpu/offline:64-127

From ACPI:

    # acpidump -o acpi
    # acpixtract -a acpi
    # iasl -d *.dat
    # grep -e 'Processor Enabled' apic.dsl | sort | uniq -c
        64                            Processor Enabled : 0
        64                            Processor Enabled : 1

So I guess this is the same as what happened in this perf run [1].

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/51360/5d43a64112711b339b82b1c0e8df7882546a1a3c/performance_comparison_[4_4]/report.html

P.S. personally I, just use cmdline=possible_cpus=64 to fix this for my
setup.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-06-25 09:37:37 +02:00
Azat Khuzhin
b8b6d597ae
Avoid OOM in perf tests (#46641)
* Avoid OOM in perf tests

At some point perf tests started to fail for one setup on CI [1]:

    /home/ubuntu/actions-runner/_work/_temp/f8fce7b1-8bc4-49c8-a203-c96867f4420a.sh: line 5: 1882659 Killed                  python3 performance_comparison_check.py "$CHECK_NAME"
    Error: Process completed with exit code 137.

  [1]: https://github.com/ClickHouse/ClickHouse/actions/runs/4230936986/jobs/7349818625

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

* Switch perf tests to ubuntu 22.04 for parallel with --memsuspend

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>

---------

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-02-23 14:05:18 +01:00
Alexander Tokmakov
669c4e94d5
Update compare.sh 2023-02-20 17:35:30 +03:00
Robert Schulze
de8fc04b03
Performance report: "Partial queries" --> "Backward-incompatible queries 2023-01-22 17:43:27 +00:00
Alexey Milovidov
42f25cb6a6
Amend 2023-01-07 00:57:47 +03:00
Alexey Milovidov
22fcabd229
Remove expert-level grep usages. 2023-01-07 00:57:11 +03:00
Alexey Milovidov
0b324ab836 Modern tools 2023-01-01 20:53:06 +01:00
Nikita Taranov
def4eeac70
Fix perf tests (#41332)
We run left server two times. If after the first run server will not be properly stopped, we will get `Address already in use: [::]:9001` exception on the second run.
2022-09-15 12:27:08 +02:00
Nikita Taranov
9f1ee52b00
Run all queries from changed perf tests (#40322)
* impl

* fix
2022-08-19 19:46:07 +02:00
Alexander Tokmakov
3bc583c22b
Revert "copy self-extracting to output" 2022-08-08 20:13:40 +03:00
Yakov Olkhovskiy
f5442cba86 clickhouse may be compressed - run once to decompress 2022-07-29 15:06:15 -04:00
Vladimir C
bfba67cf88
Update docker/test/performance-comparison/compare.sh 2022-07-08 17:13:20 +02:00
Vladimir C
9555d72dfc
Remove head ci-checks.tsv 2022-07-08 15:26:07 +02:00
vdimir
f701b58dd0
Update check_name in performance comparsion upload 2022-07-05 14:24:58 +02:00
vdimir
e4917914ae
Revert "show grants in compare.sh"
This reverts commit 4d3a64b318aa665bf1494cca6ae94e58dc8d361e.
2022-07-05 14:00:27 +02:00
vdimir
3731bd44c1
Revert "[testing] run only one perftest"
This reverts commit 3b079827b78e04ac20043346998ce9d546969746.
2022-07-05 14:00:26 +02:00
vdimir
051dd63a62
Fix types in ci-checks.tsv in compare.sh 2022-07-05 14:00:26 +02:00
vdimir
c1d44fee9f
upd compare.sh 2022-07-05 14:00:26 +02:00
vdimir
b1ee16ef77
show grants in compare.sh 2022-07-05 14:00:26 +02:00
vdimir
18dc718e4e
do not create tables for perf tests 2022-07-05 14:00:25 +02:00
vdimir
f8fa10578c
Use default database for perf tests 2022-07-05 14:00:25 +02:00
vdimir
7352c26e89
create tables for perf tests 2022-07-05 14:00:25 +02:00
vdimir
45b2b1ca8a
[wip] persist pertest results 2022-07-05 14:00:24 +02:00
vdimir
c2d774d598
[testing] run only one perftest 2022-07-05 14:00:24 +02:00
vdimir
aac2f8aefc
Rename envs for performance comparsion 2022-07-05 14:00:24 +02:00
Ilya Yatsishin
64befe9753 Filter out incompatible performance test 2022-06-02 14:29:24 +02:00
Alexey Milovidov
2d7d67e7bc Remove special handling of "short" queries - the logic is too ad-hoc, it pollutes the code and is difficult to handle 2022-04-29 04:27:57 +02:00
Mikhail f. Shiryaev
74a755d170
Use just index to split tests by group 2022-04-22 20:34:34 +02:00
Azat Khuzhin
8d87e48cb4 Simplify perf scripts by using schema inference 2022-04-17 09:01:15 +03:00
Nikolai Kochetov
3849e63ab1 Change database 2022-03-29 19:06:50 +00:00
alesapin
b838a7dcb0 Remove outdated links from CI 2022-03-28 15:53:22 +02:00
alesapin
8e1fec39cd Fix bash 2021-12-13 12:58:34 +03:00
alesapin
e2a2d1cdc3 Merge branch 'master' into add_performance_tests 2021-12-13 12:01:31 +03:00
alesapin
cf281b10dc Split perf test into multiple checks 2021-12-13 11:59:58 +03:00
Azat Khuzhin
44f366fd12 Cleanup perf test runner
Use subshell to:
- avoid change/restore of TIMEFORMAT
- grepping out trace output, by using set +x in a subshell
- use array for options to avoid extra backslashes
2021-12-12 13:58:00 +03:00
alesapin
eb51d9550d
Merge branch 'master' into add_performance_tests 2021-12-12 01:01:13 +03:00
tavplubix
85e53b1b1f
Try fix attaching gdb in tests (#32448)
* attach gdb with sudo

* fix

* Update run.sh
2021-12-10 00:12:45 +03:00