Commit Graph

2222 Commits

Author SHA1 Message Date
alexey-milovidov
adeba6bdd8
Merge pull request #15074 from amosbird/btc
Extend trivial count optimization.
2020-10-22 02:50:57 +03:00
Alexander Tokmakov
ac42199ae5 fix race on StorageReplicatedMergeTree::data_parts_exchange_endpoint 2020-10-21 22:25:22 +03:00
Kruglov Pavel
0b75885c8a
Merge branch 'master' into select_final 2020-10-21 20:42:39 +03:00
Pavel Kruglov
89fdeb4e15 Fix style, move setting and add checking level>0 2020-10-21 20:35:31 +03:00
Nikolai Kochetov
a0da588f06 Merge branch 'master' into new-block-for-functions-4 2020-10-21 16:16:58 +03:00
alexey-milovidov
0b7430dda1
Merge pull request #16206 from ClickHouse/fix-memory-tracking
Fix multiple issues with memory tracking
2020-10-21 14:34:22 +03:00
alesapin
c53f59dece
Merge pull request #15984 from ClickHouse/fix_insert_mv_dangling_ref
Fix possibly dangling reference to target table of MV
2020-10-21 12:13:51 +03:00
alesapin
11ea6d7911 Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-21 11:39:48 +03:00
alesapin
b45d42bb9c Maybe devirtualization can help 2020-10-21 11:35:36 +03:00
alesapin
9f47c82bbd Sleep a little when pool is full 2020-10-21 11:31:57 +03:00
alesapin
b1a13d4884 Merge branch 'blind_fix_of_read_in_order' into no_background_pool_no_more 2020-10-21 10:30:09 +03:00
Nikolai Kochetov
68c9a57788 Merge branch 'master' into new-block-for-functions-4 2020-10-21 09:17:25 +03:00
Alexey Milovidov
2619efadc8 Fix multiple issues with memory tracking 2020-10-21 03:31:34 +03:00
alexey-milovidov
8084ce75cb
Merge pull request #16105 from azat/allow_nondeterministic_optimize_skip_unused_shards
Add allow_nondeterministic_optimize_skip_unused_shards
2020-10-21 00:16:26 +03:00
alesapin
c77b154398 Better locks in merge tree 2020-10-21 00:10:55 +03:00
alesapin
8097c696de Trying another fix 2020-10-20 23:05:20 +03:00
alexey-milovidov
75a02112bc
Merge pull request #15592 from sundy-li/readonly-metrics
sub ReadonlyReplica metric when detach readonly tables
2020-10-20 19:17:52 +03:00
alesapin
439bbd9861 Blind performance fix 2020-10-20 18:30:46 +03:00
Vladimir Chebotarev
aa5f207fd4
Added disable_merges option for volumes in multi-disk configuration (#13956)
Co-authored-by: Alexander Kazakov <Akazz@users.noreply.github.com>
2020-10-20 18:10:24 +03:00
Nikolai Kochetov
a1d5adf8d5 Merge branch 'master' into new-block-for-functions-4 2020-10-20 16:16:08 +03:00
alesapin
30ca17b09b Comment to settings 2020-10-20 16:12:25 +03:00
alesapin
7256d01579 Normal backoff value instead of 10 seconds 2020-10-20 16:11:01 +03:00
Alexander Kuzmenkov
84908df6d8 fix setting parent from HTTP traceparent 2020-10-20 14:35:13 +03:00
alesapin
ce8ee01d75 Fix background moves start 2020-10-20 14:27:50 +03:00
alesapin
d126aa8a09 Merge branch 'master' into no_background_pool_no_more 2020-10-20 12:54:42 +03:00
alexey-milovidov
5e46e7c670
Merge pull request #15723 from Jokser/idempotent-part-move
Possibility to move part to another disk/volume if first attempt was failed
2020-10-20 04:26:50 +03:00
alexey-milovidov
124379cccc
Update IMergeTreeDataPart.h 2020-10-20 04:24:30 +03:00
alexey-milovidov
26517ff08d
Update IMergeTreeDataPart.h 2020-10-20 04:23:23 +03:00
Nikolai Kochetov
bc58637ec2 Fixing build. 2020-10-19 21:37:44 +03:00
Alexander Kuzmenkov
6dcfd26b29 Merge remote-tracking branch 'origin/master' into tmp 2020-10-19 21:36:30 +03:00
Alexander Kuzmenkov
defcd29b31
Merge pull request #16036 from ClickHouse/stress_test_improvemets
Minor improvements of stress test
2020-10-19 16:12:30 +03:00
Nicolae Vartolomei
af76ff1dbf RFC: Add metadata section to MergeTreeWriteAheadLog
Current WAL format doesn't seem to be extendable without breaking
reverse compatibility.

This PR proposes to introduces a metadata section
for each action in the WAL to which optional fields can be added.

Adding new fields is trivial and doesn't have to break backwards
compatibility if these are not critical for correctness.

Metadata contains the minimum version of the reader allowed
to interpret it.

Removing fields is not supported.
2020-10-19 12:16:31 +01:00
alesapin
514a95c292 Fixup 2020-10-19 12:06:51 +03:00
alesapin
cb139abe2a Better schedule after job already running 2020-10-19 11:47:15 +03:00
alesapin
e09713ece1 Merge branch 'master' into no_background_pool_no_more 2020-10-19 10:58:31 +03:00
alesapin
963bc57835
Merge pull request #16011 from ClickHouse/fix_alter_add_and_modify_order_by
Fix alter sorting key for ReplicatedVersionedCollapsingMergeTree
2020-10-19 10:31:13 +03:00
Azat Khuzhin
9b8abd44ab Add allow_nondeterministic_optimize_skip_unused_shards 2020-10-17 01:07:02 +03:00
Alexander Tokmakov
c19d2efd88 add more holders 2020-10-16 20:16:58 +03:00
alesapin
518ba2ceb2 Safe random generator 2020-10-16 16:48:12 +03:00
Alexander Tokmakov
026896835c fixes 2020-10-16 15:20:30 +03:00
alesapin
c22c760ac1 Fix unit test build 2020-10-16 13:18:56 +03:00
alesapin
7edbe4d276 Add some comments 2020-10-16 13:12:31 +03:00
Pavel Kovalenko
a474bdcabf Merge remote-tracking branch 'origin/master' into idempotent-part-move 2020-10-16 13:02:40 +03:00
alesapin
0fb1f74b2e Trying to schedule better 2020-10-16 11:00:15 +03:00
alesapin
280d0c55c2 Merge branch 'master' into no_background_pool_no_more 2020-10-16 10:25:02 +03:00
Alexey Milovidov
6c3aad34be Avoid stack overflow in materialized views, part 2: sanity check 2020-10-16 03:19:45 +03:00
Alexey Milovidov
ffd3d2519e Avoid stack overflow in materialized views, part 1 2020-10-16 03:13:17 +03:00
Kruglov Pavel
5aba639430 Update test 2020-10-15 22:01:18 +03:00
sundy-li
153be93544 sub ReadonlyReplica when detach readonly tables 2020-10-15 22:01:18 +03:00
alesapin
4c1f5cab13 Sleep less in background task 2020-10-15 19:10:22 +03:00
Pavel Kruglov
ee8a9d2cf1 Don't touch MySQL database if it's unnecessary 2020-10-15 18:57:17 +03:00
Alexander Kuzmenkov
bc7b5f6bb4 Merge remote-tracking branch 'origin/master' into tmp 2020-10-15 17:15:05 +03:00
Vitaly Baranov
5f261cec3c
Merge pull request #15199 from filimonov/non_delimited_protobuf
ProtobufSingle format
2020-10-15 16:58:39 +03:00
alesapin
629506445d Better backoff policy 2020-10-15 16:57:50 +03:00
Pavel Kovalenko
ed61c5681b Use 'moving' directory instead of 'detached' when move part to another disk/volume. 2020-10-15 16:55:13 +03:00
alesapin
60d14352f8 Merge branch 'master' into no_background_pool_no_more 2020-10-15 16:34:14 +03:00
Alexander Kuzmenkov
f366b366ae
Merge pull request #15987 from filimonov/background-pool-count_no_work_done-bug
Fix the bug when NOTHING_TO_DO events wrongly increment count_no_work_done
2020-10-15 16:11:57 +03:00
alesapin
2002289003 Fix bug in alter primary key for replicated versioned collapsing merge tree 2020-10-15 16:02:39 +03:00
Alexander Kuzmenkov
b4378b004f Merge remote-tracking branch 'origin/master' into tmp 2020-10-15 16:01:41 +03:00
Pavel Kruglov
f5fac575f4 don't postprocess single parts 2020-10-15 15:22:41 +03:00
tavplubix
1003de75ed
Update StorageMaterializedView.cpp 2020-10-15 15:06:44 +03:00
alesapin
dccf51b316 Remove redundant logging 2020-10-15 14:08:39 +03:00
tavplubix
6dc2f00347
Update StorageMaterializedView.cpp 2020-10-15 13:57:47 +03:00
alesapin
84b0c22044 fix possible deadlock 2020-10-15 13:54:50 +03:00
alesapin
374949051c Add thread safety 2020-10-15 13:41:36 +03:00
alesapin
e84eda176a Add test and slightly refactored 2020-10-15 13:22:02 +03:00
alesapin
583d7042e9 Get rid of some deadlocks 2020-10-15 11:29:18 +03:00
Nikolai Kochetov
e8038ae84f
Merge pull request #15857 from amosbird/e2
Refactor processors.
2020-10-15 10:45:00 +03:00
alesapin
c5419083e3 Better method name 2020-10-15 10:43:50 +03:00
alesapin
3394c22c03 Fix race and clang-tidy 2020-10-15 10:39:27 +03:00
Mikhail Filimonov
ace2e99cb3
Fix the bug when NOTHING_TO_DO events wrongly increment count_no_work_done 2020-10-14 23:08:47 +02:00
alesapin
3e3505258f No sleep when we have job 2020-10-14 22:33:36 +03:00
alesapin
ae8ed99805 Missed change 2020-10-14 21:35:03 +03:00
alesapin
7265792510 Less files 2020-10-14 21:33:41 +03:00
alesapin
a535a089d1 Some style fixes 2020-10-14 19:09:18 +03:00
alesapin
fc25b6cd72 Remove background processing pool 2020-10-14 18:26:00 +03:00
alesapin
6a4911dc57 Remove some garbage 2020-10-14 18:05:14 +03:00
alesapin
483893cdd4 Slightly refactored code 2020-10-14 17:56:42 +03:00
Vitaly Baranov
997570780d
Merge branch 'master' into non_delimited_protobuf 2020-10-14 16:26:57 +03:00
alesapin
0b14a31ba9 Get rid of background processing pool 2020-10-14 15:44:10 +03:00
alesapin
4014e0f08d Something very similar to working code 2020-10-14 15:32:35 +03:00
Alexander Tokmakov
72b1339656 Revert "Revert "Write structure of table functions to metadata""
This reverts commit c65d1e5c70.
2020-10-14 15:19:29 +03:00
tavplubix
c65d1e5c70
Revert "Write structure of table functions to metadata" 2020-10-14 13:59:29 +03:00
alesapin
efd3126b5d Moving pool 2020-10-14 10:22:48 +03:00
alexey-milovidov
f60ccb4edf
Merge pull request #14295 from ClickHouse/write_structure_of_table_functions
Write structure of table functions to metadata
2020-10-13 23:56:09 +03:00
Pavel Kruglov
44c2b138f3 Fix style 2020-10-13 22:53:36 +03:00
Pavel Kruglov
be0cb31d21 Add tests and comments 2020-10-13 21:55:03 +03:00
Pavel Kruglov
8200bab859 Add setting do_not_merge_across_partitions 2020-10-13 17:54:52 +03:00
alesapin
fd35368c59 First simple implementation 2020-10-13 17:25:42 +03:00
alesapin
dcf489ac8f Remove unused methods
(cherry picked from commit 77f5841a46)
2020-10-13 15:10:59 +03:00
alesapin
ef355e71d6 Buildable code 2020-10-13 15:10:46 +03:00
alesapin
48aaa0ce16 Split merge to separate method
(cherry picked from commit 14a7a25c4b)
2020-10-13 15:06:32 +03:00
alesapin
cb7db6d232 Split select and process merges
(cherry picked from commit 1889eb0ff1)
2020-10-13 15:04:16 +03:00
Nikita Mikhaylov
835c480056
Merge pull request #15858 from ClickHouse/fix_alter_default_validation
Fix alter default validation
2020-10-13 12:47:18 +03:00
tavplubix
6c1d59cd49
Merge pull request #15743 from azat/Atomic-DROP-TABLE-hang-fix
Fix DROP TABLE hangs with Atomic engine
2020-10-13 12:40:36 +03:00
alesapin
321a7ae6bf
Merge pull request #15852 from ClickHouse/fix_reverse_processor
Fix block structure mismatch after ALTER
2020-10-13 09:49:26 +03:00
Amos Bird
ca7a5ccd0d
More resize 2020-10-13 09:56:35 +08:00
Azat Khuzhin
bba44d0f0e Add IF EXISTS for removing inner table of the materialized view
Instead of playing with has_inner_table flag, which looks a bit icky.
2020-10-12 21:46:07 +03:00
Azat Khuzhin
d16adddb41 Fix drop of materialized view with inner table in Atomic database
Materialized view drop the inner table (if any) drop the drop() method,
and this will lead to essure recursive drop() from the drop worker
thread, which will hang:

    3  std::__1::condition_variable::wait<> ()
    4  DB::DatabaseCatalog::waitTableFinallyDropped (this=0x7ffff7831500, uuid=...) at ../src/Interpreters/DatabaseCatalog.cpp:828
    5  DB::InterpreterDropQuery::executeToTable (this=this@entry=0x7fff16ff88a0, table_id_=..., query=...) at ../src/Interpreters/InterpreterDropQuery.cpp:135
    6  DB::InterpreterDropQuery::execute (this=this@entry=0x7fff16ff88a0) at ../contrib/libcxx/include/string:1474
    7  DB::executeDropQuery (kind=kind@entry=DB::ASTDropQuery::Drop, global_context=..., target_table_id=...) at ../src/Storages/StorageMaterializedView.cpp:156
    8  DB::StorageMaterializedView::drop (this=0x7ffefc348f40) at ../src/Storages/StorageMaterializedView.cpp:169
    9  DB::DatabaseCatalog::dropTableFinally (this=this@entry=0x7ffff7831500, table=...) at ../src/Interpreters/DatabaseCatalog.cpp:775
    10 DB::DatabaseCatalog::dropTableDataTask (this=0x7ffff7831500) at ../src/Interpreters/DatabaseCatalog.cpp:745

Fix this by dropping the inner table just before scheduling job the the
drop worker thread.
2020-10-12 21:46:07 +03:00
Alexander Kuzmenkov
6200433e12 Merge origin/master into tmp (using imerge) 2020-10-12 21:15:31 +03:00
Mikhail Filimonov
87a8ba63f7
Few more CR fixes 2020-10-12 15:05:40 +02:00
tavplubix
748b75ab1b
Merge pull request #15767 from ClickHouse/fix_materialize_mysql_count_v2
Try fix select count() for MaterializeMySQL (another way)
2020-10-12 14:41:38 +03:00
Nikolai Kochetov
2a62a91af4
Merge pull request #15662 from ClickHouse/fix-15529
Fix read from Buffer table with empty nested table with different types.
2020-10-12 14:12:11 +03:00
alesapin
6732e5c217 Fix alter default validation 2020-10-12 14:02:35 +03:00
Nikolai Kochetov
7e58f99f64 Merge branch 'master' into storage-read-query-plan 2020-10-12 13:12:39 +03:00
Amos Bird
47fcd8bffb
Fix some problems introduced by refactoring. 2020-10-12 17:58:09 +08:00
Amos Bird
d2dcfc3f0d
Refactor processors. 2020-10-12 17:30:05 +08:00
alesapin
5b5dd4fb28 Fix order by desc after alter 2020-10-12 11:28:47 +03:00
Mikhail Filimonov
f6b00f2cb6
After CR fixes 2020-10-12 07:52:09 +02:00
Mikhail Filimonov
6df42c580b
ProtobufSingle output format 2020-10-12 07:51:45 +02:00
alexey-milovidov
10e9d14466
Merge pull request #15818 from ClickHouse/style-pragma-once
Check for #pragma once in headers
2020-10-11 13:14:09 +03:00
alexey-milovidov
1187903b44
Merge pull request #15813 from ClickHouse/remove-useless-metrics
Remove useless metrics to avoid confusion
2020-10-11 01:11:17 +03:00
Alexey Milovidov
269b6383f5 Check for #pragma once in headers 2020-10-10 21:37:02 +03:00
Alexey Milovidov
5b482f4191 Cleanups 2020-10-10 19:31:10 +03:00
Alexey Milovidov
06fcf437fe Addition to prev. revision 2020-10-10 19:02:13 +03:00
Alexey Milovidov
9f15daf45c Remove useless metrics to avoid confusion 2020-10-10 18:52:44 +03:00
robot-clickhouse
554fa482e6 Auto version update to [20.11.1.1] [54442] 2020-10-10 18:39:58 +03:00
Nikolai Kochetov
76a04fb4b4
Merge pull request #15762 from ClickHouse/new-block-for-functions
Use `ColumnsWithTypeAndName` instead of `Block` for function calls
2020-10-10 08:50:38 +03:00
Nikita Mikhaylov
6ac5431804
Merge pull request #15783 from nikitamikhaylov/copier-backquotes
Merging  #14939
2020-10-10 02:32:27 +03:00
alexey-milovidov
0fd007ad9e
Merge pull request #15601 from alexelex/alexelex-master
Improvement of Quorum Inserts in ClickHouse
2020-10-09 22:43:53 +03:00
alesapin
35165c8ea4
Merge pull request #15756 from CurtizJ/fix-prewhere-with-virtuals
Fix prewhere with virtual columns
2020-10-09 18:07:41 +03:00
nikitamikhaylov
88a5302759 Merge branch 'master' of github.com:ClickHouse/ClickHouse into copier-backquotes 2020-10-09 16:26:31 +03:00
Alexandra Latysheva
f6f33168aa fix compilation error 2020-10-09 12:11:21 +00:00
Alexandra Latysheva
0594a77b57 fix thread restart for parallel quorum inserts 2020-10-09 11:20:20 +00:00
Nikolai Kochetov
a7fb2e38a5 Use ColumnWithTypeAndName as function argument instead of Block. 2020-10-09 10:41:28 +03:00
Alexander Tokmakov
a6178cc876 try fix select count() for MaterializeMySQL 2020-10-08 23:39:24 +03:00
tavplubix
7b5f2b2bb0
Merge pull request #15701 from ClickHouse/better_clone_replica
Improvements in lost replica recovery
2020-10-08 23:19:23 +03:00
Alexandra Latysheva
6877f4aa9c for parallel and non-parallel quorum insertion at the same time 2020-10-08 15:35:41 +00:00
tavplubix
6065a5b65c
Update StorageReplicatedMergeTree.cpp 2020-10-08 16:37:32 +03:00
Anton Popov
1a6d2bc538 fix prewhere with virtuals columns 2020-10-08 15:59:47 +03:00
Pervakov Grigorii
3a2068f19d Use tmp disk for vertical merge files 2020-10-08 13:49:41 +03:00
alexey-milovidov
c0cb18b445
Merge pull request #15740 from azat/kafka-memory-accounting
Take memory allocations from librdkafka threads into account
2020-10-08 13:12:54 +03:00
Amos Bird
867216103f
Extend trivial count optimization. 2020-10-08 18:08:17 +08:00
Azat Khuzhin
1f51de362f Take memory allocations from librdkafka threads into account 2020-10-07 23:18:20 +03:00
alexey-milovidov
e465ce3d49
Merge pull request #15642 from azat/force_data_skipping_indices
Implement force_data_skipping_indices setting
2020-10-07 23:14:51 +03:00
Alexander Tokmakov
ffb19fa4bc fix 2020-10-07 22:47:31 +03:00
Azat Khuzhin
3cd71f3357 Cleanup interceptors for librdkafka in StorageKafka
Wrap them into StorageKafkaInterceptors to allow access to private
fields and add logging inside interceptors if something fails.

This is also preparation for ThreadStatus interceptor.
2020-10-07 21:42:13 +03:00
Nikolai Kochetov
54e77e906e
Merge pull request #15717 from ClickHouse/fix-array-join-optimisation-for-mv
Fix array join optimisation for MV
2020-10-07 20:19:35 +03:00
Latysheva Alexandra
f43ad338ed
Merge pull request #12 from alexelex/quorum_inserts_2
style check
2020-10-07 18:56:14 +06:00
Alexandra Latysheva
8f8872dc42 style check 2020-10-07 12:24:46 +00:00
Latysheva Alexandra
6c26f77380
Merge pull request #11 from alexelex/quorum_inserts_2
changing the condition for updateQuorum, specialized it and reduced t…
2020-10-07 17:49:20 +06:00
Pavel Kovalenko
69c126f1f1 Possibility to move part to another disk/volume if first attempt was failed. 2020-10-07 14:35:28 +03:00
Alexandra Latysheva
a43cac2c1a changing the condition for updateQuorum, specialized it and reduced the number of calls to the zk 2020-10-07 11:28:48 +00:00
Nikolai Kochetov
7e02152b50 Merge branch 'master' into storage-read-query-plan 2020-10-07 14:27:21 +03:00
Nikolai Kochetov
c5cb05f5f3 Try fix tests. 2020-10-07 14:26:29 +03:00
tavplubix
041015545c
Merge pull request #15537 from ClickHouse/mutation_hangs_after_replace_partition
Fix mutation may hang after REPLACE/DROP PARTITION
2020-10-07 14:25:29 +03:00
Nikolai Kochetov
df02573c92 Fix ARRAY JOIN optimisation when reading from MV. 2020-10-07 13:11:58 +03:00
Nikolai Kochetov
5f7aeddfe5
Merge pull request #15682 from ClickHouse/akz/storage_memory_less_locks
Less locking in StorageMemory: totalRows + totalBytes
2020-10-07 12:59:20 +03:00
alexey-milovidov
e00961f882
Merge pull request #15657 from Jokser/disk-s3-write-error-handling
Proper error handling during insert into MergeTree with S3
2020-10-07 11:17:32 +03:00
Alexander Tokmakov
47e9fe9ff1 fix 2020-10-07 03:05:48 +03:00
Alexander Tokmakov
ea16370024 improvements in lost replica recovery 2020-10-07 02:29:33 +03:00
Azat Khuzhin
75e612fc16 Use full featured parser for force_data_skipping_indices 2020-10-07 01:44:14 +03:00
Azat Khuzhin
ef6d12967f Implement force_data_skipping_indices setting 2020-10-07 01:42:31 +03:00
Latysheva Alexandra
991e51a80e
Merge pull request #10 from alexelex/quorum_inserts_2
style check fix
2020-10-07 04:38:30 +06:00
Alexandra Latysheva
9077c92862 style check fix 2020-10-06 22:36:42 +00:00
Latysheva Alexandra
85bcc07c0b
Merge pull request #9 from alexelex/quorum_inserts_2
Quorum inserts [version 3]
2020-10-07 04:04:41 +06:00
Alexandra Latysheva
644091459f style fixes and remove small changes 2020-10-06 22:01:30 +00:00
Alexandra Latysheva
f549ecf9d1 insert_quorum_parallel: status nodes in /quorum/parallel and allow merges 2020-10-06 21:49:48 +00:00
Alexander Kazakov
cabab90ab2 Get back to moving args 2020-10-06 17:54:22 +03:00
Alexander Kazakov
ae2c106f94 Minor fixes 2020-10-06 17:04:08 +03:00
Alexander Kazakov
e54ff6e60a Lock-less totalRows/totalBytes + more clear postponed init 2020-10-06 16:45:17 +03:00
Pavel Kovalenko
69b4bc6f33 Proper error handling during insert into MergeTree with S3. 2020-10-06 12:38:00 +03:00
Nikolai Kochetov
7caf6da363 Fix build. 2020-10-06 11:56:21 +03:00
Nikolai Kochetov
8320efc189 Fix read from Buffer table with empty nested table with different types. 2020-10-06 11:24:12 +03:00
Nikolai Kochetov
d968f276b5 Fix buffer table. 2020-10-06 11:21:05 +03:00
Nikolai Kochetov
f9bf1e3406 Merge branch 'master' into storage-read-query-plan 2020-10-06 09:50:10 +03:00
Latysheva Alexandra
d495a2fb2d
Merge pull request #7 from alexelex/quorum_inserts_2
build checker fix (style) and change comments
2020-10-06 02:33:29 +06:00
Alexandra Latysheva
41e0148d72 build checker fix (style) and change comments 2020-10-05 20:30:50 +00:00
Alexander Tokmakov
418766e92b fix another bug in mutations 2020-10-05 22:16:28 +03:00
Latysheva Alexandra
3b952aff7d
Merge pull request #6 from alexelex/quorum_inserts_2
fix test_00814
2020-10-05 23:01:18 +06:00
Alexandra Latysheva
2be62bbd1b fix test_00814 2020-10-05 16:58:26 +00:00
alesapin
8ec58c17f3 More consistent metadata usage 2020-10-05 19:41:46 +03:00
Alexander Tokmakov
30a18f7567 make it better 2020-10-05 16:52:03 +03:00
Latysheva Alexandra
18007622a1
Merge pull request #5 from alexelex/quorum_inserts_2
style check fix
2020-10-05 19:00:39 +06:00
Alexandra Latysheva
aa391a47eb style check fix 2020-10-05 12:59:07 +00:00
Latysheva Alexandra
7e7cedd73f
Merge pull request #4 from alexelex/quorum_inserts_2
style check fix
2020-10-05 16:43:14 +06:00
Alexandra Latysheva
0662432c5c style check 2020-10-05 10:41:49 +00:00
Latysheva Alexandra
a63084adaf
Merge pull request #3 from alexelex/quorum_inserts_2
Quorum inserts 2
2020-10-05 03:28:58 +06:00
Alexandra Latysheva
d54b6c9542 add question in comments 2020-10-04 20:32:08 +00:00
Alexandra Latysheva
ff8cbe6745 remove debug things 2020-10-04 20:19:05 +00:00
Alexandra Latysheva
8263e62298 working copy (with some debug info) 2020-10-04 19:55:39 +00:00
alexey-milovidov
53ce5e3892
Merge pull request #15551 from azat/for-user-limits-over-distributed
Pass through *_for_user settings via Distributed with cluster-secure
2020-10-04 04:18:20 +03:00
alexey-milovidov
9551562889
Merge pull request #15442 from ClickHouse/add_alter_version
Add ability to alter version column in VersionedCollapsingMergeTree.
2020-10-03 05:40:15 +03:00
Azat Khuzhin
f25c1742b8 Pass through *_for_user settings via Distributed with cluster-secure
In cluster-secure case the user on shards (remote) is equal to the user
on the initiator, so those settings can be safely applied.
2020-10-03 02:04:47 +03:00
Azat Khuzhin
b838214a35 Pass non-const SelectQueryInfo (and drop mutable qualifiers) 2020-10-02 22:42:35 +03:00
Azat Khuzhin
587cde853e Avoid skipping unused shards twice (for query processing stage and read itself) 2020-10-02 22:42:09 +03:00
alesapin
77c9f7af79
Merge pull request #15532 from ClickHouse/substitute_defaults_recursively
Fix defaults substitution for absent columns which depend on other defaults
2020-10-02 21:42:01 +03:00
Alexander Tokmakov
6b2da861dc Merge branch 'master' into write_structure_of_table_functions 2020-10-02 20:46:58 +03:00
Azat Khuzhin
9cb3c743bd
Convert to python3 (#15007) 2020-10-02 19:54:07 +03:00
Azat Khuzhin
21deb6812c
Drop unused code for numeric_limits<int128> in MergeTreeDataSelectExecutor (#15519) 2020-10-02 16:46:20 +03:00
alesapin
17b86dec96 Recursive defaults 2020-10-02 15:38:50 +03:00
Alexander Kuzmenkov
a9a7b065a0 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-02 14:38:47 +03:00
Nikolai Kochetov
5ea4dc0850 Try fix tests. 2020-10-02 14:25:16 +03:00
Nikolai Kochetov
ea131989be Try fix test. 2020-10-01 21:47:20 +03:00
Nikolai Kochetov
ec64def384 Use QueryPlan while reading from MergeTree. 2020-10-01 20:34:22 +03:00
Nicolae Vartolomei
eb1d253355 Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it 2020-10-01 17:59:50 +01:00
Alexander Kuzmenkov
244687bfc1 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 18:41:48 +03:00
Nicolae Vartolomei
7197a0c803 Possibly fix the issue with quorum 2020-10-01 11:38:50 +01:00
alesapin
8bc9ede711 Fix clang tidy 2020-10-01 09:53:47 +03:00
alexey-milovidov
9808d0be81
Merge pull request #15376 from excitoon-favorites/fixs3storage
Fixed compression in S3 storage
2020-10-01 04:30:32 +03:00
Alexandra Latysheva
e89a56969f first part 2020-09-30 23:16:27 +00:00
Artem Zuikov
0ac18a382f
Fix JOIN with GROUP BY over StorageMerge (#15242) 2020-09-30 23:11:27 +03:00
alesapin
97c2579fb9 Use separate function 2020-09-30 22:50:23 +03:00
alesapin
ac9f0ff4da More strict check for version column 2020-09-30 22:44:35 +03:00
Nikolai Kochetov
2efde179e9 Merge branch 'master' into storage-read-query-plan 2020-09-30 15:23:46 +03:00
Nikolai Kochetov
5ac6bc071d QueryPlan for StorageBuffer and StorageMaterializedView read. 2020-09-30 15:22:57 +03:00
Nikolai Kochetov
576ffadb17 Fix explain for ISourceStep. 2020-09-30 15:22:30 +03:00
Vladimir Chebotarev
a38c7ff2a8 Somehow uncompressed PUT works and gzipped PUT doesn't, in S3 storage. 2020-09-30 15:04:42 +03:00
Vladimir Chebotarev
698768add0 Fixed format argument in S3 storage when compression method is selected. 2020-09-30 13:55:44 +03:00
alexey-milovidov
0c07c2d3a3
Merge pull request #15089 from ClickHouse/codecs_for_nested_types
Codecs for nested types
2020-09-30 07:18:19 +03:00
alexey-milovidov
412a54e356
Merge pull request #14693 from hustnn/zk_exist_fix2
Fix potential memory leak caused by zookeeper exist calling
2020-09-30 04:48:11 +03:00
alexey-milovidov
b6bccfc4f4
Merge pull request #14776 from Vxider/disable_set_and_join_persistency
Support memory only mode for StorageJoin and StorageSet.
2020-09-30 04:35:43 +03:00
alexey-milovidov
b658f348a7
Update MergeTreeDataPartWriterWide.cpp 2020-09-30 01:23:42 +03:00
alesapin
65a05a970d Better message on error 2020-09-29 15:07:01 +03:00
tavplubix
4578d89819
Merge pull request #15348 from ClickHouse/replicate_default_args
Continuation of #14791
2020-09-28 18:53:02 +03:00
Alexander Kuzmenkov
218d86de7e Merge remote-tracking branch 'origin/master' into tmp 2020-09-28 16:29:51 +03:00
Nikita Mikhaylov
a4832ed5ce
Merge branch 'master' into HyaZz-master 2020-09-28 13:55:45 +03:00
Nikita Mikhaylov
73573472e9
Merge pull request #15299 from CurtizJ/fix-mysql-hung
Fix hang of queries with a lot of subqueries to same mysql table
2020-09-28 12:51:35 +03:00
alesapin
bc662ac4e0
Merge pull request #15293 from amosbird/bc3
Replace useless multiset with unordered_set
2020-09-28 10:30:04 +03:00
hustnn
a7024134dd Merge remote-tracking branch 'upstream/master' into zk_exist_fix2 2020-09-28 14:44:55 +08:00
Alexander Tokmakov
b0d99217fb Merge branch 'master' into write_structure_of_table_functions 2020-09-27 14:26:47 +03:00
Alexander Tokmakov
34addcf61f add review suggestions 2020-09-26 22:18:28 +03:00
alesapin
59f2bbe2a3
Merge pull request #15304 from ClickHouse/fix_race_condition_on_rename
Fix race condition between write ahead log cleanup and rename
2020-09-26 10:43:26 +03:00
alexey-milovidov
d1fce06292
Merge pull request #15297 from hexiaoting/build_bugfix
fix build bug for merge_selector2.cpp
2020-09-26 07:32:33 +03:00
Nikolai Kochetov
dea90009e3 Fix build 2020-09-25 16:03:12 +03:00
Alexander Tokmakov
68669b8a92 Merge branch 'master' into replicate_default_args 2020-09-25 15:52:17 +03:00
alesapin
f5c38b34ae Fix race condition during write ahead log cleanup and rename 2020-09-25 15:07:38 +03:00
Anton Popov
085f63a9bf fix hang of queries with a lot of subqueries to same mysql table 2020-09-25 14:12:48 +03:00
tavplubix
b96157e32b
Merge branch 'master' into enable_atomic_database_by_default 2020-09-25 13:42:39 +03:00
hexiaoting
4666ae3211 fix build bug for merge_selector2.cpp 2020-09-25 17:59:19 +08:00
Amos Bird
81d08b59e5
Replace useless multiset with unordered_set 2020-09-25 16:38:09 +08:00
alexey-milovidov
13529265c4
Revert "Avoid deadlocks in Log/TinyLog" 2020-09-25 02:28:57 +03:00
Alexander Tokmakov
fb826557b7 Merge branch 'master' into enable_atomic_database_by_default 2020-09-25 02:04:01 +03:00
Alexander Kuzmenkov
813a876e93
Merge pull request #14962 from ClickHouse/log-avoid-deadlock
Avoid deadlocks in Log/TinyLog
2020-09-24 13:54:11 +03:00
alesapin
96c419974c Merge branch 'master' into codecs_for_nested_types 2020-09-24 10:28:20 +03:00
Alexander Tokmakov
f0f91f84af Merge branch 'master' into enable_atomic_database_by_default 2020-09-23 21:50:15 +03:00
alesapin
87b64baea5 Fix again 2020-09-23 16:21:06 +03:00
alesapin
f404925397 More optimal 2020-09-23 15:19:45 +03:00
alesapin
1eb8f0a495 Fix bug in storage buffer during alter 2020-09-23 15:06:54 +03:00
alesapin
74671c909c Merge branch 'master' into codecs_for_nested_types 2020-09-23 13:12:23 +03:00
alesapin
bb4b739f43 Fix PVS-Studio warning 2020-09-23 13:11:48 +03:00
Alexander Kuzmenkov
f6316e2612 Merge remote-tracking branch 'origin/master' into tmp 2020-09-23 11:53:13 +03:00
filimonov
cc24ef9f83
Better debug message from MergeTreeDataSelectExecutor
See #15168
2020-09-22 21:35:29 +02:00
Alexander Tokmakov
7fcf20e48c enable more tests 2020-09-22 17:29:09 +03:00
alesapin
7015f272e7 Better comment 2020-09-22 16:48:38 +03:00
Alexander Kuzmenkov
679c0988a5 Merge remote-tracking branch 'origin/master' into HEAD 2020-09-22 16:25:52 +03:00
Nikolai Kochetov
62ef40394a
Merge pull request #14856 from ClickHouse/query-plan-for-creating-sets
Query plan for creating sets
2020-09-22 16:19:20 +03:00
alesapin
fd394f699c Better comments 2020-09-22 15:49:55 +03:00
alesapin
96d06c6ae6 Less changes 2020-09-22 15:16:15 +03:00
Alexander Kuzmenkov
dde4cf70e1 Merge remote-tracking branch 'origin/master' into HEAD 2020-09-22 14:03:59 +03:00
Alexander Kuzmenkov
7b64ca33b1 Merge remote-tracking branch 'origin/master' into tmp 2020-09-22 14:02:20 +03:00
Alexander Kuzmenkov
bfc3be9e43 Merge remote-tracking branch 'origin/aku/tcp-versio' into tmp 2020-09-22 14:02:15 +03:00
hustnn
35f1db0043 Fix potential memory leak caused by zookeeper exist calling 2020-09-22 09:28:12 +08:00
Alexander Tokmakov
91cbd49e85 fix tests 2020-09-22 00:09:50 +03:00
Alexey Milovidov
1e65105b06 Merge branch 'master' into log-avoid-deadlock 2020-09-21 21:09:06 +03:00
alesapin
e87b961095 Trying to add same logic for compact parts 2020-09-21 20:35:09 +03:00
alesapin
fbd6f10ff7 Use default codec instead of throwing exception 2020-09-21 19:07:14 +03:00
alesapin
8517dda807 First working test 2020-09-21 17:47:10 +03:00
alesapin
4debccb7fe Almost working version 2020-09-21 17:22:13 +03:00
alesapin
a3e999784b Buildable code 2020-09-21 14:24:10 +03:00
Alexander Tokmakov
13e41cdd20 try enable atomic database by default 2020-09-21 13:55:34 +03:00
alesapin
387b97aba5 Merge branch 'master' into codecs_for_nested_types 2020-09-21 11:06:28 +03:00
alesapin
7fc5a2dae1 Some intermediate stage 2 2020-09-21 10:18:23 +03:00
alesapin
09f6a454ae Some intermediate stage 2020-09-21 10:17:58 +03:00
alexey-milovidov
3e0509af69
Merge pull request #13573 from amosbird/rms
specific ReplicatedMergeTree settings
2020-09-21 01:36:33 +03:00
alexey-milovidov
85483f8532
Merge pull request #14853 from ClickHouse/akz/optimized_index_binary_search
Optimized marks selection algorithm for continuous marks ranges
2020-09-20 19:48:45 +03:00
alexey-milovidov
f7cae4a57d
Merge pull request #14975 from ClickHouse/fix_merge_tree_settings_check
Fix check for merge tree settings sanity on server startup
2020-09-20 19:43:40 +03:00
alesapin
5ffee8808a
Alter remove column properties and TTLs (#14742) 2020-09-20 16:27:33 +03:00
philip.han
3122455b4d BloomFilter is used just in specific cases of indexof() 2020-09-20 19:04:33 +09:00
alexey-milovidov
1474b80ecc
Merge pull request #15008 from ClickHouse/clang-tidy-11-without-enabling
Fix terribly wrong code
2020-09-20 02:00:54 +03:00
alexey-milovidov
cd7354117c
Update StorageJoin.cpp 2020-09-19 19:38:36 +03:00
Alexander Tokmakov
de540c6955 minor fixes 2020-09-19 15:59:37 +03:00
Alexey Milovidov
76147cc0c1 Generate ya.make 2020-09-19 15:52:17 +03:00
Alexey Milovidov
3003ebabc2 Merge branch 'master' into Vxider-disable_set_and_join_persistency 2020-09-19 15:51:40 +03:00
alexey-milovidov
eb9ee723c3
Merge pull request #11913 from ClickHouse/compact-parts-by-default
Enable compact parts by default for small parts
2020-09-19 15:31:15 +03:00
Alexey Milovidov
4d06bc62b1 Allow concurrent reads while writing to TinyLog 2020-09-19 14:02:11 +03:00
Alexey Milovidov
111acdc63b Continuation 2020-09-19 14:02:11 +03:00
Alexey Milovidov
bc8fc3e280 Simplification 2020-09-19 14:02:11 +03:00
Alexey Milovidov
66ea3c0c43 Remove useless method 2020-09-19 14:02:11 +03:00
Alexey Milovidov
8193da847b Simplification 2020-09-19 14:02:11 +03:00
Alexey Milovidov
3bb0088c86 Whitespace 2020-09-19 14:02:11 +03:00
Alexey Milovidov
dc7e3b75d3 Whitespace 2020-09-19 14:02:11 +03:00
Alexey Milovidov
8a8284ce31 Avoid deadlocks in Log/TinyLog 2020-09-19 14:02:11 +03:00
alexey-milovidov
1fcebce926
Merge pull request #15000 from Jokser/disable-ttl-move-on-insert
Option to disable TTL move on data part insert
2020-09-19 13:45:02 +03:00
alexey-milovidov
3463d97f8c
Merge pull request #14973 from amosbird/bm2
Ignore key constraints when doing mutations.
2020-09-19 13:44:30 +03:00
Alexey Milovidov
ef5363b87f Fix terribly wrong code 2020-09-19 02:05:13 +03:00
alexey-milovidov
4e77c2e48e
Update MergeTreeDataMergerMutator.cpp 2020-09-19 01:29:31 +03:00
Alexey Milovidov
24b334258b Resolve review comment 2020-09-18 22:25:56 +03:00
Alexey Milovidov
e1ffa07a39 Resolve review comments 2020-09-18 22:08:53 +03:00
Alexey Milovidov
21ca9fce63 Merge branch 'master' into storages-small-improvements 2020-09-18 22:03:19 +03:00
alexey-milovidov
322e63971d
Update MergeTreeIndexConditionBloomFilter.cpp 2020-09-18 21:47:32 +03:00
Amos Bird
d842cb704f
Allow mutations to work with key constraints. 2020-09-19 02:40:02 +08:00
Alexander Tokmakov
1ca9a92b21 Merge branch 'master' into write_structure_of_table_functions 2020-09-18 21:09:23 +03:00
Pavel Kovalenko
da04a130ed Add option to disable ttl move on data part insert - minor fixes. 2020-09-18 20:45:30 +03:00
Pavel Kovalenko
6b4b5898a7 Renaming. 2020-09-18 18:41:14 +03:00
Pavel Kovalenko
0da19ab46d Add option to disable ttl move on data part insert 2020-09-18 18:30:00 +03:00
Nikolai Kochetov
b26f11c00c Support StorageDistributed::read for QueryPlan. 2020-09-18 17:16:53 +03:00
alesapin
e38b537017
Merge pull request #11684 from ClickHouse/manual-write-duplicate-parts-to-replicas
Don't ignore duplicate parts written to replicas
2020-09-18 16:50:00 +03:00
Alexander Kazakov
1ee2e3d2b3 Review fix 2020-09-18 16:03:48 +03:00
Vxider
c9249f77c7 rename persistency to persistent 2020-09-18 20:58:27 +08:00
Vxider
0c535062fc rename disable_persistency to persistency 2020-09-18 20:48:55 +08:00
Nikolai Kochetov
50674a320f Refactor IStorage::read with query plan. 2020-09-18 14:39:07 +03:00
alesapin
e96a3ac5f3 DataType in enumerate streams 2020-09-18 14:37:58 +03:00
Vitaly Baranov
f43714cd76
Merge pull request #14880 from vitlibar/fix-removing-live-view-after-watching
Fix removing a live view after watching and after timeout has passed.
2020-09-18 14:17:44 +03:00
Nikolai Kochetov
2491f0e1c5 Merge branch 'master' into storage-read-query-plan 2020-09-18 14:07:03 +03:00
Nikolai Kochetov
c7aff19937
Merge pull request #14221 from hagen1778/settings-leaf-limits
[settings]: introduce new query complexity settings for leaf-nodes
2020-09-18 14:05:10 +03:00
philip.han
cbedd44a60 Fix indexOf() to use BloomFilter 2020-09-18 17:43:07 +09:00
alesapin
96a693baec Better message 2020-09-18 10:46:23 +03:00
alesapin
e6914acb3b Fix check for merge tree settings on server startup 2020-09-18 10:44:17 +03:00
alesapin
3536ac1b17
Merge pull request #14926 from ClickHouse/better-drop-replicated-table
Better drop for Replicated tables
2020-09-18 09:51:39 +03:00
roman
ddca262fe6 fix review comments 2020-09-17 20:54:21 +01:00
Alexey Milovidov
7fb4dfea2c Small improvements for IStorage::rename 2020-09-17 22:50:43 +03:00
alesapin
447205c525 More comments 2020-09-17 22:30:45 +03:00
alesapin
dc677b93fb Comments and fix test 2020-09-17 22:30:17 +03:00
alexey-milovidov
7152fec241
Update JoinSettings.cpp 2020-09-17 21:24:14 +03:00
alesapin
b07c00ef7c Ugly, but probably working implementation 2020-09-17 18:33:50 +03:00
alexey-milovidov
84eece69ba
Merge pull request #14876 from amosbird/ns
Get rid of query settings after initialization.
2020-09-17 17:49:25 +03:00
Alexey Milovidov
c1e9ce2cf2 Remove questionable code 2020-09-17 17:38:06 +03:00
Alexander Kuzmenkov
fb64cf210a straighten the protocol version 2020-09-17 17:37:29 +03:00
Vitaly Baranov
3356d75b23
Merge pull request #13156 from azat/cluster-secure
Secure inter-cluster query execution (with initial_user as current query user) [v3]
2020-09-17 17:11:00 +03:00
alesapin
d09fd8ca8b Add comment 2020-09-17 17:01:17 +03:00
Nikolai Kochetov
0bf4e8e6e9 Support reading with QueryPlan for StorageView. 2020-09-17 16:22:24 +03:00
Alexander Kuzmenkov
a374541214 straighten the protocol version 2020-09-17 15:15:05 +03:00
alesapin
6601f4f786 Better errors, fix merge 2020-09-17 15:10:06 +03:00
alesapin
6c369c8dc6 Fix merge error 2020-09-17 15:01:03 +03:00
Alexey Milovidov
a5560cd62d Better drop replicated tables 2020-09-17 14:27:17 +03:00
alesapin
40b2f203b6 Merge branch 'master' into manual-write-duplicate-parts-to-replicas 2020-09-17 13:21:00 +03:00
roman
b41421cb1c [settings]: introduce new query complexity settings for leaf-nodes
The new setting should allow to control query complexity on leaf nodes
excluding the final merging stage on the root-node. For example, distributed
query that reads 1k rows from 5 shards will breach the `max_rows_to_read=5000`,
while effectively every shard reads only 1k rows. With setting `max_rows_to_read_leaf=1500`
this limit won't be reached and query will succeed since every shard reads
not more that ~1k rows.
2020-09-17 10:37:05 +01:00
Alexander Kuzmenkov
6217dd77b5 Merge remote-tracking branch 'origin/master' into tmp 2020-09-17 12:35:10 +03:00
alesapin
f104c382f8
Merge pull request #14887 from azat/StorageFile-write-to-fd
Fix SIGSEGV for an attempt to INSERT into StorageFile(fd)
2020-09-17 10:25:02 +03:00
alesapin
5f9e7ed169
Merge pull request #14834 from ClickHouse/fix_compression_codec_perf
Fix performance degradation during parts selection for merge
2020-09-17 10:09:41 +03:00
alesapin
73544a3781
Merge pull request #14845 from ClickHouse/fix_alias_array
Fix recursive column defaults
2020-09-17 10:02:39 +03:00
Azat Khuzhin
138e953429 Fix SIGSEGV for an attempt to INSERT into StorageFile(fd) 2020-09-17 01:26:34 +03:00
Anton Popov
8e9828d2ff Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-16 21:07:35 +03:00
Alexey Milovidov
26eb49b48d Fix typo 2020-09-16 20:02:55 +03:00
Amos Bird
96a202c0fb
Get rid of query settings after initialization. 2020-09-16 22:35:39 +08:00
alesapin
cbe85327e2 Check stack size 2020-09-16 16:24:07 +03:00
Vitaly Baranov
d99a011d07 Fix removing a live view after watching and after timeout has passed. 2020-09-16 15:53:58 +03:00
alesapin
97baa67f2b
Merge pull request #14839 from Jokser/distributed-storage-multiple-volumes
Don't throw exception if Distributed storage has multi-volume storage policy configuration
2020-09-16 10:13:14 +03:00
Nikolai Kochetov
13edfeea1f Fix build. 2020-09-15 20:23:49 +03:00
Nikolai Kochetov
e29f27e333
Merge pull request #14815 from ClickHouse/storage-read-query-plan
Return query plan from storage.
2020-09-15 18:34:11 +03:00
Vitaly Baranov
74d5b43fe6
Merge pull request #14828 from vitlibar/change-columns-of-system-user-directories
Add 'params' column to system.user_directories table.
2020-09-15 18:25:50 +03:00
Alexander Kazakov
7465e00163 Optimized marks selection algorithm for continuous marks ranges 2020-09-15 17:22:32 +03:00
alesapin
e20c54998c Better exception on non physical columns 2020-09-15 16:29:11 +03:00
Anton Popov
3e855daefd Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-15 15:31:29 +03:00
alesapin
8828a78174 Fix alias on default columns 2020-09-15 14:17:58 +03:00
Vxider
e136eba3f8 fix style check 2020-09-15 18:58:16 +08:00
Nikolai Kochetov
6eac433c55 Review fixes. 2020-09-15 13:40:39 +03:00
Artem Zuikov
51ba12c2c3
Try speedup build (#14809) 2020-09-15 12:55:57 +03:00
Nikolai Kochetov
c1f61984e5
Merge pull request #14513 from amosbird/mf1
Binary operator monotonicity
2020-09-15 12:45:23 +03:00