Commit Graph

37222 Commits

Author SHA1 Message Date
Azat Khuzhin
a15b2daf6d Do not shutdown global thread pool on exception
Otherwise GlobalThreadPool can be terminated (for example due to an
exception from the ParallelInputsHandler::onFinish/onFinishThread, from
ParallelAggregatingBlockInputStream::Handler::onFinish/onFinishThread,
since writeToTemporaryFile() can definitelly throw) and the server will
not accept new connections (or/and execute queries) anymore.

Here is possible stacktrace (it is a bit inaccurate, due to
optimizations I guess, and it had been obtained with the
DB::tryLogCurrentException() in the catch block of the
ThreadPoolImpl::worker()):

    2020.02.16 22:30:40.415246 [ 45909 ] {} <Error> ThreadPool: Unhandled exception in the ThreadPool(10000,1000,10000) the loop will be shutted down: Code: 241, e.displayText() = DB::Exception: Memory limit (total) exceeded: would use 279.40 GiB (attempt to allocate chunk of 4205536 bytes), maximum: 279.40 GiB, Stack trace (when copying this message, always include the lines below):

    1.  Common/Exception.cpp:35: DB::Exception::Exception(...)
    ...
    6.  Common/Allocator.h:102: void DB::PODArrayBase<8ul, 4096ul, Allocator<false, false>, 15ul, 16ul>::reserve<>(unsigned long) (.part.0)
    7.  Interpreters/Aggregator.cpp:1040: void DB::Aggregator::writeToTemporaryFileImpl<...>(...)
    8.  Interpreters/Aggregator.cpp:719: DB::Aggregator::writeToTemporaryFile(...)
    9.  include/memory:4206: DB::Aggregator::writeToTemporaryFile(...)
    10. DataStreams/ParallelInputsProcessor.h:223: DB::ParallelInputsProcessor<DB::ParallelAggregatingBlockInputStream::Handler>::thread(...)

Refs: https://github.com/ClickHouse/ClickHouse/issues/6833#issuecomment-579221732
(Reference to particular comment, since I'm not sure about the initial issue)
2020-03-15 13:13:10 +03:00
Azat Khuzhin
6969191c9f Call onException if ParallelInputsHandler::onFinish* throws 2020-03-15 13:13:10 +03:00
Ivan Blinkov
d64154d65e
Update meet-form.js 2020-03-15 10:44:57 +03:00
alexey-milovidov
f3f1208e06
Merge pull request #9667 from ClickHouse/fix-flacky-test-uniq-combined-memory-usage
Fix flacky test 01017_uniqCombined_memory_usage
2020-03-15 05:40:23 +03:00
alexey-milovidov
a4cc526133
Merge pull request #9065 from ClickHouse/split_databases_from_context
Split databases from Context
2020-03-15 03:42:57 +03:00
Alexey Milovidov
93ea73ae0f Fix flacky test 01017_uniqCombined_memory_usage #7236 2020-03-15 03:22:06 +03:00
Alexey Milovidov
00b7e2b659 Make unit test less flacky by allowing session expiration during the test 2020-03-15 02:59:39 +03:00
Alexey Milovidov
5673fcc44d Merge branch 'master' of github.com:yandex/ClickHouse 2020-03-15 02:39:53 +03:00
Alexey Milovidov
abd9802317 Slightly improve unit tests 2020-03-15 02:37:09 +03:00
alexey-milovidov
9e658d4541
Merge pull request #9602 from ClickHouse/common-prelimit-counter
Common prelimit counter
2020-03-15 02:24:07 +03:00
alexey-milovidov
fd2269c1a7
Merge pull request #9633 from Slach/docs/distributedconnectionfail
add DistributedConnectionFailAtAll, DistributedConnectionFailTry system.events description
2020-03-15 01:45:38 +03:00
alexey-milovidov
2086c96a54
Merge pull request #9634 from azat/client-no-cursor-restore-on-send_logs_level
Do not restore previous cursor if send_logs_level is used
2020-03-15 01:03:03 +03:00
alexey-milovidov
3ef1d40b97
Merge pull request #9636 from azat/fix-sum-remote
Fix various sum*() functions via remote() usage (incorrect function name)
2020-03-15 01:00:39 +03:00
alexey-milovidov
68074a1524
Merge pull request #9653 from ClickHouse/add_setting_for_path_format
Add setting for a new format of distributed parts
2020-03-15 00:40:33 +03:00
alexey-milovidov
6dbb6317b6
Merge pull request #9654 from ClickHouse/remove-nontrivial-global-variable
Remove global variable with nontrivial ctor/dtor
2020-03-14 23:14:24 +03:00
imgbot[bot]
f2d93351bd
[ImgBot] Optimize images (#9664)
*Total -- 36.24kb -> 36.11kb (0.36%)

/website/images/index/blog.svg -- 0.71kb -> 0.70kb (1.78%)
/website/images/index/stack-overflow.svg -- 0.76kb -> 0.75kb (1.28%)
/website/images/index/youtube.svg -- 0.48kb -> 0.47kb (1.02%)
/website/images/index/telegram.svg -- 1.18kb -> 1.18kb (0.58%)
/website/images/index/google-groups.svg -- 1.12kb -> 1.12kb (0.52%)
/website/images/index/meetup.svg -- 25.21kb -> 25.12kb (0.33%)
/website/images/index/twitter.svg -- 1.03kb -> 1.03kb (0.28%)
/website/images/index/github.svg -- 1.42kb -> 1.42kb (0.27%)
/website/images/clickhouse-black.svg -- 4.33kb -> 4.33kb (0.02%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-03-14 23:06:50 +03:00
Ivan Blinkov
1e8005ba53
Refactor contacts/community sections on website front page + css tuning (#9662) 2020-03-14 23:02:57 +03:00
Ivan Blinkov
4f09b20f9c
Create play-api.js 2020-03-14 23:01:50 +03:00
Ivan Blinkov
7812da3048
Create meet-form.js 2020-03-14 23:00:20 +03:00
Alexey Milovidov
065e95817b Added results for AMD Ryzen 2020-03-14 22:20:41 +03:00
Nikolai Kochetov
95c83ec95a Fix typo. 2020-03-14 17:51:32 +03:00
Anton Popov
71e86fc471
Merge pull request #9581 from excitoon-favorites/materializeinpartition
Added MATERIALIZE TTL IN PARTITION
2020-03-14 02:15:03 +03:00
Alexander Kuzmenkov
beac0769bc
github doesn't like cute animals in check status 2020-03-14 02:04:40 +03:00
imgbot[bot]
e99bbfa3d7
[ImgBot] Optimize images (#9661)
*Total -- 115.37kb -> 112.91kb (2.12%)

/website/images/index/hardware-efficient.jpg -- 111.04kb -> 108.59kb (2.21%)
/website/images/clickhouse-black.svg -- 4.33kb -> 4.33kb (0.02%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-03-14 01:21:39 +03:00
Ivan Blinkov
e8f62660fd
replace temporary image (#9660) 2020-03-14 01:17:47 +03:00
BayoNet
a4568b52e0
DOCS-511: Deleted some experimental settings. Removed duplicated description for join_any_take_last_row. (#9639)
* CLICKHOUSEDOCS-511: Removed obsolete settings.

* CLICKHOUSEDOCS-511: Removed duplication for ## join_use_nulls {#join_use_nulls}.

Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
2020-03-14 01:12:54 +03:00
imgbot[bot]
f32655d11d
[ImgBot] Optimize images (#9659)
/website/images/clickhouse-black.svg -- 4.33kb -> 4.33kb (0.02%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-03-14 00:46:45 +03:00
Ivan Blinkov
a809204f93
Update README.md 2020-03-14 00:45:33 +03:00
Ivan Blinkov
fb6e66bc10
[website] fix some image width (#9658) 2020-03-14 00:41:44 +03:00
imgbot[bot]
c9602a14cf
[ImgBot] Optimize images (#9657)
*Total -- 104.97kb -> 100.55kb (4.21%)

/website/images/index/hardware-efficient.jpg -- 100.64kb -> 96.22kb (4.39%)
/website/images/clickhouse-black.svg -- 4.33kb -> 4.33kb (0.02%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-03-13 23:37:11 +03:00
Ivan Blinkov
2b07e39d52
Temporary fix for too large image (#9656) 2020-03-13 23:12:31 +03:00
Alexey Milovidov
4d637aace5 Merge branch 'master' of github.com:yandex/ClickHouse 2020-03-13 23:07:07 +03:00
Alexey Milovidov
16be947390 Make test faster in debug + coverage mode 2020-03-13 23:06:55 +03:00
Alexander Tokmakov
99e0f7b10e fix 2020-03-13 23:00:54 +03:00
Alexander Tokmakov
729e4fc9fd fix 2020-03-13 22:46:16 +03:00
imgbot[bot]
ef59ba6748
[ImgBot] Optimize images (#9655)
*Total -- 2,575.47kb -> 2,539.36kb (1.4%)

/website/images/index/hardware-efficient.svg -- 2,506.04kb -> 2,470.13kb (1.43%)
/website/images/index/heart.svg -- 0.43kb -> 0.43kb (0.9%)
/website/images/dots.svg -- 5.09kb -> 5.04kb (0.81%)
/website/images/index/flash.svg -- 0.97kb -> 0.97kb (0.4%)
/website/images/index/intro.svg -- 49.28kb -> 49.14kb (0.29%)
/website/images/index/safe.svg -- 1.74kb -> 1.74kb (0.22%)
/website/images/curl.svg -- 1.41kb -> 1.41kb (0.21%)
/website/images/index/scale.svg -- 6.19kb -> 6.18kb (0.06%)
/website/images/clickhouse-black.svg -- 4.33kb -> 4.33kb (0.02%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>

Co-authored-by: ImgBotApp <ImgBotHelp@gmail.com>
2020-03-13 22:39:57 +03:00
Ivan Blinkov
d4cc635a4c
Major website front page refactoring (#9300) 2020-03-13 22:35:03 +03:00
alexey-milovidov
930f2bae54
Merge pull request #9611 from ClickHouse/aku/fix-some-perf-tests
Fix some performance tests
2020-03-13 22:30:26 +03:00
Alexey Milovidov
482915fa46 Fixed profile event name and description #9632 2020-03-13 22:00:00 +03:00
alexey-milovidov
b4315e24f6
Merge pull request #9632 from Slach/docs/add_networks_errors_description
add NetworkErrors metric description in system.events
2020-03-13 21:56:15 +03:00
alexey-milovidov
253cfb096c
Merge pull request #9640 from Slach/docs/replicapartialshutdown
add description for ReplicaPartialShutdown in system.events
2020-03-13 21:53:22 +03:00
alexey-milovidov
8e0cb6b641
Update ProfileEvents.cpp 2020-03-13 21:52:54 +03:00
alesapin
f6044c9c53 Add setting for a new format of distributed parts 2020-03-13 21:49:46 +03:00
Nikolai Kochetov
75fa33fa04 Try fix tests. 2020-03-13 21:43:21 +03:00
Alexey Milovidov
3f6fdc1ddb Remove global variable with nontrivial ctor/dtor 2020-03-13 21:42:19 +03:00
Alexey Milovidov
e3782d80e3 More issue templates 2020-03-13 20:52:09 +03:00
Alexey Milovidov
0a1b3e57a8 Renamed a file for consistency 2020-03-13 20:47:46 +03:00
Nikolai Kochetov
62e06c7813 Try fix tests. 2020-03-13 20:41:39 +03:00
alexey-milovidov
847ce93366
Merge pull request #9649 from abyss7/fix-apple-clang
Don't try to guess linker on non-Linux builds
2020-03-13 20:26:20 +03:00
alesapin
18bbe16aae Fix compatibility in replication 2020-03-13 20:23:36 +03:00