Commit Graph

112279 Commits

Author SHA1 Message Date
Azat Khuzhin
c332d290d8 Keep only one throttler for BACKUPs IO (instead of separate read/write)
There is no need in separate read/write throttling, because you cannot
write faster then read anyway, and plus this makes the code less cleaner

(and also it will allow avoid implementing throttling backups to S3,
since it does not use common S3 writer).

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:40:17 +02:00
Azat Khuzhin
218b1f9c29 Add ability to throttle BACKUPs on per-server/backup basis
Server settings:
- backup_read_bandwidth_for_server
- backup_write_bandwidth_for_server

Query settings:
- backup_read_bandwidth
- backup_write_bandwidth

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:48 +02:00
Azat Khuzhin
a25dd1d348 Add ability to throttle local IO on per-query/server basis
Server settings:
- max_local_read_bandwidth_for_server
- max_local_write_bandwidth_for_server

Query settings:
- max_local_read_bandwidth
- max_local_write_bandwidth

This is the preparation for adding ability to throttle BACKUPs

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
Azat Khuzhin
b3406beeb7 Add per-query network throttling
Controlled with:
- max_remote_read_network_bandwidth
- max_remote_write_network_bandwidth

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
Azat Khuzhin
abdb682048 Move some methods for Context into module part
This will be required later, for per-query bandwidth limiting.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
Azat Khuzhin
40cb87c2ac Make remote bandwidth settings server settings
Right now those two settings are applied only at start:
- max_remote_read_network_bandwidth_for_server
- max_remote_write_network_bandwidth_for_server

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-05 09:39:15 +02:00
robot-clickhouse-ci-1
fb3af065f4
Merge pull request #48294 from ClickHouse/update-arrow-2
Try to update arrow library to release 11.0.0
2023-04-05 04:43:51 +02:00
Rich Raposa
25be18c83d
Merge pull request #48408 from ClickHouse/serxa-patch-3
doc entry for SYSTEM WAIT LOADING PARTS
2023-04-04 19:02:36 -06:00
Alexander Tokmakov
baed245710
Merge pull request #48409 from ClickHouse/better_ci_bot
Make CI slack bot less noisy
2023-04-05 03:28:18 +03:00
Alexander Tokmakov
e2679ccb53 make CI slack bot less noisy 2023-04-05 02:16:03 +02:00
Sergei Trifonov
1bea16ea63
doc entry for SYSTEM WAIT LOADING PARTS 2023-04-05 01:34:25 +02:00
FFFFFFFHHHHHHH
6e8f77ee9c
Add statistical aggregate function kolmogorovSmirnovTest (#48325) 2023-04-05 01:18:54 +02:00
Boris Kuschel
76738017a8
Fix krb5 with openssl 2023-04-04 15:28:40 -07:00
Anton Popov
10d2b1330b add perf test 2023-04-04 21:29:52 +00:00
Robert Schulze
db864891f8
Merge pull request #47610 from murfel/format-hiliting-fix
Fix minor hiliting issues in clickhouse-format
2023-04-04 22:59:46 +02:00
robot-ch-test-poll
5eb5978813
Merge pull request #48360 from ClickHouse/fix-explain-with-changed-column-names-analyzer
Fix tests with explain and analyzer where names changed.
2023-04-04 22:10:10 +02:00
Dmitry Novik
673413dc9f
Merge pull request #48355 from ClickHouse/lambda-type-resolution
Fix lambda type resolution
2023-04-04 22:07:57 +02:00
Igor Nikonov
0ff4e70c84 Fix 02579_fill_empty_chunk.sql 2023-04-04 19:11:08 +00:00
Alexander Tokmakov
ba65be22da fix bad error messages 2023-04-04 20:21:22 +02:00
Vitaly Baranov
d73df94a56
Update test.py 2023-04-04 20:20:46 +02:00
vdimir
5966281f7c
Test WriteBufferToFileSegment with several threads 2023-04-04 18:15:27 +00:00
vdimir
61c8a9586e
Fix usage of is_unbound in FileSegment 2023-04-04 18:14:54 +00:00
Alexander Tokmakov
f5574d0d74 find big allocations without limits checks 2023-04-04 20:10:22 +02:00
Smita Kulkarni
a36b81a22d Fixed comment 2023-04-04 19:07:31 +02:00
Smita Kulkarni
f4e2d45fbc Added check for backup/restore when they fail and status is not COMPLETED 2023-04-04 19:05:27 +02:00
Igor Nikonov
078ebff92a Disable debug logging 2023-04-04 17:02:53 +00:00
Smita Kulkarni
beb164dd51 Merge branch 'master' into Backup_Restore_concurrency_check_node_2 2023-04-04 18:51:30 +02:00
Igor Nikonov
2bf2764898 Fix typo 2023-04-04 16:43:48 +00:00
Igor Nikonov
1fb0292fcb polishing 2023-04-04 16:13:21 +00:00
Nikita Mikhaylov
fa5b2bd4a5
Added Keeper retries for backups operations (#47224) 2023-04-04 18:12:08 +02:00
Robert Schulze
9399a628dc
Cleanup mess in .clang-tidy
This fixes some mess I left in .clang-tidy (#43863) when clang-tidy
build times were too bad and had to be reduced urgently.

Verified locally that runtime isn't affected by this PR.
2023-04-04 16:07:02 +00:00
Igor Nikonov
5a9acac12f Clarification and cleanup 2023-04-04 16:00:09 +00:00
Azat Khuzhin
9235d1cde2 Fix system.query_views_log for MVs that are pushed from background threads
Some of such places:
- push from Buffer
- push from Distributed sends
- system.*_log workers

Before #47564 it simply does not work, but after it throws LOGICAL_ERROR
in such situation.

v2: remove expired() check after #46709 got merged
v3: use ThreadGroupStatus ctor with ContextPtr (after #47564)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-04 17:43:10 +02:00
vdimir
50c8472c57
Reset downloader in WriteBufferToFileSegment::nextImpl 2023-04-04 15:39:25 +00:00
Robert Schulze
e031783ae5
More CMake fixes 2023-04-04 15:39:16 +00:00
Mikhail f. Shiryaev
5bcbdc958a
Reduce probability of reusing the same port 2023-04-04 17:18:24 +02:00
Azat Khuzhin
353434f8f1 Fix possible SYSTEM SYNC REPLICA stuck in case of DROP/REPLACE PARTITION
In case of DROP/REPLACE PARTITION the entries from the queue will be
removed without notifying the subscribes.

CI: https://s3.amazonaws.com/clickhouse-test-reports/48242/4a315cd0d17bc12edd934fd25663b0119880f207/stress_test__asan_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-04-04 17:16:04 +02:00
natasha
c3acaecce6 fix style - missed tab 2023-04-04 16:04:33 +01:00
natasha
647fb63b83 rm unneeded parentheses 2023-04-04 16:01:15 +01:00
Mikhail f. Shiryaev
a42af5e4ac
Simplify get_free_port helper function 2023-04-04 16:56:42 +02:00
natasha
a1d3ea92b9 Merge remote-tracking branch 'origin/master' into format-hiliting-fix 2023-04-04 15:55:40 +01:00
natasha
95d77193af add comment re excessive copying in are_equal_with_hilites_removed 2023-04-04 15:54:42 +01:00
natasha
46691ef705 add check that all strings end without any hilite 2023-04-04 15:51:12 +01:00
avogar
04be32216a Allow write/read unnamed tuple as nested Message in Protobuf format 2023-04-04 14:47:37 +00:00
Kruglov Pavel
20278ef711
Update test 2023-04-04 16:44:52 +02:00
vdimir
999a3889d0
Revert "Reset downloader for cache file segment in TemporaryFileStream"
This reverts commit 07147771e6.
2023-04-04 14:22:33 +00:00
natasha
a1d718c601 update docstring for consume_hilites 2023-04-04 15:12:52 +01:00
Kruglov Pavel
fad053c4fe
Make better 2023-04-04 16:10:47 +02:00
Kruglov Pavel
a3ef50c2c0
Update src/Processors/Formats/Impl/ArrowColumnToCHColumn.cpp 2023-04-04 16:06:21 +02:00
natasha
cba124f99c fix while in consume_hilites 2023-04-04 15:04:50 +01:00