Commit Graph

13226 Commits

Author SHA1 Message Date
proller
de2b740db7 USE_INTERNAL_CONSISTENT_HASHING_LIBRARY 2018-08-30 22:07:24 +03:00
Alexey Milovidov
6ccd74aeeb Attempt to fix performance regression due to usage of taskstats #2482 2018-08-30 21:48:41 +03:00
proller
48766c1c2d split libconsistent-hashing 2018-08-30 21:44:46 +03:00
Alexey Milovidov
c06d6b7ae6 Moved file (preparation) #2482 2018-08-30 21:40:46 +03:00
Alexey Milovidov
fd5c419f17 Miscellaneous #2482 2018-08-30 21:36:24 +03:00
proller
81960a2690 CLICKHOUSE-3940 Fix crash on join 2018-08-30 18:44:30 +03:00
VadimPE
5551f2902c CLICKHOUSE-1660 2018-08-30 15:32:11 +03:00
alexey-milovidov
b05c62be9f
Merge pull request #2994 from CurtizJ/CLICKHOUSE-3935
ClickHouse-3935  Fix bug with qualified columns in where clause
2018-08-30 15:01:47 +03:00
alexey-milovidov
992aee9c2c
Update 00702_where_with_quailified_names.sql 2018-08-30 15:01:34 +03:00
CurtizJ
c818683ce7 update test 2018-08-30 14:48:58 +03:00
alexey-milovidov
ba3a20073c
Merge pull request #2988 from VadimPE/test_recovery_replica
add integration test for recovery replica
2018-08-30 14:20:10 +03:00
alexey-milovidov
2e22a14c5c
Merge pull request #2997 from VadimPE/fix_exception_message
Fix error message in exception message for DROP TABLE/PARTITION
2018-08-30 14:19:58 +03:00
chertus
409562a397 decimal: add test for input/output formats CLICKHOUSE-3765 2018-08-30 14:17:02 +03:00
VadimPE
81893ae577 Fix error message 2018-08-30 12:33:31 +03:00
robot-clickhouse
8125bd3df9 Auto version update to [18.12.0] [54407] 2018-08-30 03:23:20 +03:00
CurtizJ
764aa70d04 fix bug with quailified columns in where clause 2018-08-30 01:09:04 +03:00
CurtizJ
b43d403815 Revert "fix bug with quailified columns in where clause"
This reverts commit e007fd2b9e.
2018-08-30 01:04:45 +03:00
proller
56e571f18d odbc-bridge fixes (#2993)
* start clickhouse odbc-bridge as clickhouse-odbc-bridge

* fix

* prepare to odbc bridge tests
2018-08-30 00:32:46 +03:00
Alexey Milovidov
48cbf9de3c Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-30 00:30:49 +03:00
Alexey Milovidov
c94e0f0161 Fixed tests in Sandbox [#CLICKHOUSE-2] 2018-08-30 00:30:39 +03:00
proller
0f16160cb7 stderr.log fixes 2018-08-29 22:52:04 +03:00
CurtizJ
e007fd2b9e fix bug with quailified columns in where clause 2018-08-29 22:45:29 +03:00
Alexey Milovidov
26b5b52c24 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-29 22:01:14 +03:00
Alexey Milovidov
c34d36bf35 Fixed tests in Sandbox [#CLICKHOUSE-2] 2018-08-29 22:01:01 +03:00
proller
4529f33457 Fix clickhouse-test-server
rename /var/log/clickhouse-server/stderr to stderr.log and stdout to stdout.log
2018-08-29 21:48:14 +03:00
chertus
29d8d07975 decimal improvements [CLICKHOUSE-3765] 2018-08-29 21:47:19 +03:00
alexey-milovidov
794b4d30a8
Merge pull request #2989 from yandex/fix-context-lifetime-try-2-quick
Fix lifetime of Context reference in functions (first quick variant) …
2018-08-29 21:32:48 +03:00
alexey-milovidov
07408490b6
Merge pull request #2982 from VadimPE/CLICKHOUSE-3934
CLICKHOUSE-3934 add join_default_strictness
2018-08-29 21:32:03 +03:00
alexey-milovidov
b99bf0c558
Update Settings.h 2018-08-29 21:27:41 +03:00
Vadim
59e494a78d
Update 00701_join_default_strictness.reference 2018-08-29 19:48:09 +03:00
Vadim
b0f66d15d2
Update 00701_join_default_strictness.sql 2018-08-29 19:42:45 +03:00
Alexey Milovidov
48db3d4df8 Added test #2989 2018-08-29 19:27:29 +03:00
Alexey Milovidov
3361247126 Fix lifetime of Context reference in functions (first quick variant) [#CLICKHOUSE-2] 2018-08-29 18:36:24 +03:00
Alexey Milovidov
4ebfaa768e Miscellaneous [#CLICKHOUSE-2] 2018-08-29 18:16:34 +03:00
VadimPE
f253719eac CLICKHOUSE-3934 add SettingsJoinStrictness 2018-08-29 18:15:42 +03:00
Alexey Milovidov
697067f207 Fix lifetime of Context reference in functions (first quick variant) [#CLICKHOUSE-2] 2018-08-29 17:59:08 +03:00
Alexey Milovidov
87dfd8e47e Removed useless field #2447 2018-08-29 17:55:28 +03:00
VadimPE
5c370143c4 CLICKHOUSE-3847 fix time for cleanupthread and sleep() 2018-08-29 17:13:20 +03:00
VadimPE
a90a9af818 CLICKHOUSE-3847 fix time for cleanup_delay_period 2018-08-29 17:03:39 +03:00
VadimPE
d626ae11a7 CLICKHOUSE-3934 2018-08-29 16:54:43 +03:00
Vadim Plakhtinskiy
f0c16900aa CLICKHOUSE-3934 fix bug with CROSS JOIN 2018-08-29 16:51:07 +03:00
VadimPE
8c10c11804 CLICLKHOUSE-3847 add test 2018-08-29 16:47:48 +03:00
chertus
7bac9698f6 fix build 2018-08-29 16:24:33 +03:00
chertus
9becb21e52 better comments for IColumn [CLICKHOUSE-2] 2018-08-29 15:10:18 +03:00
chertus
a69c936b44 improve field visitors for UUID CLICKHOUSE-3249 2018-08-29 14:58:40 +03:00
VadimPE
a569d88e6a CLICKHOUSE-3847 add test 2018-08-29 13:04:41 +03:00
Amos Bird
8851fbcab2 Padding for IO buffers.
Testing data

```
select 'aaaaaaaa','bbbbbbbb','cccccccc','dddddddd','eeeeeeee','ffffffff','gggg','hhh' from numbers(3000000) into outfile '/tmp/test.tsv'
```

Testing command
```
echo "select count() from file('/tmp/test.tsv', CSV, 'a String, b String, c String, d String, e String, f String, g String, h String') where not ignore(e)" | clickhouse-benchmark
```

TSV parser has less overhead than CSV, using it would better unveil the benefits of memcpySmall.

Before
```
QPS: 1.662, RPS: 4985463.906, MiB/s: 603.823, result RPS: 1.662, result MiB/s: 0.000.
0.000%  0.559 sec.
10.000% 0.564 sec.
20.000% 0.568 sec.
30.000% 0.572 sec.
40.000% 0.575 sec.
50.000% 0.581 sec.
60.000% 0.592 sec.
70.000% 0.624 sec.
80.000% 0.639 sec.
90.000% 0.664 sec.
95.000% 0.686 sec.
99.000% 0.711 sec.
99.900% 0.715 sec.
99.990% 0.716 sec.
```

After
```
QPS: 1.861, RPS: 5582303.107, MiB/s: 676.110, result RPS: 1.861, result MiB/s: 0.000.
0.000%  0.510 sec.
10.000% 0.514 sec.
20.000% 0.517 sec.
30.000% 0.521 sec.
40.000% 0.523 sec.
50.000% 0.527 sec.
60.000% 0.530 sec.
70.000% 0.539 sec.
80.000% 0.558 sec.
90.000% 0.584 sec.
95.000% 0.589 sec.
99.000% 0.608 sec.
99.900% 0.655 sec.
99.990% 0.663 sec.
```
2018-08-29 09:39:44 +08:00
alexey-milovidov
a5d7097c08
Merge pull request #2977 from amosbird/sse2csv
Enable sse2 for CSV parsing.
2018-08-29 03:04:17 +03:00
proller
e30d93a0f2 Better debug helpers (#2983)
* Better debug helpers

* fix
2018-08-29 03:03:07 +03:00
alexey-milovidov
f3b2cf6c11
Merge pull request #2985 from 4ertus2/uuid
field visitors for UUID CLICKHOUSE-3249
2018-08-29 03:02:25 +03:00
Alexey Milovidov
783fc4de27 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-28 23:39:28 +03:00
Alexey Milovidov
2581d88f0e Better error message: avoid confusion when column is named a [#CLICKHOUSE-3] 2018-08-28 23:39:18 +03:00
proller
18044995ba Fix includes 2018-08-28 22:36:27 +03:00
chertus
6a02b18b93 field visitors for UUID CLICKHOUSE-3249 2018-08-28 21:36:41 +03:00
Alexey Milovidov
f45afa37a8 Miscellaneous [#CLICKHOUSE-3] 2018-08-28 21:25:40 +03:00
Vadim
2bab5f941d
Update 00701_join_default_strictness.sql 2018-08-28 17:58:08 +03:00
Vadim
6a3d398a26
Update 00701_join_default_strictness.reference 2018-08-28 17:57:44 +03:00
Vadim
9a0802f5bd
fix documentation 2018-08-28 17:52:27 +03:00
Vadim
98abde8480
Update ExpressionAnalyzer.cpp 2018-08-28 17:41:15 +03:00
Vadim
096b5e6a9d
Update ExpressionAnalyzer.cpp 2018-08-28 17:40:07 +03:00
Vadim
564ddbf8d8
Update ExpressionAnalyzer.cpp 2018-08-28 17:33:57 +03:00
VadimPE
139f855230 CLICKHOUSE-3934 add tests 2018-08-28 17:26:12 +03:00
Vadim
a8c1199ad4
Merge branch 'master' into CLICKHOUSE-3934 2018-08-28 17:06:17 +03:00
chertus
86dd83d012 fix use of broken context in decimal arithm/comparison 2018-08-28 16:59:52 +03:00
VadimPE
398d38eead CLICKHOUSE-3934 add join_default_strictness 2018-08-28 16:57:31 +03:00
Amos Bird
4ae8721a82
ill formated #else breaks client history 2018-08-28 20:05:27 +08:00
proller
c219562b32 Better clickhouse-test-server 2018-08-28 14:57:35 +03:00
Amos Bird
8d6a26b8df Enable sse2 for CSV parsing.
Testing data

```
select 'aaaaaaaa,bbbbbbbb,cccccccc,dddddddd,eeeeeeee,ffffffff,gggg,hhh' from numbers(3000000) into outfile '/tmp/test.csv'
```

Testing command
```
echo "select count() from file('/tmp/test.csv', CSV, 'a String, b String, c String, d String, e String, f String, g String, h String') where not ignore(e)" | clickhouse-benchmark

```

Before
```
QPS: 1.317, RPS: 3949749.687, MiB/s: 478.380, result RPS: 1.317, result MiB/s: 0.000.
0.000%  0.704 sec.
10.000% 0.712 sec.
20.000% 0.718 sec.
30.000% 0.726 sec.
40.000% 0.739 sec.
50.000% 0.754 sec.
60.000% 0.770 sec.
70.000% 0.788 sec.
80.000% 0.798 sec.
90.000% 0.815 sec.
95.000% 0.826 sec.
99.000% 0.850 sec.
99.900% 0.857 sec.
99.990% 0.858 sec.
```

After
```
QPS: 1.533, RPS: 4598308.336, MiB/s: 556.932, result RPS: 1.533, result MiB/s: 0.000.
0.000%  0.626 sec.
10.000% 0.635 sec.
20.000% 0.639 sec.
30.000% 0.642 sec.
40.000% 0.643 sec.
50.000% 0.645 sec.
60.000% 0.649 sec.
70.000% 0.652 sec.
80.000% 0.658 sec.
90.000% 0.682 sec.
95.000% 0.710 sec.
99.000% 0.727 sec.
99.900% 0.733 sec.
99.990% 0.734 sec.
```
2018-08-28 19:46:11 +08:00
alexey-milovidov
9ff0edc203
Merge pull request #2971 from urykhy/zk-operation-timeout
Make ZK operation timeout configurable
2018-08-28 14:23:09 +03:00
Amos Bird
a4dfe0ae38 Extending arrayEnumerateUniq.
https://github.com/yandex/ClickHouse/issues/2934
2018-08-28 15:31:25 +08:00
zhang2014
16404c8e7b ISSUES-2973 support nested json struct for visitParamExtractRaw 2018-08-28 13:45:21 +08:00
Alexey Milovidov
3e216f055c Miscellaneous #2758 2018-08-28 03:44:42 +03:00
Alexey Milovidov
9a4b4fbccd Miscellaneous #2758 2018-08-28 03:23:52 +03:00
Alexey Milovidov
236c3872b8 Miscellaneous #2758 2018-08-28 03:23:38 +03:00
Alexey Milovidov
32286484cd Miscellaneous #2758 2018-08-28 03:22:32 +03:00
Alexey Milovidov
52379be265 Miscellaneous #2758 2018-08-28 03:21:02 +03:00
Alexey Milovidov
4f8d324fa7 Miscellaneous #2758 2018-08-28 03:18:32 +03:00
Alexey Milovidov
fa0ffcf8dc Miscellaneous #2758 2018-08-28 03:17:27 +03:00
Alexey Milovidov
2a4b4eefd6 Miscellaneous #2758 2018-08-28 03:10:05 +03:00
Alexey Milovidov
ea643eeff9 Miscellaneous #2758 2018-08-28 03:03:10 +03:00
Alexey Milovidov
7c777c48d7 Miscellaneous #2758 2018-08-28 03:01:03 +03:00
Alexey Milovidov
0a7e288d70 Miscellaneous #2758 2018-08-28 02:59:49 +03:00
Alexey Milovidov
bab6cd504d Miscellaneous #2758 2018-08-27 22:16:38 +03:00
Alexey Milovidov
24bd803c07 Whitespaces #2758 2018-08-27 22:06:32 +03:00
Alexey Milovidov
f5cc5ef877 Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into VadimPE-CLICKHOUSE-3847 2018-08-27 22:04:14 +03:00
proller
cc86cb503e clickhouse-test-server with temporary data dir 2018-08-27 21:32:50 +03:00
Alexey Milovidov
f9b6483f95 Checkpoint [#CLICKHOUSE-2] 2018-08-27 21:21:34 +03:00
Alexey Milovidov
74fee0dc98 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:20:58 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
0d02315778 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:07:17 +03:00
Alexey Milovidov
3efffba44e Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:05:28 +03:00
Alexey Milovidov
956f76e000 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:58:43 +03:00
Alexey Milovidov
5b257c588f Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:42:13 +03:00
Yury Stankevich
f3024d2fba Make ZK operation timeout configurable 2018-08-27 20:26:19 +03:00
Alexey Milovidov
d4ea8bdb88 Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:18:39 +03:00
Alexey Milovidov
6e18af7ed3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:18:14 +03:00
chertus
d6a85d9d63 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-27 20:17:26 +03:00
chertus
220909eb39 minor fix CLICKHOUSE-3765 2018-08-27 20:17:12 +03:00
alexey-milovidov
98148d914c
Merge pull request #2958 from blahgeek/skip-json-object
Skip object fields on json input
2018-08-27 20:07:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
alexey-milovidov
95b2bcbc6b
Merge pull request #2970 from 4ertus2/decimal
Some more Decimal
2018-08-27 19:59:26 +03:00
alexey-milovidov
3328fb456a
Merge pull request #2966 from amosbird/nrvo
Get rid of useless std::move to get NRVO
2018-08-27 19:56:03 +03:00
Alexey Milovidov
ad5855b7c1 Compatibility with old CMake [#CLICKHOUSE-2] 2018-08-27 19:49:40 +03:00
chertus
9dbaa5f4a9 remove strange code CLICKHOUSE-3765 2018-08-27 19:46:42 +03:00
Vadim
2d8bffafa3
Update MergeTreeSettings.h 2018-08-27 19:38:54 +03:00
Vadim
4d9d80b271
Update MergeTreeSettings.h 2018-08-27 19:38:36 +03:00
Alexey Milovidov
076e1fb2e1 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 19:31:45 +03:00
alesapin
4ecf3ce8ef
Merge pull request #2969 from alesapin/master
CLICKHOUSE-3894: Fix Kafka test
2018-08-27 19:24:39 +03:00
VadimPE
418375aa1d Merge branch 'CLICKHOUSE-3847' of https://github.com/VadimPE/ClickHouse into CLICKHOUSE-3847 2018-08-27 19:23:08 +03:00
VadimPE
70ebb6a47d CLICKHOUSE-3847 fix code-style 2018-08-27 19:22:39 +03:00
Alexey Milovidov
e5a2dd8624 Merge branch 'master' into extra-warnings 2018-08-27 19:19:04 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
alesapin
1f0f1ecad3 CLICKHOUSE-3894: Fix Kafka test 2018-08-27 19:15:39 +03:00
Vadim
64a27e592b
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 19:00:40 +03:00
VadimPE
4d198f2bfe CLICKHOUSE-3847 fix build 2018-08-27 18:54:07 +03:00
VadimPE
0281678c3e CLICKHOUSE-3847 fix code style 2018-08-27 18:44:51 +03:00
Alexey Milovidov
303cc7242f Addition to prev. revision #2956 2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030 Removed code with duplicate semantics [#CLICKHOUSE-2] 2018-08-27 18:01:33 +03:00
alexey-milovidov
7de0549879
Update ReadHelpers.h 2018-08-27 18:00:08 +03:00
alexey-milovidov
01f01b1ee1
Update ReadHelpers.cpp 2018-08-27 17:54:58 +03:00
alesapin
a2a623d228
Merge pull request #2967 from alesapin/master
Small fixes in testing framework
2018-08-27 17:53:56 +03:00
alesapin
716c8016d7 CLICKHOUSE-3894: Print stack trace 2018-08-27 17:45:37 +03:00
alesapin
06d091580d CLICKHOUSE-3894: Increase MySQL timeout and add logging 2018-08-27 17:43:59 +03:00
proller
3acce3bff9 Build fix (#2944)
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
VadimPE
a8974f8786 CLICKHOUSE-3847 add Coordinator 2018-08-27 16:51:22 +03:00
alesapin
3913a6ef4e
Merge pull request #2965 from alesapin/master
CLICKHOUSE-3894: Wait zookeeper before clickhouse start
2018-08-27 16:51:05 +03:00
alesapin
570343fdb3 CLICKHOUSE-3894: Wait zookeeper before clickhouse start 2018-08-27 16:42:39 +03:00
alexey-milovidov
806316511f
Merge pull request #2960 from zhang2014/fix/on_cluster_crash
ISSUES-2482 fix crash when on cluster
2018-08-27 16:25:26 +03:00
Vadim
be2d821669
Merge branch 'master' into CLICKHOUSE-3847 2018-08-27 15:26:41 +03:00
Alexey Milovidov
eb165a0616 Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916] 2018-08-27 15:19:29 +03:00
Vadim
c4e90d89f0
Update ReplicatedMergeTreeCleanupThread.cpp 2018-08-27 15:16:52 +03:00
VadimPE
22aa521884 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:14:48 +03:00
VadimPE
cf0a7c1529 CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted 2018-08-27 15:09:22 +03:00
alesapin
d5dd32f4fe CLICKHOUSE-3894: Fix test_config_substs test 2018-08-27 14:40:01 +03:00
zhang2014
f8d7cf17a7 ISSUES-2482 fix crash when on cluster 2018-08-27 19:03:22 +08:00
Alexey Milovidov
252a00e25b Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 10:57:42 +03:00
BlahGeek
739119d355 skip object fields on json input 2018-08-27 12:01:47 +08:00
Alexey Milovidov
eed804ba94 Enabling extra warnings [#CLICKHOUSE-2] 2018-08-26 15:38:45 +03:00
Alexey Milovidov
e33b1d13aa Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 05:48:48 +03:00
Alexey Milovidov
b3c51070d4 Enabling -Wshadow-uncaptured-local [#CLICKHOUSE-2] 2018-08-26 05:41:05 +03:00
Alexey Milovidov
050a080be3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:29:42 +03:00
Alexey Milovidov
f7796df158 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:26:55 +03:00
Alexey Milovidov
5f21f1ba7d Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:25:45 +03:00
Alexey Milovidov
167d8ec529 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:19:18 +03:00
Alexey Milovidov
042d84e1e3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:17:18 +03:00
Alexey Milovidov
281faa1686 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:13:41 +03:00
Alexey Milovidov
8a0239b6ad Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:08:35 +03:00
Alexey Milovidov
b44343d83d Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:00:11 +03:00
Alexey Milovidov
e726fa89f8 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:58:56 +03:00
Alexey Milovidov
a1a70d4a65 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:56:34 +03:00
Alexey Milovidov
936c21de1f Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:42:02 +03:00
Alexey Milovidov
595bd32f41 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:41:08 +03:00
Alexey Milovidov
d252542e9a Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:37:22 +03:00
Alexey Milovidov
625f3fea08 Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:36:41 +03:00
Alexey Milovidov
44e848856e Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:33:20 +03:00
Alexey Milovidov
c0202bfbc9 Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:31:56 +03:00
Alexey Milovidov
29a6a85ccf Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:31:12 +03:00
Alexey Milovidov
d4ef5d05f2 Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:26:25 +03:00
Alexey Milovidov
4877cf31aa Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:25:35 +03:00
Alexey Milovidov
ac7673db29 Enabling -Wcomma [#CLICKHOUSE-2] 2018-08-26 04:24:21 +03:00
Alexey Milovidov
589ee74c7d Enabling -Wcomma [#CLICKHOUSE-2] 2018-08-26 04:19:11 +03:00
Alexey Milovidov
8c48fb14de Enabling -Wredundant-parens [#CLICKHOUSE-2] 2018-08-26 04:15:49 +03:00
Alexey Milovidov
4754abbc7d Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 04:14:00 +03:00
Alexey Milovidov
a70d0b79e4 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 04:13:02 +03:00
Alexey Milovidov
0fd919fdc5 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 04:11:58 +03:00
Alexey Milovidov
0ae34550db Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:52:58 +03:00
Alexey Milovidov
fa6e364f68 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:51:37 +03:00
Alexey Milovidov
6605098439 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:50:48 +03:00
Alexey Milovidov
52eb8fda3c Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:48:38 +03:00
Alexey Milovidov
6779de62d1 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:44:23 +03:00
Alexey Milovidov
3d0f62fb31 Enable some warnings from -Weverything [#CLICKHOUSE-2] 2018-08-26 03:39:11 +03:00
Alexey Milovidov
c193d15ef2 Merge branch 'master' into generalize-zookeeper 2018-08-26 03:32:15 +03:00
alexey-milovidov
f92bae33f8
Merge pull request #2949 from yandex/distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper
ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed.
2018-08-26 03:12:20 +03:00
Alexey Milovidov
2ce783e016 Merge branch 'read' of https://github.com/amosbird/ClickHouse into amosbird-read 2018-08-26 02:55:22 +03:00
alexey-milovidov
35806a4d27
Merge pull request #2955 from amosbird/varint
Fast path for varint read.
2018-08-26 02:47:04 +03:00
alexey-milovidov
00404a911c
Update VarInt.h 2018-08-26 02:46:18 +03:00
Amos Bird
a589230249 Faster path for varint read.
clickhouse-benchmark <<< 'select count() from s where not ignore(s);'

before this patch:

```

QPS: 0.732, RPS: 2346562049.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000.
0.000%  1.310 sec.
10.000% 1.321 sec.
20.000% 1.327 sec.
30.000% 1.337 sec.
40.000% 1.343 sec.
50.000% 1.359 sec.
60.000% 1.366 sec.
70.000% 1.381 sec.
80.000% 1.400 sec.
90.000% 1.434 sec.
95.000% 1.448 sec.
99.000% 1.489 sec.
99.900% 1.499 sec.
99.990% 1.500 sec.

```

after this patch:

```
QPS: 0.787, RPS: 2524560389.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000.
0.000%  1.228 sec.
10.000% 1.232 sec.
20.000% 1.235 sec.
30.000% 1.241 sec.
40.000% 1.246 sec.
50.000% 1.256 sec.
60.000% 1.265 sec.
70.000% 1.278 sec.
80.000% 1.296 sec.
90.000% 1.321 sec.
95.000% 1.354 sec.
99.000% 1.421 sec.
99.900% 1.453 sec.
99.990% 1.456 sec.
```

I also tried a SSE2 implementation and it's much slower (50%)
2018-08-26 02:23:26 +08:00
alexey-milovidov
732afd27cf
Merge pull request #2953 from yandex/max-block-size-in-system-tables-columns
Support for max_block_size in system.tables and system.columns tables
2018-08-25 20:36:54 +03:00
Amos Bird
9623e59870 Simplify read helpers.
Use similar APIs like https://en.cppreference.com/w/cpp/string/byte/strstr
2018-08-26 01:27:28 +08:00
Alexey Milovidov
0ef5b19436 Merge branch 'master' of github.com:yandex/ClickHouse 2018-08-25 19:50:14 +03:00
Alexey Milovidov
17818fa54f Merge branch 'Tezd-feature/suggestions' 2018-08-25 19:49:48 +03:00
Alexey Milovidov
aa936b09f9 Added check for max_block_size = 0 #2447 2018-08-25 19:32:44 +03:00
Alexey Milovidov
9c79c5f8ab Added test #2447 2018-08-25 19:26:55 +03:00
Alexey Milovidov
93b44fb17c Made suggest case sensitive again. Otherwise there is a glitch when you type SELECT DIS<TAB> #2447 2018-08-25 19:19:00 +03:00
Alexey Milovidov
068e50329e Support for max_block_size in system.tables and system.columns tables #2447 2018-08-25 19:07:48 +03:00
Alexey Milovidov
417cc1ab4d Additions #2447 2018-08-25 19:05:01 +03:00
Alexey Milovidov
24083e3088 Separate files #2447 2018-08-25 16:55:18 +03:00
Alexey Milovidov
9293882206 Allow to disable suggestion; check server revision #2447 2018-08-25 16:41:50 +03:00
Alexey Milovidov
32eb1a7942 Merge branch 'feature/suggestions' of https://github.com/Tezd/ClickHouse into Tezd-feature/suggestions 2018-08-25 16:15:30 +03:00
Amos Bird
5f03082af9 Make sure BufferBase is fully swapped. 2018-08-25 19:58:16 +08:00
alexey-milovidov
046137f9c5
Merge pull request #2946 from amosbird/locking
Better locking for StorageBuffer
2018-08-25 13:47:29 +03:00
Amos Bird
2602177525 Better locking for StorageBuffer 2018-08-25 13:52:06 +08:00
Alexey Milovidov
8cc3501c04 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 05:00:36 +03:00
Alexey Milovidov
3475ef5304 Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:58:14 +03:00
Alexey Milovidov
4d343a441c Attempt to generalize ZooKeeper interface [#CLICKHOUSE-2] 2018-08-25 04:14:02 +03:00
Alexey Milovidov
01082d03d2 Adopted logic in ReplicatedMergeTreeBlockOutputStream #2949 2018-08-25 01:55:02 +03:00
Alexey Milovidov
cc56235ad9 Merge remote-tracking branch 'origin/master' into distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper 2018-08-25 01:53:58 +03:00
Alexey Milovidov
2530561086 ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed #2939 2018-08-25 01:50:20 +03:00