Commit Graph

6752 Commits

Author SHA1 Message Date
feng lv
7ec73e1f20 fix build 2020-11-04 11:21:59 +00:00
Alexey Milovidov
c848deed1e Fix test 2020-11-04 14:07:54 +03:00
Alexey Milovidov
c7618ea99e Remove obsolete code from JOIN 2020-11-04 14:02:12 +03:00
feng lv
56b34d511c Merge branch 'master' of github.com:ClickHouse/ClickHouse into agg-func-setting-null-for-empty 2020-11-04 10:59:29 +00:00
Alexey Milovidov
155c11d29c Optimize -OrNull and -OrDefault aggregate functions by providing specializations #16123 2020-11-04 13:53:10 +03:00
Alexey Milovidov
85f81f9d9e Minor modification: less templates 2020-11-04 13:38:04 +03:00
Alexey Milovidov
ff8f80b6b6 Remove old file 2020-11-04 13:34:47 +03:00
alexey-milovidov
6f004e4abd
Merge branch 'master' into agg-func-setting-null-for-empty 2020-11-04 13:24:39 +03:00
hcz
4dccc51332
Fix typo 2020-11-04 18:21:59 +08:00
Alexey Milovidov
f7c77b4a25 Fix unit tests 2020-11-04 13:14:23 +03:00
Alexey Milovidov
5cfd84249b Merge branch 'master' into register-formats 2020-11-04 12:41:59 +03:00
alexey-milovidov
4fede5b008
Merge pull request #16438 from azat/errorCode-v2
Add errorCodeToName() and system.errors
2020-11-04 12:40:47 +03:00
alexey-milovidov
7b468c0c3a
Merge pull request #16575 from amosbird/cte2
Allow WITH subqueries to take effect immediately
2020-11-04 12:14:27 +03:00
alexey-milovidov
c82d8dde3d
Fix inconsistent whitespace. 2020-11-04 12:11:43 +03:00
alexey-milovidov
6d62f2163d
Merge pull request #16589 from amosbird/applyp
Allow parameterized functions in APPLY
2020-11-04 12:06:41 +03:00
feng lv
9b8dbf37cc fix
fix
2020-11-04 08:56:15 +00:00
alexey-milovidov
6091a7a4ff
Merge pull request #16617 from nikitamikhaylov/field-assert-decimal
Removed an incorrect check from Field::get().
2020-11-04 11:43:29 +03:00
alexey-milovidov
654d127ce6
Merge pull request #16630 from sundy-li/patch-6
better change the config
2020-11-04 11:36:07 +03:00
alexey-milovidov
74ebe952d1
Update Context.cpp 2020-11-04 11:32:20 +03:00
alexey-milovidov
0456cb2a09
Merge pull request #16638 from azat/simplify-ReadInOrderOptimizer
[RFC] Do not pass StoragePtr to ReadInOrderOptimizer::getInputOrder()
2020-11-04 11:29:06 +03:00
alexey-milovidov
397d02f828
Merge pull request #16643 from ClickHouse/quantile-merge-perf
Improve performance of quantileMerge
2020-11-04 11:28:07 +03:00
alexey-milovidov
864feaee39
Merge pull request #16644 from ClickHouse/row-input-format-better-diagnostics
Provide row number when "Cannot read all data" during parsing input
2020-11-04 11:26:54 +03:00
feng lv
cd711039fb Allow reinterpret between integers and floats of the same size 2020-11-04 07:56:27 +00:00
Nikolai Kochetov
69fa23a927
Merge pull request #16634 from Avogar/execute_query_fix
Remove redundant check
2020-11-04 08:59:41 +03:00
Azat Khuzhin
2389406c21 Fix spreading for ReadInOrderOptimizer with expression in ORDER BY
This will fix optimize_read_in_order/optimize_aggregation_in_order with
max_threads>0 and expression in ORDER BY
2020-11-04 07:07:26 +03:00
Ivan
64bd63ca49
Try to parse DataType arguments as another nested type (#16262)
* Try to parse DataType arguments as another nested one

* Allow mixed lists of arguments of data types

* Restore croaring back

* Fix tests
2020-11-04 03:08:55 +03:00
alexey-milovidov
973c1d7983
Merge pull request #16529 from azat/log_queries_min_time
Add log_queries_min_query_duration_ms
2020-11-04 01:47:18 +03:00
alexey-milovidov
8a3f38f332
Merge branch 'master' into errorCode-v2 2020-11-04 01:40:41 +03:00
alexey-milovidov
09805399d9
Merge pull request #16560 from azat/test_input_format_parallel_parsing_memory_tracking-flackiness
Fix test_input_format_parallel_parsing_memory_tracking flackiness
2020-11-04 01:37:25 +03:00
alexey-milovidov
225f7e2696
Merge pull request #16594 from amosbird/qpi
Query parameter type : Identifier
2020-11-04 01:35:23 +03:00
alexey-milovidov
df83291603
Merge pull request #16612 from ClickHouse/alter-name-collision
Fix possible name collision in calculation of DEFAULT expression.
2020-11-04 01:34:31 +03:00
Alexey Milovidov
f5ed9adad3 Remove old code 2020-11-03 23:52:57 +03:00
Alexey Milovidov
0b1c96db51 Provide row number when "Cannot read all data" during parsing input 2020-11-03 23:32:18 +03:00
Alexey Milovidov
5fe679324e Improve performance of quantileMerge #16640 2020-11-03 23:26:55 +03:00
Nikolai Kochetov
4ce88298d7 Fix build 2020-11-03 22:33:29 +03:00
Nikolai Kochetov
54a9b80a11 Fix build 2020-11-03 22:30:58 +03:00
Nikolai Kochetov
4984fdc693 Fix build 2020-11-03 22:28:50 +03:00
Nikolai Kochetov
3e012265d3 Fix build 2020-11-03 22:26:55 +03:00
Nikolai Kochetov
3b6806ea39 Fix build 2020-11-03 22:21:24 +03:00
Nikolai Kochetov
7b61f5d641 Refactor more 2020-11-03 22:05:47 +03:00
Azat Khuzhin
e7f15dff55 Do not pass StoragePtr to ReadInOrderOptimizer::getInputOrder()
Looks like this is not required anymore, since #11745
2020-11-03 21:22:46 +03:00
nikitamikhaylov
a9d4c0a4f9 open telementry log 2020-11-03 19:59:45 +03:00
Nikolai Kochetov
d7de4509a3
Update ActionsVisitor.cpp 2020-11-03 19:07:27 +03:00
Nikolai Kochetov
36f9bcdb52 Fix build. 2020-11-03 19:00:34 +03:00
nikitamikhaylov
7c2361af45 yet another logs 2020-11-03 18:19:24 +03:00
Pavel Kruglov
b67465b010 Fix style 2020-11-03 18:00:51 +03:00
Nikolai Kochetov
9f7de6a1a4 Try fix header for TTLBlockInputStream. 2020-11-03 17:26:47 +03:00
Pavel Kruglov
822bbcfdba Make Cmp with template 2020-11-03 17:25:52 +03:00
Nikolai Kochetov
726be794a4
Update ExpressionAnalyzer.cpp 2020-11-03 17:14:34 +03:00
Alexey Milovidov
9868b58531 Minor change 2020-11-03 17:09:37 +03:00
Alexey Milovidov
cd86f98aec Minor fixes 2020-11-03 17:09:37 +03:00
Alexey Milovidov
bcd660bb57 Minor fixes 2020-11-03 17:09:37 +03:00
Pavel Kruglov
cf3f39ed29 Small changes 2020-11-03 17:09:37 +03:00
Pavel Kruglov
4d399fff3e Support collation for Array and Tuple 2020-11-03 17:09:37 +03:00
Pavel Kruglov
5c296365e2 Fix build error 2020-11-03 17:08:40 +03:00
Pavel Kruglov
2892252b36 Support collate in LowCardinality(String) and Nullable(String) and refactor ColumnString 2020-11-03 17:06:21 +03:00
nikitamikhaylov
bf1ea39392 fix logs 2020-11-03 16:59:17 +03:00
Nikolai Kochetov
feccf47f27 Fxi build. 2020-11-03 16:30:55 +03:00
tavplubix
cc8932e7a1
Update DDLWorker.h 2020-11-03 15:51:26 +03:00
Nikolai Kochetov
6767a226fc Merge branch 'master' into actions-dag-f14 2020-11-03 15:21:06 +03:00
Pavel Kruglov
a8f325ba84 Remove redundant check 2020-11-03 14:41:46 +03:00
nikitamikhaylov
d95bcc8890 done 2020-11-03 14:32:06 +03:00
Nikolai Kochetov
07a7c46b89 Refactor ExpressionActions [Part 3] 2020-11-03 14:28:28 +03:00
alexey-milovidov
11fc6fd8c9
Merge pull request #16584 from ClickHouse/drop_table_task_better_scheduling
Better scheduling of drop table task
2020-11-03 14:22:51 +03:00
Anton Popov
85ab1e9bc3
Merge pull request #15938 from Avogar/select_final
Select final
2020-11-03 13:49:47 +03:00
alexey-milovidov
7978ae63d9
Merge pull request #16619 from ClickHouse/settings-early-apply
Apply SETTINGS clause earlier
2020-11-03 13:33:02 +03:00
Ildus Kurbangaliev
2534ea3426 fix bug in minMap and maxMap with zero values 2020-11-03 10:22:51 +00:00
alesapin
6e32e17a7d Merge branch 'master' into alter-name-collision 2020-11-03 13:16:34 +03:00
sundy-li
af5ecbef27 set zookeeper config 2020-11-03 17:57:24 +08:00
alesapin
01898be459
Merge pull request #16606 from ClickHouse/better_serialize_last_index_row
Simplier serialization of last index column
2020-11-03 09:59:50 +03:00
Anton Popov
a3a8e18637
Merge branch 'master' into select_final 2020-11-03 00:00:43 +03:00
Alexander Kuzmenkov
f10a5207f4
Merge pull request #16601 from ClickHouse/ban_aggregate_function_in_primary_key
Restrict to use non-comparable types in primary key
2020-11-02 23:27:46 +03:00
Alexey Milovidov
878fd466c5 Apply SETTINGS clause earlier 2020-11-02 22:23:26 +03:00
nikitamikhaylov
08b63fde77 done 2020-11-02 21:39:54 +03:00
Alexey Milovidov
e6d8ab2270 Fix possible name collision in ALTER 2020-11-02 21:37:23 +03:00
Azat Khuzhin
3be8a56f5c Add log_queries_min_query_duration_ms
Only queries slower then the value of this setting will go to system.query_log,
i.e. something like slow_query_log in mysql.

v2: log_queries_min_time renamed to log_queries_min_query_duration_ms
v3: add current_database into system.query_thread_log
v4: rewrite test using current_database
v5: fix query_duration_ms in system.query_thread_log
2020-11-02 21:34:54 +03:00
alexey-milovidov
bfa0ddcdfe
Merge pull request #16596 from ClickHouse/strange-cpp
Add strange C++ code that actually does not change anything
2020-11-02 20:02:28 +03:00
Alexander Tokmakov
ac32809b6a fix #16482 2020-11-02 19:40:39 +03:00
Alexander Kuzmenkov
2c8e42c232
Merge pull request #16563 from azat/query_thread_log_query_duration_ms-fix
Fix query_thread_log.query_duration_ms
2020-11-02 19:32:59 +03:00
Amos Bird
5e51256897
Fix warning 2020-11-02 23:04:18 +08:00
Nikolai Kochetov
14f6ec6ae2
Merge pull request #16592 from ClickHouse/revert-13964-fix/agg_combinator
Revert "Try fix IfAggCombinator with NullAggCombinator"
2020-11-02 16:53:50 +03:00
alexey-milovidov
5633dfb402
Update ExpressionElementParsers.h 2020-11-02 16:15:40 +03:00
alesapin
7f8560e0c0
Merge pull request #16538 from amosbird/fp2
Allow fetching duplicate parts to detach
2020-11-02 16:10:42 +03:00
Amos Bird
4cfae808fa
Query parameter type : Identifier 2020-11-02 20:58:51 +08:00
alesapin
b689d976f8 Fix style 2020-11-02 15:52:50 +03:00
Ivan
281bf351d2
Remove ANALYZE and AST queries (#16536) 2020-11-02 15:47:12 +03:00
alesapin
fbda80ac89 Simplier storage of last index column 2020-11-02 15:19:37 +03:00
Nikolai Kochetov
ceb83602b8 Refactor 2020-11-02 15:07:01 +03:00
alesapin
360548180c Remove redundant include 2020-11-02 14:42:25 +03:00
alesapin
f3b3025719 Ban non comparable types in primary key 2020-11-02 14:39:27 +03:00
Nikolai Kochetov
2a0db5d627 Merge branch 'master' into nikitamikhaylov-totals-having 2020-11-02 14:36:18 +03:00
Alexey Milovidov
8a68ee2547 Whitespaces 2020-11-02 13:45:48 +03:00
Alexey Milovidov
67daa37a7f Add strange C++ code that actually does not change anything 2020-11-02 13:42:47 +03:00
Nikolai Kochetov
962a89843c
Revert "Try fix IfAggCombinator with NullAggCombinator" 2020-11-02 12:01:57 +03:00
alesapin
101aa9e931 Merge branch 'master' into no_background_pool_no_more 2020-11-02 10:49:19 +03:00
Amos Bird
13fee19778
Allow parameterized functions in APPLY 2020-11-02 11:10:20 +08:00
Alexander Tokmakov
33fa54cce6 better scheduling of drop table task 2020-11-01 20:37:54 +03:00
Azat Khuzhin
5363c62fc5 Fix overflow check in ErrorCodes 2020-11-01 09:00:19 +03:00
Amos Bird
2a747ce5af
Allow WITH subqueries to take effect immediately 2020-11-01 00:02:52 +08:00
alesapin
ae53092536 Merge branch 'master' into system_fetches_table 2020-10-31 18:45:17 +03:00
Jacob Hayes
2aa0362765 Add farmFingerprint64 function 2020-10-31 08:45:53 -04:00
tavplubix
cb139203b7
Merge pull request #16504 from TCeason/shrink_gtid_set
Shrink sequence gtid set
2020-10-31 15:12:35 +03:00
tavplubix
17ecafe452
Update MySQLGtid.h 2020-10-31 14:43:46 +03:00
tavplubix
8631b31ae0
Update MySQLGtid.cpp 2020-10-31 14:43:24 +03:00
tavplubix
db146ee615
Merge pull request #16555 from ClickHouse/yet_another_fix_for_00993
Better logging in replication queue, fix flacky test
2020-10-31 14:38:15 +03:00
Azat Khuzhin
c8f756707f Swap name and value in ErrorCodes definition 2020-10-31 11:32:44 +03:00
Azat Khuzhin
e07473f1ea Update comment for StorageSystemErrors 2020-10-31 11:29:17 +03:00
Azat Khuzhin
fff6b5549e Hide getCurrentTimeNanoseconds() to avoid possible errors
To avoid further errors like in:
- c0e15ba348 ("Fix RealTimeMicroseconds ProfileEvents")
- c856d02e0f4a519cd2a29ffbe1135196de0bc65a ("Fix query_thread_log.query_duration_ms unit")
2020-10-31 11:15:27 +03:00
Azat Khuzhin
3b188921dd Fix query_thread_log.query_duration_ms unit
There is a similar problem as in [1], the problem is that
getCurrentTimeNanoseconds() returns time using CLOCK_MONOTONIC.

  [1]: c0e15ba348 ("Fix RealTimeMicroseconds ProfileEvents")
2020-10-31 11:15:27 +03:00
alexey-milovidov
15a342e5e1
Merge pull request #16541 from ucasFL/parse-null
fix parseDateTimeBestEffortOrNull with empty string
2020-10-31 06:38:51 +03:00
alexey-milovidov
022648a154
Merge pull request #16558 from azat/query_thread_log_current_database
Add current_database into query_thread_log
2020-10-31 06:36:10 +03:00
alesapin
94ae5aed73
Merge pull request #16550 from ClickHouse/remove_wrong_assertion
Remove wrong assertion from SSDComplexKeyCacheDictionary
2020-10-30 22:45:48 +03:00
Azat Khuzhin
831208e2cf Log the difference between process RSS and MemoryTracking metric 2020-10-30 22:02:02 +03:00
Azat Khuzhin
5bab7a5bc7 Add current_database into query_thread_log 2020-10-30 21:16:10 +03:00
tavplubix
ce6c44eb9f
Update ReplicatedMergeTreeQueue.cpp 2020-10-30 18:47:58 +03:00
alexey-milovidov
83220b0956
Update parseDateTimeBestEffort.cpp 2020-10-30 16:00:49 +03:00
Alexander Tokmakov
cf8202d36e better logging, fix flacky test 2020-10-30 15:41:39 +03:00
alesapin
be183027b3
Merge pull request #16516 from zlobober/remove_g0
Remove -g0 form Arcadia build settings.
2020-10-30 13:58:08 +03:00
alesapin
182f9fbdca Remove wrong assertion from SSDComplexKeyCacheDictionary 2020-10-30 12:36:46 +03:00
alesapin
15ba4dd851 Review fix 2020-10-30 11:52:11 +03:00
alesapin
b34960bffa Merge branch 'master' into system_fetches_table 2020-10-30 11:33:37 +03:00
alesapin
e06f65ee73
Merge pull request #16521 from myrrc/improvement/avro-format-lc
Fixing the inability to deserialize AVRO into table if it contains LowCardinality columns
2020-10-30 11:31:22 +03:00
Azat Khuzhin
3661769e1b Remove some absolute changes for errorCodeToName/system.errors 2020-10-30 09:04:22 +03:00
feng lv
f428675b6e fix parseDateTimeBestEffortOrNull with empty string 2020-10-30 05:42:10 +00:00
Amos Bird
18c5abc44e
Allow fetching duplicate parts to detach 2020-10-30 10:55:50 +08:00
Azat Khuzhin
ce9897bfd8 Fix readability-container-size-empty in StorageSystemErrors.cpp 2020-10-30 00:07:40 +03:00
Azat Khuzhin
0cd79de632 Eliminate extra strlen() in errorCodeToName() 2020-10-29 21:53:09 +03:00
Azat Khuzhin
cb50886ef1 Fix ErrorCodes increment on error 2020-10-29 21:24:52 +03:00
Azat Khuzhin
04bff595d3 Make check-style happy (by not using DB::ErrorCodes:: in comments) 2020-10-29 21:10:20 +03:00
Azat Khuzhin
7e79769ae4 Fix readability-inconsistent-declaration-parameter-name in ErrorCodes.h 2020-10-29 21:08:09 +03:00
myrrc
9564a7f6d1 simplified the cast 2020-10-29 20:30:24 +03:00
myrrc
68b47f5f61 removing LC in AVRO input format if needed 2020-10-29 20:24:54 +03:00
Pavel Kruglov
dbfef325e6 Rename NullSink to NullOutput 2020-10-29 20:22:48 +03:00
alexey-milovidov
434f6227cb
Merge pull request #16451 from ClickHouse/decimal-round-fuzz
Decimal round fuzz
2020-10-29 20:04:34 +03:00
Nikolai Kochetov
1c106691b5
Merge pull request #16423 from amosbird/jbodread
Balanced reading from JBOD
2020-10-29 19:22:45 +03:00
Maxim Akhmedov
3627fabfb9 Remove -g0 form Arcadia build settings. 2020-10-29 17:37:23 +03:00
tavplubix
2a66c17472
Update InterpreterDropQuery.cpp 2020-10-29 16:37:59 +03:00
alesapin
40fc512e79 Merge branch 'master' into no_background_pool_no_more 2020-10-29 12:53:34 +03:00
Azat Khuzhin
b42f77a791 Covert error codes list to lookup table and drop generation of them. 2020-10-29 10:55:41 +03:00
Azat Khuzhin
b7eac807f5 Fix readability-qualified-auto in errorCodeToName() 2020-10-29 10:55:41 +03:00
Azat Khuzhin
a81b0418ac Make errorCodeToName() return LowCardinality(String) 2020-10-29 10:55:41 +03:00
Azat Khuzhin
b2e2322895 Add system.errors table
Contains error codes with number of times they have been triggered.

Columns:

-   `name` ([String](../../sql-reference/data-types/string.md)) — name of the error (`errorCodeToName`).
-   `code` ([Int32](../../sql-reference/data-types/int-uint.md)) — code number of the error.
-   `value` ([UInt64](../../sql-reference/data-types/int-uint.md)) - number of times this error has been happened.

**Example**

``` sql
SELECT *
FROM system.errors
WHERE value > 0
ORDER BY code ASC
LIMIT 1

┌─name─────────────┬─code─┬─value─┐
│ CANNOT_OPEN_FILE │   76 │     1 │
└──────────────────┴──────┴───────┘
2020-10-29 10:55:38 +03:00
Azat Khuzhin
3fb8d08dd4 Add errorCodeToName() function
This patch adds errorCode() function that will return macro name by the
exception code, useful for analyzing query_log and similar.

Later some descriptions can be added.

v2: replace hana::map/fusion::vector with external script
v3:
- use binary cmake dir for .sh
- use jump table over suboptimal std::unordered_map (with very poor hash
  function for int -- std::hash)
- cleanup errorCodeToName (drop extra templates and headers)
- rename errorCode -> errorCodeToName
- fix arcadia build (by not providing those helpers there)
- fix build on CI, by using CMAKE_CXX_COMPILER for parsing the file
2020-10-29 10:55:00 +03:00
taichong
bb1ac2af82 Shrink sequence gtid set
when use MySQL Master -> MySQL Slave -> ClickHouse MaterializeMySQL
Engine

and MySQL Slave enable slave_parallel_worker the gtid in .metadata won't
shrink.

Like this:

https://github.com/ClickHouse/ClickHouse/issues/15951
2020-10-29 15:11:27 +08:00
Nikolai Kochetov
671d2b7f1b
Update MergeTreeReadPool.cpp
Fix comment
2020-10-29 10:04:23 +03:00
alexey-milovidov
0faf2bc7e3
Merge pull request #16332 from ClickHouse/fix-queue-processing-of-very-large-entries
Fix processing of very large entries in queue
2020-10-29 09:09:29 +03:00
Alexey Milovidov
2e0a979e3a Fix inconsistency in FormatFactory 2020-10-29 06:39:43 +03:00
Alexey Milovidov
1e99ce5f3a Merge branch 'master' into decimal-round-fuzz 2020-10-29 04:57:43 +03:00
alexey-milovidov
bf3acecf6f
Merge pull request #16032 from Avogar/mysql_bug
Don't touch MySQL database if it's unnecessary
2020-10-29 04:14:26 +03:00
Nikolai Kochetov
10bad32fb4 Refactor code a little bit. Add comment. 2020-10-29 00:52:26 +03:00