Commit Graph

60 Commits

Author SHA1 Message Date
Alexey Milovidov
993f3faefd Miscellaneous 2021-10-31 18:11:46 +03:00
Vladimir C
d60f00bab8
Merge pull request #30520 from azat/fix-unary-postfix-rewrite 2021-10-22 11:31:36 +03:00
Azat Khuzhin
e1b6acfa52 Add missing parenthesis for isNotNull/isNull rewrites to IS [NOT] NULL
After #29446 the following query was "broken":

    select isNotNull(1)+isNotNull(2) from remote('127.2', system.one)

This was also a problem for queries to external storages (i.e. mysql),
since it also uses query rewrite, like non-local distributed queries.

Fixes: #29446
2021-10-21 21:18:00 +03:00
Maksim Kita
4ea969350b Fixed build 2021-10-21 18:43:33 +03:00
Maksim Kita
650a79a907 SQLUserDefinedFunctions composition fix 2021-10-21 10:08:08 +03:00
vdimir
4acd8f3147
Do not add extra parentheses for tuple negate unary operator 2021-09-30 13:47:29 +03:00
Azat Khuzhin
2378491c04 Transform isNull/isNotNull to IS NULL/IS NOT NULL (for external dbs)
This is required to support queries (like `foo IS NULL`) to external
databases (i.e. MySQL).

This patch had been submitted separately, due to:
- avoid mixing patches
- run CI (and update tests references)
2021-09-27 22:24:09 +03:00
Realist007
63dfa8559f
Merge branch 'master' into feature/create-simple-lambda-function 2021-08-16 16:56:49 +03:00
Anton Popov
699a3d9031 implement legacy_column_name_of_tuple_literal in less intrusive way 2021-08-03 21:03:24 +03:00
Realist007
31e26862b5
Merge branch 'master' into feature/create-simple-lambda-function 2021-07-21 10:33:53 +03:00
Alexey Milovidov
09449cc101 Whitespaces 2021-07-21 04:47:56 +03:00
ANDREI STAROVEROV
3bf0db519e Improve tests and validation of new functions 2021-07-03 23:17:02 +03:00
Anton Popov
c2754c34f4 Merge remote-tracking branch 'upstream/master' into HEAD 2021-06-21 12:42:48 +03:00
Azat Khuzhin
9242654231 negate: replace special case with parens
v0: negate: add parens for negative values
    Before this patch -(-1) was formatted to --1, but this is not valid
    syntax.
v2: replace special case with parens, otherwise formatting of -(-(-1))
    will be unstable, in v0 it was formatted to -(1) but -(1) is
    formatted to -1 [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/24427/4512460aeb02fec557c558eee3f8291a6297efb2/fuzzer_asan/fuzzer.log
2021-06-17 10:07:03 +03:00
Anton Popov
ea9b890618
Merge branch 'master' into add-compatibility-setting 2021-06-16 21:10:56 +03:00
Anton Popov
8bd7cbd925 add compatibility setting for name of columns 2021-06-16 21:10:07 +03:00
Alexey Milovidov
447d7bb8cd Minor changes 2021-06-14 07:13:35 +03:00
Alexey Milovidov
cae9b25074 Minor change 2021-06-14 06:05:27 +03:00
alexey-milovidov
066d02dd2f
Merge pull request #23631 from ClickHouse/normalize-bigint
Make big integers production ready.
2021-05-11 11:07:52 +03:00
mergify[bot]
f5e77d7200
Merge branch 'master' into aku/fuzzer-typo 2021-05-10 17:54:19 +00:00
Alexey Milovidov
02ce9cc725 Untangle UUID 2021-05-04 01:46:51 +03:00
Alexander Kuzmenkov
01b1440bd4 case-insensitive comparison 2021-04-30 19:58:35 +03:00
Alexander Kuzmenkov
86c4d8b934 the last try to make the formatting check in fuzzer work 2021-04-30 00:38:40 +03:00
Azat Khuzhin
a5a8ecfe42 Fix inconsistent formatting for tupleElement (for fuzzer)
fuzzer sometimes [1] may inserts tupleElement() created from ASTLiteral:

    Function_tupleElement, 0xx
    -ExpressionList_, 0xx
    --Literal_Int64_255, 0xx
    --Literal_Int64_100, 0xx

And in this case it will be printed as "255.100", which
later will be parsed as float, and formatting will be
inconsistent.

So instead of printing it as regular tuple,
let's print it as ExpressionList instead (i.e. with ", " delimiter).

Simple reproducer:

    void ast()
    {
        auto arg1 = std::make_shared<ASTLiteral>(Field(255));
        auto arg2 = std::make_shared<ASTLiteral>(Field(100));

        auto func = makeASTFunction("tupleElement", arg1, arg2);

        auto ast = func;
        std::cerr << ast->formatForErrorMessage() << std::endl;
        std::cerr << ast->dumpTree() << std::endl;
    }

  [1]: https://clickhouse-test-reports.s3.yandex.net/23517/f1187aeb69109c88f0be978b8083080c7a843820/fuzzer_debug/report.html#fail1
2021-04-25 00:30:17 +03:00
Alexander Kuzmenkov
2782b2a6b0 fix 2021-04-16 21:50:12 +03:00
Alexander Kuzmenkov
b991cbf9d6 more stable formatting for negate() 2021-04-16 19:28:33 +03:00
Ilya Yatsishin
ed2d82603e
Merge pull request #22588 from foolchi/fix_dist_map_select
fix dist map type select
2021-04-07 11:53:23 +03:00
Amos Bird
a89e3df40a
Disable table function view in expression (#21465) 2021-04-06 16:08:29 +03:00
fuqi
043bd11d2e fix dist map type select 2021-04-04 18:00:30 +08:00
fuqi
b590926c1c fix dist map type select 2021-04-04 17:23:47 +08:00
Alexander Kuzmenkov
c3cc65f826 use macro 2021-03-26 20:30:36 +03:00
Alexander Kuzmenkov
cc93055e9e ignore UB as in negate() 2021-03-26 20:29:41 +03:00
Alexander Kuzmenkov
33647ef3d5 fix build 2021-03-25 23:02:09 +03:00
Alexander Kuzmenkov
7444eab536 Merge remote-tracking branch 'origin/aku/negate-stable' into HEAD 2021-03-25 21:40:02 +03:00
Alexander Kuzmenkov
9aa89161dc fix for decimals 2021-03-25 21:39:57 +03:00
Alexander Kuzmenkov
72b742258a
Update src/Parsers/ASTFunction.cpp 2021-03-25 19:20:36 +03:00
Alexander Kuzmenkov
4e96675a30
Update src/Parsers/ASTFunction.cpp 2021-03-25 19:18:57 +03:00
Alexander Kuzmenkov
48af3f5851 stable formatting for negate() 2021-03-25 18:38:43 +03:00
Alexander Kuzmenkov
46e4134deb fix fuzzer failure in tupleElement formatting 2021-03-19 15:47:06 +03:00
Alexander Kuzmenkov
703731c547 something works 2021-01-13 22:29:52 +03:00
Alexander Kuzmenkov
2905f70cce fix aliases in partition by/order by 2020-12-28 12:56:38 +03:00
Alexander Kuzmenkov
998bd17877 fix column name clash w/agg fns
also fix some test references influenced by the explain changes
2020-12-25 07:59:17 +03:00
Alexander Kuzmenkov
52ace7a3d1 one plan step per window 2020-12-22 04:37:45 +03:00
Alexander Kuzmenkov
132a0b42eb cleanup 2020-12-18 20:13:28 +03:00
Alexander Kuzmenkov
fc426807a8 formatting & fuzzer support 2020-12-18 03:21:23 +03:00
Alexander Kuzmenkov
a1326414ff Merge remote-tracking branch 'origin/master' into tmp 2020-12-17 00:46:14 +03:00
Alexander Kuzmenkov
fef24c81e3 some grammar 2020-12-17 00:44:05 +03:00
Anton Popov
7aaa2c052f
Merge branch 'master' into merging-map 2020-12-05 22:41:46 +03:00
Anton Popov
6b09669d66 data type map: several fixes 2020-12-05 22:36:09 +03:00
Ivan
315ff4f0d9
ANTLR4 Grammar for ClickHouse and new parser (#11298) 2020-12-04 05:15:44 +03:00