Commit Graph

5795 Commits

Author SHA1 Message Date
Alexander Kuzmenkov
608b6e3a25 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 14:00:22 +03:00
Nikolai Kochetov
3792d688c0
Merge pull request #14741 from ClickHouse/expression-dag
ActionsDAG
2020-10-01 12:50:32 +03:00
Alexander Kuzmenkov
bc66dc99d1 Merge remote-tracking branch 'origin/master' into HEAD 2020-10-01 12:28:30 +03:00
Mark Papadakis
b642bd494d
Update ActionsVisitor.cpp
Refactoring: eliminated a local, throws if it matches the column name as opposed to iterating to the end of the container.
2020-10-01 12:03:19 +03:00
alesapin
8bc9ede711 Fix clang tidy 2020-10-01 09:53:47 +03:00
alesapin
5622a0769f
Merge pull request #15477 from ClickHouse/fix_ddl_worker_wait
Fix wait event subscription in DDLWorker
2020-10-01 09:51:47 +03:00
alexey-milovidov
9808d0be81
Merge pull request #15376 from excitoon-favorites/fixs3storage
Fixed compression in S3 storage
2020-10-01 04:30:32 +03:00
tavplubix
2f95609f98
Merge pull request #15448 from ClickHouse/allow_synchronous_drop_for_atomic_db
Allow synchronous DROP/DETACH TABLE for Atomic
2020-10-01 01:14:31 +03:00
Artem Zuikov
0f6a6453fe
Remove multiple_joins_rewriter v1 (#15472) 2020-09-30 23:11:49 +03:00
Artem Zuikov
0ac18a382f
Fix JOIN with GROUP BY over StorageMerge (#15242) 2020-09-30 23:11:27 +03:00
alesapin
97c2579fb9 Use separate function 2020-09-30 22:50:23 +03:00
alesapin
ac9f0ff4da More strict check for version column 2020-09-30 22:44:35 +03:00
Alexander Kuzmenkov
e45edd57f2 Add reinterpretAsUUID function 2020-09-30 20:19:32 +03:00
Vladimir Chebotarev
0497ce4f9c Possibly better fix. 2020-09-30 18:29:10 +03:00
alesapin
cfe9a0c4a1 Fix event subscription in DDLWorker 2020-09-30 17:58:27 +03:00
Nikolai Kochetov
45618c9d4c
Merge pull request #15437 from ClickHouse/azat-ThreadPool-UAF-fixes
Destroy resources captured by lambda after `ThreadFromGlobalPool::join()`
2020-09-30 16:50:30 +03:00
Nikolai Kochetov
0b1fe69ad7 Fix build. 2020-09-30 16:31:06 +03:00
Vladimir Chebotarev
b460024356 Fixed bug in GZIP compression in S3 storage. 2020-09-30 16:09:55 +03:00
Nikolai Kochetov
a1aca04711 Fix build. 2020-09-30 15:32:37 +03:00
Vladimir Chebotarev
a38c7ff2a8 Somehow uncompressed PUT works and gzipped PUT doesn't, in S3 storage. 2020-09-30 15:04:42 +03:00
Nikolai Kochetov
782823de4d Fix build. 2020-09-30 14:45:47 +03:00
Vladimir Chebotarev
698768add0 Fixed format argument in S3 storage when compression method is selected. 2020-09-30 13:55:44 +03:00
alesapin
01d8a36cd6
Merge pull request #15456 from ClickHouse/more-exception-safety-in-shellcommand
Fix exception safety in ShellCommand
2020-09-30 12:56:55 +03:00
tavplubix
c9eeb149fd
Merge pull request #15384 from zhang2014/fix/ISSUES-15365
ISSUES-15365 fix attach mysql database database
2020-09-30 11:27:15 +03:00
Nikolai Kochetov
0e412686bc Better comments. 2020-09-30 11:25:22 +03:00
alexey-milovidov
0c07c2d3a3
Merge pull request #15089 from ClickHouse/codecs_for_nested_types
Codecs for nested types
2020-09-30 07:18:19 +03:00
feng lv
c857b5dd5d fix 2020-09-30 09:50:23 +08:00
alexey-milovidov
412a54e356
Merge pull request #14693 from hustnn/zk_exist_fix2
Fix potential memory leak caused by zookeeper exist calling
2020-09-30 04:48:11 +03:00
alexey-milovidov
b6bccfc4f4
Merge pull request #14776 from Vxider/disable_set_and_join_persistency
Support memory only mode for StorageJoin and StorageSet.
2020-09-30 04:35:43 +03:00
alexey-milovidov
ac989f3a8f
Merge pull request #15285 from ucasFL/now-with-timezone
function `now` allow an argument with timezone
2020-09-30 04:32:36 +03:00
Alexey Milovidov
78dbf10c7b Fix exception safety in ShellCommand 2020-09-30 03:00:45 +03:00
Alexander Tokmakov
e156e6115e add setting 2020-09-30 01:30:34 +03:00
alexey-milovidov
b658f348a7
Update MergeTreeDataPartWriterWide.cpp 2020-09-30 01:23:42 +03:00
alexey-milovidov
9f944424cf
Merge pull request #15364 from ClickHouse/format-raw-blob
Add format RawBLOB
2020-09-30 01:14:40 +03:00
alexey-milovidov
3e99ca797b
Merge pull request #15426 from ClickHouse/format-regexp-escaping-rule-change-default-to-raw
Format Regexp: change default escaping rule to Raw
2020-09-30 01:14:08 +03:00
Nikolai Kochetov
727289cb09 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 23:43:02 +03:00
Nikolai Kochetov
a2c70c4611 Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 22:11:40 +03:00
Artem Zuikov
86cfc6f914
change error code (#15452) 2020-09-29 20:36:14 +03:00
alesapin
4ab39d2bee
Fix style 2020-09-29 18:19:30 +03:00
Alexander Tokmakov
cf86e19f38 fix build 2020-09-29 17:15:05 +03:00
Alexander Tokmakov
8692c10495 add alias 2020-09-29 17:12:40 +03:00
Alexander Tokmakov
5d19ed04f6 allow synchronous drop/detach table for Atomic 2020-09-29 16:47:08 +03:00
Nikolai Kochetov
33487c0e4a
Merge pull request #15422 from ClickHouse/query-plan-header-remove-columns
Remove column from header descriotion for EXPLAIN PLAN
2020-09-29 15:51:09 +03:00
feng lv
4f000388a7 add setting output_format_pretty_row_numbers 2020-09-29 20:30:36 +08:00
alesapin
65a05a970d Better message on error 2020-09-29 15:07:01 +03:00
Alexander Kuzmenkov
2d456e2cd6
Merge pull request #15407 from detailyang/master
bugfix:aggregate:fix boundingratio args check
2020-09-29 14:12:54 +03:00
Nikolai Kochetov
a7e7fd084f Destroy resurces captured by lambda after ThreadFromGlobalPool::join(). 2020-09-29 13:48:11 +03:00
Nikolai Kochetov
de56c02525 Merge branch 'master' into expression-dag 2020-09-29 12:18:29 +03:00
Nikolai Kochetov
53d4e5d195 Merge branch 'master' into expression-dag 2020-09-29 12:15:50 +03:00
Azat Khuzhin
1fcc36ef80 Use ThreadPool to ensure that everything has been finished in PipelineExecutor
This will fix possible UAF, since ThreadFromGlobalPool cannot wait until
the job will be reseted, for this you need to call ThreadPool::wait()
(that waits until scheduled_jobs will be zero), and this guarantee that
the job was reseted, otherwise some variables that job is referencing
may be already destroyed, while job hasn't been destoyed yet (example
that I found PipelineExecutor -> ThreadGroupStatusPtr -> MemoryTracker
-> ~MemoryTracker -> log, while log had been destroyed already, here is
TSAN report --
https://gist.github.com/azat/d480dc3af5a0a44de4b038e20807c4b9, copied
from
https://clickhouse-test-reports.s3.yandex.net/15035/79133a426fdf042e383ea0cdccc4dc8273baa3a7/functional_stateless_tests_(thread)/test_run.txt.out.log)
2020-09-29 11:00:03 +03:00
Azat Khuzhin
789434994a Reset job on failure too in ThreadPool::worker()
job should be reseted before decrementing scheduled_jobs to
ensure that the Job destroyed before wait() returns.
2020-09-29 10:56:36 +03:00
zhang2014
9e94c077e7 IESSUES-15365 try fix integration test 2020-09-29 10:39:30 +08:00
Alexey Milovidov
dee57d7976 Format Regexp: change default escaping rule to Raw 2020-09-29 00:19:13 +03:00
Alexey Milovidov
e4800e7b35 Fix comment 2020-09-29 00:10:36 +03:00
Nikolai Kochetov
347080ff9a Remove column from header descriotion for EXPLAIN PLAN and EXPLAIN PIPELINE 2020-09-28 20:37:11 +03:00
Alexander Kuzmenkov
51b9aaf4d8
Merge pull request #15363 from ClickHouse/format-regexp-raw
Add support for "Raw" column format for Regexp format
2020-09-28 20:03:32 +03:00
tavplubix
4578d89819
Merge pull request #15348 from ClickHouse/replicate_default_args
Continuation of #14791
2020-09-28 18:53:02 +03:00
tavplubix
421d3b0b86
Merge pull request #14760 from bharatnc/ncb/event_time_microsec_p2
add event_time_microseconds field for system.{trace,text,query,query_thread}_log tables
2020-09-28 18:34:21 +03:00
zhang2014
e5a6d06820 ISSUES-15365 try fix integration test failure 2020-09-28 21:15:02 +08:00
detailyang
6e70f2ce7a bugfix:aggregate:fix boundingratio args check 2020-09-28 19:56:42 +08:00
zhang2014
e40d23cfe5 ISSUES-15365 add ya make 2020-09-28 19:11:40 +08:00
Nikita Mikhaylov
72e4b10c00
Merge pull request #14842 from hexiaoting/hxt_dev
Fix bug for LineAsString Format
2020-09-28 14:02:23 +03:00
zhang2014
d3047d0783 ISSUES-15365 fix attach mysql database failure 2020-09-28 18:02:30 +08:00
Nikita Mikhaylov
73573472e9
Merge pull request #15299 from CurtizJ/fix-mysql-hung
Fix hang of queries with a lot of subqueries to same mysql table
2020-09-28 12:51:35 +03:00
Anton Ivashkin
c2b692f2c7 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into multi_delete_in_s3 2020-09-28 12:00:34 +03:00
Anton Ivashkin
c18cdec77c Use S3 multi object delete
Some strange with s3_with_proxy test
2020-09-28 11:47:04 +03:00
tavplubix
ffc0499952
Merge pull request #15243 from ClickHouse/tavplubix-patch-1
Try fix race on Context::settings
2020-09-28 11:44:27 +03:00
alesapin
bc662ac4e0
Merge pull request #15293 from amosbird/bc3
Replace useless multiset with unordered_set
2020-09-28 10:30:04 +03:00
hustnn
a7024134dd Merge remote-tracking branch 'upstream/master' into zk_exist_fix2 2020-09-28 14:44:55 +08:00
Alexey Milovidov
57c6af479c Fix "Arcadia" 2020-09-28 03:26:15 +03:00
Alexey Milovidov
79f510d63a Fix error in LowCardinality; add test 2020-09-28 03:22:50 +03:00
Alexey Milovidov
a7ddd8489a Added format RawBLOB 2020-09-28 03:11:19 +03:00
Alexey Milovidov
b800a7fdf1 Add support for "Raw" column format for Regexp format 2020-09-28 01:09:32 +03:00
Alexander Tokmakov
3bc8d9daa9 fix sync 2020-09-27 14:10:45 +03:00
Alexander Tokmakov
34addcf61f add review suggestions 2020-09-26 22:18:28 +03:00
alexey-milovidov
bbbe51033d
Merge pull request #15321 from ClickHouse/query-obfuscator
Query obfuscator
2020-09-26 19:43:36 +03:00
tavplubix
df6221f7bf
Merge pull request #15302 from ClickHouse/tavplubix-patch-2
Fix ASTColumnsReplaceTransformer::Replacement::clone()
2020-09-26 19:10:00 +03:00
alesapin
59f2bbe2a3
Merge pull request #15304 from ClickHouse/fix_race_condition_on_rename
Fix race condition between write ahead log cleanup and rename
2020-09-26 10:43:26 +03:00
alesapin
adf8c94d70
Merge pull request #15300 from ClickHouse/fix_race_on_default_database
Fix for default database race on server startup
2020-09-26 10:43:17 +03:00
Alexey Milovidov
da8a938069 Replace unit test to functional test 2020-09-26 09:50:34 +03:00
feng lv
6d5cd95d3f fix 2020-09-26 14:48:59 +08:00
alexey-milovidov
fc1cf426dd
Merge pull request #15048 from markpapadakis/patch-5
Update ForkProcessor.cpp
2020-09-26 07:35:31 +03:00
alexey-milovidov
d1fce06292
Merge pull request #15297 from hexiaoting/build_bugfix
fix build bug for merge_selector2.cpp
2020-09-26 07:32:33 +03:00
Alexey Milovidov
57b480e65d Fix PVS warning 2020-09-26 07:03:55 +03:00
Alexey Milovidov
5e146eda04 Fix error 2020-09-26 06:02:05 +03:00
Alexey Milovidov
f3349c8d13 Keywords are case-insensitive 2020-09-26 05:13:20 +03:00
Alexey Milovidov
c51502bce4 Remove words with dashes 2020-09-26 05:06:14 +03:00
Alexey Milovidov
f97d40584d Fix "Arcadia" 2020-09-26 04:10:26 +03:00
Alexey Milovidov
bda2c2f58f Remove sensitive words 2020-09-26 03:53:26 +03:00
Alexey Milovidov
fc10803def Fix comment 2020-09-26 03:50:56 +03:00
Alexey Milovidov
d78fc63deb Remove duplicate word 2020-09-26 03:50:00 +03:00
Alexey Milovidov
22861b0c3d Remove some profanity 2020-09-26 03:49:30 +03:00
Alexey Milovidov
673f72cf8c Remove some profanity 2020-09-26 03:48:09 +03:00
Alexey Milovidov
ed4ff51ed8 Integrate into clickhouse-format; add test and comments 2020-09-26 03:38:59 +03:00
Alexey Milovidov
62c2c2000c Query obfuscator: development 2020-09-26 03:00:54 +03:00
bharatnc
5c8c636cf1 Fix - allow empty tz in exp like toStartOf*(today()) 2020-09-25 11:03:16 -07:00
bharatnc
4f8266c7a1 Make trace_log test to pass 2020-09-25 10:39:37 -07:00
bharatnc
b27579e3f7 Use std::chrono instead of clock_gettime 2020-09-25 10:39:37 -07:00
bharatnc
24ea6b2380 TraceCollector - time s&us using same timespec 2020-09-25 10:39:37 -07:00
bharatnc
324a06145c EventTime - construct time in s and us from same timespec 2020-09-25 10:39:37 -07:00