Azat Khuzhin
72d7b6117e
Use total_memory_tracker when there is no other MemoryTracker object.
...
This should significantly reduce the MemoryTracking drift, test shows
that there is 0 drift after query storm (100 queries, via http/tcp/tcp
in one session).
TL;DR;
To track memory, clickhouse creates memory tracker object for each
thread **explicitly**, but until it is not created the memory
allocations are not under account.
There should not be lot of allocations w/o memory tracker, since most of
the time it is created early enough, but even this maybe enough to
trigger some problems.
Plus sometimes it is not possible to create it, for example some 3d
party library does not allow to do this explicitly:
- for example before #15740 allocations from librdkafka threads,
- or even worse, poco threads, they don't have any routines to do this.
This won't be a problem for `MemoryTracking` metric if the deallocation
will be done from the same thread w/o memory tracker (or vise versa),
but this is not always true.
NOTE, that this will slow down per-thread allocations w/o memory
tracker, since before this patch there were no memory tracking for them
while now they will be accounted in total_memory_tracker, and for
total_memory_tracker max_untracked_memory is always reached.
But this should not be significant.
2020-10-23 21:07:52 +03:00
Mikhail Filimonov
f3a18864d5
After CR fixes - better & simpler. Issue in Context::shutdown fixed
2020-10-23 16:57:06 +02:00
Mikhail Filimonov
58df7f7883
clickhouse-local can work without tmp directory
2020-10-23 11:53:35 +02:00
Alexander Kuzmenkov
a1a7bc0217
Merge pull request #16192 from filimonov/clickhouse-local-segfault
...
Add setTemporaryStorage to clickhouse-local to make OPTIMIZE work
2020-10-22 20:47:28 +03:00
Alexander Kuzmenkov
ef39def7ff
Apply suggestions from code review
...
Co-authored-by: filimonov <1549571+filimonov@users.noreply.github.com>
2020-10-22 20:46:17 +03:00
Alexander Kuzmenkov
5cbf645de4
Merge remote-tracking branch 'origin/master' into tmp
2020-10-22 19:48:02 +03:00
Alexander Kuzmenkov
145e2b012f
cleanup
2020-10-22 19:47:20 +03:00
Mikhail Filimonov
111b553ee5
Better
2020-10-22 09:37:03 +02:00
Mikhail Filimonov
67cbb55d63
Fix compilation
2020-10-21 22:16:13 +02:00
Mikhail Filimonov
748ff404f9
Attempt to fix the race
2020-10-21 20:36:01 +02:00
alexey-milovidov
db481a33bd
Merge pull request #14135 from ClickHouse/simplify-init-script
...
Simplify init script
2020-10-21 03:37:50 +03:00
Alexey Milovidov
b26e979e5c
Added TODOs + minor adjustments
2020-10-21 01:13:41 +03:00
alexey-milovidov
2b00b5391a
Merge pull request #11844 from Enmk/AES_encrypt_decrypt
...
encrypt and decrypt functions
2020-10-20 22:57:35 +03:00
Alexey Milovidov
104019bd87
Set capabilities with caution
2020-10-20 21:09:15 +03:00
Mikhail Filimonov
d7ea9b6d93
Add setTemporaryStorage to clickhouse-local to make OPTIMIZE work
2020-10-20 17:57:53 +02:00
Alexander Kuzmenkov
84908df6d8
fix setting parent from HTTP traceparent
2020-10-20 14:35:13 +03:00
alexey-milovidov
b4f0e08369
Merge pull request #16158 from ClickHouse/minimal-ui
...
Added minimal web UI
2020-10-20 11:57:56 +03:00
Alexey Milovidov
3be41e55a7
Add comments
2020-10-20 04:08:30 +03:00
Alexey Milovidov
9ae144dc69
Edit comment
2020-10-20 04:05:29 +03:00
Alexey Milovidov
9b57f7cdc9
Minor changes
2020-10-20 03:39:24 +03:00
Alexey Milovidov
f8fef7eff6
Minor changes
2020-10-20 03:32:50 +03:00
Alexey Milovidov
a554ca5e62
Added /play handler; added a test
2020-10-20 03:28:33 +03:00
Alexey Milovidov
0af87e9598
Advancements and adjustments
2020-10-20 02:37:10 +03:00
Vitaly Baranov
235a493a25
Merge pull request #12736 from traceon/ldap-any-user-authentication
...
Add LDAP user directory support for locally non-existent users
2020-10-19 23:58:35 +03:00
Alexey Milovidov
f229185bee
Comments and corrections
2020-10-19 22:25:58 +03:00
Alexey Milovidov
7b4a537538
Added minimal web UI
2020-10-19 21:29:51 +03:00
Alexander Kuzmenkov
036cdd33c5
reset error code in ast fuzzer
2020-10-16 17:27:47 +03:00
Alexander Kuzmenkov
9116a00a12
reset error code in ast fuzzer
2020-10-16 17:26:59 +03:00
Alexey Milovidov
5e502c52b3
Merge branch 'master' into AES_encrypt_decrypt
2020-10-14 16:30:23 +03:00
Denis Glazachev
6eec447a64
Merge branch 'master' into ldap-any-user-authentication
...
* master: (189 commits)
Fix ugly links in docs
Update Internals.cpp
Whitespace
Fix ugliness in docs
better
better backticks
Try fix tests.
Fetch helper image before run
Fetch helper image before run
Fetch helper image before run
Update version_date.tsv after release 20.7.4.11
Update version_date.tsv after release 20.8.4.11
Update 01515_with_global_and_with_propagation.sql
fix compilation error
Supress pvs
Update version_date.tsv after release 20.9.3.45
Add missed file
fix thread restart for parallel quorum inserts
Update openssl
Fix race in openssl
...
2020-10-14 16:46:37 +04:00
Alexander Kuzmenkov
6200433e12
Merge origin/master into tmp (using imerge)
2020-10-12 21:15:31 +03:00
Amos Bird
e2643d881e
Prettify
2020-10-12 00:12:36 +08:00
alexey-milovidov
1aafa19146
Update Client.cpp
2020-10-11 13:27:09 +03:00
Amos Bird
ff665c362f
Add print query id support to client
2020-10-11 10:09:08 +08:00
Nikita Mikhaylov
dbb607573b
Update Internals.cpp
2020-10-10 02:31:33 +03:00
nikitamikhaylov
b45a4a2cd1
better
2020-10-09 20:44:54 +03:00
nikitamikhaylov
d0b610c6b2
better backticks
2020-10-09 19:58:45 +03:00
nikitamikhaylov
88a5302759
Merge branch 'master' of github.com:ClickHouse/ClickHouse into copier-backquotes
2020-10-09 16:26:31 +03:00
Alexey Milovidov
7d97c8b053
Remove useless code
2020-10-07 11:21:32 +03:00
alexey-milovidov
674d8d44b9
Update main.cpp
2020-10-05 09:28:52 +03:00
alexey-milovidov
8ff92a16ab
Update main.cpp
2020-10-05 08:01:08 +03:00
Azat Khuzhin
9e3ff349eb
Ensure that there will be no strlen() calls for SSE checks
2020-10-04 17:37:31 +03:00
Azat Khuzhin
2a6874e065
Run MADV_DONTNEED after SSE check to fix 01103_check_cpu_instructions_at_startup
2020-10-04 11:20:29 +03:00
Azat Khuzhin
caf3156fb7
Check MADV_DONTNEED (for jemalloc), maybe broken under qemu
...
jemalloc relies on working MADV_DONTNEED (that fact that after
madvise(MADV_DONTNEED) returns success, after subsequent access to those
pages they will be zeroed).
However qemu does not support this, yet [1], and you can get very tricky
assert if you will run clickhouse-server under qemu:
<jemalloc>: ../contrib/jemalloc/src/extent.c:1195: Failed assertion: "p[i] == 0"
[1]: https://patchwork.kernel.org/patch/10576637/
But after this patch you will get pretty error:
$ qemu-x86_64-static programs/clickhouse
MADV_DONTNEED does not zeroed page. jemalloc will be broken
2020-10-04 11:20:29 +03:00
Azat Khuzhin
9c09050e7c
Cleanup server instructions startup checking code
2020-10-04 01:47:44 +03:00
Denis Glazachev
44916af70a
Merge branch 'master' into ldap-any-user-authentication
...
* master: (279 commits)
Convert to python3 (#15007 )
update en and ru docs: add 128/256 types (#15515 )
Drop unused code for numeric_limits<int128> in MergeTreeDataSelectExecutor (#15519 )
Fix comment
More defaults on defaults
Recursive defaults
Fix bash
Update ActionsVisitor.cpp
Don't add memcpy for sanitizers builds
Fix gRPC build scripts.
Neutrialize thinlto's memcpy libcall gen.
Revert "Add fno-builtin-memcpy"
Throw an error when a single parameter is passed to ReplicatedMergeTree instead of ignoring it
Update SECURITY.md
Update tsan_suppressions.txt
Update ActionsVisitor.cpp
remove unrelated changes
Update SECURITY.md
fixes
Update ActionsVisitor.cpp
...
2020-10-03 00:45:57 +04:00
alesapin
17b86dec96
Recursive defaults
2020-10-02 15:38:50 +03:00
Alexander Kuzmenkov
244687bfc1
Merge remote-tracking branch 'origin/master' into HEAD
2020-10-01 18:41:48 +03:00
Alexander Kuzmenkov
626c2a3e28
microsecond precision for start/finish time
2020-09-30 19:16:33 +03:00
Alexey Milovidov
e65465ac16
Fix install script
2020-09-29 00:11:08 +03:00
tavplubix
4578d89819
Merge pull request #15348 from ClickHouse/replicate_default_args
...
Continuation of #14791
2020-09-28 18:53:02 +03:00
Alexander Kuzmenkov
218d86de7e
Merge remote-tracking branch 'origin/master' into tmp
2020-09-28 16:29:51 +03:00
Nikita Mikhaylov
a4832ed5ce
Merge branch 'master' into HyaZz-master
2020-09-28 13:55:45 +03:00
Alexander Tokmakov
34addcf61f
add review suggestions
2020-09-26 22:18:28 +03:00
alexey-milovidov
bbbe51033d
Merge pull request #15321 from ClickHouse/query-obfuscator
...
Query obfuscator
2020-09-26 19:43:36 +03:00
alesapin
adf8c94d70
Merge pull request #15300 from ClickHouse/fix_race_on_default_database
...
Fix for default database race on server startup
2020-09-26 10:43:17 +03:00
Alexey Milovidov
57b480e65d
Fix PVS warning
2020-09-26 07:03:55 +03:00
Alexey Milovidov
3a2c809173
Add missing dependencies
2020-09-26 04:59:25 +03:00
Alexey Milovidov
ed4ff51ed8
Integrate into clickhouse-format; add test and comments
2020-09-26 03:38:59 +03:00
Denis Glazachev
8f2c23e6de
Merge branch 'master' into ldap-any-user-authentication
...
* master: (224 commits)
Update in.md
Add a test for embedded configs
Allow to run without /proc/self/maps
Update adopters.md
More convenient
Enable embedded configs for AArch64
More results
More handy
More handy
Added a comment
Adjustments
Adjustments
Adjustments
Added new results
Step 1: make adding hardware benchmark results more convenient
Revert "Avoid deadlocks in Log/TinyLog"
Fix MSan report in QueryLog
add some disabled tests from arcadia to skip_list.json
Update skip_list.json
Bump CI. [2]
...
# Conflicts:
# docker/test/testflows/runner/Dockerfile
2020-09-25 17:33:50 +04:00
alesapin
97671a1771
Ugly fix for default database race
2020-09-25 14:27:00 +03:00
tavplubix
b96157e32b
Merge branch 'master' into enable_atomic_database_by_default
2020-09-25 13:42:39 +03:00
Alexey Milovidov
1f6e55ff35
Allow to run without /proc/self/maps
2020-09-25 05:03:58 +03:00
Alexey Milovidov
f5eead5b2a
Enable embedded configs for AArch64
2020-09-25 04:45:47 +03:00
Alexander Tokmakov
f0f91f84af
Merge branch 'master' into enable_atomic_database_by_default
2020-09-23 21:50:15 +03:00
Alexander Tokmakov
a8266a3d3c
fix DDDL with cross-replication and Atomic
2020-09-23 21:28:59 +03:00
alesapin
39f23fbb8f
Merge pull request #14711 from myrrc/feature/cmake-flags-doc-generator
...
CMake flags reference generator, the guide for adding new options, and the attempt to correct the existing options
2020-09-23 18:56:32 +03:00
alesapin
269d225637
Merge branch 'master' into myrrc-feature-cmake-flags-doc-generator
2020-09-22 17:00:02 +03:00
Alexander Kuzmenkov
679c0988a5
Merge remote-tracking branch 'origin/master' into HEAD
2020-09-22 16:25:52 +03:00
Alexander Kuzmenkov
dde4cf70e1
Merge remote-tracking branch 'origin/master' into HEAD
2020-09-22 14:03:59 +03:00
Alexander Kuzmenkov
7b64ca33b1
Merge remote-tracking branch 'origin/master' into tmp
2020-09-22 14:02:20 +03:00
Alexander Kuzmenkov
bfc3be9e43
Merge remote-tracking branch 'origin/aku/tcp-versio' into tmp
2020-09-22 14:02:15 +03:00
Alexander Kuzmenkov
478c7309d4
Merge pull request #14843 from ClickHouse/aku/global-pool
...
Exception on double init of global thread pool
2020-09-22 13:44:39 +03:00
Alexander Kuzmenkov
e97c9b16a7
more diagnostics in fuzzer
2020-09-22 13:35:28 +03:00
Alexander Tokmakov
13e41cdd20
try enable atomic database by default
2020-09-21 13:55:34 +03:00
alexey-milovidov
3e0509af69
Merge pull request #13573 from amosbird/rms
...
specific ReplicatedMergeTree settings
2020-09-21 01:36:33 +03:00
Denis Glazachev
442b1407cf
Merge branch 'master' into ldap-any-user-authentication
...
* master: (375 commits)
Update type-conversion-functions.md
Update maxmap.md
Update maxmap.md
Update maxmap.md
Update single_fixed_string_groupby.xml
Alter remove column properties and TTLs (#14742 )
better fixed string group by support
Fix incorrect key condition of fixed strings.
constant output order
more tests for #14646
Maybe fix MSan report in base64
Proper exception message for wrong number of arguments of CAST
Added a test
Fix buffer overflow in "bar" function
Update convertMySQLDataType.cpp
Fix clang-tidy
Remove obsolete code from performance test
Slightly better code
Even more
Even more
...
# Conflicts:
# src/Interpreters/Context.cpp
2020-09-21 00:31:04 +04:00
alexey-milovidov
1474b80ecc
Merge pull request #15008 from ClickHouse/clang-tidy-11-without-enabling
...
Fix terribly wrong code
2020-09-20 02:00:54 +03:00
myrrc
c78d9f9f38
moved the generators to docs/ folder
2020-09-19 19:42:36 +03:00
alexey-milovidov
c461d782e4
Merge pull request #14929 from ClickHouse/mlock-code-segment
...
Only mlock code segment
2020-09-19 13:46:49 +03:00
Alexey Milovidov
ef5363b87f
Fix terribly wrong code
2020-09-19 02:05:13 +03:00
alexey-milovidov
988b20a32c
Merge pull request #14684 from azat/parallel-distributed_ddl
...
Allow parallel execution of distributed DDL
2020-09-18 22:18:17 +03:00
myrrc
f6bce8bd1e
reverted USE to ENABLE
2020-09-18 17:18:59 +03:00
myrrc
3953ed485b
added sub-tables in report, replaced some USE_ -> ENABLE_ for
...
consistency
2020-09-18 16:09:22 +03:00
Alexander Kuzmenkov
449189dcda
Initialize global thread pool before we fetch configs from ZK
2020-09-18 13:47:09 +03:00
alexey-milovidov
cf5db5e4dc
Merge pull request #14888 from azat/client-imporove-INSERT-error-message
...
Improve error message for INSERT via clickhouse-client
2020-09-18 01:13:22 +03:00
Alexey Milovidov
799a675b5d
Merge branch 'master' into AES_encrypt_decrypt
2020-09-17 21:42:51 +03:00
Alexey Milovidov
eb523f1a7c
Merge branch 'master' into mlock-code-segment
2020-09-17 21:15:09 +03:00
myrrc
a8fa23fb9d
updated multi-line command
2020-09-17 19:27:51 +03:00
myrrc
507acdb5e7
fix
2020-09-17 19:17:56 +03:00
myrrc
7cd5c0d34f
Merge remote-tracking branch 'upstream/master' into feature/cmake-flags-doc-generator
2020-09-17 19:17:09 +03:00
myrrc
7eff17cd40
removed extra dots in generated list
2020-09-17 18:46:55 +03:00
myrrc
acff0feb58
slighly updated CMake files
2020-09-17 18:09:59 +03:00
Alexey Milovidov
08668de2c1
Remove previous modification
2020-09-17 17:39:22 +03:00
Alexey Milovidov
5ba1ad73d0
Merge branch 'back_quote_in_copier' into HyaZz-master
2020-09-17 17:38:48 +03:00
Alexey Milovidov
4cf131256a
Merge branch 'master' of https://github.com/HyaZz/ClickHouse into HyaZz-master
2020-09-17 17:38:41 +03:00
Alexey Milovidov
c1e9ce2cf2
Remove questionable code
2020-09-17 17:38:06 +03:00
Alexander Kuzmenkov
fb64cf210a
straighten the protocol version
2020-09-17 17:37:29 +03:00
alexey-milovidov
e101c912aa
Update Internals.cpp
2020-09-17 17:19:10 +03:00
Vitaly Baranov
3356d75b23
Merge pull request #13156 from azat/cluster-secure
...
Secure inter-cluster query execution (with initial_user as current query user) [v3]
2020-09-17 17:11:00 +03:00