Commit Graph

7632 Commits

Author SHA1 Message Date
Alexander Tokmakov
6bc6ef8f2e fix test 2021-09-19 01:12:11 +03:00
alexey-milovidov
20d8523a2e
Merge pull request #28888 from azat/mysql-in-fix
Fix queries to external databases (i.e. MySQL) with multiple columns in IN ( i.e. `(k,v) IN ((1, 2))` )
2021-09-18 15:53:40 +03:00
alexey-milovidov
2a9c6fb9fc
Merge pull request #29153 from azat/test-2010_lc_native-fix
Increase timeout in 2010_lc_native
2021-09-18 15:43:46 +03:00
alexey-milovidov
3eed1f06ea
Merge pull request #28952 from fuzzERot/h3-functions
Implementation of h3ToGeoBoundary
2021-09-18 14:27:11 +03:00
Azat Khuzhin
7f5f0e364d Increase timeout in 2010_lc_native
10 seconds it not enough [1]:

    2010_lc_native:                                                         [ FAIL ] 15.53 sec. - having stderror:
    Traceback (most recent call last):
      File "/usr/share/clickhouse-test/queries/0_stateless/2010_lc_native.python", line 302, in <module>
        main()
      File "/usr/share/clickhouse-test/queries/0_stateless/2010_lc_native.python", line 298, in main
        insertLowCardinalityRowWithIndexOverflow()
      File "/usr/share/clickhouse-test/queries/0_stateless/2010_lc_native.python", line 259, in insertLowCardinalityRowWithIndexOverflow
        readException(s)
      File "/usr/share/clickhouse-test/queries/0_stateless/2010_lc_native.python", line 185, in readException
        assert(readVarUInt(s) == 2)
      File "/usr/share/clickhouse-test/queries/0_stateless/2010_lc_native.python", line 65, in readVarUInt
        byte = readStrict(s)[0]
      File "/usr/share/clickhouse-test/queries/0_stateless/2010_lc_native.python", line 34, in readStrict
        cur = s.recv(size)
    socket.timeout: timed out

  [1]: https://clickhouse-test-reports.s3.yandex.net/29060/7f1160c466a968c680d1bc73e0ad5e9419d0b6d0/functional_stateless_tests_(debug).html#fail1

Server log:

    2021.09.17 21:02:53.734388 [ 682 ] {123456} <Trace> ContextAccess (default): Access granted: INSERT(x) ON test_0tmdh4.tab
    2021.09.17 21:03:04.835044 [ 682 ] {123456} <Error> executeQuery: Code: 117. DB::Exception: Index for LowCardinality is out of range. Dictionary size is 1, but found index with value 72057594037927936. (INCORRECT_DATA) (version 21.11.1.8109) (from [::ffff:127.0.0.1]:59512) (in query: insert into test_0tmdh4.tab format TSV settings input_format_defaults_for_omitted_fields=0), Stack trace (when copying this message, always include the lines below):

And according to trace_log the problem is slow unwind:

    2021-09-17 21:02:55.103893 libunwind::LocalAddressSpace::get32
    2021-09-17 21:02:56.151960 libunwind::LocalAddressSpace::get8
    2021-09-17 21:03:03.168447 libunwind::LocalAddressSpace::getULEB128
2021-09-18 10:53:02 +03:00
Amos Bird
6b3cd34cff
Disable projections when ARRAY JOIN is used. 2021-09-18 08:15:59 +08:00
Kruglov Pavel
9fb73af891
Mark test as no-parallel 2021-09-17 23:54:09 +03:00
Kruglov Pavel
5ab8d5beda
Delete grep 2021-09-17 23:52:28 +03:00
Alexander Tokmakov
3bca886174 remove some trash 2021-09-17 22:29:10 +03:00
Kruglov Pavel
e9f0137340
Update test 2021-09-17 20:14:37 +03:00
Maksim Kita
784a4a33e0 Fixed tests 2021-09-17 18:43:00 +03:00
Maksim Kita
93ecbf3ae4 Added tests 2021-09-17 18:42:59 +03:00
Pavel Kruglov
aba86b010b Update docs, tests and add some fixes 2021-09-17 17:32:23 +03:00
Pavel Kruglov
fe79db79af Change test 2021-09-17 16:14:33 +03:00
Pavel Kruglov
48a3a2f75c Fix segfault in Avro with LowCardinality(Nullable) 2021-09-17 16:11:44 +03:00
Maksim Kita
14e4d49601
Merge pull request #29063 from ClickHouse/read-integer-overflow-bug-fix
Merging #27963
2021-09-17 16:06:58 +03:00
Nikolai Kochetov
a8c3b02598 Merge branch 'master' into rewrite-pushing-to-views 2021-09-17 15:38:11 +03:00
Vladimir C
333fd323f5
Merge pull request #29062 from Avogar/orc-fixes 2021-09-17 14:48:19 +03:00
PHO
3c4b1ea9c5 New setting: output_format_csv_null_representation
This is the same as output_format_tsv_null_representation but is for CSV output.
2021-09-17 17:58:23 +09:00
Nikita Mikhaylov
c52b8ec083
Introduced MergeTask and MutateTask (#25165)
Introduced MergeTask and MutateTask
2021-09-17 00:19:58 +03:00
Anton Popov
99175f7acc minor enhancements in async inserts 2021-09-16 20:55:34 +03:00
Anton Popov
77a995381b
Merge pull request #28975 from ClickHouse/check-what-if-do-not-add-const-agg-keys-with-having
Don not add const group by key for query with only having.
2021-09-16 18:33:53 +03:00
Pavel Kruglov
96dba14213 Improve MsgPack input/output format 2021-09-16 17:05:07 +03:00
vdimir
661a54827b
Do not throw LOGICAL_ERROR from fuse quantile for illegal params 2021-09-16 16:06:02 +03:00
mergify[bot]
d4ac1fdba0
Merge branch 'master' into h3-functions 2021-09-15 21:24:31 +00:00
Maksim Kita
7a72a765c2 Added tests 2021-09-16 00:01:01 +03:00
mergify[bot]
a8e9450d91
Merge branch 'master' into exp-smooth 2021-09-15 20:55:32 +00:00
Pavel Kruglov
2e9858172e Allow to input and output LowCardinality columns in ORC format 2021-09-15 22:04:36 +03:00
Anton Popov
f6191b98e7 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-15 17:47:22 +03:00
Anton Popov
8970dcdaf5 fix throwing exception for multiple clients in async inserts 2021-09-15 17:19:28 +03:00
Kruglov Pavel
8d1bf1b675
Merge pull request #29008 from vdimir/issue-26980-join-id-alias
Do not replaceAliasColumnsInQuery for JOIN OR/USING sections
2021-09-15 16:27:46 +03:00
Nikita Mikhaylov
2684d06b51
Merge pull request #27135 from FArthur-cmd/compressed_output_formats_3473
compress INTO OUTFILE with parameter compress
2021-09-15 16:25:13 +03:00
Kruglov Pavel
8a67c3cf44
Merge pull request #28636 from amosbird/nullable-index-fix
Fix nullable/lowcardinality primary key with constant conversion
2021-09-15 15:56:19 +03:00
vdimir
cd7fb8132d
Split GatherFunctionQuantileVisitor to h/cpp, fix fuzzed bugs 2021-09-15 15:15:42 +03:00
kssenii
710c8d12dd Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-15 12:28:09 +03:00
Maksim Kita
69e59f34da
Merge pull request #29014 from vdimir/issue-29007-dict-join-strictness
Check left join strictness in tryInitDictJoin
2021-09-15 11:11:30 +03:00
Anton Popov
dafc6d32ef add test to access rights 2021-09-15 01:42:28 +03:00
Anton Popov
fc17936c12 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-14 23:02:30 +03:00
mergify[bot]
fa903ac255
Merge branch 'master' into describe-with-subcolumns 2021-09-14 14:43:29 +00:00
Nikolai Kochetov
0e267c50b4 Merge branch 'master' into rewrite-pushing-to-views 2021-09-14 16:13:54 +03:00
Nikolai Kochetov
fc1456164a Add test from #28880 2021-09-14 15:50:39 +03:00
vdimir
a3304a87a4
Rename optimize_syntax_fuse_aggregate -> optimize_syntax_fuse_functions 2021-09-14 15:27:12 +03:00
vdimir
a1463d5719
Merge remote-tracking branch 'origin/master' into fuse_quantile 2021-09-14 15:23:06 +03:00
vdimir
5a1aeeb044
Use optimize_syntax_fuse_aggregate instead of optimize_fuse_sum_count_avg and optimize_fuse_quantile 2021-09-14 15:21:16 +03:00
vdimir
a3db56f056
Revert "fuse multi setting options into one when Optimize"
This reverts commit bbd7799375.
2021-09-14 15:12:21 +03:00
vdimir
32e8c11cab
Check left join strictness in tryInitDictJoin 2021-09-14 15:04:45 +03:00
Anton Popov
4403847744
Merge pull request #28325 from nicelulu/issues_27763
Bit shift operations for FixedString and String data types.
2021-09-14 14:45:29 +03:00
vdimir
3d2d994c5d
Skip JOIN OR/USING sections in replaceAliasColumnsInQuery 2021-09-14 14:13:19 +03:00
Nikolai Kochetov
6847610ed3
Merge pull request #28997 from ClickHouse/fix-num-threads-in-global-in-subquery
Fix num threads in global in subquery
2021-09-14 13:53:54 +03:00
hexiaoting
bbd7799375 fuse multi setting options into one when Optimize 2021-09-14 18:51:13 +08:00
Nikolai Kochetov
1b89719462
Update 2015_global_in_threads.sh 2021-09-14 11:53:53 +03:00
Alexander Tokmakov
f03484e0dc fix test 2021-09-14 11:46:40 +03:00
Nikolay Degterinsky
4204e20f06
Merge pull request #29001 from azat/fix-01150_ddl_guard_rwr
Fix 01150_ddl_guard_rwr test
2021-09-14 11:37:23 +03:00
vdimir
1fdbb9509f
Add additional checkTypesOfKeys to JoiningTransform::transformHeader 2021-09-14 11:03:22 +03:00
Vladimir C
6e526aff89
Merge pull request #28969 from vdimir/01115-explicit-db
Remove explicit DB in 01115_join_with_dictionary
2021-09-14 10:26:51 +03:00
Azat Khuzhin
1792b23a2c Fix 01150_ddl_guard_rwr test
CI report [1]:

    2021-09-13 09:55:27 Code: 219. DB::Exception: Received from localhost:9000. DB::Exception: New table appeared in database being dropped or detached. Try again.. (DATABASE_NOT_EMPTY)
    2021-09-13 09:55:27 Code: 82. DB::Exception: Received from localhost:9000. DB::Exception: Database test_01150 already exists.. (DATABASE_ALREADY_EXISTS)

  [1]: https://clickhouse-test-reports.s3.yandex.net/0/abe314feecd1647d7c2b952a25da7abf5c19f352/functional_stateless_tests_(release,_databaseordinary)/test_run.txt.out.log
2021-09-14 00:30:40 +03:00
alesapin
abe314feec
Merge pull request #28962 from azat/create-settings
Apply settings from CREATE AS SELECT queries
2021-09-13 22:14:21 +03:00
Nikolai Kochetov
e8bc0287ff Add test. 2021-09-13 20:53:31 +03:00
Anton Popov
7ec5c73c9b
Merge branch 'master' into issues_27763 2021-09-13 20:33:29 +03:00
Alexander Tokmakov
8ac19caca9 Merge branch 'master' into tables_topsort 2021-09-13 16:58:39 +03:00
vdimir
9ebef6e3cf
Remove explicit DB in 01115_join_with_dictionary 2021-09-13 13:06:38 +03:00
mergify[bot]
d731bf6c4d
Merge branch 'master' into compressed_output_formats_3473 2021-09-13 09:14:35 +00:00
Nikita Mikhaylov
4b3c0a95d1
Merge pull request #28046 from syominsergey/fix-build-clang-13-2
[WIP] Improve support for build with clang-13
2021-09-13 12:11:38 +03:00
Maksim Kita
6161365b4e
Merge pull request #28540 from azat/fix-zookeeper_mutations_and_insert_quorum_long
Fix insert_quorum_timeout in zookeeper_mutations_and_insert_quorum_long
2021-09-13 11:27:11 +03:00
Filatenkov Artur
c23fe5baf6
Improve codec for encr 19896 (#27476)
* change syntax of encrypted command

* commit all encrypted changes

* correct encryption

* correct config for test

* add tests and correct code style and typos

* correct test

* fix unbundled build

* add log warning messages

* improve code according to review comments

* correct nonce

* correct errors found by fuzzing

* improve codec AES_128_GCM_SIV. Add AES_256_GCM_SIV. Add sections for last in tests. Improve documentation

* Update CompressionCodecEncrypted.h

* Update 01683_codec_encrypted.sql

* correct compression factory after changes in master

* correct behavior with wrong key in data

* correct fuzzer

* add connection for fuzzer with fix for compression_encrypted

* refactor code

* add load from config with throwing errors on server start

* fix typos and check style

* Update Server.cpp

* correct loading and reading

* refactor code. fix uninitialized value

* refactor code

* move defines from server to cpp file

* correct build

* remove repeated code

* correct namespace

* fix code style
2021-09-13 11:25:36 +03:00
Maksim Kita
e9d7dfeeb1
Merge pull request #28863 from kitaisreal/column-default-dict-get-identifier-fix
Column default dictGet identifier fix
2021-09-13 10:56:39 +03:00
Azat Khuzhin
dad02452c8 Apply settings from CREATE AS SELECT queries 2021-09-13 10:10:00 +03:00
alexey-milovidov
ad997cf51e
Merge branch 'master' into exp-smooth 2021-09-13 07:29:49 +03:00
alexey-milovidov
b467df98d3
Update 02006_h3_to_geo_boundary.sql 2021-09-13 07:25:46 +03:00
Vitaly Baranov
512786346c
Merge pull request #28909 from vitlibar/convert-skip-list-into-first-line-comments
Convert skip_list .json into first line comments
2021-09-13 03:37:39 +03:00
fuzzERot
dba428c443 Implementation of h3ToGeoBoundary 2021-09-12 23:47:51 +03:00
Nikolay Degterinsky
b02c807346
Merge pull request #27481 from nicelulu/add_sparkbar
Add sparkbar aggregate function.
2021-09-12 21:29:24 +03:00
Sergei Semin
12e24a23d3
Merge branch 'master' into fix-build-clang-13-2 2021-09-12 19:30:55 +03:00
Vitaly Baranov
daa5979347 Remove unnecessary files. 2021-09-12 17:15:28 +03:00
Vitaly Baranov
39d73c01b2 Add tags to tests. 2021-09-12 17:15:28 +03:00
Vitaly Baranov
bbb192ee85 Convert skip_list.json into first line comments. 2021-09-12 17:15:23 +03:00
Kseniia Sumarokova
d4823d41b0
Merge pull request #28890 from azat/client-improvements-v2
Add query to the exception message in case of error during processing INSERT block on client
2021-09-12 16:07:57 +03:00
alexey-milovidov
aa5c42b7db
Merge pull request #28773 from azat/nth_value-ubsan-fix
Fix signed integer overflow for nth_value() window function
2021-09-12 15:57:19 +03:00
alexey-milovidov
cdcfdbec7e
Merge pull request #28873 from CurtizJ/fix-subcolumns-compact-parts
Fix reading of subcolumns from compact parts
2021-09-12 15:54:07 +03:00
alexey-milovidov
f066edc43c
Merge pull request #28910 from ClickHouse/fix-trash-optimization
Fix bad optimization of ORDER BY in subquery if it contains WITH FILL
2021-09-12 15:27:53 +03:00
alexey-milovidov
ea13a8b562
Merge pull request #28659 from myrrc/improvement/tostring_to_magic_enum
Improving CH type system with concepts
2021-09-12 15:26:29 +03:00
Alexey Milovidov
9ea1d443ba Add exponentialMovingSum aggregate function 2021-09-12 12:26:13 +03:00
alexey-milovidov
1616a0e230
Merge pull request #28887 from Avogar/fix-short-circuit
Fix bug with LowCardinality in short-curcuit function evaluation
2021-09-12 09:06:02 +03:00
Alexey Milovidov
797e1f4fd4 Add more tests 2021-09-12 08:37:51 +03:00
Alexey Milovidov
0745631bf7 Add aggregate function for exp smoothing 2021-09-12 08:26:07 +03:00
Alexey Milovidov
7899c6a0f1 One more 2021-09-12 03:00:09 +03:00
Alexey Milovidov
98a25f3ece Add a test 2021-09-12 02:56:47 +03:00
Alexey Milovidov
8935a70f60 Fix another misoptimization 2021-09-12 01:41:37 +03:00
Alexey Milovidov
d85588210d Fix bad optimization of ORDER BY in subquery if it contains WITH FILL 2021-09-12 01:24:20 +03:00
Anton Popov
02a7edf902 allow to include subccolumns in describe query 2021-09-12 00:07:33 +03:00
Azat Khuzhin
c7e5cd7cda Fix arrayCumSumNonNegative() for consts 2021-09-11 22:39:30 +03:00
Azat Khuzhin
6403cbee46 Fix arrayDifference() for consts 2021-09-11 22:39:30 +03:00
Azat Khuzhin
3c75844a79 Fix SIGSEGV for arrayCompact() with consts
arrayCompact() implements useDefaultImplementationForConstants() but it
is a no-op for FunctionArrayMapped, fix this.

CI report [1]:

  [1]: https://clickhouse-test-reports.s3.yandex.net/28890/baac2e561cfb05bc174f0bd25571e607d19c7463/fuzzer_asan/report.html#fail1
2021-09-11 22:39:20 +03:00
Azat Khuzhin
2f34ab1717 tests: update 00900_long_parquet_load.reference 2021-09-11 21:59:42 +03:00
Sergei Semin
d2c678928c remove cases with unspecified behaviour (out of UInt64 range) 2021-09-11 18:14:00 +03:00
alexey-milovidov
648d561242
Merge pull request #28828 from azat/nested-combinators
Relax nested function for If-combinator check (but forbid nested identical combinators)
2021-09-11 15:53:19 +03:00
Azat Khuzhin
976874d57b tests/01016_input_null_as_default: remove one more tuple nesting
CI report [1]:

    01016_input_null_as_default:                                            [ FAIL ] - having stderror:
    Code: 53. DB::Exception: Bad size of tuple. Expected size: 1, actual size: 2.: While executing ValuesBlockInputFormat: data for INSERT was parsed from stdin. (TYPE_MISMATCH)

  [1]: https://clickhouse-test-reports.s3.yandex.net/28888/5ad9cb9b797abe498ae558f9c233e16cd89e41b4/fast_test.html#fail1
2021-09-11 15:38:30 +03:00
Azat Khuzhin
b51c180922 tests/00132_sets: remove one more tuple nesting
CI report [1]:

    2021-09-11 14:25:31 [5656ccb14ed9] 2021.09.11 14:25:31.498685 [ 18561 ] {6096a73f-2066-4c78-9f99-73f013c96deb} <Error> executeQuery: Code: 43. DB::Exception: Invalid types for IN function: Tuple(UInt8, Tuple(UInt8, UInt8)) and Tuple(Tuple(Tuple(UInt8, Tuple(UInt8, UInt8)), Tuple(UInt8, Tuple(UInt8, UInt8)))).: While processing (1 AS number, (2, 3) AS tuple) IN tuple(((1, (2, 3)), (4, (5, 6)))). (ILLEGAL_TYPE_OF_ARGUMENT) (version 21.11.1.1) (from [::1]:32780) (comment: 00132_sets.sql) (in query: SELECT number, tuple FROM (SELECT 1 AS number, (2, 3) AS tuple) WHERE (number, tuple) IN (((1, (2, 3)), (4, (5, 6))));), Stack trace (when copying this message, always include the lines below):

  [1]: https://clickhouse-test-reports.s3.yandex.net/28888/5ad9cb9b797abe498ae558f9c233e16cd89e41b4/fast_test.html#fail1
2021-09-11 15:29:43 +03:00
Pavel Kruglov
9c756fc4b2 Fix bug with LowCardinality in short-curcuit function evaluation 2021-09-11 12:56:25 +03:00
Artur
c77a65f9d5 avoid error with order 2021-09-11 07:28:54 +00:00
Azat Khuzhin
c6b9816d45 tests: mark 00763_lock_buffer as long
https://clickhouse-test-reports.s3.yandex.net/28827/58266e4ed6db77109e6237ecd2612d34c0b19516/functional_stateless_tests_flaky_check_(address).html#fail1
2021-09-11 09:15:38 +03:00
Azat Khuzhin
f7540dad56 tests: update 01305_replica_create_drop_zookeeper after client query printing 2021-09-11 09:13:23 +03:00
Mike Kot
c4385a2c40 Simplifying exception messages 2021-09-11 00:40:18 +02:00
Azat Khuzhin
58266e4ed6 tests/queries/0_stateless/01175_distributed_ddl_output_mode_long: use unique tmp file 2021-09-10 23:23:24 +03:00
Azat Khuzhin
4336038711 tests: update more references after client started printing query 2021-09-10 23:19:16 +03:00
Azat Khuzhin
1e7714d56d Forbid nested identical (only) combinators
Nested identical combinators (i.e. uniqCombinedIfIf) is not
supported (since they even don't work -- silently).

But non-identical does supported and works, for example
uniqCombinedIfMergeIf, it is useful in case when the underlying
storage stores AggregateFunction(uniqCombinedIf) and in SELECT you
need to filter aggregation result based on another column for
example.
2021-09-10 21:03:24 +03:00
Azat Khuzhin
60df1e8800 Relax nested function for If-combinator check
Second If combinator can be useful to add condition based on another
column, when Merge combinator is applied for example (i.e.
uniqCombinedIfMergeIf(state_of_merge_that_is_stored_in_table, event_date = today())).
2021-09-10 21:03:24 +03:00
Azat Khuzhin
c4a24c7696 tests: update reference after client started printing query 2021-09-10 21:02:55 +03:00
Azat Khuzhin
b383115389 Allow values up to INT64_MAX for nth_value/lagInFrame/leadInFrame 2021-09-10 21:02:06 +03:00
Azat Khuzhin
62a29420bd Fix signed integer overflow for nth_value() window function
CI report [1]:

    ../src/Processors/Transforms/WindowTransform.cpp:1699:54: runtime error: signed integer overflow: -9223372036854775808 - 1 cannot be represented in type 'long' Received signal -3 Received signal Unknown signal (-3)

In query:

    SELECT
        number,
        nth_value(number, 2147483648) OVER w,
        anyOrNull(number) OVER (ORDER BY -2147483648 - intDiv(number, 1024) DESC NULLS FIRST, number DESC ROWS BETWEEN 65535 FOLLOWING AND UNBOUNDED FOLLOWING),
        nth_value(number, 65537) OVER w AS firstValue,
        nth_value(number, -9223372036854775808) OVER w AS secondValue,
        nth_value(number, 1048576) OVER w AS thirdValue
    FROM numbers(1)
    WINDOW w AS (ORDER BY number DESC)
    ORDER BY number DESC

  [1]: https://clickhouse-test-reports.s3.yandex.net/28532/7623af5513e12aa8dfa1bee963caffe00185c31a/fuzzer_ubsan/report.html#fail1
2021-09-10 21:02:04 +03:00
Anton Popov
a63887413c fix reading of subcolumns from compact parts 2021-09-10 20:19:18 +03:00
Nikolai Kochetov
3a9d88fbc9 Fix more tests. 2021-09-10 17:52:24 +03:00
Maksim Kita
a87ffdff92 Column default dictGet identifier fix 2021-09-10 17:41:09 +03:00
Anton Popov
0bb74f8eaf
Merge pull request #28762 from CurtizJ/fix-nested-1
Fix usage of nested columns with non-array columns with the same prefix [2]
2021-09-10 17:34:43 +03:00
Artur
a7c43c3e2d add compression key-word and some tests 2021-09-10 13:59:22 +00:00
Anton Popov
5cff615eca Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-10 13:40:48 +03:00
mergify[bot]
95be9c3571
Merge branch 'master' into add_sparkbar 2021-09-10 10:19:27 +00:00
Alexander Tokmakov
3f8fb1e562 Merge branch 'master' into tables_topsort 2021-09-10 13:16:41 +03:00
Maksim Kita
bdbf0c1967
Merge pull request #28821 from azat/compile-short-circuit-eval
Fix expressions compilation with short circuit evaluation
2021-09-10 00:49:00 +03:00
Azat Khuzhin
63e14fc389 Fix expressions compilation with short circuit evaluation
Before this patch, you may get the following error:

    Column Function is not a contiguous block of memory

Since under short circuit evaluation you may get Function not the
result.
2021-09-09 22:43:11 +03:00
Anton Popov
4eae64b174 add stress test for async inserts 2021-09-09 20:17:19 +03:00
kssenii
904cf74159 Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-09 15:26:20 +03:00
Nikolai Kochetov
13eb93a9c0
Merge pull request #28700 from amosbird/projection-fix16
Fix crash on exception with projection aggregate
2021-09-09 15:24:05 +03:00
Anton Popov
8e5b3b2f6c Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-09 15:12:34 +03:00
Nikolai Kochetov
abfb1d20ea
Merge pull request #25734 from vdimir/join-arrayjoin-type-cast
Move join type inference to ExpressionAnalyzer from syntax stage + small refactor
2021-09-09 14:38:43 +03:00
tavplubix
341a6c51d6
Merging #24866 (#28691)
* Add StorageSystemISTables.cpp/.h

* Another attempt

* Columns and Views

* Add information schema db and fix information schema 'tables' table

* fix build

* remove copy-paste, add views to system tables

* add test

* fix

* fix_tests

Co-authored-by: Damir Petrov <petrovdamir2235@gmail.com>
Co-authored-by: Damir Petrov <0442a403@verstehen.sas.yp-c.yandex.net>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-09-09 12:37:51 +03:00
Amos Bird
91293c7449
Fix crash on exception with projection aggregate 2021-09-09 10:43:56 +08:00
kssenii
797f858bc6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-08 22:52:48 +03:00
Anton Popov
9816014f6c fix nested and scalar columns with dot, which is missed in part 2021-09-08 21:42:34 +03:00
Anton Popov
f864c4252a support adding defaults in async inserts 2021-09-08 17:08:57 +03:00
mergify[bot]
64fb384656
Merge branch 'master' into global-merge-executor 2021-09-08 13:15:38 +00:00
mergify[bot]
9f0c50335f
Merge branch 'master' into tables_topsort 2021-09-08 10:55:11 +00:00
Anton Popov
5d33baab5f
Merge pull request #28658 from CurtizJ/fix-or-to-in
Fix optimization of disjunctions chain in distributed queries
2021-09-08 13:26:45 +03:00
alesapin
3b9dae8718
Merge pull request #28616 from ClickHouse/qoega-try-llvm-12
Merging #20495
2021-09-08 11:43:46 +03:00
Vladimir C
70fbc85768
Merge pull request #28686 from ljcui/distributed_coredump
Fix coredump in creating distributed table
2021-09-08 10:52:56 +03:00
Nikita Mikhaylov
6062dd0021 Better 2021-09-08 00:21:21 +00:00
Nikita Mikhaylov
e398af08dc Maybe fix test 2021-09-07 19:53:51 +00:00
Vitaly Baranov
59148fa453
Merge pull request #22415 from Enmk/governance/session_log
Governance/session log
2021-09-07 22:09:32 +03:00
alesapin
d9ca1e29c3 Increase stack size for coroutines 2021-09-07 15:56:32 +03:00
ZhiYong Wang
978dd19fa2 Fix coredump in creating distributed table 2021-09-07 19:05:26 +08:00
Dmitry Novik
99dc685146
Merge pull request #28315 from amosbird/indexfix
Fix NOT-IN index optimization when not all key columns are used.
2021-09-07 11:58:30 +03:00
alesapin
81d3e33087 Add crashing test 2021-09-07 10:36:39 +03:00
Vitaly Baranov
70c6623036
Merge branch 'master' into governance/session_log 2021-09-07 10:12:54 +03:00
Vitaly Baranov
bcc31f1f3e Remove unnecessary changes. 2021-09-07 01:37:28 +03:00
kssenii
7bea8200d8 Revert "Merge pull request #28082 from zhongyuankai/add-system-of-table_views"
This reverts commit e5bcfba89e, reversing
changes made to d77f243651.
2021-09-06 19:20:33 +00:00
zhangxiao871
0b6ab61633 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into yandex-master 2021-09-07 01:22:02 +08:00
zhangxiao871
fe3e786cf2 add bitShiftLeft for FixedString and String integer. 2021-09-07 01:20:12 +08:00
Anton Popov
47f46e388d fix optimization of disjunctions chain 2021-09-06 16:54:26 +03:00
Nikolai Kochetov
2178ed21df
Merge pull request #28560 from amosbird/projection-fix15
Fix wrong header of minmax_count projection
2021-09-06 13:00:44 +03:00
Amos Bird
8fac97692a
Fix nullable primary key with constant conversion 2021-09-06 15:11:37 +08:00
Amos Bird
18a7adf0fa
Fix NOT-IN index optimization when not all keys are used. 2021-09-06 12:21:03 +08:00
zhangxiao871
e73719ab80 Fix FixedString type ConstConst. 2021-09-05 13:21:06 +08:00
kssenii
d0113743c9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into materialized-postgresql 2021-09-05 01:07:31 +03:00
zhangxiao871
6d5605e1ee Better support FixedString type and add test case. 2021-09-05 00:41:52 +08:00
Maksim Kita
f076cc69b4
Merge pull request #28530 from kitaisreal/dict-get-default-implementation-for-nulls
Function dictGet default implementation for nulls
2021-09-04 13:29:22 +03:00
Anton Popov
66173d2cc0 fix debug assert in table asynchronous_inserts 2021-09-04 04:11:37 +03:00
Anton Popov
275118b0e8 fix data race in InsertQuery 2021-09-04 03:57:05 +03:00
Maksim Kita
c329f04b22 Fixed tests 2021-09-03 23:08:55 +03:00
Anton Popov
59128412ea Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-03 22:17:11 +03:00
Anton Popov
f91f8c1e8f add more tests with async inserts 2021-09-03 20:31:29 +03:00
Kruglov Pavel
f559c34113
Merge pull request #28302 from amosbird/binaryconstantwrap
Always monotonic for non-zero division
2021-09-03 20:02:54 +03:00
Kseniia Sumarokova
67ffb59b72
Merge pull request #28531 from CurtizJ/fix-nested
Fix usage of nested columns with non-array columns with the same prefix
2021-09-03 18:06:27 +03:00
alesapin
dd7493d871
Merge pull request #27038 from excitoon-favorites/altermaterializecolumn
`ALTER TABLE ... MATERIALIZE COLUMN`
2021-09-03 15:50:52 +03:00
Amos Bird
bb87d01579
Fix wrong header of minmax_count projection 2021-09-03 18:49:01 +08:00
kssenii
f17d1bc7a5 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into materialized-postgresql 2021-09-03 09:03:48 +00:00
Azat Khuzhin
4909d3f2e0 Fix endless loop for truncated bzip2
Stress test (thread) found an issue [1]:

    elapsed:              2094.356407533
    query:                SELECT count(), max(x) FROM file
    thread_ids:           [2927,11494,7502]
    current_database:     test_19

Stacktrace for 7502:

    0  __syscall () at ../base/glibc-compatibility/musl/x86_64/syscall.s:14
    1  0x000000001ba033b8 in clock_nanosleep (clk=1, flags=1, req=0x7fbb8adaed68, rem=0x0) at ../base/glibc-compatibility/musl/clock_nanosleep.c:21
    2  0x0000000018e25b84 in sleepForNanoseconds (nanoseconds=<optimized out>) at ../base/common/sleep.cpp:48
    3  0x0000000009a47143 in DB::injection (yield_probability=0, migrate_probability=0, sleep_probability=0.10000000000000001, sleep_time_us=100000) at ../src/Common/ThreadFuzzer.cpp:193
    4  DB::ThreadFuzzer::signalHandler () at ../src/Common/ThreadFuzzer.cpp:204
    5  0x00000000098e1447 in __tsan::CallUserSignalHandler(__tsan::ThreadState*, bool, bool, bool, int, __sanitizer::__sanitizer_siginfo*, void*) ()
    6  0x00000000098d7f99 in __tsan::ProcessPendingSignals(__tsan::ThreadState*) ()
    7  0x00000000098e57de in pread ()
    8  0x00000000099fab84 in DB::ReadBufferFromFileDescriptor::nextImpl (this=0x7b38010ddb00) at ../src/IO/ReadBufferFromFileDescriptor.cpp:62
    9  0x0000000009ab0cf3 in DB::ReadBuffer::next (this=0x7b38010ddb00) at ../src/IO/ReadBuffer.h:62
    10 DB::ReadBuffer::nextIfAtEnd (this=0x7b38010ddb00) at ../src/IO/ReadBuffer.h:78
    11 DB::Bzip2ReadBuffer::nextImpl (this=0x7b20032f4800) at ../src/IO/Bzip2ReadBuffer.cpp:59

It looks like bz2 is not capable to read/fail partially written archive:

    2021.09.03 00:52:36.744818 [ 3553 ] {90419c0a-c410-42ea-ba76-7672ff5ae5ec} <Debug> executeQuery: (from [::1]:54714) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') CREATE TABLE file (x UInt64) ENGINE = File(TSV, 'test_19/bz2.tsv.bz2')
    2021.09.03 00:52:41.255409 [ 2927 ] {9c7b4e21-cc37-438d-9c13-f9dc01efd30c} <Debug> executeQuery: (from [::1]:54750) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') TRUNCATE TABLE file
    2021.09.03 00:52:43.762791 [ 2927 ] {82857e3d-f7cc-453d-82a4-e8b8fb82ae0e} <Debug> executeQuery: (from [::1]:54758) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') INSERT INTO file SELECT * FROM numbers(1000000)
    2021.09.03 00:52:54.939333 [ 2927 ] {82857e3d-f7cc-453d-82a4-e8b8fb82ae0e} <Error> executeQuery: Code: 241. DB::Exception: Memory limit (total) exceeded: would use 63.07 GiB (attempt to allocate chunk of 4194364 bytes), maximum: 62.94 GiB. (MEMORY_LIMIT_EXCEEDED) (version 21.10.1.7982) (from [::1]:54758) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') (in query: INSERT INTO file SELECT * FROM numbers(1000000)), Stack trace (when copying this message, always include the lines below):
    2021.09.03 00:53:08.505015 [ 2927 ] {2bc7444e-c0d6-462e-9d6a-567f70b01697} <Debug> executeQuery: (from [::1]:54842) (comment: '/usr/share/clickhouse-test/queries/0_stateless/01059_storage_file_compression.sh') SELECT count(), max(x) FROM file

  [1]: https://clickhouse-test-reports.s3.yandex.net/28474/6d5f01a56bb1715c47de8444bfc85b39228f3081/stress_test_(thread).html#fail1
2021-09-03 10:49:17 +03:00
Azat Khuzhin
acf655de16 Fix insert_quorum_timeout in zookeeper_mutations_and_insert_quorum_long 2021-09-03 10:26:03 +03:00
alesapin
1894524438
Merge pull request #28528 from ClickHouse/fix_detach_attach_versioned_collapsing
Fix detach/attach for ReplicatedVersionedCollapsingMergeTree after alter
2021-09-03 10:13:52 +03:00
alesapin
d571c84a56 Better test for flaky check 2021-09-02 23:41:00 +03:00
Anton Popov
ee7f50396b fix nested and scalar columns with dot 2021-09-02 20:22:01 +03:00
alesapin
ba78a737dc Fix detach/attach for ReplicatedVersionedCollapsingMergeTree after alter 2021-09-02 17:47:00 +03:00
Nikolai Kochetov
af0da33147
Merge pull request #27827 from ClickHouse/more-checks-for-lv-and-native
Add more checks for LC in native protocol.
2021-09-02 17:27:42 +03:00
Alexander Tokmakov
1e2844f999 support function IN 2021-09-02 16:48:41 +03:00
Alexey Milovidov
03ae73a91a Drop arcadia_skip_list.txt 2021-09-02 16:19:36 +03:00
alesapin
b592400e54
Merge pull request #28404 from ClickHouse/remove_outdated_settings
Remove obsolete settings for replicated fetches.
2021-09-02 14:03:12 +03:00
Nikolai Kochetov
5f0b1bc4e3
Merge pull request #26286 from amosbird/projection-improve2
Virtual projection for min max indices.
2021-09-02 13:03:30 +03:00
Anton Popov
5e421ab272 Merge remote-tracking branch 'upstream/master' into HEAD 2021-09-02 02:42:50 +03:00
Anton Popov
7c42ce8370 improvements of async inserts 2021-09-02 02:18:09 +03:00
Nikolay Degterinsky
53b6d918eb
Merge pull request #25310 from bharatnc/ncb/import-export-lz4
LZ4 compression for import/export
2021-09-01 21:12:50 +03:00
mergify[bot]
5d299fbdee
Merge branch 'master' into remove_outdated_settings 2021-09-01 14:07:48 +00:00
vdimir
13bf141e1d
Fix storage_join type inference 2021-09-01 15:05:47 +03:00
vdimir
c4ffc2879f
Perform join type inference for USING at ExpressionAnalyzer instead of TreeRewriter 2021-09-01 15:05:47 +03:00
tavplubix
e55c0bc40a
Merging #27980 (#28413)
* fix: empty string convert to DecimalOrNumbeOrDateOrDateTime

* fix: ifnull convert to defaut value

* fix variable name

* fix cast args

* modify ifnull args

* use short circuit

Co-authored-by: liyang830 <liyang830@jd.com>
2021-09-01 12:12:23 +03:00
alesapin
383a84553e
Merge pull request #28396 from ClickHouse/add_test_for_our_friends
Add a test for a friend
2021-09-01 10:30:44 +03:00
Nikita Mikhaylov
f471ed4506
Merge pull request #28037 from nikitamikhaylov/settings-s3-engine
Support `SETTINGS` clause for `S3` engine
2021-08-31 21:08:53 +03:00
Nikita Mikhaylov
cc29130eba chmod -x 2021-08-31 18:08:02 +00:00
Vladimir C
94d5f3a87b
Merge pull request #28349 from vdimir/issue-27691-qf
Fix non joined rows from nullable column
2021-08-31 17:09:24 +03:00
alesapin
af3c528dcb Better test 2021-08-31 16:48:01 +03:00
alesapin
d6381ea68b Fix test 2021-08-31 16:19:32 +03:00
vdimir
bef0628522 Fix S3 stateless tests 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
5f7a1bab94 better 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
cc73ca17d3 Debug 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
92446b1b88 Better 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
4a88e5f281 Better 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
26efa7184d Added minio 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
fcfda4b983 Fix tests and update ya.make 2021-08-31 12:54:45 +00:00
Nikita Mikhaylov
ae241fc129 done 2021-08-31 12:54:06 +00:00
Vasily Nemkov
109d2f63d0 Fixed tests and minor style issues 2021-08-31 15:39:15 +03:00
Alexander Tokmakov
c8d8f0a38c fix 2021-08-31 15:07:00 +03:00
Nikolay Degterinsky
e8713a7d7e Merge branch 'master' into ncb/import-export-lz4 2021-08-31 13:32:39 +03:00