thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-18 13:42:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
58,013 Commits 9,138 Branches 1,774 Tags 2 GiB
6a5ab40988
Commit Graph

10641 Commits

Author SHA1 Message Date
Nikolai Kochetov
af214e794f Review fixes. 2021-02-10 15:45:39 +03:00
Alexander Kuzmenkov
d5b0f30732 cache the block size in the block itself for some speedup 2021-02-10 15:44:07 +03:00
Alexander Kuzmenkov
b57b3244f5 reuse sort order 2021-02-10 15:44:07 +03:00
Alexander Kuzmenkov
a67a54e2a5 cleanup 2021-02-10 15:44:07 +03:00
alesapin
a63d73db58 Don't allow TTL in old syntax 2021-02-10 15:09:12 +03:00
alesapin
e07bdad5c0 Fix test build 2021-02-10 14:44:21 +03:00
alesapin
420f2958e2
Merge pull request #19991 from ClickHouse/constant-propagation-fix 
Do not use inputs which values are known constants in ActionsDAG.
 2021-02-10 14:13:52 +03:00
alesapin
21faea1f68 Relax check in data writer for non adaptive tables 2021-02-10 13:43:31 +03:00
Maksim Kita
85396fc82e
Merge pull request #20057 from rf/rf/add-deltasum 
Add `deltaSum` aggregate function, docs & test
 2021-02-10 13:28:48 +03:00
alesapin
0d179e021b Add sync cmd 2021-02-10 13:15:42 +03:00
alesapin
57d8d81d59 Fix style 2021-02-10 13:02:09 +03:00
alesapin
9179fc8d96
Merge pull request #20226 from ClickHouse/fix_race_in_system_parts 
Fix benign race in system.parts
 2021-02-10 12:45:51 +03:00
alesapin
c95140d906 Better startup and non-verbose logging by default 2021-02-10 12:28:53 +03:00
Nikolai Kochetov
253c72afc4
Merge pull request #20251 from ClickHouse/fix-20242 
Fix not closed ports in DelayedPortsProcessor
 2021-02-10 12:28:28 +03:00
vdimir
d9afee55ba
Add RewriteCountVariantsVisitor.cpp to ya.make 2021-02-10 12:48:41 +08:00
Amos Bird
fc6c57f8e0
Fix 2021-02-10 12:48:41 +08:00
Amos Bird
565a148da9
Normalize count() variants 2021-02-10 12:48:41 +08:00
Amos Bird
afb5846a24
refactor 2021-02-10 11:22:24 +08:00
HuFuwang
4ac8860cea refine code in MergeTreeData::loadDataParts to avoid parsing WAL file as data part. 2021-02-10 10:13:43 +08:00
alexey-milovidov
4ff3a28a9f
Merge pull request #20211 from amosbird/fixcte2 
Fix CTE in INSERT-SELECT
 2021-02-10 02:12:05 +03:00
alexey-milovidov
21b1a3fc6d
Merge pull request #20246 from ucasFL/avg-optimize 
fix a problem in ArithmeticOperationsInAgrFuncOptimize
 2021-02-10 02:10:15 +03:00
alexey-milovidov
ec9808bf63
Merge pull request #20228 from ClickHouse/add_some_final_specifiers 
Add final to some classes
 2021-02-09 23:37:47 +03:00
Russ Frank
6b80ae6c4f style fixes 2021-02-09 15:01:57 -05:00
Nikolai Kochetov
8ba9576ed9 Added comment. 2021-02-09 22:52:48 +03:00
Nikolai Kochetov
27d607a955 Respect header in addMissingDefaults 2021-02-09 22:48:34 +03:00
alesapin
51c221f993 Fix outdated session kill 2021-02-09 21:29:06 +03:00
Vladimir Ch
a8acaafd56
Merge pull request #20223 from vdimir/fix-array-join-missing-arg 
Handle syntax error for ARRAY JOIN with no args
 2021-02-09 20:13:09 +03:00
alesapin
9d414d215e Merge branch 'master' into in_memory_raft 2021-02-09 20:00:50 +03:00
Alexander Kuzmenkov
a2a0d385c5 style 2021-02-09 19:50:39 +03:00
Nikolai Kochetov
db09d5a990 Fix not closed ports in DelayedPortsProcessor 2021-02-09 19:35:46 +03:00
Vitaly Baranov
9de7a0a779
Add comment 2021-02-09 18:55:36 +03:00
alesapin
c78f3ba204 Missed file 2021-02-09 18:39:15 +03:00
Alexander Kuzmenkov
8212976dc0 add boundary order check 2021-02-09 18:36:08 +03:00
Maksim Kita
a2560cecf4
Merge branch 'master' into fuse 2021-02-09 18:30:18 +03:00
Alexander Tokmakov
2c6a0e74fb better replica creation 2021-02-09 18:14:20 +03:00
alesapin
b130fbfd78 Add coordination settings 2021-02-09 17:47:18 +03:00
Alexander Kuzmenkov
c18749a704 fix a bug and add some tests 2021-02-09 17:44:04 +03:00
feng lv
5e0095c70b fix a problem in ArithmeticOperationsInAgrFuncOptimize 2021-02-09 14:17:48 +00:00
alexey-milovidov
faf28eeff3
Merge pull request #20183 from ucasFL/avg-optimize 
rewrite avg for algebraic optimization
 2021-02-09 16:36:13 +03:00
alesapin
9667bdcbd2 Merge branch 'master' into in_memory_raft 2021-02-09 16:06:31 +03:00
Alexander Kuzmenkov
6e40b9fb6c fix for the DESC frame 2021-02-09 14:56:58 +03:00
Alexander Kuzmenkov
fe8b414a69 cleanup 2021-02-09 14:56:58 +03:00
tavplubix
86530e603c
Merge pull request #20027 from bharatnc/ncb/event_time_micro_part_log 
add event_time_microseconds field to system.part_log table
 2021-02-09 14:46:40 +03:00
Alexander Tokmakov
4859657c42 fix int field to decimal conversion 2021-02-09 13:21:54 +03:00
hexiaoting
28b981a76b Fix style error and test cases error 2021-02-09 18:08:55 +08:00
alesapin
cb1194d37a Add final to some classes 2021-02-09 12:05:54 +03:00
alesapin
8da9f150de Fix race in system.parts 2021-02-09 11:51:17 +03:00
Nikolai Kochetov
798ffdc719 Fix build. 2021-02-09 11:37:55 +03:00
Nikolai Kochetov
229acbad5d
Merge pull request #20077 from ClickHouse/remove-adding-const-column-transform 
Remove AddingConstColumn step and transform.
 2021-02-09 11:28:44 +03:00
alesapin
accf48a21b
Merge pull request #20212 from nvartolomei/codespace-4851 
Remove dead code
 2021-02-09 11:27:27 +03:00
alesapin
15ce3dc112 Fix access control manager destruction order 2021-02-09 11:24:39 +03:00
vdimir
241769ee7c
Handle syntax error for ARRAY JOIN with no args 2021-02-09 11:21:26 +03:00
Russ Frank
2cde36a155 dont allow col type to be decimal 2021-02-08 22:53:45 -05:00
Russ Frank
b297e0ef36 feedback: use references, dont support decimal, rearrange struct members 2021-02-08 22:51:03 -05:00
Amos Bird
8911a038a0
Another fix 2021-02-09 11:46:06 +08:00
Russ Frank
746dc1ddae Merge remote-tracking branch 'origin/master' into rf/add-deltasum 2021-02-08 15:35:16 -05:00
alexey-milovidov
38c7ad3c38
Merge pull request #20204 from amosbird/fixubs 
Fix ubsan error
 2021-02-08 23:19:16 +03:00
Alexander Tokmakov
5e0cbfe972 Merge branch 'master' into database_replicated 2021-02-08 23:01:12 +03:00
alesapin
b8baf3a443 Fix some warnings 2021-02-08 22:40:44 +03:00
Alexander Tokmakov
78c1d69b8c better code 2021-02-08 22:36:17 +03:00
tavplubix
ac477d9850
Merge pull request #19771 from ClickHouse/thread_state_improvements 
Minor code improvements around ThreadStatus
 2021-02-08 22:34:55 +03:00
Nikolai Kochetov
e0a806c180
Delete filterPushDown.cpp 2021-02-08 22:10:27 +03:00
Azat Khuzhin
ce91c257b2 Lockless SYSTEM FLUSH DISTRIBUTED 
Right now SYSTEM FLUSH DISTRIBUTED will block:
- INSERT into this Distributed table (requireDirectoryMonitor())
- SELECT * FROM system.distribution_queue
 2021-02-08 22:07:30 +03:00
Maksim Kita
ebf5868652
Merge pull request #20164 from kitaisreal/cache-dictionaries-lru-cache 
Added LRUHashMap
 2021-02-08 21:00:27 +03:00
Nicolae Vartolomei
c336cac306 Remove dead code 2021-02-08 17:36:58 +00:00
Nicolae Vartolomei
a8f37e7704 Remove dead code 2021-02-08 17:19:35 +00:00
Amos Bird
46f2b4063f
Fix CTE in INSERT-SELECT 2021-02-09 00:25:24 +08:00
Ivan Lezhankin
a287443438 Merge remote-tracking branch 'upstream/master' into dwarf-folly 2021-02-08 18:36:41 +03:00
bharatnc
60c8dfa22c PartLog - populate event_time_microseconds for MergeParts 2021-02-08 07:25:44 -08:00
bharatnc
cb65515dc7 PartLog - fix style checks 2021-02-08 07:25:44 -08:00
bharatnc
46c843b004 PartLog - fix formatting 2021-02-08 07:25:44 -08:00
bharatnc
aa7f5cfe79 PartLog - use ColumnsWithTypeAndName for all columns 2021-02-08 07:25:44 -08:00
bharatnc
19cf5ca6c0 PartLog - try fix event_time_microseconds column 2021-02-08 07:25:44 -08:00
bharatnc
f1d2804bb0 PartLog - populate event_time s & us from same timespec 2021-02-08 07:25:44 -08:00
bharatnc
c98baf3496 PartLog - add field event_time_microseconds column 2021-02-08 07:25:44 -08:00
alesapin
f2feeb9b19 Missing fix 2021-02-08 18:20:12 +03:00
Nikolai Kochetov
4840d663e6
Merge pull request #20035 from ClickHouse/early-stop-for-delayed-ports-processor 
Close input ports in DelayedPortsProcessor as soon as all outputs are finished
 2021-02-08 18:18:11 +03:00
alesapin
d57613aa18 Fix 0_o build in arcadia 2021-02-08 16:50:03 +03:00
templarzq
7e3186c826
optimize aggfunc column data copy (#19407) 
* optimize agg column data copy

* add aggfunc col data copy test

* fix null warning

* fix style

* fix style

* fix style

* fix style

* fix copy same dat to same pos bug

* fix style

* fix style

* Update ColumnAggregateFunction.cpp

fix type check

* control record buf size

* fix performance

* fix performance

* fix destroy data speed

* decrease run time.

* fix warning

* decrease test run time

* Update aggfunc_col_data_copy.xml

* replace unordered_map with HashMap

* fix compile err

* fix compile err

* fix compile err

* fix compile err

* fix compile err

* fix compile err

* fix compile err

* fix compile err

* fix compile err

* fix hash map compile err

* fix compile err

* fix compile err

* fix format

* faster test

Co-authored-by: centos7 <templarzq@localhost.localdomain>
 2021-02-08 16:18:48 +03:00
Anton Popov
f1beeb7c25
Merge pull request #20099 from azat/remove-not-existing-setting 
Remove never existing insert_in_memory_parts_timeout
 2021-02-08 16:09:03 +03:00
alesapin
add89c17f2 Less serde in responses, watches on followers 2021-02-08 16:06:55 +03:00
lehasm
363aefb42e
DOCSUP-3908: mannWitneyUTest, welchTTest and studentTTest documentation (#19784) 
* studentTTest function description

* welchttest description, links in studentttest

* mannWhitneyUTest description

* Text changed slightly

* Text changed slightly

* Text changed slightly

* Text changed slightly

* - First header is first level.
- sample_index type set to UInt64.
- Return values renamed.

- mannWhitneyUTest:
  - added continuity_correction parameter
  - optional parameters wrapped in braces [ ]
  - description refactored
  - example SQL placed on single line

* Improved formulations (hopefully)
General data type names used (Integer, Float, Decimal)
Removed names from return values

* Fixes

* Optional parameters stated explicitly

* New line at the end of files

* Russian function description

* Files moved in the right folder

* Translated 'Original article' to russian

* Typos are fixed

* fixed alowed parameter value: "two sided" -> "two-sided"
* duplicate word "require" is removed from exception messages

* mannWhitneyUTest description changed
Added Tuple link in return values
"samples from two populations" added in short descriptions

* Russian translation updated

* fix

Co-authored-by: Alexey Smirnov <alexey-sm@yandex-team.ru>
 2021-02-08 15:58:27 +03:00
Nikolai Kochetov
00d5d28ddf Fix build. 2021-02-08 15:52:30 +03:00
Nikolai Kochetov
d7fa440356
Merge branch 'master' into remove-adding-const-column-transform 2021-02-08 15:49:23 +03:00
Alexey Milovidov
dc01464764 Merge branch 'master' into no-excessive-squash-memory 2021-02-08 15:39:22 +03:00
alexey-milovidov
e192676238
Merge pull request #19603 from JackyWoo/add_quota_type 
add quota type QUERY_SELECTS and QUERY_INSERTS
 2021-02-08 15:31:54 +03:00
tavplubix
060be5b2db
rerun CI checks 2021-02-08 15:04:40 +03:00
tavplubix
b31891ce2b
Merge pull request #20105 from nicelulu/zookeeper_table_in_query 
Supports system.zookeeper path IN query.
 2021-02-08 15:01:56 +03:00
tavplubix
2daa403201
Update AggregateFunctionGroupArrayMoving.h 2021-02-08 14:59:51 +03:00
Amos Bird
e9001a7dde
Fix ubsan error 2021-02-08 19:41:58 +08:00
Amos Bird
109a392e0c
Fix ubsan 2021-02-08 19:41:16 +08:00
vdimir
776b682f28
Add comment for used_flags in hash join, fix build 2021-02-08 14:38:31 +03:00
Kruglov Pavel
b256bd455c
Merge pull request #19961 from ucasFL/shard-id 
add setting insert_shard_id
 2021-02-08 14:28:13 +03:00
alesapin
786e687b2f Trying to avoid unlimited wait 2021-02-08 14:01:50 +03:00
Alexander Tokmakov
91d0924665 write dictionaries metadata to zk 2021-02-08 12:46:30 +03:00
Alexander Tokmakov
7ce0ef2561 show clusters for replicated db 2021-02-08 12:14:17 +03:00
Nikolai Kochetov
13b2c2de20 Fixing ya.make 2021-02-08 12:06:14 +03:00
Nikolai Kochetov
bd8f88f464 Fix style 2021-02-08 12:04:19 +03:00
Nikolai Kochetov
77cb68c3e7 Fixing build. 2021-02-08 12:03:04 +03:00
Maksim Kita
7ee1ad6833 Fixed unit tests 2021-02-08 11:44:32 +03:00
alesapin
d5ee7d33e9 Merge branch 'master' into in_memory_raft 2021-02-08 10:30:31 +03:00
hexiaoting
2c278f1e02 Restrict move JOINON to WHERE optimizer only to inner join 2021-02-08 13:44:50 +08:00
Maksim Kita
285d46bc56 Fix gcc build issues 2021-02-07 23:54:14 +03:00
Alexey Milovidov
8118e20eec Fix some tests 2021-02-07 23:40:30 +03:00
Alexey Milovidov
869bca74a7 Fix some tests 2021-02-07 23:37:55 +03:00
feng lv
6a5a539e98 rewrite avg for algebraic optimization 2021-02-07 14:41:41 +00:00
alexey-milovidov
3b43b0a1be
Merge pull request #20131 from azat/DateTime64-fix 
DateTime64 fixes
 2021-02-07 16:55:28 +03:00
Alexey Milovidov
0145be85df Do not spill warnings suppressions from ANTLR 2021-02-07 16:50:57 +03:00
Maksim Kita
1201c4c55f Fixed build issues 2021-02-07 16:45:29 +03:00
alexey-milovidov
0b043c41b6
Merge pull request #20160 from ClickHouse/cumulative-sum-normalized 
Fix UBSan report in arrayCumSum
 2021-02-07 14:28:16 +03:00
Amos Bird
ab5c7b75a4
Delay or throw insertion when too many inactive parts 2021-02-07 19:03:55 +08:00
Ivan
4181f8d9b7
Fix segfault using ANTLR parser (#20156) 
* Fix build of utils

* Fix visitor
 2021-02-07 11:06:39 +03:00
alexey-milovidov
ed5a81ab59
Merge pull request #20078 from abyss7/better-read-buffers-4 
LimitReadBuffer: check that position always advances
 2021-02-07 07:33:08 +03:00
Amos Bird
1b32292dd0
bitmap function for all native integers 2021-02-07 11:32:54 +08:00
JackyWoo
77c0f0a0e7 add quota type QUERY_SELECTS and QUERY_INSERTS 2021-02-07 10:57:18 +08:00
Alexey Milovidov
38ea4af339 Fix quadratic INSERT 2021-02-07 05:40:06 +03:00
Alexey Milovidov
c75e34c291 Corrections 2021-02-07 05:39:53 +03:00
Alexey Milovidov
905793a7e4 Disable excessive squashing of blocks for StorageMemory #13052 2021-02-07 04:57:17 +03:00
Azat Khuzhin
46ff7d2ab0 Fix DateTime64 overflows 2021-02-07 02:24:31 +03:00
alexey-milovidov
75f3ca8e34
Merge pull request #20150 from ClickHouse/useless-changes 
Useless changes
 2021-02-07 01:40:12 +03:00
alexey-milovidov
f2ab4f2ce9
Merge pull request #20037 from abyss7/better-read-buffers-2 
ReadBuffer: check for unread data on next()
 2021-02-07 01:33:06 +03:00
alexey-milovidov
417cfcd698
Update ReadBuffer.h 2021-02-07 01:31:20 +03:00
alexey-milovidov
66b868d865
Merge pull request #20153 from zlobober/customize_prewhere_optimizer 
Allow using MergeTreeWhereOptimizer not only with MergeTree-based storages
 2021-02-07 01:10:11 +03:00
alexey-milovidov
44b44c1fe7
Update InterpreterSelectQuery.cpp 2021-02-07 01:09:55 +03:00
alexey-milovidov
f5a853381b
Merge pull request #20152 from ucasFL/remove-useless-code 
remove some useless code
 2021-02-07 00:58:34 +03:00
Maksim Kita
eadd23aa38 Added LRUHashMap 2021-02-07 00:06:27 +03:00
alexey-milovidov
d0a1e69e99
Merge pull request #20094 from ClickHouse/columns-description-fuzzer 
Add fuzzer for ColumnsDescription
 2021-02-06 23:21:41 +03:00
Alexey Milovidov
1209c02869 Fix overflow in mapPopulateSeries 2021-02-06 23:18:42 +03:00
Alexey Milovidov
d9d49a4d30 Fix UBSan report in arrayCumSum 2021-02-06 22:22:21 +03:00
Alexey Milovidov
65902f4c6e Fix UBSan report in arrayCumSum 2021-02-06 22:21:22 +03:00
Alexey Milovidov
fd899daa00 Fix UBSan report in arrayCumSum 2021-02-06 22:17:19 +03:00
Ivan Lezhankin
8953fe1eb2 Fix seekable buffer 2021-02-06 19:30:46 +03:00
Maxim Akhmedov
0cd3601928 Allow using MergeTreeWhereOptimizer not only with MergeTree-based storages 2021-02-06 18:08:42 +03:00
feng lv
529fb1ea49 remove some useless code 2021-02-06 14:59:48 +00:00
Kruglov Pavel
d94e8624d7
Merge branch 'master' into shard-id 2021-02-06 16:48:17 +03:00
Alexey Milovidov
4092916db6 Useless changes 2021-02-06 14:56:10 +03:00
tavplubix
1c5d6bbe44
Merge pull request #20051 from stigsb/materializemysql-system-tables-fix 
Show details of MaterializeMySQL tables in `system.tables`
 2021-02-06 14:50:11 +03:00
Alexey Milovidov
26d4d52b9b Merge branch 'master' into columns-description-fuzzer 2021-02-06 13:31:50 +03:00
Azat Khuzhin
c4b5eed4ff Fix DateTime64 initialization (to match DateTime behaviour) 
There was no specializations for toDateTime64(<numeric>), and because of
this default decimal conversion was used, however this is not enough for
DateTime/DateTime64 types, since the date may overflow and the proper
check is required (like DateTime has), and this what UBsan found [1]:

    ../src/IO/WriteHelpers.h:812:33: runtime error: index 508 out of bounds for type 'const char [201]' Received signal -3 Received signal Unknown signal (-3)

Backtrace:

    (gdb) bt
    0  LocalDateTime::LocalDateTime (this=0x7fffffff8418, year_=1970, month_=1 '\001', day_=1 '\001', hour_=2 '\002', minute_=0 '\000', second_=254 '\376') at LocalDateTime.h:83
    1  0x00000000138a5edb in DB::writeDateTimeText<(char)45, (char)58, (char)32, (char)46> (datetime64=..., scale=7, buf=..., date_lut=...) at WriteHelpers.h:852
    2  0x0000000019c379b4 in DB::DataTypeDateTime64::serializeText (this=0x7ffff5c4b0d8, column=..., row_num=0, ostr=..., settings=...) at DataTypeDateTime64.cpp:66
    3  0x0000000019d297e4 in DB::IDataType::serializeAsText (this=0x7ffff5c4b0d8, column=..., row_num=0, ostr=..., settings=...) at IDataType.cpp:387

  [1]: https://clickhouse-test-reports.s3.yandex.net/19527/cea8ae162ffbf92e5ed29304ab010704c5d611c8/fuzzer_ubsan/report.html#fail1

Also fix CAST for DateTime64
 2021-02-06 13:04:53 +03:00
Azat Khuzhin
0627ba0e36 Fix timezone argument for DateTime64 
It should be marked with always const, otherwise it will bail:

    Code: 44, e.displayText() = DB::Exception: Illegal column String of time zone argument of function, must be constant string: While processing toDateTime(-1, 1, 'GMT'), Stack trace (when copying this message, always include the lines below):
 2021-02-06 13:04:53 +03:00
Azat Khuzhin
f4c2048bf2 Fix toDateTime64(toDate()/toDateTime()) for DateTime64 
Maybe this is even does not worth it, but at least there was code that
assume that this should work - ToDateTime64Transform in
FunctionsConversion.h.
 2021-02-06 13:04:53 +03:00
alexey-milovidov
5c281bd2f1
Merge pull request #20133 from ClickHouse/fix_if_tuple 
Fix if with tuple then/else arguments
 2021-02-06 09:52:54 +03:00
alexey-milovidov
dee8f1fbf2
Merge pull request #20132 from ClickHouse/fix-data-type-parser-exponential 
Fix the case when DataType parser may have exponential complexity
 2021-02-06 08:42:40 +03:00
Nikolai Kochetov
9d62842a33 Fix tests. 2021-02-05 22:52:06 +03:00
alesapin
011109c82a
Merge pull request #17348 from xjewer/alex/CLICKHOUSE-606_deduplication_UUID 
CLICKHOUSE-606: query deduplication based on parts' UUID
 2021-02-05 22:47:34 +03:00
alesapin
f81a407cdd Fix if with tuple then/else arguments 2021-02-05 22:39:26 +03:00
Nikolai Kochetov
d563cfb2be Fix tests. 2021-02-05 22:22:11 +03:00
Alexey Milovidov
60f2e89cfb Fix the case when DataType parser may have exponential complexity 2021-02-05 22:21:30 +03:00
Nikolai Kochetov
5aa27a6dd1 Fix tests. 2021-02-05 21:21:48 +03:00
Nikolai Kochetov
a761143286 Fix tests. 2021-02-05 21:19:41 +03:00
Nikolai Kochetov
e49315e058 Fix tests. 2021-02-05 19:52:50 +03:00
Nikolai Kochetov
a7f58da87e Fix tests. 2021-02-05 19:35:21 +03:00
Alexander Kuzmenkov
4bb38f333b some simple cases 2021-02-05 18:34:03 +03:00
Nikolai Kochetov
85c175883e Rename functions. 2021-02-05 18:11:26 +03:00
Nikolai Kochetov
872d2a8ad5 Fix test. 2021-02-05 17:42:41 +03:00
Nikolai Kochetov
31384cd652 Fix test. 2021-02-05 17:37:49 +03:00
Nikolai Kochetov
8c49e84668 Fix test. 2021-02-05 16:42:45 +03:00
Stig Bakken
3fc1641d91 Show details of MaterializeMySQL tables in system.tables 2021-02-05 21:37:29 +08:00
vdimir
01a6e01ad7
Store usage info flags separate from row refs in hash join 2021-02-05 16:20:13 +03:00
Nikolai Kochetov
98cfefdcfb Fix build 2021-02-05 14:49:58 +03:00
Nikolai Kochetov
9869f70a0d Remove AddMissed step and transform. 2021-02-05 14:41:44 +03:00
alesapin
aafadc06df Better types 2021-02-05 13:31:46 +03:00
Ivan Lezhankin
16d399aa35 Another build fix 2021-02-05 13:31:18 +03:00
alesapin
65d7b39cd6
Merge pull request #20073 from ClickHouse/fix-split-filter-remove-column 
Fix removing of filter column when split filter actions.
 2021-02-05 13:31:02 +03:00
alesapin
449e8e3fd9 More checks for setting 2021-02-05 13:15:02 +03:00
tavplubix
f59dc7f40d
Merge pull request #20066 from havardk/multi-table-update 
Fix handling of TABLE_MAP_EVENT from MySQL
 2021-02-05 13:11:59 +03:00
alesapin
7cbc135e72 More isolated code 2021-02-05 12:54:34 +03:00
Nikolai Kochetov
a34cd32552 Fix build 2021-02-05 12:25:16 +03:00
Alexander Kuzmenkov
6824f13a35 tmp 2021-02-05 12:13:19 +03:00
Vitaly Baranov
1c51b4a4e4 MongoDB table engine now establishes connection only when it reads data. 2021-02-05 11:47:31 +03:00
vdimir
c6c1541c9f
Remove assert from CollectJoinOnKeysVisitor.cpp 2021-02-05 10:53:26 +03:00
vdimir
1e2c302248
Merge pull request #18377 from Jokser/disk-s3-backup-restore-metadata 2021-02-05 10:44:59 +03:00
alesapin
ab98040003 More logs 2021-02-05 10:15:28 +03:00
zhangxiao871
581495ae23 Supports system.zookeeper path IN query. 2021-02-05 14:45:28 +08:00
alexey-milovidov
34151eea2c
Merge pull request #20067 from ClickHouse/mod-negative-type-promotion 
Add type promotion for modulo of division of negative number
 2021-02-05 09:31:46 +03:00
hexiaoting
e1359b01a1 Remove unnecessary codes 2021-02-05 11:11:27 +08:00
Russ Frank
2f31eabc13 turn off ubsan for deltasum functions 2021-02-04 21:22:05 -05:00
Ivan
d135a727e2
Merge branch 'master' into better-read-buffers-2 2021-02-05 02:17:05 +03:00
Ivan Lezhankin
d59b45e496 Fix build 2021-02-05 02:14:17 +03:00
Azat Khuzhin
64c0bf9829 TCPHandler: catch exceptions from the WriteBuffer in destructor 
For TCPHandler it is safe thing todo.

Otherwise *San will report [1]:

    2021.01.24 15:33:40.103996 [ 270 ] {} <Trace> BaseDaemon: Received signal -1
    2021.01.24 15:33:40.110693 [ 270 ] {} <Fatal> BaseDaemon: (version 21.2.1.5789, build id: FF421B087D1E2EAA19FA17B5AB3AE413832744E0) (from thread 48318) Terminate called for uncaught exception:
    2021.01.24 15:33:40.114845 [ 270 ] {} <Trace> BaseDaemon: Received signal 6
    2021.01.24 15:33:40.138738 [ 218027 ] {} <Fatal> BaseDaemon: ########################################
    2021.01.24 15:33:40.138838 [ 218027 ] {} <Fatal> BaseDaemon: (version 21.2.1.5789, build id: FF421B087D1E2EAA19FA17B5AB3AE413832744E0) (from thread 48318) (no query) Received signal Aborted (6)
    2021.01.24 15:33:40.138912 [ 218027 ] {} <Fatal> BaseDaemon:
    2021.01.24 15:33:40.139277 [ 218027 ] {} <Fatal> BaseDaemon: Stack trace: 0x7f185474118b 0x7f1854720859 0xaddc0cc 0x2af9fab8 0x2af9fa04 0xa91758b 0x1e418bb5 0x20725b4f 0x20725d9e 0x266b47a3 0x269772f5 0x26971847 0x7f18548f6609 0x7f185481d293
    2021.01.24 15:33:40.139637 [ 218027 ] {} <Fatal> BaseDaemon: 3. raise @ 0x4618b in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.01.24 15:33:40.140113 [ 218027 ] {} <Fatal> BaseDaemon: 4. abort @ 0x25859 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.01.24 15:33:40.144121 [ 218027 ] {} <Fatal> BaseDaemon: 5. ./obj-x86_64-linux-gnu/../base/daemon/BaseDaemon.cpp:0: terminate_handler() @ 0xaddc0cc in /usr/bin/clickhouse
    2021.01.24 15:33:40.151208 [ 218027 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:61: std::__terminate(void (*)()) @ 0x2af9fab8 in /usr/bin/clickhouse
    2021.01.24 15:33:40.153085 [ 218027 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../contrib/libcxxabi/src/cxa_handlers.cpp:0: std::terminate() @ 0x2af9fa04 in /usr/bin/clickhouse
    2021.01.24 15:33:40.155209 [ 218027 ] {} <Fatal> BaseDaemon: 8. ? @ 0xa91758b in /usr/bin/clickhouse
    2021.01.24 15:33:40.156621 [ 218027 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/IO/WriteBufferFromPocoSocket.cpp:0: DB::WriteBufferFromPocoSocket::~WriteBufferFromPocoSocket() @ 0x1e418bb5 in /usr/bin/clickhouse
    2021.01.24 15:33:40.161041 [ 218027 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2518: DB::TCPHandler::~TCPHandler() @ 0x20725b4f in /usr/bin/clickhouse
    2021.01.24 15:33:40.164557 [ 218027 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.h:101: DB::TCPHandler::~TCPHandler() @ 0x20725d9e in /usr/bin/clickhouse
    2021.01.24 15:33:40.165921 [ 218027 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/AtomicCounter.h:314: Poco::Net::TCPServerDispatcher::run() @ 0x266b47a3 in /usr/bin/clickhouse
    2021.01.24 15:33:40.167347 [ 218027 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:0: Poco::PooledThread::run() @ 0x269772f5 in /usr/bin/clickhouse
    2021.01.24 15:33:40.169401 [ 218027 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:0: Poco::ThreadImpl::runnableEntry(void*) @ 0x26971847 in /usr/bin/clickhouse
    2021.01.24 15:33:40.169498 [ 218027 ] {} <Fatal> BaseDaemon: 15. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    2021.01.24 15:33:40.169566 [ 218027 ] {} <Fatal> BaseDaemon: 16. __clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.01.24 15:33:41.027601 [ 218027 ] {} <Fatal> BaseDaemon: Calculated checksum of the binary: 63D7491B39260494BA0D785E1860B427. There is no information about the reference checksum.

  [1]: https://clickhouse-test-reports.s3.yandex.net/19451/1e16bd6f337985a82fbdf4eded695dc6e663af58/stress_test_(address).html#fail1

v2: Fix catching errors in WriteBufferFromPocoSocket destructor
 2021-02-05 01:32:36 +03:00
Azat Khuzhin
98e3a99a88 Do not catch exceptions during final flush in writers destructors 
Since this hides real problems, since destructor does final flush and if
it fails, then data will be lost.

One of such examples if MEMORY_LIMIT_EXCEEDED exception, so lock
exceptions from destructors, by using
MemoryTracker::LockExceptionInThread to block these exception, and allow
others (so std::terminate will be called, since this is c++11 with
noexcept for destructors by default).

Here is an example, that leads to empty block in the distributed batch:

    2021.01.21 12:43:18.619739 [ 46468 ] {7bd60d75-ebcb-45d2-874d-260df9a4ddac} <Error> virtual DB::CompressedWriteBuffer::~CompressedWriteBuffer(): Code: 241, e.displayText() = DB::Exception: Memory limit (for user) exceeded: would use 332.07 GiB (attempt to allocate chunk of 4355342 bytes), maximum: 256.00 GiB, Stack trace (when copying this message, always include the lines below):

    0. DB::Exception::Exception<>() @ 0x86f7b88 in /usr/bin/clickhouse
    ...
    4. void DB::PODArrayBase<>::resize<>(unsigned long) @ 0xe9e878d in /usr/bin/clickhouse
    5. DB::CompressedWriteBuffer::nextImpl() @ 0xe9f0296 in /usr/bin/clickhouse
    6. DB::CompressedWriteBuffer::~CompressedWriteBuffer() @ 0xe9f0415 in /usr/bin/clickhouse
    7. DB::DistributedBlockOutputStream::writeToShard() @ 0xf6bed4a in /usr/bin/clickhouse
 2021-02-05 01:31:45 +03:00
Azat Khuzhin
4beb5c1b8a TCPHandler: Move constructor into the module and add missing headers 2021-02-05 01:31:42 +03:00
Azat Khuzhin
a46d65f99d Fix typo in comment for memoryTrackerCanThrow() 2021-02-05 01:29:46 +03:00
Azat Khuzhin
48b415d3e4 Remove never existing insert_in_memory_parts_timeout 
Fixes: a43cb93be5 ("remove questionable functionality")
Cc: @CurtizJ
 2021-02-05 01:26:40 +03:00
Ivan
0db2aa3c2e
Check that position doesn't go beyond end (#20039) 2021-02-05 01:21:24 +03:00
Nikolai Kochetov
d9aa1096cf Build actions dag to evaluate missing defaults. 2021-02-04 23:36:50 +03:00
vdimir
91ea99129e
Merge pull request #19999 from kreuzerkrieg/change_the_idisk_interface 
return `DiskType` instead of `String` in IDisk::getType()
 2021-02-04 22:46:54 +03:00
Alexander Tokmakov
18f6b5bbad add timeouts 2021-02-04 22:41:44 +03:00
Alexey Milovidov
d2c1a97d86 Minor modification 2021-02-04 22:41:17 +03:00
alesapin
c5312bf362 Trying to disable suspicious parameter 2021-02-04 22:29:46 +03:00
Russ Frank
bcf5a70e4f check arg type 2021-02-04 14:28:45 -05:00
Ivan Lezhankin
84b88c6802 CC 2021-02-04 22:06:43 +03:00
Alexey Milovidov
19c38c61e6 Add fuzzer for ColumnsDescription 2021-02-04 22:03:56 +03:00
Ivan Lezhankin
2b9909d396 Merge remote-tracking branch 'upstream/master' into better-read-buffers-2 2021-02-04 21:51:23 +03:00
Ivan Lezhankin
bcbe6f209c Merge branch 'better-read-buffers-1' into better-read-buffers-2 2021-02-04 21:50:31 +03:00
Ivan Lezhankin
610d7b755b Don't forget to update position of inner buffer 2021-02-04 21:50:15 +03:00
Alexander Kuzmenkov
26020daca5 Merge remote-tracking branch 'origin/master' into HEAD 2021-02-04 20:58:25 +03:00
Alexander Kuzmenkov
3796a183ba Merge remote-tracking branch 'origin/master' into HEAD 2021-02-04 20:54:36 +03:00
Russ Frank
2bfeef23cf correct merge logic 2021-02-04 11:55:19 -05:00
Alexey Milovidov
85b5805c3c Fix tests 2021-02-04 19:36:31 +03:00
Ivan Lezhankin
ac4c3a6b27 Don't pass empty vector to ConcatReadBuffer 2021-02-04 18:59:54 +03:00
vdimir
30f98795bc
Merge remote-tracking branch 'upstream/master' into disk-s3-backup-restore-metadata 2021-02-04 18:38:28 +03:00
Haavard Kvaalen
e49a051092 Remove superfluous semicolon 2021-02-04 16:21:28 +01:00
Ivan Lezhankin
ee0ff755e2 Check that position always advances 2021-02-04 17:46:46 +03:00
Nikolai Kochetov
e3d6ffd9dc Remove AddingConstColumn step and transform. 2021-02-04 17:25:11 +03:00
Haavard Kvaalen
a161969b50 Fix incorrectly placed brace 2021-02-04 14:43:18 +01:00
alesapin
d85e9b496c Fix gcc-10 build 2021-02-04 16:22:30 +03:00
alesapin
da51ea1794 Simplify shutdown and requests processing 2021-02-04 15:07:41 +03:00
alexey-milovidov
c12f2d460e
Merge pull request #19972 from ClickHouse/fix-rocksdb 
Fix missing type check in EmbeddedRocksDB
 2021-02-04 15:06:12 +03:00
Alexey Milovidov
a3ac276741 Add type promotion for modulo of division of negative number 2021-02-04 14:56:04 +03:00
Haavard Kvaalen
e6f1ce48fe Fix handling of TABLE_MAP_EVENT from MySQL 
The MySQL replication code assumed that row update events would be
preceded by a single TABLE_MAP_EVENT.  However, if a single SQL
statement modifies rows in multiple tables, MySQL will first send
table map events for all involved tables, and then row update events.

Depending on circumstances, this could lead to an exception when the row
update was processed, the update could be incorrectly dropped, or the
update could be applied to the wrong table.
 2021-02-04 12:49:10 +01:00
Nikolai Kochetov
7a2279d067 Fix removing filter column from expression after Filter actions split 2021-02-04 14:44:00 +03:00
Alexander Kuzmenkov
02ca7386b1
Merge pull request #19951 from ClickHouse/aku/window-prototype-3 
CURRENT ROW and offset for start of ROWS frame
 2021-02-04 14:33:13 +03:00
alexey-milovidov
298a29ef52
Merge pull request #20049 from ClickHouse/point-in-polygon-ubsan 
Avoid UBSan report in pointInPolygon
 2021-02-04 13:51:30 +03:00
alesapin
3ddca91a5b Fix build one more time 2021-02-04 12:39:07 +03:00
alesapin
9c04d912ec Merge branch 'master' into in_memory_raft 2021-02-04 11:50:32 +03:00
alesapin
e7a83868dd Fix build 2021-02-04 11:28:11 +03:00
kreuzerkrieg
1cc9e03d0c return DiskType instead of String IDisk::getType() as in the rest of storage interfaces 2021-02-04 10:01:21 +02:00
alexey-milovidov
c13759dd85
Merge pull request #20047 from azat/pushing-to-views-elapsed-fix 
Fix log message with elapsed time while pushing to views
 2021-02-04 10:44:12 +03:00
Alexander Kuzmenkov
c1c71fc8e9 ROWS OFFSET frame end 2021-02-04 10:41:09 +03:00
Alexey Milovidov
15a529f6f7 Whitespace 2021-02-04 10:35:49 +03:00
alexey-milovidov
5c1b96dd93
Merge pull request #19886 from azat/writer-partial-buffer 
Allow writing partial buffer
 2021-02-04 10:29:47 +03:00
alexey-milovidov
29dd4030c6
Merge pull request #20011 from azat/UBsan-fixes-21.2.1 
UBsan fixes
 2021-02-04 10:27:08 +03:00
Alexander Kuzmenkov
4abbbae583 Merge remote-tracking branch 'origin/aku/window-prototype-3' into HEAD 2021-02-04 09:52:02 +03:00
Alexander Kuzmenkov
1b6262f874 cleanup 2021-02-04 09:51:46 +03:00
Alexander Kuzmenkov
773b364fe4 check some bounds 2021-02-04 09:50:56 +03:00
Alexander Kuzmenkov
b281d39036 yamake 2021-02-04 09:40:09 +03:00
Alexander Kuzmenkov
d6372bd3d9 linker woes 2021-02-04 09:38:42 +03:00
Alexey Milovidov
55c7fdbbe4 Merge branch 'master' into fix-rocksdb 2021-02-04 08:30:02 +03:00
alexey-milovidov
5731189515
Merge pull request #20045 from ClickHouse/executable-dictionary-data-race 
Fix data race in executable dictionary
 2021-02-04 08:28:58 +03:00
Alexey Milovidov
47a56b9d1d Merge branch 'master' into point-in-polygon-ubsan 2021-02-04 08:26:41 +03:00
Russ Frank
f47ea31ef1 clang-format 2021-02-04 00:26:23 -05:00
Alexey Milovidov
474f151707 More docs for MergeTreeSettings 2021-02-04 08:26:22 +03:00
Russ Frank
75ab05f80a correct conditional 2021-02-04 00:19:24 -05:00
Russ Frank
b36d20ef6e record seen first and last 2021-02-04 00:11:43 -05:00
Russ Frank
3913f39211 Add deltaSum aggregate function, docs & test 2021-02-03 22:49:28 -05:00
Azat Khuzhin
fb4596f433 Fix clang-analyzer-optin.cplusplus.VirtualCall 2021-02-04 02:08:41 +03:00
Azat Khuzhin
984445b44b Fix UBsan reports in quantileTiming 
UBsan reports [1]:

    ../src/AggregateFunctions/QuantileTiming.h:442:27: runtime error: 1.84467e+19 is outside the range of representable values of type 'unsigned long' Received signal -3 Received signal Unknown signal (-3)

  [1]: https://clickhouse-test-reports.s3.yandex.net/19971/e15f5d9cb5b36482d1ae9ca069074fb200f2ab37/fuzzer_ubsan/report.html#fail1

Follow-up for: #19394
 2021-02-04 02:01:48 +03:00
Azat Khuzhin
c59f22d7b4 Change PushingToViewsBlockOutputStream::process, to accept ref to ViewInfo 
It is safe, no need to use quirks with passing view_num.
 2021-02-04 00:44:24 +03:00
Azat Khuzhin
50d8a87c27 Fix logging of elapsed time while pushing to views 
Logging from PushingToViewsBlockOutputStream::write() is incorrect,
since it does not takes into account squashing (default to 1<<20 rows
and 256<<20), whle write will be done from
PushingToViewsBlockOutputStream::writeSuffix().

Fixes: #19378
 2021-02-04 00:44:24 +03:00
Azat Khuzhin
ca071381e1 Merge remote-tracking branch 'upstream/master' into writer-partial-buffer 2021-02-03 23:46:39 +03:00
Azat Khuzhin
46f5268135 Fix incorrect WriteBuffer interface usage in message brokers producers 
WriteBufferToKafkaProducer and WriteBufferToRabbitMQProducer uses
WriteBuffer::set(nullptr, 0) which will leave the WriteBuffer in the
invalid state, since after this available() is 0 and next() will not
call nextImpl().

Stacktrace:

    2021.02.02 05:27:16.248056 [ 97 ] {} <Fatal> BaseDaemon: ########################################
    2021.02.02 05:27:16.248697 [ 97 ] {} <Fatal> BaseDaemon: (version 21.3.1.5880, build id: 03F265087EF651DC4D8E569775FE9E91FFA5DE76) (from thread 93) (query_id: 8c34c220-f66a-45d2-8f4f-01193cede98b) Received signal Segmentation fault (11)
    2021.02.02 05:27:16.249030 [ 97 ] {} <Fatal> BaseDaemon: Address: NULL pointer. Access: write. Address not mapped to object.
    2021.02.02 05:27:16.249623 [ 97 ] {} <Fatal> BaseDaemon: Stack trace: 0x12f3dbeb 0x12efd075 0x12efc90e 0x12ebb0e9 0x12ebe0cb 0x12e1da18 0x12a8c857 0x1219aa62 0x1218fc82 0x1218fdaa 0x11e3f120 0x12dfa3df 0x12df42a4 0x12e00fa8 0x158cdc63 0x158ce38f 0x15a36b72 0x15a35110 0x15a33918 0x8adf12d 0x7fb5e0fe3609 0x7fb5e0f0a293
    2021.02.02 05:27:16.408985 [ 97 ] {} <Fatal> BaseDaemon: 5. ./obj-x86_64-linux-gnu/../src/IO/WriteHelpers.h:64: DB::JSONEachRowRowOutputFormat::writeRowStartDelimiter() @ 0x12f3dbeb in /usr/bin/clickhouse
    2021.02.02 05:27:16.534797 [ 97 ] {} <Fatal> BaseDaemon: 6. ./obj-x86_64-linux-gnu/../src/Processors/Formats/IRowOutputFormat.cpp:80: DB::IRowOutputFormat::write(std::__1::vector<COW<DB::IColumn>::immutable_ptr<DB::IColumn>, std::__1::allocator<COW<DB::IColumn>::immutable_ptr<DB::IColumn> > > const&, unsigned long) @ 0x12efd075 in /usr/bin/clickhouse
    2021.02.02 05:27:16.599210 [ 97 ] {} <Fatal> BaseDaemon: 7. ./obj-x86_64-linux-gnu/../src/Processors/Formats/IRowOutputFormat.cpp:0: DB::IRowOutputFormat::consume(DB::Chunk) @ 0x12efc90e in /usr/bin/clickhouse
    2021.02.02 05:27:16.680733 [ 97 ] {} <Fatal> BaseDaemon: 8. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3211: DB::IOutputFormat::write(DB::Block const&) @ 0x12ebb0e9 in /usr/bin/clickhouse
    2021.02.02 05:27:16.798768 [ 97 ] {} <Fatal> BaseDaemon: 9. ./obj-x86_64-linux-gnu/../src/Processors/Formats/OutputStreamToOutputFormat.cpp:15: DB::OutputStreamToOutputFormat::write(DB::Block const&) @ 0x12ebe0cb in /usr/bin/clickhouse
    2021.02.02 05:27:16.981593 [ 97 ] {} <Fatal> BaseDaemon: 10. ./obj-x86_64-linux-gnu/../src/DataStreams/MaterializingBlockOutputStream.h:0: DB::MaterializingBlockOutputStream::write(DB::Block const&) @ 0x12e1da18 in /usr/bin/clickhouse
    2021.02.02 05:27:17.090383 [ 97 ] {} <Fatal> BaseDaemon: 11. ./obj-x86_64-linux-gnu/../src/Storages/RabbitMQ/RabbitMQBlockOutputStream.cpp:61: DB::RabbitMQBlockOutputStream::write(DB::Block const&) @ 0x12a8c857 in /usr/bin/clickhouse
    2021.02.02 05:27:17.140425 [ 97 ] {} <Fatal> BaseDaemon: 12. ./obj-x86_64-linux-gnu/../src/DataStreams/AddingDefaultBlockOutputStream.cpp:0: DB::AddingDefaultBlockOutputStream::write(DB::Block const&) @ 0x1219aa62 in /usr/bin/clickhouse
    2021.02.02 05:27:17.190282 [ 97 ] {} <Fatal> BaseDaemon: 13. ./obj-x86_64-linux-gnu/../src/DataStreams/SquashingBlockOutputStream.cpp:0: DB::SquashingBlockOutputStream::finalize() @ 0x1218fc82 in /usr/bin/clickhouse
    2021.02.02 05:27:17.240052 [ 97 ] {} <Fatal> BaseDaemon: 14. ./obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2844: DB::SquashingBlockOutputStream::writeSuffix() @ 0x1218fdaa in /usr/bin/clickhouse
    2021.02.02 05:27:17.294527 [ 97 ] {} <Fatal> BaseDaemon: 15. ./obj-x86_64-linux-gnu/../src/DataStreams/CountingBlockOutputStream.h:37: DB::CountingBlockOutputStream::writeSuffix() @ 0x11e3f120 in /usr/bin/clickhouse
    2021.02.02 05:27:17.405442 [ 97 ] {} <Fatal> BaseDaemon: 16. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:521: DB::TCPHandler::processInsertQuery(DB::Settings const&) @ 0x12dfa3df in /usr/bin/clickhouse
    2021.02.02 05:27:17.475822 [ 97 ] {} <Fatal> BaseDaemon: 17. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:0: DB::TCPHandler::runImpl() @ 0x12df42a4 in /usr/bin/clickhouse
    2021.02.02 05:27:17.609845 [ 97 ] {} <Fatal> BaseDaemon: 18. ./obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1419: DB::TCPHandler::run() @ 0x12e00fa8 in /usr/bin/clickhouse
    2021.02.02 05:27:17.695292 [ 97 ] {} <Fatal> BaseDaemon: 19. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:57: Poco::Net::TCPServerConnection::start() @ 0x158cdc63 in /usr/bin/clickhouse
    2021.02.02 05:27:17.833612 [ 97 ] {} <Fatal> BaseDaemon: 20. ./obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:0: Poco::Net::TCPServerDispatcher::run() @ 0x158ce38f in /usr/bin/clickhouse
    2021.02.02 05:27:17.907391 [ 97 ] {} <Fatal> BaseDaemon: 21. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/ScopedLock.h:36: Poco::PooledThread::run() @ 0x15a36b72 in /usr/bin/clickhouse
    2021.02.02 05:27:18.033949 [ 97 ] {} <Fatal> BaseDaemon: 22. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread.cpp:56: Poco::(anonymous namespace)::RunnableHolder::run() @ 0x15a35110 in /usr/bin/clickhouse
    2021.02.02 05:27:18.122761 [ 97 ] {} <Fatal> BaseDaemon: 23. ./obj-x86_64-linux-gnu/../contrib/poco/Foundation/include/Poco/SharedPtr.h:277: Poco::ThreadImpl::runnableEntry(void*) @ 0x15a33918 in /usr/bin/clickhouse
    2021.02.02 05:27:18.283663 [ 97 ] {} <Fatal> BaseDaemon: 24. __tsan_thread_start_func @ 0x8adf12d in /usr/bin/clickhouse
    2021.02.02 05:27:18.284153 [ 97 ] {} <Fatal> BaseDaemon: 25. start_thread @ 0x9609 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    2021.02.02 05:27:18.284544 [ 97 ] {} <Fatal> BaseDaemon: 26. __clone @ 0x122293 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    2021.02.02 05:27:21.675458 [ 97 ] {} <Fatal> BaseDaemon: Calculated checksum of the binary: B53B58DB6CF8186EEC9EA9273F135E44. There is no information about the reference checksum.
    2021.02.02 05:27:28.078805 [ 1 ] {} <Fatal> Application: Child process was terminated by signal 11.
 2021-02-03 23:46:28 +03:00
alesapin
1ff87ac6f9 Add background session lifetime control 2021-02-03 23:32:15 +03:00
Alexander Tokmakov
066fb4c82b fix 2021-02-03 23:02:37 +03:00
alexey-milovidov
ca06d3b317
Merge branch 'master' into fix-rocksdb 2021-02-03 21:28:50 +03:00
alexey-milovidov
402c018d1e
Merge pull request #19947 from azat/dist-INSERT-block-structure-mismatch 
Fix "Block structure mismatch" for INSERT into Distributed
 2021-02-03 21:27:45 +03:00
Alexey Milovidov
05c5c8ed80 Avoid UBSan report in pointInPolygon 2021-02-03 21:23:54 +03:00
Alexey Milovidov
dc2afc4795 Fix double whitespace #18383 2021-02-03 21:12:14 +03:00
Alexey Milovidov
40939ff6ba Fix data race in executable dictionary 2021-02-03 20:45:50 +03:00
Nikolai Kochetov
c39c965612
Merge pull request #19962 from keen-wolf/timezoneOffset 
Implement the timezoneOffset function
 2021-02-03 20:37:34 +03:00
Alexey Milovidov
82ab793731 Fix missing type check in StorageEmbeddedRocksDB 2021-02-03 20:35:23 +03:00
Alexander Tokmakov
87502d0220 Merge branch 'thread_state_improvements' into database_replicated 2021-02-03 20:19:35 +03:00
Alexander Tokmakov
d010f97db0 Merge branch 'master' into database_replicated 2021-02-03 20:13:25 +03:00
Alexander Kuzmenkov
ec382d8812 BETWEEN CURRENT ROW AND CURRENT ROW 2021-02-03 17:55:40 +03:00
Alexander Kuzmenkov
35754abb4a CURRENT ROW frame start for RANGE frame 2021-02-03 17:22:37 +03:00
Alexander Kuzmenkov
7c55ecf67d cleanup 2021-02-03 16:41:59 +03:00
Alexander Kuzmenkov
bd6d7facf1 style 2021-02-03 16:33:50 +03:00
Alexander Kuzmenkov
f31d2206a7 more fuzzing and less bugs 2021-02-03 15:50:25 +03:00
Ivan Lezhankin
72b0a18503 Check for unread data on next() 2021-02-03 15:37:32 +03:00
Ivan Lezhankin
b0f400ca1b Reset internal buffer position on next() 2021-02-03 15:31:45 +03:00
Pavel Kovalenko
62e96c138e Remove unused error code in DiskS3 2021-02-03 15:01:43 +03:00
Nikolai Kochetov
b5b68f66a9 Colse input ports in DelayedPortsProcessor as soon as all outputs are finished. 2021-02-03 14:57:22 +03:00
Pavel Kovalenko
b6094859c7 Throw exception during restore DiskS3 if object doesn't have path in metadata. 2021-02-03 14:26:24 +03:00
Pavel Kovalenko
b7151aa754 Merge remote-tracking branch 'origin/master' into disk-s3-backup-restore-metadata 
# Conflicts:
#	src/Disks/DiskDecorator.h
#	src/Disks/IDisk.h
#	src/Disks/S3/DiskS3.cpp
 2021-02-03 14:22:18 +03:00
hexiaoting
45aee71fff Modified some implementation 2021-02-03 18:52:20 +08:00
Nikolai Kochetov
73002eb3b7 Fix constant propagation. 2021-02-03 13:29:44 +03:00
tavplubix
b24f73fd88
remove outdated comment 2021-02-03 13:27:41 +03:00
tavplubix
50362840bb
Merge pull request #19924 from amosbird/ddlworker2 
Initialize MaxDDLEntryID upon restarting
 2021-02-03 13:22:22 +03:00
hexiaoting
56de38ea6a Merge remote-tracking branch 'origin/master' into dev_joinon 2021-02-03 17:20:24 +08:00
Nikolai Kochetov
ebab5df236 Update ya.make 2021-02-03 12:13:44 +03:00
Alexander Kuzmenkov
bb45c5a8ff Merge remote-tracking branch 'origin/master' into HEAD 2021-02-03 12:13:23 +03:00
Maksim Kita
ba45cf32ab
Merge pull request #19858 from kitaisreal/reinterpret-as-updated-to-big-integers 
Function reinterpretAs updated to support big integers
 2021-02-03 12:12:13 +03:00
Alexander Kuzmenkov
1b47cf08a9
Merge pull request #19921 from ClickHouse/aku/window-prototype-2 
UNBOUNDED FOLLOWING frame end
 2021-02-03 12:10:37 +03:00
Alexander Kuzmenkov
3c0a5d2226 fix invalid iterator addition 2021-02-03 12:09:31 +03:00
Alexander Kuzmenkov
dad4f82e0e fix invalid iterator addition 2021-02-03 12:08:46 +03:00
alesapin
0c3ef018bb Fix ya.make 2021-02-03 10:15:57 +03:00
alesapin
c334bdca1f Fix NuKeeper server parameters 2021-02-03 10:11:19 +03:00
Alexander Kuzmenkov
7e945bab03 fix the calculation for moving frame start 2021-02-03 08:53:21 +03:00
alexey-milovidov
4cbd0ed282
Merge pull request #20010 from ClickHouse/coverity 
Fix some of the issues found by Coverity
 2021-02-03 08:48:05 +03:00
alexey-milovidov
a4d86c43e9
Merge pull request #19946 from ClickHouse/improve-performance-of-aggregate-functions 
Improve performance of aggregate functions
 2021-02-03 08:46:51 +03:00
PHO
09c49d3842 Add function runningConcurrency() 
Given a series of beginning time and ending time of events, this function calculates concurrency of the events at each of the data point, that is, the beginning time.
 2021-02-03 14:34:44 +09:00
Aleksei Semiglazov
d05c6446b9
Send cancel packet and cancel read_context before retrying the query 2021-02-03 00:07:00 +00:00
Azat Khuzhin
fabace394d Cleanup message brokers output streams 2021-02-03 00:32:36 +03:00
Alexander Tokmakov
6456ccf0da better test 2021-02-02 22:39:04 +03:00
Alexey Milovidov
12485eee6b Fix some of the issues found by Coverity 2021-02-02 22:07:23 +03:00
Aleksei Semiglazov
921518db0a CLICKHOUSE-606: query deduplication based on parts' UUID 
* add the query data deduplication excluding duplicated parts in MergeTree family engines.

query deduplication is based on parts' UUID which should be enabled first with merge_tree setting
assign_part_uuids=1

allow_experimental_query_deduplication setting is to enable part deduplication, default ot false.

data part UUID is a mechanism of giving a data part a unique identifier.
Having UUID and deduplication mechanism provides a potential of moving parts
between shards preserving data consistency on a read path:
duplicated UUIDs will cause root executor to retry query against on of the replica explicitly
asking to exclude encountered duplicated fingerprints during a distributed query execution.

NOTE: this implementation don't provide any knobs to lock part and hence its UUID. Any mutations/merge will
update part's UUID.

* add _part_uuid virtual column, allowing to use UUIDs in predicates.

Signed-off-by: Aleksei Semiglazov <asemiglazov@cloudflare.com>

address comments
 2021-02-02 16:53:39 +00:00
Alexander Kuzmenkov
264aea20be Merge remote-tracking branch 'origin/master' into HEAD 2021-02-02 19:12:46 +03:00
keenwolf
9beb7689cc add comments and update test cases. 2021-02-02 23:35:45 +08:00
Vitaly Baranov
9427d5d94b
Merge pull request #19805 from vitlibar/allow-getting-return-type-of-dictget-without-loading-dictionary 
Fix starting the server with tables having default expressions containing dictGet()
 2021-02-02 18:19:55 +03:00
Alexander Kuzmenkov
d2a0e44a3a
Merge pull request #19299 from ClickHouse/aku/window-prototype 
[wip] support RANGE frame for window functions
 2021-02-02 17:59:16 +03:00
Nikolai Kochetov
b2d7790794 Fix test. 2021-02-02 17:30:54 +03:00
alesapin
9979181c02 Merge branch 'master' into in_memory_raft 2021-02-02 17:05:20 +03:00
alexey-milovidov
695e28079d
Merge pull request #19960 from ClickHouse/json-extract-inaccurate-conversion-from-double-to-float 
Allow inaccurate conversion from double to float in function JSONExtract beacuse the users want that
 2021-02-02 15:15:37 +03:00
Nikolai Kochetov
998aed3029 Do not use inputs which values are known constants in ActionsDAG. 2021-02-02 14:58:35 +03:00
alexey-milovidov
4d0973cf25
Merge pull request #19959 from depressed-pho/fix-segv-fromModifiedJulianDay 
Fix a segfault in fromModifiedJulianDay()
 2021-02-02 13:50:14 +03:00
Alexander Tokmakov
0073c87d5d fix 2021-02-02 13:32:42 +03:00
alexey-milovidov
05b8164133
Merge pull request #19956 from ClickHouse/geohash-ubsan 
Fix UBSan report in geoHashesInBox
 2021-02-02 12:52:01 +03:00
alexey-milovidov
8f90367e99
Merge pull request #19957 from ClickHouse/msan-system-stack-trace 
Add MSan annotation for system.stack_trace
 2021-02-02 12:50:52 +03:00
feng lv
0edf65c094 fix test 
fix

update

fix spell
 2021-02-02 09:22:30 +00:00
Kruglov Pavel
fd5adf1ff6
Merge pull request #19925 from ClickHouse/fix_insert_values_with_semicolon 
Fix logical error in INSERT VALUES
 2021-02-02 12:05:19 +03:00
tavplubix
befee42ab0
Merge pull request #19684 from yiguolei/master 
Should fail ddl query as soon as possible if table is shutdown
 2021-02-02 11:46:58 +03:00
tavplubix
dbcddbcebd
Merge pull request #19770 from stigsb/materializemysql_system_parts 
Show MaterializeMySQL tables in system.parts
 2021-02-02 11:43:42 +03:00
alexey-milovidov
f5dc38a33c
Merge pull request #19584 from azat/client-complete-error-codes 
client: more suggestions
 2021-02-02 11:05:17 +03:00
Maksim Kita
d0151de4bb
Merge pull request #19608 from kreuzerkrieg/Add_IStoragePolicy_interface 
Add IStoragePolicy interface
 2021-02-02 11:03:20 +03:00
alesapin
d265e3b419 Less timeouts 2021-02-02 11:02:25 +03:00
feng lv
4279c7da41 add setting insert_shard_id 
add test

fix style

fix
 2021-02-02 04:26:59 +00:00
Alexey Milovidov
078011ef2d Allow conversion from double to float in function JSONExtract beacuse the users want that 2021-02-02 07:16:47 +03:00
Alexey Milovidov
06bd0345eb Merge branch 'master' into improve-performance-of-aggregate-functions 2021-02-02 06:48:08 +03:00
Alexey Milovidov
656cd583f7 Add MSan annotation for system.stack_trace 2021-02-02 06:46:54 +03:00
PHO
5f7a852b92 Fix a segfault in fromModifiedJulianDay() 
It was crashing when the argument type was Nullable(T) where T was any integral type other than Int32.
 2021-02-02 12:43:36 +09:00
Alexey Milovidov
9930bb0bf6 Fix UBSan report in geoHashesInBox 2021-02-02 06:37:24 +03:00
Alexey Milovidov
9f8f908779 Better code (add suggestion from Azat) 2021-02-02 06:05:40 +03:00
Alexey Milovidov
bd0ec1b9f4 Remove useless header 2021-02-02 06:03:30 +03:00
keenwolf
d251807ea4 add function timezoneOffset 2021-02-02 11:01:20 +08:00
tavplubix
37c178f5e1
Update DDLWorker.cpp 2021-02-02 10:32:01 +08:00
tavplubix
8e6b09b1ae
Update DDLWorker.cpp 2021-02-02 10:32:01 +08:00
tavplubix
902ae7894e
Update DDLWorker.h 2021-02-02 10:32:01 +08:00
Amos Bird
a7eb2ce6d0
initialize MaxDDLEntryId upon restarting 2021-02-02 10:32:01 +08:00
Alexander Kuzmenkov
8bd026271a more cleanup 2021-02-02 04:16:44 +03:00
Alexander Kuzmenkov
41880719bf
Merge pull request #19919 from ClickHouse/aku/remove-always-false 
Remove an always-false condition from query parser
 2021-02-02 03:54:02 +03:00
Alexander Kuzmenkov
d084625436 cleanup 2021-02-02 03:51:35 +03:00
Alexander Kuzmenkov
78a9624fc5 CURRENT ROW frame start for ROWS frame 2021-02-02 02:27:23 +03:00
Alexander Kuzmenkov
5e99b4461d cleanup 2 2021-02-02 02:27:17 +03:00
Alexander Kuzmenkov
ef46c36317 start offset for ROWS frame 2021-02-02 02:27:17 +03:00
Alexander Kuzmenkov
5e78105786 cleanup 3 2021-02-02 02:27:17 +03:00
Alexander Kuzmenkov
18b6fb2a93 cleanup 1 2021-02-02 02:24:04 +03:00
Azat Khuzhin
f3a56b965c Add deebug assertion for empty working buffer in WriteBuffer 2021-02-02 01:56:00 +03:00
Azat Khuzhin
8b92749e1c Fix ParallelFormattingOutputFormat after allowed partial writes 
The problem was that ParallelFormattingOutputFormat creats
BufferWithOutsideMemory with Memory<> whos size is 0, and this create
WriteBuffer with zero size, which will have endless loop.
 2021-02-02 01:52:19 +03:00
Azat Khuzhin
63a8f463f9 Allow writing partial buffer 
In #6012 the behavior of the WriteBuffer has been changed.

Before, WriteBuffer write the data when next() is called.
After, WriteBuffer will write the data if, and only if, the buffer is
full.

See the discussion here [1].

  [1]: https://github.com/ClickHouse/ClickHouse/pull/6012#discussion_r567320267
 2021-02-02 00:23:55 +03:00
Azat Khuzhin
37797fdf5b Merge remote-tracking branch 'upstream/master' into client-complete-error-codes 2021-02-02 00:14:53 +03:00
Alexander Tokmakov
9da445e740 execute initial query in the same thread 2021-02-01 22:29:47 +03:00
Pavel Kruglov
a3f1b825cc Fix build 2021-02-01 21:17:12 +03:00
alexey-milovidov
6b2f0435c8
Merge pull request #19375 from Avogar/select-final 
Improve do_not_merge_across_partitions_select_final optimization.
 2021-02-01 20:31:08 +03:00
alexey-milovidov
1f0a91e0ab
Merge pull request #19677 from kitaisreal/executable-dictionary-implicit-key-option 
ExecutableDictionarySource added implicit_key option
 2021-02-01 20:13:25 +03:00
alexey-milovidov
2901591f81
Merge pull request #19876 from ClickHouse/intdiv-ubsan 
Fix UBSan report in intDiv
 2021-02-01 20:12:30 +03:00
Alexey Milovidov
349d783089 Improve performance of aggregate functions 2021-02-01 20:12:12 +03:00
alesapin
365bf65f5a Fix install script 2021-02-01 17:14:59 +03:00
alesapin
2aa8a6304b
Merge pull request #15450 from CurtizJ/fix-ttl-group-by 
Fix some cases of TTL expressions
 2021-02-01 16:48:07 +03:00
alesapin
57c9b6c864 Fix build without nuraft 2021-02-01 16:18:17 +03:00
Nikolai Kochetov
19e4a33f9d
Merge pull request #19544 from amosbird/limitconcurrency 
Per MergeTree table query limit
 2021-02-01 16:09:12 +03:00
alexey-milovidov
f09158de0c
Merge pull request #19884 from kitaisreal/bloom-filter-index-crash-fix 
BloomFilter index crash fix
 2021-02-01 15:42:56 +03:00
alexey-milovidov
9161a5f570
Merge pull request #19875 from ClickHouse/text-log-fix-deadlock 
Fix deadlock in system.text_log
 2021-02-01 15:42:16 +03:00
Alexander Tokmakov
accf4d262e fix logical error 2021-02-01 15:40:57 +03:00
alesapin
0fb7bc6cbe clang-tidy is very smart 2021-02-01 15:10:55 +03:00
alesapin
0aca40d8cb Merge branch 'master' into in_memory_raft 2021-02-01 14:30:11 +03:00
alesapin
eb5c77f558 Fix some races and better reaction to leader change 2021-02-01 14:27:26 +03:00
Alexander Kuzmenkov
7780c0b8e9 Remove an always-false condition from query parser 
https://github.com/ClickHouse/ClickHouse/pull/19236#discussion_r567673775
 2021-02-01 13:49:19 +03:00
tavplubix
2a20f20f21
Merge pull request #19790 from taiyang-li/fix_client_select 
fix client bug while executing select
 2021-02-01 13:17:14 +03:00
robot-clickhouse
cd82eed093 Auto version update to [21.3.1.1] [54448] 2021-02-01 12:50:56 +03:00
Maksim Kita
d9d206af92 Fixed typo 2021-02-01 12:35:47 +03:00
Maksim Kita
d3f299269f Fixed code review issues 2021-02-01 12:35:47 +03:00
alexey-milovidov
e5b89f24b5 Update ExecutableDictionarySource.cpp 2021-02-01 12:35:47 +03:00
alexey-milovidov
77a8ef24de Update ExecutableDictionarySource.cpp 2021-02-01 12:35:47 +03:00
alexey-milovidov
ecd6e10e22 Update ExecutableDictionarySource.cpp 2021-02-01 12:35:47 +03:00
alexey-milovidov
b83b8c56da Update ExecutableDictionarySource.cpp 2021-02-01 12:35:47 +03:00
Maksim Kita
a0755e439c Fixed typo 2021-02-01 12:35:47 +03:00
Maksim Kita
a9ecb6bf78 Fixed clang-tidy 2021-02-01 12:35:47 +03:00
Maksim Kita
d194294d0b Fixed tests 2021-02-01 12:35:47 +03:00
Maksim Kita
dafb0ef4e9 ExecutableDictionarySource added implicit_key option 2021-02-01 12:35:47 +03:00
tavplubix
4f955be832
fix sync 2021-02-01 12:32:36 +03:00
Stig Bakken
bedc472bb0 Show MaterializeMySQL tables in system.parts 2021-02-01 16:59:10 +08:00
alesapin
67412bd529 Don't accept connections if we don't see leader + race fix from upstream 2021-02-01 10:51:10 +03:00
alexey-milovidov
ef72ba7349
Merge pull request #19861 from amosbird/fixcte 
Fix crash when pushing down predicates to union distinct subquery
 2021-02-01 10:28:41 +03:00
alexey-milovidov
f4df161672
Merge pull request #19863 from ClickHouse/improve-server-latency 
Maybe improve server latency
 2021-02-01 10:27:44 +03:00
Alexey Milovidov
49979afbc1 Fix bad translation 2021-02-01 10:12:14 +03:00
Alexey Milovidov
57664bffe0 Amend 2021-02-01 10:11:41 +03:00
alesapin
d9598c47b4
Merge pull request #19702 from ClickHouse/fix_rare_bug_after_part_corruption 
Fix incorrect virtual_parts after part corruption
 2021-02-01 10:09:48 +03:00
Alexey Milovidov
e9a61c4738 More correct 2021-02-01 07:52:18 +03:00
Alexey Milovidov
1c0c3b3aab Merge branch 'master' into intdiv-ubsan 2021-02-01 07:46:40 +03:00
alexey-milovidov
08f713f177
Merge pull request #14822 from vzakaznikov/live_view_periodic_refresh 
Adding support for periodically refreshed LIVE VIEW tables
 2021-02-01 06:11:30 +03:00
yiguolei
768e461d28 add functional test 2021-02-01 10:40:48 +08:00
alexey-milovidov
cc23a2b399
Update PredicateRewriteVisitor.cpp 2021-02-01 03:44:40 +03:00
alexey-milovidov
a6b0fdd3eb
Merge pull request #19862 from ClickHouse/ubsan-gather-utils 
Fix UBSan report in GatherUtils
 2021-02-01 03:43:43 +03:00
alexey-milovidov
9407c5baf4
Merge pull request #19868 from amosbird/fixif 
Fix argMinMaxIf crash
 2021-02-01 03:42:48 +03:00
Alexander Tokmakov
84d3d6e728 fix 'Unmatched parentheses', add test 2021-02-01 02:10:41 +03:00
Maksim Kita
d2b8d9886f Fixed fuzzer crash 2021-01-31 22:25:53 +03:00
Maksim Kita
1aa8d7fdfb BloomFilter index crash fix 2021-01-31 21:49:27 +03:00
Maksim Kita
a4812aa97b Updated tests 2021-01-31 18:32:47 +03:00
alexey-milovidov
342baa4223
Merge pull request #19720 from ClickHouse/unicode-asan 
Fix unsufficient args check (trash code) in StringSearcher
 2021-01-31 15:43:05 +03:00
alexey-milovidov
b80ad9f9bc
Merge pull request #19859 from ClickHouse/date-time-add-ubsan 
Fix UBSan report in DateTimeAddInterval
 2021-01-31 14:09:04 +03:00
vdimir
000b51f95a
Merge pull request #19518 from bharatnc/ncb/toIPv6-parses-IPv4 
toIPv6 function parses IPv4 addresses
 2021-01-31 13:56:45 +03:00
Alexey Milovidov
ddff28e594 Fix UBSan report in intDiv 2021-01-31 13:23:50 +03:00
Alexey Milovidov
11f144f589 Fix deadlock in system.text_log 2021-01-31 13:02:35 +03:00
Alexey Milovidov
37f88a1468 Whitespace 2021-01-31 12:02:54 +03:00
Azat Khuzhin
978f23e343 Fix SIGSEGV due to accessing GRPCServer::currentConnections() before initialization 
This PR makes asynchronous metrics available just after start, and this
breaks GRPCServer, since it requires the server be started before
accessing currentConnections().

However it is possible to trigger the same SIGSEGV even without that
patch, with some timeouts during previous server initilizations and
small asynchronous_metrics_update_period_s.

Fix this by creating GRPCServer::Runner in the ctor.

Stacktrace:
    26.842505 [ 7 ] {} <Information> Application: Listening for MySQL compatibility protocol: 0.0.0.0:9004
    26.842562 [ 7 ] {} <Information> Application: Listening for gRPC protocol: 0.0.0.0:9100
    26.842600 [ 7 ] {} <Debug> AsynchronousMetrics: MemoryTracking: was 350.72 KiB, peak 5.25 MiB, will set to 232.63 MiB (RSS), difference: 232.29 MiB
    26.842834 [ 8 ] {} <Trace> BaseDaemon: Received signal 11
    26.843014 [ 39 ] {} <Fatal> BaseDaemon: ########################################
    26.843055 [ 39 ] {} <Fatal> BaseDaemon: (version 21.2.1.5858, build id: B27D5550AC34F9091BC4437D8021B752EDB34FBB) (from thread 7) (no query) Received signal Segmentation fault (11)
    26.843085 [ 39 ] {} <Fatal> BaseDaemon: Address: 0x78 Access: read. Address not mapped to object.
    26.843104 [ 39 ] {} <Fatal> BaseDaemon: Stack trace: 0x7fe8c4e6afc4 0x13683cf1 0xf52efe5 0xe7c9137 0x85596e1 0x8553635 0x11b7a313 0x8545ebc 0x8544b25 0x84e1cbe 0x7fe8c4c940b3 0x84ac22e
    26.843136 [ 39 ] {} <Fatal> BaseDaemon: 2. pthread_mutex_lock @ 0xbfc4 in /usr/lib/x86_64-linux-gnu/libpthread-2.31.so
    26.843162 [ 39 ] {} <Fatal> BaseDaemon: 3. std::__1::mutex::lock() @ 0x13683cf1 in ?
    26.843188 [ 39 ] {} <Fatal> BaseDaemon: 4. DB::GRPCServer::currentConnections() const @ 0xf52efe5 in /usr/bin/clickhouse
    26.843204 [ 39 ] {} <Fatal> BaseDaemon: 5. DB::AsynchronousMetrics::update() @ 0xe7c9137 in /usr/bin/clickhouse
    26.843228 [ 39 ] {} <Fatal> BaseDaemon: 6. DB::AsynchronousMetrics::start() @ 0x85596e1 in /usr/bin/clickhouse
    26.843248 [ 39 ] {} <Fatal> BaseDaemon: 7. DB::Server::main(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) @ 0x8553635 in /usr/bin/clickhouse
    26.843270 [ 39 ] {} <Fatal> BaseDaemon: 8. Poco::Util::Application::run() @ 0x11b7a313 in /usr/bin/clickhouse
    26.843284 [ 39 ] {} <Fatal> BaseDaemon: 9. DB::Server::run() @ 0x8545ebc in /usr/bin/clickhouse
    26.843299 [ 39 ] {} <Fatal> BaseDaemon: 10. mainEntryClickHouseServer(int, char**) @ 0x8544b25 in /usr/bin/clickhouse
    26.843313 [ 39 ] {} <Fatal> BaseDaemon: 11. main @ 0x84e1cbe in /usr/bin/clickhouse
    26.843331 [ 39 ] {} <Fatal> BaseDaemon: 12. __libc_start_main @ 0x270b3 in /usr/lib/x86_64-linux-gnu/libc-2.31.so
    26.843346 [ 39 ] {} <Fatal> BaseDaemon: 13. _start @ 0x84ac22e in /usr/bin/clickhouse
 2021-01-31 11:29:46 +03:00
Amos Bird
18f3df31d5
Fix crash when pushing down predicates to union distinct subquery 2021-01-31 16:29:29 +08:00
Amos Bird
c39ee3f58c
Fix argMinMaxIf crash 2021-01-31 16:27:46 +08:00
Alexey Milovidov
5b7c437e6d Minor modification 2021-01-31 11:24:37 +03:00
alexey-milovidov
842c2c840c
Merge pull request #19773 from ClickHouse/tavplubix-patch-3 
Fix stack overflow in FieldVisitorAccurateEquals
 2021-01-31 11:09:41 +03:00
Alexey Milovidov
01a703ae50 Update test 2021-01-31 10:48:18 +03:00
Alexey Milovidov
d604cbc986 Maybe improve server latency 2021-01-31 10:41:24 +03:00
Alexey Milovidov
e23dc60e31 Fix UBSan report in GatherUtils 2021-01-31 10:12:17 +03:00
Alexey Milovidov
248540e58f Fix UBSan report in GatherUtils 2021-01-31 10:10:37 +03:00
Alexey Milovidov
40a356db74 Fix warning 2021-01-31 07:40:51 +03:00
Alexey Milovidov
0128d185ea Fix UBSan report in DateTimeAddInterval 2021-01-31 06:49:33 +03:00
alexey-milovidov
d93dad0ec3
Merge pull request #19722 from azat/background_message_broker_schedule_pool_size 
Add separate pool for message brokers (RabbitMQ and Kafka)
 2021-01-31 06:07:45 +03:00
alexey-milovidov
d0bd6af49d
Merge pull request #19824 from azat/tryLogCurrentException 
Avoid losing exception messages in logs under high memory pressure
 2021-01-31 06:05:55 +03:00
Alexey Milovidov
0fa5142715 Remove tons of garbage 2021-01-31 05:36:52 +03:00
Alexey Milovidov
5c718c8754 Merge branch 'master' into unicode-asan 2021-01-31 02:40:24 +03:00
alexey-milovidov
8ac39e7f56
Merge pull request #19791 from ClickHouse/format-readable-time-delta-ubsan 
formatReadableTimeDelta: correctly output infinite values
 2021-01-31 01:37:59 +03:00