Commit Graph

4399 Commits

Author SHA1 Message Date
Alexey Milovidov
9e32d0f5b2 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-inconsistent-formatting 2024-02-23 15:05:46 +01:00
Vitaly Baranov
db119eed49
Merge pull request #60002 from vitlibar/add-config-setting-remove-backup-files-after-failure
Add new config setting "backups.remove_backup_files_after_failure"
2024-02-23 12:42:55 +01:00
János Benjamin Antal
7cad0050c0
Disambiguate alter commands list (#59532)
* Add optional parentheses to TTL element and alter command

* Add some basic tests

* Extend tests with more test cases

* Add one more test case

* Add server setting to control new formatting behavior

* Automatic style fix

* Fix segfault in `clickhouse-format` related to new server setting

* Remove format_ttl_expressions_with_parentheses

* Fix unit test compilation failures

* Introduce global flag to control the new formatting behavior

* Revert "Fix segfault in `clickhouse-format` related to new server setting"

This reverts commit d7131a3145.

* Revert accidental changes

* Revert accidental include reorder

* Revert accidental changes

* Enable new format in client and local server

---------

Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2024-02-22 19:17:15 +01:00
Vitaly Baranov
b130726a0c
Merge branch 'master' into add-config-setting-remove-backup-files-after-failure 2024-02-22 18:09:12 +01:00
Alexander Tokmakov
97ed2c05b0 Merge branch 'master' into fix_undead_sessions 2024-02-22 14:36:36 +01:00
Alexey Milovidov
2d9fbaa859 Merge with master 2024-02-21 20:37:48 +01:00
Alexander Tokmakov
64a80f1011
Fix default path when path is not specified in config (#59654)
* Update Server.cpp

* Update SentryWriter.cpp

* Update Keeper.cpp

* Update SentryWriter.cpp
2024-02-21 20:33:39 +01:00
Igor Nikonov
a0105e94ba
Merge pull request #60077 from ClickHouse/cleanup-connection-pool-priority
Cleanup: less confusion between config priority and balancing priority in connection pools
2024-02-21 15:22:08 +01:00
Sergei Trifonov
6e3fddf4a3
Merge pull request #59313 from ClickHouse/abstract-concurrency-control
Split `ISlotControl` from `ConcurrencyControl`
2024-02-21 15:04:03 +01:00
Robert Schulze
6a027b3528
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-21 11:48:34 +00:00
Alexander Tokmakov
45d407034f Merge branch 'master' into fix_undead_sessions 2024-02-20 22:21:37 +01:00
Antonio Andelic
bb0b1fa9bc Fix 2024-02-20 14:46:16 +01:00
Antonio Andelic
a0bfb47e95 Merge branch 'master' into keeper-more-resilient-disks 2024-02-20 13:51:23 +01:00
Alexey Milovidov
c753550d0b Digging into a pile of garbage 2024-02-20 10:42:20 +01:00
Igor Nikonov
f06e15ce5f Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-19 11:33:55 +00:00
Robert Schulze
ba9661a5d4
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-19 09:54:08 +00:00
Alexey Milovidov
a955ae8673
Merge pull request #60086 from ClickHouse/check-wrong-abbrs
Check wrong abbreviations
2024-02-17 05:17:11 +01:00
Alexey Milovidov
3128cf1f1b Remove the check for formatting consistency from the Fuzzer 2024-02-17 02:24:21 +01:00
Alexey Milovidov
509d8ee99c Apply review comments 2024-02-17 01:54:54 +01:00
Alexey Milovidov
ceb65bb114 Merge branch 'master' of github.com:ClickHouse/ClickHouse into print-cpu-flags-at-startup 2024-02-17 01:53:56 +01:00
Igor Nikonov
b85a68790a Cleanup: connection pool priority -> config priority
- names were creating confusion between config priority and balancing priority for a reader
2024-02-16 14:39:41 +00:00
Kruglov Pavel
4d6f167e0c
Merge pull request #59092 from Avogar/auto-format-detection
Try to detect file format automatically during schema inference if it's unknown
2024-02-16 14:32:18 +01:00
Alexey Milovidov
39f363ba6e Print CPU flags at startup 2024-02-16 13:09:07 +01:00
Alexey Milovidov
0787e9f402 Merge remote-tracking branch 'origin/master' into print-cpu-flags-at-startup 2024-02-16 13:07:03 +01:00
Alexey Milovidov
5b83e771ed Print CPU flags at startup 2024-02-16 13:06:57 +01:00
Antonio Andelic
0f489de46e
Merge pull request #59945 from ClickHouse/keeper-prometheus-filtered-events
Send only Keeper related metrics/events for Prometheus
2024-02-16 09:43:43 +01:00
Alexander Tokmakov
22c97be2a4 ability to detect undead ZooKeeper sessions 2024-02-15 22:17:31 +01:00
Konstantin Bogdanov
dbb6804a70
Merge pull request #59976 from ClickHouse/add-cloud-placement
Add `PlacementInfo`
2024-02-15 19:16:56 +03:00
Alexey Milovidov
0b58f16938
Merge pull request #59964 from ClickHouse/cleanups
Cleanups
2024-02-15 02:59:54 +01:00
Vitaly Baranov
5591d74076 Add new config setting "backups.remove_backup_files_after_failure". 2024-02-14 23:19:21 +01:00
Alexey Milovidov
7a5e152d9e
Merge pull request #59967 from ClickHouse/dashboards-to-use-merge-tables
Use merge table in the dashboard; add Cloud overview to the system table
2024-02-14 21:56:37 +01:00
Antonio Andelic
40d4fc1c24 More resilient Disk related operations 2024-02-14 14:53:22 +01:00
Antonio Andelic
0bee591a0c Fix build 2024-02-14 14:10:58 +01:00
Yarik Briukhovetskyi
4c57400664
Merge pull request #59922 from xuzifu666/Common_imporve
Commands node args should add rvalue to push_back to reduce object copy cost
2024-02-14 12:42:45 +01:00
Konstantin Bogdanov
48fcc3eeab
Fix standalone build 2024-02-14 12:41:41 +01:00
Konstantin Bogdanov
f678bdc546
Update tests 2024-02-14 10:51:42 +01:00
Konstantin Bogdanov
914fd27d5b
Add PlacementInfo 2024-02-14 10:19:36 +01:00
Robert Schulze
7b7ea6d477
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-14 08:56:22 +00:00
Alexey Milovidov
c49651ef89 Even less conflicts 2024-02-14 03:31:31 +01:00
Alexey Milovidov
39378deac1 Less conflicts 2024-02-14 03:09:40 +01:00
Alexey Milovidov
98f7602ea1 Less conflicts 2024-02-14 03:01:03 +01:00
Alexey Milovidov
27f115f581 Use merge table in the dashboard 2024-02-14 02:17:23 +01:00
Alexey Milovidov
2b4949bd18 Cleanups 2024-02-14 00:21:13 +01:00
Alexey Milovidov
8b59977639
Merge pull request #59909 from azat/rmt-macros-cleanup
Petite cleanup around macros and ReplicatedMergeTree
2024-02-14 00:09:34 +01:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection 2024-02-13 19:08:33 +01:00
Antonio Andelic
0d151e3f0d Send only specific events/metrics for Keeper prometheus 2024-02-13 16:01:50 +01:00
xuzifu666
12599c4b8e Commands node args should add rvalue to push_back 2024-02-13 17:35:55 +08:00
Alexey Milovidov
58563ef036
Merge pull request #59857 from azat/build/components-cleanup
Remove ability to disable generic clickhouse components
2024-02-13 04:21:08 +01:00
Azat Khuzhin
c61ac1d3bc Convert default_replica_path/default_replica_name into server settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
Azat Khuzhin
13e3877254 Add chc/chl/ch into clickhouse-bundle target
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 14:32:15 +01:00
Azat Khuzhin
11fddc8d63 Unify binary aliases
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 12:06:33 +01:00
Azat Khuzhin
3145c5d5f5 Add missing install target for ch/chc/chl
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 12:02:42 +01:00
Azat Khuzhin
7fb31fe160 Remove ability to disable generic clickhouse components
Components like client/server/... are very generic, and there is no
point in disabling them, since it does not reduce amount of compiled
code a lot anyway (just a few modules for entrypoints, everything else
is already included in the clickhouse binary), and eventually they are
just symlinks to the clickhouse binary.

But there are few, that requires extra libraries, like ODBC bridge or
keeper components (and there is also standalone keeper binary compiled
with musl), those had been kept.

Also add some descriptions for some utils and change exit code to 0 for
--help.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:10:00 +01:00
Antonio Andelic
36b966967b Merge branch 'master' into keeper-more-reduce 2024-02-12 10:03:07 +01:00
Alexey Milovidov
5dbcff8048
Merge pull request #58609 from azat/binary-aliases-cmake
Create ch/chc/chl symlinks by cmake as well (for develop mode)
2024-02-11 23:45:58 +01:00
Alexey Milovidov
61227acdc4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-10 19:30:22 +01:00
Robert Schulze
3a4b6a2379
Merge remote-tracking branch 'rschu1ze/master' into cgroup-observing-memory-tracker 2024-02-10 13:53:19 +00:00
Azat Khuzhin
e6d96e4325 Better warning for disabled kernel.task_delayacct
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-10 14:49:43 +01:00
Alexey Milovidov
a7c30098b6 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-09 22:52:49 +01:00
Antonio Andelic
35303603b6 Merge branch 'master' into keeper-more-reduce 2024-02-09 11:28:03 +01:00
Alexey Milovidov
a585ae60a8 English (somewhat incomplete) 2024-02-09 00:30:29 +01:00
Alexey Milovidov
1b91b7b999 Better logs in CI and non-interactive install 2024-02-09 00:16:15 +01:00
Robert Schulze
f6f1fd4d26
Initial implementation 2024-02-08 16:06:44 +00:00
serxa
0130d525f4 fix dashboard params default values 2024-02-08 12:02:28 +00:00
Antonio Andelic
33f12c9f35 Merge branch 'master' into keeper-more-reduce 2024-02-08 10:54:26 +01:00
Alexey Milovidov
02c0b4c67f Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-02-07 22:45:50 +01:00
Konstantin Bogdanov
38373b989a
Merge pull request #59659 from ClickHouse/create-tables-in-threadpool-followup
Follow up for #59277
2024-02-07 21:12:43 +03:00
Antonio Andelic
15c89bdd66 Merge branch 'master' into keeper-more-reduce 2024-02-07 14:21:31 +01:00
Alexey Milovidov
d65a56d967
Merge branch 'master' into enable-coverage-for-debug-build 2024-02-07 04:58:21 +01:00
Konstantin Bogdanov
5894fa9860
0 means number of cores 2024-02-06 19:10:34 +01:00
Alexey Milovidov
8a428eb7cf Better usability for server versions in ClickHouse Cloud 2024-02-06 18:37:14 +01:00
Antonio Andelic
a0170bcbd5 Fix utils 2024-02-05 17:58:33 +01:00
Antonio Andelic
2116043e2c Merge branch 'master' into keeper-more-reduce 2024-02-05 14:58:26 +01:00
Konstantin Bogdanov
f663f13a35
Merge pull request #59277 from ClickHouse/create-tables-in-threadpool
Concurrent tables creation in `recoverLostReplica`
2024-02-05 16:04:46 +03:00
serxa
9c93a76268 Fix backward incompatibility of dashboard url hashes 2024-02-04 12:50:26 +00:00
Amos Bird
e3716b0f38
Backward compatibility of uncompressed state 2024-02-04 11:03:18 +08:00
Alexey Milovidov
667256a67d Fixes for binary.html 2024-02-01 20:36:38 +01:00
Konstantin Bogdanov
5969668503
Concurrent table creation in DatabaseReplicated 2024-02-01 09:51:52 +01:00
Alexey Milovidov
a286d500c3
Merge pull request #59124 from amosbird/dashboard-compress-state
Compress state of dashboard
2024-01-30 08:05:38 +01:00
avogar
377937d415 Merge branch 'master' of github.com:ClickHouse/ClickHouse into auto-format-detection 2024-01-29 15:45:18 +00:00
Alexey Milovidov
cb69a1b25d Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-01-29 15:35:04 +01:00
Alexey Milovidov
aec3f28ccb Support backups for compressed in-memory tables 2024-01-28 23:06:50 +01:00
Alexey Milovidov
4a94ae5a1b Merge branch 'master' into enable-coverage-for-debug-build 2024-01-28 22:24:26 +01:00
serxa
ba85642453 split ISlotControl from ConcurrencyControl 2024-01-28 20:26:55 +00:00
Alexey Milovidov
77de2b0ebc
Merge pull request #59311 from ClickHouse/binary-allow-user-host-password
`/binary` handler: allow specifying user/password/host
2024-01-28 20:33:39 +01:00
Alexey Milovidov
45cb7094af
Merge pull request #59303 from ClickHouse/play-rendering-errors-json
Play UI: improve rendering of errors from JSON formats
2024-01-28 18:32:27 +01:00
Alexey Milovidov
4dcf27e5b2 /binary: allow specifying user/password/host 2024-01-28 18:27:15 +01:00
Alexey Milovidov
9dd6362ae7 Play UI: improve rendering of errors from JSON formats 2024-01-28 13:44:56 +01:00
Azat Khuzhin
4248ae509a Support specifying settings for Distributed engine in config (like for MergeTree)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 18:06:16 +01:00
Azat Khuzhin
1404b73b50 Add example of configuring ReplicatedMergeTree via config.xml
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-27 17:03:18 +01:00
Kruglov Pavel
946c4e0495
Merge branch 'master' into auto-format-detection 2024-01-26 15:51:35 +01:00
Sergei Trifonov
4fb511bfb3
Merge pull request #59137 from ClickHouse/fix-async-loader-shutdown-deadlock
Fix not started database shutdown deadlock
2024-01-26 11:21:13 +01:00
Kruglov Pavel
46a6b84a5a
Merge branch 'master' into auto-format-detection 2024-01-25 22:11:07 +01:00
Maksim Kita
2a327107b6 Updated implementation 2024-01-25 14:31:49 +03:00
serxa
a40da92761 Merge branch 'master' into fix-async-loader-shutdown-deadlock 2024-01-25 11:31:05 +00:00
Antonio Andelic
3e3ae52aca Reduce even more memory 2024-01-25 08:40:19 +00:00
Nikolay Edigaryev
c8adf35298
DisksApp.cpp: fix typo (specifiged → specified) 2024-01-24 02:34:17 +04:00
serxa
8728ab768f Fix not started database shutdown deadlock 2024-01-23 19:01:57 +00:00
avogar
48609d3c9f Fix tests 2024-01-23 18:59:40 +00:00
avogar
617cc514b7 Try to detect file format automatically during schema inference if it's unknown 2024-01-23 18:59:39 +00:00
Amos Bird
7e86c0e928
Compress state of dashboard 2024-01-23 23:04:19 +08:00
Robert Schulze
e23e7e6b73
Merge pull request #53710 from rschu1ze/system-reload-asynchronous-metrics
Add statement `SYSTEM RELOAD ASYNCHRONOUS METRICS`
2024-01-23 11:56:25 +01:00
serxa
7b99d9a176 wait for currently running jobs to finish #2 2024-01-22 23:50:53 +00:00
serxa
1d6d1182fd Fix server shutdown due to exception while loading metadata 2024-01-22 19:38:26 +00:00
Robert Schulze
90a0ea36b3
Add statement 'SYSTEM RELOAD ASYNCHRONOUS METRICS' 2024-01-22 17:14:58 +00:00
Alexander Tokmakov
b8d69ecd5f
Update Client.cpp 2024-01-22 17:00:56 +01:00
Vitaly Baranov
01aafda27b
Merge pull request #58804 from vitlibar/allow-kill-query-for-backups
Allow KILL QUERY for backups
2024-01-20 23:48:18 +01:00
Alexey Milovidov
dc1dac3ba4 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-01-20 21:41:07 +01:00
Alexey Milovidov
735708e9bb Merge branch 'master' into enable-coverage-for-debug-build 2024-01-20 21:40:53 +01:00
robot-clickhouse
273a06856a
Merge pull request #59025 from ClickHouse/cpu-scheduler
Split resource scheduler off `IO/` into `Common/Scheduler/`
2024-01-20 15:43:50 +01:00
Kseniia Sumarokova
5d67e26fc4
Merge pull request #58869 from ClickHouse/force-check-for-cached-custom-disk
Fix for custom cached disk creation
2024-01-20 14:47:36 +01:00
serxa
824deab761 split resource scheduler off IO/ into Common/Scheduler/ 2024-01-20 12:06:26 +00:00
Kruglov Pavel
90057c6f39
Merge pull request #58907 from ClickHouse/Avogar-patch-1
Fix possible crash in clickhouse-local during loading suggestions
2024-01-19 11:20:25 +01:00
Vitaly Baranov
4c6d3e7efa Add server settings "shutdown_wait_backups_and_restores" (default=true)
to set whether shutdown should wait for running backups to finish or just cancel them.
2024-01-18 13:27:14 +01:00
Alexey Milovidov
c098f41dbc Merge branch 'master' into enable-coverage-for-debug-build 2024-01-17 22:35:51 +01:00
Kruglov Pavel
79b3e19eb1
Fix style 2024-01-17 14:54:18 +01:00
Kruglov Pavel
63ac1c784f
Fix possible crash in clickhouse-local during loading suggestions 2024-01-17 14:28:10 +01:00
kssenii
3d564c0802 Fix typo 2024-01-17 10:34:13 +01:00
Mikhail Koviazin
6e6197019c
Reintroduce commit 3067ca6
Update `query_masking_rules` when reloading the config

This reverts commit 7e55eab1c3.
2024-01-17 08:10:49 +02:00
kssenii
237146b4e2 Add to default config 2024-01-16 16:30:07 +01:00
Alexey Milovidov
1caef19143 Maybe better 2024-01-16 09:44:52 +01:00
Alexey Milovidov
779f738cb9 Merge branch 'master' of github.com:ClickHouse/ClickHouse into enable-coverage-for-debug-build 2024-01-16 05:07:17 +01:00
Kseniia Sumarokova
ae884760db
Merge pull request #58357 from ClickHouse/better-disks-configuration
Flexible configuration for disks
2024-01-15 21:34:36 +01:00
Alexey Milovidov
e13ca48bce Better dump on exit 2024-01-15 05:13:43 +01:00
Alexey Milovidov
30c3629090 An option to dump coverage to a file at exit 2024-01-15 00:36:44 +01:00
kssenii
341a9b3b70 Fix keeper build 2024-01-13 12:56:27 +01:00
Alexey Milovidov
d112492c56 Remove some code 2024-01-13 03:48:04 +01:00
kssenii
f4546a5eee Fix build 2024-01-12 10:53:40 +01:00
Antonio Andelic
654fee820e
Merge pull request #58665 from ClickHouse/jemalloc-system-commands
Add SYSTEM commands and Keeper 4LW for jemalloc
2024-01-12 10:08:13 +01:00
Antonio Andelic
2bfed6b8eb Add system commands and 4lw for jemalloc 2024-01-11 08:24:56 +00:00
Yakov Olkhovskiy
4fc11e189c
Merge branch 'master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-10 12:03:47 -05:00
Yakov Olkhovskiy
2e124b19b8
Merge branch 'master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-10 09:05:18 -05:00
Robert Schulze
499227b9cf
Merge remote-tracking branch 'rschu1ze/master' into replace-std_regexp-by-re2 2024-01-10 10:02:53 +00:00
vdimir
b4bfd01322
Merge pull request #58246 from ClickHouse/vdimir/util_format_values
clickhouse-format improvements: support VALUES, comments, max_line_length
2024-01-09 11:24:42 +01:00
Bharat Nallan
ee37f551a2
independent registration of interpreters (#58443)
* make interpreter factory an instance

* add registerInterpreter

* register interpreters individually

* try wire everything up

* fix style

* fix test
2024-01-08 22:33:48 -08:00
Alexey Milovidov
d3e73ff6e6
Merge pull request #58584 from ClickHouse/enable-all-access-control-improvements
Enable all access control improvements by default
2024-01-08 23:05:47 +01:00
Azat Khuzhin
c5bf722ee2 Create ch/chc/chl symlinks by cmake as well (for develop mode)
Before, they had been created only by install target.

Follow-up for: #56634

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-01-08 21:27:53 +03:00
vdimir
e68fc2df7a
Remove spaces after insert in clickhouse-format 2024-01-08 12:16:53 +00:00
vdimir
cccc24c2fd
upd 2024-01-08 12:01:34 +00:00
vdimir
621d17b16f
Better clickhouse-format: support VALUES, comments 2024-01-08 12:01:33 +00:00
Alexey Milovidov
eb8217efb0 Fix wrong message in Keeper 2024-01-08 01:22:11 +01:00
Robert Schulze
f553b55e3a
Merge remote-tracking branch 'rschu1ze/master' into regex-std-re2 2024-01-07 22:31:35 +00:00
Robert Schulze
8e804487f3
Some fixups 2024-01-07 22:28:08 +00:00
Alexey Milovidov
6bc27dfcf5 Enable all access control improvements by default 2024-01-07 20:56:16 +01:00
Yakov Olkhovskiy
feab812712 read body of HTTP POST request to prevent 'connection reset by peer' error on client side 2024-01-07 14:40:12 +00:00
Yakov Olkhovskiy
9ca4be5d91 Merge remote-tracking branch 'origin/master' into revert-58450-revert-56064-feature-server-iface-metrics 2024-01-06 00:24:31 +00:00
Michael Kolupaev
52058211e7
Fix some thread pool settings not updating at runtime (#58485) 2024-01-04 17:21:46 +01:00
Alexander Tokmakov
10e3ae9e68 Merge branch 'master' into allow-not-resolving-hostnames 2024-01-04 13:22:15 +01:00
Yakov Olkhovskiy
85f03478ef
Revert "Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces"" 2024-01-03 11:47:15 -05:00
Raúl Marín
d491758939
Revert "Use CH Buffer for HTTP out stream, add metrics for interfaces" 2024-01-03 10:42:15 +01:00