Commit Graph

23111 Commits

Author SHA1 Message Date
Azat Khuzhin
7b4fcc5fc5 Read temporary tables on failure to avoid interpreting that bits as query
Before this patch if the query failes (due to "Too many simultaneous
queries" for example) it will not read external tables info, and the
next request will interpret them as the query beginning at got:

  DB::Exception: Unknown packet 11861 from client

v2: reordering in the executeQuery() is not enough, since the query
    can fail in other places, before, i.e. quotas
v3: I cannot make non-intergration test (since there is no ability to
    receive "Unknown packet" via client, only from the server log),
    hence added one
2019-12-08 23:26:43 +03:00
Oleg Matrokhin
8ea7cab7e4 simplify expression 2019-12-08 18:07:06 +03:00
Oleg Matrokhin
2cab90b9f4 fmt 2019-12-08 17:36:31 +03:00
Oleg Matrokhin
36303a82f7 add tests 2019-12-08 17:24:37 +03:00
alesapin
af7b8f9274
Merge pull request #8051 from ClickHouse/fix_collations_behaviour
Fix several bugs with collations.
2019-12-08 11:10:23 +03:00
Yuriy
e0796261aa mysql protocol: fixed Float32 conversion and added types test 2019-12-08 08:40:08 +03:00
Oleg Matrokhin
10cf9e5b9f implement new function 2019-12-08 03:18:24 +03:00
Nicolae Vartolomei
f5e764eba1 Fix SYSTEM query parser suggestions 2019-12-07 23:05:57 +00:00
Vladimir Chebotarev
984e81876a Fixed Clang build. 2019-12-07 22:30:37 +03:00
Vladimir Chebotarev
bb0de2509a Fixed test_system_merges/test.py::test_mutation_simple[replicated] test. 2019-12-07 22:23:25 +03:00
Vladimir Chebotarev
c60493fe72 Fixed test_system_merges/test.py::test_merge_simple[replicated] test. 2019-12-07 22:02:01 +03:00
alesapin
2fffe2802f Review fixes 2019-12-07 16:13:14 +03:00
Vladimir Chebotarev
ed2ec2d15d Fixed test_system_merges to correctly check replicated node set. 2019-12-07 13:35:13 +03:00
Vladimir Chebotarev
1513e5a854 Added replicated tests for system.merges. 2019-12-07 13:15:01 +03:00
Vladimir Chebotarev
1fbfb50fba Fixed updating result_part_path while merging and mutating. 2019-12-07 12:54:05 +03:00
Vladimir Chebotarev
b64b2cff09 Added simple non-replicated tests for system.merges. 2019-12-07 11:40:49 +03:00
alesapin
b9591a8bb4 Fix variable scope 2019-12-07 11:17:01 +03:00
Vladimir Chebotarev
05a05b5fb6 Fixed result_part_part of a mutation. 2019-12-07 11:10:08 +03:00
alesapin
5b828a6cbf Better test 2019-12-07 01:25:14 +03:00
alesapin
3881a85c39 Review fixes 2019-12-07 01:22:12 +03:00
alexey-milovidov
56b2ec8b4a
Merge pull request #7693 from millb/hashes_from_values_of_UUID_type
Created cityHash for decimal and UUID types.
2019-12-07 00:30:28 +03:00
alexey-milovidov
113ddb2588
Update FunctionsHashing.h 2019-12-06 22:21:22 +03:00
alexey-milovidov
1c1351d644
Update FunctionsHashing.h 2019-12-06 22:19:19 +03:00
alexey-milovidov
e0aa12717b
Update FunctionsHashing.h 2019-12-06 22:18:47 +03:00
alexey-milovidov
bef3a0d2d2
Merge pull request #8071 from azat/Connection-sendCancel-SIGSEGV
Avoid null dereference after "Unknown packet X from server"
2019-12-06 22:15:18 +03:00
alexey-milovidov
36203721de
Update Connection.cpp 2019-12-06 22:14:27 +03:00
millb
6799feaba6 Merge branch 'hashes_from_values_of_UUID_type' of github.com:millb/ClickHouse into hashes_from_values_of_UUID_type 2019-12-06 22:08:40 +03:00
millb
b13cd85613 Applied the required changes 2019-12-06 22:08:21 +03:00
Azat Khuzhin
e4209d6a3f Avoid null dereference after "Unknown packet X from server"
stracktrace:
  ...
  2  DB::WriteBuffer::nextIfAtEnd (this=0x0) at ../dbms/src/IO/WriteBuffer.h:66
  3  DB::writeVarUInt (ostr=..., x=3) at ../dbms/src/IO/VarInt.h:191
  4  DB::Connection::sendCancel (this=0x7f0b7f5e5610) at ../dbms/src/Client/Connection.cpp:444
  5  0x0000561738d0b565 in DB::MultiplexedConnections::sendCancel (this=0x7f0c9b0173e0) at ../dbms/src/Client/MultiplexedConnections.cpp:174
  6  0x00005617387d22df in DB::RemoteBlockInputStream::tryCancel (this=0x7f0cc45f9810, reason=<optimized out>) at /usr/include/c++/9/bits/unique_ptr.h:352
  7  0x00005617387d2a37 in DB::RemoteBlockInputStream::cancel (this=<optimized out>, kill=false) at ../dbms/src/DataStreams/RemoteBlockInputStream.cpp:121
  8  0x000056173891f10c in DB::ParallelInputsProcessor<DB::UnionBlockInputStream::Handler>::cancel (this=0x7f0c370ec168, kill=kill@entry=false)
  9  0x000056173892cfce in DB::UnionBlockInputStream::cancel (kill=false, this=<optimized out>) at ../dbms/src/DataStreams/UnionBlockInputStream.h:99
  10 DB::UnionBlockInputStream::Handler::onException (this=0x7f0c370ec160, exception=...) at ../dbms/src/DataStreams/UnionBlockInputStream.h:240
  11 DB::ParallelInputsProcessor<DB::UnionBlockInputStream::Handler>::thread (this=0x7f0c370ec168, thread_group=..., thread_num=<optimized out>)
      at ../dbms/src/DataStreams/ParallelInputsProcessor.h:217

And in onException frame there is:
  (gdb) p ((DB::Exception *)exception._M_exception_object)._msg._M_dataplus._M_p
  $6 = (...) 0x7f0c9b1e7a40 "Unknown packet 9 from server HOSTNAME:PORT"

And on "Unknown packet" there is disconnect() before, see default in
switch statement at Connection::receivePacket().
2019-12-06 21:55:17 +03:00
Mikhail Korotov
688ca7bfde performance test added 2019-12-06 21:10:03 +03:00
Mikhail Korotov
f63fe65e53 Simple tests added 2019-12-06 20:23:41 +03:00
Mikhail Korotov
3528555174
Update FunctionsHashing.h 2019-12-06 19:33:37 +03:00
Amos Bird
971770a040
Interpose malloc symbols entirely. 2019-12-07 00:32:00 +08:00
Mikhail Korotov
5a1ad17736
Update FunctionsHashing.h 2019-12-06 19:30:46 +03:00
millb
c801845185 Applied the required changes 2019-12-06 19:27:45 +03:00
millb
e3426e39e8 Fixed bugs 2019-12-06 18:43:50 +03:00
Vxider
47f8d9713a build fix 2019-12-06 23:35:23 +08:00
millb
41008c9cca Merge branch 'master' into hashes_from_values_of_UUID_type 2019-12-06 18:22:06 +03:00
millb
56c7e53bdc Changes applied 2019-12-06 18:21:58 +03:00
alexey-milovidov
3d279499d0
Merge pull request #7632 from hczhcz/patch-2
Allow relative user_files_path
2019-12-06 17:44:18 +03:00
robot-clickhouse
6d56509109 Auto version update to [19.19.1.1] [54430] 2019-12-06 17:22:00 +03:00
robot-clickhouse
114db61c84 Auto version update to [19.18.1.1805] [54429] 2019-12-06 17:21:25 +03:00
Nikolai Kochetov
a73975d6a3
Merge pull request #8063 from Akazz/tests/better_server_pid_detection
Improved getting ClickHouse server pid in clickhouse-test
2019-12-06 16:26:47 +03:00
Vitaly Baranov
8bd9709d1d
Merge pull request #8044 from vitlibar/simplify-format-of-header-of-distributed-send
Simplify format of the header of data sent to a shard in a distributed query.
2019-12-06 15:46:00 +03:00
Mikhail Filimonov
4e4957e052 returning allowNext() to the proper position 2019-12-06 12:22:36 +01:00
Alexander Kazakov
faedac0b95 Rewrite command line for getting server pid 2019-12-06 13:58:46 +03:00
Nikita Mikhaylov
34d20a0ef4
updating test after resolving conflicts 2019-12-06 13:17:51 +03:00
Nikita Mikhaylov
6fc5248a27
Merge branch 'master' into limit_with_ties 2019-12-06 13:16:54 +03:00
alesapin
de6cd490ef
Merge pull request #8037 from vitlibar/system-reload-dictionary-causes-complete-reloading
SYSTEM RELOAD DICTIONARY reloads a dictionary completely
2019-12-06 12:55:41 +03:00
Yuriy
5237e3c059 better exception text 2019-12-06 04:42:12 +03:00
Yuriy
6c8e2d8b85 fixed getting double SHA1 in mysql_native_password auth plugin 2019-12-06 04:35:49 +03:00
Yuriy
e91d4722a4 fixed occasional federated server test failures 2019-12-06 04:35:49 +03:00
Vitaly Baranov
2133492598
Merge pull request #7257 from vitlibar/RBAC-2
RBAC-2
2019-12-06 03:19:39 +03:00
Mikhail Filimonov
7d760a964d Fix for timestamp & style 2019-12-05 22:21:15 +01:00
Nikita Mikhaylov
46478db2f8 Merge branch 'master' of github.com:ClickHouse/ClickHouse 2019-12-05 22:09:15 +03:00
Nikita Mikhaylov
88027947a1
update test after resolving conflicts 2019-12-05 21:59:30 +03:00
Nikita Mikhaylov
4946409a78
Merge branch 'master' into limit_with_ties 2019-12-05 21:58:47 +03:00
Nikita Mikhaylov
de2d996063
Merge pull request #7786 from nikitamikhaylov/incorrect_count
Incorrect count() with condition query result for SummingMergeTree.
2019-12-05 21:56:54 +03:00
Nikita Mikhaylov
5e60e0661f
delete useless reference 2019-12-05 21:54:18 +03:00
Nikita Mikhaylov
826a675974
delete useless reference 2019-12-05 21:53:44 +03:00
Nikita Mikhaylov
7783475aaa
delete useless test 2019-12-05 21:53:26 +03:00
alesapin
6afafef86c
Merge pull request #8047 from ClickHouse/fix_check_query_again
Fix bug in checkDataPart
2019-12-05 21:31:36 +03:00
Vitaly Baranov
6306e2ab91 Add DCL to manage quotas. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
8035af3a79 Make Field::getScaleMultiplier() inline to allow using FieldVisitorConvertToNumber
in the "clickhouse_parsers" library.
2019-12-05 21:03:57 +03:00
Vitaly Baranov
3e6619c076 Move IntervalKind-related functions to a separate file. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
ae29628779 Add an integration test for quotas. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
38fa1af5ca Disable quota consumptions for the system queries and for selecting
from the `system.quota` and `system.quotas` tables.
2019-12-05 21:03:57 +03:00
Vitaly Baranov
d9b1a733fc Add table system.quotas. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
55a05e5643 Add functions currentQuota() and currentQuotaKey(). 2019-12-05 21:03:57 +03:00
Vitaly Baranov
0e21673271 Rework Quota based on IAccessEntity. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
c733e5b50b Add functions for writing std::chrono to string. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
7db6c60bb1 Add AccessControlManager and an interface for the storage. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
44f3ab5f96 Extend typeid_cast() for shared_ptr. 2019-12-05 21:03:57 +03:00
Vitaly Baranov
4d784d6f44 Add test. 2019-12-05 20:07:33 +03:00
Vitaly Baranov
9b44848179 SYSTEM RELOAD DICTIONARY now reloads a dictionary with update_field completely. 2019-12-05 19:45:05 +03:00
alesapin
772bb0b70b Fix collation locales 2019-12-05 18:35:09 +03:00
Nikita Mikhaylov
4f74974492 fixed warning unique_lock 2019-12-05 17:34:35 +03:00
alesapin
227d0ba9d6 Add one more test 2019-12-05 15:39:02 +03:00
alesapin
cd43debd79 Test with non adaptive parts 2019-12-05 15:18:18 +03:00
alesapin
ee46a73d25 Fix bug in checkDataPart when last granule has same number of rows as in .mrk file 2019-12-05 15:01:36 +03:00
chertus
852e891499 better comment 2019-12-05 15:01:34 +03:00
Nikolai Kochetov
26e415736a
Merge pull request #7665 from 4ertus2/joins
New ANY, SEMI, ANTI JOIN (HashJoin only)
2019-12-05 14:38:20 +03:00
Nikolai Kochetov
86ff01d3aa
Merge pull request #7988 from ClickHouse/processors-4.4
Better updated ports check in processors
2019-12-05 13:54:40 +03:00
Vitaly Baranov
133675a86a Simplify format of the header of data sending to a shard in a distributed query. 2019-12-05 13:34:25 +03:00
Mikhail Korotov
88e37020e0 JSONCompactEachRow and JSONCompactEachRowWithNamesAndTypes (#7841)
* Research commit

* Created Output EachRow Format

* Fixed bugs

* Created output format JSONCompactEachRowWithNamesAndTypes without totals

* Fixed bugs

* Fixed bugs

* Totals for JSONCompactEachRowWithNamesAndTypes

* Deleted needless debug

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Working commit

* Tests added

* Input Format for JSONCompactEachRow

* Fixed bugs for JSONCompactEachRow Input format

* Fixed bugs for JSONCompactEachRowRowInputFormat.cpp

* JSONCompactEachRow and JSONCompactEachRowWithNamesAndTypes united

* Created input format for both formats

* fixed bugs

* fixed bugs

* Working commit

* Working commit

* Working commit

* Working commit

* tests

* Working commit

* Final tests

* Performance tests added
2019-12-05 13:13:40 +03:00
Vladimir Chebotarev
73b0315b2f Added information about lld to instruction to sanitizers. 2019-12-05 13:08:34 +03:00
Vladimir Chebotarev
b9db05e1fd Revert "Added -D LINKER_NAME=lld to instruction to sanitizers."
This reverts commit c5a30d39a0.
2019-12-05 13:04:53 +03:00
Vladimir Chebotarev
60077e2311 Revert "Minor typo was fixed."
This reverts commit e436bf140c.
2019-12-05 13:04:47 +03:00
Nikita Mikhaylov
a3f3a333e2 better test 2019-12-05 12:55:06 +03:00
Nikita Mikhaylov
b6413d4a04 better 2019-12-05 12:52:49 +03:00
Nikita Mikhaylov
9d005d1565 true changes 2019-12-05 12:50:42 +03:00
Vladimir Chebotarev
7c7562987d Removed is_move from system.merges. 2019-12-05 12:31:45 +03:00
hcz
8a464995e7 Fix 2019-12-05 17:22:00 +08:00
Vladimir Chebotarev
3c35b3db60 Removed localtime from HTTPDictionarySource::getUpdateFieldAndDate(). 2019-12-05 12:18:51 +03:00
Vitaly Baranov
2cc78413ed
Merge pull request #7914 from azat/dist-send-extra-checksum
Add checksum for extra info/query in distributed sends
2019-12-05 11:43:08 +03:00
alesapin
a524e82a7f
Merge pull request #8029 from ClickHouse/fix_dict_partially_update_failover
Fix external dictionaries failover, when they have invalidate_query.
2019-12-05 11:12:17 +03:00
Yuriy Baranov
1df4250b2f
Update MySQLHandler.cpp 2019-12-05 04:52:48 +03:00
Yuriy Baranov
67d72f35b9
Update Authentication.cpp 2019-12-05 03:35:52 +03:00
Yuriy
9a222c6a2a compare with proper variable 2019-12-05 03:23:12 +03:00
Yuriy
4b170ae769 fixed compilation error 2019-12-05 03:19:36 +03:00