thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-16 11:22:12 +00:00
Code Issues Packages Projects Releases Wiki Activity
103,548 Commits 9,338 Branches 1,783 Tags 2.1 GiB
6b6504f0d1
Commit Graph

4741 Commits

Author SHA1 Message Date
serxa
ea17b30358 Merge branch 'storage-system-moves' of github.com:ClickHouse/ClickHouse into storage-system-moves 2022-11-07 20:33:31 +00:00
serxa
59408ebf57 fill more fields 2022-11-07 20:33:25 +00:00
Sergei Trifonov
6d3b96ee42
Merge branch 'master' into storage-system-moves 2022-11-07 21:31:27 +01:00
alesapin
257e766e0e Trying to fix two flaky tests 2022-11-07 20:49:41 +01:00
Alexander Tokmakov
9210e586d2 fix 2022-11-07 20:27:18 +01:00
Alexander Tokmakov
b8174a63a8 Merge branch 'master' into fix_intersecting_parts2 2022-11-07 20:26:36 +01:00
Kruglov Pavel
48163ff9c2
Merge pull request #42938 from amosbird/issue_42771 
Fix NOT_FOUND_COLUMN_IN_BLOCK in some rare case
 2022-11-07 13:10:12 +01:00
Duc Canh Le
bd2bd7149d fix typo 2022-11-07 18:22:50 +08:00
Duc Canh Le
f7e65ebd72 make comments more clear 2022-11-07 16:25:36 +08:00
Robert Schulze
cdaf0becfe
Merge branch 'master' into bitcast 2022-11-07 09:24:52 +01:00
Robert Schulze
f3f50530d1
Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-11-07 09:14:02 +01:00
Duc Canh Le
69d6d42443 NOT LIKE only work for 'prefix%' 2022-11-06 15:26:19 +08:00
zhongyuankai
ef6065b331 fix test 2022-11-06 13:40:26 +08:00
Igor Nikonov
e94b9cd003 Fixes 
+ enable retries in integration test
+ typo in fault injection traces
 2022-11-05 22:28:32 +00:00
Robert Schulze
9c066e964d
Less use of CH-specific bit_cast() 
Converted usage of CH-custom bit_cast to std::bit_cast if possible, i.e.
when
  sizeof(From) == sizeof(To).
(The CH-custom bit_cast is able to deal with sizeof(From) != sizeof(To).)

Motivation for this came from #42847 where it is not clear how the
internal bit_cast should behave on big endian systems, so we better
avoid that situation as much as possible.
 2022-11-04 15:52:48 +00:00
Amos Bird
d901ead1bc
Done 2022-11-04 17:26:44 +08:00
zhongyuankai
049a593272 Merge branch 'master' into optimze_ttl_merge 2022-11-04 17:22:38 +08:00
zhongyuankai
e773eb2fd1 batter 2022-11-04 17:19:34 +08:00
Azat Khuzhin
7032b2b98a Attach thread pool for loading parts to the query 
Detach should be done via CurrentThread::defaultThreadDeleter()

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-11-04 09:06:12 +01:00
Azat Khuzhin
cdd09fd72a Improve messages for loading data parts (add part type) 
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-11-04 09:05:06 +01:00
Amos Bird
7186898ffa
Experiment 2022-11-04 00:29:17 +08:00
Antonio Andelic
66ffdda973
Merge branch 'master' into optimize-entire-partition 2022-11-03 09:52:13 +01:00
Alexander Tokmakov
e67d05604c Merge branch 'master' into fix_intersecting_parts2 2022-11-02 19:30:27 +01:00
Igor Nikonov
9a315b7899 Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry 2022-11-02 15:32:54 +00:00
Alexander Tokmakov
00c9e50ee3 fix race between INSERT and ALTER PARTITION 2022-11-02 16:25:26 +01:00
Alexander Tokmakov
acbad99b24 remove abandonable_lock part 2 2022-11-02 14:28:49 +01:00
Antonio Andelic
c4b717b343
Update src/Storages/MergeTree/MergeTreeDataMergerMutator.cpp 
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
 2022-11-02 08:24:54 +01:00
Duc Canh Le
ec382d7903 add comment 2022-11-02 09:50:41 +08:00
Duc Canh Le
c6598dc66d
Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-11-02 09:42:01 +08:00
Alexander Tokmakov
4f50a999bb remove abandonable_lock part 1 2022-11-01 21:35:25 +01:00
Igor Nikonov
e76c3c381f Better handling tables in read-only mode during insert 
+ throw immediately if table has no metadata in zk
+ stop retries in case of shutdown
+ check if table is readonly at the begining of every retry
 2022-11-01 18:47:51 +00:00
Anton Popov
88674ef964
Merge pull request #42794 from CurtizJ/better-code-in-check-part 
Slightly better code with projections
 2022-11-01 16:05:27 +01:00
zhongyuankai
c1e2b2af74 Optimize TTL merge, completely expired parts can be removed in time 2022-11-01 22:58:15 +08:00
Anton Popov
876dca48da
Merge pull request #36969 from CurtizJ/dynamic-columns-14 
Support `Object` type inside other types
 2022-11-01 15:20:02 +01:00
Duc Canh Le
07d9720ed5
Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-11-01 22:16:09 +08:00
Maksim Kita
fe48a1ce7e
Merge pull request #42681 from kitaisreal/merge-tree-indexes-use-actions-dag 
MergeTree indexes use ActionsDAG
 2022-11-01 13:55:17 +03:00
Duc Canh Le
3545db0a6c
Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-11-01 16:54:26 +08:00
Yakov Olkhovskiy
bab0e06e3d
Merge pull request #42458 from Clark0/match-func-use-index 
match function can use index if it's a condition on string prefix #37333
 2022-10-31 17:33:58 -04:00
Igor Nikonov
9cc64a0fcc Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry 2022-10-31 18:21:21 +00:00
Igor Nikonov
2d5050ea66 Fix review comments 2022-10-31 18:20:58 +00:00
Anton Popov
2ae3cfa9e0
Merge branch 'master' into dynamic-columns-14 2022-10-31 16:15:19 +01:00
Alexander Tokmakov
599ccb9939
Update MergeTreeData.h 2022-10-31 16:18:17 +03:00
Alexander Tokmakov
b2b9479afa
Update src/Storages/MergeTree/MergeTreeData.h 
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
 2022-10-31 16:15:35 +03:00
Maksim Kita
bca22ec5f5 Fixed code review issues 2022-10-31 12:30:00 +01:00
Maksim Kita
115fcaffc5 Fixed tests 2022-10-31 11:30:56 +01:00
Duc Canh Le
d309e8793a
Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-10-31 15:13:39 +08:00
Alexander Tokmakov
f53df7870c fix race between drop and failed insert 2022-10-30 17:59:47 +01:00
Alexander Tokmakov
c68ab231f9 fix accessing part in Deleting state 2022-10-30 17:30:51 +01:00
FArthur-cmd
607b81989d fix build 2022-10-30 14:57:10 +00:00
Anton Popov
8de75bf29c better code with projections 2022-10-29 14:39:59 +00:00
clarkcaoliu
ca5dbe88db match function can use index if prefix 2022-10-29 18:25:29 +08:00
Filatenkov Artur
21c024b043
Merge branch 'master' into annoy_cosine 2022-10-28 20:15:53 +03:00
FArthur-cmd
f187d4e1d4 add cosine distance for annoy and fix docs for cosineDistance 2022-10-28 17:03:35 +00:00
Igor Nikonov
d09deaf10f Fix style check 2022-10-28 15:17:05 +00:00
Igor Nikonov
937dd44399 Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry 2022-10-28 15:09:23 +00:00
Igor Nikonov
c53b96a11c Add more comments 2022-10-28 15:09:01 +00:00
Alexey Milovidov
f64e632707
Merge pull request #42469 from amosbird/issue_42456 
Fix misbehavior of key analysis
 2022-10-28 16:18:00 +02:00
Antonio Andelic
5fae8b0cc9 Merge branch 'master' into optimize-entire-partition 2022-10-28 11:44:10 +00:00
Sergei Trifonov
836595c7ae
Merge branch 'master' into storage-system-moves 2022-10-28 11:39:38 +02:00
Duc Canh Le
848f5b5d65
Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-10-28 13:40:17 +08:00
Duc Canh Le
c080964391 correct 'notLike' in key condition 2022-10-28 13:39:01 +08:00
Duc Canh Le
69311bd5cd Merge branch 'master' into ch_canh_fix_prefix_not_like 2022-10-28 11:59:50 +08:00
Igor Nikonov
3682913172 Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry 2022-10-27 22:01:53 +00:00
Igor Nikonov
a601c166ad Add clean up for faults injected before zk request 
+ for multi-op request, it create responses in multi response
+ some polishing
 2022-10-27 21:35:13 +00:00
Anton Popov
7715afa595
Merge pull request #42618 from CurtizJ/refactor-data-part 
Try to save `IDataPartStorage` interface
 2022-10-27 22:20:44 +02:00
Igor Nikonov
f773436de5 Fix flaky test 2022-10-27 13:34:07 +00:00
Nikolai Kochetov
24e1aaf324
Merge pull request #42576 from ClickHouse/table-function-merge-invalid-where-type 
Invalid type in where for Merge table (logical error)
 2022-10-27 13:03:27 +02:00
Antonio Andelic
10aa7091ca
Merge pull request #42605 from ClickHouse/correctly-handle-prewhere-type 
Correctly handle non-native integers in PREWHERE
 2022-10-27 09:25:38 +02:00
Igor Nikonov
649e8d302c Sync with retiring branch igor/insert_zk_retries 2022-10-26 17:41:44 +00:00
Igor Nikonov
8435cba352 Merge remote-tracking branch 'origin/master' into igor/insert_zk_retries_retry 2022-10-26 17:35:47 +00:00
Maksim Kita
f04f663818 Fixed tests 2022-10-26 18:55:14 +02:00
Nikolai Kochetov
1520bcd53c Fix error code. 2022-10-26 15:50:10 +00:00
Anton Popov
ca4df62e37
Merge branch 'master' into refactor-data-part 2022-10-26 17:49:20 +02:00
Maksim Kita
1c17e9d454 Fixed tests 2022-10-26 15:54:37 +02:00
Nikolai Kochetov
db422fa903
Merge pull request #42410 from ClickHouse/fix-multi-arg-monotonicity 
Fix possible LOGICAL_ERROR in binary ariphmetics monotonicity.
 2022-10-26 14:11:23 +02:00
Kruglov Pavel
219553df8d
Merge pull request #42580 from hanfei1991/fei/limit_max_rows 
fix behaviour of max_rows_to_read for trival limit queries
 2022-10-26 14:09:59 +02:00
Maksim Kita
c47ca522f4 Fixed style check 2022-10-26 13:27:14 +02:00
Antonio Andelic
35a9672704 Merge branch 'master' into optimize-entire-partition 2022-10-26 11:09:25 +00:00
Maksim Kita
1b6293f6db MergeTree indexes use ActionsDAG 2022-10-26 12:44:37 +02:00
Antonio Andelic
97aaebfa18 Address PR comments 2022-10-26 10:06:56 +00:00
Antonio Andelic
979d180931
Merge branch 'master' into correctly-handle-prewhere-type 2022-10-26 11:13:16 +02:00
Azat Khuzhin
8db31beee6 Remove covered parts for fetched part 
Here is an example that I found on production, simplified.

Consider the following queue (nothing of this had been processed on this
replica):

- GET_PART all_0_0_0 (queue-0000000001)
- GET_PART all_1_1_0 (queue-0000000002)
...
- GET_PART all_0_1_1 (queue-0000000003)
- GET_PART all_2_2_0 (queue-0000000004)
...
- MERGE_PARTS from [all_0_1_1, all_2_2_0] to all_0_2_2 (queue-0000000005)

And now queue-0000000005 started to executing (either because
of reording, or because at that time GET_PART fails), and it
does not have any required parts, so it will fetch them, but
not all_0_0_0 and all_1_1_0, so this replica delay will set to
the time of min(queue-0000000001, queue-0000000002), while it
is not true, since it already have parts that covers those
parts.

and since MERGE_PARTS takes 30min, it increased the replica delay
eventually to 30min, for the time range of 30min, which is pretty huge.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-26 11:10:50 +03:00
Anton Popov
79889198b1 fix style check 2022-10-25 23:03:37 +00:00
Anton Popov
d8b09b430f add comments 2022-10-25 22:27:11 +00:00
Anton Popov
c4d4f2dbed better interface 2022-10-25 22:14:06 +00:00
Sergei Trifonov
34b43f8b4b
Merge branch 'master' into storage-system-moves 2022-10-25 22:56:45 +02:00
serxa
55a86bc2de Add active moves system table 2022-10-25 13:56:46 +00:00
Antonio Andelic
611c2e2bd7 Support for optimizing old parts for entire partition only 2022-10-25 13:40:18 +00:00
Anton Popov
c8199bc125
Merge branch 'master' into refactor-data-part 2022-10-25 14:31:05 +02:00
Raúl Marín
0016bc2b73
Improve the time to recover keeper connections (#42541) 
Co-authored-by: Nikita Mikhaylov <nikitamikhaylov@clickhouse.com>
Co-authored-by: robot-clickhouse <robot-clickhouse@clickhouse.com>
Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 2022-10-25 13:26:29 +02:00
Antonio Andelic
af0c54e055 Small fix 2022-10-25 11:13:41 +00:00
Antonio Andelic
451a50d9e9 Merge branch 'master' into correctly-handle-prewhere-type 2022-10-25 10:48:35 +00:00
Maksim Kita
06fe6f3c8b
Merge pull request #31796 from kitaisreal/identifier-resolver 
Added Analyzer
 2022-10-25 12:36:08 +03:00
Anton Popov
cbfa887e52 fix merge of projections 2022-10-24 23:51:57 +00:00
Anton Popov
f865b28da4 fix drop of MergeTree tables 2022-10-24 22:38:53 +00:00
Alexey Milovidov
9ee7131f67
Merge pull request #42423 from ClickHouse/optimize-partitions-in-background 
Optimize partitions in background
 2022-10-24 19:41:50 +02:00
Anton Popov
dcb7667808 share transaction for projections 2022-10-24 16:28:19 +00:00
Anton Popov
128fdd785e better interface 2022-10-24 14:44:22 +00:00
Antonio Andelic
5579d139eb Avoid crash with big int in prewhere 2022-10-24 08:37:52 +00:00
Maksim Kita
d083200d65 Fixed code review issues 2022-10-24 10:22:38 +02:00
Maksim Kita
ca93ee7479 Fixed tests 2022-10-24 10:22:20 +02:00
Maksim Kita
fed146e198 Added SAMPLE BY support. Added SAMPLE BY, FINAL support for JOINS. 2022-10-24 10:22:20 +02:00
Igor Nikonov
54013009d3 Code migration from #41734 to align diff and git blame. 
Initial implementation was different and it changed the entire
ReplicatedMergeTreeSink::commitPart() which change history provided by git blame.
Then RetriesControl.retryLoop() was introduced later which significantly reduces
the diff since it's like while() used before.
So, check outing the current version will keep more original history in
git blame, which is useful here
 2022-10-24 08:20:11 +00:00
Anton Popov
cf375c9732 better interface 2022-10-23 22:29:24 +00:00
Anton Popov
b40d9200d2 better semantic of constsness of DataPartStorage 2022-10-23 15:24:20 +00:00
Anton Popov
56e5daba0c remove DataPartStorageBuilder 2022-10-23 00:23:15 +00:00
Han Fei
2fc91fd338 fix behaviour of max_rows_to_read for trival limit queries 2022-10-22 18:27:24 +02:00
Amos Bird
f104dd08cd
Only fix LowCardinality for now 2022-10-22 15:47:13 +08:00
Azat Khuzhin
4e76629aaf Fixes for -Wshorten-64-to-32 
- lots of static_cast
- add safe_cast
- types adjustments
  - config
  - IStorage::read/watch
  - ...
- some TODO's (to convert types in future)

P.S. That was quite a journey...

v2: fixes after rebase
v3: fix conflicts after #42308 merged
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
 2022-10-21 13:25:19 +02:00
Antonio Andelic
3091d609fa
Merge branch 'master' into optimize-partitions-in-background 2022-10-21 11:01:41 +02:00
Alexander Tokmakov
5b03bbce2e
Merge pull request #41981 from ClickHouse/fixes_for_replicated_merge_tree2 
Some fixes for ReplicatedMergeTree
 2022-10-20 16:57:51 +03:00
Robert Schulze
469d6ad624
Merge pull request #42485 from ClickHouse/fix-bad_cast-in-annoy 
Fix bad_cast in Annoy index
 2022-10-20 15:27:58 +02:00
Alexander Tokmakov
d668a82829
Merge branch 'master' into improve_replica_recovery 2022-10-20 14:25:09 +03:00
Amos Bird
2499ab3b3a
Use convertFieldToType 2022-10-20 17:53:52 +08:00
Antonio Andelic
77eb353839
Merge pull request #42243 from ClickHouse/use-multiread-more 
Use MultiRead where possible
 2022-10-20 09:04:54 +02:00
Alexander Tokmakov
84ef32e33f Merge branch 'master' into improve_replica_recovery 2022-10-19 16:28:01 +02:00
Alexander Tokmakov
f958c155f3
Merge branch 'master' into fixes_for_replicated_merge_tree2 2022-10-19 17:25:24 +03:00
Robert Schulze
42f680849c
Fix bad_cast in Annoy index 
- Problem originally found by data type fuzzer
  https://s3.amazonaws.com/clickhouse-test-reports/42180/2f83d8790581dce0ffeec56c137b1d13160cfa7b/fuzzer_astfuzzermsan//report.html

- This commit restricts which data types are allowed for Annoy indexes
  (similar things are done for other index types).
 2022-10-19 13:40:39 +00:00
Antonio Andelic
05e6b94b54 Polishing 2022-10-19 12:59:28 +00:00
Antonio Andelic
e5408aac99 Simplify logic 2022-10-19 12:34:20 +00:00
Amos Bird
549597fe80
Fix misbehavior of key analysis. 
When key types cannot be inside Nullable, it can break key analysis. See
https://github.com/ClickHouse/ClickHouse/issues/42456.
 2022-10-19 12:15:27 +08:00
Alexander Tokmakov
1d9d753167 fix 2022-10-18 18:13:18 +02:00
Alexander Tokmakov
ea77ff9022 Merge branch 'master' into fixes_for_replicated_merge_tree2 2022-10-18 17:25:25 +02:00
Nikolai Kochetov
b109767dda Merge branch 'master' into fix-multi-arg-monotonicity 2022-10-18 14:47:33 +00:00
Kruglov Pavel
25e13bdd2f
Merge pull request #41107 from Avogar/improve-combinators 
Support all combinators combination in WindowTransform/arratReduce*/initializeAggregation/aggregate functions versioning
 2022-10-18 15:24:49 +02:00
Antonio Andelic
d105796c91 Merge branch 'master' into optimize-partitions-in-background 2022-10-18 12:24:03 +00:00
Antonio Andelic
e828dce331 Disable auto optimize by default 2022-10-18 12:11:23 +00:00
Tian Xinhui
45c6974f7d
Use alias for std::shared_ptr<MergeMutateSelectedEntry> (#42211) 
* use alias for MergeMutateSelectedEntry share ptr

* fix StorageMergeTree.cpp
 2022-10-18 13:35:34 +02:00
Antonio Andelic
06b2eeb5a7 Small changes to settings 2022-10-18 09:31:16 +00:00
Antonio Andelic
bd2522fdd0 Merge branch 'master' into optimize-partitions-in-background 2022-10-18 09:13:59 +00:00
Nikolai Kochetov
3d1ed2969a Fix possible LOGICAL_ERROR in binary ariphmetics monotonicity. Fix invalid evaluation of binary monotonic function in KeyCondition. 2022-10-17 18:21:03 +00:00
Alexander Tokmakov
57f6e27300 Merge branch 'master' into improve_replica_recovery 2022-10-17 18:37:31 +02:00
Nikolai Kochetov
c9aa6a655c
Merge pull request #42319 from ClickHouse/fix-alter-update-wrong-type 
Fix an invalid type of a column after attach and alter.
 2022-10-17 12:44:16 +02:00
Antonio Andelic
125501b36a Merge branch 'master' into use-multiread-more 2022-10-17 07:32:30 +00:00
avogar
52427e6028 Remove code duplication 2022-10-14 18:07:02 +00:00
Kruglov Pavel
ff11904850
Merge branch 'master' into improve-combinators 2022-10-14 17:19:31 +02:00
Nikolai Kochetov
b18c6fd8e6 Fix an invalid type of a column after attach and alter. 2022-10-14 14:52:26 +00:00
alesapin
fd718c0d00 Merge branch 'master' into disable_concurrent_parts_removal 2022-10-14 13:32:11 +02:00
alesapin
4e1a10fb34 better check 2022-10-14 13:32:08 +02:00
Alexey Milovidov
bbd1196a96
Update MergeTreeData.cpp 2022-10-12 00:57:02 +03:00
Antonio Andelic
5e6a7c1678 Use multiread where possible 2022-10-11 09:27:46 +00:00
Alexey Milovidov
56e59dd536
Merge branch 'master' into fix-projections 2022-10-11 02:24:12 +03:00
alesapin
f6b0dc168d Disable concurrent parts removal 2022-10-10 14:10:04 +02:00
alesapin
8a2ba6cd81
Add logging during merge tree startup (#42163) 2022-10-10 09:32:13 +02:00
Duc Canh Le
f823b9a177 add not like to atom map 2022-10-10 13:31:10 +08:00
Alexey Milovidov
e27dbf4369
Update MergeTreeDataSelectExecutor.cpp 2022-10-09 18:27:47 +03:00
Alexey Milovidov
cebc38fa6e Fix a bug with projections and aggregate_functions_null_for_empty setting 2022-10-09 05:30:25 +02:00
Alexey Milovidov
9ee6896916
Merge pull request #42002 from ClickHouse/relax-too-many-parts-threshold 
Relax "too many parts" threshold
 2022-10-08 20:17:01 +03:00
Alexey Milovidov
e4ac4a29a9 Fix error 2022-10-08 00:24:51 +02:00
Alexey Milovidov
a45f7c3023 Relax "too many parts" thresholds 2022-10-08 00:24:51 +02:00
Alexey Milovidov
169c505603 Relax "too many parts" thresholds 2022-10-08 00:24:51 +02:00
Alexander Tokmakov
4175f8cde6 abort instead of __builtin_unreachable in debug builds 2022-10-07 21:49:08 +02:00
Alexander Tokmakov
1a78e8a817 fix 2022-10-07 20:22:03 +02:00
Robert Schulze
cc24fcd6d5
Merge pull request #41873 from ClickHouse/generated-file-cleanup 
Consolidate CMake-generated config headers
 2022-10-06 14:31:03 +02:00
Raúl Marín
adbaaca2f5
QOL log improvements (#41947) 
* Uniformize disk reservation logs

* Remove log about destroying stuff that appears all the time

* More tweaks on disk reservation logs

* Reorder logs in hash join

* Remove log that provides little information

* Collapse part removal logs

Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
 2022-10-06 14:22:44 +02:00
Robert Schulze
78be400ac0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup 2022-10-06 12:22:43 +00:00
Anton Popov
aabec50988
Merge pull request #42040 from CurtizJ/async-inserts-log 
Add system table `asynchronous_insert_log`
 2022-10-06 13:14:41 +02:00
Vladimir C
3f24c904ad
Merge pull request #41842 from amosbird/index_analysis_1 2022-10-06 11:14:21 +02:00
Robert Schulze
da5a2e2db0
Merge remote-tracking branch 'origin/master' into generated-file-cleanup 
Physical merge conflicts:
- src/Common/ZooKeeper/ZooKeeperImpl.cpp
- src/Core/config_core.h.in
- src/Functions/FunctionsAES.h
- src/Functions/config_functions.h.in
- src/configure_config.cmake

Logical merge conflicts:
- Functions/tryDecrypt.cpp
 2022-10-06 08:43:25 +00:00
Anton Popov
190e1f6830
Merge branch 'master' into async-inserts-log 2022-10-06 01:59:27 +02:00
Anton Popov
f7cf35d1dd
Merge pull request #42072 from CurtizJ/fix-fuzzer-4 
Fix assertion in bloom filter index
 2022-10-05 16:38:13 +02:00
Anton Popov
02cdc20d5d
Merge pull request #40096 from CurtizJ/fuzz-table-definitions 
Add fuzzer for table definitions
 2022-10-05 14:53:48 +02:00
Anton Popov
2f423071f2 fix assertion in bloom filter index 2022-10-04 19:27:56 +00:00
Nikita Mikhaylov
2933a28a5d
Add log message and lower the retry timeout in MergeTreeRestartingThread (#42026) 2022-10-04 20:07:11 +02:00
Anton Popov
9a2cabd3a1
Merge branch 'master' into async-inserts-log 2022-10-04 15:10:50 +02:00
Anton Popov
8ca73eab03
Merge branch 'master' into fuzz-table-definitions 2022-10-04 15:10:31 +02:00
Kseniia Sumarokova
6d02fa3c5f
Merge pull request #42022 from kssenii/better-exception-merge-tree-data-load-parts 
More detailed exception message
 2022-10-04 11:20:35 +02:00
Anton Popov
148995894f add system table asynchronous_inserts_log 2022-10-03 21:35:55 +00:00
Anton Popov
5cb6357549 fix style check 2022-10-03 19:37:27 +00:00
Alexey Milovidov
c8872fe96d
Merge pull request #42001 from ClickHouse/part-thresholds-override-more-sane 
More sane behavior of part number thresholds override in query level settings
 2022-10-03 17:25:39 +03:00
Anton Popov
6e61cf92f5 Merge remote-tracking branch 'upstream/master' into HEAD 2022-10-03 13:16:57 +00:00
kssenii
0dc71e9883 More detailed exception message 2022-10-03 14:21:53 +02:00
Alexander Tokmakov
00914a174d
Merge pull request #41410 from ClickHouse/keeper-multiread 
Add MultiRead support in Keeper and internal ZK client
 2022-10-03 14:17:57 +03:00
Alexander Tokmakov
a2c29076d6 avoid detached broken part duplicates 2022-10-03 12:27:17 +02:00
Alexander Tokmakov
3f9c9c9a77 fix intersecting part if session expired during queue initialization 2022-10-03 12:27:17 +02:00
Alexander Tokmakov
7b5b7e4963
Merge pull request #41945 from ClickHouse/enable_more_s3_tests 
Enable some disabled S3 tests
 2022-10-03 13:25:50 +03:00
Robert Schulze
db5ef7b3cb
Merge branch 'master' into generated-file-cleanup 2022-10-02 23:13:18 +02:00
Alexey Milovidov
0da9ed8a18
Merge branch 'master' into part-thresholds-override-more-sane 2022-10-02 02:26:21 +03:00
Alexander Tokmakov
e40917a9c5 fix 2022-10-02 00:44:46 +02:00
Alexey Milovidov
7b71524109 More sane behavior of part number thresholds override in query level settings 2022-10-01 20:18:12 +02:00
Vitaly Baranov
7be9744bab Remove confusing warning when inserting with perform_ttl_move_on_insert=false. 2022-09-30 20:51:48 +02:00
alesapin
00bf90186a Better 2022-09-30 19:03:54 +02:00
alesapin
350ff96628 Fix potential race condition with broken parts 2022-09-30 19:01:06 +02:00
Vladimir C
895afdec45
Merge pull request #40893 from ClickHouse/vdimir/track-tmp-disk 2022-09-30 11:27:24 +02:00
Robert Schulze
cc92a2d174
Merge branch 'master' into generated-file-cleanup 2022-09-30 09:56:31 +02:00
alesapin
0097f15ee7
Merge pull request #41832 from ClickHouse/make_copy_instead_of_hardlink 
Use copy for some operations instead of hardlinks
 2022-09-29 17:12:08 +02:00
Alexander Tokmakov
4e422b8046
Merge pull request #41741 from ClickHouse/fix_intersecting_parts 
Fix intersecting parts
 2022-09-29 18:00:22 +03:00
Amos Bird
44eaa9583b
Merge branch 'master' into index_analysis_1 2022-09-29 20:25:03 +08:00
vdimir
c0898ce289
Use abstraction for temporary data on disk in Sort and Aggregation 2022-09-29 09:51:41 +00:00
Antonio Andelic
fcc54104a4 Define methods for multi read requests 2022-09-29 09:19:47 +00:00
Antonio Andelic
3109ce51c6 Merge branch 'master' into keeper-multiread 2022-09-29 06:50:49 +00:00
Anton Popov
34bc16cd5b avoid more useless errors 2022-09-28 15:55:39 +00:00
alesapin
905d4585ac
Merge branch 'master' into make_copy_instead_of_hardlink 2022-09-28 16:47:45 +02:00
alesapin
072c19ba96
Merge pull request #41838 from tbsal/tbsal_34798 
Improve feedback when replacing partition with different primary key
 2022-09-28 15:33:11 +02:00
Robert Schulze
fd86829824
Consolidate config_core.h into config.h 
Less duplication, less confusion ...
 2022-09-28 13:31:57 +00:00
Kruglov Pavel
6340369c2a
Merge branch 'master' into improve-combinators 2022-09-28 14:55:30 +02:00
Robert Schulze
78fc36ca49
Generate config.h into ${CONFIG_INCLUDE_PATH} 
This makes the target location consistent with other auto-generated
files like config_formats.h, config_core.h, and config_functions.h and
simplifies the build of clickhouse_common.
 2022-09-28 12:48:26 +00:00
alesapin
2eef384807 Add comments and test 2022-09-28 13:09:48 +02:00
Alexey Milovidov
1653482406
Merge pull request #41823 from ClickHouse/trying_to_fix_compressed_marks 
Fix compressed marks read for compact parts
 2022-09-28 14:06:56 +03:00
alesapin
9e77d520d4 Merge branch 'master' into make_copy_instead_of_hardlink 2022-09-28 12:10:00 +02:00
Kseniia Sumarokova
b0a362e403
Merge pull request #41839 from ClickHouse/kssenii-patch-5 
Remove unused variable in registerStorageMergeTree.cpp
 2022-09-28 11:58:01 +02:00
Alexey Milovidov
e5ffd74a56
Merge branch 'master' into trying_to_fix_compressed_marks 2022-09-28 02:30:10 +03:00
Alexey Milovidov
12dc33f4fd
Merge branch 'master' into nv/fix-mutate-fetch 2022-09-28 01:28:19 +03:00
Kseniia Sumarokova
85b44c909a
Update MergeTreeDataPartCompact.cpp 2022-09-27 18:16:58 +02:00
Salvatore Mesoraca
fc73b74379 Improve feedback when replacing partition with different primary key 2022-09-27 16:31:47 +02:00
Amos Bird
c39c138416
Better index analysis with NULL literal 2022-09-27 22:00:50 +08:00
alesapin
a20a9242a1 Fix order of arguments 2022-09-27 15:50:25 +02:00
Kseniia Sumarokova
2f237a8a2c
Update registerStorageMergeTree.cpp 2022-09-27 15:30:18 +02:00
alesapin
695133cc5b Better mutations 2022-09-27 15:23:02 +02:00
alesapin
d4d4f92976 Use copy for some operations instead of hardlinks 2022-09-27 14:38:13 +02:00
Antonio Andelic
265c8b3d26 Merge branch 'master' into keeper-multiread 2022-09-27 12:37:22 +00:00
kssenii
ce422052b0 Fix CANNOT_READ_ALL_DATA for compact parts in case compressed_marks=1 2022-09-27 14:27:56 +02:00
Alexander Tokmakov
19062e9d97
Update src/Storages/MergeTree/ReplicatedMergeTreeAttachThread.cpp 
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
 2022-09-27 14:26:45 +03:00
Alexander Tokmakov
0f6a44efef fix missing metadata_version for old tables 2022-09-26 20:11:30 +02:00
Alexander Tokmakov
9501f88f8c
Merge branch 'master' into fix_intersecting_parts 2022-09-26 19:53:59 +03:00
Alexander Tokmakov
49983dafeb fix 2022-09-26 17:13:10 +02:00
alesapin
31f6636a47 Fix endless remove 2022-09-26 16:33:25 +02:00
Kruglov Pavel
3dc54272ed
Merge branch 'master' into improve-combinators 2022-09-26 13:03:32 +02:00
Antonio Andelic
97385ca861 Format 2022-09-26 09:33:50 +00:00
Antonio Andelic
cc3719e463 Use multiread 2022-09-26 09:07:34 +00:00
alesapin
5852df7f65
Merge branch 'master' into fix_part_removal_retries 2022-09-24 17:06:32 +02:00
alesapin
ce2c2b5310 Merge branch 'master' into fix_intersecting_parts 2022-09-24 17:00:54 +02:00
alesapin
34d9794ab7
Merge pull request #41653 from ClickHouse/investigating_more_bugs 
Add very explicit logging on disk choice for fetch
 2022-09-24 16:15:02 +02:00
Alexander Tokmakov
a2b8c4926e fix intersecting parts 2022-09-23 20:51:44 +02:00
Alexander Tokmakov
2c16232b02 fix part removal retries 2022-09-23 14:39:05 +02:00
alesapin
148f018eae Fix style: 2022-09-23 14:32:19 +02:00
alesapin
dff61267b4 More explicit logs 2022-09-23 14:31:05 +02:00
Alexander Tokmakov
981c1e95c6
Update MutateTask.cpp 2022-09-22 18:51:27 +03:00
Nikolai Kochetov
63e757a659
Merge pull request #36379 from amosbird/projection-compatibility-fix 
Make minmax_count projection backward compatible
 2022-09-22 14:15:35 +02:00
Nikolai Kochetov
3b63719ece
Merge pull request #41619 from den-crane/patch-50 
increase default max_suspicious_broken_parts to 100
 2022-09-22 13:25:22 +02:00
alesapin
ca410b7a0b
Merge pull request #41147 from ClickHouse/enable_projections_and_zero_copy 
Enable projections and zero copy replication
 2022-09-22 13:05:09 +02:00
alesapin
a95e291474
Merge branch 'master' into investigating_more_bugs 2022-09-22 12:51:55 +02:00
alesapin
57be648984
Merge pull request #41649 from ClickHouse/supress_one_more_key_doesnt_exists 
Release AWS SDK log level + replace one exception
 2022-09-22 12:38:03 +02:00
Alexey Milovidov
2a75e025f2
Merge pull request #40715 from ClickHouse/compress-marks 
Merging #37693: Compress marks and primary key
 2022-09-22 07:30:34 +03:00
Alexey Milovidov
45afacdae4
Merge pull request #41186 from ClickHouse/fix-three-fourth-of-trash 
Fix more than half of the trash
 2022-09-22 07:28:26 +03:00
alesapin
9c433c14d1 Add very explicit logging on disk choice for fetch 2022-09-21 21:33:28 +02:00
alesapin
499f678112 Release AWS SDK log level + replace one exception 2022-09-21 19:56:42 +02:00
Nikita Taranov
100c055510
Prefetching in aggregation (#39304) 
* impl

* stash

* clean up

* do not apply when HT is small

* make branch static

* also in merge

* do not hardcode look ahead value

* fix

* apply to methods with cheap key calculation

* more tests

* silence tidy

* fix build

* support HashMethodKeysFixed

* apply during merge only for cheap

* stash

* fixes

* rename method

* add feature flag

* cache prefetch threshold value

* fix

* fix

* Update HashMap.h

* fix typo

* 256KB as default l2 size

Co-authored-by: Alexey Milovidov <milovidov@clickhouse.com>
 2022-09-21 18:59:07 +02:00
Denny Crane
75cf53c06e
increase default max_suspicious_broken_parts to 100 2022-09-21 11:10:19 -03:00
Robert Schulze
186d4e4140
Merge pull request #40818 from Vector-Similarity-Search-for-ClickHouse/annoy 
Add annoy index
 2022-09-21 13:42:43 +02:00
Nicolae Vartolomei
e93a78faee Proper comment for bad code 2022-09-20 19:56:14 +00:00
Nicolae Vartolomei
3d6fcf4ae5 Explain bad code 2022-09-20 19:46:07 +00:00
Nicolae Vartolomei
372545b306 Remove leftover 2022-09-20 19:28:40 +00:00
Nicolae Vartolomei
45f1f572f0 Get rid of scary setting for testing fetching byte identical parts 2022-09-20 19:27:49 +00:00
Nicolae Vartolomei
90666a43a8 CLICKHOUSE-2153: Move new_data_part shared pointer to allow Outdated part to be deleted immediately on mutation failure 2022-09-20 18:23:19 +00:00
alesapin
4bd667c6b7 Drop all WALs 2022-09-20 18:28:15 +02:00
Filatenkov Artur
2139d5be17
Merge branch 'master' into annoy 2022-09-20 15:28:08 +03:00
alesapin
8ba74d8655 Fix bugs found by CI 2022-09-20 14:00:57 +02:00
alesapin
e9d31977f3
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-20 12:25:10 +02:00
Filatenkov Artur
be8221fae1
Correct work with negative distance 2022-09-20 09:48:33 +03:00
Alexey Milovidov
7c299dc561
Update src/Storages/MergeTree/MergeTreeDataMergerMutator.cpp 
Co-authored-by: Robert Schulze <robert@clickhouse.com>
 2022-09-20 05:16:12 +03:00
Alexey Milovidov
e7525da88f
Update src/Storages/MergeTree/MergeTreePartsMover.cpp 
Co-authored-by: Robert Schulze <robert@clickhouse.com>
 2022-09-20 05:16:02 +03:00
Filatenkov Artur
3598a7e680
Fix query type information 2022-09-20 01:03:55 +03:00
alesapin
ee24b21aaf Fix revert order 2022-09-19 21:19:36 +02:00
alesapin
f67e23183f Fix parts removal on drop + add unrelated test 2022-09-19 20:19:49 +02:00
Amos Bird
1a21f0a0f0
normalize ast for replicated metadata 2022-09-19 22:06:41 +08:00
Amos Bird
0bb70d4378
Make minmax_count projection backward compatible 2022-09-19 22:06:40 +08:00
Kruglov Pavel
47f6f09ce0
Merge branch 'master' into improve-combinators 2022-09-19 14:31:12 +02:00
Alexey Milovidov
45b6052b20 Merge branch 'master' into compress-marks 2022-09-19 10:57:05 +02:00
Alexey Milovidov
b87d12494e Fix build 2022-09-19 08:53:20 +02:00
Alexey Milovidov
ab4db2d0c4 Fix 5/6 of trash 2022-09-19 08:50:53 +02:00
Alexey Milovidov
d4b9fe41be
Merge pull request #41457 from ClickHouse/remove-trash-5 
Remove trash from Field
 2022-09-19 06:36:48 +03:00
alesapin
a5a9d89fb9
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-18 17:20:08 +02:00
alesapin
560bc2bc22
Merge pull request #41386 from ClickHouse/fix_redundant_fetch 
Fix redundant fetch in zero copy replication
 2022-09-18 15:57:27 +02:00
Alexey Milovidov
791de6592b Remove trash from Field 2022-09-18 05:16:08 +02:00
Alexey Milovidov
f4a48cd4d6 Remove cruft 2022-09-17 22:16:31 +02:00
alesapin
33216dedf9
Merge pull request #41323 from ClickHouse/remove_bad_exception 
Fix parts removal in case of connection loss
 2022-09-17 19:14:53 +02:00
alesapin
dcb1586977 Add comment 2022-09-17 19:11:58 +02:00
alesapin
db30a3041e
Update src/Storages/MergeTree/MutateFromLogEntryTask.cpp 
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
 2022-09-17 19:10:23 +02:00
avogar
0101cc2e56 Support complex combinators in window transform, arrayReduce*, initializeAggregation and Aggregate functons versionning 2022-09-16 19:07:36 +00:00
Nikolai Kochetov
16f78eb804
Merge pull request #41281 from ClickHouse/fix-key-condition-with-actions-dag-literal-name 
Fix wrong literal name in KeyCondition using ActionsDAG.
 2022-09-16 16:06:38 +02:00
alesapin
b4d2d217f4
Merge branch 'master' into enable_projections_and_zero_copy 2022-09-16 13:53:17 +02:00
alesapin
06ccdb1ecf Fix nasty bug 2022-09-16 13:49:39 +02:00
alesapin
af259a2a68
Update src/Storages/MergeTree/MergeFromLogEntryTask.cpp 
Co-authored-by: Alexander Tokmakov <tavplubix@clickhouse.com>
 2022-09-16 11:50:07 +02:00
Alexander Tokmakov
8301f5758b Update IMergeTreeDataPart.cpp 2022-09-15 21:32:57 +02:00
alesapin
be81d653e1 Fix comment 2022-09-15 18:56:16 +02:00
alesapin
b098c1be36 Fix data duplication in zero copy replication 2022-09-15 18:54:27 +02:00
alesapin
7570c5cf67 Remove recursive without blobs 2022-09-15 15:31:19 +02:00
alesapin
c585ed47fc Forget to remove 2022-09-15 15:15:28 +02:00
alesapin
e127c8b4a9 Add kringe 2022-09-15 14:49:31 +02:00
alesapin
c04f7afb2a Delete kringe 2022-09-15 14:48:59 +02:00
alesapin
63213465ef Fix comment 2022-09-14 17:28:12 +02:00
alesapin
ad279940d6 Trying print less scary messages in case No such key for outdated parts 2022-09-14 17:25:58 +02:00
alesapin
d8c14ebcf6 Fixup 2022-09-14 16:44:40 +02:00
alesapin
9d3ab9a7f7 Merge branch 'master' into enable_projections_and_zero_copy 2022-09-14 15:16:16 +02:00
Anton Popov
3623807527
Merge pull request #41290 from CurtizJ/dynamic-columns-20 
Fix `ALTER ADD COLUMN`  with columns of type `Object`
 2022-09-14 14:15:29 +02:00
Vladimir C
00d0b37cd0
Merge pull request #41263 from ClickHouse/vdimir/quorum-log-msg-fix 2022-09-14 10:54:21 +02:00
Anton Popov
ee54451741 fix adding of columns of type Object 2022-09-13 22:43:59 +00:00
Nikolai Kochetov
3f0bc94d25 Comment. 2022-09-13 18:50:01 +00:00
Nikolai Kochetov
66d9d92de4 Fix wrong literal name in KeyCondition using ActionsDAG. 2022-09-13 18:47:29 +00:00
alesapin
2cecf9e55f Fix bug 2022-09-13 18:30:55 +02:00
vdimir
f2acb53887
Better log message for replicas number in StorageReplicatedMerge 2022-09-13 13:49:51 +00:00
alesapin
7a1ae1f316 Fix for stateless test 2022-09-13 15:10:49 +02:00
zhongyuankai
f36d70e9dd
Merge branch 'master' into compress_marks_and_primary_key 2022-09-13 20:05:39 +08:00
Alexander Tokmakov
4d146b05a9
Merge pull request #38262 from PolyProgrammist/fix-ordinary-system-unfreeze 
Fix SYSTEM UNFREEZE for ordinary database
 2022-09-13 14:55:11 +03:00
alesapin
cc9f6d47be Merge branch 'master' into enable_projections_and_zero_copy 2022-09-13 12:34:22 +02:00
Kseniia Sumarokova
b2c9c04c7b
Merge pull request #40821 from kssenii/improve-marks-cache-loading 
Allow to load marks in threadpool in advance
 2022-09-13 12:31:58 +02:00
Kseniia Sumarokova
651d850652
Merge pull request #41230 from kssenii/minor-change 
minor change in MergeTreeDataPartCompact
 2022-09-13 12:23:18 +02:00
zhongyuankai
75c0854a78 fix test 2022-09-13 11:18:25 +08:00
zhongyuankai
1477bb132f
Merge branch 'master' into compress_marks_and_primary_key 2022-09-13 11:05:57 +08:00