Commit Graph

337 Commits

Author SHA1 Message Date
Alexey Milovidov
fc27be314b Avoid temporary nullptr references [#CLICKHOUSE-2] 2018-09-02 06:00:04 +03:00
Alexey Milovidov
f7107f12b4 Merge branch 'master' into extra-warnings 2018-09-02 03:13:36 +03:00
Alexey Milovidov
7d77d001f5 Full support for alignment of aggregate states #2808 2018-09-01 07:25:03 +03:00
alexey-milovidov
6d5092518f
Merge pull request #2808 from chenxing-xc/master
Aligned aggregate state  #2754
2018-09-01 05:38:11 +03:00
alexey-milovidov
a05cdfbb45
Merge branch 'master' into extra-warnings 2018-08-31 03:03:44 +03:00
chertus
9becb21e52 better comments for IColumn [CLICKHOUSE-2] 2018-08-29 15:10:18 +03:00
proller
18044995ba Fix includes 2018-08-28 22:36:27 +03:00
Alexey Milovidov
74fee0dc98 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:20:58 +03:00
Alexey Milovidov
a3cd1ea8cb Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 21:16:32 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
alexey-milovidov
95b2bcbc6b
Merge pull request #2970 from 4ertus2/decimal
Some more Decimal
2018-08-27 19:59:26 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
Alexey Milovidov
6779de62d1 Enabling -Wextra-semi [#CLICKHOUSE-2] 2018-08-26 03:44:23 +03:00
chertus
53ec40eeee some decimal field improvements CLICKHOUSE-3765 2018-08-24 19:35:00 +03:00
Alexey Milovidov
6043ea02de Style #2913 2018-08-24 08:25:00 +03:00
Alexey Milovidov
1437e5cbe3 Fix style [#CLICKHOUSE-2] 2018-08-24 03:07:25 +03:00
chertus
cbb80f52c2 own DecimalField for Decimal32/64/128, better field comparison CLICKHOUSE-3765 2018-08-23 17:03:37 +03:00
Alexey Milovidov
7d76c3fd4f Miscellaneous [#CLICKHOUSE-3765] 2018-08-21 07:31:35 +03:00
Alexey Milovidov
15c971a225 Decimal: fixed error [#CLICKHOUSE-3765] 2018-08-21 07:00:50 +03:00
Alexey Milovidov
be80ac893e Whitespace [#CLICKHOUSE-3621] 2018-08-21 06:40:09 +03:00
zhang2014
3b0f0ac01e ISSUES-2846 fix build failure with gcc 8.1 2018-08-15 11:51:03 +08:00
alexey-milovidov
c376b2d476
Merge pull request #2869 from yandex/low-cardinality-fixes
LowCardinality fixes
2018-08-14 22:36:19 +03:00
Nikolai Kochetov
f61fdf2076 Better const resolution for LowCardinality type. [#CLICKHOUSE-3621] 2018-08-14 20:19:40 +03:00
chertus
241b05c80a merge master 2018-08-14 15:50:28 +03:00
alexey-milovidov
f538bd2113
Merge branch 'master' into decimal 2018-08-13 11:57:42 +03:00
chertus
01c8b1d7bb decimal field extraction (from column or type) 2018-08-10 17:57:55 +03:00
Nikolai Kochetov
4a62ab9d5c Merged with master. 2018-08-10 16:53:08 +03:00
Alexey Milovidov
36db216abf Preparation for extra warnings [#CLICKHOUSE-2] 2018-08-10 07:02:56 +03:00
chertus
479166283e DecField (in progress) 2018-08-09 19:32:01 +03:00
Nikolai Kochetov
4fd3d57e79 Less compiler warnings. 2018-08-09 13:52:54 +03:00
Nikolai Kochetov
79db5b261f Less compiler warnings. 2018-08-09 13:52:46 +03:00
Nikolai Kochetov
f4d9d50168 Merged with master. 2018-08-08 15:01:18 +03:00
Nikolai Kochetov
e83268a7f4 Optimize mapUniqueIndex for ColumnWIthDictionary. 2018-08-07 21:12:04 +03:00
Nikolai Kochetov
01209533f7 Optimize reverse index for ColumnUnique. 2018-08-07 21:10:16 +03:00
Nikolai Kochetov
3f4348a88b Use HashTableWithSavedHash for strings in ColumnUnique. 2018-08-07 21:09:55 +03:00
Nikolai Kochetov
a109d8f002 Disabled checks for index values in ColumnWithDictionary. 2018-08-07 21:09:49 +03:00
chertus
de68022fc5 rewrite Decimal with own data type 2018-08-07 16:57:28 +03:00
chenxing.xc
4acc441179 fix aligned states review comments 2018-08-05 18:12:06 +08:00
chenxing.xc
202894e191 Merge remote-tracking branch 'rb/master' 2018-08-05 17:59:58 +08:00
chenxing.xc
90d8290d28 aligned aggregate state 2018-08-05 16:45:15 +08:00
chertus
b9fd87eff7 Merge branch 'master' into decimal 2018-07-27 20:31:33 +03:00
chertus
c1c149d74b decimal comparisons 2018-07-25 22:38:21 +03:00
chertus
5ec47b4a1c decimal (in progress) 2018-07-20 22:05:07 +03:00
Nikolai Kochetov
df379afde4 Reserve memory for HashTable in ColumnUnique. 2018-07-20 19:16:33 +03:00
alexey-milovidov
c9dc058345
Update Collator.cpp 2018-07-20 18:49:47 +03:00
alesapin
fae9c33282 CLICKHOUSE-3791: Add system table collations 2018-07-20 16:17:16 +03:00
Nikolai Kochetov
bf26fda38d Added canBeExecutedOnDefaultArguments into IFunction. Don't run function on defaults is this flag is true. 2018-07-20 13:19:07 +03:00
Nikolai Kochetov
9c763f8090 Make DatsTypeWithDictionary independent from index type. 2018-07-20 13:16:27 +03:00