Alexey Milovidov
00774ad8c6
Suggested changes by Amos Bird #2954
2018-08-27 18:27:23 +03:00
Alexey Milovidov
303cc7242f
Addition to prev. revision #2956
2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030
Removed code with duplicate semantics [#CLICKHOUSE-2]
2018-08-27 18:01:33 +03:00
alexey-milovidov
7de0549879
Update ReadHelpers.h
2018-08-27 18:00:08 +03:00
alexey-milovidov
01f01b1ee1
Update ReadHelpers.cpp
2018-08-27 17:54:58 +03:00
alesapin
a2a623d228
Merge pull request #2967 from alesapin/master
...
Small fixes in testing framework
2018-08-27 17:53:56 +03:00
alesapin
716c8016d7
CLICKHOUSE-3894: Print stack trace
2018-08-27 17:45:37 +03:00
alesapin
06d091580d
CLICKHOUSE-3894: Increase MySQL timeout and add logging
2018-08-27 17:43:59 +03:00
proller
3acce3bff9
Build fix ( #2944 )
...
* Build fix
* Better sample build scripts
* zlib apple fix
* fix
* fix
* better so version
* SPLIT_SHARED -> LINK_MODE
* clean
2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864
Get rid of useless std::move to get NRVO
...
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision
Some quote:
> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."
There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
if (block && remove_filter)
block.erase(static_cast<size_t>(filter_column));
return std::move(block);
}
```
because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
VadimPE
a8974f8786
CLICKHOUSE-3847 add Coordinator
2018-08-27 16:51:22 +03:00
alesapin
3913a6ef4e
Merge pull request #2965 from alesapin/master
...
CLICKHOUSE-3894: Wait zookeeper before clickhouse start
2018-08-27 16:51:05 +03:00
alesapin
570343fdb3
CLICKHOUSE-3894: Wait zookeeper before clickhouse start
2018-08-27 16:42:39 +03:00
alexey-milovidov
806316511f
Merge pull request #2960 from zhang2014/fix/on_cluster_crash
...
ISSUES-2482 fix crash when on cluster
2018-08-27 16:25:26 +03:00
alexey-milovidov
2a99560f17
Merge pull request #2964 from yandex/zookeeper-tweak-error-codes
...
Tweak error code in ZooKeeper library for correct expectations from t…
2018-08-27 16:24:07 +03:00
alexey-milovidov
eb5f571935
Merge pull request #2959 from VadimPE/CLICKHOUSE-3914
...
CLICKHOUSE-3914 add doc for CASE without ELSE
2018-08-27 15:36:06 +03:00
VadimPE
5c0039f124
CLICKHOUSE-3914 fix
2018-08-27 15:31:17 +03:00
Vadim
be2d821669
Merge branch 'master' into CLICKHOUSE-3847
2018-08-27 15:26:41 +03:00
Alexey Milovidov
eb165a0616
Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916]
2018-08-27 15:19:29 +03:00
Vadim
c4e90d89f0
Update ReplicatedMergeTreeCleanupThread.cpp
2018-08-27 15:16:52 +03:00
VadimPE
22aa521884
CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted
2018-08-27 15:14:48 +03:00
VadimPE
cf0a7c1529
CLICKHOUSE-3847 fix bug when replica recover and it's log_pointer will be deleted
2018-08-27 15:09:22 +03:00
alesapin
9b358e037e
Merge pull request #2962 from alesapin/master
...
CLICKHOUSE-3894: Fix test_config_substs test
2018-08-27 14:51:09 +03:00
alesapin
d5dd32f4fe
CLICKHOUSE-3894: Fix test_config_substs test
2018-08-27 14:40:01 +03:00
zhang2014
f8d7cf17a7
ISSUES-2482 fix crash when on cluster
2018-08-27 19:03:22 +08:00
VadimPE
83ff0d2721
CLICKHOUSE-3914 add doc for CASE without ELSE
2018-08-27 12:21:40 +03:00
BlahGeek
739119d355
skip object fields on json input
2018-08-27 12:01:47 +08:00
alexey-milovidov
3be0b6ca6d
Merge pull request #2950 from yandex/generalize-zookeeper
...
Generalize zookeeper library
2018-08-26 03:33:11 +03:00
Alexey Milovidov
c193d15ef2
Merge branch 'master' into generalize-zookeeper
2018-08-26 03:32:15 +03:00
alexey-milovidov
f92bae33f8
Merge pull request #2949 from yandex/distinguish-between-definitely-lost-and-unknown-requests-in-zookeeper
...
ZooKeeperImpl: allow to distinguish cases when request was definitely not been processed.
2018-08-26 03:12:20 +03:00
Alexey Milovidov
74b0d9b6a7
Little better; added comment #2954
2018-08-26 02:59:53 +03:00
Alexey Milovidov
2ce783e016
Merge branch 'read' of https://github.com/amosbird/ClickHouse into amosbird-read
2018-08-26 02:55:22 +03:00
alexey-milovidov
35806a4d27
Merge pull request #2955 from amosbird/varint
...
Fast path for varint read.
2018-08-26 02:47:04 +03:00
alexey-milovidov
00404a911c
Update VarInt.h
2018-08-26 02:46:18 +03:00
Amos Bird
a589230249
Faster path for varint read.
...
clickhouse-benchmark <<< 'select count() from s where not ignore(s);'
before this patch:
```
QPS: 0.732, RPS: 2346562049.608, MiB/s: 22378.560, result RPS: 0.732, result MiB/s: 0.000.
0.000% 1.310 sec.
10.000% 1.321 sec.
20.000% 1.327 sec.
30.000% 1.337 sec.
40.000% 1.343 sec.
50.000% 1.359 sec.
60.000% 1.366 sec.
70.000% 1.381 sec.
80.000% 1.400 sec.
90.000% 1.434 sec.
95.000% 1.448 sec.
99.000% 1.489 sec.
99.900% 1.499 sec.
99.990% 1.500 sec.
```
after this patch:
```
QPS: 0.787, RPS: 2524560389.064, MiB/s: 24076.084, result RPS: 0.787, result MiB/s: 0.000.
0.000% 1.228 sec.
10.000% 1.232 sec.
20.000% 1.235 sec.
30.000% 1.241 sec.
40.000% 1.246 sec.
50.000% 1.256 sec.
60.000% 1.265 sec.
70.000% 1.278 sec.
80.000% 1.296 sec.
90.000% 1.321 sec.
95.000% 1.354 sec.
99.000% 1.421 sec.
99.900% 1.453 sec.
99.990% 1.456 sec.
```
I also tried a SSE2 implementation and it's much slower (50%)
2018-08-26 02:23:26 +08:00
alexey-milovidov
732afd27cf
Merge pull request #2953 from yandex/max-block-size-in-system-tables-columns
...
Support for max_block_size in system.tables and system.columns tables
2018-08-25 20:36:54 +03:00
Amos Bird
9623e59870
Simplify read helpers.
...
Use similar APIs like https://en.cppreference.com/w/cpp/string/byte/strstr
2018-08-26 01:27:28 +08:00
Alexey Milovidov
0ef5b19436
Merge branch 'master' of github.com:yandex/ClickHouse
2018-08-25 19:50:14 +03:00
Alexey Milovidov
17818fa54f
Merge branch 'Tezd-feature/suggestions'
2018-08-25 19:49:48 +03:00
alexey-milovidov
e7edfd2a05
Merge pull request #2952 from amosbird/buffer
...
Make sure BufferBase is fully swapped.
2018-08-25 19:35:41 +03:00
Alexey Milovidov
aa936b09f9
Added check for max_block_size = 0 #2447
2018-08-25 19:32:44 +03:00
Alexey Milovidov
9c79c5f8ab
Added test #2447
2018-08-25 19:26:55 +03:00
Alexey Milovidov
93b44fb17c
Made suggest case sensitive again. Otherwise there is a glitch when you type SELECT DIS<TAB> #2447
2018-08-25 19:19:00 +03:00
Alexey Milovidov
068e50329e
Support for max_block_size in system.tables and system.columns tables #2447
2018-08-25 19:07:48 +03:00
Alexey Milovidov
417cc1ab4d
Additions #2447
2018-08-25 19:05:01 +03:00
Alexey Milovidov
24083e3088
Separate files #2447
2018-08-25 16:55:18 +03:00
Alexey Milovidov
9293882206
Allow to disable suggestion; check server revision #2447
2018-08-25 16:41:50 +03:00
Alexey Milovidov
32eb1a7942
Merge branch 'feature/suggestions' of https://github.com/Tezd/ClickHouse into Tezd-feature/suggestions
2018-08-25 16:15:30 +03:00
Amos Bird
5f03082af9
Make sure BufferBase is fully swapped.
2018-08-25 19:58:16 +08:00
alexey-milovidov
046137f9c5
Merge pull request #2946 from amosbird/locking
...
Better locking for StorageBuffer
2018-08-25 13:47:29 +03:00