Commit Graph

19955 Commits

Author SHA1 Message Date
Amos Bird
30b06a969b
Cancel vertical merges (#31057)
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-15 14:32:53 +03:00
Alexander Tokmakov
416a82b99a Merge branch 'master' into check_dependencies_on_drop 2021-11-15 13:35:45 +03:00
alesapin
af820f85d3
Merge pull request #31259 from azat/temporary_directories_lifetime-message-fix
Print warning during old directories cleanup in MergeTree only if it is old
2021-11-15 12:56:31 +03:00
alesapin
a4c711ba8b
Merge pull request #31406 from ClickHouse/tavplubix-patch-5
Remove excessive debug info from the log message in DDLWorker
2021-11-15 12:38:03 +03:00
Vladimir Chebotarev
5e9710a26e Attempt to resolve nullptr in STS credentials provider for S3. 2021-11-15 10:46:43 +03:00
Azat Khuzhin
fe36884110 Convert assert(!isGlobalContext()) to LOGICAL_ERROR 2021-11-15 10:32:19 +03:00
Azat Khuzhin
68068ff71d Remove check for clickhouse-local
From #26231 clickhouse-local uses local context for query execution.
2021-11-15 10:32:19 +03:00
Azat Khuzhin
fa317e96e8 Do not try to resolve temporary tables from global context 2021-11-15 10:32:19 +03:00
alesapin
2a9ed85f23
Merge pull request #31300 from ClickHouse/fix_intersecting_parts_to_do3
Remove strange code from mutations
2021-11-15 10:08:32 +03:00
qieqieplus
b6aa781c9b add dot separator 2021-11-15 14:47:34 +08:00
tavplubix
b5b20f84bc
Update DDLWorker.cpp 2021-11-14 17:41:55 +03:00
Kseniia Sumarokova
846fbd059b
Merge pull request #31403 from kssenii/fix-client-output
Fix client
2021-11-14 15:01:30 +03:00
kssenii
ad1b7c83cd Fix 2021-11-14 07:19:59 +00:00
Alexey Milovidov
052a7a92e8 Whitespace 2021-11-14 10:05:20 +03:00
Alexey Milovidov
fe3ee85d80 Fix MaterializedMySQL 2021-11-14 10:04:45 +03:00
alexey-milovidov
cb6342025d
Merge pull request #31229 from zhanglistar/fsync
Change all fsync to fdatasync
2021-11-14 05:16:01 +03:00
Alexey Milovidov
bd684f02f2 Fix clang-tidy 2021-11-14 04:57:59 +03:00
Alexey Milovidov
1e4e36ff2d Remove thread_local std::string 2021-11-14 02:43:17 +03:00
alexey-milovidov
e323b83f6a
Merge pull request #30876 from pmed/backslash_letter_interactive_input
add aliases for `\<letter>` interactive client commands
2021-11-14 01:43:13 +03:00
Azat Khuzhin
f2c74a81f7 Fix QueryScope in MaterializedMySQLSyncThread
QueryScope should exist for the whole query execution time.
2021-11-13 20:06:08 +03:00
Kseniia Sumarokova
59d4eb99c2
Merge pull request #31291 from kssenii/update-async-reads-setting
Make remote_filesystem_read_method=threadpool by default
2021-11-13 19:19:35 +03:00
Azat Khuzhin
11be942bb0 Fix possible data-race in case of query cancellation with async_socket_for_remote
RemoteQueryExecutor::cancel() (that is called in another thread), steal
the fiber, and process any pending packets, to leave the connection in
the correct state (so that it can be reused for further queries).

However this requires processing pending packets, and this will update
the RemoteQueryExecutorReadContext::packet field, which can be read in
another thread by the RemoteQueryExecutor::read().

This was pretty tricky due to fibers, but AFAICS I understand this
correctly and this should fix the race.

Note, that if you will look at the logs from the #28854, you will see,
that all those data races was triggered after query cancellation.

Fixes: #28854
Refs: #18715

v2: fix daedlock in case of duplicated parts
v3: do not hold the mutex, since was_cancelled is atomic
2021-11-13 12:44:02 +03:00
Kseniia Sumarokova
c7be79b4e7
Merge pull request #31136 from LiuYangkuan/IDiskRemote_metadata_disk
use DiskPtr instead of OS's file system API in class IDiskRemote
2021-11-13 12:16:05 +03:00
mergify[bot]
5d0306ed0c
Merge branch 'master' into notlike-fix 2021-11-12 22:35:10 +00:00
Maksim Kita
38be11a622
Merge pull request #31334 from kitaisreal/bloom-filter-index-check-fix
BloomFilter index check fix
2021-11-13 01:26:08 +03:00
Kseniia Sumarokova
c6fd56ede9
Update DiskLocal.cpp 2021-11-13 00:00:32 +03:00
mergify[bot]
22e7efa8b0
Merge branch 'master' into add_oss_support 2021-11-12 18:25:26 +00:00
LiuYangkuan
4366fcbc83 fix build check and make rename robust in DiskS3::restoreFileOperations 2021-11-12 22:54:10 +08:00
Tomáš Hromada
445b0ba7cc
Expose all GlobalThreadPool config params (#31285) 2021-11-12 16:24:47 +03:00
Kruglov Pavel
051a9e7c69
Merge pull request #31249 from vitlibar/fix-show-grants
Fix SHOW GRANTS when partial revokes are used.
2021-11-12 15:49:12 +03:00
tavplubix
8916d3bebf
Merge pull request #31305 from ClickHouse/rename_support_ifexists
Merging #31081
2021-11-12 15:22:43 +03:00
Anton Popov
7769ed76ce
Merge pull request #31261 from CurtizJ/tuple-element-to-subcolumn
Optimize tupleElement to reading of subcolumn
2021-11-12 15:00:53 +03:00
kssenii
6f895036e6 Disable for hdfs until tested, adjust tests with profile events 2021-11-12 14:09:19 +03:00
Vitaly Baranov
79a93c819f
Merge pull request #31262 from vitlibar/initial-user-role-row-policy
Initial user's roles are used now to find row policies
2021-11-12 13:51:20 +03:00
liyang830
7b88c956c8 fix: quota limit was not reached, but the limit was exceeded 2021-11-12 18:22:55 +08:00
zhanglistar
8bcef97e11 1. style check fix. 2021-11-12 17:23:22 +08:00
Maksim Kita
1b5ff67eaa BloomFilter index check fix 2021-11-12 12:22:43 +03:00
Kseniia Sumarokova
99cbf64044
Merge pull request #31325 from ClickHouse/kssenii-fix
Fix check in async buffer
2021-11-12 12:09:13 +03:00
Nikolai Kochetov
6623c609cf
Merge pull request #19587 from ClickHouse/refactor-pipeline-executor
Refactor pipeline executor
2021-11-12 11:49:05 +03:00
zhanglistar
d13256242a 1. fix sytle check 2021-11-12 16:15:39 +08:00
Kseniia Sumarokova
074d24fcf3
Merge pull request #31318 from kssenii/fix-progress-numbers-mt
Proper progress for numbers_mt
2021-11-12 11:13:32 +03:00
zhanglistar
4e7823ade7 1. add macosx fix 2021-11-12 15:49:21 +08:00
LiuYangkuan
f7078a17ce add DiskLocalDirectoryIterator() when path not directory or nonexist, fix remove from_path after moveDirectory in DiskS3::restoreFileOperations 2021-11-12 11:36:48 +08:00
alexey-milovidov
b1f177e2ae
Merge pull request #31309 from Civil/riscv
Initial support for risc-v
2021-11-12 03:41:57 +03:00
kssenii
031754b465 Fix 2021-11-12 01:37:18 +03:00
Kseniia Sumarokova
e709c3ba90
Update AsynchronousReadIndirectBufferFromRemoteFS.h 2021-11-12 01:13:44 +03:00
kssenii
f46569a46b Fix 2021-11-12 00:42:36 +03:00
Kseniia Sumarokova
1bf30709f0
Merge pull request #31258 from cccgp/move_InputCreatorFunc_to_InputCreator
move InputCreatorFunc to InputCreator
2021-11-12 00:05:21 +03:00
Kseniia Sumarokova
2313981fd7
Merge pull request #31260 from azat/external-cleanup
Cleanup extern ProfileEvents/CurrentMetrics and add a style check
2021-11-12 00:02:57 +03:00
Azat Khuzhin
10fa34c73a Print warning during old directories cleanup in MergeTree only if it is old 2021-11-11 23:57:44 +03:00
Anton Popov
4c6c80b9a2
Merge pull request #31044 from kssenii/fix-storage-merge-with-aliases-and-where
Fix StorageMerge with aliases and where
2021-11-11 21:46:02 +03:00
Vladimir Smirnov
48451182f8 Initial support for risc-v
Make ClickHouse compilable and runnable on risc-v 64

So far only basic functionality was tested (on real hw),
clickhouse server runs, exceptions works, client works,
simple tests works.

What doesn't work:
 1. traces - they are always empty
 2. system.stack_trace only have first frame
2021-11-11 19:23:34 +01:00
avogar
e5661b9b62 Minor change 2021-11-11 21:09:21 +03:00
tavplubix
de6a6f3227
Merge pull request #31180 from ClickHouse/merge_selecting_backoff
Slightly better backoff for merge selecting task
2021-11-11 20:57:40 +03:00
Nikolay Degterinsky
bcfe902b0d
Merge pull request #31226 from georgthegreat/master
Fix typo in USE_MYSQL check
2021-11-11 20:49:30 +03:00
alexey-milovidov
572aec481a
Update DirectoryMonitor.cpp 2021-11-11 20:17:55 +03:00
Kseniia Sumarokova
b3bacac021
Merge pull request #29894 from kssenii/retriable-http
Make http read buffer retriable
2021-11-11 19:50:50 +03:00
cgp
18504f545a move InputCreatorFunc to InputCreator 2021-11-12 00:34:59 +08:00
Nikolai Kochetov
36954a910e try fix header. 2021-11-11 19:30:59 +03:00
Alexander Tokmakov
73ab518e97 minor improvements 2021-11-11 19:29:56 +03:00
mergify[bot]
58c5981cab
Merge branch 'master' into refactor-pipeline-executor 2021-11-11 16:16:52 +00:00
Alexander Tokmakov
5858a4f74f remove strange code from mutations 2021-11-11 17:03:33 +03:00
Nikolay Degterinsky
0d58c5231f Better 2021-11-11 13:28:18 +00:00
kssenii
d8ef39461f Fix 2021-11-11 16:10:07 +03:00
tavplubix
ce8893ad43
Merge pull request #31010 from amosbird/narrowlock
Only grab AlterLock when we do alter.
2021-11-11 16:04:09 +03:00
Nikolay Degterinsky
7b5954b736 Merge branch 'master' into query_parameters 2021-11-11 11:43:00 +00:00
Nikolai Kochetov
90cf835277 A little bit more refactoring. 2021-11-11 14:41:15 +03:00
Alexander Tokmakov
108b5a70e2 mark settings as obsolete 2021-11-11 14:21:42 +03:00
Alexander Tokmakov
627dde7aba Merge branch 'master' into merge_selecting_backoff 2021-11-11 13:43:10 +03:00
tavplubix
dd720ec9b4
Merge pull request #31252 from ClickHouse/warning_for_obsolete_settings
Show warning if some obsolete setting changed
2021-11-11 13:41:49 +03:00
kssenii
0dda1f280b Update setting remote_filesystem_read_method 2021-11-11 13:19:49 +03:00
Kseniia Sumarokova
e20cb0c10a
Merge branch 'master' into retriable-http 2021-11-11 11:52:06 +03:00
Nikolai Kochetov
b062c8ca51
Merge pull request #31031 from cmsxbc/throw-exception-offset-fetch-without-order-by
improve error message while using OFFSET FETCH clause without ORDER BY
2021-11-11 11:37:16 +03:00
cfcz48
d0425016e3 I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
New Feature

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Aliyun OSS Storage support.
2021-11-11 16:26:29 +08:00
Vladimir C
b85710a673
Merge pull request #31105 from abel-cheng/fix-rewrite-in-local-in 2021-11-11 10:02:52 +03:00
cms
bc6616d8be
improve error message while using OFFSET FETCH clause without ORDER BY 2021-11-11 08:20:21 +08:00
kssenii
18b9a8f7fd Fix build check 2021-11-11 02:03:56 +03:00
alexey-milovidov
e3650b865a
Merge pull request #30965 from kssenii/intersect-except-fix
Fix cases when intersect / except is not checked
2021-11-11 01:59:59 +03:00
Kseniia Sumarokova
c916f24a06
Merge pull request #31224 from kssenii/rename-setting
Rename setting value read_threadpool to threadpool
2021-11-11 01:04:58 +03:00
kssenii
62c70ce5cf Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into retriable-http 2021-11-10 21:16:11 +00:00
kssenii
175f903624 Fix 2021-11-10 21:14:17 +00:00
Anton Popov
47e19a4cd9 optimize tupleElement to reading of subcolumn 2021-11-10 22:24:28 +03:00
Vitaly Baranov
db5ac1ed06 Initial user's roles are used now to find row policies. 2021-11-10 22:21:50 +03:00
Azat Khuzhin
f9428450cd Fix OpenedFileCacheHits/OpenedFileCacheMisses 2021-11-10 21:15:27 +03:00
Azat Khuzhin
baf14444e6 Cleanup ProfileEvents and CurrentMetrics 2021-11-10 21:15:27 +03:00
Azat Khuzhin
47a18e8ac5 Remove non existing BackgroundPoolTask in ReplicatedMergeTreeQueue 2021-11-10 21:15:26 +03:00
Anton Popov
833652e8f4 Merge branch 'nikvas0/simple_optimizations' of git://github.com/nikvas0/ClickHouse into merging-constraints 2021-11-10 19:35:28 +03:00
kssenii
a2326f5035 Fix 2021-11-10 19:03:54 +03:00
Alexander Tokmakov
9d83832bde show warning if some obsolete setting changed 2021-11-10 18:49:13 +03:00
Vitaly Baranov
1579bcfd20
Merge pull request #31178 from vitlibar/backup-engines-and-improvements
Backup engines and improvements
2021-11-10 18:20:41 +03:00
kssenii
de1bb90fec Fix build check 2021-11-10 15:07:42 +00:00
Nikolai Kochetov
c11243619c Roll back boost contrib. 2021-11-10 18:01:26 +03:00
LiuYangkuan
006dca1362 use DiskPtr instead of OS's file system API in class IDiskRemote 2021-11-10 22:50:15 +08:00
Nikolai Kochetov
650fe5a834 Refactor a littel bit more. 2021-11-10 17:13:27 +03:00
Vitaly Baranov
b74999b6bd Fix SHOW GRANTS when partial revokes are used. 2021-11-10 17:03:02 +03:00
Anton Popov
9538dcf0c7
Merge pull request #31218 from CurtizJ/map-contains-to-subcolumn
Optimize `mapContains` to reading of subcolumn
2021-11-10 16:34:26 +03:00
mergify[bot]
5084003ed8
Merge branch 'master' into narrowlock 2021-11-10 13:07:07 +00:00
Vladimir C
19e2cbcabc
Apply suggestions from code review 2021-11-10 14:44:35 +03:00
kssenii
f4f0bd8b5c Fix 2021-11-10 13:16:39 +03:00
zhanglistar
aaad3f84da
Merge branch 'ClickHouse:master' into fsync 2021-11-10 17:44:08 +08:00
zhanglistar
96b8df5899 1. chagne all fsync to fdatasync 2021-11-10 17:40:16 +08:00
kssenii
6bc7fb1edf Fixes 2021-11-10 09:33:48 +00:00
kssenii
60ed991c2c Fix 2021-11-10 11:47:03 +03:00
Yuriy Chernyshov
abf4fbe82f Fix typo in USE_MYSQL check 2021-11-10 11:38:03 +03:00
kssenii
e166bfbf26 Save redirect result 2021-11-10 08:27:07 +00:00
Vitaly Baranov
71359433dd Add parameters "backups.allowed_path" and "backups.allowed_disk" to config. 2021-11-10 11:03:09 +03:00
Vitaly Baranov
606e94f4cc Fix backup of database. 2021-11-10 11:03:09 +03:00
Vitaly Baranov
e0f475c724 Split backup implementation into two parts to help implementing other backup engines. 2021-11-10 11:03:03 +03:00
kssenii
618c332f9c Rename read_threadpool to threadpool 2021-11-10 07:46:18 +00:00
alexey-milovidov
7006147268
Merge pull request #31159 from snar/freebsd-disk-space
correct disk space calculations
2021-11-10 02:48:29 +03:00
Anton Popov
c2eb9e7e78 optimize mapContains to subcolumn 2021-11-10 00:44:51 +03:00
alexey-milovidov
b8f98fdc79
Merge pull request #31147 from georgthegreat/master
Do not include unnecessary experimental/type_traits
2021-11-09 23:18:10 +03:00
Vitaly Baranov
bf8606a931 Add UUID and timestamp to backup metadata. 2021-11-09 23:16:45 +03:00
Vitaly Baranov
8a93001245 Switch to XML format for backup's metadata. 2021-11-09 23:16:45 +03:00
Vitaly Baranov
cf77c0b3fc New syntax for BACKUP/RESTORE: set backup engine explicitly. 2021-11-09 23:16:40 +03:00
Alexander Tokmakov
4f542ab019 add test 2021-11-09 23:11:02 +03:00
alesapin
d4cb8dad94
Merge pull request #31175 from ClickHouse/add_unit_tests
Add unit tests to CI
2021-11-09 20:18:35 +03:00
sundy-li
d8aaac36ec Add stable order by tests result 2021-11-09 21:34:55 +08:00
sundy-li
45cab9f3b0 Add stable order by tests result 2021-11-09 21:31:31 +08:00
Kruglov Pavel
17085183bf
Merge pull request #31042 from Avogar/hdfs-bad-url
Add additional hdfs url check
2021-11-09 16:23:59 +03:00
alesapin
b91b90d639 Fix test local address 2021-11-09 16:02:17 +03:00
Alexander Tokmakov
51bd98294e better merge selecting backoff 2021-11-09 15:26:51 +03:00
kssenii
bfde7fd36c Better 2021-11-09 12:06:43 +00:00
Dmitry Novik
406bb4d997
Merge pull request #28965 from nicelulu/issues_28774
128bit hash-functions accepting arbitrary list of arguments
2021-11-09 14:40:25 +03:00
kssenii
ee9ceaf7d4 Better 2021-11-09 14:27:17 +03:00
Amos Bird
33dfed584d
Fix exception message 2021-11-09 18:19:00 +08:00
Amos Bird
94fe925773
Better 2021-11-09 18:02:17 +08:00
Alexandre Snarskii
c36c64a9a0 more corrections for disk size calculations 2021-11-09 12:28:59 +03:00
alesapin
68a3baf3cd
Merge pull request #31150 from ClickHouse/fix_keeper_log_gap
Fix bug in Keeper when some logs was lost
2021-11-09 10:28:55 +03:00
Kseniia Sumarokova
581986c0d3
Merge pull request #30997 from kssenii/rabbitmq-fixes
RabbitMQ: fix one issue and add more tests
2021-11-09 10:15:01 +03:00
kssenii
36f213e51c Fix build 2021-11-09 07:11:44 +00:00
sundy-li
3a981de643 ISSUES-30801: Remove not like function into RPNElement 2021-11-09 10:57:37 +08:00
kssenii
7e57368c82 Fix 2021-11-08 19:48:38 +00:00
Kseniia Sumarokova
c458f73138
Update AsynchronousReadIndirectBufferFromRemoteFS.cpp 2021-11-08 22:12:04 +03:00
Kseniia Sumarokova
1167e5aae8
Merge pull request #31112 from kssenii/fix-async-reads
Fix threadpool read for remote disks
2021-11-08 22:10:30 +03:00
tavplubix
7079a6abff
Merge pull request #31060 from ClickHouse/fix_intersecting_parts_to_do2
Fix intersecting parts in `parts_to_do` 2
2021-11-08 20:08:13 +03:00
mergify[bot]
f55e1439cb
Merge branch 'master' into output-formats 2021-11-08 15:33:45 +00:00
alesapin
13d39fdbd4 Fix tautology 2021-11-08 17:59:38 +03:00
Nikolai Kochetov
14a3988f8c
Merge pull request #31033 from azat/remap-log
Log size of remapped memory (remap_executable)
2021-11-08 17:12:04 +03:00
kssenii
dead99011b Merge branch 'master' of github.com:ClickHouse/ClickHouse into intersect-except-fix 2021-11-08 16:15:33 +03:00
Vladimir C
a3d8bcb82f
Merge pull request #31149 from vdimir/fix_optimize_syntax_fuse_functions 2021-11-08 16:14:39 +03:00
Kseniia Sumarokova
9e3f112d89
Update src/Storages/RabbitMQ/StorageRabbitMQ.h
Co-authored-by: tavplubix <tavplubix@gmail.com>
2021-11-08 16:10:22 +03:00
alesapin
e64efbb2b1 Fix Bug in Keeper with inability to start 2021-11-08 15:53:45 +03:00
Vladimir C
a9689c0f27
Merge pull request #25894 from vdimir/join-on-const-to-cross 2021-11-08 15:52:40 +03:00
vdimir
56bc802ee2
Support join on constant 2021-11-08 15:44:13 +03:00
vdimir
4bc9798c63
Some optimizations for constant conditions in JOIN ON 2021-11-08 15:36:34 +03:00
vdimir
2fb21906de
Disable optimize_syntax_fuse_functions by default 2021-11-08 15:25:56 +03:00
Yuriy Chernyshov
479ebc0652 Do not include unnecessary experimental/type_traits 2021-11-08 14:16:19 +03:00
kssenii
83d64f1c2d Better 2021-11-08 13:32:32 +03:00
Amr Alaa
ad81977ace
Skip max_partition_size_to_drop check in case of ATTACH PARTITION ... FROM (#30995)
* Skip checkPartitionCanBeDropped check in case of ATTACH PARTITION ... FROM

* Add integration test

* Fix syntax error

* Fix integration test

* Fix integration test

* Fix integration test

* Skip max_partition_size_to_drop for MOVE PARTITION
2021-11-08 13:07:14 +03:00