Commit Graph

12902 Commits

Author SHA1 Message Date
Alexey Milovidov
6e18af7ed3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 20:18:14 +03:00
Alexey Milovidov
486d87ebcd Merge remote-tracking branch 'origin/master' into extra-warnings 2018-08-27 20:01:33 +03:00
alexey-milovidov
95b2bcbc6b
Merge pull request #2970 from 4ertus2/decimal
Some more Decimal
2018-08-27 19:59:26 +03:00
alexey-milovidov
3328fb456a
Merge pull request #2966 from amosbird/nrvo
Get rid of useless std::move to get NRVO
2018-08-27 19:56:03 +03:00
Alexey Milovidov
ad5855b7c1 Compatibility with old CMake [#CLICKHOUSE-2] 2018-08-27 19:49:40 +03:00
chertus
9dbaa5f4a9 remove strange code CLICKHOUSE-3765 2018-08-27 19:46:42 +03:00
Alexey Milovidov
076e1fb2e1 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 19:31:45 +03:00
alesapin
4ecf3ce8ef
Merge pull request #2969 from alesapin/master
CLICKHOUSE-3894: Fix Kafka test
2018-08-27 19:24:39 +03:00
Alexey Milovidov
e5a2dd8624 Merge branch 'master' into extra-warnings 2018-08-27 19:19:04 +03:00
chertus
ee873c8e9f Merge branch 'master' into decimal 2018-08-27 19:18:48 +03:00
chertus
c86f2878ff add special ColumnDecimal instead of ColumnVector<DecimalNN> CLICKHOUSE-3765 2018-08-27 19:16:16 +03:00
alesapin
1f0f1ecad3 CLICKHOUSE-3894: Fix Kafka test 2018-08-27 19:15:39 +03:00
Alexey Milovidov
303cc7242f Addition to prev. revision #2956 2018-08-27 18:01:33 +03:00
Alexey Milovidov
6e57168030 Removed code with duplicate semantics [#CLICKHOUSE-2] 2018-08-27 18:01:33 +03:00
alesapin
a2a623d228
Merge pull request #2967 from alesapin/master
Small fixes in testing framework
2018-08-27 17:53:56 +03:00
alesapin
716c8016d7 CLICKHOUSE-3894: Print stack trace 2018-08-27 17:45:37 +03:00
alesapin
06d091580d CLICKHOUSE-3894: Increase MySQL timeout and add logging 2018-08-27 17:43:59 +03:00
proller
3acce3bff9 Build fix (#2944)
* Build fix

* Better sample build scripts

* zlib apple fix

* fix

* fix

* better so version

* SPLIT_SHARED -> LINK_MODE

* clean
2018-08-27 17:39:20 +03:00
Amos Bird
ea84430864 Get rid of useless std::move to get NRVO
http://eel.is/c++draft/class.copy.elision#:constructor,copy,elision

Some quote:

> Speaking of RVO, return std::move(w); prohibits it. It means "use move constructor or fail to compile", whereas return w; means "use RVO, and if you can't, use move constructor, and if you can't, use copy constructor, and if you can't, fail to compile."

There is one exception to this rule:
```cpp
Block FilterBlockInputStream::removeFilterIfNeed(Block && block)
{
    if (block && remove_filter)
        block.erase(static_cast<size_t>(filter_column));

    return std::move(block);
}
```

because references are not eligible for NRVO, which is another rule "always move rvalue references and forward universal references" that takes precedence.
2018-08-27 22:15:48 +08:00
alesapin
3913a6ef4e
Merge pull request #2965 from alesapin/master
CLICKHOUSE-3894: Wait zookeeper before clickhouse start
2018-08-27 16:51:05 +03:00
alesapin
570343fdb3 CLICKHOUSE-3894: Wait zookeeper before clickhouse start 2018-08-27 16:42:39 +03:00
alexey-milovidov
806316511f
Merge pull request #2960 from zhang2014/fix/on_cluster_crash
ISSUES-2482 fix crash when on cluster
2018-08-27 16:25:26 +03:00
Alexey Milovidov
eb165a0616 Tweak error code in ZooKeeper library for correct expectations from the calling code [#CLICKHOUSE-3916] 2018-08-27 15:19:29 +03:00
alesapin
d5dd32f4fe CLICKHOUSE-3894: Fix test_config_substs test 2018-08-27 14:40:01 +03:00
zhang2014
f8d7cf17a7 ISSUES-2482 fix crash when on cluster 2018-08-27 19:03:22 +08:00
Alexey Milovidov
252a00e25b Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-27 10:57:42 +03:00
Alexey Milovidov
eed804ba94 Enabling extra warnings [#CLICKHOUSE-2] 2018-08-26 15:38:45 +03:00
Alexey Milovidov
e33b1d13aa Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 05:48:48 +03:00
Alexey Milovidov
b3c51070d4 Enabling -Wshadow-uncaptured-local [#CLICKHOUSE-2] 2018-08-26 05:41:05 +03:00
Alexey Milovidov
050a080be3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:29:42 +03:00
Alexey Milovidov
f7796df158 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:26:55 +03:00
Alexey Milovidov
5f21f1ba7d Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:25:45 +03:00
Alexey Milovidov
167d8ec529 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:19:18 +03:00
Alexey Milovidov
042d84e1e3 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:17:18 +03:00
Alexey Milovidov
281faa1686 Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:13:41 +03:00
Alexey Milovidov
8a0239b6ad Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:08:35 +03:00
Alexey Milovidov
b44343d83d Enabling -Wshadow [#CLICKHOUSE-2] 2018-08-26 05:00:11 +03:00
Alexey Milovidov
e726fa89f8 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:58:56 +03:00
Alexey Milovidov
a1a70d4a65 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:56:34 +03:00
Alexey Milovidov
936c21de1f Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:42:02 +03:00
Alexey Milovidov
595bd32f41 Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:41:08 +03:00
Alexey Milovidov
d252542e9a Enabling -Wzero-as-null-pointer-constant [#CLICKHOUSE-2] 2018-08-26 04:37:22 +03:00
Alexey Milovidov
625f3fea08 Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:36:41 +03:00
Alexey Milovidov
44e848856e Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:33:20 +03:00
Alexey Milovidov
c0202bfbc9 Enabling -Wunused-exception-parameter [#CLICKHOUSE-2] 2018-08-26 04:31:56 +03:00
Alexey Milovidov
29a6a85ccf Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:31:12 +03:00
Alexey Milovidov
d4ef5d05f2 Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:26:25 +03:00
Alexey Milovidov
4877cf31aa Enabling -Winconsistent-missing-destructor-override [#CLICKHOUSE-2] 2018-08-26 04:25:35 +03:00
Alexey Milovidov
ac7673db29 Enabling -Wcomma [#CLICKHOUSE-2] 2018-08-26 04:24:21 +03:00
Alexey Milovidov
589ee74c7d Enabling -Wcomma [#CLICKHOUSE-2] 2018-08-26 04:19:11 +03:00