Maksim Kita
e7772ed434
Fix clang-tidy warnings in Common folder
2022-03-14 18:17:35 +00:00
Azat Khuzhin
0b2de32228
Fix QueryProfiler (query_profiler_{cpu,real}_time_period_ns) reset
...
Even after timer_delete() the signal can be fired.
Reproducer:
$ clickhouse-server & # with configured trace_log
$ clickhouse-benchmark -c2 --query 'select * from numbers(1e6)' --query_profiler_cpu_time_period_ns=1 &
...
2021.12.02 14:28:01.320288 [ 24885 ] {} <Debug> TCPHandler: Processed in 177.055205644 sec.
User defined signal 2
CI failures:
- https://s3.amazonaws.com/clickhouse-test-reports/32067/8dbc7a8dae17090a18778f29629d8746a1bb9b72/stateful_tests__debug__actions_.html
- https://s3.amazonaws.com/clickhouse-test-reports/32064/c07450a7dce363b7a4c5ca3ab0e833c25e3d46c0/stateful_tests__debug__actions_.html
Fix this by do not reset the signal back, and introduce a flag to ignore
signals after disabling the timer.
Fixes : #31740
2021-12-03 01:33:08 +03:00
Azat Khuzhin
df67af0c88
Fix disabling query profiler
...
Before there was two incorrect checks:
- timer_id != nullptr, but first timer is 0x0 and the comparison does
not work
- previous_handler should also be reseted regardless it was nullptr or
not, plus it also incorrectly uses 'sigaction * previous_handler'
before.
Which leads to permanent query profiler enabled for particular thread,
this is especially visible if you have query profiler disabled and you
are running some query with profiler enabled, i.e.:
select 1 settings query_profiler_real_time_period_ns=1
After, QueryPipelineEx will eat lots of CPU due because of profiler.
2021-11-24 23:28:20 +03:00
Alexey Milovidov
8b4a6a2416
Remove cruft
2021-10-28 02:10:39 +03:00
Alexey Milovidov
fe6b7c77c7
Rename "common" to "base"
2021-10-02 10:13:14 +03:00
Alexey Milovidov
53ca1ebca6
Be in style
2021-08-25 03:58:49 +03:00
Artem Zuikov
51ba12c2c3
Try speedup build ( #14809 )
2020-09-15 12:55:57 +03:00
Alexey Milovidov
edd89a8610
Fix half of typos
2020-08-08 03:47:03 +03:00
Ivan
85d783c247
Poco contrib refactoring ( #10396 )
...
* Remove config_common.h
* Refactor libcpuid contrib
* Remove support for libcpuinfo
* Define USE_CPUID in Arcadia
* Refactor Poco libraries
2020-05-08 17:11:19 +03:00
Ivan Lezhankin
e230632645
Changes required for auto-sync with Arcadia
2020-04-16 15:31:57 +03:00
Ivan Lezhankin
06446b4f08
dbms/ → src/
2020-04-03 18:14:31 +03:00
