Commit Graph

140433 Commits

Author SHA1 Message Date
Yarik Briukhovetskyi
21b88c5041 added execution permission for test file 2024-04-25 18:02:51 +00:00
kssenii
acd7292be0 Fix abort in temporary data in cache 2024-04-25 20:00:40 +02:00
Yarik Briukhovetskyi
64cb638717
add tests and changed implementation 2024-04-25 19:46:20 +02:00
Kseniia Sumarokova
f85d967f11
Merge pull request #62967 from ClickHouse/better-assertion-message-in-cache
Better exception message
2024-04-25 17:16:40 +00:00
Yarik Briukhovetskyi
f623ee99f8
Update message for clickhouse local 2024-04-25 18:57:42 +02:00
Yarik Briukhovetskyi
5b4b4087e3
fixed build, moved verbose to help, fixed exception message 2024-04-25 18:51:17 +02:00
Yarik Briukhovetskyi
87c54b79ef
revert changes for clickhouse benchmark 2024-04-25 18:34:28 +02:00
Yarik Briukhovetskyi
281fe68622
allow all settings if not --help 2024-04-25 18:28:09 +02:00
Nikita Mikhaylov
6c7752d4c5
Merge pull request #62632 from pakud/patch-1
documenting alternative syntax that's supported for DATE_ADD, DATE_SUB
2024-04-25 15:54:07 +00:00
Nikita Mikhaylov
239f9e2059 Better 2024-04-25 15:50:29 +00:00
Raúl Marín
5b4190f0b5
Merge pull request #62965 from Algunenano/03128_argMin_combinator_projection_flaky
Fix flaky 03128_argMin_combinator_projection
2024-04-25 15:49:01 +00:00
Yarik Briukhovetskyi
d87bd11d41
Update Benchmark.cpp 2024-04-25 17:43:24 +02:00
Yarik Briukhovetskyi
aae67062bf
Update Benchmark.cpp 2024-04-25 17:27:58 +02:00
Nikita Taranov
6a3acd71bb make tets lighter 2024-04-25 16:27:23 +01:00
Yarik Briukhovetskyi
317017c495
small fixes 2024-04-25 17:24:03 +02:00
Yarik Briukhovetskyi
a36d86f63a
add --verbose for help and suggest to use system.settings 2024-04-25 17:01:34 +02:00
Max Kainov
4b6227148f Fuse in Finish Check for MQ 2024-04-25 14:52:42 +00:00
Max K
a5302bf9f3 Revert "Revert "CI: add FT to MQ remove Style from master"" 2024-04-25 14:51:06 +00:00
Konstantin Bogdanov
7326e2a0fa
Fix aborting on IPv6 peer address 2024-04-25 16:44:16 +02:00
Nikolai Kochetov
0038f322e8
Merge pull request #62916 from ClickHouse/fix-prewhere-for-storage-buffer-with-different-types
Fix PREWHERE for StorageBuffer with different source table column types.
2024-04-25 14:40:11 +00:00
Robert Schulze
3051723d0d
Merge pull request #62880 from rschu1ze/revert-revert-62511
Add test for bug 33446
2024-04-25 14:38:05 +00:00
Nikolai Kochetov
e1da9114fb
Merge pull request #62811 from canhld94/fix_cte_final
Fix FINAL modifier is not respected in CTE with analyzer
2024-04-25 14:37:50 +00:00
Mikhail f. Shiryaev
cd9b75e28d
Merge pull request #62919 from ClickHouse/labels-refactoring
Refactor Labels in the CI
2024-04-25 14:30:20 +00:00
Robert Schulze
9e511023c5
Merge remote-tracking branch 'rschu1ze/master' into revert-revert-62511 2024-04-25 14:28:39 +00:00
Raúl Marín
5553e2da65
Merge pull request #62910 from chandrevdw31/master
Updated MindsDB
2024-04-25 14:02:35 +00:00
Nikita Mikhaylov
9c3ebc5a99 Added setting change to the history 2024-04-25 15:39:42 +02:00
yariks5s
0cc404a74c init 2024-04-25 13:39:09 +00:00
Nikita Mikhaylov
2724a08cbc Better 2024-04-25 13:06:09 +00:00
Nikita Mikhaylov
f43a155aa9 Make allow_experimental_database_replicated obsolete. 2024-04-25 13:05:14 +00:00
kssenii
6dc48de031 Fix 2024-04-25 14:55:09 +02:00
Azat Khuzhin
5d72a34561 Add some comments for getAlterMutationCommandsForPart()
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
e5650f8af3 Move add_to_result() out from loop
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
e0b83bde50 Consider alter_conversions_mutations as valid only if part metadata version matches
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
d2a922bd44 Revert "Fix processing INSERT after metadata mutations that had not been applied yet"
The problem is that the atomic counter (alter_conversions_mutations) is
not accounted correctly for IMergeTreeDataPart::getMetadataVersion()

This reverts commit 0124642b39f538eaf2b1c7cfab9a0a917b1b12f6.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
c048ab9d6d Fix processing INSERT after metadata mutations that had not been applied yet
The problem is that right now INSERT may write old columns even after
metadata mutation (i.e. RENAME), because it will simply write the new
block number that is bigger then metadata version, and so this part
won't be mutated.

To fix this, it should get the mutation version from metadata - this is
quite a major change!

Fixes: 2555_davengers_rename_chain
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
Azat Khuzhin
be6777bc86 Reduce overhead of the mutations for SELECTs (v2)
SELECTs are affected by the mutations, since it tries to apply them on
fly, and scanning over existing mutations can take significant amount of
time (for simple queries, i.e. count())

And also even after mutation had been finished, it still a problem,
because mutations are not removed instantly.

So instead introduce an atomic counter alter_conversions_mutations, that
is incremented for new mutations and decremented once mutation
finished/killed, that way once the mutation finished they will not
affect queries.

Here are some numbers for non-RENAME mutations:

    rmt vanilla w/o mutations | queries: 3693, QPS: 494.813
    rmt vanilla w/ mutations  | queries: 2190, QPS: 388.256
    rmt patched w/o mutations | queries: 3168, QPS: 620.061
    rmt patched w/ mutations  | queries: 3155, QPS: 614.424
    mt vanilla w/o mutations  | queries: 3498, QPS: 656.399
    mt vanilla w/ mutations   | queries: 3821, QPS: 600.425
    mt patched w/o mutations  | queries: 5732, QPS: 745.585
    mt patched w/ mutations   | queries: 4719, QPS: 715.034

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:35:21 +02:00
kssenii
773fac5214 Update test 2024-04-25 14:27:42 +02:00
Azat Khuzhin
de2e9f8983 tests: preserve table on exit in 02555_davengers_rename_chain
Rely on clickhouse-test random database cleanup, for debugging

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:15:01 +02:00
Azat Khuzhin
e3218af9e6 tests: make wait_for_all_mutations faster
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:15:01 +02:00
Azat Khuzhin
d1ba0f64bb tests: make 02555_davengers_rename_chain deterministic (by properly waiting for mutations)
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:15:01 +02:00
Azat Khuzhin
6d462c8874 tests: make output better for 02555_davengers_rename_chain
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:15:01 +02:00
Azat Khuzhin
ba5b9380d9 tests: simplify 02555_davengers_rename_chain
- reduce copy-paste
- better bash

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-04-25 14:15:01 +02:00
Robert Schulze
d2c1dfff09
Merge pull request #62543 from tomershafir/cow-examples-assert
Add asserts to COW example programs
2024-04-25 12:07:47 +00:00
Raúl Marín
115103b238 Fix flaky 03128_argMin_combinator_projection 2024-04-25 14:03:58 +02:00
Nikita Mikhaylov
6fe4203d44 Merge branch 'master' of github.com:ClickHouse/ClickHouse into keywords-2 2024-04-25 11:59:06 +00:00
Nikita Mikhaylov
c98b9c350a
Merge pull request #62923 from Blargian/document_lengthUTF8
[Docs] update `length` and `lengthUTF8`
2024-04-25 11:37:32 +00:00
Nikita Mikhaylov
7fef1d728d
Merge pull request #62592 from peter279k/add_try_base_usage
Document functions tryBase58Decode and  tryBase64Decode
2024-04-25 11:30:37 +00:00
Nikita Mikhaylov
5ea95cbbec
Merge branch 'master' into access-controls-enable-by-default 2024-04-25 13:21:23 +02:00
Alexander Tokmakov
e752ebdf9c
Merge pull request #62658 from ClickHouse/install_path
Don't allow relative paths when installing
2024-04-25 11:18:00 +00:00
Nikita Mikhaylov
9b51476399
Merge pull request #61910 from peter279k/fix_pr_60656_install_tests
Fix PR #60656 for install check tests
2024-04-25 11:16:22 +00:00