thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-10-02 06:30:55 +00:00
Code Issues Packages Projects Releases Wiki Activity
21,199 Commits 8,979 Branches 1,767 Tags 1.8 GiB
6fce028b56
Commit Graph

11434 Commits

Author SHA1 Message Date
alexey-milovidov
f6c264b70b
Every function in its own file, part 9 (#3733) 
* Every function in its own file, part 9 [#CLICKHOUSE-2]

* Every function in its own file, part 9 [#CLICKHOUSE-2]
 2018-12-03 06:17:06 +03:00
alexey-milovidov
02636b3388
Merge pull request #3729 from amosbird/dryrun 
Function execution with dry runs
 2018-12-02 22:45:07 +03:00
alexey-milovidov
48b30edcf5
Merge branch 'master' into alter-order-by 2018-12-02 21:06:38 +03:00
alexey-milovidov
af110b8202
Merge pull request #3693 from yandex/simplier_merge_read_logic 
Simplify merge stream read logic
 2018-12-02 20:59:43 +03:00
Amos Bird
3cc0829cc1 Function execution with dry runs 
This commit prevents stateful functions like rowNumberInAllBlocks from being modified in getHeader() calls.
 2018-12-02 19:02:04 +08:00
Amos Bird
65b654a1b6 Versatile StorageJoin 
This commit does the following:

1. StorageJoin with simple keys now supports reading
2. StorageJoin can be created with Join settings applied. Syntax is
similar to MergeTree and Kafka
3. Left Any StorageJoin with one simple key can be used as a
dictionary-like structure by function joinGet.

Examples are listed in the related test file.
 2018-12-02 16:49:39 +08:00
Alexey Milovidov
2930da2880 Every function in its own file, part 8 [#CLICKHOUSE-2] 2018-12-02 05:52:49 +03:00
Alexey Milovidov
70a1275d50 Every function in its own file, part 8 [#CLICKHOUSE-2] 2018-12-02 05:47:47 +03:00
Alexey Milovidov
dbbf148a98 Every function in its own file, part 8 [#CLICKHOUSE-2] 2018-12-02 04:57:01 +03:00
alexey-milovidov
01d39892f5
Merge pull request #3725 from vitlibar/CLICKHOUSE-4127-fix-assertion-in-debug-build 
CLICKHOUSE-4127: Fix assertion in debug build.
 2018-12-02 03:51:46 +03:00
Alexey Milovidov
c9b8cd0626 Fixed errors and improved PR #3724 2018-12-02 03:47:34 +03:00
alexey-milovidov
c5dac3d496
Merge pull request #3724 from ClickHouse-Ninja/master 
timeSlots: add optional parameter 'Size'
 2018-12-02 03:34:52 +03:00
Vitaly Baranov
7c03b35bc4 CLICKHOUSE-4127: Fix assertion in debug build. 
Do reading faster if the structure isn't altered.
 2018-12-01 15:42:56 +03:00
Kirill Shvakov
566644b171 timeSlots: add optional parameter 'Size' 2018-12-01 10:01:20 +02:00
Alexey Milovidov
2cf627457a Fixed error #3720 2018-12-01 05:38:54 +03:00
Alexey Milovidov
b7d9910bd3 Merge branch 'master' into dont-allocate-too-much-memory-to-parse-query 2018-12-01 04:54:01 +03:00
Alexey Milovidov
024a4ba73c Fixed build after merge #3689 2018-12-01 02:52:20 +03:00
alexey-milovidov
bf7b68cf95
Merge pull request #3689 from abyss7/CLICKHOUSE-3936 
CLICKHOUSE-3936
 2018-12-01 01:50:04 +03:00
alexey-milovidov
32b0b61d25
Merge pull request #3699 from amosbird/master 
NonJoinedStream[ALL] bypasses max_block_size
 2018-12-01 01:48:48 +03:00
alexey-milovidov
2a6b7b3d00
Merge pull request #3719 from yandex/fix-buffer-read-locking 
Fix destination table locking for Buffer engine reads
 2018-12-01 01:27:39 +03:00
Alexey Milovidov
be80b7b188 Added suggestion from Nikolay Kochetov #3720 2018-11-30 22:47:47 +03:00
Alexey Milovidov
ca1d38914a Don't log to stderr within RE2 library [#CLICKHOUSE-2] 2018-11-30 22:37:31 +03:00
Persiyanov Dmitriy Andreevich
d982d39b1d remove NameRoundToExp2 & co 2018-11-30 19:13:40 +03:00
Persiyanov Dmitriy Andreevich
be91c76dd2 Merge branch 'master' into feature/roundDown-function 2018-11-30 19:07:49 +03:00
Persiyanov Dmitriy Andreevich
4a48414a5c working with numeric types 2018-11-30 18:57:06 +03:00
Alexey Milovidov
35f6fb5ae6 Avoid memory over-allocation when large value of "max_query_size" is specified [#CLICKHOUSE-4169] 2018-11-30 18:36:41 +03:00
Alexey Zatelepin
2d71338b78 examine structure of the destination table of Buffer storage under lock 2018-11-30 18:34:24 +03:00
Amos Bird
d092d35fa9 NonJoinedStream[ALL] bypasses max_block_size 2018-11-30 22:59:17 +08:00
alexey-milovidov
cee0d48ce6
Merge pull request #3703 from dqminh/fix-empty-fixed-string 
Fix buffer overflow for EmptyImpl with FixedString
 2018-11-30 17:30:35 +03:00
proller
cd2af4b6d2 Update Contributors 2018-11-30 16:49:53 +03:00
Persiyanov Dmitriy Andreevich
5d3034c560 almost works w/ different types 2018-11-30 14:15:58 +03:00
Daniel Dao
eb91b19a99
Fix buffer overflow for EmptyImpl with FixedString 
Signed-off-by: Daniel Dao <dqminh89@gmail.com>
 2018-11-30 02:17:01 +00:00
alesapin
51f73651dd Inject columns after creating header 2018-11-29 18:16:08 +03:00
proller
1cc69100f1 Fix macos build 2018-11-29 17:37:56 +03:00
alesapin
fc379c1d5c Inject column names before types 2018-11-29 15:03:58 +03:00
alesapin
b2fd3e804a Add special logic for alter 2018-11-29 14:55:34 +03:00
alesapin
e2e88324d0 Rename MergeTree streams for select 2018-11-29 12:19:42 +03:00
alesapin
a0862efc17 Merge remote-tracking branch 'origin/master' into simplier_merge_read_logic 2018-11-29 10:58:45 +03:00
Persiyanov Dmitriy Andreevich
614af51fb7 test 2018-11-29 03:32:52 +03:00
alexey-milovidov
9cc36d3d3c
Merge pull request #3692 from yandex/fix-create-table-engine-parsing 
Fix CREATE TABLE engine parsing
 2018-11-29 00:22:20 +03:00
Alexey Milovidov
b4d218a890 Fixed race condition, part 1 (ad-hoc) [#CLICKHOUSE-2] 2018-11-28 21:40:02 +03:00
Alexey Milovidov
97280bb361 Whitespace [#CLICKHOUSE-2] 2018-11-28 21:28:30 +03:00
alesapin
d4059ba507 Inject default column 2018-11-28 20:21:27 +03:00
Nikolai Kochetov
540a99c93a Fix engine parsing in create query. 2018-11-28 19:52:46 +03:00
Alexey Milovidov
f615b062d8 Fixed build [#CLICKHOUSE-2] 2018-11-28 19:29:56 +03:00
Alexey Zatelepin
f425803418 don't overwrite table metadata file in case of offline ALTER after ATTACH [#CLIKCHOUSE-3859] 2018-11-28 19:05:29 +03:00
Ivan
448846fc0d
Merge branch 'master' into CLICKHOUSE-3936 2018-11-28 18:59:57 +03:00
Ivan Lezhankin
8b5a05947c Remove redundant information from RWLock. 
And fix broken exception in some race conditions
 2018-11-28 18:50:52 +03:00
Alexey Zatelepin
57f25e978a update comments and docs [#CLICKHOUSE-3859] 2018-11-28 18:12:44 +03:00
alesapin
23aa6595cd Missed file 2018-11-28 18:05:53 +03:00
alesapin
b7cdd8fe7f Trying to simplify merge reading logic 2018-11-28 18:05:28 +03:00
alexey-milovidov
6f007f45a1
Merge pull request #3673 from yandex/fix-insert-distributed-sync 
Fix insert_distributed_sync
 2018-11-28 17:48:06 +03:00
alexey-milovidov
a4fd7f4eb3
Update configReadClient.h 2018-11-28 17:45:58 +03:00
alexey-milovidov
a991781937
Update configReadClient.cpp 2018-11-28 17:45:01 +03:00
proller
eea1ca8920 Merge remote-tracking branch 'upstream/master' into fix4 2018-11-28 17:42:33 +03:00
proller
7e9d053d5d Benchmark: use client config for ssl options 2018-11-28 17:41:51 +03:00
alexey-milovidov
b8cb6c8f5e
Merge pull request #3687 from yandex/date-type-and-number-comparsion 
Date type and number comparsion
 2018-11-28 17:34:46 +03:00
Alexey Milovidov
52fea90a86 Removed useless code [#CLICKHOUSE-2] 2018-11-28 17:33:40 +03:00
Alexey Zatelepin
1b27fb046d Merge branch 'master' into alter-order-by 
Conflicts:
	dbms/programs/server/Server.cpp
 2018-11-28 16:47:07 +03:00
Alexey Milovidov
3c551b43b8 Updated comment [#CLICKHOUSE-2] 2018-11-28 16:40:24 +03:00
Alexey Zatelepin
9ae79c60e8 get rid of (ASTPtr *) in AlterCommands::apply [#CLICKHOUSE-3859] 2018-11-28 16:34:57 +03:00
Nikolai Kochetov
05ac77dbde Added test with Date and numbers comparsion. 2018-11-28 15:10:01 +03:00
Alexey Zatelepin
ceea7bde2e better names in ZooKeeperNodeCache [#CLICKHOUSE-3859] 2018-11-28 14:40:59 +03:00
proller
dd2371e071 CLICKHOUSE-4137 DictionaryFactory, DictionarySourceFactory (#3653) 
* Split ComplexKeyCacheDictionary to faster compile (part2)

* Dictionaries as lib WIP

* wip

* clean

* Fix build with old capnp

* fix

* wip

* fixes

* fix

* clean

* clean

* clean

* wip

* wip

* wip

* flat

* wip

* cache

* clean

* wip

* faster

* fix style

* fixes

* clean

* clean

* Split CacheDictionary.cpp for faster compile

* fix

* fix

* Less memory usage while compiling

* missing file

* format

* Update registerDictionaries.h

* clean
 2018-11-28 14:37:12 +03:00
Nikolai Kochetov
6bd61d17c9 Disable Date and numeric types comparsion. 2018-11-28 14:11:10 +03:00
Alexey Milovidov
0dfa73221c Removed temporary compatibility fix for Yandex.Metrika. [#CLICKHOUSE-2] 2018-11-28 13:37:08 +03:00
root
6f699e9f94 b 2018-11-28 14:22:21 +08:00
root
5a120db014 Compatible with LowCardinality type data write 2018-11-28 14:19:45 +08:00
root
94164ef250 Compatible with LowCardinality type data write 2018-11-28 12:51:04 +08:00
root
c19199e23e Merge remote-tracking branch 'master/master' 2018-11-28 12:46:25 +08:00
alexey-milovidov
e95bf5d888
Merge pull request #3681 from yandex/fix-low-cardinality-permutation 
Fix low cardinality permutation
 2018-11-27 22:40:38 +03:00
Alexey Milovidov
cdb272848c Fixed typo in comment [#CLICKHOUSE-2] 2018-11-27 21:44:19 +03:00
Alexey Milovidov
b1bc7481d9 Whitespace #3603 2018-11-27 21:43:55 +03:00
alexey-milovidov
a12927a439
Merge pull request #3603 from vitlibar/CLICKHOUSE-4127 
CLICKHOUSE-4127: Fix ALTER of destination table for the BUFFER engine.
 2018-11-27 21:38:40 +03:00
Nikolai Kochetov
65e5494326 Fixed size for LowCardinality dictionary permutation. 2018-11-27 21:08:54 +03:00
alexey-milovidov
b77043c462
Merge pull request #3680 from yandex/background-processing-pool-fix-race-condition 
Fixed race condition in BackgroundProcessingPool
 2018-11-27 20:41:07 +03:00
Alexey Zatelepin
e085bc9816 adapt code of #3609 [#CLICKHOUSE-3859] 2018-11-27 20:07:10 +03:00
Ivan Lezhankin
470f96ce19 Minor refactoring 2018-11-27 19:45:45 +03:00
proller
f1791e94e2
Do not write preprocessed configs to /etc/ (#2443) 2018-11-27 19:11:46 +03:00
proller
1ea31e0491
Fix icu link #3631 (#3671) 2018-11-27 18:34:21 +03:00
Alexey Milovidov
dba43be6c8 Fixed race condition in BackgroundProcessingPool [#CLICKHOUSE-2] 2018-11-27 17:59:10 +03:00
Vitaly Baranov
44ca56c731 CLICKHOUSE-4127: Convert destination table's data when reading from 
StorageBuffer.
 2018-11-27 03:43:58 +03:00
Alexey Milovidov
2115c31dda Fixed wrong exception message [#CLICKHOUSE-2] 2018-11-26 20:11:04 +03:00
alexey-milovidov
7e9e5c383a
Merge pull request #3670 from abyss7/CLICKHOUSE-3766 
Rename method partition() → alterPartition()
 2018-11-26 20:09:37 +03:00
alexey-milovidov
a7d75c527b
Merge pull request #3652 from yandex/unquote-partition 
Don't quote single-field partition keys
 2018-11-26 19:57:01 +03:00
alexey-milovidov
e00ce0bb57
Every function in its own file, part 7 (#3666) 
* Every function in its own file, part 7 [#CLICKHOUSE-2]

* Every function in its own file, part 7 [#CLICKHOUSE-2]

* Every function in its own file, part 7 [#CLICKHOUSE-2]

* Every function in its own file, part 7 [#CLICKHOUSE-2]

* Every function in its own file, part 7 [#CLICKHOUSE-2]

* Fixed build #3666
 2018-11-26 19:20:40 +03:00
Alexey Zatelepin
01501fa8db correct column list for rewritten INSERT query into Distributed [#CLICKHOUSE-4161] 2018-11-26 17:57:25 +03:00
Ivan Lezhankin
73aa7f2027 Rename method partition() → alterPartition() 
Also fix build with internal shared libraries.
 2018-11-26 17:43:40 +03:00
Alexey Milovidov
e793a27cc3 Restored old test util #3665 2018-11-26 16:57:54 +03:00
Alexey Zatelepin
d3d9242462 Merge branch 'master' into alter-order-by 
Conflicts:
	dbms/src/Parsers/ASTAlterQuery.h
	dbms/src/Parsers/ParserAlterQuery.cpp
	dbms/src/Storages/AlterCommands.cpp
	dbms/src/Storages/AlterCommands.h
 2018-11-26 16:01:48 +03:00
Alexey Zatelepin
3a3dda5ec5 use standard Tuple serialization [#CLICKHOUSE-4054] 2018-11-26 15:41:17 +03:00
Alexey Milovidov
5a0feee45e Removed "conditional computations" feature, because it is not ready #2272 2018-11-26 04:39:04 +03:00
Alexey Milovidov
c77930fe30 Whitespaces [#CLICKHOUSE-2] 2018-11-26 03:56:50 +03:00
alexey-milovidov
0b2848b0f2
Merge pull request #3662 from yandex/fixed-error-in-lower-upper-utf8 
Fixed error in lowerUTF8 and upperUTF8 functions
 2018-11-26 02:24:41 +03:00
alexey-milovidov
5b1eaba276
Every function in its own file, part 6 (#3661) 
* Every function in its own file, part 6 [#CLICKHOUSE-2]

* Every function in its own file, part 6 [#CLICKHOUSE-2]

* Every function in its own file, part 6 [#CLICKHOUSE-2]
 2018-11-26 02:24:26 +03:00
Alexey Milovidov
4cb7f2896c Fixed error in lowerUTF8 and upperUTF8 functions [#CLICKHOUSE-2] 2018-11-26 01:26:36 +03:00
chenxing.xc
ff6e849c0f address review comments | 2018-11-25 12:22:01 +08:00
Alexey Milovidov
68e0a687c8 Removed unused method [#CLICKHOUSE-2] 2018-11-25 04:24:03 +03:00
Alexey Milovidov
5a045ff11c Fixed error in URL functions [#CLICKHOUSE-2] 2018-11-25 03:31:24 +03:00
Alexey Milovidov
b53c1ea913 Removed useless include [#CLICKHOUSE-2] 2018-11-25 03:16:14 +03:00
Alexey Milovidov
af9ad0f8ae Fixed bad code [#CLICKHOUSE-2] 2018-11-25 03:15:43 +03:00
Alexey Milovidov
141e9799e4 Fixed error with "extractURLParameter" function (read after buffer); improved performance; added support for zero bytes in URLs; renamed Chars_t type [#CLICKHOUSE-2] 2018-11-25 03:08:50 +03:00
Alexey Milovidov
73e3a7b662 Fixed bad code; added generic implementation for "arrayReverse" function; added test [#CLICKHOUSE-3] 2018-11-24 06:14:54 +03:00
Alexey Milovidov
7d6fffff48 More style checks [#CLICKHOUSE-3] 2018-11-24 04:48:06 +03:00
Alexey Milovidov
e82241553a Merge branch 'master' of github.com:yandex/ClickHouse 2018-11-24 04:20:37 +03:00
Alexey Milovidov
bbed8a8ca8 Fixed bad code [#CLICKHOUSE-3] 2018-11-24 04:20:27 +03:00
alexey-milovidov
bedca47bca
Merge pull request #3649 from yandex/low-cardinaliry-left-array-join 
Low cardinaliry left array join
 2018-11-24 04:16:38 +03:00
alexey-milovidov
905a4ffc04
Merge pull request #3651 from yandex/fix-functions-with-low-cardinality-argument-and-array-result 
Fix functions with low cardinality argument and array result
 2018-11-24 04:15:20 +03:00
proller
ad6ae4fdbe Fix build on mac (caused by #3631) (#3654) 
* Fix build on mac (caused by #3631)

* fix
 2018-11-24 04:15:00 +03:00
Alexey Milovidov
cc06488ddc Whitespace #2601 2018-11-24 03:10:51 +03:00
Alexey Milovidov
1e449b2e16 Added another compatibility alias #3638 2018-11-24 02:14:18 +03:00
Alexey Milovidov
954c974507 Added "POWER" alias to "pow" function; made some math functions case insensitive for compatibility #3638 2018-11-24 00:14:28 +03:00
alexey-milovidov
507990d5f2
Merge branch 'master' into master 2018-11-23 23:41:38 +03:00
Alexey Milovidov
af6f91e762 Added comment #3350 2018-11-23 22:47:15 +03:00
Alexey Milovidov
62e30de715 Whitespaces #3350 2018-11-23 21:54:23 +03:00
Alexey Milovidov
dbbacf4f87 Added more style checks [#CLICKHOUSE-3] 2018-11-23 21:52:00 +03:00
alexey-milovidov
af013285e9
Merge branch 'master' into base64_functions 2018-11-23 21:33:56 +03:00
Nikolai Kochetov
560e0a04d0 Fix functions with low cardinality argumant and array result. 2018-11-23 19:09:07 +03:00
Nikolai Kochetov
de16f36256 Fix functions with low cardinality argumant and array result. 2018-11-23 18:59:45 +03:00
alexey-milovidov
ac29388224
Merge pull request #3632 from yandex/fix-low-cardinality-distributed-group-by 
Fix low cardinality distributed group by
 2018-11-23 16:45:56 +03:00
alexey-milovidov
0822f500f8
Merge pull request #3642 from yandex/odbc_bridge_die_with_server 
ODBC bridge die with server
 2018-11-23 16:44:53 +03:00
alexey-milovidov
c6bc4279ee
Merge pull request #3377 from s-mx/CLICKHOUSE-4032 
Added support for column COMMENTs in table definition.
 2018-11-23 16:43:58 +03:00
Nikolai Kochetov
449ab47350 Disable low cardinality default implementation for emptyArrayToSingle function. 2018-11-23 16:29:14 +03:00
Nikolai Kochetov
f3aa1292a9 Remove null map cache from ColumnUnique. 2018-11-23 14:55:06 +03:00
Nikolai Kochetov
d64fe4204a Remove null map cache from ColumnUnique. 2018-11-23 13:47:01 +03:00
Nikolai Kochetov
e74b1edb35 Remove null map cache from ColumnUnique. 2018-11-23 13:18:50 +03:00
alesapin
7f40494330 Enable keep alive only with patched poco 2018-11-23 12:24:59 +03:00
Nikolai Kochetov
7fea1397d6 Remove null map cache from ColumnUnique. 2018-11-23 11:11:54 +03:00
alesapin
d31d30c8e1 Fix comments, naming, log about kill inability and better test 2018-11-23 11:08:35 +03:00
alexey-milovidov
3729c4e532
Update ReadBufferFromHDFS.h 2018-11-23 03:20:33 +03:00
alexey-milovidov
1002ed7487
Merge branch 'master' into 3958/many_templates 2018-11-23 01:48:42 +03:00
alexey-milovidov
429d65e4f7
Update StorageReplicatedMergeTree.h 2018-11-23 01:08:00 +03:00
alexey-milovidov
6d7aa73e44
Update StorageReplicatedMergeTree.cpp 2018-11-23 01:07:35 +03:00
alexey-milovidov
9580a87409
Update StorageReplicatedMergeTree.cpp 2018-11-23 01:06:02 +03:00
alexey-milovidov
6f1846f1cc
Update StorageReplicatedMergeTree.cpp 2018-11-23 01:05:36 +03:00
alexey-milovidov
65e6d447b8
Update StorageReplicatedMergeTree.cpp 2018-11-23 01:04:25 +03:00
alexey-milovidov
4cfb51b14e
Update StorageReplicatedMergeTree.cpp 2018-11-23 01:03:51 +03:00
Alexey Milovidov
c0e97a97cd Resolved inconsistencies in documentation #3539 2018-11-23 01:00:03 +03:00
alexey-milovidov
12045a0e0e
Merge pull request #3641 from yandex/fix-array-mapped-functions-with-low-cardinality-lambda 
Fix array mapped functions with low cardinality lambda
 2018-11-23 00:40:16 +03:00
alexey-milovidov
733ab51089
Merge pull request #3643 from yandex/fix-parallel-inputs-processor-deadlock 
Fix deadlock in ParallelInputsProcessor in case thread creation fails.
 2018-11-23 00:30:01 +03:00
Alexey Milovidov
64c6951b1a More correct documentation #3644 2018-11-23 00:28:38 +03:00
Alexey Milovidov
d3bb69be74 More correct documentation + miscellaneous name change #3644 2018-11-23 00:27:52 +03:00
alexey-milovidov
49d2d8a1b8
Merge pull request #3644 from proller/fix4 
Add VERSION_INT (ClickHouse version in integer format like 18014009) …
 2018-11-23 00:22:19 +03:00
alexey-milovidov
2c2d75cceb
Don't allow exceptions without code (#3645) 
* Don't allow exceptions without code #3633

* Don't allow exceptions without code #3633
 2018-11-23 00:19:58 +03:00
alexey-milovidov
b680029030
Update ColumnsDescription.cpp 2018-11-22 22:36:56 +03:00
proller
f410c93fb1 Add VERSION_INT (ClickHouse version in integer format like 18014009) to system.metrics and system.build_options 2018-11-22 21:24:38 +03:00
Alexey Milovidov
a5d1fc0ca7 Removed unused constructor #3633 2018-11-22 21:09:17 +03:00
Alexey Zatelepin
8b25084637 fix deadlock in ParallelInputsProcessor in case thread creation fails [#CLICKHOUSE-4155] 2018-11-22 20:29:49 +03:00
alesapin
2b2195d4de Fix stupid if 2018-11-22 19:01:17 +03:00
alesapin
1e879850bb Kill odbc-bridge with clickhouse-server 2018-11-22 18:59:00 +03:00
Nikolai Kochetov
4721b16b51 Fix array mapped functions with low cardinality lambda argument. 2018-11-22 18:52:53 +03:00
Alexey Milovidov
7b919c9b2b Removed unused constructor #3633 2018-11-22 18:09:19 +03:00
Sabyanin Maxim
3a67b505c5 Merge branch 'master' of https://github.com/yandex/ClickHouse into CLICKHOUSE-4032 2018-11-22 16:54:10 +03:00
Sabyanin Maxim
060fce3899 make ReplicatedMergeTree work with comments. ignore empty comments when make column_comments hashmap 2018-11-22 16:51:43 +03:00
Alexey Milovidov
ab5d76fc42 Fixed error introduced in #3553 and prevent it happening 2018-11-21 23:56:37 +03:00
Alexey Milovidov
6f48ebbb06 Better exception message in case of "unknown identifier" [#CLICKHOUSE-4142] 2018-11-21 23:35:55 +03:00
proller
1d40c2c871 Better link and deps (#3631) 
* try fix 1

* Better deps

* fix

* fix

* fix

* Update CMakeLists.txt

* Update CMakeLists.txt

* fix

* fix

* fix

* disable old

* Update find_odbc.cmake
 2018-11-21 22:20:27 +03:00
Nikolai Kochetov
4d96e88058 Fix distributed group by LowCardinality(Nullable). #3615 2018-11-21 21:59:33 +03:00
小路
0bf4aa46db
Merge branch 'master' into click_update 2018-11-21 22:40:05 +08:00
Persiyanov Dmitriy Andreevich
b3e694e3eb ugly version 2018-11-21 13:10:22 +03:00
alexey-milovidov
5038f13b08
Merge pull request #3514 from abyss7/CLICKHOUSE-3766 
Implement 'ALTER … FREEZE' command
 2018-11-21 07:17:21 +03:00
alexey-milovidov
0bc9776e2a
Update Cluster.cpp 2018-11-21 07:06:40 +03:00
alexey-milovidov
af8db3e9ec
Update Cluster.h 2018-11-21 07:04:53 +03:00
alexey-milovidov
96fdc2a390
Update Cluster.h 2018-11-21 07:04:24 +03:00
alexey-milovidov
5ee36769db
Update Cluster.cpp 2018-11-21 07:04:05 +03:00
alexey-milovidov
5cf9beabe3
Update StorageDistributed.cpp 2018-11-21 07:02:56 +03:00
alexey-milovidov
866917ad32
Update Cluster.cpp 2018-11-21 07:02:19 +03:00
chenxing.xc
86f1a18185 withdraw INSERT INFILE feature 2018-11-21 11:59:24 +08:00
alexey-milovidov
f67e54dbf3
Merge pull request #3594 from yandex/CLICKHOUSE-4112 
Add http connection pool between replicas
 2018-11-21 06:57:22 +03:00
alexey-milovidov
235dc66881
Merge pull request #3564 from amosbird/master 
Implement dictGet[OrDefault]
 2018-11-21 06:48:10 +03:00
alexey-milovidov
0d627c7230
Update FunctionsExternalDictionaries.h 2018-11-21 06:48:01 +03:00
alexey-milovidov
9b0226a73d
Merge pull request #3588 from zhang2014/fix/predicate 
ISSUES-1777 qualified subqueries when optimize predicate
 2018-11-21 06:20:37 +03:00
Alexey Milovidov
7febe64c82 Failproof #3589 2018-11-21 06:19:29 +03:00
Alexey Milovidov
7e6d9ed82b Correct calculation of avg_value_size_hint #3589 2018-11-21 06:18:42 +03:00
Alexey Milovidov
31561ef25a Fixed error; added test #3589 2018-11-21 06:09:56 +03:00
Alexey Milovidov
2cef50669a Better error message #3589 2018-11-21 05:40:23 +03:00
Alexey Milovidov
2662594865 Attempt to fight back performance of firstSignificantSubdomain function #3601 2018-11-21 03:46:06 +03:00
alexey-milovidov
8590348dc6
Merge pull request #3601 from hatarist/patch-1 
Update firstSignificantSubdomain function
 2018-11-21 03:00:59 +03:00
alexey-milovidov
87e5d40858
Merge pull request #3626 from yandex/types-clarification 
More clean NearestFieldType.
 2018-11-21 02:55:46 +03:00
Alexey Milovidov
78e72a1962 Little better #3624 2018-11-20 23:09:20 +03:00
alexey-milovidov
a41485f69d
Merge pull request #3624 from yandex/types-clarification 
Fixed code that was not quite correct
 2018-11-20 22:37:10 +03:00
alexey-milovidov
596e136b73
Update InterpreterInsertQuery.cpp 2018-11-20 21:36:13 +03:00
alexey-milovidov
8ff62c9da6
Update InterpreterInsertQuery.cpp 2018-11-20 21:31:39 +03:00
alexey-milovidov
7a98d55415
Update ReadBufferFromHDFS.h 2018-11-20 21:31:21 +03:00
alexey-milovidov
5e0b679f04
Merge pull request #3620 from proller/fix13 
Fix build with old capnp
 2018-11-20 21:19:40 +03:00
alexey-milovidov
98ed411da3
Update Field.h 2018-11-20 20:37:50 +03:00
Alexey Milovidov
38d2e9efa2 Fixed code that was not quite correct 2018-11-20 20:36:21 +03:00
alesapin
57ea89c5f3 Merge branch 'master' into CLICKHOUSE-4112 2018-11-20 20:23:08 +03:00
alesapin
f08e090bda Better uri scheme check and fix in poco submodule 2018-11-20 20:21:32 +03:00
Ivan Lezhankin
1e070a7c51 Move FREEZE_ALL command source code inside |PartitionCommand| 2018-11-20 20:13:59 +03:00
Marek Vavruša
8fad726d95 Added null guards for all CurrentThread::attachToIfDetached() 
refs #3622
 2018-11-20 09:10:34 -08:00
proller
2deb523265 Fix build with old capnp 2018-11-20 18:10:28 +03:00
Ivan Lezhankin
74fe350451 Refactor partition commands handling into separate interface method. 2018-11-20 17:59:34 +03:00
alesapin
00f1329c59 Merge branch 'master' of github.com:yandex/ClickHouse 2018-11-20 17:04:07 +03:00
alexey-milovidov
a008a41374
Merge pull request #3609 from s-mx/CLICKHOUSE-4090 
Add primary_key, order_key, partition_key and sample_key to system.tables.
 2018-11-20 16:39:54 +03:00
alesapin
01e2137364 CLICKHOUSE-4112: Add keepalive for http connections 2018-11-20 16:15:44 +03:00
Sabyanin Maxim
7d175e4666 Merge branch 'CLICKHOUSE-4090' of github.com:s-mx/ClickHouse into CLICKHOUSE-4090 2018-11-20 15:22:54 +03:00
Sabyanin Maxim
e3fc18fcb8 add getters of expressions names in StorageReplicatedMergeTree 2018-11-20 15:19:12 +03:00
chenxing.xc
939368cf08 Merge remote-tracking branch 'hdfs/master' 2018-11-20 19:28:40 +08:00
root
3df876d541 better 2018-11-20 19:02:45 +08:00
root
e7e94826a7 Merge branch 'update_22' of https://github.com/nicelulu/ClickHouse into update_22 2018-11-20 18:59:19 +08:00
root
811c7e9aef better 2018-11-20 18:55:40 +08:00
root
f69524cf49 better 2018-11-20 18:50:42 +08:00
小路
74579138b8
Merge branch 'click_update' into update_22 2018-11-20 16:51:55 +08:00
root
cc7ec374d5 better 2018-11-20 16:10:33 +08:00
alexey-milovidov
6aa2313dec
Merge pull request #3580 from abyss7/fix-quantile-datetime 
Some fixes to quantile*() functions related to DateTime argument type
 2018-11-19 21:28:06 +03:00
alexey-milovidov
de5d4b6256
Update AggregateFunctionQuantile.h 2018-11-19 21:25:57 +03:00
Sabyanin Maxim
4ac727e7ad fix style 2018-11-19 20:21:34 +03:00
alexey-milovidov
72fb78a0f8
Update StorageBuffer.cpp 2018-11-19 18:20:34 +03:00
alexey-milovidov
9a3701cc50
Update StorageBuffer.cpp 2018-11-19 18:20:05 +03:00
alexey-milovidov
33eb64269f
Update StorageBuffer.cpp 2018-11-19 18:14:44 +03:00
Alexey Milovidov
c843bc1d58 utils/check-style/check-style -n 2018-11-19 18:09:19 +03:00
alexey-milovidov
5a40a67500
Update StorageSystemColumns.cpp 2018-11-19 18:07:43 +03:00
alexey-milovidov
6ad4519c81
Update IStorage.h 2018-11-19 18:05:48 +03:00
Sabyanin Maxim
08fc057a15 make is_in_primary_key and etcetera work. add test. 2018-11-19 17:31:16 +03:00
Ivan Lezhankin
b63f0a5a9f Minor refactoring 2018-11-19 17:25:42 +03:00
Alexey Milovidov
2f3b4ba851 Better exception message [#CLICKHOUSE-4143] 2018-11-19 15:31:26 +03:00
chenxing.xc
76843c2dc0 hdfs read support 2018-11-19 16:17:09 +08:00
Vitaly Baranov
a029034d8c CLICKHOUSE-4127: Fix ALTER of destination table for the BUFFER engine. 2018-11-19 09:14:36 +03:00
alexey-milovidov
e7fb653d0c
Update HTTPCommon.cpp 2018-11-19 01:20:36 +03:00
alexey-milovidov
f35d300d33
Update HTTPCommon.cpp 2018-11-19 01:15:42 +03:00
alexey-milovidov
786bf36aee
Update DDLWorker.cpp 2018-11-19 01:04:11 +03:00
Igor Hatarist
faa4cac4da
Update firstSignificantSubdomain function 
Added gov, mil, edu 2nd level domains
 2018-11-18 06:37:43 +03:00
proller
ddf231e57f BI-154 Fix isLocal detection 2018-11-17 21:52:47 +03:00
nicelulu
f96111b423 Fixed the way to get username and password. 2018-11-17 22:03:32 +08:00
chertus
b4b58b292f remove hack for StorageDistributed & insert_sample_with_metadata 2018-11-16 22:19:47 +03:00
alesapin
2a4a8d180b Try to change stupid naming 2018-11-16 16:33:43 +03:00
alesapin
0266f058c9 Merge branch 'master' into CLICKHOUSE-4112 2018-11-16 16:21:27 +03:00
alesapin
d4ce674b93 Add http connection pool between replicas 2018-11-16 16:15:17 +03:00
proller
160ffb2283
Build fixes (clang 7.0.0+) (#3582) 2018-11-16 15:22:51 +03:00
Sabyanin Maxim
49dc9939d4 fix serializing of ColumnsDescription 2018-11-16 15:01:52 +03:00
Gleb Kanterov
1b8e5f9b47 Optimization to skip unused shards for Distributed engine 
Hide behind `distributed_optimize_skip_select_on_unused_shards` setting.
 2018-11-16 10:21:06 +00:00
chertus
811b824b01 AddingDefaultsBlockInputStream fixed types optimisation 2018-11-15 23:26:51 +03:00
chertus
c642e16ee1 clearer evaluateMissingDefaults [CLICKHOUSE-3578] 2018-11-15 19:57:20 +03:00
chertus
13646eb4c4 move BlockMissingValues from Block to IBlockInputStream::getMissingValues() 2018-11-15 18:57:20 +03:00
zhang2014
c23447ba3a ISSUES-1777 qualified subqueries when optimize predicate 2018-11-15 23:23:44 +08:00
chertus
65d34ca231 do not override current_database in context [CLICKHOUSE-3578] 2018-11-15 18:03:13 +03:00
Amos Bird
eec50adbeb Implement dictGet[OrDefault] 2018-11-15 21:48:00 +08:00
Sabyanin Maxim
d9e6789f78 make MergeTree work with comments 2018-11-15 16:12:27 +03:00
chertus
5c67e02205 fix build 2018-11-15 13:39:13 +03:00
chertus
8284de8268 fix build 2018-11-15 13:32:20 +03:00
chertus
0e1044b165 Merge branch 'master' into issue-3578 2018-11-15 13:28:53 +03:00
Amos Bird
9021bfb2f1 Fix variant assignments 2018-11-15 17:29:53 +08:00
Sabyanin Maxim
035049d1a8 make modify column comment work 2018-11-15 01:46:39 +03:00
chertus
ebf3d60186 column defaults without CapNProto [CLICKHOUSE-3578] 2018-11-14 21:20:16 +03:00
Alexey Zatelepin
b071547b2d add checks for ALTER MODIFY ORDER BY [#CLICKHOUSE-3859] 2018-11-14 20:12:32 +03:00
Ivan Lezhankin
fc272ecded Some fixes to quantile*() functions related to DateTime argument type 2018-11-14 18:04:23 +03:00
Alexandr Krasheninnikov
177a00f09a Merge https://github.com/yandex/ClickHouse into base64_functions 2018-11-14 12:32:42 +03:00
Alexandr Krasheninnikov
050abdf2b6 Auto detect of codec 2018-11-14 12:07:20 +03:00
Alexey Milovidov
e3b0cecdec Merge branch 'master' of github.com:yandex/ClickHouse 2018-11-14 04:59:40 +03:00
Alexey Milovidov
2daab83a23 Fixed bad and wrong code #3553 2018-11-14 04:59:32 +03:00
alexey-milovidov
3b2cd38beb
Merge pull request #3570 from yandex/fix-with-with-alias-only 
Fix WITH with alias only
 2018-11-14 04:22:38 +03:00
proller
37a9af5a68 CLICKHOUSE-4109 mlock clickhouse (#3553) 
* CLICKHOUSE-4109 mlock clickhouse

* wip

* Fix

* wip

* fix

* fix

* better place

* wip

* clean

* tidy

* fix
 2018-11-14 04:11:13 +03:00
Alexey Milovidov
d3349ebde8 Merge branch 'master' of github.com:yandex/ClickHouse 2018-11-14 04:04:29 +03:00
Alexey Milovidov
d1b86225ef Fixed bad code #3565 2018-11-14 04:04:09 +03:00
alexey-milovidov
2f16ec5c79
Merge pull request #3568 from yandex/fix-low-cardinality-nullable-perf 
Fix perf in IColumnUnique::size func.
 2018-11-14 03:27:05 +03:00
Alexey Milovidov
ead153e9e4 Better code #3565 2018-11-13 22:48:47 +03:00
Alexey Milovidov
69e57187d2 Fixed error; removed unique_ptr #3565 2018-11-13 22:43:17 +03:00
Sabyanin Maxim
3e4c981db2 small changes 2018-11-13 22:17:40 +03:00
Alexey Milovidov
4b0645cb25 Fixed error in #3565 2018-11-13 21:41:07 +03:00
chertus
9d3325f56e one more fix for bad merge of branches 2018-11-13 16:36:53 +03:00
Alexey Zatelepin
29b34365e6 Merge branch 'master' into alter-order-by 
Conflicts:
	dbms/src/Interpreters/ExpressionAnalyzer.cpp
	dbms/src/Storages/MergeTree/MergeTreeData.cpp
	dbms/src/Storages/MergeTree/MergeTreeDataSelectExecutor.cpp
 2018-11-13 16:27:19 +03:00
Alexey Zatelepin
2cc0aae82c rearrange AST members in MergeTreeData [#CLICKHOUSE-3859] 2018-11-13 16:15:17 +03:00
Alexey Zatelepin
7167bfd7b3 fix prewhere with FINAL for VersionedCollapsingMergeTree [#CLICKHOUSE-3859] 2018-11-13 16:15:12 +03:00
Alexey Zatelepin
8b85822192 store original key ASTs, and not extracted ASTExpressionLists [#CLICKHOUSE-3859] 2018-11-13 16:14:44 +03:00
Alexey Zatelepin
31a6a6b4fd calculate ReplicatedMergeTreeTableMetadata diff [#CLICKHOUSE-3859] 2018-11-13 16:13:55 +03:00
Alexey Zatelepin
74c48ed226 apply metadata changes on startup [#CLICKHOUSE-3859] 2018-11-13 16:13:50 +03:00
Alexey Zatelepin
96d7eee785 fix use-after-free in ZooKeeperNodeCache [#CLICKHOUSE-3859] 2018-11-13 16:13:46 +03:00
Alexey Zatelepin
106800b857 apply changes in ReplicatedMergeTreeAlterThread [#CLICKHOUSE-3859] 2018-11-13 16:13:40 +03:00
Alexey Zatelepin
4036ec83af write metadata znode in StorageReplicatedMergeTree::alter() [#CLICKHOUSE-3859] 2018-11-13 16:13:34 +03:00
Alexey Zatelepin
ce1ead5b88 allow arbitrary callbacks in ZooKeeperNodeChange [#CLICKHOUSE-3859] 2018-11-13 16:13:29 +03:00
Alexey Zatelepin
a0a9aad777 Stat data in ZooKeeperNodeCache [#CLICKHOUSE-3859] 2018-11-13 16:13:23 +03:00
Alexey Zatelepin
0c0c4fd28d add sorting_and_primary_keys_independent [#CLICKHOUSE-3859] 2018-11-13 16:13:19 +03:00
Alexey Zatelepin
07a22100cb ALTER ORDER BY for ordinary MergeTree [#CLICKHOUSE-3859] 2018-11-13 16:13:14 +03:00
Alexey Zatelepin
02337242b5 ALTER MODIFY ORDER BY syntax [#CLICKHOUSE-3859] 2018-11-13 16:13:10 +03:00
Alexey Zatelepin
c4bf38ef07 comments [#CLICKHOUSE-3859] 2018-11-13 16:13:06 +03:00
Alexey Zatelepin
f4c26e78d2 renames [#CLICKHOUSE-3859] 2018-11-13 16:13:01 +03:00
Alexey Zatelepin
0fa86162d9 separate sorting key and primary key, allow setting primary key separately [#CLICKHOUSE-3859] 2018-11-13 16:12:55 +03:00
Alexey Zatelepin
9a92c0a55c sort key is distinct from primary key [#CLICKHOUSE-3859] 2018-11-13 16:12:49 +03:00
Alexey Zatelepin
580146eedb add primary key syntax [#CLICKHOUSE-3859] 2018-11-13 16:12:14 +03:00
Sabyanin Maxim
6296f58186 fix typo 2018-11-13 15:22:32 +03:00
Sabyanin Maxim
befaea63d2 add is_mutable method to AlterCommand. change comment column test 2018-11-13 15:08:07 +03:00
Nikolai Kochetov
986d490435 Comments. 2018-11-12 21:33:39 +03:00
Nikolai Kochetov
97d9ce5193 Fix WITH with single alias. #2465 2018-11-12 21:28:32 +03:00
chertus
c1518da50f fix build with CAPNP 2018-11-12 20:29:02 +03:00
Sabyanin Maxim
b869cfed9a fixed couple of mistakes. 2018-11-12 18:45:35 +03:00
Alexey Milovidov
03c35f2aa4 Remove Analyzers because it was failed refactoring attempt [#CLICKHOUSE-2] 2018-11-12 18:40:33 +03:00
chertus
af4cceb877 make branch up to date 2018-11-12 18:25:21 +03:00
chertus
9966f975a3 Merge branch 'master' into issue-3578 2018-11-12 17:58:00 +03:00
chertus
2fe3cdb3f5 restore lost commits [CLICKHOUSE-3578] 2018-11-12 17:52:30 +03:00
Ivan Lezhankin
4eb0f33ec2 Add some locks on freeze and support |freezeAll()| for replicated merge-tree. 2018-11-12 15:26:15 +03:00
Ivan Lezhankin
baf9566413 Fix style 2018-11-12 15:26:15 +03:00
Ivan Lezhankin
5d3da110a8 Refactor |freezePartition()| and |freezeAll()| 2018-11-12 15:26:15 +03:00
abyss7
0cdb808ded Fix comments 2018-11-12 15:26:15 +03:00
Ivan Lezhankin
b01acc8917 Fix style 2018-11-12 15:26:15 +03:00
Ivan Lezhankin
56f0f6194f Refactor parsing of 'WITH NAME' 2018-11-12 15:26:14 +03:00
Ivan Lezhankin
126ff55fa7 Forgot about 'WITH NAME …' statement part. 2018-11-12 15:26:14 +03:00
Ivan Lezhankin
935615a647 Reimplement FREEZE command. 2018-11-12 15:26:14 +03:00
Ivan Lezhankin
a837060454 Lock table structure before freezing. 2018-11-12 15:26:14 +03:00
Ivan Lezhankin
03e6a29eb2 Implement 'ALTER … FREEZE' command. 
Need some tests!
 2018-11-12 15:26:14 +03:00
Nikolai Kochetov
3429274de1 Fix perf in IColumnUnique::size func. #3256 2018-11-12 12:03:40 +03:00
KochetovNicolai
5f3dcf794a
Merge pull request #3551 from yandex/syntax-analyzer-2 
Split ExpressionAnalyzer and SyntaxAnalyzer.
 2018-11-12 11:43:52 +03:00
Amos Bird
6815b25d18 replace std::tuple with std::variant 2018-11-12 03:29:52 +08:00
Amos Bird
f76bfb00a3 Avoid materialization for dictGetTOrDefault 2018-11-12 00:35:13 +08:00
Sabyanin Maxim
94594d8c06 add order_key section in system.tables 2018-11-11 18:44:21 +03:00
proller
5678d1ed98 Build fixes (#3545) 
* StorageSystemContributors clean

* Fix

* ARM fixes

* Fix arm compile

* fix

* Fix macos?

* Fix includes

* fix

* fix

* Try fix apple build part 1

* Fix identation

* Fix static libc++ in clang

* fix arm build

* better

* fix

* fix

*  better check-include
 2018-11-10 23:09:07 +03:00
alexey-milovidov
93a3f1663e
Merge pull request #3552 from amosbird/patch-14 
Prioritize rvalue creator for ColumnTuple
 2018-11-10 22:57:55 +03:00
Alexey Milovidov
60d42eb4f7 Merge branch 'master' of github.com:yandex/ClickHouse 2018-11-10 20:52:32 +03:00
Alexey Milovidov
8f50c62033 Avoid busy loop in DDLWorker when ZooKeeper is not available [#CLICKHOUSE-4126] 2018-11-10 20:52:25 +03:00
Nikolai Kochetov
28be6d6443 Review fixes. 2018-11-09 20:23:48 +03:00
Sabyanin Maxim
9befbd94e4 is_in_order_key, is_in_partition_key, is_in_sample_key in system.columns works, is_in_primary_key not yet 2018-11-09 18:39:21 +03:00
Nikolai Kochetov
1e9aeba603 Split ExpressionAnalyzer and SyntaxAnalyzer. 2018-11-09 18:01:18 +03:00
Sabyanin Maxim
ac6aaa37b5 add is_primary_key, is_order_key, is_partition_key, is_sampling_key sections in system.columns 2018-11-09 15:02:08 +03:00
chertus
cc005c3ac9 Merge branch 'master' into issue-3578 2018-11-09 13:12:34 +03:00
Sabyanin Maxim
51c7284583 add getSecondaryExpression 2018-11-09 12:41:52 +03:00
Sabyanin Maxim
c9d8dc6171 add primary_key, partition_key, sampling_key sections in system.tables. add getPartitionExpression method in IStorage. 2018-11-08 20:45:41 +03:00
Amos Bird
076ec44089
Prioritize rvalue creator for ColumnTuple 
This validates `ColumnTuple::create(Columns({std::move(s_c0), std::move(s_c1)})); `
 2018-11-09 01:24:30 +08:00
Nikolai Kochetov
726ae0cb9a Split ExpressionAnalyzer and SyntaxAnalyzer. 2018-11-08 19:47:12 +03:00
KochetovNicolai
4609569538
Merge pull request #3549 from yandex/syntax-analyzer 
Syntax analyzer
 2018-11-08 17:15:37 +03:00
Nikolai Kochetov
baef5abc12 Review fixes. 2018-11-08 15:06:35 +03:00
Sabyanin Maxim
f8f2779f7b make ColumnComment just a hashmap 2018-11-08 15:03:42 +03:00
Nikolai Kochetov
29fe5ea5b6 Review fixes. 2018-11-08 14:17:31 +03:00
Nikolai Kochetov
90120493bf Syntax analyzer (in progress). 2018-11-08 12:06:11 +03:00
Nikolai Kochetov
a5a36d0078 Syntax analyzer (in progress). 2018-11-08 12:01:41 +03:00
Nikolai Kochetov
6ebfd2c42f Syntax analyzer (in progress). 2018-11-08 12:01:12 +03:00
proller
9a98b80cf8 Try fix apple build part 2 2018-11-07 16:24:36 +03:00
proller
a996326efe Fix identation 2018-11-07 15:55:56 +03:00
Nikolai Kochetov
7f8deccd7e Merged with master. 2018-11-07 15:52:16 +03:00
proller
bb1dafd2b3 Try fix apple build part 1 2018-11-07 15:50:36 +03:00
Nikolai Kochetov
748b0f7077 SyntaxAnalyzer (in progress). 2018-11-07 15:44:05 +03:00
chertus
9819c10628 fix build with libcxx 2018-11-07 14:46:39 +03:00
Nikolai Kochetov
7a5cfc7a6d Skip columns from prewhere_info->remove_columns_actions in prewhere result for alias source columns. [#CLICKHOUSE-4111] 2018-11-07 13:53:36 +03:00
alexey-milovidov
86a4c95048
Merge pull request #3544 from yandex/fix_aio_unknown_compression_method 
Fix AIO unknown compression method when merge tree has mark to the last byte of file
 2018-11-07 00:34:45 +03:00
Artem Zuikov
e9dc302cdc
Merge pull request #3465 from 4ertus2/bugs 
hotfix for distributed DDLs over secure port [CLICKHOUSE-4089]
 2018-11-06 21:39:10 +03:00
Nikolai Kochetov
bcd6e03257 SyntaxAnalyzer (in progress). 2018-11-06 21:13:35 +03:00
alesapin
bdb473b425 Fix AIO unknown compression method when merge tree has mark to last byte of file 2018-11-06 20:29:31 +03:00
chertus
172acbabd0 fix tests (second attempt) [CLICKHOUSE-4089] 2018-11-06 19:38:01 +03:00
Artem Zuikov
469ce719dc
Merge pull request #3521 from 4ertus2/joins 
Set default database name for tables in view's (sub)selects [CLICKHOUSE-3145]
 2018-11-06 19:15:07 +03:00
chertus
458e20c31f fix tests/integration over ssl by alesapin@ 2018-11-06 17:42:30 +03:00
Sabyanin Maxim
dacd999d4f Merge branch 'master' into CLICKHOUSE-4032 2018-11-06 16:50:07 +03:00
alesapin
70df5a1cb7
Merge pull request #3534 from yandex/block_structure_mistmatch 
[WIP] Trying to fix block structure mismatch
 2018-11-06 16:40:05 +03:00
chertus
756342551a add general comment for visitors 2018-11-06 16:28:22 +03:00
Sabyanin Maxim
bdcdc15b1e fixed comment test. 
remove ColumnComment struct.
style fixes
 2018-11-06 16:26:43 +03:00
Nikolai Kochetov
8df77930ec Added InterpreterSelectQuery::unifyStreams 2018-11-06 14:44:45 +03:00
Nikolai Kochetov
d7992b11d8 Fix block structure mismatch in MergingSorted stream. 2018-11-06 13:11:37 +03:00
Alexey Milovidov
c5173782dc Potentially better #3490 2018-11-05 17:29:38 +03:00
Alexey Milovidov
a191c32254 Potential improvement #3490 2018-11-05 13:34:48 +03:00
Alexey Milovidov
6f00f165e5 Clarifications; potential improvement #3490 2018-11-05 12:32:59 +03:00
alexey-milovidov
c25e093b82
Merge pull request #3512 from lapkofear/amd_perf_problem 
fixed group by int16 and Date types on AMD EPYC 7401P machine
 2018-11-04 11:53:38 +03:00
Alexandr Krasheninnikov
6ab45d081c Arch-based compilation 2018-11-02 22:06:05 +03:00
chertus
50d9a6e5d5 refactoring: unify QueryAliasesVisitor with other AST visitors 2018-11-02 18:09:15 +03:00
alesapin
b74dd7fb3f
Merge pull request #3530 from yandex/project-clone-performance 
Project clone performance
 2018-11-02 17:29:21 +03:00
chertus
2f5fb25de6 Merge branch 'master' into joins 2018-11-02 13:39:19 +03:00
Alexey Milovidov
120e2cbe2f Use "ALL" as "join_default_strictness" setting by default for compatibility [#CLICKHOUSE-4087] 2018-11-02 13:03:05 +03:00
Nikolai Kochetov
ecd48dfd07 Removed column clone from project action. 2018-11-02 12:57:29 +03:00
Nikolai Kochetov
9332dd5d2f Removed column clone from project action. 2018-11-02 12:56:37 +03:00
alexey-milovidov
c19b1d919e
Merge pull request #3517 from yandex/kill_pending_queries 
CLICKHOUSE-4094: Add ability to kill pending queries
 2018-11-01 21:07:45 +03:00
proller
c2a818b64d StorageSystemContributors clean (#3524) 
* StorageSystemContributors clean

* Fix
 2018-11-01 21:01:10 +03:00
Alexey Milovidov
9d328839d5 Merge branch 'master' of github.com:yandex/ClickHouse 2018-11-01 20:56:03 +03:00
Alexey Milovidov
30a2513fac Whitespace [#CLICKHOUSE-2] 2018-11-01 20:55:53 +03:00
Alexey Milovidov
accda8bed2 Fixed some code (incomplete) #3139 2018-11-01 20:55:11 +03:00
Alexey Milovidov
dd3f57dd5d Fixed some code (incomplete) #3139 2018-11-01 20:54:53 +03:00
alexey-milovidov
6bc7297a92
Merge pull request #3523 from yandex/low-cardinality-fix-extremes 
Low cardinality fix extremes
 2018-11-01 20:54:09 +03:00
Alexey Milovidov
4a5fd44da2 Merge branch 'add_rate_function' of https://github.com/twosixlabs/ClickHouse into twosixlabs-add_rate_function 2018-11-01 20:41:32 +03:00
Nikolai Kochetov
03b2b609b1 Fix ColumnLowCardinality::getExtremes. #3288 2018-11-01 20:24:05 +03:00
alexey-milovidov
b1db9ec23c
Merge pull request #3436 from amosbird/master 
Flexible fields assignment
 2018-11-01 20:22:28 +03:00
alexey-milovidov
4dedead38f
Update StorageSystemDataTypeFamilies.cpp 2018-11-01 20:21:43 +03:00
alexey-milovidov
1a4a99377a
Update StorageSystemFunctions.cpp 2018-11-01 20:21:15 +03:00
alexey-milovidov
e10fd083ef
Update StorageSystemFunctions.cpp 2018-11-01 20:20:41 +03:00
alexey-milovidov
ac10a55b6f
Update StorageSystemDataTypeFamilies.cpp 2018-11-01 20:20:14 +03:00
alexey-milovidov
cce68f5b40
Merge pull request #3519 from yandex/better-behaviour-of-hash-functions 
Fixed idiosyncrasy with hash functions introduced in #3451
 2018-11-01 20:13:39 +03:00
alexey-milovidov
e2b0c6c94f
Merge pull request #3518 from yandex/low-cardinality-fix-nullable-serialization-into-arena 
Low cardinality fix nullable serialization into arena
 2018-11-01 20:12:06 +03:00
chertus
009f77002e add default db name to views [CLICKHOUSE-3145] 2018-11-01 20:07:20 +03:00
proller
f86d1a7034 CONTRIB-254 Arcadia fixes (#3475) 
* Macos: set ENABLE_EMBEDDED_COMPILER=0 by default (because contrib/llvm temporary broken under macos)

* \n

* arcadia fix

* fix arcadia link

* wip

* wip

* wip

* fix

* wip

* wip

* fix

* try use users from server dir

* Revert "try use users from server dir"

This reverts commit 79b2c6fd9c.

* Fix logging

* fix

* Update ZooKeeperImpl.h
 2018-11-01 20:07:20 +03:00
Alexey Milovidov
719efbe60a Fixed idiosyncrasy introduced in #3451 2018-11-01 18:47:08 +03:00
alexey-milovidov
82933e9c31
Merge pull request #3451 from CurtizJ/CLICKHOUSE-3490 
Support more hash functions for tuple, unify FunctionHash template. [CLICKHOUSE-3490]
 2018-11-01 18:30:01 +03:00
alesapin
11092e895c Better comment 2018-11-01 18:22:59 +03:00
alesapin
c6d1677222 CLICKHOUSE-4097: Remove redundant whitespace 2018-11-01 18:09:19 +03:00
Nikolai Kochetov
dc688ef5e1 Fix nullable comparsion for LowCardinality(Nullable()). #3227 #3256 #3212 2018-11-01 17:57:50 +03:00
alesapin
b0ac729228 CLICKHOUSE-4094: Add ability to kill pending queries 2018-11-01 17:56:37 +03:00
Nikolai Kochetov
045b5d5cd8 Fixed LowCardinality(Nullable()) (de)serialization with arena. #3227 #3256 #3212 2018-11-01 17:55:37 +03:00
chertus
d6defafad2 use AddDefaultDatabaseVisitor for views [CLICKHOUSE-3145] 2018-11-01 17:49:37 +03:00
proller
71403c3ff8 StorageSystemContributors.sh debug (#3491) 
* Sql fuzzy test

* wip

* wip

* wip

* wip

* wip

* Build fixes

* better

* bugs

* wip

* fix

* Fix test

* build fixes

* better

* wip

* fix test

* StorageSystemContributors.sh debug

* debug

* wip

* more

* Fix jemalloc include

* more
 2018-11-01 17:07:14 +03:00
proller
a7437b93a9 Commited StorageSystemContributors.generated.cpp (#3510) 
* CLICKHOUSE-4085 system.contributors

* fi

* Fix random

* Commited StorageSystemContributors.generated.cpp

* fix

* Update CMakeLists.txt
 2018-11-01 17:05:37 +03:00
alexey-milovidov
121f04522e
Merge pull request #3503 from yandex/check_array_value_null 
Better code for check on null values inside array IN expression
 2018-11-01 17:01:06 +03:00
alexey-milovidov
00fa7d9fad
Update Aggregator.cpp 2018-11-01 15:42:57 +03:00
Artem Zuikov
eb535c4b9b
Merge pull request #3500 from 4ertus2/joins 
refactoring: one place for db and table extraction from AST
 2018-11-01 14:59:56 +03:00
igor.lapko
2d565f1099 code style fix 2018-11-01 13:42:15 +02:00
chertus
1a71a443b8 resolve review remarks 2018-11-01 14:32:44 +03:00
alesapin
63c6647be4 Better comment 2018-11-01 14:23:23 +03:00
alesapin
abcc692dbf CLICKHOUSE-4096: Fix nested unaliased joins segfault 2018-11-01 14:23:23 +03:00
igor.lapko
d603cb1eb8 fixed group by int16 and Date types on AMD EPYC 7401P machine 2018-11-01 09:01:34 +02:00
Marek Vavruša
d88450db4d DictionarySourceFactory: fix mistaken connect timeout for read timeout 
It looks like this was accidental, as XDBCStorage and bridges use
http_receive_timeout, but the dictionary passes http_connection_timeout,
so it times out on long queries.
 2018-10-31 16:21:23 -07:00
chertus
1db565193c description for TranslateQualifiedNamesVisitor 2018-10-31 20:45:41 +03:00
chertus
1eae5c38ea remove code duplicates for creating table AST node 2018-10-31 20:31:04 +03:00
chertus
3931a4db5c Merge branch 'master' into joins 2018-10-31 18:11:23 +03:00
chertus
d8674a264a ExpressionAnalyzer fix columns deduplication 2018-10-31 15:58:12 +03:00
alesapin
791a1422de Enable merge with DIRECT_IO when summary size of participating parts more than 10GB 2018-10-31 12:24:58 +03:00
alesapin
892ab4ce8a Better code for check on null values inside array IN expression 2018-10-31 12:17:47 +03:00
chertus
4ff0391ca6 DatabaseAndTableWithAlias - the only place for db & table expraction from AST 2018-10-30 19:31:21 +03:00
chertus
d2518fdb3f more refactoring: funcs to extract database_and_table from AST 2018-10-29 22:04:28 +03:00
Alex Zatelepin
83ac918bab
Merge pull request #3477 from hotid/master 
stop generating empty WHERE () section in mysql queries (#3431)
 2018-10-29 18:23:14 +03:00
alesapin
b944a068d0
Merge pull request #3487 from yandex/fix_nullable_array_at_client 
Add validation of array data
 2018-10-29 18:09:11 +03:00
Alex Zatelepin
fc99b7d389
style fixes 2018-10-29 17:17:58 +03:00
alesapin
444b6e1e43 Add validation of array data 2018-10-29 16:18:41 +03:00
Artem Zuikov
ccfb51b8dd
Merge pull request #3476 from 4ertus2/joins 
ExpressionAnalyzer refactoring - remove duplicated code
 2018-10-29 11:36:06 +03:00
Sabyanin Maxim
73e9f5057d fix code style checker errors 2018-10-27 23:39:59 +03:00
Sabyanin Maxim
65bd40e290 Merge branch 'master' of github.com:yandex/ClickHouse into CLICKHOUSE-4032 2018-10-27 22:33:52 +03:00
proller
c35c979285 CLICKHOUSE-4085 system.contributors (#3452) 
* CLICKHOUSE-4085 system.contributors

* fi

* Fix random
 2018-10-26 20:43:50 +03:00
hotid
f22779ad15 stop generating empty WHERE () section in mysql queries 2018-10-26 20:14:43 +03:00
Alexey Zatelepin
e4e38f71e1 allow empty header in RemoteBlockOutputStream #3411 
The bug with inserts to Distributed tables was introduced in https://github.com/yandex/ClickHouse/pull/3171
It added a workaround specifically for inserting in the Native format without specifying the list of columns.
Native (as opposed to other formats) historically supports this. To signal that the input block structure
shouldn't conform to any fixed header in this case, the remote server started sending empty header block.
This commit adds support for empty headers to RemoteBlockOutputStream.
 2018-10-26 18:26:07 +03:00
chertus
95c618b163 ExpressionAnalyzer: remove duplicated code 2018-10-26 18:13:02 +03:00
Alex Zatelepin
a54dff25aa
Merge pull request #3457 from yandex/fix_non_deterministic_compile 
Don't unfold non deterministic expressions CLICKHOUSE-4077
 2018-10-26 15:59:33 +03:00
alesapin
20b20d04f9 Include from env 2018-10-26 12:22:33 +03:00
alesapin
64b1108989 Merge branch 'master' of github.com:yandex/ClickHouse into fix_non_deterministic_compile 2018-10-25 20:01:22 +03:00
alesapin
a4dd489165 Do not build compiled functions 2018-10-25 19:52:28 +03:00
alesapin
3a9311d3ad Now default block can have size more than one 2018-10-25 19:02:20 +03:00
proller
713c44c3db
Build fixes (#3466) 2018-10-25 18:23:41 +03:00
alesapin
c3159af898 Enlarge constant default column if it's empty 2018-10-25 17:54:00 +03:00
chertus
19a69004f0 fix crash with non const scale in toDecimal() 2018-10-25 16:53:25 +03:00
Ivan Lezhankin
0592081f2f Reduce maximum allowable size of |HashSet|. 2018-10-25 16:17:29 +03:00
chertus
480bee07db hotfix for distributed DDLs over secure port [CLICKHOUSE-4089] 2018-10-25 14:35:19 +03:00
Artem Zuikov
fd6fc3d2cb
Merge pull request #3460 from 4ertus2/joins 
USE database for ON CLUSTER DDLs [CLICKHOUSE-4036]
 2018-10-25 14:15:23 +03:00
chertus
e8f9e3c2a2 better fix for distributed DDL [CLICKHOUSE-4036] [CLICKHOUSE-4015] 2018-10-25 12:40:30 +03:00
proller
7dafcacd15
Build fixes (#3459) 2018-10-24 20:20:27 +03:00
chertus
6375009c81 Merge branch 'master' into joins 2018-10-24 19:43:48 +03:00
chertus
7a24e9b8ff one more minor fix 2018-10-24 18:41:28 +03:00
chertus
a844d10a9a minor fix 2018-10-24 18:39:37 +03:00
chertus
58f14b0db2 USE database for ON CLUSTER DDLs [CLICKHOUSE-4036] 2018-10-24 18:31:07 +03:00
Ivan Lezhankin
aa6a69b635 Add TODO comment 2018-10-24 17:28:23 +03:00
Ivan Lezhankin
69ebaaeed6 Merge branch '3958/many_templates' of github.com:abyss7/ClickHouse into 3958/many_templates 2018-10-24 17:24:52 +03:00
Ivan Lezhankin
9296ef5008 Temporarily disable precalculated bias estimations for precisions other than 17. 2018-10-24 17:23:57 +03:00
CurtizJ
06e955e92a fix combine hashes 2018-10-24 16:12:59 +03:00
alesapin
54a1f0c2a6 enable compiled expressions byt default 2018-10-24 14:36:02 +03:00
alesapin
070d75c7c9 Don't unfold non deterministic expressions 2018-10-24 14:31:23 +03:00
Amos Bird
3cf2177268 Flexible fields assignment 
Field f;

before:

f = Int64(-42);

after:

f = -42;
 2018-10-24 08:47:33 +08:00
alexey-milovidov
bb00bb8592
Merge pull request #3405 from yandex/CLICKHOUSE-2211 
CLICKHOUSE-2211: Fix aio reading (with correct buffer size), reduce M…
 2018-10-24 01:37:05 +03:00
alexey-milovidov
10abde5b62
Merge pull request #3441 from CurtizJ/CLICKHOUSE-1834 
Setting for TCP keepalive. [CLICKHOUSE-1834]
 2018-10-23 23:21:15 +03:00
alexey-milovidov
165890a3e6
Merge pull request #3453 from yandex/fix-union-header 
Fix union header
 2018-10-23 23:18:36 +03:00
alesapin
1c77cf51ce Remove compile_expressions by default 2018-10-23 21:25:55 +03:00
CurtizJ
68f2bea4ba fix style 2018-10-23 21:07:20 +03:00
Nikolai Kochetov
d2f0925685 Uniform headers for union stream. #2156 2018-10-23 21:01:38 +03:00
CurtizJ
e3dea84265 support more hash functions for tuples 2018-10-23 20:43:09 +03:00
alesapin
72e435893d Better comment 2018-10-23 14:19:01 +03:00
alexey-milovidov
4bf54337b9
Merge pull request #3292 from CurtizJ/order-by-efficient 
Efficiently finish sorting by (x, y) stream, that already sorted by (x) [CLICKHOUSE-4022]
 2018-10-23 11:34:22 +03:00
alexey-milovidov
21e7c25134
Update FinishSortingBlockInputStream.cpp 2018-10-23 11:32:28 +03:00
alexey-milovidov
9c3278f378
Merge pull request #3400 from zhang2014/fix/ISSUES-2312 
ISSUES-2312 fix nested view & joined view without database
 2018-10-23 11:21:29 +03:00
Alexey Milovidov
bac6b6f381 Fixed error #2863 2018-10-23 11:19:47 +03:00
CurtizJ
7963e952f1 rename setting to tcp_keep_alive 2018-10-23 02:02:57 +03:00
Alexey Milovidov
b8cfa77ea0 Fixed build [#CLICKHOUSE-2] 2018-10-22 23:58:16 +03:00
alexey-milovidov
98c2ed582c
Merge pull request #2863 from VadimPE/ISSUES-2581 
ISSUES-2581 fix SELECT with sequential consistency
 2018-10-22 23:55:33 +03:00
alexey-milovidov
2deb510c59
Merge branch 'master' into master 2018-10-22 23:45:26 +03:00
alexey-milovidov
57e6dc3477
Merge pull request #3385 from VadimPE/CLICKHOUSE-1791 
[CLICKHOUSE-1791] add modulo for Date and DateTime
 2018-10-22 23:38:40 +03:00
alexey-milovidov
1c3c4c0890
Update FunctionsArithmetic.h 2018-10-22 23:35:28 +03:00
alexey-milovidov
00d49602d3
Merge pull request #3404 from CurtizJ/CLICKHOUSE-3274 
Add lock for .inner. table while insert.  [CLICKHOUSE-3274]
 2018-10-22 23:32:12 +03:00
alexey-milovidov
fd86a6bea5
Update AggregateFunctionUniqCombined.cpp 2018-10-22 22:38:46 +03:00
alexey-milovidov
bd148bb082
Update AggregateFunctionUniqCombined.cpp 2018-10-22 22:37:55 +03:00
alexey-milovidov
f90783d885
Update AggregateFunctionUniqCombined.cpp 2018-10-22 22:36:32 +03:00
alexey-milovidov
c8868cffaa
Update AggregateFunctionUniqCombined.cpp 2018-10-22 22:34:39 +03:00
alexey-milovidov
72b3ec1ffa
Merge pull request #3428 from 4ertus2/joins 
Мore ExpressionAnalyser refactoring, add unit-test for it
 2018-10-22 22:24:39 +03:00
CurtizJ
a05aa5448d add setting keep_alive 2018-10-22 21:09:55 +03:00
Ivan Lezhankin
2a53716043 Move the precision template argument one level up. 2018-10-22 20:18:08 +03:00
Alexey Zatelepin
bd38b4f560 add clear error message #275 2018-10-22 15:38:04 +03:00
VadimPE
31794b7a46 fix codestyle 2018-10-22 14:58:56 +03:00
alexey-milovidov
28fc99c556
Merge pull request #3430 from yandex/fix_subquery_global_counter 
Add global counter to subqueries
 2018-10-22 14:56:31 +03:00
alesapin
c6debd1c33 Better comment 2018-10-22 14:30:24 +03:00
Ivan Lezhankin
19ed7b6ae9 Minor optimizations 2018-10-22 13:00:37 +03:00
chertus
a62fae8332 Merge branch 'master' into joins 2018-10-22 11:25:43 +03:00
chertus
d4699bd9d2 fix FieldToDataType for Decimal128 2018-10-22 11:25:11 +03:00
alesapin
dcc8ca49d7 Add global counter to subqueries 2018-10-20 00:03:45 +03:00
proller
2659e94573 Fix use after pop_back() 2018-10-19 20:27:38 +03:00
proller
67eb30d192 CLICKHOUSE-4074 Fix merge_tree_uniform_read_distribution=0 2018-10-19 19:31:51 +03:00
chertus
b784f754a7 minor settings changes 2018-10-19 18:42:47 +03:00
chertus
dcf04ac36d unit-test for ExpressionAnalyzer [CLICKHOUSE-3996] 2018-10-19 18:33:40 +03:00
Alex Zatelepin
4449d7e059
Update FinishSortingBlockInputStream.cpp 2018-10-19 16:21:50 +03:00
CurtizJ
6ff8a60460 fix style 2018-10-19 16:04:50 +03:00
CurtizJ
8a72ddd94b wip on finish sorting 2018-10-19 15:02:31 +03:00
proller
abfe675097
Build fixes (#3419) 2018-10-18 22:28:05 +03:00
chertus
5aedca40c2 fix asan 2018-10-18 22:27:28 +03:00
Ivan Lezhankin
28ea773b9e Use a single "place" for a default precision constant. 
Also update stateless tests.
 2018-10-18 21:38:45 +03:00
Marek Vavruša
37e03bd938 StorageKafka: check dependencies recursively, add max_block setting 
Changes:

* Check table dependencies recursively before starting streaming
* Use actual number of created consumers when streaming
* Add size limits hint to Kafka consumer stream
* Configurable `kafka_max_block_size` per table
 2018-10-18 09:20:34 -07:00
Ivan Lezhankin
45e6fd8cd2 Fix compilation with gcc and code style 2018-10-18 18:25:39 +03:00
chertus
a32e06d298 more ExpressionAnalyzer refactoring [CLICKHOUSE-3996] 2018-10-18 18:03:14 +03:00
VadimPE
f2db463ab0 fix bug with merge part, wich us inserted with quorum 2018-10-18 17:14:07 +03:00
VadimPE
451114c9a3 rename partition -> part 2018-10-18 15:16:53 +03:00
VadimPE
4a93d3b836 fix addedparts 2018-10-18 14:51:40 +03:00
Ivan Lezhankin
e16081d4d4 Fix initialization of precision. 2018-10-18 14:15:47 +03:00
alesapin
87bb06fdd8 CLICKHOUSE-2211: Add exception for impossible case 2018-10-18 12:24:16 +03:00
alesapin
fe6406eac1 CLICKHOUSE-2211: Fix accident delition 2018-10-17 19:18:14 +03:00
alesapin
d78d569d42 CLICKHOUSE-2211: Fix aio reading (with correct buffer size), reduce MergeTreeReader creation and add useless test 2018-10-17 17:56:15 +03:00
Ivan Lezhankin
6d783ef013 Move-away "uniqCombined" as a separate aggregated function with HLL precision 2018-10-17 17:31:06 +03:00
CurtizJ
f86b9d3983 add lock for .inner. table 2018-10-17 17:11:20 +03:00
CurtizJ
d81ed27004 add lock for .inner. table 2018-10-17 17:08:52 +03:00
Artem Zuikov
52e94ecc5a
Merge pull request #3368 from 4ertus2/joins 
Extract visitors from ExpressionAnalyser [CLICKHOUSE-3996]
 2018-10-17 15:48:42 +03:00
chertus
5d3f03a6d2 minor refactoring (function naming) 2018-10-17 14:06:46 +03:00
chertus
40f1805bf4 fix gcc build 2018-10-17 13:59:05 +03:00
zhang2014
133363e8e3 ISSUES-2312 fix nested view & joined view without database 2018-10-17 14:35:16 +08:00
alexey-milovidov
7566ffe751
Merge pull request #3398 from yandex/better-startup-time 
Better server startup time
 2018-10-17 08:58:23 +03:00
Alexey Milovidov
44f5c735aa Temporary disable "enable_optimize_predicate_expression" setting by default #1777 2018-10-17 06:46:06 +03:00
Alexey Milovidov
99a64d3b92 Presumably better #2278 2018-10-17 06:13:00 +03:00