Commit Graph

262 Commits

Author SHA1 Message Date
Robert Schulze
c0d5705891
Merge pull request #37326 from ClickHouse/fix-marks-cache-size-cfg
Provide default value for mark_cache_size
2022-05-19 20:20:25 +02:00
Azat Khuzhin
29a8a00656 Add ability to pass QueryKind via clickhouse-client/local (useful for debugging)
v2: fix LocalConnection::sendQuery() for Suggest (comes w/o client_info) [1]
    [1]: https://s3.amazonaws.com/clickhouse-test-reports/37290/7c85175963226ff78eec542efafcff4e650aa0f0/stateless_tests__ubsan__actions_.html
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-05-19 07:19:27 +03:00
Robert Schulze
8ca58cd5a5
Provide default value for mark_cache_size
I played around with my local config.xml file. The minimal working example is this:
<?xml version="1.0"?>
<clickhouse>
    <mark_cache_size>5368709120</mark_cache_size>
    <listen_host>localhost</listen_host>
    <tcp_port>9000</tcp_port>
    <users_config>users.xml</users_config>
    <logger><console>true</console></logger>
</clickhouse>

Not specifying mark_cache_size made the server not start up:
  2022.05.18 12:15:06.549078 [ 8728320 ] {} <Error> Application: Not found: mark_cache_size

Looking at ClickHouse's ca. 100 server configuration options +
sub-options, it seems that mark_cache_size is NOT special enough to
require explicit configuration but instead that the behavior was
unintended because no default value was provided.
2022-05-18 15:28:19 +02:00
Alexey Milovidov
1bdc51a496 Merge branch 'remind_for_external_option' of github.com:bigo-sg/ClickHouse into bigo-sg-remind_for_external_option 2022-05-07 12:36:57 +02:00
Alexey Milovidov
1ba42076e5
Merge pull request #36778 from ClickHouse/init-thread-pools-local-server
Init thread pools for clickhouse-local
2022-05-06 01:52:55 +03:00
Antonio Andelic
45a72d9aa9 Init thread pools for clickhouse-local 2022-04-29 07:41:10 +00:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
Kseniia Sumarokova
d3763c4a62 Update ClientBase.h 2022-04-06 12:13:34 +02:00
kssenii
83488b2d13 Better 2022-04-05 14:48:26 +02:00
kssenii
1fb9440d47 Merge master 2022-03-30 17:37:37 +02:00
kssenii
95565b45d6 Fix 2022-03-29 13:33:17 +02:00
kssenii
98fe1ca1ec Fix 2022-03-29 12:05:27 +02:00
taiyang-li
1114c54899 merge master and fix conflict 2022-03-23 11:03:25 +08:00
Vitaly Baranov
39614e6e15
Merge pull request #35276 from vitlibar/fix-code-style-and-minor-corrections-after-allow-no-password
Fix code style and other minor corrections after implementing allow_no_password.
2022-03-16 18:55:05 +01:00
mergify[bot]
9cdd6ec7ab
Merge branch 'master' into test-mode-for-local 2022-03-15 08:28:40 +00:00
Vitaly Baranov
1eb2e8693e Fix code style and other minor corrections after implementing allow_no_password. 2022-03-14 20:55:34 +01:00
Vitaly Baranov
4af61fb9d3
Merge pull request #34738 from DevTeamBK/Issue-33953
New setting in Server Configuration to on/off AuthType Plaintext_password and No_password
2022-03-14 17:09:46 +01:00
kssenii
199188be08 Support test mode for clickhouse-local 2022-03-14 12:02:06 +01:00
HeenaBansal2009
3f031df225 Code refactoring 2022-03-10 22:22:51 -08:00
HeenaBansal2009
3ce9397246 Added Suggestions from Code review 2022-03-09 20:35:01 -08:00
taiyang-li
2283513fc8 merge master and solve conflict 2022-03-08 11:29:00 +08:00
taiyang-li
1b9987ceb1 fix mistake in check-style 2022-03-05 14:22:56 +08:00
taiyang-li
7f69507c95 finish dev 2022-03-01 17:22:12 +08:00
taiyang-li
b31440c77a Merge branch 'master' into add_metric_for_local 2022-03-01 12:29:36 +08:00
HeenaBansal2009
aa8494a808 Fix: System Reload Config Failure 2022-02-28 10:51:49 -08:00
HeenaBansal2009
1b263f0c15 Added FT testcase 2022-02-18 12:58:46 -08:00
Kruglov Pavel
adf58ea1ce
Merge pull request #34490 from Avogar/fix-client
Refactor client fault tolerant connection
2022-02-16 12:39:46 +03:00
taiyang-li
24bd47e556 finish dev 2022-02-15 20:11:13 +08:00
Anton Popov
2399f3e3bb
Merge pull request #34495 from Avogar/improve-local
Improve schema inference in clickhouse-local
2022-02-14 17:27:24 +03:00
alexey-milovidov
0250b28916
Merge pull request #34550 from kssenii/fix-test
Tiny fixes for client/local suggestions
2022-02-14 16:52:56 +03:00
Kruglov Pavel
2bf15d6b5b
Merge pull request #34352 from bigo-sg/clickhouse_local_format
Default input and output formats that can be overriden by --input-format and --output-format.
2022-02-14 14:09:59 +03:00
kssenii
39049251b7 Fix disable_suggestion argument for clickhouse-local 2022-02-12 20:26:01 +01:00
avogar
7d92d9d060 Fix tests 2022-02-10 18:37:27 +03:00
avogar
a69905d378 Fix 2022-02-10 18:23:52 +03:00
avogar
9bbbbdcdd6 Improve schema inference in clickhouse-local 2022-02-10 18:23:52 +03:00
avogar
75c56163a0 Refactor client fault tolerant connection 2022-02-10 12:43:08 +03:00
taiyang-li
0c47dd4ec2 format override input-format 2022-02-06 12:17:03 +08:00
avogar
8858b6bf86 Small improvement in schema inference from stdin in local 2022-01-28 19:17:35 +03:00
Kruglov Pavel
aa49a826b5
Try to fix tests 2022-01-25 14:11:02 +03:00
avogar
a82cdd4fb5 Fix tests 2022-01-25 10:55:09 +03:00
avogar
fed54e0204 Fix 2022-01-25 10:25:37 +03:00
avogar
a20fdc210a Add format autodetect in clickhouse-local 2022-01-20 15:55:28 +03:00
Azat Khuzhin
aee034a597 Use explicit template instantiation for SystemLog
- Move some code into module part to avoid dependency from IStorage in SystemLog
- Remove extra headers from SystemLog.h
- Rewrite some code that was relying on headers that was included by SystemLog.h

v2: rebase
v3: squash move into module part with explicit template instantiation
    (to make each commit self compilable after rebase)
2022-01-10 22:01:41 +03:00
avogar
8112a71233 Implement schema inference for most input formats 2021-12-29 12:18:56 +03:00
kssenii
38ca791465 Fix 2021-12-25 22:00:28 +03:00
Kseniia Sumarokova
b5472d6d99
Update LocalServer.cpp 2021-12-15 12:42:07 +03:00
Azat Khuzhin
fa6090f588 Fix processing initial table (--table/stdin) in clickhouse-local
This patch will:
- fix the issue when table had been tried to create multiple times for
  --queries-files
- create these table for --interactive mode (before it works only if you
  had some queries already, i.e. when it run interactive after
  non-interactive)

This will also make ClientBase interface a little bit cleaner, by
removing one abstract method getQueryTextPrefix()
2021-12-10 22:08:03 +03:00
Nikita Mikhaylov
c7f0a400d8 Typo 2021-12-07 10:31:48 +00:00
Nikita Mikhaylov
80a146816c More comments and style 2021-12-06 21:34:52 +00:00
Nikita Mikhaylov
fb24e7181f Better 2021-12-06 18:27:06 +00:00