Commit Graph

16331 Commits

Author SHA1 Message Date
Sergei Trifonov
d2aebe2c9a
Merge branch 'master' into alter-table-forget-partition 2024-02-20 13:56:50 +01:00
Antonio Andelic
34e8e673e9
Merge pull request #60144 from ClickHouse/per-user-s3-settings
Support specifying users for S3 settings
2024-02-20 13:20:07 +01:00
Igor Nikonov
b6277d5e87 Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-20 12:13:10 +00:00
Robert Schulze
7e11fc79d9
Merge pull request #58023 from canhld94/materialize_non_override_past_values
Materializing an ordinary column with default expression should not override past values
2024-02-20 11:12:31 +01:00
kssenii
3dac4c9743 Fix 2024-02-20 11:10:11 +01:00
kssenii
5ef4a30d6f Fix 2024-02-20 10:24:09 +01:00
MikhailBurdukov
c2d641c658
Merge branch 'master' into backoff_for_failed_mutations 2024-02-20 11:48:59 +03:00
Maksim Kita
9e0f607608 Revert "Revert "ReplicatedMergeTree invalid metadata_version fix"" 2024-02-20 11:39:57 +03:00
MikhailBurdukov
7cdfedaedd Enable setting by default 2024-02-20 08:39:11 +00:00
Alexey Milovidov
b216223aa0
Merge pull request #60139 from ClickHouse/revert-60093-lazy-primary-key-loading
Fix data race in `IMergeTreeDataPart`
2024-02-20 06:44:28 +01:00
Raúl Marín
9361946d15 Fix build in master 2024-02-19 17:48:53 +01:00
alesapin
31bc327005
Merge pull request #60111 from ClickHouse/buffer_bg_flush_parallel
Flush StorageBuffer into multiple threads if num_layers > 1
2024-02-19 16:56:24 +01:00
Antonio Andelic
175a1db787 Support specifying users for s3 settings 2024-02-19 16:43:27 +01:00
Anton Popov
0aa8dafe0a Merge remote-tracking branch 'upstream/master' into HEAD 2024-02-19 14:07:55 +00:00
Vitaly Baranov
f10a8868e1
Merge pull request #60097 from vitlibar/move-thread-pool-callback-runner-to-common
Move threadPoolCallbackRunner to the "Common" folder
2024-02-19 14:10:36 +01:00
Antonio Andelic
7c2654f62e Fix data race 2024-02-19 14:09:37 +01:00
Igor Nikonov
f06e15ce5f Merge remote-tracking branch 'origin/master' into cleanup-connection-pool-priority 2024-02-19 11:33:55 +00:00
Alexey Milovidov
a10eddecef
Merge pull request #59697 from ClickHouse/check-stack-size-in-parser
Check stack size in Parser
2024-02-19 11:33:04 +01:00
Alexey Milovidov
df48106cd5
Merge pull request #60015 from azat/values-quote-escape
Fix INSERT into SQLite with single quote (by escaping single quotes with a quote instead of backslash)
2024-02-19 10:37:45 +01:00
alesapin
6565423b1a Review fix 2024-02-19 10:32:36 +01:00
conicliu
b38ad8297c skip log empty message 2024-02-19 16:11:42 +08:00
Alexey Milovidov
fa1ca348a4 Miscellaneous 2024-02-19 03:19:21 +01:00
Alexey Milovidov
6fd563df52 Miscellaneous 2024-02-19 02:58:51 +01:00
MikhailBurdukov
c3ab9071fc
Merge branch 'master' into backoff_for_failed_mutations 2024-02-18 17:48:11 +03:00
MikhailBurdukov
b227e5dd3f Review changes 2024-02-18 13:37:12 +00:00
alesapin
29e3e7cb96 Better if only 1 layer 2024-02-18 13:19:35 +01:00
alesapin
8f29320a73 Flush StorageBuffer into multiple threads if num_layers > 1 2024-02-18 13:15:24 +01:00
Alexey Milovidov
8d6e6d67ed Merge branch 'fix-inconsistent-formatting-of-explain-in-subqueries' into lazy-primary-key-loading 2024-02-18 11:04:01 +01:00
Alexey Milovidov
232fe0dd1b Fix inconsistent formatting of SELECT ... FROM (EXPLAIN ...) 2024-02-18 05:38:34 +01:00
Alexey Milovidov
c083498cf8 Apply review comments 2024-02-18 05:13:17 +01:00
Vitaly Baranov
3323d5ce81 Move threadPoolCallbackRunner to the "Common" folder. 2024-02-17 21:59:51 +01:00
Alexey Milovidov
0e944d400c
Merge pull request #60092 from ClickHouse/index-preparation
A small preparation for better handling of primary key in memory
2024-02-17 10:15:06 +01:00
Alexey Milovidov
c5107afb94
Merge branch 'master' into lazy-primary-key-loading 2024-02-17 10:14:35 +01:00
Alexey Milovidov
6cae75751b
Merge pull request #60049 from ClickHouse/less-memory-usage-primary-key
Maybe less memory usage for primary keys in memory
2024-02-17 08:58:02 +01:00
Alexey Milovidov
021e11e4fc Add a setting for lazy loading 2024-02-17 06:42:53 +01:00
Alexey Milovidov
423ff759f1 Lazy loading of primary keys in memory 2024-02-17 06:35:03 +01:00
Alexey Milovidov
e9cf92245f Move methods to .cpp 2024-02-17 06:20:44 +01:00
Alexey Milovidov
fce3a8cafc A small preparation for better handling of primary key in memory 2024-02-17 06:16:56 +01:00
Alexey Milovidov
ac5bef7c74 A small preparation for better handling of primary key in memory 2024-02-17 06:16:01 +01:00
Alexey Milovidov
46c2f85314 Merge branch 'master' into less-memory-usage-primary-key 2024-02-17 04:55:59 +01:00
Alexey Milovidov
2f315e0eb5 Style check for abbreviations 2024-02-17 02:14:15 +01:00
Alexey Milovidov
731c484b3d
Revert "Implement system.dns_cache table (#59856)"
This reverts commit b5ef034697.
2024-02-17 01:46:41 +01:00
Kirill Nikiforov
b5ef034697
Implement system.dns_cache table (#59856)
* system.dns_cache table WIP

* system.dns_cache table

* rollback unexpected contrib changes

* rollback unexpected changes

* add docs

* code style fixes

* optimize dns cache exporting

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* cr fixes

* stateful test for system.dns_cache table

* stateful test for system.dns_cache table

* Update 02981_system_dns_cache_table.sql

* Update 02981_system_dns_cache_table.reference

---------

Co-authored-by: pufit <pufit@clickhouse.com>
2024-02-16 14:31:22 -05:00
Alexander Tokmakov
31479649fe
Merge pull request #59908 from azat/rmt-uuid-macro
[RFC] Allow uuid in replica_path if CREATE TABLE explicitly has it
2024-02-16 17:31:59 +01:00
Alexander Tokmakov
3813a97775
Merge pull request #59895 from azat/rmt-mutations-polling
Do not pull mutations if pulling replication log had been stopped
2024-02-16 17:24:30 +01:00
Dmitry Novik
a3c34a7cc2
Merge pull request #54211 from ClickHouse/Support_parameterized_view_with_analyzer
Refactor parameterized view & add support for new analyzer
2024-02-16 16:13:49 +01:00
Igor Nikonov
b85a68790a Cleanup: connection pool priority -> config priority
- names were creating confusion between config priority and balancing priority for a reader
2024-02-16 14:39:41 +00:00
Kruglov Pavel
4d6f167e0c
Merge pull request #59092 from Avogar/auto-format-detection
Try to detect file format automatically during schema inference if it's unknown
2024-02-16 14:32:18 +01:00
Alexander Tokmakov
228a29b93f fix 2024-02-16 14:05:22 +01:00
alesapin
0a189e830c
Merge pull request #59942 from kitaisreal/storage-system-tables-add-metadata-version
StorageSystemTables add metadata_version
2024-02-16 13:17:22 +01:00
Raúl Marín
e168329ade
Revert "ReplicatedMergeTree invalid metadata_version fix" 2024-02-16 11:44:16 +01:00
Alexey Milovidov
2f36c9e965 Maybe less memory usage for primary keys in memory 2024-02-16 00:56:24 +01:00
Alexander Tokmakov
22c97be2a4 ability to detect undead ZooKeeper sessions 2024-02-15 22:17:31 +01:00
kssenii
2a783321d7 Fix deletion of s3 queue 2024-02-15 17:56:38 +01:00
Azat Khuzhin
f10fc95933 Fix INSERT into SQLite with single quote
Previously it leads to syntax error, due to incorrect escaping of single
quotes for SQLite, "\'" had been used instead of "''"

So set output_format_values_escape_quote_with_quote=true for SQLite to
fix this.

v2: prepare modified Context for writing on storage creation
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-15 12:47:29 +01:00
Robert Schulze
f8413481c4
Merge remote-tracking branch 'ClickHouse/master' into materialize_non_override_past_values 2024-02-15 10:29:00 +00:00
Alexey Milovidov
a98facee52
Merge pull request #59944 from ClickHouse/fewer_lambdas
Replace lambdas with pointers to members to simplify stacks
2024-02-15 06:02:35 +01:00
Alexey Milovidov
009d08561d
Merge pull request #59946 from kitaisreal/replicated-merge-tree-alter-update-metadata-version-in-single-transaction
ReplicatedMergeTree invalid metadata_version fix
2024-02-15 04:38:06 +01:00
Alexey Milovidov
681351fe1e
Merge pull request #59987 from nickitat/fix_data_race_storage_distributed
Fix data race in `StorageDistributed`
2024-02-15 02:55:08 +01:00
Alexey Milovidov
7a5e152d9e
Merge pull request #59967 from ClickHouse/dashboards-to-use-merge-tables
Use merge table in the dashboard; add Cloud overview to the system table
2024-02-14 21:56:37 +01:00
Nikita Taranov
5f87956fc8 impl 2024-02-14 16:22:14 +01:00
Maksim Kita
d4778d858d Fixed tests 2024-02-14 18:05:29 +03:00
Maksim Kita
0cce386207 Added documentation 2024-02-14 18:05:29 +03:00
Maksim Kita
f6d211b44d StorageSystemTables add metadata_version 2024-02-14 18:05:29 +03:00
Maksim Kita
be490291af Updated implementation 2024-02-14 18:05:06 +03:00
Maksim Kita
dca627026c ReplicatedMergeTree ALTER update metadata_version in single transaction 2024-02-14 18:05:06 +03:00
kssenii
8fe9ede207 Add a test 2024-02-14 15:25:43 +01:00
Nikolai Kochetov
03720d558e
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-14 12:54:29 +01:00
Alexander Gololobov
dda7c5d2b7 Add comment with motivation 2024-02-14 11:41:07 +01:00
Alexey Milovidov
7b3e57e2d2 Use merge table in the dashboard 2024-02-14 02:37:42 +01:00
Alexey Milovidov
102e64cf1d Merge branch 'master' of github.com:ClickHouse/ClickHouse into dashboards-to-use-merge-tables 2024-02-14 02:20:20 +01:00
Alexey Milovidov
27f115f581 Use merge table in the dashboard 2024-02-14 02:17:23 +01:00
Alexey Milovidov
7ee6b0bd87
Merge pull request #59941 from kitaisreal/register-storage-merge-tree-exception-message-fix
Register StorageMergeTree exception message fix
2024-02-14 01:31:00 +01:00
Alexey Milovidov
8b59977639
Merge pull request #59909 from azat/rmt-macros-cleanup
Petite cleanup around macros and ReplicatedMergeTree
2024-02-14 00:09:34 +01:00
Kruglov Pavel
1dbfeafb42
Merge branch 'master' into auto-format-detection 2024-02-13 19:08:33 +01:00
Alexander Gololobov
037bc043e6 Removed lambdas 2024-02-13 16:01:17 +01:00
Maksim Kita
4dc6ed3a39 Register StorageMergeTree exception message fix 2024-02-13 17:53:35 +03:00
Smita Kulkarni
d7056d642d Addressed review comments 2024-02-13 13:53:40 +01:00
Smita Kulkarni
3526d7982c Merge branch 'master' into Support_parameterized_view_with_analyzer 2024-02-13 13:08:35 +01:00
Kseniia Sumarokova
bb12fb45c4
Merge pull request #59873 from azat/file-log-shutdown-fix
Fix long shutdown of FileLog storage
2024-02-13 12:08:12 +01:00
Nikita Mikhaylov
4b85f6b39a
Revert "Less error prone interface of read buffers" (#59911) 2024-02-13 12:02:46 +01:00
Nikolai Kochetov
666b3d6664
Merge branch 'master' into allow-parallel-replicas-for-join-with-analyzer-2 2024-02-13 11:11:03 +01:00
Azat Khuzhin
58e5d7876b Allow uuid in replica_path if CREATE TABLE explicitly has it
Right now the query with {uuid} macro without ON CLUSTER fails:

    CREATE TABLE x UUID 'aaaaaaaa-1111-2222-3333-aaaaaaaaaaaa' (key Int) ENGINE = ReplicatedMergeTree('/tables/{database}/{uuid}', 'r1') ORDER BY tuple();

There is a workaround right now to use ATTACH instead of CREATE, but
ATTACH is not CREATE.

CREATE still useful for proper RESTORE without ON CLUSTER.

So this patch allows this syntax, but only if UUID had been explicitly
passed in the query. This looks safe.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-13 08:01:09 +01:00
Alexey Milovidov
4dc59051a1
Merge pull request #59897 from ClickHouse/s3queue-fix-uninitialized-value
s3queue: fix uninitialized value
2024-02-13 02:44:45 +01:00
Azat Khuzhin
c61ac1d3bc Convert default_replica_path/default_replica_name into server settings
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 21:05:58 +01:00
kssenii
d008ee725f Add a test 2024-02-12 20:23:21 +01:00
kssenii
0628ae6268 S3 queue fix uninitialized value 2024-02-12 17:13:30 +01:00
Azat Khuzhin
c7c05c9881 Do not pull mutations if pulling replication log had been stopped
Right now, mutations can be pulled even after:

    SYSTEM STOP PULLING REPLICATION LOG

Since they pulled from two places:
- StorageReplicatedMergeTree::mutationsUpdatingTask()
- ReplicatedMergeTreeQueue::pullLogsToQueue()

And only the last one checks action blocker.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 16:28:08 +01:00
Nikolai Kochetov
fd2ee19f65 Follow up for #58554. Cleanup. 2024-02-12 13:37:25 +00:00
Nikolai Kochetov
09d3b3c0d0
Merge pull request #58554 from ClickHouse/try-to-always-push-down-prewhere-from-query-plan
Simplify optimize-push-to-prewhere from query plan
2024-02-12 12:52:39 +01:00
Azat Khuzhin
67b73c3e49 Fix long shutdown of FileLog storage
Previously it was possible to wait up to
poll_directory_watch_events_backoff_max (default is 32000) on shutdown,
because it was not possible to stop poll of inotify.

Before (takes 3 seconds):

    2024.02.12 11:27:55.058192 [ 10134 ] {} <Trace> StorageFileLog (file_log): Waiting for cleanup
    2024.02.12 11:27:58.178021 [ 10271 ] {} <Trace> directory_watch: Execution took 7519 ms.

After:

    2024.02.12 11:33:29.722403 [ 15866 ] {} <Trace> StorageFileLog (file_log): Waiting for cleanup
    2024.02.12 11:33:29.722473 [ 15956 ] {} <Trace> directory_watch: Execution took 6399 ms.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-02-12 11:52:09 +01:00
Robert Schulze
06dc9ed074
Merge remote-tracking branch 'ClickHouse/master' into materialize_non_override_past_values 2024-02-11 15:48:55 +00:00
Alexander Gololobov
309db427e7 Do not reinitialize ZooKeeperWithFaultInjection on each chunk 2024-02-11 13:13:49 +01:00
Michael Kolupaev
5424f235a9 Fix StorageURL doing some of the query execution in one thread instead of max_threads 2024-02-11 02:44:18 +00:00
Anton Popov
b4449535c2
Merge pull request #59733 from CurtizJ/check-minmax-index-types
Validate types of arguments for `minmax` skipping index
2024-02-09 19:39:59 +01:00
Nikolai Kochetov
862c6cd79c
Merge pull request #57430 from ClickHouse/non-ready-set-ttl
Non ready set in TTL WHERE.
2024-02-09 16:31:26 +01:00
Igor Nikonov
effaaceb26
Merge pull request #59501 from ClickHouse/pr-better-replicas-failover-2
Parallel replicas: better initial replicas failover (2)
2024-02-09 15:50:56 +01:00
Dmitry Novik
2e6ca6200e
Merge pull request #59774 from ClickHouse/analyzer-merge-follow-up
Followup #50894
2024-02-09 15:05:19 +01:00
Vitaly Baranov
09e727d48b
Merge pull request #56988 from ClickHouse/Azure_backup
Backup & Restore support for AzureBlobStorage
2024-02-09 14:45:35 +01:00
Dmitry Novik
8655c11280
Fix typo 2024-02-09 11:45:15 +01:00