Commit Graph

12 Commits

Author SHA1 Message Date
Azat Khuzhin
bfef9663ca Tiny cleanup of AggregateFunctionSimpleState/AggregateFunctionState
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-28 08:10:08 +03:00
Azat Khuzhin
4e4e70ec6e Fix leak in SimpleState function (due to recrusive reference)
CI reports [1]:

    Indirect leak of 648 byte(s) in 9 object(s) allocated from:
    ...
        2 0x12b96503 in DB::AggregateFunctionSimpleState::getReturnType() const obj-x86_64-linux-gnu/../src/AggregateFunctions/AggregateFunctionSimpleState.h:47:15
    ...

  [1]: https://s3.amazonaws.com/clickhouse-test-reports/33957/08f4f45fd9da923ae3e3fdd8a527c297d35247eb/stress_test__address__actions_.html

After we can get this query by using query_log artifact:

    $ wget https://s3.amazonaws.com/clickhouse-test-reports/33957/08f4f45fd9da923ae3e3fdd8a527c297d35247eb/stress_test__address__actions_/query_log_dump.tar
    $ tar -xf query_log_dump.tar
    $ clickhouse-local --path var/lib/clickhouse/
    SELECT query
    FROM system.query_log
    ARRAY JOIN used_aggregate_function_combinators AS func
    WHERE has(used_aggregate_functions, 'groupBitOr') AND has(used_aggregate_function_combinators, 'SimpleState') AND (type != 'QueryStart')

    Query id: 5b7722b3-f77e-4e7e-bd0b-586d6d32a899

    ┌─query────────────────────────────────────────────────────────────────────────────┐
    │ with groupBitOrSimpleState(number) as c select toTypeName(c), c from numbers(1); │
    └──────────────────────────────────────────────────────────────────────────────────┘

Fixes: 01570_aggregator_combinator_simple_state.sql
Fixes: #16853
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-01-27 15:23:04 +03:00
kssenii
d18609467b First version 2021-05-30 13:57:30 +00:00
Vladimir
fc15cad7e0
Pass Settings to aggregate function creator 2021-05-26 14:58:31 +03:00
Vladimir
7224e25156
Revert "Pass Settings to aggregate function creator" 2021-05-26 14:46:42 +03:00
vdimir
a2f1bde5cc
Pass Settings to all aggregate function creator 2021-04-15 13:39:59 +03:00
Alexey Milovidov
349d783089 Improve performance of aggregate functions 2021-02-01 20:12:12 +03:00
alexey-milovidov
8b98465f10
Merge pull request #17043 from amosbird/countoptimization
Devirtualize -If and vectorize count
2020-12-31 03:34:16 +03:00
Amos Bird
2e0a2257b8
-SimpleState function arg type = return type 2020-12-23 21:09:05 +08:00
Amos Bird
282dd23587
Split minmaxany 2020-12-21 12:46:31 +08:00
Amos Bird
c6ac831d4e
Fix type 2020-12-11 22:44:22 +08:00
Amos Bird
5b1e5679b4
Add -SimpleState combinator 2020-12-11 11:43:56 +08:00