Commit Graph

127263 Commits

Author SHA1 Message Date
robot-ch-test-poll3
b6cb32b984
Merge pull request #56086 from kitaisreal/keeper-fix-run-without-config
Keeper fix run without config
2023-10-28 00:36:52 +02:00
robot-clickhouse-ci-2
9591f04229
Merge pull request #56080 from ClickHouse/tavplubix-patch-9
Try enable `01154_move_partition_long` with s3
2023-10-28 00:33:06 +02:00
Alexey Milovidov
2b60d5ae67 Make the code less bloated 2023-10-28 00:04:19 +02:00
Alexey Milovidov
e8e96ea77a Throw an error when comparing time intervals with different units 2023-10-27 23:24:55 +02:00
Alexey Milovidov
6eb89ac785 Merge remote-tracking branch 'origin/master' into intervals_comparison 2023-10-27 23:05:55 +02:00
Alexey Milovidov
fbb919c269 Fix typo 2023-10-27 23:05:46 +02:00
Alexey Milovidov
59e3d64d2c
Merge pull request #56050 from azat/bash-completion-fix
Fix bash completion for mawk (and update format list and add one more delimiter)
2023-10-27 22:12:42 +02:00
Alexander Gololobov
2f53dc9432
Merge pull request #56054 from ClickHouse/optimize_keeper_metrics
Avoid traversing potentially big list of watches
2023-10-27 22:02:39 +02:00
Dmitry Novik
224d4f0ee1
Merge pull request #56055 from ClickHouse/fix-recursive-window-analyzer
Analyzer: Fix crash on window resolve
2023-10-27 21:55:46 +02:00
Azat Khuzhin
8782873e4f Fix overrides via connections_credentials in case of root directives exists
Before the following did not work, it always uses user `dev`, even with
`clickhouse-client --connection prod`:

  ```yaml
  user: dev

  connections_credentials:
    prod:
      name: prod
      user: prod
  ```

The problem was that before it was not possible to distinguish options
that had been set via command line options and via configuration file.

I've splitted this two actions, and embedded a call to
parseConnectionsCredentials() in between.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-27 20:03:50 +02:00
Michael Kolupaev
c4ad55a4d4 Fix flakiness of 02263_lazy_mark_load 2023-10-27 17:59:10 +00:00
Maksim Kita
9b60a3d7aa Keeper run without config fix 2023-10-27 20:53:07 +03:00
Michael Kolupaev
b65c498016
Fix 'Block structure mismatch' on concurrent ALTER and INSERTs in Buffer table (#55995) 2023-10-27 10:06:43 -07:00
AN
a6dd84aae2
Update performance.md
Minor language-related fixes (dashes, missing or explicit commas, standard terms, etc.)
2023-10-27 19:02:24 +03:00
Amos Bird
d6066302f3
Improve test 2023-10-27 23:57:56 +08:00
Amos Bird
3eca59d62d
Revert "Fix error code"
This reverts commit ca4fa430b3.
2023-10-27 23:46:43 +08:00
Dmitry Novik
c634c43662
Update src/Analyzer/Passes/QueryAnalysisPass.cpp
Co-authored-by: Nikita Mikhaylov <mikhaylovnikitka@gmail.com>
2023-10-27 16:47:06 +02:00
Alexander Tokmakov
662df28890
Update 01154_move_partition_long.sh 2023-10-27 16:19:08 +02:00
AN
f560e7ee52
Update architecture.md (#56049)
Minor fixes (typo found in comment pull/55985 by den-crane, punctuation style unification)
2023-10-27 15:36:05 +02:00
Amos Bird
ca4fa430b3
Fix error code 2023-10-27 21:30:48 +08:00
Alexander Gololobov
9a95b82cae Avoid traversing potentially big list of watches 2023-10-27 14:54:58 +02:00
Kruglov Pavel
f1f1846572
Merge pull request #55861 from bigo-sg/ch_55858
Throw exception when parsing illegal string as float if precise_float_parsing is true
2023-10-27 14:24:55 +02:00
robot-ch-test-poll
ed41508374
Merge pull request #56075 from RoryCrispin/patch-3
Fix dead link to Virtual Columns
2023-10-27 13:11:30 +02:00
frinkr
18c50c11b3
Multithreading after window functions (#50771)
* feat: Preserve number of streams after evaluation the window functions to allow parallel stream processing

* fix style

* fix style

* fix style

* setting query_plan_preserve_num_streams_after_window_functions default true

* fix tests by SETTINGS query_plan_preserve_num_streams_after_window_functions=0

* fix test references

* Resize the streams after the last window function, to keep the order between WindowTransforms (and WindowTransform works on single stream anyway).

* feat: Preserve number of streams after evaluation the window functions to allow parallel stream processing

* fix style

* fix style

* fix style

* setting query_plan_preserve_num_streams_after_window_functions default true

* fix tests by SETTINGS query_plan_preserve_num_streams_after_window_functions=0

* fix test references

* Resize the streams after the last window function, to keep the order between WindowTransforms (and WindowTransform works on single stream anyway).

* add perf test

* perf: change the dataset from 50M to 5M

* rename query_plan_preserve_num_streams_after_window_functions -> query_plan_enable_multithreading_after_window_functions

* update test reference

* fix clang-tidy

---------

Co-authored-by: Nikita Taranov <nikita.taranov@clickhouse.com>
2023-10-27 12:36:28 +02:00
Rory Crispin
b817ab45bd
Fix dead link to Virtual Columns 2023-10-27 12:03:15 +02:00
Raúl Marín
e93f64670b Force shutdown in upgrade test 2023-10-27 11:16:00 +02:00
Nikita Mikhaylov
f5890a5b4c
Added healthcheck for LDAP (#55571) 2023-10-27 10:53:59 +02:00
Robert Schulze
a68e8be08f
Merge pull request #55696 from zvonand/zvonand-datetime-ranges
Introduce setting `date_time_overflow_behavior` to control the overflow behavior when converting to `Date` / `Date32` / `DateTime` / `DateTime64`
2023-10-27 10:40:20 +02:00
Robert Schulze
5801b06529
Merge pull request #55983 from rschu1ze/snowflake-scale
Fix dateTime64ToSnowflake64() with non-default scale
2023-10-27 10:22:35 +02:00
lgbo
489e6d9bdc
Optimization for getting value from map, arrayElement(1/2) (#55929) 2023-10-27 09:54:25 +02:00
Justin de Guzman
b51f90362d
Clarify query behavior dictionary updates 2023-10-27 00:20:32 -07:00
李扬
308b2942d7
Update readFloatText.h 2023-10-27 11:42:33 +08:00
Andrey Zvonov
2da12ec291
Update FunctionsConversion.h 2023-10-27 01:13:52 +02:00
zvonand
35baf7792d cleanup after rebase, add [[unlikely]] 2023-10-26 23:56:45 +02:00
Robert Schulze
325ff33c3a
Merge pull request #55239 from aiven-sal/aiven-sal/format_query
Add formatQuery function
2023-10-26 22:46:01 +02:00
Robert Schulze
b1fd28d0f4
Try to stabilize test, pt. II 2023-10-26 19:41:29 +00:00
robot-clickhouse-ci-1
d2461671bd
Merge pull request #56056 from ClickHouse/vdimir/fix_doc_function_json
Fix function_json_value_return_type_allow_nullable setting name in doc
2023-10-26 21:08:00 +02:00
Alexander Tokmakov
eacf1ee79b
Merge pull request #56026 from ClickHouse/make_code_worse
Fix some bad code by making it worse
2023-10-26 20:18:04 +02:00
Amos Bird
829fc61e77
Add scalars in all cases 2023-10-27 01:41:02 +08:00
Azat Khuzhin
8556929f50 Fix mixing of send_timeout and receive_timeout
I've noticed this in one of production setups, where lots of queries are
executed with distributed_group_by_no_merge=2 (automatically vai
optimize_skip_unused_shards optimization) and
optimize_aggregation_in_order=1, with this two settings initiator may
not read from some shards (i.e. X) for quite long period of time,
because it reads from other shards (i.e. Y) and it does not need
any data from X yet (due to it read everything in order), and this will
lead to query timeout, so timeouts had been increased.

Previously both timeouts had been tuned, but this leads to connection
hungs in case of abnormal machine reboots. So it is better to tune only
send_timeout (and this should be enough, since the only problem is the
sender) and this will allow to see that the connection is broken on the
initiator once it will read from this shard.

but after changing only send_timeout, the query still timedout, and the
reason is this place, which swaps this timeouts.

It had been introduced in 134efcd, with a comment:

    NOTE: We use send_timeout for the receive timeout and vice versa (change arguments ordering in TimeoutSetter),
     because send_timeout is client-side setting which has opposite meaning on the server side.

But it sounds odd to me, it may only make sense with the
clickhouse-client, since any other driver does not implement any server
settings.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-26 19:36:12 +02:00
vdimir
dbaf66b8f2
Fix function_json_value_return_type_allow_nullable setting name in doc 2023-10-26 19:26:18 +02:00
Dmitry Novik
7cc4b8b1ae Analyzer: Fix crash on window resolve 2023-10-26 17:07:26 +00:00
avogar
990ecaa711 Fix tests 2023-10-26 16:59:36 +00:00
Konstantin Bogdanov
ecafc77e0f
Merge pull request #55521 from ClickHouse/fix-query-params-with-custom-http-handlers
Fix Query Parameters not working with custom HTTP handlers
2023-10-26 18:34:37 +02:00
Alexander Tokmakov
c588a7f386 Merge branch 'master' into make_code_worse 2023-10-26 17:39:10 +02:00
Azat Khuzhin
caec685a49 Update formats list
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-26 17:35:22 +02:00
Azat Khuzhin
4cb8b186e7 Add more delimiters for completion
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-26 17:35:22 +02:00
Azat Khuzhin
b6435b32f0 Fix bash completion for mawk
$ strings < /usr/bin/awk | grep awk
mawk 1.3%s%s %s, Copyright (C) Michael D. Brennan

$ awk '{print substr($0, 0, 1)}' <<<foo # returns empty string

$ awk '{print substr($0, 1, 1)}' <<<foo # returns empty string
f

$ awk -V | head -1
GNU Awk 5.2.2, API 3.2, PMA Avon 8-g1, (GNU MPFR 4.2.1, GNU MP 6.3.0)

$ awk '{print substr($0, 0, 1)}' <<<foo
f
$ awk '{print substr($0, 1, 1)}' <<<foo
f

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-10-26 17:35:22 +02:00
Salvatore Mesoraca
4db31d55fb
Restart CI 2023-10-26 16:22:36 +02:00
Alexander Tokmakov
fa963d60d0
Merge pull request #55641 from evillique/resubmit-cluster-groups
Resubmit #54421
2023-10-26 15:53:53 +02:00