Commit Graph

63557 Commits

Author SHA1 Message Date
Azat Khuzhin
69e395bede Round floats in AggregatingTransform log messages 2021-05-08 18:01:57 +03:00
Azat Khuzhin
6b11319cdf Round floats in Aggregator log messages 2021-05-08 18:01:24 +03:00
Alexey Milovidov
3e8deef6fe Fix some PVS-Studio warnings 2021-05-08 17:54:08 +03:00
Azat Khuzhin
21f08a1aa9 Use 0 over nan for hit_rate in case of 0 queries to the cache dictionary 2021-05-08 17:51:22 +03:00
Azat Khuzhin
4cecc238d6 Fix SIGSEGV for external GROUP BY and overflow row
Overflow row is used for GROUP BY if all of the above is true:
- WITH TOTALS is requested
- max_rows_to_group_by > 0
- group_by_overflow_mode = any
- totals_mode != after_having_exclusive

And in case of overflow row and external GROUP BY, once the temporary
file dumps to disk it resets without_key data variant to nullptr, so any
subsequent dump to disk will cause SIGSEGV.

Fix this, by recreating without_key data variant after dumping to disk,
instead of reseting to nullptr.

And also add sanity check (LOGICAL_ERROR) to make error more
deterministic in case of such error.

Found with fuzzer [1].

  [1]: https://clickhouse-test-reports.s3.yandex.net/23929/e7027e052998540ee660d186727e20f9555b729d/fuzzer_ubsan/report.html#fail1
2021-05-08 17:48:24 +03:00
Alexey Milovidov
9e1a5f41fc A bunch of changes for PVS-Studio 2021-05-08 17:43:03 +03:00
Maksim Kita
1bb4988b1f Fixed FunctionsComparison constant result with non constant arguments 2021-05-08 17:39:35 +03:00
Maksim Kita
4cd097b983 Fixed config.xml 2021-05-08 17:39:35 +03:00
Maksim Kita
6dc0dcdfa4 Fixed code review issues 2021-05-08 17:39:35 +03:00
Maksim Kita
dd44d93f49 Fixed compile expressions 2021-05-08 17:39:35 +03:00
alexey-milovidov
b76503a4ea Update ActionsDAG.cpp 2021-05-08 17:39:35 +03:00
Maksim Kita
21d8684aaf Added CHJIT documentation 2021-05-08 17:39:35 +03:00
Maksim Kita
57d5f55d7f Added jit if test 2021-05-08 17:39:35 +03:00
Maksim Kita
050cb74ed0 Fix compiled if statement 2021-05-08 17:39:35 +03:00
Maksim Kita
8df4e866f3 Fixed clickhouse-client log 2021-05-08 17:39:35 +03:00
Maksim Kita
72d610be2e Updated CHJIT interface to be more thread safe 2021-05-08 17:39:35 +03:00
Maksim Kita
7778172a1f Fixed compilable function 2021-05-08 17:39:35 +03:00
Maksim Kita
4db7e49ccf Fixed Date, DateTime native type 2021-05-08 17:39:35 +03:00
Maksim Kita
16a07f61ae Refactored CompileDAG build algorithm 2021-05-08 17:39:35 +03:00
Maksim Kita
8828599380 Fixed style check 2021-05-08 17:39:35 +03:00
Maksim Kita
c79d7eae21 Refactored interfaces 2021-05-08 17:39:35 +03:00
Maksim Kita
24798ef07c Updated interfaces 2021-05-08 17:39:34 +03:00
Maksim Kita
d2eecfe593 Updated Nullable default implementation 2021-05-08 17:39:34 +03:00
Maksim Kita
8d6c282e0a Fixed test 2021-05-08 17:39:34 +03:00
Maksim Kita
af06f5b68b Fixed UUID test 2021-05-08 17:39:34 +03:00
Maksim Kita
97d87eb518 Fixed JITMemoryManager 2021-05-08 17:39:34 +03:00
Maksim Kita
e40aa26611 Fixed MSan 2021-05-08 17:39:34 +03:00
Maksim Kita
baf1978124 CHJIT updated thread safe interface 2021-05-08 17:39:34 +03:00
Maksim Kita
2b58357a77 Fixed tests 2021-05-08 17:39:34 +03:00
Maksim Kita
69fdcdcc4a Fixed tests 2021-05-08 17:39:34 +03:00
Maksim Kita
231433d951 Fixed style check 2021-05-08 17:39:34 +03:00
Maksim Kita
ca9a23abbc Fix build 2021-05-08 17:39:34 +03:00
Maksim Kita
e58e956092 Enable llvm in fast test 2021-05-08 17:39:34 +03:00
Maksim Kita
3ec4409d52 Added CHJIT 2021-05-08 17:39:34 +03:00
Maksim Kita
ca44ff2ede Updated example 2021-05-08 17:39:34 +03:00
Maksim Kita
c264e42542 Updated example 2021-05-08 17:39:34 +03:00
Maksim Kita
9f88fea760 Updated test 2021-05-08 17:39:34 +03:00
Maksim Kita
6b70cbd53c Added jit example 2021-05-08 17:39:34 +03:00
Maksim Kita
fe7af99701 CMake USE_EMBEDDED_COMPILER ON by default 2021-05-08 17:39:34 +03:00
Maksim Kita
5792a2533f Enable compile_expressions in fuzzer 2021-05-08 17:39:34 +03:00
Maksim Kita
9daf5b8308 Updated Settings 2021-05-08 17:39:34 +03:00
Alexey Milovidov
78867a53c6 Fixed build 2021-05-08 17:39:34 +03:00
Alexey Milovidov
996cdd327c Addition to prev. revision 2021-05-08 17:39:34 +03:00
Alexey Milovidov
e862580898 Added comment 2021-05-08 17:39:34 +03:00
Alexey Milovidov
f7830eb7b3 Unpoison data generated by JIT-ed functions for MSan 2021-05-08 17:39:34 +03:00
Alexey Milovidov
40ed49350e Enable "compile_expressions" by default 2021-05-08 17:39:34 +03:00
Alexey Milovidov
aa727e941d Fix bad code (found by PVS-Studio) 2021-05-08 17:21:36 +03:00
Alexey Milovidov
8da7d43c99 Fix bad code in Keeper (found by PVS-Studio) 2021-05-08 17:13:32 +03:00
Alexey Milovidov
e9c7aa5ab5 Remove some code 2021-05-08 17:12:26 +03:00
Alexey Milovidov
afae68a019 Fix bad code in Keeper (found by PVS-Studio) 2021-05-08 17:10:06 +03:00