Commit Graph

680 Commits

Author SHA1 Message Date
Alexey Milovidov
23cf6d0d8b Useless changes 2024-05-11 22:51:57 +02:00
Alexey Milovidov
dd58af7d4f Merge branch 'master' of github.com:ClickHouse/ClickHouse into clang-18-ci 2024-05-10 07:17:39 +02:00
Michael Kolupaev
1b43c58489
Merge pull request #62087 from ClickHouse/checkmate
Avoid crashing on column type mismatch in a few dozen places
2024-05-09 23:59:59 +00:00
Alexey Milovidov
224e1940ae Useless changes 2024-05-09 03:58:34 +02:00
Alexey Milovidov
95f12ef274 Useless changes 2024-05-09 01:08:33 +02:00
Yarik Briukhovetskyi
767e32d566
Merge pull request #63406 from yohannj/fix_error_codes
Update ErrorCodes for functions using NUMBER_OF_ARGUMENTS_DOESNT_MATCH
2024-05-08 15:12:00 +00:00
Michael Kolupaev
d14fc62d4d Avoid crashing on column type mismatch in a few dozen places 2024-05-06 22:09:02 +00:00
Yohann Jardin
ab7d457c51 Update ErrorCodes for functions using NUMBER_OF_ARGUMENTS_DOESNT_MATCH 2024-05-06 11:35:48 +02:00
李扬
c0ddd3df0b
Merge branch 'ClickHouse:master' into complex_map_key 2024-05-06 10:23:18 +08:00
Kruglov Pavel
49ba81a5f9
Merge pull request #62417 from Avogar/dot-product-overflow
Don't check overflow in  arrayDotProduct in undefined sanitizer
2024-04-09 10:17:58 +00:00
avogar
b318091528 Don't check overflow in dotProduct in undefined sanitizer 2024-04-08 17:17:04 +00:00
李扬
7df85e6176
Merge branch 'ClickHouse:master' into complex_map_key 2024-04-07 10:32:43 +08:00
Raúl Marín
11eb872ac6 Remove more nested includes 2024-04-03 19:06:36 +02:00
李扬
5f786647fb
Merge branch 'ClickHouse:master' into complex_map_key 2024-04-02 12:10:37 +08:00
Raúl Marín
c98634ad8c Merge remote-tracking branch 'blessed/master' into nested_includes 2024-03-20 14:08:10 +01:00
Raúl Marín
a1c08b256a
Merge pull request #61539 from Algunenano/arrayPartialReverseSort
Fix crash in arrayPartialReverseSort
2024-03-20 12:37:32 +01:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
Robert Schulze
02e0b682ab
Merge remote-tracking branch 'rschu1ze/master' into dotProduct-memcpy 2024-03-18 21:29:41 +00:00
Raúl Marín
4c27287c6d Fix crash in arrayPartialReverseSort 2024-03-18 17:30:29 +01:00
robot-ch-test-poll4
e8a08baf23
Merge pull request #61092 from rschu1ze/locate-mysql
Make the argument order for `locate` compatible with MySQL
2024-03-18 11:55:05 +01:00
Robert Schulze
f02db275c5
Merge remote-tracking branch 'rschu1ze/master' into dotProduct-memcpy 2024-03-18 09:26:29 +00:00
Alexey Milovidov
2af6d35752 Less crap 2024-03-17 12:53:59 +01:00
Robert Schulze
4233fa4d80
Merge remote-tracking branch 'rschu1ze/master' into locate-mysql 2024-03-14 11:35:58 +00:00
Kruglov Pavel
4b3f33c5fd
Merge pull request #60451 from Avogar/fix-map-array-func-lc
Try to fix logical error 'Cannot capture column because it has incompatible type' in mapContainsKeyLike
2024-03-13 19:02:24 +01:00
Robert Schulze
173fa7934c
Merge remote-tracking branch 'rschu1ze/master' into locate-mysql 2024-03-13 12:31:56 +00:00
Mikhail Koviazin
94f15dd5e0
Fix has() function with Nullable column
Previous implementation didn't check for `null_map` when the given
argument was not `Null`. This commit adds the missing check.

Fixes #60214
2024-03-12 16:48:43 +02:00
李扬
a830462af2
Merge branch 'ClickHouse:master' into complex_map_key 2024-03-11 10:26:44 +08:00
Robert Schulze
349894fc2b
Fixes #61051 2024-03-10 13:13:59 +00:00
Robert Schulze
bcd705517a
Remove unnecessary call to convertToFullColumnIfConst() 2024-03-10 13:09:01 +00:00
Robert Schulze
530efbe810
Beautify exception, pt. II 2024-03-10 13:09:01 +00:00
Yarik Briukhovetskyi
23b55ecbe8
beautify exception 2024-03-08 22:02:22 +01:00
Robert Schulze
45a1f0f8ed
More consistency and extended tests 2024-03-08 14:02:34 +00:00
Yarik Briukhovetskyi
e7cc49212a
fix tidy build 2024-03-08 12:28:14 +01:00
Nikita Mikhaylov
82ba97c3a7
More explicit template instantiations (#60730) 2024-03-07 17:16:13 +01:00
Yarik Briukhovetskyi
66dea51112
fix clang-tidy 2024-03-07 12:40:48 +01:00
Robert Schulze
245ea0c186
Implement const/non-const shortcut 2024-03-06 16:56:01 +00:00
Robert Schulze
a69bcc29f5
Refactor a sanity check 2024-03-06 15:02:01 +00:00
Robert Schulze
c3909743ed
Remove repeated unnecessary unpacking of const columns 2024-03-06 13:54:14 +00:00
Robert Schulze
2dc1721262
Refactorings for consistency 2024-03-06 12:24:05 +00:00
Raúl Marín
f212c9c230 Fix crash in arrayEnumerateRanked 2024-03-04 13:14:13 +01:00
Alexey Milovidov
3749618ba1 Add a test 2024-02-28 23:28:46 +01:00
Alexey Milovidov
98be049e66 Fix bad error message 2024-02-28 23:08:29 +01:00
avogar
416638461f Try to fix logical error 'Cannot capture column because it has incompatible type' in mapContainsKeyLike 2024-02-27 15:02:13 +00:00
taiyang-li
ccd317da7e Merge branch 'master' into complex_map_key 2024-02-27 17:25:37 +08:00
Robert Schulze
ae597d86dd
Merge remote-tracking branch 'rschu1ze/master' into vector-dot-product 2024-02-22 10:16:28 +00:00
Nikolai Kochetov
0e9d7f3540
Merge pull request #60037 from ClickHouse/fix-01656_test_query_log_factories_info-for-analyzer
Fix 01656_test_query_log_factories_info with analyzer.
2024-02-21 17:37:15 +01:00
Robert Schulze
8f0f8bf294
Fix typo 2024-02-21 11:54:20 +00:00
Robert Schulze
9f37f17900
Further refactorings to make the code more similar to arrayDistance.cpp 2024-02-21 10:59:58 +00:00
Robert Schulze
daa61a8576
Manualy vectorize arrayDotProduct()
Measurements go down from
- 0.34 sec --> 0.30 sec (Float32)
- 0.68 sec --> 0.54 sec
2024-02-20 22:51:11 +00:00
Robert Schulze
e57b8f64e0
Help the compiler a bit with auto-vectorization
For query
   SELECT sum(dp) FROM (SELECT dotProduct(v, v) AS dp FROM vectors)
with vectors of type
   Array(Float32) and
   Array(Float64)
and dimension = 150, runtimes go down from
  0.46 sec to 0.34 sec (Float32) and
  0.74 sec to 0.68 sec (Float64))

The latter (only a minor improvement) is independent of the number of
lanes (VEC_SIZE = 4 vs. 2 which is the theoretical optimal for Float64).
2024-02-20 22:24:18 +00:00