Commit Graph

2777 Commits

Author SHA1 Message Date
Ivan Blinkov
7b1ab482b0 restore immediate stacktrace output 2020-06-22 10:22:13 +03:00
Ivan Blinkov
2c0ff29c48 Merge branch 'master' of github.com:ClickHouse/ClickHouse into sentry 2020-06-22 10:06:36 +03:00
alexey-milovidov
5decc73b5d
Merge pull request #11832 from ClickHouse/mysql-vars
Added support for MySQL style global variables syntax
2020-06-22 03:04:04 +03:00
alexey-milovidov
dd31bcff66
Merge pull request #11846 from ClickHouse/prohibit-array-join-in-higher-order-functions
Don't allow arrayJoin inside higher order functions
2020-06-22 03:00:51 +03:00
Alexey Milovidov
69008521f6 Fix build 2020-06-22 00:17:19 +03:00
Alexey Milovidov
4dcc0a0f86 Better diagnostics for logical error triggered by test 00992 2020-06-22 00:07:06 +03:00
Alexey Milovidov
318b35cd85 generate-ya-make 2020-06-21 23:22:34 +03:00
alexey-milovidov
0135771d7f
Merge pull request #11839 from ClickHouse/tuple-compare-const-string
Fix comparison of tuple with constant string
2020-06-21 21:59:15 +03:00
Alexey Milovidov
3f0931ad72 Fix build 2020-06-21 21:57:20 +03:00
Alexey Milovidov
a8e739b191 Fix build 2020-06-21 21:52:58 +03:00
Alexey Milovidov
8cc411c5b5 Clarify setting 2020-06-21 21:50:02 +03:00
Alexey Milovidov
8100423b7e Style 2020-06-21 21:47:16 +03:00
alexey-milovidov
c3a5c32a48
Merge branch 'master' into arch-chooser 2020-06-21 21:30:06 +03:00
alexey-milovidov
38b018fa04
Update executeQuery.cpp 2020-06-21 21:29:11 +03:00
Alexey Milovidov
7117b419b9 Don't allow arrayJoin inside higher order functions #3933 2020-06-21 21:22:34 +03:00
alexey-milovidov
59d3e200ce
Merge pull request #11831 from ClickHouse/decimal-cut-extra-digits-after-point
Make reading of Decimal more compatible with other DBMS
2020-06-21 21:03:06 +03:00
Alexey Milovidov
199a6576a5 Remove dependency 2020-06-21 19:37:12 +03:00
Alexey Milovidov
9c97a1e6d1 Merge branch 'master' into mysql-vars 2020-06-21 19:12:24 +03:00
Alexey Milovidov
fac2c6050c Fix UBSan 2020-06-21 19:10:38 +03:00
Alexey Milovidov
8a3610bad8 Fix build 2020-06-21 19:08:41 +03:00
Alexey Milovidov
0b2ffb9c77 Merge branch 'master' into print-build-id 2020-06-21 19:08:07 +03:00
Alexey Milovidov
71317dd59c Merge branch 'master' into send-logs-on-fatal-errors 2020-06-21 19:05:20 +03:00
Azat Khuzhin
844960195d Fix memory accounting via HTTP interface
function perf_test()
{
    time yes '127.1:8123/?wait_end_of_query=1' | head -n10000 | xargs -P10000 curl -s -d 'select 1' | grep -x -c 1
}
function server()
{
    local limit=$1 && shift
    clickhouse-server "$@" -- --max_server_memory_usage=$limit
}

perf_test:

- before this patch with 1G  limit: succeed only ~800  queries
- after  this patch with 1G  limit: succeed      ~8000 queries

- before this patch with 10G limit: succeed only ~3000  queries
- after  this patch with 10G limit: succeed      ~10000 queries

Fixes: #11153
2020-06-21 17:27:54 +03:00
alexey-milovidov
863b46534f
Update FunctionsComparison.h 2020-06-21 17:25:41 +03:00
Alexey Milovidov
9514965207 Fix comparison of tuple with constant string 2020-06-21 16:23:32 +03:00
Azat Khuzhin
fb30629ff2 Add settings to control nesting level for shards skipping optimization
- optimize_skip_unused_shards_nesting (allows control nesting level for
  shards skipping optimization)
- force_skip_optimize_shards_nesting (allows control nesting level for
  checking was shards skipped or not)
- deprecates force_skip_optimize_shards_no_nested
2020-06-21 15:27:01 +03:00
Alexey Milovidov
3f96bdaa24 Minor changes after merge 2020-06-21 15:16:08 +03:00
Alexey Milovidov
814c1019b2 Fix build after merge 2020-06-21 14:41:06 +03:00
alexey-milovidov
4ee623ccac
Merge pull request #10242 from MovElb/movelb-postgresql-wire-protocol-impl
PostgreSQL wire protocol implementation
2020-06-21 14:39:22 +03:00
alexey-milovidov
f4a1872085
Update WriteHelpers.h 2020-06-21 14:32:54 +03:00
alexey-milovidov
e6ab9b969e
Merge pull request #11830 from zlobober/fix_mmap_threshold
Move MMAP_THRESHOLD definition to .cpp file.
2020-06-21 14:07:07 +03:00
alexey-milovidov
90b5e5d2f9
Merge pull request #11688 from ClickHouse/query-plan
Query plan
2020-06-21 14:05:13 +03:00
Alexey Milovidov
fe71a8eb8c Merge branch 'master' into send-logs-on-fatal-errors 2020-06-21 13:55:11 +03:00
Alexey Milovidov
9bbb4ff3d8 Added missing file 2020-06-21 13:54:28 +03:00
Alexey Milovidov
477116844f Fix Arcadia 2020-06-21 13:53:54 +03:00
Alexey Milovidov
fd885e86f7 Merge branch 'master' into mysql-vars 2020-06-21 13:53:37 +03:00
Alexey Milovidov
4b7d253c8a Fix clang-static-analyzer 2020-06-21 13:51:51 +03:00
Alexey Milovidov
227afea032 Merge branch 'master' into decimal-cut-extra-digits-after-point 2020-06-21 13:50:06 +03:00
Alexey Milovidov
f430893adc Fix Arcadia 2020-06-21 13:45:26 +03:00
Alexey Milovidov
7f05d2bac0 Merge branch 'master' into print-build-id 2020-06-21 13:44:32 +03:00
alexey-milovidov
31dd02c45b
Merge pull request #11833 from ClickHouse/disable-bad-optimization
Disable bad optimization #10047
2020-06-21 02:03:50 +03:00
alexey-milovidov
48f2987cbd
Merge pull request #11835 from ClickHouse/fix-false-msan-report-dl
Fix false MSan report in SymbolIndex
2020-06-21 02:03:15 +03:00
Maxim Akhmedov
2ff7f34968 Make constants in cpp file extern. 2020-06-21 00:45:20 +03:00
alexey-milovidov
c8eabd8cec
Merge pull request #11829 from ClickHouse/improve-error-message-decimal-cast
Improve error message for Decimal CAST
2020-06-21 00:24:03 +03:00
alexey-milovidov
485c4c9055
Merge pull request #11828 from ClickHouse/fix-fixed-string-comparison
Fix FixedString comparison #11393
2020-06-21 00:21:13 +03:00
alexey-milovidov
cd3d7c9155
Merge pull request #11806 from azat/optimize_aggregators_of_group_by_keys-fix-alias
Preserve column alias with optimize_aggregators_of_group_by_keys
2020-06-21 00:13:19 +03:00
Alexey Milovidov
961568e978 Fix false MSan report in SymbolIndex 2020-06-20 22:05:03 +03:00
alexey-milovidov
603e690c18
Update Allocator.cpp 2020-06-20 21:52:36 +03:00
alexey-milovidov
87937e580e
Update Allocator.h 2020-06-20 21:52:13 +03:00
alexey-milovidov
017f55a715
Merge pull request #11821 from ClickHouse/hostname-alias
Added "hostname" as an alias to function "hostName"
2020-06-20 21:46:21 +03:00
Alexey Milovidov
147cda2581 Merge branch 'master' into print-build-id 2020-06-20 21:05:31 +03:00
Alexey Milovidov
420b943cf1 Auto-generate ya.make 2020-06-20 21:03:40 +03:00
Alexey Milovidov
14e29f2c11 Disable bad optimization #10047 2020-06-20 21:00:00 +03:00
alexey-milovidov
9bfefc99ab
Merge pull request #11599 from filimonov/better_kafka_states
Kafka work with formats based on PeekableReadBuffer and other improvements
2020-06-20 20:36:54 +03:00
alexey-milovidov
076fe8e8ba
Update KafkaBlockInputStream.cpp 2020-06-20 20:34:42 +03:00
Alexey Milovidov
6111cbec7f Trying to fix clang-static-analyzer 2020-06-20 20:10:16 +03:00
Alexey Milovidov
15272d9e60 Fix style 2020-06-20 20:05:47 +03:00
alexey-milovidov
92d37efe18
Merge pull request #11736 from maxim-babenko/patch-1
Fix PODArrayBase::push_back_raw_many
2020-06-20 19:16:15 +03:00
Alexey Milovidov
e6a969e2e6 Added support for MySQL style global variables syntax 2020-06-20 19:05:49 +03:00
Maxim Akhmedov
34fbc62033 Move MMAP_THRESHOLD definition to .cpp file. 2020-06-20 19:01:16 +03:00
Alexey Milovidov
4867934204 Every function in its own file 2020-06-20 18:45:50 +03:00
Alexey Milovidov
408fc241d6 Make reading of Decimal more compatible with other DBMS 2020-06-20 17:43:01 +03:00
Alexey Milovidov
7b2b726c17 Fix bad types 2020-06-20 17:00:38 +03:00
alexey-milovidov
c6877371ac
Merge pull request #11816 from ClickHouse/better-code-agr-functions-optimize
Fix 10% of bad code #11756
2020-06-20 16:51:44 +03:00
alexey-milovidov
f9372bfbbb
Merge pull request #11818 from ClickHouse/fix-bad-code-optimizations
Fix another 10% of bad code.
2020-06-20 16:49:23 +03:00
Nikolai Kochetov
819ea4fb89 Fix tests. 2020-06-20 16:48:21 +03:00
Alexey Milovidov
d9e7fe3735 Improve error message for Decimal CAST 2020-06-20 16:34:22 +03:00
Alexey Milovidov
3658ea6e55 Fix FixedString comparison #11393 2020-06-20 16:13:51 +03:00
Alexey Milovidov
733e34f890 Fix build 2020-06-20 14:33:09 +03:00
Alexey Milovidov
7fcf942d24 Turn off traps 2020-06-20 14:29:23 +03:00
Alexey Milovidov
826fdf44ae Set send_logs_level to fatal by default 2020-06-20 14:28:49 +03:00
Alexey Milovidov
7ba25bd799 Make it work 2020-06-20 14:17:15 +03:00
Nikolai Kochetov
a58b152140 Fix build. 2020-06-20 13:40:53 +03:00
Alexey Milovidov
9f42e81ef9 Send logs on fatal errors (development) 2020-06-20 13:10:18 +03:00
Alexey Milovidov
5c2e9da583 Added a function "buildId" 2020-06-20 12:17:43 +03:00
Alexey Milovidov
ead4a2cfd9 Print build id in crash messages 2020-06-20 12:07:05 +03:00
Nikolai Kochetov
0c6129ac7c Fix build. 2020-06-20 11:52:41 +03:00
Azat Khuzhin
b8ee2ea7d9 Pass max_ignored_errors/fallback_to_stale_replicas to PoolWithFailoverBase::get() too 2020-06-20 11:46:13 +03:00
Azat Khuzhin
de011a6edc Mark PoolWithFailoverBase::get() protected 2020-06-20 11:39:21 +03:00
Azat Khuzhin
dd054380bf Drop default values for some arguments of PoolWithFailoverBase::getMany 2020-06-20 11:21:18 +03:00
Azat Khuzhin
caa195c034 Add number of errors to ignore while choosing replicas (distributed_replica_max_ignored_errors)
This will allow avoid switching to another replica in case of error
(since error can be temporary).
2020-06-20 11:20:16 +03:00
Azat Khuzhin
687eb24f50 Fix divizion by zero for distributed_replica_error_half_life=0 2020-06-20 11:05:39 +03:00
Azat Khuzhin
2a5a8e70f4 Drop unused PoolWithFailoverBase<>::reportError() 2020-06-20 11:05:38 +03:00
Nikolai Kochetov
4d70cc34c1 Merge branch 'master' into query-plan 2020-06-20 10:53:48 +03:00
Nikolai Kochetov
e75091ab6c Fix distinct for FinishSortingStep. 2020-06-20 10:50:45 +03:00
alexey-milovidov
c256682068
Update PODArray.h 2020-06-20 10:45:51 +03:00
Alexey Milovidov
f25416beb8 Added "hostname" as an alias to function "hostName" 2020-06-20 10:43:35 +03:00
Alexey Milovidov
ad672f7ce2 Whitespace 2020-06-20 10:26:33 +03:00
Alexey Milovidov
b8769e1ada Fix style 2020-06-20 10:24:51 +03:00
Alexey Milovidov
9f26ac06ea Fix another 10% of bad code #11529 2020-06-20 09:54:05 +03:00
Alexey Milovidov
71d907129c Whitespace 2020-06-20 09:41:09 +03:00
Alexey Milovidov
b91782594d Fix 10% of bad code #11756 2020-06-20 09:24:34 +03:00
alexey-milovidov
f27ae6a12a
Merge pull request #11682 from ClickHouse/fix-parallel-final-stuck
Fix parallel final stuck
2020-06-20 09:05:32 +03:00
alexey-milovidov
2e604726e0
Update PODArray.h 2020-06-20 08:39:52 +03:00
alexey-milovidov
4129300fdb
Merge pull request #11788 from ClickHouse/fix-too-many-threads
Fix too many threads
2020-06-20 08:24:47 +03:00
alexey-milovidov
d341e34fac
Merge pull request #11795 from ClickHouse/remove-leader-election-3
Remove leader election, step 3: remove yielding of leadership; remove sending queries to leader.
2020-06-20 08:24:16 +03:00
Alexander Kuzmenkov
fbecf42dfc report the number of errors 2020-06-20 01:41:15 +03:00
tavplubix
b8685322b7
Merge pull request #11767 from amosbird/fs1
add scalars in time
2020-06-20 01:01:20 +03:00
Alexander Kuzmenkov
288f217df3 Merge remote-tracking branch 'origin/master' into HEAD 2020-06-19 23:07:53 +03:00
Azat Khuzhin
5f14622bfd Preserve column alias with optimize_aggregators_of_group_by_keys
optimize_aggregators_of_group_by_keys has been introduced in #11667
2020-06-19 23:04:19 +03:00
alexey-milovidov
8a33cd7483
Merge pull request #11785 from abyss7/h3-arcadia
Support H3 in Arcadia
2020-06-19 22:52:07 +03:00
alesapin
85070ea2fd Remove unused variable 2020-06-19 22:41:24 +03:00
alexey-milovidov
08b53c1ab5
Update gtest_pod_array.cpp 2020-06-19 22:10:04 +03:00
Nikolai Kochetov
8a048340b0 Fix tests. 2020-06-19 21:23:44 +03:00
alesapin
4c0879ae30 Better logging in storages 2020-06-19 20:17:13 +03:00
Nikolai Kochetov
9ca456f255 Try fix totals. 2020-06-19 19:58:27 +03:00
Nikolai Kochetov
4cafa3d703 Try fix totals. 2020-06-19 19:51:44 +03:00
alesapin
a462462610 Merge branch 'master' into atomic_metadata5 2020-06-19 18:58:42 +03:00
alesapin
c9fa5d2ec3 Better naming 2020-06-19 18:39:41 +03:00
alesapin
a2e7e9f232 Remove unused constructor and rename method 2020-06-19 18:21:48 +03:00
alesapin
3c47faa9da Move partition key initialization into registerMergeTree 2020-06-19 18:14:08 +03:00
Nikolai Kochetov
f6cd3f43bb Fix Context leak in InterpreterSelectQuery 2020-06-19 17:42:01 +03:00
Alexey Milovidov
468eaa8d93 Remove unused method 2020-06-19 17:21:26 +03:00
Alexey Milovidov
5211a42c04 Remove leader election, step 3 2020-06-19 17:18:58 +03:00
Nikolai Kochetov
6c9c33f870 Fix Context leak in InterpreterSelectQuery 2020-06-19 17:00:11 +03:00
Nikolai Kochetov
ec892775a5 Fix Context leak in InterpreterSelectQuery 2020-06-19 16:34:40 +03:00
Maxim Babenko
5895f25166 Styling 2020-06-19 16:30:00 +03:00
Maxim Babenko
8436688437 Add unittests for push_back_raw_many 2020-06-19 16:21:54 +03:00
alesapin
016ee6316f Add missed check 2020-06-19 15:05:29 +03:00
alexey-milovidov
3e06182079
Update InterpreterSelectQuery.cpp 2020-06-19 14:28:48 +03:00
Nikolai Kochetov
b85b6a6cc2 Fix MergingAggregatedStep 2020-06-19 14:27:07 +03:00
alexey-milovidov
397f0aa721
Merge pull request #11746 from azat/build-fix
Fix usage/linking of static dbms library (add clickhouse_aggregate_functions)
2020-06-19 14:26:52 +03:00
alesapin
ce0c5faf9e Merge branch 'fix_alter_with_materialized' into atomic_metadata5 2020-06-19 14:00:32 +03:00
Nikolai Kochetov
0335c698e0 Limit the number of threads. 2020-06-19 13:57:44 +03:00
alesapin
4b6db63fff Fix alter key when materialized column passed 2020-06-19 13:53:20 +03:00
Nikolai Kochetov
cac365689f Fix mx_threads in query_plan. 2020-06-19 13:45:48 +03:00
Ivan Lezhankin
747a3bb0e8 Support H3 in Arcadia 2020-06-19 13:06:42 +03:00
Nikolai Kochetov
690b88d331
Merge pull request #11291 from Provet/master
Partial sorting optimization fix
2020-06-19 12:58:44 +03:00
Nikolai Kochetov
9ddd7b98cc Fix tests. 2020-06-19 12:47:15 +03:00
Mikhail Filimonov
9609bd9dee Kafka better states, formats based on PeekableReadBuffer, and other minor fixes.
Add formats tests, fixes for JSONCompactEachRowWithNamesAndTypes, TSVWithNamesAndTypes. Some CR fixes
Add sanitizing for kafka_max_block_size and kafka_poll_max_batch_size
2020-06-19 10:49:05 +02:00
Nikolai Kochetov
6708ae75f3 Fix build. 2020-06-19 11:30:21 +03:00
Nikolai Kochetov
cda4de40d7 Merge branch 'master' into query-plan 2020-06-19 11:29:15 +03:00
alesapin
67062f45be Merge branch 'master' into atomic_metadata5 2020-06-19 11:09:03 +03:00
Anton Popov
36b9847d9a
Merge pull request #11768 from CurtizJ/any-input-optimize
Sligtly better code after #11529.
2020-06-19 03:36:49 +03:00
tavplubix
bed1f37790
Merge pull request #11214 from Potya/multiword_data_type
Add some multiword data types
2020-06-18 23:47:37 +03:00
Nikolai Kochetov
1f013208db Fix style. 2020-06-18 23:11:42 +03:00
alesapin
009977c20c Fix locks 2020-06-18 22:45:37 +03:00
Nikolai Kochetov
de6ef17d27 Fix QueryPipeline::unitePipelines 2020-06-18 22:42:28 +03:00
Ruslan
f44dbcd2ab
Fix crash in min(multiply(1)) with optimize_arithmetic_operations_in_aggregate_functions (#11756) 2020-06-18 22:25:28 +03:00
Nikolai Kochetov
26161aac8a Fix ReadFromStorageStep 2020-06-18 22:17:21 +03:00
Nikolai Kochetov
6cbdb6da00 Fix build. 2020-06-18 22:03:21 +03:00
Azat Khuzhin
d34e6217bc Add logging of adjusting conditional settings for distributed queries 2020-06-18 21:49:29 +03:00
Azat Khuzhin
6507247328 optimize_skip_unused_shards=2 will disable it for nested distributed queries
P.S. Looks like settings can be converted between SettingUInt64 and
SettingBool without breaking binary protocol.

FWIW maybe it is a good idea to change the semantics of the settings as
follow (but I guess that changing semantic is not a good idea, better to
add new settings and deprecate old ones):
- optimize_skip_unused_shards -- accept nesting level on which the
  optimization will work
- force_skip_optimize_shards_nesting -- accept nesting level on which
  the optimization will work
2020-06-18 21:49:29 +03:00
Azat Khuzhin
041533eae2 Disable optimize_skip_unused_shards if sharding_key has non-deterministic func
Example of such functions is rand()

And this patch disables only optimize_skip_unused_shards, i.e. INSERT
code path does not changed, so it will work as before.
2020-06-18 21:49:29 +03:00
Nikolai Kochetov
0ba7ff85e1 Fix build. 2020-06-18 21:45:27 +03:00
Nikolai Kochetov
7bfb5c9a47 Fix build. 2020-06-18 21:40:02 +03:00
Nikolai Kochetov
a99d9f7712 Fix build. 2020-06-18 21:36:37 +03:00
Nikolai Kochetov
b7bed87a7f Use QueryPlan in InterpreterSelectQuery [part 3]. 2020-06-18 21:29:33 +03:00
Nikolai Kochetov
45adacf0bc Use QueryPlan in InterpreterSelectQuery [part 2]. 2020-06-18 20:45:00 +03:00
alesapin
2ca9cfa753 Merge branch 'master' into atomic_metadata5 2020-06-18 20:28:01 +03:00