Commit Graph

185 Commits

Author SHA1 Message Date
chertus
73d6784c59 join right table nulls 2019-07-03 22:06:34 +03:00
alexey-milovidov
d81ae49f2c
Merge pull request #5755 from 4ertus2/bugs
Fix wrong ColumnConst.isColumnNullable()
2019-07-03 02:06:07 +03:00
chertus
207145025c Join.h refactoring: extract joinDispatch into own file 2019-07-02 17:38:31 +03:00
chertus
0c634129da add IColumn.isNullable() 2019-07-01 14:44:19 +03:00
chertus
f19dee706a move IColumn.isColumnConst() outside of interface 2019-06-27 22:28:52 +03:00
chertus
db7c8748e9 remove IColumn.isColumnNullable() 2019-06-27 21:50:20 +03:00
chertus
68034103bb fix arrayIndex for new columns's isNullable 2019-06-27 15:49:08 +03:00
chertus
65c0d23efa better casts to ColumnNullable 2019-06-26 20:20:33 +03:00
chertus
b166791176 batched version of RowRefList 2019-05-14 17:40:43 +03:00
chertus
6200d20dc2 RowRefList refactoring 2019-05-14 17:39:03 +03:00
chertus
4969ad2f98 correct comment & some renames 2019-05-08 13:53:45 +03:00
chertus
74feef7e53 Join.h refactoring: remove unneeded specialisations 2019-05-07 21:21:44 +03:00
Martijn Bakker
f96a7e401e remove the list lookup and prevent the global lock 2019-04-05 18:59:48 +01:00
chertus
d5ffbd9b6d fix multithreaded ASOF JOIN crash 2019-04-02 21:50:35 +03:00
chertus
04efcf2bdc asof refactoring (searching for the crash reason) 2019-04-02 19:22:14 +03:00
chertus
9ed4ac7e82 get rid of macro in AsofRowRefs 2019-04-01 19:44:15 +03:00
Martijn Bakker
d4ec3bbf70 fix style 2019-04-01 11:35:37 +01:00
Martijn Bakker
a64b8afc7e cleanup 2019-04-01 00:09:00 +01:00
Martijn Bakker
27776ca929 fix up wrong assumption that the sample_block_with_keys has same ordering as key_names_right 2019-03-31 22:56:37 +01:00
Martijn Bakker
7ea03f6fa7 appears to work and get the correct timestamps 2019-03-31 22:14:43 +01:00
Martijn Bakker
4a7393cfc6 include the asof column in the block stored. overall not working yet but at least doesnt crash anymore 2019-03-31 20:03:57 +01:00
Martijn Bakker
4709b744bb address the code review issues 2019-03-30 21:30:21 +00:00
Martijn Bakker
4a94545882 add test for multiple supported asof types 2019-03-30 12:52:48 +00:00
Martijn Bakker
7c5febb6aa Merge branch 'master' into martijn-asof-nomap 2019-03-30 02:02:48 +00:00
Martijn Bakker
389f108807 working multi type asof join columns 2019-03-30 01:32:08 +00:00
Martijn Bakker
89515861df asof join without using std::map, but still only on u32 2019-03-29 21:20:23 +00:00
chertus
6bdbf75e30 fix crash when joining nulluble vs not nullable 2019-03-29 21:07:22 +03:00
Martijn Bakker
9ac52b9368 fix master merge 2019-03-28 21:06:49 +00:00
Martijn Bakker
46f4557944 Merge branch 'master' into martijn-asof-join 2019-03-28 20:20:17 +00:00
Martijn Bakker
e7a10b8a3e add inner asof join with tests 2019-03-28 19:31:11 +00:00
Martijn Bakker
817a9244c0 fix up code style 2019-03-28 19:03:57 +00:00
Martijn Bakker
b0fd915724 remove the ASOFSplit struct 2019-03-28 18:35:50 +00:00
chertus
2a5b4b3b31 fix ANY JOIN nulls in right key (ALL JOIN is still affected) 2019-03-27 16:37:11 +03:00
chertus
e92dcd4774 fix clang release build 2019-03-27 01:47:38 +03:00
Martijn Bakker
ac68fc8088 pass the half-enforced style checks such that they cannot be run on a whole file automatically :( 2019-03-26 22:05:51 +00:00
Martijn Bakker
84f40ddf02 fix build as cpp does not do partial function specialization 2019-03-26 20:13:15 +00:00
chertus
0a0e986f75 fix crash on join not nullable with nullable 2019-03-26 22:46:03 +03:00
Martijn Bakker
f6987cfa52 have the parser recognize asof joins and feed them through to the executor
insert the time series into a struct ready for joining

working version that inserts the data into the hash table using the existing dispatching machinery for various types

working asof left join in clickhouse

add a test for the asof join

do some asof join cleanup

revisit the logic in case the values match between left and right side
2019-03-26 19:17:21 +00:00
chertus
b1f4cc6ed2 fix left join with const column 2019-03-20 20:20:14 +03:00
chertus
2ea11f8528 more Joins.cpp refactoring (constexpr if) 2019-03-20 18:52:41 +03:00
chertus
efa4a2bb18 minor changes 2019-03-20 18:15:44 +03:00
chertus
2713d36ce8 syntax: remove tab 2019-03-20 17:49:05 +03:00
chertus
1bb05eb089 more Join.cpp refactoring (hide some logic into AddedColumns) 2019-03-20 17:41:35 +03:00
chertus
2a4da2f687 more refactoring (rename misleading variable) 2019-03-20 16:38:17 +03:00
chertus
e1f015295b rename functions & add comment 2019-03-20 15:28:45 +03:00
chertus
ef2d77f946 some more refactoring 2019-03-20 15:08:38 +03:00
chertus
e5a9633132 Join.cpp refactoring 2019-03-19 19:53:36 +03:00
chertus
09a3b24cbc join kind helpers 2019-03-11 14:14:09 +03:00
alexey-milovidov
695a2dc35f
Merge pull request #4552 from 4ertus2/bugs
Fix crash on JOIN with array or tuple
2019-03-01 18:49:22 +03:00
chertus
83503df56a fix crach on JOIN with array or tuple 2019-03-01 18:32:32 +03:00