thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-12-15 19:02:04 +00:00
Code Issues Packages Projects Releases Wiki Activity
138,358 Commits 9,326 Branches 1,783 Tags 2.1 GiB
73deb9a24c
Commit Graph

222 Commits

Author SHA1 Message Date
Kseniia Sumarokova
c4b1f537cd
Merge pull request #37879 from Vxider/wv-inner-target-drop 
Do not drop the inner target table when alter WindowView
 2022-06-07 13:00:15 +02:00
Vxider
acda04a3d4 do not drop inner target table when alter windowview 2022-06-06 05:06:02 +00:00
Vxider
d4f0e8d4c2 update code style 2022-06-04 17:14:42 +00:00
Vxider
1f10276686 fire and clean only when data inserted 2022-06-04 16:55:46 +00:00
Kseniia Sumarokova
7632de911d
Merge pull request #37807 from Vxider/deley-cleanup 
Delay schedule of the cleaning task in WindowView
 2022-06-03 19:48:57 +02:00
Kseniia Sumarokova
9c0e838404
Merge pull request #37770 from Vxider/fix-empty-target-id 
Fix empty target table id in WindowView
 2022-06-03 11:23:35 +02:00
Vxider
d3c907cf12 log exception when fire 2022-06-02 18:22:48 +00:00
Vxider
1282d038cc delay schedule of windowview cleanup 2022-06-02 18:21:56 +00:00
Vxider
8221fcd5f1 update var name 2022-06-02 04:38:45 +00:00
Vxider
df4db70bb8 fix empty target table id 2022-06-02 04:28:18 +00:00
Nikolai Kochetov
86fbb74703 Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-05-31 18:07:47 +00:00
Vxider
b24346328d fix parser when using table identifer 2022-05-28 08:22:34 +00:00
Nikolai Kochetov
54d7e4139f Fix build. 2022-05-25 18:16:48 +00:00
Nikolai Kochetov
1b85f2c1d6 Merge branch 'master' into refactor-read-metrics-and-callbacks 2022-05-25 16:27:40 +02:00
Nikolai Kochetov
3d84aae0ab Better. 2022-05-24 20:06:08 +00:00
Nikolai Kochetov
9756b759c6 Move some resources 2022-05-23 13:46:57 +00:00
Vxider
fcd317a642 update windowview create syntax 2022-05-22 10:18:34 +00:00
Vxider
5f84f06d6d simplify windowview 2022-05-22 10:13:16 +00:00
Nikolai Kochetov
56feef01e7 Move some resources 2022-05-20 19:49:31 +00:00
Vxider
956459eba2 Merged with master 2022-05-20 10:50:21 +00:00
Vxider
f6cc73235b Merged with master 2022-05-19 13:03:45 +00:00
Vxider
b2c7ba7cbe update 2022-05-19 12:54:41 +00:00
Vxider
24f1a1fde7 Merge branch 'wv-alter' of https://github.com/Vxider/ClickHouse into wv-populate 2022-05-19 12:49:37 +00:00
vxider
797edb0ae1
Update src/Storages/WindowView/StorageWindowView.cpp 
Co-authored-by: Kseniia Sumarokova <54203879+kssenii@users.noreply.github.com>
 2022-05-19 20:49:02 +08:00
Vxider
1cc347364f Merged with master 2022-05-19 12:45:46 +00:00
Kseniia Sumarokova
b0c7cf910a
Merge pull request #37224 from Vxider/wv-fix-dependency 
Fix addDependency in WindowView
 2022-05-19 13:51:11 +02:00
Vxider
04f1b20229 init inner window names 2022-05-18 14:34:40 +00:00
Vxider
4b5eda4de9 fix cleanup 2022-05-18 11:14:08 +00:00
Vxider
f102497929 fix parser with join query 2022-05-18 08:05:06 +00:00
Vxider
037db32e24 set alter query internal 2022-05-17 13:50:55 +00:00
Vxider
90bac2f004 add shutdown check 2022-05-17 06:20:08 +00:00
Vxider
f74c934a61 Merged with master 2022-05-17 02:53:59 +00:00
mergify[bot]
0d0fc23170
Merge branch 'master' into wv-engine 2022-05-17 02:24:18 +00:00
Vxider
3986e82b19 Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into wv-populate 2022-05-17 02:18:17 +00:00
Kseniia Sumarokova
f073efc025
Merge pull request #37225 from Vxider/wv-fix-cleanup 
Fix WindowView cleanup
 2022-05-16 22:39:58 +02:00
Vxider
8f271159bf check null pointer 2022-05-16 13:59:55 +00:00
Vxider
b3a731c226 fix build 2022-05-16 12:51:19 +00:00
Vxider
6b3b744e3f fix data race 2022-05-16 11:31:49 +00:00
Vxider
95e6e5aef7 fix window view dependency 2022-05-16 08:41:32 +00:00
Vxider
9201df7cde update code style 2022-05-16 02:00:39 +00:00
Vxider
77ad48fee9 fix build 2022-05-15 17:40:42 +00:00
Vxider
15b35c1910 speed up windowview watch 2022-05-15 17:14:53 +00:00
Vxider
18ee285ce1 fix windowview cleanup 2022-05-15 16:50:34 +00:00
Vxider
93fec4ebc7 remove dependency when drop windowview 2022-05-15 16:12:24 +00:00
Vxider
033b1e7f82 add lock for cleanup query 2022-05-15 11:18:42 +00:00
Vxider
6c2d78b802 rename var 2022-05-15 11:18:23 +00:00
Vxider
65779adf8b update code style 2022-05-15 07:07:27 +00:00
Vxider
4ed79cd9e1 fix windowview watch 2022-05-15 06:45:25 +00:00
Vxider
f459dd5aba change windowview engine behaviour 2022-05-14 16:46:49 +00:00
Vxider
f2ef27e5d6 rename windowview header 2022-05-14 09:21:54 +00:00
Vxider
b52cac970d fix alter on replicated engine 2022-05-14 06:35:50 +00:00
mergify[bot]
4e184306c1
Merge branch 'master' into wv-alter 2022-05-14 02:11:46 +00:00
Vxider
9a0cc75f3a update code style 2022-05-13 14:13:14 +00:00
Vxider
930939ef75 update code style 2022-05-13 13:38:53 +00:00
Vxider
3ecd9f972a alter table support for windowview 2022-05-13 12:51:51 +00:00
Vxider
07aaa92299 fix windowview watch 2022-05-13 09:25:50 +00:00
Vxider
83c2ee8c8b fix build 2022-05-13 00:28:44 +08:00
Vladimir C
182ba1c605
Merge pull request #36928 from Vxider/wv-fix-multiple-columns 2022-05-12 18:28:15 +02:00
Vxider
dc33c3a9bb Merged with master 2022-05-12 23:04:07 +08:00
mergify[bot]
7ffad69019
Merge branch 'master' into wv-populate 2022-05-12 11:52:04 +00:00
Vxider
5211b12bdd fix windowview cleanup for database replicated 2022-05-12 13:13:36 +08:00
mergify[bot]
c9cb5496cd
Merge branch 'master' into wv-read 2022-05-12 01:57:34 +00:00
Vxider
e65cfaecf8 remove unused code 2022-05-12 00:18:47 +08:00
Vxider
07fe7f5c09 disable read when windowview has no target table 2022-05-11 09:16:26 +00:00
Vxider
3dfede3165 support read for windowview 2022-05-11 09:00:49 +00:00
Vxider
e4f43d0b01 update getSampleBlock for windowview 2022-05-11 08:47:08 +00:00
Vxider
9ed1e4f7e6 fix build 2022-05-10 16:36:56 +00:00
Sergei Trifonov
376e556474
Merge pull request #36861 from Vxider/fix-fire-hop-window 
Fix fire in window view with hop window
 2022-05-10 09:25:24 +02:00
Vxider
5d0a5d34c8 removing function populate in windowview 2022-05-10 15:06:58 +08:00
Vxider
8c3c80f84c rename parent table to source table 2022-05-10 14:54:36 +08:00
Vxider
34f1821eb9 function now support for windowview populate 2022-05-08 23:43:08 +08:00
Vxider
712d046d04 Merged with master 2022-05-08 18:18:52 +08:00
Vxider
e7c4eb2697 Merged with master 2022-05-08 18:15:31 +08:00
Kseniia Sumarokova
fac59dfd97
Merge pull request #36998 from Vxider/removing-replacing-wv-transform 
Removing ReplacingWindowColumnTransform in WindowView
 2022-05-08 12:11:44 +02:00
Vxider
aab6b1e8b5 update code style 2022-05-07 17:33:42 +00:00
Vxider
72a634b5c6 removing-replacing-window-column-transform 2022-05-07 08:41:51 +00:00
Vxider
c4b357d5cb update 2022-05-07 08:34:52 +00:00
Vxider
1966bb6504 fix stuck when drop source table in windowview 2022-05-06 12:34:00 +00:00
Vxider
5a8479446a simplify code 2022-05-06 14:35:10 +08:00
Vxider
38fec0ed4d update code style 2022-05-06 14:30:31 +08:00
Vxider
ceef3b480c update 2022-05-06 11:08:59 +08:00
Vxider
9eea003d69 Merged with master 2022-05-06 00:12:17 +08:00
Vxider
a7dc1f48e5 populate support for windowview 2022-05-05 23:31:15 +08:00
Vxider
966733ef8d rename 2022-05-05 23:19:54 +08:00
mergify[bot]
eba26ec956
Merge branch 'master' into fix-fire-hop-window 2022-05-05 13:11:34 +00:00
Vxider
ffe1e3a5a1 update 2022-05-05 17:43:23 +08:00
Vxider
840ecc68ae wv-fix-multiple-columns 2022-05-05 14:27:12 +08:00
Vxider
407c14251a simplify code 2022-05-04 20:56:09 +08:00
vxider
0617ce01c9
simplify code 
Co-authored-by: Sergei Trifonov <svtrifonov@gmail.com>
 2022-05-04 20:51:12 +08:00
Vxider
ecca2f23f7 simplify code 2022-05-04 04:02:13 +00:00
Robert Schulze
777b5bc15b
Don't let storages inherit from boost::noncopyable 
... IStorage has deleted copy ctor / assignment already
 2022-05-03 09:07:08 +02:00
Vxider
afbdb8fccc fix fire in hop window 2022-05-03 12:42:42 +08:00
Robert Schulze
330212e0f4
Remove inherited create() method + disallow copying 
The original motivation for this commit was that shared_ptr_helper used
std::shared_ptr<>() which does two heap allocations instead of
make_shared<>() which does a single allocation. Turned out that
1. the affected code (--> Storages/) is not on a hot path (rendering the
performance argument moot ...)
2. yet copying Storage objects is potentially dangerous and was
   previously allowed.

Hence, this change

- removes shared_ptr_helper and as a result all inherited create() methods,

- instead, Storage objects are now created using make_shared<>() by the
  caller (for that to work, many constructors had to be made public), and

- all Storage classes were marked as noncopyable using boost::noncopyable.

In sum, we are (likely) not making things faster but the code becomes
cleaner and harder to misuse.
 2022-05-02 08:46:52 +02:00
Robert Schulze
89aa9ae00f
Fixed clang-tidy check "bugprone-branch-clone" 
The check is currently *not* part of .clang-tidy. It complains about:
(1) "switch has multiple consecutive identical branches"
(2) "repeated branch in conditional chain"

About (1): Lots of findings in switches were about redundant
"[[fallthrough]]" in places where the compiler would not warn anyways. I
have cleaned these up.

About (2): In if-else_if-else chains, fixing the warning would usually
mean concatenating multiple if-conditions. As this would reduce
readability in most cases, I did not fix these places.

Because of (2), I also refrained from adding "bugprone-branch-clone" to
.clang-tidy.
 2022-04-30 19:40:28 +02:00
Amos Bird
4a5e4274f0
base should not depend on Common 2022-04-29 10:26:35 +08:00
fenglv
cac2df914b fix 2022-04-10 17:28:17 +00:00
fenglv
24e86f81cb Fix window view when is proc time and window kind larger than day 
fix
 2022-04-10 17:26:09 +00:00
fenglv
97523a3329 Try remove unneed variable 2022-04-01 09:58:23 +00:00
fenglv
e2e4b02d13 remove unused variable 2022-03-31 12:01:10 +00:00
mergify[bot]
e11ef05c2b
Merge branch 'master' into issue_33147 2022-03-21 13:40:17 +00:00