Commit Graph

73984 Commits

Author SHA1 Message Date
Mike Kot
5d38930a3c Fixing gcc build due to a bug in compiler 2021-10-02 14:27:52 +02:00
Azat Khuzhin
74a7a0603d test/fuzzer: print stacktrace
To get the stacktrace for errors w/o it [1]:

    SET max_parser_depth = 4000

    Got boring AST
    Code: 306. DB::Exception: Maximum parse depth (1000) exceeded. Consider rising max_parser_depth parameter. (TOO_DEEP_RECURSION)

  [1]: https://clickhouse-test-reports.s3.yandex.net/29513/769bfbe71f22c392458eced655080a0bbd442e02/fuzzer_ubsan/fuzzer.log
2021-10-02 12:49:44 +03:00
alexey-milovidov
654b9b1234
Merge pull request #29605 from qoega/compressed-buffer-fuzz
Improve CompressedReadBuffer
2021-10-02 12:04:01 +03:00
alexey-milovidov
86d1ce63cf
Merge pull request #29649 from CurtizJ/merging-29376
Merging #29376
2021-10-02 12:02:42 +03:00
Azat Khuzhin
0b6063a902 Disable merges for parallel_mv 2021-10-02 11:54:47 +03:00
Alexey Milovidov
ed54a4c944 Fix build 2021-10-02 11:49:25 +03:00
Alexey Milovidov
922872fb9a Move modelEvaluate function to its own file 2021-10-02 11:39:26 +03:00
Alexey Milovidov
2ad5dbdfe8 Rename "common" to "base" 2021-10-02 11:30:38 +03:00
Azat Khuzhin
4d5ca0f409 client: do not try to fuzz USE queries 2021-10-02 11:17:17 +03:00
Azat Khuzhin
a419fe6633 client: don not try to fuzz SET queries
They were forbidden in QueryFuzzer.cpp anyway, this is just a patch to
avoid trying to do this and update comment.
2021-10-02 11:16:53 +03:00
kssenii
e10255bba3 Fix 2021-10-02 08:10:34 +00:00
Alexey Milovidov
fe6b7c77c7 Rename "common" to "base" 2021-10-02 10:13:14 +03:00
alexey-milovidov
93a11d7444
Update adopters.md 2021-10-02 09:33:53 +03:00
alexey-milovidov
41924c9a2b
Merge pull request #29594 from azat/glibc-compact
Add ability to compile using newer version fo glibc w/o using new symbols
2021-10-02 06:24:13 +03:00
alexey-milovidov
f21ea8f160
Update CompressedReadBufferBase.cpp 2021-10-02 06:13:46 +03:00
alexey-milovidov
9025f522ec
Merge pull request #29603 from qoega/improve-integration-2
Improve some more integration tests
2021-10-02 06:09:24 +03:00
Anton Popov
bb92ff52d8
Update IMergeTreeDataPart.cpp 2021-10-02 00:50:19 +03:00
Anton Popov
d404efbf7e add test for freeze in-memory parts 2021-10-01 22:05:36 +03:00
Maksim Kita
ad6d143303
Merge pull request #29574 from kitaisreal/jit-fix-short-circuit-with-alias
ExpressionJIT fix short-circuit with alias
2021-10-01 21:18:31 +03:00
Nikolai Kochetov
754f7aafeb
Merge pull request #29608 from ClickHouse/fix-many-signals-in-integration-tests
Do not send many signals at server restart (integration tests).
2021-10-01 21:09:00 +03:00
Azat Khuzhin
769bfbe71f Fix server pid in fuzzer tests
Previously it was the pid of the subshell 40 while it should be the pid
of the clickhouse-server 39:

Here we see that the server pid is 39:

    2021-09-28 11:02:34	 + pgrep -f clickhouse-server
    2021-09-28 11:02:34	 39

Here we see that the 40 is the pid of subshell:

    2021-09-28 11:02:45	 ch/docker/test/fuzzer/run-fuzzer.sh: line 90:    39 Killed                  clickhouse-server --config-file db/config.xml -- --path db 2>&1
    2021-09-28 11:02:45	         40 Done                    | tail -100000 > server.log

And here we see that server_pid variable is 40:

    2021-09-28 11:02:45	 + server_exit_code=0
    2021-09-28 11:02:45	 + wait 40

v2: wait in background to call wait in foreground and ensure that the
process is alive, since w/o job control this is the only way to obtain
the exit code
2021-10-01 21:05:30 +03:00
Azat Khuzhin
9d69786a6b Increase listen_backlog by default (to match default in newer linux kernel)
It was 64 for a long time, and even linux kernel never has such a small
limit, it had 128 (net.core.somaxconn sysctl).

But recently, in 5.4, the default value had been increased even in
linux kernel, to 4096 [1].

  [1]: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=19f92a030ca6d772ab44b22ee6a01378a8cb32d4

Let's increase it in ClickHouse too.

Also note, that I've looked through some instances with
clickhouse-server only, and TcpExtListenOverflows was non zero (`nstat
-za`), in other words backlog of the listen socket indeed overflowed
there.

So it is better to increase the default to move the problem to
clickhouse-server itself (yes you will unlikely have 4K new incomming
connections at one time, with accept thread do not accept them all, but
still seems that it is possible, maybe due to some locks or something
else).
2021-10-01 21:03:59 +03:00
Azat Khuzhin
cab0551c5b Add ability to compile using newer version fo glibc w/o using new symbols
In glibc 2.32 new version of some symbols had been added [1]:

    $ nm -D clickhouse | fgrep -e @GLIBC_2.32
                     U pthread_getattr_np@GLIBC_2.32
                     U pthread_sigmask@GLIBC_2.32

  [1]: https://www.spinics.net/lists/fedora-devel/msg273044.html

Right now ubuntu 20.04 is used as official image for building
ClickHouse, however once it will be switched someone may not be happy
with that fact that he/she cannot use official binaries anymore because
they have glibc < 2.32.

To avoid this dependency, let's force previous version of those
symbols from glibc.

Note, that I've tested this by compiling with glibc 2.32 and verifying
that output ELF does not have @GLIBC_2.32 symbols and also running that
binary inside ubuntu:20.04 image (that has glibc 2.31).

v1: -Wl,--wrap
v2: -Wl,--defsym
v3: -include
v4: fix versioning for aarch64
2021-10-01 21:01:59 +03:00
Vitaly Baranov
27f6d5864d
Merge pull request #29060 from azat/inter-server-secret-auth-fix
Do not allow to reuse previous credentials in case of inter-server secret
2021-10-01 20:44:48 +03:00
kssenii
dabab85c60 Fix 2021-10-01 17:31:00 +00:00
Anton Popov
f0363c524d Merge branch 'master' of git://github.com/mo-avatar/ClickHouse into merging-29376 2021-10-01 20:29:33 +03:00
sevirov
ec2e36c4cf
Update docs/en/operations/storing-data.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-01 20:24:31 +03:00
sevirov
6617ff3da1
Update docs/en/operations/storing-data.md
Co-authored-by: olgarev <56617294+olgarev@users.noreply.github.com>
2021-10-01 20:24:24 +03:00
Mike Kot
e8625e85a4 Fixing integration tests 2021-10-01 19:13:14 +02:00
Anton Popov
9c296e94f3 fix performance of updatePermutation 2021-10-01 19:45:17 +03:00
Maksim Kita
57666725f9
Merge pull request #29623 from kitaisreal/bloom-filter-indexes-map-support-fix-unsafe-identifier-cast
BloomFilter indexes map data type support fix unsafe identifier cast
2021-10-01 19:28:04 +03:00
Maksim Kita
94117f83ad
Merge pull request #29636 from kitaisreal/map-get-non-const-key-added-test
Map get non const key added test
2021-10-01 19:27:46 +03:00
Nikita Mikhaylov
b2f7b6fae8
Fix race between MergeTask and storage destruction (#29614) 2021-10-01 18:55:04 +03:00
kssenii
04e159b42c Merge branch 'master' of https://github.com/ClickHouse/ClickHouse into fix-signals 2021-10-01 15:54:52 +00:00
Mike Kot
282aa6009b Merge branch 'improvement/fn-traits' of github.com:myrrc/ClickHouse into improvement/fn-traits 2021-10-01 16:56:59 +02:00
Mike Kot
38b02b121a Merge remote-tracking branch 'upstream/master' into improvement/fn-traits 2021-10-01 16:55:28 +02:00
Mike Kot
5e560ff9d7 fix 2021-10-01 16:55:01 +02:00
Maksim Kita
a58cc620e9 Map get non const key added test 2021-10-01 17:54:40 +03:00
Maksim Kita
2fd9b3e6f3
Merge pull request #29627 from den-crane/patch-29
Doc. warning about systems with small RAM
2021-10-01 17:34:11 +03:00
Maksim Kita
fe6bb1bb1e Fixed tests 2021-10-01 17:33:14 +03:00
Denny Crane
6a1f6f799f
Update tips.md
warning about system with small RAM
2021-10-01 11:24:06 -03:00
kssenii
05181c6900 Fix 2021-10-01 14:13:02 +00:00
Maksim Kita
26b8d4c480 Fixed test 2021-10-01 17:10:28 +03:00
Maksim Kita
4a480699bd Added tests 2021-10-01 16:44:09 +03:00
Vladimir C
ec966b7df5
Merge pull request #27933 from mathalex/numeric_tuple_functions 2021-10-01 16:18:52 +03:00
Maksim Kita
c793c8e7fa BloomFilter indexes map data type support fix unsafe identifier cast 2021-10-01 14:40:00 +03:00
alesapin
53fce1411c
Merge pull request #29597 from ClickHouse/fix-docker-image
Fix docker/test/util declaration
2021-10-01 13:43:17 +03:00
olgarev
1020c25830 Links repaired 2021-10-01 10:06:26 +00:00
Nikolai Kochetov
291a8332b9 Do not send many signals at server restart (integration tests). 2021-10-01 12:52:24 +03:00
Maksim Kita
30220529b7
Merge pull request #29573 from ClickHouse/fix_segfault_in_add_database_visitor
Fix nullpointer dereference in AddDefaultDatabaseVisitor
2021-10-01 12:44:15 +03:00