Commit Graph

13071 Commits

Author SHA1 Message Date
kssenii
607a9d761b Fix 2024-04-02 19:04:02 +02:00
kssenii
9b74e246af Rename a method 2024-04-02 19:03:54 +02:00
alesapin
add92939da
Merge d11d10050b into e037e68130 2024-04-02 16:08:10 +00:00
alesapin
f5c5146153 [RFC] Try to add global Real and CPU trace collector 2024-04-02 18:04:53 +02:00
kssenii
c11aa01226 Fix race 2024-04-02 17:58:59 +02:00
Dmitry Novik
40b9f39c00 Analyzer: Fix query parameters 2024-04-02 17:47:00 +02:00
vdimir
e037e68130
Merge pull request #62050 from ClickHouse/vdimir/dictioary_reload_twice_on_start2
Resubmit 'Update invalidate_query_response on dictionary startup'
2024-04-02 17:37:45 +02:00
kssenii
7285a55f69 One more 2024-04-02 17:08:32 +02:00
Raúl Marín
c35a436435 Remove nested dependency on DateLutImpl 2024-04-02 14:45:48 +02:00
Raúl Marín
40a22ffa63 Remove a few nested include dependencies 2024-04-02 13:43:14 +02:00
kssenii
fb94a95425 Add logging 2024-04-02 12:23:22 +02:00
Raúl Marín
48ab0721a8 Unify lightweight mutation control 2024-04-02 11:52:14 +02:00
Han Fei
89108202d5
Merge pull request #58705 from zhongyuankai/drop_tables
Supports DROP multiple tables
2024-04-01 22:43:55 +02:00
Nikolai Kochetov
686534a460
Merge pull request #61992 from kitaisreal/aggregator-parallel-merge-cancellation
Aggregator parallel merge cancellation
2024-03-29 19:25:38 +01:00
zhongyuankai
79b486b8bf batter 2024-03-29 09:53:50 +08:00
Han Fei
419ac380f1
Merge pull request #61953 from hanfei1991/hanfei/fix-quorum-retry
fix logical-error when undoing quorum insert transaction
2024-03-28 20:49:32 +01:00
kssenii
1d453af6ff Fix style check 2024-03-28 16:47:22 +01:00
vdimir
0b85d8570b
Resubmit 'Update invalidate_query_response on dictionary startup' 2024-03-28 16:46:44 +01:00
kssenii
19b90d8348 Resolve conflicts after merge, add system.filesystem_cache_settings 2024-03-28 16:28:59 +01:00
kssenii
15768ffce6 Merge remote-tracking branch 'origin/master' into better-dynamic-cache-resize-part-2 2024-03-28 16:28:18 +01:00
Kruglov Pavel
70bb85a754
Merge pull request #61999 from Avogar/variant-number-bool
Don't treat Bool and number variants as suspicious in Variant type
2024-03-28 14:33:24 +01:00
Kseniia Sumarokova
0244e0851a
Merge pull request #61954 from ClickHouse/follow-up-broken-projections
Follow up to #60452
2024-03-28 14:23:28 +01:00
Han Fei
a0d27e45b9
Merge branch 'master' into drop_tables 2024-03-28 13:56:50 +01:00
Yarik Briukhovetskyi
003d258ba1
Merge pull request #61862 from HowePa/truncate_all_tables
add TRUNCATE ALL TABLES
2024-03-28 13:32:46 +01:00
Kseniia Sumarokova
5ba2ad53b6
Merge pull request #61163 from ClickHouse/filecache-better-try-reserve
Less contention in cache, part 3
2024-03-28 13:24:22 +01:00
Maksim Kita
a376a7354f Fixed code review issues 2024-03-28 15:04:14 +03:00
zhongyuankai
7938a8e62b Merge branch 'master' into drop_tables 2024-03-28 20:00:56 +08:00
Alexander Tokmakov
a0b9b888ee
Merge pull request #61799 from ClickHouse/more_secondary_create
Skip more sanity checks for secondary create queries
2024-03-28 10:01:05 +01:00
avogar
043c625898 Don't treat Bool and number variants as suspicious 2024-03-27 19:19:08 +00:00
Han Fei
e849c48e21 add a test 2024-03-27 18:56:13 +01:00
Maksim Kita
d8b06588b8 Aggregator parallel merge cancellation 2024-03-27 20:14:52 +03:00
Igor Nikonov
15a0f5381f
Merge pull request #59176 from azat/dist/readonly-replicas
Add ability to skip read-only replicas for INSERT into Distributed engine
2024-03-27 13:19:12 +01:00
Yarik Briukhovetskyi
844bb4f06c
Merge pull request #61727 from yariks5s/fix_undrop_query
Revert "Revert "Un-flake test_undrop_query""
2024-03-27 13:12:50 +01:00
Kseniia Sumarokova
af66e1f7c4
Fix style check 2024-03-27 11:25:58 +01:00
kssenii
0a5ce69880 Review fix 2024-03-26 22:02:50 +01:00
kssenii
dc83eb1ad6 Review fixes 2024-03-26 21:43:54 +01:00
kssenii
a777045dd3 Fix and more tests for broken projections handling 2024-03-26 18:47:48 +01:00
shabroo
8e8bc83d36
Update Context.cpp
@alexey-milovidov please stop torturing me and accept this commit.
2024-03-26 17:37:27 +01:00
Yarik Briukhovetskyi
d8bfdf040f
has_all -> has_all_tables 2024-03-26 16:58:36 +01:00
Azat Khuzhin
b9469e2729 Do not try to INSERT into readonly replicas for Distributed engine
Sometimes replica may be readonly for a long time, and this will make
some INSERT queries fail, but it does not make sense to INSERT into
readonly replica, so let's ignore them.

But note, that this will require to extend TableStatus (not extend, but
introduce new version), that will have is_readonly field.

Also before background INSERT into Distributed does not uses
getManyChecked() which means that they do not request TableStatus
packet, while now they would, though this is minor (just a note).

v2: Add a note about max_replica_delay_for_distributed_queries for INSERT
v3: Skip read-only replicas for async INSERT into Distributed
v4: Remove extra @insert parameter for ConnectionPool*::get*
    It make sense only when the table name had passed --
    ConnectionPoolWithFailover::getManyChecked()
v5: rebase on top LoggerPtr
v6: rebase
v7: rebase
v8: move TryResult::is_readonly into the end

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-26 11:21:38 +01:00
vdimir
802d6a2dac
Merge pull request #59007 from ClickHouse/vdimir/using_alias_followup
Analyzer: fixes for JOIN columns resolution
2024-03-26 10:36:50 +01:00
Kseniia Sumarokova
fd8e34a0ba
Merge pull request #60452 from ClickHouse/revert-refert-of-broken-projections-handling
Revert "Revert "Merge pull request #56864 from ClickHouse/broken-projections-better-handling""
2024-03-26 10:34:48 +01:00
Alexey Milovidov
9b052d059d No "please" 2024-03-26 09:00:20 +01:00
zhongyuankai
aa3830a3db Merge branch 'master' into drop_tables 2024-03-26 14:09:04 +08:00
zhongyuankai
8af5682395 batter 2024-03-26 13:02:12 +08:00
pufit
cad66f3e68
Fix ALTER QUERY MODIFY SQL SECURITY (#61480) 2024-03-25 20:03:02 -04:00
avogar
2e066966b1 Add log message, use storesDataOnDisk method 2024-03-25 22:17:43 +00:00
Kruglov Pavel
de1229ba60
Merge branch 'master' into better-stress-upgrade-checks 2024-03-25 19:18:35 +01:00
kssenii
5100b0d52e Fix typo 2024-03-25 17:04:44 +01:00
Alexey Milovidov
dc6d713658
Merge pull request #60774 from canhld94/zookeeper_log_us
Change column name from duration_ms to duration_us in system.zookeeper
2024-03-25 18:07:58 +03:00
Alexey Milovidov
24261476c4
Merge pull request #61820 from ClickHouse/get-client-http-header
Add a new function `getClientHTTPHeader`
2024-03-25 17:48:24 +03:00
kssenii
e3d2fb28cf Merge remote-tracking branch 'origin/master' into revert-refert-of-broken-projections-handling 2024-03-25 13:54:39 +01:00
kssenii
513bb7ddbb Minor 2024-03-25 13:54:06 +01:00
Sergei Trifonov
10c6152aac
Merge pull request #61546 from ClickHouse/more-log-for-async-loader
More logging for loading of tables
2024-03-25 13:12:45 +01:00
Yarik Briukhovetskyi
8bdbfce43c
Merge branch 'master' into fix_undrop_query 2024-03-25 13:06:46 +01:00
kssenii
f7ef5734fa Add more comments 2024-03-25 12:10:26 +01:00
HowePa
d38534e047 add TRUNCATE ALL TABLES 2024-03-25 15:59:15 +08:00
zhongyuankai
64961edb3f Merge branch 'master' into drop_tables 2024-03-25 11:13:26 +08:00
zhongyuankai
7e264839c9 bug fix 2024-03-25 11:04:12 +08:00
Alexey Milovidov
cbf3b5ea02 Fix error 2024-03-25 03:41:52 +01:00
Alexey Milovidov
d488d4fac5 Remove unused headers 2024-03-25 03:38:47 +01:00
Alexey Milovidov
e3dd42131c Fix build 2024-03-25 03:38:47 +01:00
Alexey Milovidov
4813014710 Merge with master 2024-03-25 03:38:47 +01:00
Alexey Milovidov
29d51d71b7 Fix the name 2024-03-25 03:38:47 +01:00
Duc Canh Le
271342a871 change column name from duration_ms to duration_us in system.zookeeper
Signed-off-by: Duc Canh Le <duccanh.le@ahrefs.com>
2024-03-25 03:38:46 +01:00
Alexey Milovidov
3d5908b876 Merge branch 'master' into get-client-http-header 2024-03-25 03:27:18 +01:00
Alexey Milovidov
8c6a6f2b71
Merge pull request #61832 from azat/dist/flush-settings
Add ability to override initial INSERT SETTINGS via SYSTEM FLUSH DISTRIBUTED
2024-03-25 03:09:01 +03:00
Alexey Milovidov
baef1cd4d2 Merge branch 'master' into get-client-http-header 2024-03-24 21:37:14 +01:00
Azat Khuzhin
35722be8ec Add ability to override initial INSERT SETTINGS via SYSTEM FLUSH DISTRIBUTED
This is useful to overwrite settings in the initial query during force
flush with SYSTEM FLUSH DISTRIBUTED.

For example imagine that your server is out of queries
(max_max_concurrent_queries_for_all_users had been reached), but you
want to flush the distributed table anyway, after this patch you can
use something like this:

    SYSTEM FLUSH DISTRIBUTED dist SETTINGS max_concurrent_queries_for_all_users=1000000

And also fix flush_on_detach for SYSTEM FLUSH DISTRIBUTED, it should
ignore flush_on_detach.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-03-24 21:32:34 +01:00
Alexey Milovidov
51aada55b1
Merge pull request #61736 from ClickHouse/cucurbita
Fix segfault in SquashingTransform
2024-03-24 22:01:41 +03:00
kssenii
b87b280e38 Adjust check for duplicate queue entry 2024-03-24 15:15:59 +01:00
Alexey Milovidov
008c252a26
Merge pull request #61365 from evillique/fix-attach-on-cluster
Fix ATTACH query with external ON CLUSTER
2024-03-24 04:17:42 +03:00
kssenii
b91184219d SLRU: disallow concurrent priority increase if there is unfinished space reservation 2024-03-23 22:29:29 +01:00
Alexey Milovidov
e195806c5b Add function getClientHTTPHeader, part 1 2024-03-23 20:52:26 +01:00
Antonio Andelic
61e74cc2df
Merge pull request #61752 from ClickHouse/keeper-destroy-dispatcher-first
Keeper fix: destroy `KeeperDispatcher` first
2024-03-23 18:51:32 +01:00
kssenii
d3c6836e2b More logging 2024-03-23 12:25:16 +01:00
Alexander Tokmakov
ace983f3d5 skip more sanity checks for secondary create queries 2024-03-23 00:03:31 +01:00
Alexey Milovidov
a56c113c83 Fix for clang-19 2024-03-22 22:12:59 +01:00
Alexey Milovidov
14c616e696 Fix for clang-19 2024-03-22 21:29:42 +01:00
vdimir
a1036075e0
Merge branch 'master' into vdimir/using_alias_followup 2024-03-22 20:16:26 +00:00
Michael Kolupaev
84daaa1c7e Style 2024-03-22 20:00:42 +00:00
kssenii
b69e4541b9 Unify code in SLRU 2024-03-22 18:06:46 +01:00
Nikolai Kochetov
41d9b19a4a
Merge pull request #61059 from ClickHouse/fix-parallel-replicas-explain-syntax-crash
Fix: parallel replicas with CTEs, crash in EXPLAIN SYNTAX with analyzer
2024-03-22 18:06:30 +01:00
kssenii
e91dc87f82 Speed up dynamic resize of filesystem cache 2024-03-22 17:26:12 +01:00
Nikolay Degterinsky
83ccd2a144 Merge remote-tracking branch 'upstream/master' into fix-attach-on-cluster 2024-03-22 16:06:01 +00:00
avogar
47095f63b1 Fix writing exception message in output format in HTTP when http_wait_end_of_query is used 2024-03-22 16:03:28 +00:00
kssenii
272ae1d6ea Fixes 2024-03-22 16:13:06 +01:00
Alexander Tokmakov
9082a018a5
Merge pull request #59082 from ClickHouse/fix_race_async_inserts_queue
Fix race on `Context::async_insert_queue`
2024-03-22 16:06:13 +01:00
Antonio Andelic
6a681e074f Fix build 2024-03-22 15:17:28 +01:00
Sergei Trifonov
7013b84445
Merge branch 'master' into more-log-for-async-loader 2024-03-22 11:11:51 +01:00
Antonio Andelic
5beabe071c Destroy KeeperDispatcher first 2024-03-22 09:43:39 +01:00
pufit
216dcbef2c
Correct revoke for the partially granted rights. (#61115)
* Correct revoke for the partially granted rights.
2024-03-22 02:13:51 -04:00
robot-ch-test-poll
03a4b5fb58
Merge pull request #61053 from ClickHouse/async-loader-waiters-limit
Separate limits on number of waiting and executing queries
2024-03-22 03:15:25 +01:00
Michael Kolupaev
7ac41d7fc1 Fix segfault in SquashingTransform 2024-03-21 23:25:55 +00:00
yariks5s
6a19b77d9e init 2024-03-21 18:39:05 +00:00
Alexey Milovidov
8670f1dc91
Merge pull request #61543 from ClickHouse/fix-regexp-recompilation-in-parser
Fix recompilation of regexps during backtracking in the parser
2024-03-21 21:15:17 +03:00
kssenii
87b1e0ead2 Add more logging 2024-03-21 18:22:11 +01:00
Vitaly Baranov
1acc0ebe79
Merge pull request #61356 from vitlibar/fix-replace-dictionary
Fix CREATE OR REPLACE DICTIONARY
2024-03-21 16:45:06 +01:00
Igor Nikonov
f36e19917f Disable analyzer for EXPLAIN SYNTAX queries 2024-03-21 15:27:39 +00:00
Dmitry Novik
e4209218d4
Merge pull request #60497 from ClickHouse/analyzer-distr-json
Analyzer: Support different ObjectJSON on shards
2024-03-21 16:25:30 +01:00
kssenii
b1e03abc1f One more fix for SLRU 2024-03-21 12:51:26 +01:00
serxa
c31b958f88 Merge branch 'master' into async-loader-waiters-limit 2024-03-21 10:58:22 +00:00
serxa
67819b1484 Merge branch 'master' into fix-db-iterator-waits 2024-03-21 10:53:54 +00:00
Sergei Trifonov
a91eaa78ee
Update src/Interpreters/ServerAsynchronousMetrics.cpp
Co-authored-by: Antonio Andelic <antonio2368@users.noreply.github.com>
2024-03-21 11:46:44 +01:00
vdimir
15bf6d1d5f
Merge branch 'master' into vdimir/using_alias_followup 2024-03-21 10:39:18 +00:00
vdimir
9b51780458
Merge pull request #60896 from loudongfeng/master_smj_nullorder
make nulls direction configuable for FullSortingMergeJoin
2024-03-21 10:40:43 +01:00
Antonio Andelic
c06a509033
Merge pull request #61654 from ClickHouse/fix-aggregator-variant
Fix Aggregator when data is empty
2024-03-21 08:48:15 +01:00
Alexey Milovidov
99ed82d561 Merge branch 'master' into fix-regexp-recompilation-in-parser 2024-03-21 02:21:09 +01:00
Alexey Milovidov
97b7daef84
Merge pull request #61604 from Algunenano/nested_includes
Reduce header dependencies
2024-03-21 02:02:17 +03:00
kssenii
e9bc922d94 Fix SLRU case, not yet working 2024-03-20 21:02:04 +01:00
Alexander Tokmakov
d190ee8113
Update AsynchronousInsertQueue.h 2024-03-20 19:19:30 +01:00
vdimir
2753042387
Merge branch 'master' into vdimir/using_alias_followup 2024-03-20 17:29:13 +00:00
vdimir
c799bfd016
Analyzer: fixes for join using columns 2024-03-20 17:13:59 +00:00
Robert Schulze
35cc335597
Revert "Un-flake test_undrop_query" 2024-03-20 18:04:35 +01:00
serxa
87037d6d7d fix build 2024-03-20 16:17:30 +00:00
Antonio Andelic
9bf50ac814 Fix aggregator when data is empty 2024-03-20 14:50:26 +01:00
Raúl Marín
c98634ad8c Merge remote-tracking branch 'blessed/master' into nested_includes 2024-03-20 14:08:10 +01:00
Kruglov Pavel
e7e11d738b
Merge branch 'master' into revert-61200-revert-60430-max-parallel-replicas-validate 2024-03-20 13:59:38 +01:00
Dmitry Novik
10bf164aa7 Cleanup #ci_set_analyzer 2024-03-20 10:47:15 +01:00
kssenii
fd7c732c12 Add one more comment, better cache policy randomizer 2024-03-19 23:09:17 +01:00
kssenii
4940162959 Add comments 2024-03-19 22:44:08 +01:00
Alexander Tokmakov
7275caf5bb
Update Context.cpp 2024-03-19 22:40:00 +01:00
Vitaly Baranov
2f4b9b3a5b Add few notes and a debug check. 2024-03-19 22:07:13 +01:00
Alexander Tokmakov
1913466da4 fix uaf of async_insert_queue 2024-03-19 21:07:42 +01:00
Alexey Milovidov
a996155e83 Merge branch 'master' of github.com:ClickHouse/ClickHouse into fix-regexp-recompilation-in-parser 2024-03-19 19:56:11 +01:00
Alexey Milovidov
b561560c99 Remove it from remaining places 2024-03-19 19:55:59 +01:00
Dmitry Novik
221b74c77f Fix #ci_set_analyzer 2024-03-19 19:44:15 +01:00
Alexander Tokmakov
5d7e5e5a72 Merge branch 'master' into fix_race_async_inserts_queue 2024-03-19 19:39:25 +01:00
Dmitry Novik
302179c81d Merge remote-tracking branch 'origin/master' into analyzer-distr-json 2024-03-19 18:56:04 +01:00
Maksim Kita
f4d20a79b0 Fixed build 2024-03-19 19:07:45 +03:00
Maksim Kita
ec6c276a92 Temporary data use temporary_files_codec setting 2024-03-19 19:07:45 +03:00
Raúl Marín
de855ca917 Reduce header dependencies 2024-03-19 17:04:29 +01:00
Nikolay Degterinsky
4e2e5a015b
Fixes 2024-03-19 16:29:50 +01:00
Alexey Milovidov
018316c78a
Merge pull request #61211 from bigo-sg/split_aggregator
Too big translation unit in `Aggregator`
2024-03-19 17:29:24 +03:00
kssenii
595165add0 Merge remote-tracking branch 'origin/master' into filecache-better-try-reserve 2024-03-19 15:12:55 +01:00
kssenii
6a29268d5a Fix 2024-03-19 15:11:06 +01:00
Nikolai Kochetov
240242da22
Merge pull request #61580 from ClickHouse/follow-up-61458
Add a comment after #61458
2024-03-19 14:06:24 +01:00
Nikolai Kochetov
f2f770d73a
Update src/Interpreters/ActionsDAG.h
Co-authored-by: Sergei Trifonov <sergei@clickhouse.com>
2024-03-19 13:37:21 +01:00
Nikolai Kochetov
ba6d6e9258 Add a comment after #61458 2024-03-19 11:40:03 +00:00
János Benjamin Antal
922df7d60e
Merge pull request #61003 from amosbird/less-header-1
Replace some header includes with forward declarations
2024-03-19 12:14:06 +01:00
Alexander Tokmakov
dd50091513
Merge pull request #60338 from PapaToemmsn/test-transaction-fixes
fix for #57598 (ROLLBACK should be no-op...)
2024-03-19 11:56:25 +01:00
Kseniia Sumarokova
73487600c1
Merge pull request #61524 from ClickHouse/better-dynamic-cache-size-reloading-part-1
Less contention during dynamic resize of filesystem cache
2024-03-19 11:41:44 +01:00
lgbo-ustc
4eeb9a7e83 Merge remote-tracking branch 'origin/master' into split_aggregator 2024-03-19 16:32:01 +08:00
nemonlou
8ff21d7e47 fix review comments 2024-03-19 11:29:22 +08:00
nemonlou
0b5fc743f2 make nulls direction configuable for FullSortingMergeJoin(fix review comments) 2024-03-19 09:58:07 +08:00
nemonlou
a1a4bd3514 make nulls direction configuable for FullSortingMergeJoin 2024-03-19 09:58:07 +08:00
Vitaly Baranov
c8375cd167 Better code: remove unnecessary usage of const_cast and std::function. 2024-03-19 02:56:38 +01:00
Vitaly Baranov
306f642d97 Update dictionary's comment in the same safe manner too. 2024-03-19 02:56:33 +01:00
robot-ch-test-poll3
e82cf5d5ba
Merge pull request #61528 from ClickHouse/revert-61518-revert-61298-analyzer-merge-virtual-columns
Revert "Revert "Analyzer: Fix virtual columns in StorageMerge""
2024-03-18 23:51:55 +01:00
PapaToemmsn
fbc8a19a02
Merge branch 'ClickHouse:master' into test-transaction-fixes 2024-03-18 22:42:10 +01:00