thevar1able/ClickHouse
1
0
Fork 0
mirror of https://github.com/ClickHouse/ClickHouse.git synced 2024-11-25 00:52:02 +00:00
Code Issues Packages Projects Releases Wiki Activity
49,028 Commits 9,166 Branches 1,781 Tags 2.1 GiB
765db4196f
Commit Graph

2171 Commits

Author SHA1 Message Date
Mikhail Filimonov
22bd22702e
Fix enable_optimize_predicate_expression for finalizeAggregation 
finalizeAggregation was wrongly marked as stateful, preventing pushing the conditions down.
 2020-09-17 15:59:14 +02:00
Vxider
1322a1ce7a add blank line to end of file 2020-09-17 21:53:39 +08:00
alexey-milovidov
2413caa7d5
Merge pull request #14889 from ClickHouse/extract-all-groups-empty-match 
Fix error in "extractAllGroups" function
 2020-09-17 16:02:30 +03:00
alesapin
40b2f203b6 Merge branch 'master' into manual-write-duplicate-parts-to-replicas 2020-09-17 13:21:00 +03:00
roman
b41421cb1c [settings]: introduce new query complexity settings for leaf-nodes 
The new setting should allow to control query complexity on leaf nodes
excluding the final merging stage on the root-node. For example, distributed
query that reads 1k rows from 5 shards will breach the `max_rows_to_read=5000`,
while effectively every shard reads only 1k rows. With setting `max_rows_to_read_leaf=1500`
this limit won't be reached and query will succeed since every shard reads
not more that ~1k rows.
 2020-09-17 10:37:05 +01:00
alesapin
f104c382f8
Merge pull request #14887 from azat/StorageFile-write-to-fd 
Fix SIGSEGV for an attempt to INSERT into StorageFile(fd)
 2020-09-17 10:25:02 +03:00
alesapin
73544a3781
Merge pull request #14845 from ClickHouse/fix_alias_array 
Fix recursive column defaults
 2020-09-17 10:02:39 +03:00
Azat Khuzhin
13088d9bef Fix 00900_parquet_load (update exception message on INSERT failures) 2020-09-17 08:05:56 +03:00
Azat Khuzhin
138e953429 Fix SIGSEGV for an attempt to INSERT into StorageFile(fd) 2020-09-17 01:26:34 +03:00
Alexey Milovidov
c37b55c3b1 Fix error in "extractAllGroups" function 2020-09-17 00:19:58 +03:00
Azat Khuzhin
7d046b24e6 Improve error message for INSERT via clickhouse-client 
With '\n...' after the query [1] clickhouse-client prefer data from the
INSERT over from stdin, and produce very tricky message:

    Code: 27. DB::Exception: Cannot parse input: expected '\n' before: ' ': (at row 1)

Well for TSV it is ok, but for RowBinary:

    Code: 33. DB::Exception: Cannot read all data. Bytes read: 1. Bytes expected: 4.

So improve error message by adding the source of data for INSERT.

  [1]: clickhouse-client -q "INSERT INTO data FORMAT TSV\n " <<<2
 2020-09-17 00:16:51 +03:00
Anton Popov
8e9828d2ff Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-16 21:07:35 +03:00
Nikolai Kochetov
d0debd51c0 Add sorting to fix test. 2020-09-16 20:00:44 +03:00
tavplubix
faa5190f11
Update arcadia_skip_list.txt 2020-09-16 18:17:16 +03:00
Amos Bird
3e576a29c9
explict column list in columns matcher (#14775) 2020-09-16 15:44:05 +03:00
tavplubix
28a6b7e622
Merge pull request #14831 from bharatnc/ncb/fix-timespec-construct 
construct query_start_time & query_start_time_microseconds from the same timespec
 2020-09-16 15:42:19 +03:00
alesapin
813a6e991c Remove wait_for_mutation from test 2020-09-15 18:16:29 +03:00
Anton Popov
3e855daefd Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-15 15:31:29 +03:00
Anton Popov
63db2ca68d fix test 2020-09-15 15:30:07 +03:00
alesapin
8828a78174 Fix alias on default columns 2020-09-15 14:17:58 +03:00
hexiaoting
023daddbea Fix bug for LineAsString Format 2020-09-15 18:13:39 +08:00
Nikolai Kochetov
c1f61984e5
Merge pull request #14513 from amosbird/mf1 
Binary operator monotonicity
 2020-09-15 12:45:23 +03:00
Vxider
9b98ec2cc0 add functional test 2020-09-15 17:16:48 +08:00
bharatnc
90e0ef9b70 QueryLog,QueryThreadLOg - better test for query_start_time_microseconds 2020-09-14 20:04:29 -07:00
Amos Bird
4770175aa3
more tests 2020-09-15 10:02:26 +08:00
Anton Popov
f725f8deee fix more tests 2020-09-15 02:14:14 +03:00
Azat Khuzhin
65e48663e7 Drop policy on start in 01308_row_policy_and_trivial_count_query 2020-09-15 01:36:22 +03:00
Alexander Tokmakov
da6beb1a91 Merge branch 'master' into enable_some_tests_with_database_atomic 2020-09-14 23:00:14 +03:00
Nikolai Kochetov
d418ee48a4
Merge pull request #14783 from amosbird/fix3 
Fix signedness conversion monotonicity
 2020-09-14 21:40:51 +03:00
Ildus Kurbangaliev
67b49862d9
Add mapPopulateSeries function (#13166) 2020-09-14 19:11:50 +03:00
alexey-milovidov
752e3f8197
Merge pull request #14453 from amosbird/apply2 
column transformers in insert select
 2020-09-14 16:46:01 +03:00
Artem Zuikov
d274125c74
Fix wide integer left shift + refactoring (#14697) 2020-09-14 14:56:43 +03:00
Amos Bird
5998570762
Fix signedness conversion monotonicity 2020-09-14 18:12:41 +08:00
Amos Bird
654245af3c
Fix signedness conversion monotonicity 2020-09-14 18:11:40 +08:00
alesapin
336430d3c2
Merge pull request #14646 from ClickHouse/if_bug 
Fix bug in if function when then clause contain const nullable column
 2020-09-14 09:51:40 +03:00
Nikolai Kochetov
109fd9d6d7
Merge pull request #13015 from amosbird/jgmko 
Refactor joinGet and implement multi-key lookup.
 2020-09-13 22:39:48 +03:00
Amos Bird
34b9547ce1
Binary operator monotonicity 2020-09-13 21:55:12 +08:00
Amos Bird
016f707ea1
column transformers in insert select 2020-09-13 10:21:13 +08:00
Amos Bird
882b2a3348
CTE 2020-09-13 09:39:17 +08:00
alesapin
ecbcbad0d9 Fix flaky test 2020-09-12 10:07:08 +03:00
nikitamikhaylov
b96da75ead done 2020-09-11 19:44:14 +03:00
Nikita Mikhaylov
26742a3c81
Merge pull request #14703 from nikitamikhaylov/format-line-as-string 
Merging #13846 (Format LineAsString)
 2020-09-11 16:45:57 +04:00
Nikita Mikhaylov
468089a4cd
Merge pull request #14514 from bharatnc/ncb/event_time_microseconds_metric_logs 
add event_time_microseconds field to asynchronous_metric_log & metric_log system tables
 2020-09-11 16:14:00 +04:00
alexey-milovidov
e73ca17ad3
Merge pull request #14725 from BooBSD/formatReadableQuantity 
formatReadableQuantity() function
 2020-09-11 12:09:18 +03:00
Alexander Kuzmenkov
d227f1f706
Merge pull request #13192 from ClickHouse/aku/semicolon-simple 
Simpler version of semicolon-terminated VALUES #12999 w/o `pos` changes
 2020-09-11 11:51:52 +03:00
alesapin
902624cb7b Merge branch 'master' into if_bug 2020-09-11 10:54:32 +03:00
Anton Popov
8a201a28c0 remove skip list for tests with polymorphic parts 2020-09-11 03:14:35 +03:00
Anton Popov
fa6d88b3b2 fix more tests 2020-09-10 21:43:02 +03:00
Anton Popov
6031e6bae9 fix tests 2020-09-10 20:09:19 +03:00
Artem Hnilov
bbe379d58e 00534_filimonov.data was updated 2020-09-10 17:06:32 +00:00
Artem Hnilov
142026f4ab 01492_format_readable_quantity test added 2020-09-10 16:54:52 +00:00
nikitamikhaylov
6e0d2a427c add another test 2020-09-10 19:30:11 +03:00
Nikolai Kochetov
964c18241c Added test from #13829 2020-09-10 19:04:53 +03:00
bharatnc
397ebdb855 remove sleep from unit test 2020-09-10 08:55:39 -07:00
Nikita Mikhaylov
a39ba57e8c
Merge branch 'master' into dev-nf 2020-09-10 18:10:47 +04:00
Nikita Mikhaylov
f0a65522cc
Merge pull request #14333 from hczhcz/patch-0901 
Add JSONStrings formats
 2020-09-10 17:54:42 +04:00
bharatnc
31b0bd481c Integration tests - more accurate tests 2020-09-10 00:35:25 -07:00
alexey-milovidov
92b746116a
Merge pull request #14655 from ClickHouse/nested-multiline-comments 
Support for nested multiline comments
 2020-09-10 06:10:31 +03:00
bharatnc
05a80518a1 Merge remote-tracking branch 'upstream/master' into ncb/event_time_microseconds_metric_logs 2020-09-09 17:58:29 -07:00
bharatnc
0a3f7d0fcc AsynchronousMetricsLog - add improved tests 
This adds integration tests to test the asynchronous_metric_log table
for event_time_microseconds field.

Asynchronous metrics are updated once every 60s, so this setting needs
to be overridden for having those metrics available in time so that the
tests can run. So the `asynchronous_metric_update_period_s` setting is
being overriden to be 2s.
 2020-09-09 17:50:39 -07:00
Anton Popov
d1c35dc794 Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-10 03:13:08 +03:00
Nikita Mikhaylov
44726c37c3
Merge branch 'master' into fix-executable-dictionary-source-hangup 2020-09-09 23:01:41 +04:00
Alexey Milovidov
7304bad56f Support for nested multiline comments 2020-09-09 20:51:05 +03:00
alesapin
62428845a0 Bug in mutation 2020-09-09 19:47:06 +03:00
alexey-milovidov
38131917ef
Merge pull request #14530 from amosbird/ma 
Fix Nullable String to Enum conversion.
 2020-09-09 19:24:04 +03:00
Alexander Tokmakov
7f4106687c fix 2020-09-09 19:23:31 +03:00
alexey-milovidov
c6d0944994
Merge pull request #14591 from myrrc/bugfix/lc-nullability-checker 
Correct nullability checker for LowCardinality nested columns
 2020-09-09 19:23:19 +03:00
alexey-milovidov
a6a0d4966c
Merge pull request #14595 from azat/query-format-trailing-whitespace 
Fix some trailing whitespaces in query format (ExpressionList users)
 2020-09-09 19:22:55 +03:00
alesapin
bd14c79b0b
Merge pull request #14494 from ClickHouse/recompression_in_background 
Recompression TTL
 2020-09-09 17:46:01 +03:00
Alexander Tokmakov
b68782d285 enable more tests with Atomic database 2020-09-09 16:32:50 +03:00
Artem Zuikov
48f29ae11f
Fix bug in Decimal scale (#14603) 2020-09-09 16:18:58 +03:00
myrrc
a8f5d9e70f added the test and comment 2020-09-09 15:52:44 +03:00
Nikita Mikhaylov
c03a9487ca another test + fix 2020-09-09 14:55:20 +03:00
Artem Zuikov
36972d34a7
Fix logical error in GLOBAL JOIN with table function (#14545) 2020-09-09 13:03:13 +03:00
hcz
2ea59cb0c2 Fix tests 2020-09-09 17:54:41 +08:00
Anton Popov
32135d96f9
Merge pull request #12183 from CurtizJ/polymorphic-parts-2 
Support codecs in compact parts
 2020-09-09 12:34:13 +03:00
alesapin
485b104898 Use max ttl and add introspection to system parts about recompression 2020-09-09 12:15:42 +03:00
hcz
d8fce448a2 Implement null_as_default for JSONStrings formats 2020-09-09 15:47:32 +08:00
alesapin
a696cf12f6 Merge branch 'master' into recompression_in_background 2020-09-09 10:12:03 +03:00
Azat Khuzhin
68c441e07b Add LIMIT BY format test 2020-09-09 01:37:15 +03:00
Azat Khuzhin
11ba7049c0 Cover WITH format 2020-09-09 01:37:15 +03:00
Azat Khuzhin
0324770773 Remove all trailing whitespaces in tests 
sed -r -i \
    -e 's/SELECT $/SELECT/' \
    -e 's/SELECT DISTINCT $/SELECT DISTINCT/' \
    -e 's/WITH $/WITH/' \ # zero matches, new test will be added
    -e 's/ARRAY JOIN $/ARRAY JOIN/' \
    -e 's/GROUP BY $/GROUP BY/' \
    -e 's/ORDER BY $/ORDER BY/' \
    -e 's/LIMIT ([0-9]+) BY $/LIMIT \1 BY/' \ # zero matches, new test will be added
    tests/queries/*/*.sql \
    tests/queries/*/*.reference

(With except for tests/queries/0_stateless/00751_default_databasename_for_view.reference)
 2020-09-09 01:36:58 +03:00
Azat Khuzhin
4f1321daef Make 00443_merge_tree_uniform_read_distribution_0.reference real file (was symlink) 2020-09-09 01:36:21 +03:00
alexey-milovidov
1e300d9119
Merge pull request #14562 from CurtizJ/fix-fuzz 
Fix segfault in combinator -Resample
 2020-09-08 23:53:14 +03:00
Anton Popov
a419267dc6 minor fixes 2020-09-08 19:28:49 +03:00
Alexey Milovidov
74bd12284e Fix typo 2020-09-08 16:13:49 +03:00
Kruglov Pavel
23a5a78873
Fix tests 2020-09-08 16:07:58 +03:00
Avogar
5d303573c7 Add tests 2020-09-08 16:06:05 +03:00
alesapin
f0f7f2b5d2 Merge branch 'master' into recompression_in_background 2020-09-08 15:43:37 +03:00
Nikita Mikhaylov
80f193f615
Merge pull request #14252 from bharatnc/ncb/time-query-log-in-ms 
add query_start_time_microseconds field to system.query_log & system.query_thread_log tables
 2020-09-08 15:11:50 +04:00
Nikolai Kochetov
d771ce5609
Merge pull request #14500 from ClickHouse/many-rows-in-totals 
Many rows in totals
 2020-09-08 10:40:14 +03:00
Anton Popov
ee218c354e fix segfault in combinator -Resample 2020-09-08 02:21:12 +03:00
Nikolai Kochetov
73de00f4df Review fix. 2020-09-07 20:49:23 +03:00
Nikita Mikhaylov
5d9367aea4
Merge pull request #14411 from nikitamikhaylov/rank-corr 
Merging #11769 (Rank Correlation Spearman)
 2020-09-07 21:18:19 +04:00
Alexey Milovidov
661d9bdb4c Skip test 2020-09-07 19:03:36 +03:00
alesapin
acbe21304a Fix test for compact parts 2020-09-07 14:46:32 +03:00
Alexey Milovidov
99ebab706c Fix "Arcadia" 2020-09-07 12:02:47 +03:00
Amos Bird
4c3c1cdaf3
Fix Nullable String to Enum conversion. 2020-09-07 15:32:44 +08:00
alesapin
ba70de63f8 Fix diff 2020-09-07 10:28:04 +03:00
Alexey Milovidov
04a6965006 Fix error with executable dictionary source 2020-09-07 09:40:01 +03:00
alesapin
7f301eab63 Merge branch 'master' into recompression_in_background 2020-09-07 09:31:16 +03:00
alexey-milovidov
ff2d9aec1a
Merge pull request #14409 from dimarub2000/obfuscator_uuid 
Added UUID to Obfuscator
 2020-09-07 06:58:41 +03:00
alexey-milovidov
8b0a6d5609
Merge pull request #14404 from dimarub2000/system_events_show_zero_values 
system_events_show_zero_values setting added
 2020-09-07 06:40:36 +03:00
hexiaoting
a3671a15f6 Add new feature: SHOW DATABASES LIKE 2020-09-07 10:54:59 +08:00
bharatnc
fd22450a2a Merge remote-tracking branch 'upstream/master' into ncb/time-query-log-in-ms 2020-09-06 13:19:27 -07:00
Dmitry
7ca155c417 test added 2020-09-06 19:44:12 +03:00
bharatnc
ec0d0243cc MetricLog - add tests for event_time_microseconds field 2020-09-06 08:31:27 -07:00
bharatnc
6a5b885ac1 AsynchronousMetricLog - add tests for event_time_microseconds column 2020-09-06 08:31:27 -07:00
Dmitry
5aa9dc0e86 show transform in test 2020-09-06 00:42:38 +03:00
Dmitry
ace61fa67e Uint128 logic and tests 2020-09-06 00:35:24 +03:00
alexey-milovidov
69630972d4
Merge pull request #14509 from bharatnc/ncb/disallow-empty-tz-toStartOfIntervalFunc 
disallow empty time_zone argument in toStartOf* type of functions
 2020-09-05 17:41:53 +03:00
Anton Popov
30a867e387 Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-05 17:00:14 +03:00
bharatnc
d543b82100 fix 00921_dateteime_compatibility test 2020-09-04 21:26:41 -07:00
bharatnc
25080f3a88 additional checks for empty tz for toStartOfMonth|Quarter|Year 2020-09-04 20:15:37 -07:00
bharatnc
8fd00ff77b rename test files and fix tests - add ; at the end 2020-09-04 18:42:43 -07:00
bharatnc
0fd9288374 add tests for - toStartOfInterval* functions 2020-09-04 17:32:38 -07:00
Anton Popov
af69c4208c fix flaky test 2020-09-04 22:16:30 +03:00
bharatnc
0c1a65ddf2 tests query_start_time_microseconds for system.query_thread_log 2020-09-04 09:42:18 -07:00
bharatnc
89eebdfde4 fix tests 2020-09-04 09:42:18 -07:00
bharatnc
774bae722b add tests 2020-09-04 09:42:18 -07:00
Nikolai Kochetov
35bf64471f Added test 2020-09-04 19:32:51 +03:00
Anton Popov
f1cf03f1bb Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-04 17:40:22 +03:00
Nikita Mikhaylov
d718c5af99 fixed 2020-09-04 17:36:08 +03:00
alesapin
de911aaabe Merge branch 'master' into recompression_in_background 2020-09-04 17:21:27 +03:00
Artem Zuikov
7c20aa2c62
Another 256-bit integers (strict 32 bytes) (#14229) 2020-09-04 16:33:02 +03:00
Anton Popov
68913eab62 better reading from compact parts with differents codecs 2020-09-04 15:48:55 +03:00
alesapin
f8aa6cfe8a
Merge pull request #14438 from ClickHouse/apply_ttl_if_not_calculated 
Apply TTL if it's not calculated for part
 2020-09-04 15:32:50 +03:00
alexey-milovidov
54ede2e1bb
Merge pull request #14467 from ClickHouse/topk-check-overflow 
Check for array size overflow in topK
 2020-09-04 09:15:33 +03:00
Alexey Milovidov
1cee6d5a31 Check for array size overflow in topK #14452 2020-09-04 04:05:57 +03:00
Alexey Milovidov
0e53cd26a0 Simplify tests for mutations 2020-09-04 02:28:44 +03:00
Alexey Milovidov
40ad23245c Fix flaky test 00944_clear_index_in_partition 2020-09-04 02:12:30 +03:00
alexey-milovidov
4f9df21d3e
Merge pull request #10373 from azat/dist-SELECT-optimization 
Optimize queries with LIMIT/LIMIT BY/ORDER BY for distributed with GROUP BY sharding_key
 2020-09-04 01:38:56 +03:00
Nikita Mikhaylov
9fef663caa add test 2020-09-03 21:06:30 +03:00
nikitamikhaylov
b7a2d9b176 fast test 2020-09-03 19:04:08 +03:00
Anton Popov
98011f6fc3 Merge remote-tracking branch 'upstream/master' into HEAD 2020-09-03 17:53:05 +03:00
alesapin
aa47d0aabc Merge branch 'apply_ttl_if_not_calculated' into recompression_in_background 2020-09-03 12:07:03 +03:00
alesapin
acc0ee0657 Apply TTL if it's not calculated for part 2020-09-03 11:59:41 +03:00
alexey-milovidov
9e4aa5954e
Update 00184_shard_distributed_group_by_no_merge.sql 2020-09-03 04:46:45 +03:00
alexey-milovidov
06edd217db
Update 01247_optimize_distributed_group_by_sharding_key.sql 2020-09-03 04:46:12 +03:00
alexey-milovidov
722e1bb81f
Update 01247_optimize_distributed_group_by_sharding_key_dist_on_dist.sql 2020-09-03 04:45:36 +03:00
alexey-milovidov
1c2435d4f7
Merge pull request #14233 from amosbird/apply 
Introduce columns transformers.
 2020-09-03 01:37:40 +03:00
Azat Khuzhin
5e71fe3f39 Add a test for distributed_group_by_no_merge=2 2020-09-03 00:54:11 +03:00
Azat Khuzhin
10b4f3b41f Optimize queries with LIMIT/LIMIT BY/ORDER BY for distributed with GROUP BY sharding_key 
Previous set of QueryProcessingStage does not allow to do this.
But after WithMergeableStateAfterAggregation had been introduced the
following queries can be optimized too under
optimize_distributed_group_by_sharding_key:
- GROUP BY sharding_key LIMIT
- GROUP BY sharding_key LIMIT BY
- GROUP BY sharding_key ORDER BY

And right now it is still not supports:
- WITH TOTALS (looks like it can be supported)
- WITH ROLLUP (looks like it can be supported)
- WITH CUBE
- SETTINGS extremes=1 (looks like it can be supported)
But will be implemented separatelly.

vX: fixes
v2: fix WITH *
v3: fix extremes
v4: fix LIMIT OFFSET (and make a little bit cleaner)
v5: fix HAVING
v6: fix ORDER BY
v7: rebase against 20.7
v8: move out WithMergeableStateAfterAggregation
v9: add optimize_distributed_group_by_sharding_key into test names
 2020-09-03 00:52:51 +03:00
alexey-milovidov
8e2fba5be1
Merge pull request #12567 from amosbird/fmi 
table function view
 2020-09-02 17:07:57 +03:00
Nikita Mikhaylov
cdb1f30630 style + fast test 2020-09-02 16:49:47 +03:00
Nikita Mikhaylov
7021f6edc1 better 
(cherry picked from commit 81481f26b5)
 2020-09-02 15:47:23 +03:00
Nikita Mikhaylov
eee19dada4 fixes + test 
(cherry picked from commit 5daee1cae1)
(cherry picked from commit c3dfb8e838)
 2020-09-02 15:47:09 +03:00
Nikolai Kochetov
811e44a937
Merge pull request #14315 from azat/EXPLAIN-SIGSEGV-fix 
[RFC] Fix QueryPlan lifetime (for EXPLAIN PIPELINE graph=1) for queries with nested interpreter
 2020-09-02 12:46:59 +03:00
Amos Bird
6bd753d85d
TableFunction view. 2020-09-02 16:02:10 +08:00
Amos Bird
be925f8d9c
Introduce columns transformers. 2020-09-02 15:36:34 +08:00
hcz
a80c1adee8 Add JSONCompactStrings formats 2020-09-02 12:15:58 +08:00
alexey-milovidov
adf50fd774
Merge pull request #13761 from zhang2014/improvement/date_time 
ISSUES-4006 add precision argument for DateTime type
 2020-09-02 05:12:35 +03:00
alexey-milovidov
2d85213629
Merge pull request #13792 from azat/lambda-arrayJoin-fix 
[RFC] Fix arrayJoin() capturing in lambda
 2020-09-02 05:10:58 +03:00
hcz
ac5877e601 Fix tests 2020-09-02 00:58:39 +08:00
bharatnc
f0d1c6c794 Merge remote-tracking branch 'upstream/master' into ncb/fix-alter-live-lock 2020-09-01 09:06:10 -07:00
bharatnc
120962b61a fix tests 2020-09-01 08:55:54 -07:00
tavplubix
cb4644ea6d
Merge pull request #14326 from ClickHouse/fix_crash_alter_table_function 
Throw exception on alter for storages created from table functions
 2020-09-01 15:03:09 +03:00
alesapin
c37a19f7b0 Better 2020-09-01 14:23:38 +03:00
alesapin
f0dc5a3085 First working test 2020-09-01 13:49:53 +03:00
hcz
c25a99aaf5 Add tests 2020-09-01 17:47:37 +08:00
alesapin
a0b4cc78d6 Throw exception on alter for storages created from table functions 2020-09-01 10:26:31 +03:00
Azat Khuzhin
d04cda0367 Fix QueryPlan lifetime (for EXPLAIN PIPELINE graph=1) for queries with nested interpreter 
Example of such queries are distributed queries, which creates local
InterpreterSelectQuery, which will have it's own QueryPlan but returns
Pipes that has that IQueryPlanStep attached.

After EXPLAIN PIPELINE graph=1 tries to use them, and will get SIGSEGV.

- TSAN:

<details>

```
==2782113==ERROR: AddressSanitizer: heap-use-after-free on address 0x6120000223c0 at pc 0x00002b8f3f3e bp 0x7fff18cfbff0 sp 0x7fff18cfbfe8
READ of size 8 at 0x6120000223c0 thread T22 (TCPHandler)
    #0 0x2b8f3f3d in DB::printPipelineCompact(std::__1::vector<std::__1::shared_ptr<DB::IProcessor>, std::__1::allocator<std::__1::shared_ptr<DB::IProcessor> > > const&, DB::WriteBuffer&, bool) /build/obj-x86_64-linux-gnu/../src/Processors/printPipeline.cpp:116:53
    #1 0x29ee698c in DB::InterpreterExplainQuery::executeImpl() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:275:17
    #2 0x29ee2e40 in DB::InterpreterExplainQuery::execute() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:73:14
    #3 0x2a7b44a2 in DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:389:28
    #4 0x2a7b1cb3 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:675:30
    #5 0x2b7993b2 in DB::TCPHandler::runImpl() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:253:24
    #6 0x2b7b649a in DB::TCPHandler::run() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1217:9
    #7 0x31d9c57e in Poco::Net::TCPServerConnection::start() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
    #8 0x31d9d281 in Poco::Net::TCPServerDispatcher::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:114:20
    #9 0x3206b5d5 in Poco::PooledThread::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
    #10 0x320657ad in Poco::ThreadImpl::runnableEntry(void*) /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
    #11 0x7ffff7f853e8 in start_thread (/usr/lib/libpthread.so.0+0x93e8)
    #12 0x7ffff7ea2292 in clone (/usr/lib/libc.so.6+0x100292)

0x6120000223c0 is located 0 bytes inside of 272-byte region [0x6120000223c0,0x6120000224d0)
freed by thread T22 (TCPHandler) here:
    #0 0x122f3b62 in operator delete(void*, unsigned long) (/src/ch/tmp/master-20200831/clickhouse+0x122f3b62)
    #1 0x2bd9e9fa in std::__1::default_delete<DB::IQueryPlanStep>::operator()(DB::IQueryPlanStep*) const /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2363:5
    #2 0x2bd9e9fa in std::__1::unique_ptr<DB::IQueryPlanStep, std::__1::default_delete<DB::IQueryPlanStep> >::reset(DB::IQueryPlanStep*) /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2618:7
    #3 0x2bd9e9fa in std::__1::unique_ptr<DB::IQueryPlanStep, std::__1::default_delete<DB::IQueryPlanStep> >::~unique_ptr() /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2572:19
    #4 0x2bd9e9fa in DB::QueryPlan::Node::~Node() /build/obj-x86_64-linux-gnu/../src/Processors/QueryPlan/QueryPlan.h:66:12
    #5 0x2bd9e9fa in void std::__1::allocator_traits<std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> > >::__destroy<DB::QueryPlan::Node>(std::__1::integral_constant<bool, false>, std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> >&,
 DB::QueryPlan::Node*) /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:1798:23
    #6 0x2bd9e9fa in void std::__1::allocator_traits<std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> > >::destroy<DB::QueryPlan::Node>(std::__1::allocator<std::__1::__list_node<DB::QueryPlan::Node, void*> >&, DB::QueryPlan::Node*) /build/obj-x86_64-lin
ux-gnu/../contrib/libcxx/include/memory:1630:14
    #7 0x2bd9e9fa in std::__1::__list_imp<DB::QueryPlan::Node, std::__1::allocator<DB::QueryPlan::Node> >::clear() /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/list:762:13
    #8 0x29fece08 in DB::InterpreterSelectQuery::execute() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:492:1
    #9 0x2abf7484 in DB::ClusterProxy::(anonymous namespace)::createLocalStream(std::__1::shared_ptr<DB::IAST> const&, DB::Block const&, DB::Context const&, DB::QueryProcessingStage::Enum) /build/obj-x86_64-linux-gnu/../src/Interpreters/ClusterProxy/SelectStreamFactory.cpp:
78:33
    #10 0x2abea85d in DB::ClusterProxy::SelectStreamFactory::createForShard(DB::Cluster::ShardInfo const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, std::__1::shar
ed_ptr<DB::Throttler> const&, DB::SelectQueryInfo const&, std::__1::vector<DB::Pipe, std::__1::allocator<DB::Pipe> >&)::$_0::operator()() const /build/obj-x86_64-linux-gnu/../src/Interpreters/ClusterProxy/SelectStreamFactory.cpp:133:51
    #11 0x2abea85d in DB::ClusterProxy::SelectStreamFactory::createForShard(DB::Cluster::ShardInfo const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, std::__1::shar
ed_ptr<DB::Throttler> const&, DB::SelectQueryInfo const&, std::__1::vector<DB::Pipe, std::__1::allocator<DB::Pipe> >&) /build/obj-x86_64-linux-gnu/../src/Interpreters/ClusterProxy/SelectStreamFactory.cpp:189:13
    #12 0x2abe6d99 in DB::ClusterProxy::executeQuery(DB::ClusterProxy::IStreamFactory&, std::__1::shared_ptr<DB::Cluster> const&, Poco::Logger*, std::__1::shared_ptr<DB::IAST> const&, DB::Context const&, DB::Settings const&, DB::SelectQueryInfo const&) /build/obj-x86_64-lin
ux-gnu/../src/Interpreters/ClusterProxy/executeQuery.cpp:107:24
    #13 0x2abc4b74 in DB::StorageDistributed::read(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, s
td::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, DB::SelectQueryInfo const&, DB::Context const&, DB::QueryProcessingStage::Enum, unsigned long, unsigned int) /build/obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:514:12
    #14 0x2bda1c5a in DB::ReadFromStorageStep::ReadFromStorageStep(std::__1::shared_ptr<DB::RWLockImpl::LockHolderImpl>, std::__1::shared_ptr<DB::StorageInMemoryMetadata const>&, DB::SelectQueryOptions, std::__1::shared_ptr<DB::IStorage>, std::__1::vector<std::__1::basic_st
ring<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, DB::SelectQueryInfo const&, std::__1::shared_ptr<DB::Context>, DB::QueryProcessingStage
::Enum, unsigned long, unsigned long) /build/obj-x86_64-linux-gnu/../src/Processors/QueryPlan/ReadFromStorageStep.cpp:39:26
    #15 0x2a01ca70 in std::__1::__unique_if<DB::ReadFromStorageStep>::__unique_single std::__1::make_unique<DB::ReadFromStorageStep, std::__1::shared_ptr<DB::RWLockImpl::LockHolderImpl>&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const>&, DB::SelectQueryOptions&, std
::__1::shared_ptr<DB::IStorage>&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >&, DB::SelectQueryInfo&, st
d::__1::shared_ptr<DB::Context>&, DB::QueryProcessingStage::Enum&, unsigned long&, unsigned long&>(std::__1::shared_ptr<DB::RWLockImpl::LockHolderImpl>&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const>&, DB::SelectQueryOptions&, std::__1::shared_ptr<DB::IStorage>&,
std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > >&, DB::SelectQueryInfo&, std::__1::shared_ptr<DB::Context>&,
DB::QueryProcessingStage::Enum&, unsigned long&, unsigned long&) /build/obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:3028:32
    #16 0x29ff556a in DB::InterpreterSelectQuery::executeFetchColumns(DB::QueryProcessingStage::Enum, DB::QueryPlan&, std::__1::shared_ptr<DB::PrewhereInfo> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::
__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:1383:26
    #17 0x29fe6b83 in DB::InterpreterSelectQuery::executeImpl(DB::QueryPlan&, std::__1::shared_ptr<DB::IBlockInputStream> const&, std::__1::optional<DB::Pipe>) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:795:9
    #18 0x29fe5771 in DB::InterpreterSelectQuery::buildQueryPlan(DB::QueryPlan&) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:473:5
    #19 0x2a47d370 in DB::InterpreterSelectWithUnionQuery::buildQueryPlan(DB::QueryPlan&) /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectWithUnionQuery.cpp:182:38
    #20 0x29ee5bff in DB::InterpreterExplainQuery::executeImpl() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:265:21
    #21 0x29ee2e40 in DB::InterpreterExplainQuery::execute() /build/obj-x86_64-linux-gnu/../src/Interpreters/InterpreterExplainQuery.cpp:73:14
    #22 0x2a7b44a2 in DB::executeQueryImpl(char const*, char const*, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:389:28
    #23 0x2a7b1cb3 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, DB::Context&, bool, DB::QueryProcessingStage::Enum, bool) /build/obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:675:30
    #24 0x2b7993b2 in DB::TCPHandler::runImpl() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:253:24
    #25 0x2b7b649a in DB::TCPHandler::run() /build/obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1217:9
    #26 0x31d9c57e in Poco::Net::TCPServerConnection::start() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
    #27 0x31d9d281 in Poco::Net::TCPServerDispatcher::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:114:20
    #28 0x3206b5d5 in Poco::PooledThread::run() /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
    #29 0x320657ad in Poco::ThreadImpl::runnableEntry(void*) /build/obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
    #30 0x7ffff7f853e8 in start_thread (/usr/lib/libpthread.so.0+0x93e8)
```

</details>
 2020-09-01 10:04:08 +03:00
alesapin
e28b477f79
Merge pull request #14263 from bharatnc/ncb/disallow-codec-for-alias 
Disallow codec for ALIAS columns types
 2020-09-01 09:42:53 +03:00
bharatnc
2c0353587e add tests 2020-08-31 22:53:47 -07:00
bharatnc
c377c228ef fix tests 2020-08-31 10:22:53 -07:00
alexey-milovidov
75ca3d217f
Merge pull request #14232 from zhang2014/fix/ISSUES-14231 
ISSUES-14231 fix wrong lexer in MaterializeMySQL database engine dump stage
 2020-08-31 19:03:04 +03:00
bharatnc
c4e235b000 Merge remote-tracking branch 'upstream/master' into ncb/disallow-codec-for-alias 2020-08-31 09:01:07 -07:00
bharatnc
caed8cd474 change error code to BAD_ARGUMENTS (36) 2020-08-31 09:00:32 -07:00
Alexander Kuzmenkov
bc8765d5ad
Merge pull request #14095 from azat/DistributedFilesToInsert-fix 
Fix DistributedFilesToInsert metric (zeroed when it should not)
 2020-08-31 18:58:30 +03:00
Alexander Kuzmenkov
134aae89f3
Merge pull request #14110 from 4ertus2/decimal 
Fix Decimal to Float conversion and toDecimal256() function
 2020-08-31 17:08:49 +03:00
bharatnc
025de8cecc add tests 2020-08-31 00:12:19 -07:00
zhang2014
761512413e ISSUES-14231 allow dollar and numver in identifier 2020-08-31 14:14:02 +08:00
zhang2014
d24bf8de51 ISSUES-14231 allow dollar sign in identifier 2020-08-31 12:46:41 +08:00
alexey-milovidov
b1efc5df01
Merge pull request #14225 from amosbird/bf1 
Fix bug in mark inclusion search.
 2020-08-30 02:58:22 +03:00
Azat Khuzhin
134080ae3f Add 01460_DistributedFilesToInsert into the arcadia_skip_list 
To fix the following failure:
    Yandex synchronization check (only for Yandex employees)
 2020-08-30 01:24:21 +03:00
alexey-milovidov
2a514eae21
Merge pull request #14223 from nikitamikhaylov/update-permutaiton-bug-fix 
Fixed incorrect sorting order if LowCardinality column.
 2020-08-29 18:25:26 +03:00
Amos Bird
865c66ba7a
Add .reference 2020-08-29 23:09:09 +08:00
alexey-milovidov
4c60f36a0a
Update 01460_mark_inclusion_search_crash.sql 2020-08-29 09:46:46 +08:00
Amos Bird
591a4d60d4
Fix bug in mark inclusion search. 2020-08-29 09:46:46 +08:00
alexey-milovidov
c6f55bbe6a
Merge pull request #14151 from 4ertus2/some 
Add functions: isDecimalOverflow(), countDigits()
 2020-08-28 22:01:54 +03:00
alesapin
10c7a6c45e
Add ability to specify Default codec for columns (#14049) 
* Add ability to specify DefaultCompression codec which correspond to settings specified in config.xml

* Fix style

* Rename DefaultCompression to simple Default

* Fix compression codec

* Better codec description representation

* Less strange code and one method

* Fix delta
 2020-08-28 20:40:45 +03:00
alesapin
65c33f0802
Merge pull request #13280 from amosbird/as 
ALTER MODIFY SAMPLE BY
 2020-08-28 19:32:09 +03:00
Nikita Mikhaylov
9d1cb7e22e done 2020-08-28 18:15:15 +03:00
alesapin
057bb65658
Merge pull request #14199 from azat/01085_max_distributed_connections-flacky-fix 
Fix 01085_max_distributed_connections flackiness
 2020-08-28 13:22:30 +03:00
alesapin
0896b49533 Small fixes 2020-08-28 13:18:56 +03:00
Artem Zuikov
881cd3331a gix comment and useDefault*(), add tests for nullables 2020-08-28 13:16:42 +03:00
alesapin
35af2f9df9
Merge pull request #14198 from azat/00974_distributed_join_on-flacky-fix 
Fix 00974_distributed_join_on flackiness (by allow retries and hide logs)
 2020-08-28 10:04:39 +03:00
Alexey Milovidov
dd6e23bbbd Slightly better test 2020-08-28 04:08:09 +03:00
Alexey Milovidov
733446a5be Added a test with quorum 2020-08-28 04:05:28 +03:00
Alexey Milovidov
538b7730dd Use 10 replicas in test 2020-08-28 04:02:04 +03:00
Alexey Milovidov
ed1d120de0 Added another test; fixup 2020-08-28 03:28:37 +03:00
Azat Khuzhin
07923cd7cd Fix 01085_max_distributed_connections flackiness 
1.8 seconds is too small delay, which eventually can lead to
false-positive if the machine will be slow enough.

Increase number of remote streams and the delay, to avoid
false-positive.
 2020-08-28 02:41:11 +03:00
Azat Khuzhin
cdb6bed8b9 Fix 00974_distributed_join_on flackiness (by allow retries and hide logs) 2020-08-28 02:10:13 +03:00
Alexey Milovidov
c04dc4e722 Merge branch 'master' into manual-write-duplicate-parts-to-replicas 2020-08-28 01:56:11 +03:00
alexey-milovidov
f1811bfc88
Merge pull request #14194 from ClickHouse/fix-flaky-test-12 
Fix flaky test
 2020-08-28 01:46:22 +03:00
Azat Khuzhin
a384194216 Add a test for DistributedFilesToInsert 2020-08-27 22:00:35 +03:00
Alexey Milovidov
b7c27c2a8c Remove race condition from test 2020-08-27 21:43:21 +03:00
Alexey Milovidov
01567d62a4 Fix nullptr dereference in defaultValueOfTypeName 2020-08-27 21:36:18 +03:00
Amos Bird
078b14610d
ALTER MODIFY SAMPLE BY 2020-08-27 22:31:30 +08:00
Artem Zuikov
0d134f2c26 add test 2020-08-27 17:05:55 +03:00