Commit Graph

7752 Commits

Author SHA1 Message Date
János Benjamin Antal
16e2f7f0b9 Add optional version argument to rm 2023-09-16 00:03:46 +00:00
Kruglov Pavel
8d01137d73
Merge pull request #54498 from bakam412/bugfix/local_multiquery_parameter
Bugfix/local multiquery parameter
2023-09-15 11:46:08 +02:00
vdimir
1aa18e0eb6
Analyzer: Remove constants from header in StorageDistributed 2023-09-14 16:44:18 +00:00
Kseniia Sumarokova
eeb2c5b223
Merge pull request #53220 from valbok/double-to-single
MaterializedMySQL: Introduce Character Set Introducers
2023-09-14 13:18:08 +02:00
Robert Schulze
a9ae813db0
Merge pull request #54115 from slvrtrn/simplified-prepared-statements-for-mysql
Implement the MySQL binary protocol implementation for initial support of Tableau Online
2023-09-14 12:27:11 +02:00
Antonio Andelic
6306180333
Merge pull request #53049 from ClickHouse/keeper-batch-flushes
Try batching multiple flush requests in Keeper
2023-09-14 11:39:33 +02:00
Val Doroshchuk
6cfbaf9f86 MaterializedMySQL: Introduce Character Set Introducers
If some string literals are used in DDL, they might have `Character Set Introducers`
https://dev.mysql.com/doc/refman/8.0/en/charset-introducer.html
f.e. _utf8mb4'1' which is not parsable by current ParserStringLiteral.

Since we use utf8 by default, suggesting to automatically convert the string literals to utf8
before executing the query and avoid any charset introducers there.
Conversion from utf8 to utf8 is not needed and skipped.

Also it might convert double quotes to single quotes if any
which might solve issues with COMMENT and empty string literals "" in DEFAULT expressions.

SELECT _latin1"abc"; -- might be also valid for MySQL
... DEFAULT "",
... COMMENT "abc"

Currently no DEFAULT expressions are supported, not parsable at all,
but using this MR it allows to parse the expressions together with double quotes as string literals.
2023-09-14 08:24:25 +02:00
bakam412
c5c3833a80 fix tests 2023-09-14 11:12:44 +08:00
slvrtrn
44e1f6b53d Fix LowCardinality/Nullable columns issues 2023-09-13 23:40:31 +02:00
slvrtrn
c0961d9378 Merge remote-tracking branch 'origin' into simplified-prepared-statements-for-mysql 2023-09-13 19:33:11 +02:00
Nikolay Degterinsky
0998b0bbc7 Fixes 2023-09-13 03:14:02 +00:00
Nikolay Degterinsky
268c45d900 Merge remote-tracking branch 'upstream/master' into users-valid-until 2023-09-12 23:44:22 +00:00
pufit
85b23e9403 Increase default timeout in tests for keeper-client 2023-09-12 14:06:57 -04:00
slvrtrn
dddea9219a Address the review comments 2023-09-12 18:39:03 +02:00
pufit
a54a7b726d
Merge pull request #54201 from ClickHouse/pufit/keeper-client-reconfig
Implementing `reconfig`, `sync`, `exists` commands for keeper-client
2023-09-12 10:58:02 -04:00
Nikolai Kochetov
894024a830
Update test.py 2023-09-12 13:54:26 +02:00
slvrtrn
611a75a87f Merge remote-tracking branch 'origin' into simplified-prepared-statements-for-mysql 2023-09-12 10:38:44 +02:00
Alexey Milovidov
e9daff6c2f
Merge pull request #54506 from azat/system.detached_parts-modification_time
Add modification_time into system.detached_parts
2023-09-12 04:53:59 +03:00
Alexey Milovidov
ee8db35d66
Merge pull request #51449 from ClickHouse/cbrace
Fix data race in copyFromIStreamWithProgressCallback
2023-09-12 04:51:13 +03:00
Sema Checherinda
0ea0799118
Merge pull request #54430 from CheSema/remove-recursive-with-projection
reproduce and fix the bug in removeSharedRecursive
2023-09-12 00:18:55 +02:00
Michael Kolupaev
df71dcd94d Fix data race in copyFromIStreamWithProgressCallback 2023-09-11 21:04:37 +00:00
pufit
4f5d132019 Fix timeout keeper-client 2023-09-11 14:46:40 -04:00
Azat Khuzhin
8cd6153c83 Add modification_time into system.detached_parts
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-09-11 20:29:55 +02:00
Nikolai Kochetov
d86d92fa2d Flush logs for system.backup_log test. 2023-09-11 12:58:04 +00:00
Antonio Andelic
1494eb3a86 Fix version parsing 2023-09-11 12:34:16 +00:00
Igor Nikonov
f3f3eddd52 Merge remote-tracking branch 'origin/master' into pr-distributed-prefer-localhost-replica 2023-09-11 12:13:45 +00:00
Antonio Andelic
479ae52f9c Merge branch 'master' into keeper-batch-flushes 2023-09-11 11:36:23 +00:00
Mikhail f. Shiryaev
61f0683f1c
Merge pull request #54043 from ClickHouse/revert-53929-revert-53713-ADQM-1107
undefined
2023-09-11 11:34:18 +02:00
Sergei Trifonov
08bad4d440
Merge pull request #47009 from ClickHouse/disks-and-io-sheduler 2023-09-11 07:22:14 +02:00
robot-clickhouse-ci-2
47c0f8c99f
Merge pull request #54179 from joelynch/http-query-timing
Add elapsed_ns to HTTP headers X-ClickHouse-Progress and X-ClickHouse-Summary
2023-09-11 06:18:47 +02:00
Igor Nikonov
3a78ba6de4 Fix, enable tests, make cluster_for_parallel_replicas empty by default 2023-09-09 21:36:39 +00:00
Mikhail f. Shiryaev
c7e058fa6e
Disable broken tests 2023-09-09 23:21:16 +02:00
Mikhail f. Shiryaev
b17dc582a5
Disable test_disk_over_web_server for analyzer 2023-09-09 23:21:15 +02:00
Mikhail f. Shiryaev
5f0d94d523
Disable broken tests to have the bug fixed 2023-09-09 23:21:14 +02:00
Mikhail f. Shiryaev
b610faf685
Revert "Revert "Fixed wrong python test name pattern"" 2023-09-09 23:21:14 +02:00
Igor Nikonov
9464433683 Merge remote-tracking branch 'origin/master' into pr-distributed-prefer-localhost-replica 2023-09-09 19:48:50 +00:00
Robert Schulze
4d2223defe
Merge pull request #54119 from mkmkme/mkmkme/aklomp-base64
Replace Turbo-Base64 with aklomp/base64
2023-09-09 16:24:26 +02:00
Sema Checherinda
1298dba0c6 fix the bug, add useful logs 2023-09-09 15:54:28 +02:00
Alexey Milovidov
2e2e226e1d
Merge pull request #54367 from Avogar/fix-flaky-azure-schema-cache-test
Fix flaky test test_storage_azure_blob_storage/test.py::test_schema_iference_cache
2023-09-08 23:48:44 +03:00
robot-ch-test-poll4
839f69c940
Merge pull request #53765 from vitlibar/sync-uuids-of-tables-on-replicas
Sync UUIDs of tables on replicas after RESTORE
2023-09-08 17:30:32 +02:00
Antonio Andelic
5207997bd4 Merge branch 'master' into keeper-batch-flushes 2023-09-08 13:05:47 +00:00
Sema Checherinda
44e432deab style fix 2023-09-08 00:21:21 +02:00
Sema Checherinda
411a97ff36 reproduce a bug in removeSharedRecursive 2023-09-07 21:15:30 +00:00
Robert Schulze
46e1d05a89
Fix another test 2023-09-07 19:43:01 +00:00
Kruglov Pavel
8c2b45aab3
Fix style 2023-09-07 18:42:04 +02:00
Kruglov Pavel
7abc9c896d
Fix style 2023-09-07 18:06:46 +02:00
serxa
a94ae9a7ab review fixes 2023-09-07 14:02:58 +00:00
Igor Nikonov
ce8e72e464
Merge pull request #54377 from ClickHouse/pr-distributed-tests-disable-plr
Disable prefer_localhost_replica in test for parallel replicas
2023-09-07 11:59:42 +02:00
Igor Nikonov
2c85c28113 Cleanup 2023-09-07 07:15:42 +00:00
robot-clickhouse
cc78926919 Automatic style fix 2023-09-07 00:44:54 +00:00
pufit
ef2350cfc7 Implementing exists, sync commands. Better tests 2023-09-06 20:36:39 -04:00
Alexey Milovidov
539394b463
Merge pull request #54371 from Avogar/try-fix-async-query-sending-test
Enable hedged requests integration tests with tsan, use max_distributed_connections=1 to fix possible flakiness
2023-09-07 01:57:24 +03:00
robot-clickhouse
6404768aa4 Automatic style fix 2023-09-06 22:45:17 +00:00
Igor Nikonov
724e2ee4f7 Disable prefer_localhost_replica in tests 2023-09-06 22:27:41 +00:00
robot-clickhouse
cd7c57f5d4 Automatic style fix 2023-09-06 19:00:05 +00:00
Igor Nikonov
f938c38eb9 Merge remote-tracking branch 'origin/master' into pr-distributed-prefer-localhost-replica 2023-09-06 18:47:43 +00:00
serxa
664efaf3fa add test 2023-09-06 18:35:40 +00:00
SmitaRKulkarni
f0146c0ff0
Increase retries for test_merge_tree_azure_blob_storage (#54069)
* Increase max_single_download_retries & max_single_read_retries for test_merge_tree_azure_blob_storage

* Updated logs to log exception leading to detaching part

* Updated to catch RequestFailedException azure exception as its the base exception

* Updated isRetryableExcepion to take std::exception_ptr as input

* Fixed style check fails

* Fix build issue & moved NetException & TimeoutException to retryable exceptions

* Fixed style check with catch
2023-09-06 19:57:59 +02:00
Kruglov Pavel
c3fb0ef5d4
Fix style 2023-09-06 19:42:14 +02:00
avogar
e44580fa47 Enable hedged requests integration tests with tsan, use max_distributed_connections=1 to fix possible flakiness 2023-09-06 17:15:23 +00:00
avogar
76acc77e66 Fix flaky test test_storage_azure_blob_storage/test.py::test_schema_inference_cache 2023-09-06 16:39:45 +00:00
Antonio Andelic
824b90f754 Merge branch 'master' into keeper-batch-flushes 2023-09-06 13:29:35 +00:00
robot-clickhouse
87a59e7084 Automatic style fix 2023-09-05 23:12:35 +00:00
Igor Nikonov
3fe2e1084b test_read_equally_from_each_replica + prefer_localhost_replica=1 2023-09-05 22:25:34 +00:00
Joe Lynch
91f637b24a
fix python test 2023-09-05 21:03:13 +02:00
Arthur Passos
46c62f4543
Lower the number of iterations in test_host_regexp_multiple_ptr_records_concurrent (#54307)
* Lower the number of iterations in test_host_regexp_multiple_ptr_records_concurrent

Suddenly, `test_host_regexp_multiple_ptr_records_concurrent` became flaky. I have looked through two reports, both of them manage to complete > 9k requests. This change lowers the iteration so the total amount of requests is 8k.

* 50 to be on super safe side
2023-09-05 20:05:12 +02:00
robot-ch-test-poll
2e7edf4413
Merge pull request #53638 from arenadata/ADQM-987
Add `backup_log` system table
2023-09-05 17:03:41 +02:00
robot-clickhouse
8a1984ae8c
Merge pull request #54291 from ClickHouse/fix-test_keeper_disks
Fix `test_keeper_disks`
2023-09-05 14:51:44 +02:00
vdimir
f7e57edea8
Merge pull request #54113 from ClickHouse/vdimir/cluser_discovery_init_fix 2023-09-05 11:49:57 +02:00
Victor Krasnov
132ab6067b Merge branch 'master' into ADQM-987 2023-09-05 10:01:44 +03:00
Antonio Andelic
8086472909 Use different config for snapshot test 2023-09-05 06:45:06 +00:00
Alexey Milovidov
b2821106fd
Merge pull request #53923 from myrrc/docs/ch-disks
Add docs for clickhouse-disks
2023-09-05 02:10:18 +03:00
slvrtrn
319a51c0b7 Address style checks 2023-09-04 22:05:51 +02:00
slvrtrn
6e0a254368 Update tests, update imports, remove requirements 2023-09-04 21:50:06 +02:00
slvrtrn
4f4640ec90 Add DateTime64 support 2023-09-04 20:49:29 +02:00
Victor Krasnov
78760639d2 Merge branch 'master' into ADQM-987 2023-09-04 13:59:20 +03:00
Antonio Andelic
365bc584ec Merge branch 'master' into keeper-batch-flushes 2023-09-04 07:24:21 +00:00
Igor Nikonov
40efa989f3 Merge remote-tracking branch 'origin/master' into revert-54189-revert-53904-fix-parallel-replicas-skip-shards 2023-09-03 20:48:48 +00:00
robot-clickhouse
23091478d1 Automatic style fix 2023-09-03 14:03:18 +00:00
Igor Nikonov
4e6a2b38d3 Extend cluster_all_replicas intergration test
+ skip_unavailable_shards
2023-09-03 13:39:05 +00:00
Victor Krasnov
9c315490f7 Align test_backup_restore_new::test_backup_all[True] with backup_log 2023-09-03 15:04:23 +03:00
Alexey Milovidov
061821d731 Update test 2023-09-03 00:03:15 +02:00
Igor Nikonov
d7076ab017
Revert "Revert "Fix: respect skip_unavailable_shards with parallel replicas"" 2023-09-02 23:52:56 +02:00
robot-clickhouse-ci-1
97061f6806
Merge pull request #54199 from ClickHouse/fix-parallel-replicas-distributed
Fix: parallel replicas over distributed don't read from all replicas
2023-09-02 15:38:51 +02:00
Alexey Milovidov
44bf743304
Merge pull request #54191 from arthurpassos/fix_flaky_test_s3_storage_conf_proxy
Fix flaky test_s3_storage_conf_proxy
2023-09-02 16:38:21 +03:00
robot-clickhouse
2c23be72f3 Automatic style fix 2023-09-01 22:55:55 +00:00
Igor Nikonov
a59674f624 Fix: parallel replicas over distributed don't read from all replicas on shard 2023-09-01 22:33:42 +00:00
Arthur Passos
fd417c84ef resolve might return proxy2 in some cases, account for that 2023-09-01 13:41:12 -03:00
Victor Krasnov
52cce27e81 Merge branch 'master' into ADQM-987 2023-09-01 18:00:20 +03:00
Igor Nikonov
f2290d9a6f
Fix: respect skip_unavailable_shards with parallel replicas (#53904)
Co-authored-by: robot-clickhouse <robot-clickhouse@users.noreply.github.com>
2023-09-01 15:57:40 +02:00
Antonio Andelic
5f1a75ceae Fix tests 2023-09-01 12:13:33 +00:00
Alexander Tokmakov
d81eae6c1b Merge branch 'master' into some_fixes 2023-08-31 19:15:54 +02:00
robot-clickhouse
3999994eb4 Automatic style fix 2023-08-31 15:07:26 +00:00
Antonio Andelic
7739dd7157 Fix integration tests 2023-08-31 14:52:42 +00:00
Antonio Andelic
dd824fe558 Merge branch 'master' into keeper-batch-flushes 2023-08-31 14:35:36 +00:00
Mike Kot
ebcc97ad1b change case for copy operation in clickhouse-disks 2023-08-31 13:39:32 +00:00
Anton Popov
579ec699bf Merge remote-tracking branch 'upstream/master' into HEAD 2023-08-31 12:59:59 +00:00
Raúl Marín
4703c463aa Merge remote-tracking branch 'blessed/master' into better_zk_retries_on_insert 2023-08-31 14:37:02 +02:00
vdimir
d7dca71bee
Add fail point to cluster discovery initialization 2023-08-31 11:45:54 +00:00
slvrtrn
8483d1c701 Binary protocol tests 2023-08-31 13:26:27 +02:00
Robert Schulze
97d960ba1d
Merge pull request #53818 from arenadata/ADQM-1070
Add new hide_in_preprocessed attribute in configuration file
2023-08-31 13:00:16 +02:00
robot-ch-test-poll
10898ee96f
Merge pull request #54092 from arenadata/ADQM-1080
Increased log waiting timeout in test_profile_max_sessions_for_user
2023-08-31 06:04:51 +02:00
Alexey Gerasimchuck
3de967ecbe Increased log waiting timeout 2023-08-30 22:05:38 +00:00
Alexey Milovidov
bb47e2cc23 Remove CurrentStatusInfo 2023-08-30 20:56:14 +02:00
slvrtrn
8378441248 Merge remote-tracking branch 'origin' into simplified-prepared-statements-for-mysql 2023-08-30 19:00:51 +02:00
slvrtrn
f4dd6be8a8 WIP prepared statements 2023-08-30 18:59:39 +02:00
Alexander Tokmakov
5cfd1c6d63
Merge pull request #54066 from kssenii/fix-named-collections-access-type-change
Fix named_collection_admin alias
2023-08-30 18:34:03 +02:00
Victor Krasnov
6dd926b68b Rename back_table_up to backup_table 2023-08-30 18:53:07 +03:00
Alexander Tokmakov
4d70624ca3
Merge pull request #53907 from arenadata/ADQM-1126
Added validate_tcp_client_information server setting
2023-08-30 15:10:13 +02:00
kssenii
185e3819ac Fix 2023-08-30 13:41:18 +02:00
Alexey Gerasimchuck
a1687e618b backward compatibility changes + fixes 2023-08-29 23:50:41 +00:00
Alexander Tokmakov
e610a1867c
Revert "Fixed wrong python test name pattern" 2023-08-29 15:19:13 +02:00
Alexander Tokmakov
87890ef02d update tests 2023-08-29 14:35:30 +02:00
Roman Vasin
7ceb9ec5eb Fix flakiness in test_config_hide_in_preprocessed 2023-08-29 11:22:23 +00:00
Mikhail f. Shiryaev
25eda7f358
Merge pull request #53713 from arenadata/ADQM-1107
Fixed wrong python test name pattern
2023-08-29 12:38:12 +02:00
János Benjamin Antal
a1a45ee905
Merge pull request #53766 from ilejn/exceptions_kafka_consumers
system.kafka_consumers exception info improvements
2023-08-29 10:22:26 +02:00
Roman Vasin
8ad066ecd3 Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-1070 2023-08-29 05:08:46 +00:00
Alexey Gerasimchuck
1069244d17 Fix in ci-runner.py 2023-08-28 22:05:36 +00:00
Raúl Marín
174f7a4e63 Merge remote-tracking branch 'blessed/master' into better_zk_retries_on_insert 2023-08-28 16:27:45 +02:00
Antonio Andelic
4137cb916d Merge branch 'master' into keeper-batch-flushes 2023-08-28 13:14:06 +00:00
Roman Vasin
5f70361583 Add test for 1 value of hide_in_preprocessed 2023-08-28 12:59:43 +00:00
Roman Vasin
6ee3639966 Rename hide attribute into hide_in_preprocessed 2023-08-28 12:51:17 +00:00
Victor Krasnov
921f0c8b5d Merge branch 'master' into ADQM-987 2023-08-25 21:20:23 +03:00
Roman Vasin
8cfab6d53f Merge branch 'master' of github.com:ClickHouse/ClickHouse into ADQM-1070 2023-08-25 12:13:53 +00:00
kssenii
fe4e04a7ae Merge remote-tracking branch 'upstream/master' into parallelize-file-cache-metadata-download 2023-08-25 11:36:40 +02:00
Kruglov Pavel
1b4a907574
Try fix tests 2023-08-25 00:04:43 +02:00
Kruglov Pavel
44db5fa992
Merge branch 'master' into cache-count 2023-08-24 17:21:18 +02:00
Roman Vasin
b4e0ca3b0a Add test for nested nodes, add checks for presence of nodes in pre-processed config 2023-08-24 14:23:46 +00:00
Ilya Golshtein
f58b4a812d exceptions_kafka_consumers: code review suggestions are addressed 2023-08-24 13:10:21 +00:00
Arthur Passos
2bade7db08
Add global proxy setting (#51749)
* initial impl

* fix env ut

* move ut directory

* make sure no null proxy resolver is returned by ProxyConfigurationResolverProvider

* minor adjustment

* add a few tests, still incomplete

* add proxy support for url table function

* use proxy for select from url as well

* remove optional from return type, just returns empty config

* fix style

* style

* black

* ohg boy

* rm in progress file

* god pls don't let me kill anyone

* ...

* add use_aws guards

* remove hard coded s3 proxy resolver

* add concurrency-mt-unsafe

* aa

* black

* add logging back

* revert change

* imrpove code a bit

* helper functions and separate tests

* for some reason, this env test is not working..

* formatting

* :)

* clangtidy

* lint

* revert some stupid things

* small test adjusmtments

* simplify tests

* rename test

* remove extra line

* freaking style change

* simplify a bit

* fix segfault & remove an extra call

* tightly couple proxy provider with context..

* remove useless include

* rename config prefix parameter

* simplify provider a bit

* organize provider a bit

* add a few comments

* comment out proxy env tests

* fix nullptr in unit tests

* make sure old storage proxy config is properly covered without global context instance

* move a few functions from class to anonymous namespace

* fix no fallback for specific storage conf

* change API to accept http method instead of bool

* implement http/https distinction in listresolver, any still not implemented

* implement http/https distinction in remote resolver

* progress on code, improve tests and add url function working test

* use protcol instead of method for http and https

* small fix

* few more adjustments

* fix style

* black

* move enum to proxyconfiguration

* wip

* fix build

* fix ut

* delete atomicroundrobin class

* remove stale include

* add some tests.. need to spend some more time on the design..

* change design a bit

* progress

* use existing context for tests

* rename aux function and fix ut

* ..

* rename test

* try to simplify tests a bit

* simplify tests a bit more

* attempt to fix tests, accept more than one remote resolver

* use proper log id

* try waiting for resolver

* proper wait logic

* black

* empty

* address a few comments

* refactor tests

* remove old tests

* baclk

* use RAII to set/unset env

* black

* clang tidy

* fix env proxy not respecting any

* use log trace

* fix wrong logic in getRemoteREsolver

* fix wrong logic in getRemoteREsolver

* fix test

* remove unwanted code

* remove ClientConfigurationperRequest and auxilary classes

* remove unwanted code

* remove adapter test

* few adjustments and add test for s3 storage conf  with new proxy settings

* black

* use chassert for context

* Add getenv comment
2023-08-24 16:07:26 +03:00
Anton Popov
19a52f19f1
Merge pull request #53547 from joelynch/shutdown-async-insert-queue-first
bugfix: Flush async insert queue first on shutdown
2023-08-24 13:59:12 +02:00
Raúl Marín
1c98568df9 Merge remote-tracking branch 'blessed/master' into better_zk_retries_on_insert 2023-08-24 12:22:42 +02:00
Kseniia Sumarokova
4caa60e642
Update test.py 2023-08-24 11:50:56 +02:00
Kseniia Sumarokova
4d2efd87b5
Merge pull request #53736 from kssenii/fix-s3-queue-test
Fix flaky test_storage_s3_queue/test.py::test_delete_after_processing
2023-08-24 11:47:56 +02:00
Antonio Andelic
322b53dd62 Merge branch 'master' into keeper-batch-flushes 2023-08-24 09:08:47 +00:00
Ilya Golshtein
94ae9f640f exceptions_kafka_consumers: test fix 2023-08-24 07:28:26 +00:00
Ilya Golshtein
ec0c12960a exceptions_kafka_consumers: stylecheck 2023-08-23 23:10:25 +00:00
Ilya Golshtein
e7213ef5b9 exceptions_kafka_consumers: new test, MV exceptions propagated 2023-08-23 22:46:04 +00:00
Vitaly Baranov
7b9d6c4b96 Add test. 2023-08-23 23:33:51 +02:00
Kruglov Pavel
3404efcb21
Fix style 2023-08-23 22:20:14 +02:00
avogar
894513f6cd Fix tests 2023-08-23 18:43:08 +00:00
Kruglov Pavel
592fa77987
Merge branch 'master' into cache-count 2023-08-23 15:18:02 +02:00
Joe Lynch
075c0261e9
These queries need to be run in the same session 2023-08-23 15:00:00 +02:00
Joe Lynch
8d0824f1b8
Add test for flushing async insert queue 2023-08-23 15:00:00 +02:00
robot-ch-test-poll1
c22ffa6195
Merge pull request #53529 from Avogar/filter-files-all-table-functions
Use filter by file/path before reading in url/file/hdfs table functins
2023-08-23 14:21:23 +02:00
helifu
9300d2848d Fix a style check issue 2023-08-23 20:13:54 +08:00
helifu
178194ec50 Updated according to review comments 2023-08-23 19:50:27 +08:00
helifu
f5ca37d0b6 Update the test case 2023-08-23 19:42:03 +08:00
helifu
270adafe53 Fix a style check issue 2023-08-23 19:42:03 +08:00
helifu
0cea777aa9 Fix a style check issue 2023-08-23 19:42:03 +08:00