Smita Kulkarni
1f89db78a5
Added is_create_parameterized_view flag in ActionsVisitor, added functions for column manipulation for parameterized view in StorageView, updated tests to fix flaky test issues and addressed small review comments- 40907 Parameterized views as table functions
2023-01-03 11:00:39 +01:00
Antonio Andelic
e0b8fd528d
Merge pull request #44842 from ClickHouse/fix-data-race-storage-s3
...
Fix data race in StorageS3
2023-01-03 09:20:08 +01:00
Han Fei
7d7de3833b
Merge pull request #44651 from hanfei1991/hanfei/fix-async-insert-cleanup
...
fix bug that async blocks cleanup not work
2023-01-02 21:58:27 +01:00
Dmitry Novik
929300a721
Update MergeTreeData.cpp
2023-01-02 21:18:16 +01:00
Dmitry Novik
04fb410a40
Merge branch 'master' into parallel_parts_cleanup_with_zero_copy
2023-01-02 20:48:39 +01:00
Dmitry Novik
c646048af9
Merge pull request #44461 from ClickHouse/parts-removal-limit
...
Add part removal limit for one CleanupThread iteration
2023-01-02 20:04:19 +01:00
Alexey Milovidov
e855d3519a
Merge branch 'master' into refactoring-ip-types
2023-01-02 21:58:53 +03:00
Nikolai Kochetov
d2630f8321
Add test.
2023-01-02 18:01:53 +00:00
Nikolai Kochetov
09325ff17e
Store context created from projection analysis.
2023-01-02 17:00:48 +00:00
alesapin
39331e07d5
Improve logging
2023-01-02 17:05:08 +01:00
alesapin
6fc63878b4
Fix rare race which can lead to queue hang
2023-01-02 16:57:25 +01:00
Kruglov Pavel
966f57ef68
Merge pull request #42777 from Avogar/improve-streaming-engines
...
Refactor and Improve streaming engines Kafka/RabbitMQ/NATS and data formats
2023-01-02 15:59:06 +01:00
Antonio Andelic
e07d820156
Fix race on total_size
2023-01-02 14:28:27 +00:00
Han Fei
eef0136415
add debug log
2023-01-02 11:59:44 +01:00
Alexey Milovidov
50bb7f90d8
Merge pull request #44809 from ClickHouse/fix-race-in-mergetreedatapart
...
Fix race in `system.parts` and `system.parts_columns`
2023-01-01 01:09:46 +03:00
Han Fei
a036c6bc01
Merge branch 'master' into hanfei/fix-async-insert-cleanup
2022-12-31 20:52:16 +01:00
Alexey Milovidov
3a5cea8281
Fix race in system.parts and system.parts_columns
2022-12-31 15:07:26 +01:00
Alexey Milovidov
26eb2f57e1
Fix race in system.parts and system.parts_columns
2022-12-31 15:06:57 +01:00
Azat Khuzhin
e7bf2cc959
Add a comment for lack of fsync in MergedBlockOutputStream::finalizePartOnDisk()
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-30 22:39:13 +01:00
Azat Khuzhin
9fb6004c92
Add missing fsync for small files (ttl.txt, columns.txt, ...) in mutations
...
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-30 22:22:39 +01:00
Nikolai Kochetov
758f30cc17
Cleanup.
2022-12-30 17:53:46 +00:00
avogar
2ca3a74b9a
Fix style
2022-12-30 16:46:21 +00:00
avogar
a74ffa70bc
Don't use async producing in Kafka
2022-12-30 16:40:04 +00:00
Nikolai Kochetov
5f38e17941
Fix integration test.
2022-12-30 16:20:06 +00:00
Vladimir C
2ff0d7e942
Apply suggestion
2022-12-30 16:48:57 +01:00
Han Fei
454f40ab17
fix test
2022-12-30 16:30:33 +01:00
Alexander Gololobov
2c64f0042a
Added force_wait parameter to IStorage::mutate()
2022-12-30 16:23:03 +01:00
chen
72200273da
Update StorageS3Settings.cpp
2022-12-30 22:47:48 +08:00
Kruglov Pavel
0844fe7089
Merge pull request #44493 from xiedeyantu/s3_optimize
...
If user only need virtual columns, we don't need to initialize ReadBufferFromS3
2022-12-30 15:44:20 +01:00
xiedeyantu
c636b3e363
S3 support upload object using storage class INTELLIGENT_TIERING
2022-12-30 21:05:01 +08:00
Alexander Gololobov
d12f5cb119
Merge pull request #44705 from ClickHouse/fix_crash_on_delete
...
Fix crash on delete from materialized view
2022-12-30 12:57:21 +01:00
Alexey Milovidov
13b76ad760
Merge pull request #44719 from ClickHouse/fix_attach_thread_deadlock
...
Fix deadlock in attach thread
2022-12-30 13:56:18 +03:00
Nikolay Degterinsky
dfe93b5d82
Merge pull request #42284 from Algunenano/perf_experiment
...
Performance experiment
2022-12-30 03:14:22 +01:00
Kruglov Pavel
894726bd8f
Merge branch 'master' into improve-streaming-engines
2022-12-29 22:59:45 +01:00
Alexander Gololobov
fbae502499
Merge pull request #42126 from ClickHouse/fix_invalid_number_of_rows_in_chunk_with_prewhere
...
Fixing "Invalid number of rows in Chunk" with lightweight deletes
2022-12-29 21:46:12 +01:00
Kseniia Sumarokova
e52ef6cbcd
Update NamedCollectionsHelpers.h
2022-12-29 21:35:20 +01:00
alesapin
5dfefb43a3
Fix deadlock in attach thread
2022-12-29 18:52:20 +01:00
Alexey Milovidov
4c80f597c9
Merge pull request #44706 from kssenii/fix-filelog-tests
...
Fix flaky filelog tests with database ordinary
2022-12-29 20:31:08 +03:00
Alexander Gololobov
e6b6ea59bf
Merge branch 'master' into fix_crash_on_delete
2022-12-29 17:55:03 +01:00
Dmitry Novik
81c0db3b67
Reuse FunctionBase for IndexHint
2022-12-29 15:47:43 +00:00
Dmitry Novik
bd480f18c1
Merge branch 'master' into parts-removal-limit
2022-12-29 16:27:54 +01:00
vdimir
aa3ecbab0a
Fix bug with wring type in Merge table with PREWHERE
2022-12-29 15:22:31 +00:00
chen
6ad3bb2caa
Merge branch 'master' into s3_optimize
2022-12-29 23:22:11 +08:00
Alexander Gololobov
a02a631d51
Cleanups based on code review
2022-12-29 15:00:42 +01:00
Alexander Gololobov
7df137e460
Replaced asserts with logical errors
2022-12-29 14:33:11 +01:00
SmitaRKulkarni
02ff2ea8ac
Merge branch 'master' into 40907_Parameterized_views_as_table_functions
2022-12-29 13:56:00 +01:00
Alexey Milovidov
875797ee63
Merge pull request #44685 from ClickHouse/remove-old-code-4
...
Remove old code
2022-12-29 15:43:59 +03:00
alesapin
02c3e708af
Merge pull request #44694 from Algunenano/old_part_improvement
...
Improve handling of old parts
2022-12-29 13:14:52 +01:00
Alexander Gololobov
938aac906e
Added IStorage::supportsDelete() method to properly check for DELETE FROM query support
2022-12-29 13:03:50 +01:00
chen
2e54f4e3f4
Merge branch 'ClickHouse:master' into s3_optimize
2022-12-29 20:03:30 +08:00
kssenii
4c111465cd
Fix
2022-12-29 12:59:09 +01:00
alesapin
b1ed48a977
Merge pull request #44628 from ClickHouse/CurtizJ-fix-restart-after-quorum-insert
...
Fix restart after quorum insert
2022-12-29 12:51:54 +01:00
Vladimir C
f002ff605d
Merge pull request #44261 from lzydmxy/remove-limits-on-maximum-result-for-view
...
fixes https://github.com/ClickHouse/ClickHouse/issues/44260
2022-12-29 11:53:57 +01:00
Alexander Gololobov
059ec6f747
Cleanups
2022-12-29 01:22:47 +01:00
Alexey Milovidov
4579067762
Merge pull request #44681 from Avogar/fix-std-exception
...
Avoid std::out_of_range exception in StorageExecutable
2022-12-29 01:54:51 +03:00
Alexey Milovidov
4311e6c147
Merge pull request #44683 from CurtizJ/fix-flaky-test-4
...
Fix test `01130_in_memory_parts`
2022-12-29 01:53:24 +03:00
Raúl Marín
32d1662503
Improve handling of old parts
2022-12-28 21:22:40 +01:00
Raúl Marín
5de11979ce
Unify query elapsed time measurements ( #43455 )
...
* Unify query elapsed time reporting
* add-test: Make shell tests executable
* Add some tests around query elapsed time
* Style and ubsan
2022-12-28 21:01:41 +01:00
Raúl Marín
e915ce1e95
Merge remote-tracking branch 'blessed/master' into perf_experiment
2022-12-28 20:15:43 +01:00
Alexey Milovidov
33bcd07be5
Remove old code
2022-12-28 19:02:06 +01:00
alesapin
697617548c
Tiny improvement
2022-12-28 18:59:24 +01:00
Nikolai Kochetov
763fcdc939
Update MergeTreeSequentialSource.cpp
2022-12-28 18:17:40 +01:00
Alexander Gololobov
10a058d138
More cleanups in the logic of applying current step filter and final filter
2022-12-28 18:07:36 +01:00
Alexander Gololobov
fd5d328fae
Test accumulating filters ignoring prewhere_info->need_filter flag
2022-12-28 18:07:36 +01:00
Alexander Gololobov
a7adc0a91b
Cleanups
2022-12-28 18:07:36 +01:00
Alexander Gololobov
b22711baa3
Reset need_filter flag when filter is applied
2022-12-28 18:07:36 +01:00
Alexander Gololobov
ada6422985
Restored old logic for filling _part_offset
2022-12-28 18:07:36 +01:00
Alexander Gololobov
4cebc6f3a4
Cleanups
2022-12-28 18:07:36 +01:00
Alexander Gololobov
13e457c754
Cleanups
2022-12-28 18:07:36 +01:00
Alexander Gololobov
a1cdad4815
Fix for reading _part_offset along with newly added column that has only default value
2022-12-28 18:07:35 +01:00
Alexander Gololobov
ac1549f6b3
Skip filtering if there are no rows after optimize()
2022-12-28 18:07:35 +01:00
Alexander Gololobov
f273f8712d
Avoid filtering same column in block_before_prewhere if it is present in the result
2022-12-28 18:07:35 +01:00
Alexander Gololobov
f3646248c5
Avoid unneeded work if all rows were filtered
2022-12-28 18:07:35 +01:00
Alexander Gololobov
75152ddabb
Apply filter only if needed
2022-12-28 18:07:35 +01:00
Alexander Gololobov
a18850458c
Test applying current filter at each step
2022-12-28 18:07:35 +01:00
Alexander Gololobov
29b5c4af07
Test dirty intermediate changes
2022-12-28 18:07:35 +01:00
Alexander Gololobov
c561acb774
Properly handle low cardinality column as prewhere filter
2022-12-28 18:07:35 +01:00
Alexander Gololobov
aa276b230b
Don't need to save filter and rows_per_granule from previous step
2022-12-28 18:07:35 +01:00
Alexander Gololobov
c4a01cbd5b
Fix for propely cleaning rows_per_granule_original between prewhere steps
2022-12-28 18:07:35 +01:00
Alexander Gololobov
abbb58107c
Fix for "out of bound" in ColumnVector::insertRangeFrom called from shrink()
2022-12-28 18:07:35 +01:00
Alexander Gololobov
79874e8733
Fix for "Invalid number of rows in Chunk"
2022-12-28 18:07:35 +01:00
Alexander Gololobov
bdf51545f7
Added FilterWithCachedCount class instead of caching counts in filter_bytes_map
2022-12-28 18:07:35 +01:00
Azat Khuzhin
31a88d4eae
Fix PREWHERE with row-level filters (when row filter is always true/false)
...
In case of row-level filters optimized out, i.e. converted to
always true/false, it is possible for MergeTreeRangeReader to reuse
incorrect statistics for the filter (countBytesInResultFilter()), and
because of this it simply does not apply other filters, since it assume
that this filter does not need to filter anything.
Fixes : #40956
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-28 18:07:35 +01:00
Alexander Gololobov
d44392b366
Checking the fix for "Invalid number of rows in Chunk"
2022-12-28 18:07:35 +01:00
Anton Popov
38f0cf9b10
fix test 01130_in_memory_parts
2022-12-28 16:40:31 +00:00
Dmitry Novik
6efd64a61c
Merge branch 'master' into parts-removal-limit
2022-12-28 17:34:48 +01:00
avogar
80ef2c6edc
Avoid std::out_of_range exception in StorageExecutable
2022-12-28 16:21:58 +00:00
alesapin
3a1e9f4a4d
Fix style
2022-12-28 14:08:13 +01:00
Kruglov Pavel
d5eece7408
Merge branch 'master' into s3_optimize
2022-12-28 13:19:57 +01:00
xiedeyantu
d6a92fbd63
better
2022-12-28 10:11:33 +08:00
Nikolai Kochetov
c203aa054a
Use sequential source for mutations.
2022-12-27 20:28:25 +00:00
Han Fei
4d8513024c
fix bug that async blocks cleanup not work
2022-12-27 20:12:09 +01:00
alesapin
3a7f26ff3a
Split test into two
2022-12-27 16:15:23 +01:00
Raúl Marín
948ce8db93
Revert "Merge pull request #38953 from ClickHouse/add-allocation-ptr-to-trace-log"
...
This reverts commit e99849d031
, reversing
changes made to 7ad3ff8a9e
.
2022-12-27 14:28:13 +01:00
alesapin
560223ac19
Merge branch 'fix-restart-after-quorum-insert' of github.com:CurtizJ/ClickHouse into CurtizJ-fix-restart-after-quorum-insert
2022-12-27 13:48:55 +01:00
Alexey Milovidov
bfe895975e
Merge pull request #44575 from ClickHouse/minimal-changes
...
Non-significant changes
2022-12-27 15:34:27 +03:00
Alexey Milovidov
464a513f0e
Merge pull request #44615 from ClickHouse/projection-grouping-sets
...
Disable projections in presense of any grouping sets, including WITH ROLLUP, WITH CUBE and WITH TOTALS
2022-12-27 15:31:03 +03:00
Alexey Milovidov
1b21cc018e
Merge pull request #44342 from ClickHouse/add-test-29883
...
Add a test for #29883
2022-12-27 14:55:14 +03:00
Raúl Marín
fc1fa82a39
Merge branch 'master' into perf_experiment
2022-12-27 10:51:58 +01:00
SmitaRKulkarni
4d7459bd65
Merge branch 'master' into 40907_Parameterized_views_as_table_functions
2022-12-27 08:15:42 +01:00
Alexey Milovidov
593675a7c5
Disable projections in presense of any grouping sets, including WITH ROLLUP, WITH CUBE and WITH TOTALS
2022-12-26 22:31:41 +01:00
Igor Nikonov
ba88bc17d4
Fix typo
2022-12-26 21:01:00 +00:00
Igor Nikonov
3204f7353b
Fix: handle exceptions from unlockSharedData() during error handling
...
+ renamePartToTemporary() lambda to reused code
2022-12-26 20:49:04 +00:00
Igor Nikonov
0d428318a9
Merge remote-tracking branch 'origin/master' into fix-restart-after-quorum-insert
2022-12-26 19:18:35 +00:00
Alexey Milovidov
52b306d544
Improve variable name
2022-12-26 18:00:18 +01:00
alesapin
d8924f0b0e
Merge pull request #44578 from ClickHouse/check-bad-index-granularity
...
Check for bad index granularity
2022-12-26 15:20:36 +01:00
Yakov Olkhovskiy
280e14456f
Merge pull request #44026 from ClickHouse/bug-ephemeral-default
...
Support expression for EPHEMERAL (currently only literal is supported)
2022-12-25 18:59:38 -05:00
Alexey Milovidov
71850f6913
Check for bad index_granularity
2022-12-25 16:06:34 +01:00
Alexey Milovidov
f22fc35900
Minimal changes
2022-12-25 14:18:05 +01:00
Nikolai Kochetov
03352a15b6
Use sequential source for mutations.
2022-12-23 22:39:27 +00:00
Alexander Tokmakov
a0668af762
Update MergeTreeData.cpp
2022-12-23 23:06:37 +03:00
Alexander Tokmakov
b2af49a4cf
Merge branch 'master' into parallel_parts_cleanup_with_zero_copy
2022-12-23 20:02:17 +01:00
Smita Kulkarni
a6f860f24e
Fixed review comments and updated FunctionParameterValuesVisitor to use visitFunction - 40907 Parameterized views as table functions
2022-12-23 17:57:17 +01:00
chen
3263815d20
Merge branch 'master' into s3_optimize
2022-12-23 23:57:58 +08:00
alesapin
2fecf420cb
Merge pull request #44513 from ClickHouse/small_polishing
...
Minor code polishing
2022-12-23 13:47:26 +01:00
xiedeyantu
2dd809e403
fix
2022-12-23 19:45:26 +08:00
xiedeyantu
68aeb39892
fix
2022-12-23 19:33:08 +08:00
xiedeyantu
d0eb22a1cd
fix
2022-12-23 19:25:14 +08:00
kssenii
8308177361
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-23 12:14:46 +01:00
xiedeyantu
b5fd23358f
fixed
2022-12-23 19:11:51 +08:00
Vladimir C
7482ea54ab
Merge pull request #43972 from ClickHouse/vdimir/tmp-data-in-fs-cache-2
2022-12-23 11:59:27 +01:00
kssenii
853f2ea123
Merge remote-tracking branch 'upstream/master' into use-new-named-collections-code-2
2022-12-23 11:49:02 +01:00
Kseniia Sumarokova
068f2f329b
Merge pull request #44517 from kssenii/better-error-message
...
Better error message if named collection does not exist
2022-12-23 11:39:06 +01:00
Alexander Tokmakov
45f9fa48c8
fix
2022-12-23 02:12:14 +01:00
Alexander Tokmakov
6b6504f0d1
Merge branch 'master' into parallel_parts_cleanup_with_zero_copy
2022-12-23 02:04:43 +01:00
Dmitry Novik
6c23721255
Merge pull request #43761 from ClickHouse/refector-function-node
...
Refactor FunctionNode
2022-12-22 23:53:27 +01:00
alesapin
a32fab90d5
Merge pull request #44436 from ClickHouse/fix_bug_with_max_task_count_update
...
Fix bug with merge/mutate pool size increase
2022-12-22 23:48:54 +01:00
Dmitry Novik
d3502937c7
Update MergeTreeIndexSet
2022-12-22 22:17:18 +00:00
Dmitry Novik
cff882d506
Merge remote-tracking branch 'origin/master' into refector-function-node
2022-12-22 21:34:29 +00:00
Raúl Marín
d540b74e1f
Rework the shared lock usage in system.tables
2022-12-22 19:40:29 +01:00
Raúl Marín
f0fe27e9e2
Do not acquire read locks in system.tables when possible
2022-12-22 17:31:34 +01:00
alesapin
8d0ad4bbcd
Strange why I have to supress in .cpp
2022-12-22 16:14:19 +01:00
kssenii
11c0aa189a
Better error message
2022-12-22 15:29:35 +01:00
alesapin
fa467b3398
Minor code polishing
2022-12-22 14:31:42 +01:00
Nikolai Kochetov
773de7a8a6
Merge pull request #44472 from CurtizJ/fix-mutations
...
Fix mutations with setting `max_streams_for_merge_tree_reading`
2022-12-22 14:05:20 +01:00
kssenii
a58b8b8e6c
Fix tests
2022-12-22 12:27:42 +01:00
alesapin
049103c550
Merge pull request #44495 from azat/mergetree/static-storage-fix
...
Do not try to remove WAL/move broken parts for static storage
2022-12-22 12:27:08 +01:00
Vladimir C
341d759837
Merge branch 'master' into remove-limits-on-maximum-result-for-view
2022-12-22 12:17:06 +01:00
vdimir
88008726d8
Merge branch 'master' into vdimir/tmp-data-in-fs-cache-2
2022-12-22 10:58:39 +00:00
alesapin
380c6cebe4
Merge pull request #44393 from ClickHouse/small_improvement
...
Lock table for share during startup for database ordinary
2022-12-22 11:42:42 +01:00
alesapin
bf188c46a4
Merge branch 'master' into fix_bug_with_max_task_count_update
2022-12-22 11:40:08 +01:00
Maksim Kita
e5ebf20044
Merge pull request #44097 from kitaisreal/analyzer-support-set-index
...
Analyzer support Set index
2022-12-22 13:30:15 +03:00
vdimir
d30d25dbbe
Temporary files evict fs cache
2022-12-22 10:22:49 +00:00
Yakov Olkhovskiy
a8cb29da4b
Merge branch 'master' into refactoring-ip-types
2022-12-21 23:56:24 -05:00
chen
5c8fb627b3
Update StorageS3.cpp
2022-12-22 08:28:09 +08:00
chen
9fc1020855
Update StorageS3.cpp
2022-12-22 08:15:50 +08:00
kssenii
d3db1dd6a7
Fix tests
2022-12-22 00:27:22 +01:00
alesapin
9b97cd98c8
Update src/Storages/MergeTree/MergeTreeDataMergerMutator.h
2022-12-21 23:27:17 +01:00
alesapin
97d43a6748
Add comment
2022-12-21 23:26:26 +01:00
alesapin
edcd0d95ca
Revert "Remove explicit dependency on fast test to debug the issue"
...
This reverts commit 2fe969a2e1
.
2022-12-21 23:25:50 +01:00