Commit Graph

121298 Commits

Author SHA1 Message Date
Alexey Gerasimchuck
63b05da1f2 System logs improvements 2023-07-28 07:23:34 +00:00
Alexey Milovidov
a465dba311
Merge pull request #52628 from ClickHouse/load-suggestion-only-with-clickhouse-dialect
Load suggestion only with `clickhouse` dialect
2023-07-28 10:21:53 +03:00
robot-clickhouse-ci-1
ac2de3c79f
Merge pull request #52643 from ClickHouse/fix-local-udf-settings
UDF: allow positional options for clickhouse-local and populate global udf settings
2023-07-28 09:21:04 +02:00
robot-ch-test-poll3
d6e2e8b92c
Merge pull request #52653 from azat/virtual-columns-or
RFC: Fix filtering by virtual columns with OR expression
2023-07-28 09:18:36 +02:00
Roman Vasin
cfa06725cc
Merge branch 'master' into ADQM-984 2023-07-28 10:15:27 +03:00
Duc Canh Le
97e63d523f use same executor for GET_PART and ATTACH_PART 2023-07-28 07:08:11 +00:00
robot-clickhouse
9fd99ce814 Automatic style fix 2023-07-28 06:34:05 +00:00
pufit
0e15f098d1 Yet another fix test 2023-07-28 02:22:44 -04:00
Alexey Gerasimchuck
b3351bb547 partially fixed 01747_system_session_log_long test 2023-07-28 03:36:23 +00:00
pufit
6573ba5378
Temporary returning metadata_cache.xml into tests config 2023-07-27 19:37:28 -04:00
ltrk2
5bd670d8c6 Improve endianness-independent support for hash functions 2023-07-27 15:58:46 -07:00
Yakov Olkhovskiy
565204f491
Merge branch 'master' into fix-nullable-ipv4-intdiv 2023-07-27 17:34:53 -04:00
chen
0c3118c9af
Merge branch 'master' into s3-url 2023-07-28 05:26:10 +08:00
Dmitry Novik
18c1fd6f08 Refactor InDepthQueryTreeVisitorWithContext 2023-07-27 21:24:39 +00:00
robot-clickhouse
7d8dc92ed0 Automatic style fix 2023-07-27 21:07:54 +00:00
Igor Nikonov
8a47ef7b5f Merge remote-tracking branch 'origin/master' into distinct-in-order-sqlancer-crashes 2023-07-27 20:54:11 +00:00
Igor Nikonov
407fb58d4b Fix style check 2023-07-27 20:53:36 +00:00
Sema Checherinda
4629ab1df1 add test with broken pipe 2023-07-28 00:24:05 +04:00
Robert Schulze
0b0ad7d45d
Merge branch 'master' into follow-up-to-50986 2023-07-27 22:08:26 +02:00
Yakov Olkhovskiy
9448d42aea
Merge pull request #51756 from ClickHouse/fix-ip-dict
Support IPv4 and IPv6 as dictionary attributes
2023-07-27 15:59:21 -04:00
Jai Jhala
dba8b445bd
Update default output_format_arrow_compression.md
Updates the default parameter of output_format_arrow_compression_method from "none" to "lz4_frame".
2023-07-27 12:32:53 -07:00
Kruglov Pavel
32d23b0904
Update aspell-dict.txt 2023-07-27 21:28:28 +02:00
Alexey Milovidov
f7d8930906
Merge pull request #52664 from ClickHouse/auto/v23.7.1.2470-stable
Update version_date.tsv and changelogs after v23.7.1.2470-stable
2023-07-27 22:14:36 +03:00
Nikolay Degterinsky
eb74e658b7 Fix build 2023-07-27 19:12:06 +00:00
Yakov Olkhovskiy
5942c80fae fix test: '--option' now is allowed after terminating '--' 2023-07-27 19:11:44 +00:00
avogar
b9c9933cc9 Fix typo 2023-07-27 18:56:23 +00:00
avogar
67b0993bdf Add documentation 2023-07-27 18:54:41 +00:00
Han Fei
4f9075e819
Merge pull request #52623 from hanfei1991/hanfei/MergeTreeDeduplicationLog
Fix stress test: check if storage shutdown before we operate MergeTreeDeduplicationLog
2023-07-27 20:50:17 +02:00
Robert Schulze
9340f02d26
Silence spell check 2023-07-27 18:33:07 +00:00
yariks5s
da53bca6e4 added tests 2023-07-27 18:29:50 +00:00
Yakov Olkhovskiy
b95745d916 fix: check positional options 2023-07-27 17:52:44 +00:00
Anton Kozlov
2717be7c47 [minor][bugfix] fix connected_zk_index column of system.zookeeper_connection table 2023-07-27 17:34:53 +00:00
Azat Khuzhin
d40dbdee62 Fix usage of temporary directories during RESTORE
Previously during RESTORE you may get the following warning in logs:

    <Warning> TemporaryFileOnDisk: Temporary path 'tmp/21672kaaaaa' does not exist in './disks/s3_common_disk/'

The reason is that it uses not disks/s3_common_disk/tmp but instead
disks/s3_common_disk/disks/s3_common_disk/tmp path.

Fix this by adding TemporaryFileOnDisk::getRelativePath() and use it
when appropriate.

And now - `find disks`, does not shows any more temporary leftovers.

v2: rename getPath to getAbsolutePath
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-27 19:24:54 +02:00
Azat Khuzhin
a8a48af7cb Fix 02417_opentelemetry_insert_on_distributed_table flakiness
Looks like everything is OK with opentelemetry, and the reason of the
flakiness is this:

    $ gg opentelemetry_start_trace_probability tests/**.xml
    tests/config/users.d/opentelemetry.xml:            <opentelemetry_start_trace_probability>0.1</opentelemetry_start_trace_probability>

So let's simply disable it.

And also let's stop the distributed sends to increase the failure rate
if there is some problem left.

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-27 19:19:24 +02:00
Smita Kulkarni
380da31512 Improvements to backup restore disallow_concurrency test 2023-07-27 19:03:44 +02:00
Dmitry Novik
9e1e005bcf Merge remote-tracking branch 'origin/master' into query-tree-visitor 2023-07-27 16:44:08 +00:00
Dmitry Novik
03f025ddd1 Fix typo 2023-07-27 16:38:02 +00:00
Vitaly Baranov
faca843ac0 Add utility to parse a backup metadata file and print information about the backup. 2023-07-27 18:25:21 +02:00
Anton Popov
dfc06d2714 fix reading of unneded column in case of multistage prewhere 2023-07-27 16:15:23 +00:00
Robert Schulze
c2ee774350
Add query cache metrics to system.asynchronous_metrics
Cf. https://github.com/ClickHouse/ClickHouse/pull/52384#issuecomment-1653241216
2023-07-27 15:19:01 +00:00
Robert Schulze
d48b1cadb0
Merge pull request #52384 from rschu1ze/query_cache_usage_in_query_log
Include query cache usage in SYSTEM.QUERY_LOG
2023-07-27 17:16:54 +02:00
Azat Khuzhin
68aed0d16e RFC: Fix filtering by virtual columns with OR expression
Virtual columns did not supports queries with OR, for example query like
this (here `m` is the `Merge` table, see the test):

    select key from m where (value = 10 and _table = 'v1') or (value = 20 and _table = 'v1');

Will always leads to:

    Cannot find column `value` in source stream, there are only columns ...

The reason for this is that it actually executes the following queries:

    SELECT key, value FROM default.d1 WHERE ((value = 10) AND ('v1' = 'v1')) OR ((value = 20) AND ('v1' = 'v1'));
    SELECT key FROM default.d2 WHERE 0;

And this kind of filtering is used not only for `Merge` table but also:
- `_table` for `Merge` (already mentioned)
- `_file` for `File`
- `_idx` for `S3`
- and as well as filtering `system.*` tables by `database`/`table`/...

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-27 16:35:17 +02:00
Azat Khuzhin
5611b2fff4 Add a note about not working _table filter for Merge with analyzer
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2023-07-27 16:35:17 +02:00
Han Fei
9488567bf6
Update src/Storages/MergeTree/MergeTreeDeduplicationLog.cpp 2023-07-27 16:28:08 +02:00
Han Fei
f6ca013c53
Update src/Storages/MergeTree/MergeTreeDeduplicationLog.cpp 2023-07-27 16:28:00 +02:00
Han Fei
0d44d527ef
Update src/Storages/MergeTree/MergeTreeDeduplicationLog.cpp
Co-authored-by: Alexander Tokmakov <tavplubix@gmail.com>
2023-07-27 16:27:04 +02:00
Nikolay Degterinsky
ee9bad7a31 Fix style 2023-07-27 14:18:46 +00:00
Nikolay Degterinsky
b5160c8072 Fix bugs and better test for SYSTEM STOP LISTEN 2023-07-27 14:16:19 +00:00
Han Fei
f5dfb70f5c
Update src/Storages/MergeTree/MergeTreeDeduplicationLog.cpp 2023-07-27 16:12:20 +02:00
Han Fei
ce38d3c5ea address comment 2023-07-27 16:11:08 +02:00