Commit Graph

13659 Commits

Author SHA1 Message Date
chertus
a95e0015dc fix build and tests 2019-06-07 21:11:50 +03:00
proller
516ce69d70 CLICKHOUSE-4179 Fix of function arrayEnumerateUniqRanked for arguments with empty arrays 2019-06-07 20:37:01 +03:00
chertus
3007975199 T64 codec concept 2019-06-07 19:12:45 +03:00
alesapin
53e62b83d2 Fix complex bug in deduplication 2019-06-06 18:28:02 +03:00
Zhichang Yu
8a26060ca8 fix style 2019-06-06 08:34:34 +08:00
alesapin
a0e7d183f7
Merge pull request #5534 from yandex/debug_dns_cache
Fix bug in pooled sessions and host ip change
2019-06-05 22:37:17 +03:00
alexey-milovidov
42dbb7e881
Merge pull request #5539 from yandex/alter-ttl-fix
Fixed alter modify ttl on ReplicatedMergeTree.
2019-06-05 22:05:17 +03:00
CurtizJ
27d8b90dd9 fixed alter modify ttl on ReplicatedMergeTree and test added 2019-06-05 19:22:41 +03:00
Orivej Desh
5ec179377a DEVTOOLS-5170 Delete Y_IGNORE markers (#5533)
They have been superseded by a new include resolution configuration that lives
outside clickhouse source tree.
2019-06-05 14:52:39 +03:00
alesapin
07ee60b546 Fix bug with pooled HTTP sessions and host ip change 2019-06-05 12:23:41 +03:00
Zhichang Yu
b694d039c1 added FunctionBitmapContains 2019-06-05 16:25:48 +08:00
alexey-milovidov
4ca476ec80
Merge pull request #5516 from yandex/fix-regression-models
Fix regression models
2019-06-05 08:07:18 +03:00
alexey-milovidov
b7248803d5
Merge pull request #5524 from NanoBjorn/fix-drop-index-if-exists
Fixed DROP INDEX IF EXISTS and added simple test
2019-06-05 08:04:04 +03:00
alexey-milovidov
59a59c34c6
Update FunctionsBitmap.h 2019-06-05 08:03:09 +03:00
Zhichang Yu
0e3f2d5faa added comments for bitmapHasAll and bitmapHasAny 2019-06-05 11:26:13 +08:00
Gleb Novikov
29a26af156 Merge branch 'master' into fix-drop-index-if-exists 2019-06-04 11:32:22 +03:00
Zhichang Yu
6d0e7b7b21 fix https://github.com/yandex/ClickHouse/issues/5479 2019-06-04 14:10:51 +08:00
alexey-milovidov
e389df385c
Merge pull request #5523 from orivej/croaring
DEVTOOLS-5507 Include roaring.h as roaring/roaring.h
2019-06-04 03:58:22 +03:00
Gleb Novikov
8bd2c7b3a7 Fixed DROP INDEX IF EXISTS and added simple test 2019-06-04 00:08:52 +03:00
Anton Yuzhaninov
091b591681 Fix build without Brotli (#5513) (#5521) 2019-06-03 23:27:53 +03:00
alesapin
db6de83fa1
Merge pull request #5520 from yandex/fix_inconsistent_parts_removing
Fix inconsistent parts remove from local FS without dropping them from ZK
2019-06-03 21:18:16 +03:00
Георгий Кондратьев
2499cefdb9 DEVTOOLS-5507 Include roaring.h as roaring/roaring.h
This is needed to unbundle roaring. Its original cmake build system installs:

     /usr/include/roaring/roaring.h
     /usr/include/roaring/roaring.hh

and declares:

     set_target_properties(roaring::roaring PROPERTIES
       INTERFACE_INCLUDE_DIRECTORIES "/usr/include"
     )
2019-06-03 17:03:41 +00:00
Ivan
f70eed78d8
Don't do intermediate commits in Kafka tables by default (#5445)
* Don't do intermediate commits in Kafka tables by default
* Use default settings' values as defaults in code
2019-06-03 19:40:22 +03:00
alesapin
dfe214b37c Fix inconsistent parts remove from local FS without dropping them from ZK 2019-06-03 17:58:19 +03:00
Nikolai Kochetov
7cb3e3b251 Set default learnng_rate to 0.01. 2019-06-03 08:50:07 +03:00
Nikolai Kochetov
47f82dac72 Fix build. 2019-06-03 08:31:04 +03:00
Nikolai Kochetov
d224d3dcd2 Fix build. 2019-06-03 08:25:48 +03:00
Nikolai Kochetov
1034295f04 Fixed UInt32 overflow bug in linear models. Allow eval ML model for non-const model argument. 2019-06-03 08:11:15 +03:00
Konstantin Podshumok
633f2f2664 limit remote timeouts to max_execution_time for SelectStreamFactory 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
e60a2fd1ad clickhouse dictionary source: fix timeouts for remotes 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
d52be42c37 use new timeouts in ClusterProxy 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
bebd19135a remove connections_with_failover_max_tries and getSaturated(settings.max_execution_time) from Cluster 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
9e7387182a StorageReplicatedMergeTree: move timeouts to RemoteBlockInputStream 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
a61a8386f3 update timeouts usage in DistributedBlockOutputStream 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
b801fcb79a fix timeouts usage in directory monitor 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
f993ea6127 add timeouts to remote streams 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
a3d2310d6f add timeouts to multiplexed connections 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
eb31345224 add timeouts to ConnectionPoolWithFailover and use max_tries from settings 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
d18fd5f10b timeouts from ConnectionPool members as they are intended to live longer than timeouts state 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
6836bf6733 connection: make sure connection timeouts are applied during sendQuery 2019-06-02 12:43:20 +03:00
Konstantin Podshumok
94b2bf5551 move timeouts from members to parameters in Connection
maybe it is better to provide some `set_timeouts` method?
2019-06-02 12:43:20 +03:00
alexey-milovidov
005217c9d9
Merge pull request #5492 from Quid37/master
Some changes and fixes on regression methods
2019-06-02 06:31:22 +03:00
alexey-milovidov
086572b604
Merge pull request #5503 from 4ertus2/bugs
Fix union all supertype column
2019-06-02 06:18:33 +03:00
Alexander Kozhikhov
ba3d6c4b6c unique 2019-06-02 01:46:25 +03:00
Danila Kutenin
b5f42d36fa
Merge pull request #5498 from yandex/gcc9-warnings
Fix gcc9 warnings and ICEs
2019-06-01 15:12:41 +03:00
Vitaly Baranov
a4ce427bfa
Merge pull request #5429 from azat-archive/INSERT-into-Distributed-with-MATERIALIZED
Fix INSERT into Distributed() table with MATERIALIZED column
2019-06-01 12:28:45 +03:00
Vitaly Baranov
421c6a90e2
Use function getSampleBlockNonMaterialized() to simplify the solution 2019-05-31 21:31:09 +03:00
Alexander Kozhikhov
da8d49a67a shared to unique 2019-05-31 18:53:31 +03:00
Alexander Kozhikhov
73c07cb9d5 fix on lin_ref_perf 2019-05-31 18:39:17 +03:00
alesapin
117c9edda7
Merge pull request #5489 from azat-archive/DDLWorker-fix
Skip ZNONODE during DDL query processing
2019-05-31 18:34:47 +03:00
chertus
40b5375aa8 fix const optimisation 2019-05-31 16:34:09 +03:00
chertus
28c1a60eb7 fix union all supertype column 2019-05-31 15:36:44 +03:00
Danila Kutenin
7e2b3b59b8 Fix gcc9 warnings and ICE's 2019-05-31 11:55:01 +03:00
alexey-milovidov
4819a34394
Merge pull request #5448 from yandex/low-cardinality
Add setting suspicious type for low cardinality (fixed #4965)
2019-05-31 07:35:19 +03:00
proller
1b0d1a4450 Info about frozen parts in system.parts (#5471)
* wip

*    wip

* wip

* Clean

* fix test

* clean

* fix test

* fix test
2019-05-31 07:03:46 +03:00
alexey-milovidov
261dd5668e
Merge pull request #5477 from yandex/fix-linking-with-lld
Fixed linking with lld
2019-05-31 07:00:55 +03:00
Alexander Kozhikhov
42f3ee2e2b conflict 2019-05-31 01:55:18 +03:00
Alexander Kozhikhov
0f222640d5 style 2019-05-31 01:53:56 +03:00
Alexander Kozhikhov
15fe367f83 few fixes 2019-05-31 01:48:44 +03:00
Alexander Kozhikhov
ef23528452 some changes and fixes on regression methods 2019-05-31 00:59:40 +03:00
Azat Khuzhin
eb5f46fb07
Skip ZNONODE during DDL query processing
Right now if another node removes the znode in task_queue, the one that
did not process it, but already get list of children, will terminated
the DDLWorker thread, and this is very unconvinient because you do not
have any sane way to know is DDLWorker still running or not (except for
timed out DDL queries or via debugger), and the clickhouse-server it
self do not fail either.

Fixes: #5064
2019-05-30 20:25:29 +03:00
Olga Khvostikova
2fc3ce7f5d
Merge branch 'master' into low-cardinality 2019-05-30 16:31:40 +03:00
proller
a813a001e2
Allow to use internal compiler with system includes (fix compile for freebsd) (#5447)
* Allow to use internal compiler with system includes (fix compile for freebsd)
* Fix macos build
2019-05-30 15:58:15 +03:00
Alexey Milovidov
05737678e2 Remove debug logging from MySQL protocol 2019-05-30 11:25:16 +03:00
Alexey Milovidov
1607ec49ba Fixed linking with lld 2019-05-30 11:23:20 +03:00
stavrolia
60459bbb87 Yet another fix 2019-05-29 20:49:35 +03:00
stavrolia
605de8c36c Fixed 2019-05-29 17:59:11 +03:00
chertus
3f2e09ac93 Merge branch 'master' into decimal 2019-05-29 13:58:33 +03:00
Nikolai Kochetov
713ccd1f60 Added comment for IAggregateFunction::getReturnTypeToPredict(). Small code fixes. 2019-05-29 06:42:33 +03:00
Nikolai Kochetov
1c8b7dc96d
Merge pull request #5411 from Quid37/master
small changes on linear regression
2019-05-29 06:31:51 +03:00
zhang2014
80788cd7a8 Rename system sync distributed to system flush distributed 2019-05-29 10:43:52 +08:00
zhang2014
1a33840964 fix review 2019-05-29 10:43:52 +08:00
zhang2014
c44f608868 support replicas system queries for distributed 2019-05-29 10:43:52 +08:00
chertus
49e12eaa60 remove unused specializations in dictionaries 2019-05-28 22:30:01 +03:00
stavrolia
3edf296aa3 Change error message 2019-05-28 22:09:40 +03:00
stavrolia
0a5fb04b56 One more fixed 2019-05-28 21:32:14 +03:00
stavrolia
aa0e227288 Fixed 2019-05-28 21:08:47 +03:00
alexey-milovidov
c5d18dfde1
Merge pull request #5446 from 4ertus2/some
Disable implicit type conversions in dictGet functions (it's not working)
2019-05-28 20:34:13 +03:00
alexey-milovidov
5adef8bc56
Merge pull request #5437 from TCeason/bug_fix
ISSUES-5432 fix bad alloc when truncate join storage
2019-05-28 20:33:14 +03:00
stavrolia
976815660f Fix improvement of check 2019-05-28 20:28:17 +03:00
alexey-milovidov
829102671f
Merge pull request #5440 from azat-archive/hashed-dictionary-element_count
Fix element_count for hashed dictionary (do not include duplicates)
2019-05-28 20:21:40 +03:00
stavrolia
a91e72eb39 Improve check 2019-05-28 19:45:27 +03:00
stavrolia
4cd595b450 Add setting allow suspicious types for low cardinality with long message about error (fixed #4965) 2019-05-28 19:10:55 +03:00
chertus
0d77a96b3c disable implicit type conversions in dictGet functions 2019-05-28 17:04:00 +03:00
Azat Khuzhin
0275d62523
Fix element_count for hashed dictionary (do not include duplicates) 2019-05-28 11:25:31 +03:00
tai
1ab21e5774 ISSUES-5432 fix bad alloc when truncate join storage 2019-05-28 14:23:07 +08:00
alexey-milovidov
0c2aa46065
Merge pull request #5416 from vitlibar/fix-clickhouse-as-mysql-server
Fix clickhouse as mysql server
2019-05-28 06:13:31 +03:00
Vitaly Baranov
1364cdd057 Fix ErrorCodes. 2019-05-28 03:08:12 +03:00
Vitaly Baranov
63b319404b Fix handling mixed const/non-const cases. 2019-05-28 02:47:33 +03:00
Azat Khuzhin
e527def18a
Fix INSERT into Distributed() table with MATERIALIZED column
By just skipping MATERIALIZED columns during processing.

P.S. you cannot use insert_allow_materialized_columns since it works
only for Buffer() engine.

Fixes: #4015
Fixes: #3673
Fixes: 01501fa8db ("correct column list
for rewritten INSERT query into Distributed [#CLICKHOUSE-4161]")
2019-05-27 23:32:05 +03:00
Alexander Kozhikhov
b9c68cbf3a changes on return type of linearRegression 2019-05-27 23:18:14 +03:00
Alexander Kozhikhov
5cd85baec6 changes on return type of linearRegression 2019-05-27 23:14:23 +03:00
Danila Kutenin
b579c98651
Merge pull request #5422 from yandex/ngram_non_symmetric
ngramEntry renamed to ngramSearch
2019-05-27 12:50:08 +03:00
Danila Kutenin
b65a9499c8 ngramEntry renamed to ngramSearch 2019-05-27 12:05:02 +03:00
alexey-milovidov
ead911efc2
Merge pull request #5419 from yurriy/mysql
Improvements of MySQL Wire Protocol
2019-05-27 04:59:23 +03:00
Yuriy
96c2bb383f using logging level from config.xml 2019-05-26 22:30:23 +03:00
Sergi Vladykin
8c7b6137bc Code style fixed. 2019-05-26 13:02:48 +03:00
Sergi Vladykin
2be4721771 Merge branch 'master' of https://github.com/yandex/ClickHouse into bitmap1 2019-05-26 12:27:54 +03:00
Danila Kutenin
61a1d91d71
Merge pull request #5418 from yandex/ngram_non_symmetric
ngramEntry function was added
2019-05-26 11:02:48 +03:00
Yuriy
96e3574a06 Improvements of MySQL Wire Protocol 2019-05-26 09:52:29 +03:00
Danila Kutenin
6090f5eca8 ngramEntry function was added 2019-05-25 21:47:26 +03:00
Alexander Kozhikhov
dd259c408d Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-25 21:42:16 +03:00
Alexander Kozhikhov
0be0529b59 changes on lin reg 2019-05-25 21:41:58 +03:00
alexey-milovidov
461c4919d3
Merge pull request #5116 from PerformanceVision/send_header
Send a X-ClickHouse summary on the header for HTTP client with number of rows inserted
2019-05-25 20:20:35 +03:00
Alexey Milovidov
207d2048c6 Added forward declarations 2019-05-25 17:15:22 +03:00
Alexey Milovidov
b94f2be154 Merge branch 'mysql' of https://github.com/yurriy/ClickHouse into yurriy-mysql 2019-05-25 17:14:57 +03:00
alexey-milovidov
6bb468b8c9
Merge pull request #5200 from hczhcz/patch-5
Add statistics functions: skewSamp, skewPop, kurtSamp, and kurtPop
2019-05-25 17:06:13 +03:00
alexey-milovidov
65957974b4
Update AggregateFunctionStatisticsSimple.h 2019-05-25 17:04:26 +03:00
Alexander Kozhikhov
7b235a312b Merge branch 'master' of https://github.com/yandex/ClickHouse 2019-05-25 16:33:36 +03:00
alexey-milovidov
e0e35f3258
Merge pull request #5246 from nikvas0/nikvas0/fix_minmax_null
[wip] fix null minmax
2019-05-25 16:11:23 +03:00
alexey-milovidov
81ed764d6a
Merge pull request #5285 from abyss7/issue-5085
Don't crash the server when Kafka consumers have failed to start
2019-05-25 16:09:26 +03:00
alexey-milovidov
cb89e506a4
Merge pull request #5353 from yandex/aku/detached-parts-5164
Add system.detached_parts table.
2019-05-25 16:08:33 +03:00
alexey-milovidov
980c564db6
Merge pull request #5339 from sundy-li/feature/sequence64
Make sequenceMatch aggregate functions support other unsigned Integer types
2019-05-25 15:59:36 +03:00
alexey-milovidov
0c38226a25
Merge pull request #5366 from abyss7/storage-merge-sample
Check that underlying tables support sampling for StorageMerge
2019-05-25 15:44:02 +03:00
alexey-milovidov
fbbe3c1246
Merge pull request #5359 from andyyzh/fix_bitmap_issue_5244
Fixed bitmap functions produce wrong result
2019-05-25 15:43:38 +03:00
alexey-milovidov
bffe621d94
Merge pull request #5407 from kvap/all-columns-required-in-limit-by
Mark all input columns in LIMIT BY as required output
2019-05-25 15:13:01 +03:00
alexey-milovidov
b79582e15a
Merge pull request #5395 from clemrodriguez/master
Close MySQL connections opened by external MySQL dictionaries
2019-05-25 14:13:51 +03:00
alexey-milovidov
9e24c8d19a
Merge pull request #5396 from 4ertus2/ast
Support IN in CrossToInnerJoin push down predicates
2019-05-25 14:07:45 +03:00
alexey-milovidov
661d661d57
Update CrossToInnerJoinVisitor.cpp 2019-05-25 14:05:12 +03:00
proller
6c1cb02172 CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT (#5397)
* CLICKHOUSE-4523 Fix "Column '0' already exists" in SELECT .. PREWHERE on column with DEFAULT

* fix style

* Fix build

* Update iostream_debug_helpers.cpp

* Update evaluateMissingDefaults.cpp
2019-05-25 14:03:12 +03:00
alexey-milovidov
1d98441c34
Update ExpressionAnalyzer.cpp 2019-05-25 13:51:48 +03:00
Alexander Kozhikhov
464083803b redundant include 2019-05-25 12:44:11 +03:00
Alexander Kozhikhov
a63ad11ee7 LinearRegression without -State modifier now simply returns its weights 2019-05-25 02:18:44 +03:00
Clément Rodriguez
8e8a563e30 Code style fixes 2019-05-24 14:30:12 +02:00
chertus
9eca696e82 actualize isNumber for Decimal 2019-05-24 15:11:03 +03:00
alexey-milovidov
9d7754e332
Merge pull request #5391 from yandex/rename-regression-methods
Rename regression methods.
2019-05-24 13:01:50 +03:00
Constantin S. Pan
cbc0f56af1 Mark all input columns in LIMIT BY as required output
The query analyzer only marks the actual arguments of LIMIT BY as required
output for the LimitBy step in the pipeline. This is fine, unless the query is
distributed, in which case the first stage might remove a column that is used
at the second stage (e.g. for ORDER BY) but is not part of the final select.

Prevent removal of any columns in LimitBy by marking all input columns as
required output.
2019-05-24 09:53:09 +01:00
alexey-milovidov
f54b01fad8
Merge pull request #5393 from abyss7/fix-blockio
Fix order of destruction inside BlockIO
2019-05-23 21:49:40 +03:00
chertus
333c9aeecc support IN in CrossToInnerJoin push down 2019-05-23 19:01:17 +03:00
alesapin
15e31d5a8c
Merge pull request #5392 from yandex/insert_data_to_null_columns
Add ability to insert data in column nullable
2019-05-23 17:38:01 +03:00
chertus
f82ea1c1d5 dictGet() dictGetOrDefault for Decimals 2019-05-23 17:04:33 +03:00
Clément Rodriguez
c4c99c80a1 Make the connection closure parameterized in dictionary.xml 2019-05-23 15:55:00 +02:00
Ivan Lezhankin
646d6f3fb5 Fix order of destruction 2019-05-23 16:54:11 +03:00
alesapin
d860b3912b Insert data in column nullable 2019-05-23 16:35:26 +03:00
Clément Rodriguez
7b40d37212 Close MySQL connections after usage in MySQLDictionarySource 2019-05-23 15:09:07 +02:00
Nikolai Kochetov
54a52853e8 Remane regression methods. 2019-05-23 14:51:25 +03:00
sundy-li
ad539464b0 add empty judge 2019-05-22 14:11:27 +08:00
proller
f5933dd40c
Update tldLookup.h 2019-05-21 18:42:45 +03:00
proller
551897cea8
Update firstSignificantSubdomain.h 2019-05-21 18:41:47 +03:00
proller
6cb4485473
Rename aggregate functions TSgroup* to timeSeriesGroup* (#5307) 2019-05-21 18:33:54 +03:00
Alexander Kuzmenkov
6472040c6c Initialize StoragesInfo fields. 2019-05-21 16:58:55 +03:00
Ivan Lezhankin
28bddf9a4a [StorageMerge] check that underlying tables support sampling 2019-05-21 16:04:34 +03:00
Alexander Kuzmenkov
43655a8db7 Add system.detached_parts table.
https://github.com/yandex/ClickHouse/issues/5164
2019-05-21 15:06:36 +03:00
hcz
ba527dac20
Update AggregateFunctionStatisticsSimple.h 2019-05-21 16:17:12 +08:00
hcz
f7bad8c87b
Fix NaN 2019-05-21 16:10:49 +08:00
Danila Kutenin
3536184ba8
Merge pull request #5357 from yandex/concat_optimization
Optimize concat function with recent format function.
2019-05-21 08:11:35 +03:00
Guillaume Tassery
938d6d7f24 coding style 2019-05-21 11:06:36 +07:00
Andy Yang
a62f7e2fea Fixed bitmap functions produce wrong result 2019-05-21 10:58:38 +08:00
sundy-li
afcd60a0a4 add NO_SANITIZE_UNDEFINED 2019-05-21 10:16:46 +08:00
sundy-li
b55bf7cf83 whitespaces 2019-05-21 09:56:48 +08:00
alexey-milovidov
418a86f338
Merge pull request #5355 from yandex/checksum-mismatch-more-verbose-error-message
Better error message on checksum mismatch #5347
2019-05-21 01:46:52 +03:00
Danila Kutenin
cf014b704a Check for number of arguments 2019-05-21 00:12:25 +03:00
Danila Kutenin
daaebf5ab0 optimized concat function with format, make format a bit more generic 2019-05-21 00:06:43 +03:00
Alexey Milovidov
4b604e4656 Better error message on checksum mismatch #5347 2019-05-20 23:46:52 +03:00
Alexey Milovidov
da142a5d5d Better error message on checksum mismatch #5347 2019-05-20 23:35:43 +03:00
chertus
187311add0 add decimal to decimal convertion in IN 2019-05-20 18:51:54 +03:00
Guillaume Tassery
77b7158cd8 Progress rename for total_rows and write_[rows|bytes] 2019-05-20 18:37:41 +07:00
sundy-li
66c60c2985 better tests 2019-05-20 12:31:52 +08:00
sundy-li
6843254ce4 Make sequenceMatch support other unsigned integer types 2019-05-20 12:02:54 +08:00
alexey-milovidov
02937294ce
Merge pull request #5311 from azat-archive/SimpleAggregateFunction-Arena-fix
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
2019-05-19 13:12:38 +03:00
Danila Kutenin
295a4a8684
Merge pull request #5330 from yandex/format_function
Format function added
2019-05-19 12:07:57 +03:00
Danila Kutenin
ed588bf727 style 2019-05-19 03:39:44 +03:00
Azat Khuzhin
db274bf516
Allocates arena for SimpleAggregateFunction only if IAggregateFunction requires 2019-05-19 03:33:04 +03:00
Azat Khuzhin
2f471d6ea3
Set allocatesMemoryInArena for SingleValueDataString to true
This includes next aggregate functions for String() type:
- *min*
- *max*
- *any*
2019-05-19 03:33:04 +03:00
Azat Khuzhin
4e8370b0b0
Fix SimpleAggregateFunction for String longer MAX_SMALL_STRING_SIZE
SimpleAggregateFunction do not pass arena to the
add_function -> getAddressOfAddFunction(), hence next crash happens:
  (gdb) bt
  #0  DB::Arena::alloc (size=64, this=0x0) at ../dbms/src/Common/Arena.h:124
  #1  DB::SingleValueDataString::changeImpl (this=0x7f97424a27d8, value=..., arena=0x0) at ../dbms/src/AggregateFunctions/AggregateFunctionMinMaxAny.h:274
  #2  0x0000000005ea5319 in DB::AggregateFunctionNullUnary<true>::add (arena=<optimized out>, row_num=<optimized out>, columns=<optimized out>, place=<optimized out>, this=<optimized out>) at ../dbms/src/AggregateFunctions/AggregateFunctionNull.h:43
  #3  DB::IAggregateFunctionHelper<DB::AggregateFunctionNullUnary<true> >::addFree (that=<optimized out>, place=<optimized out>, columns=<optimized out>, row_num=<optimized out>, arena=<optimized out>) at ../dbms/src/AggregateFunctions/IAggregateFunction.h:131
  #4  0x000000000679772f in DB::AggregatingSortedBlockInputStream::addRow (this=this@entry=0x7f982de19c00, cursor=...) at ../dbms/src/Common/AlignedBuffer.h:31
  #5  0x0000000006797faa in DB::AggregatingSortedBlockInputStream::merge (this=this@entry=0x7f982de19c00, merged_columns=..., queue=...) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:140
  #6  0x0000000006798979 in DB::AggregatingSortedBlockInputStream::readImpl (this=0x7f982de19c00) at ../dbms/src/DataStreams/AggregatingSortedBlockInputStream.cpp:78
  #7  0x000000000622db55 in DB::IBlockInputStream::read (this=0x7f982de19c00) at ../dbms/src/DataStreams/IBlockInputStream.cpp:56
  #8  0x0000000006613bee in DB::MergeTreeDataMergerMutator::mergePartsToTemporaryPart (this=this@entry=0x7f97ec65e1a0, future_part=..., merge_entry=..., time_of_merge=<optimized out>, disk_reservation=<optimized out>, deduplicate=<optimized out>) at /usr/include/c++/8/bits/shared_ptr_base.h:1018
  #9  0x000000000658f7a4 in DB::StorageReplicatedMergeTree::tryExecuteMerge (this=0x7f97ec65b810, entry=...) at /usr/include/c++/8/bits/unique_ptr.h:342
  #10 0x00000000065940ab in DB::StorageReplicatedMergeTree::executeLogEntry (this=0x7f97ec65b810, entry=...) at ../dbms/src/Storages/StorageReplicatedMergeTree.cpp:910
  <snip>

  (gdb) f 1
  (gdb) p MAX_SMALL_STRING_SIZE
  $1 = 48
  (gdb) p capacity
  $2 = 64
  (gdb) p value
  $3 = {data = 0x7f97242fcbd0 "HHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH", size = 61}

v2: avoid leaking of allocated by Arena memory on the intermediate step

Fixes: 8f8d2c048e ("Merge pull request #4629 from bgranvea/simple_aggregate_function")
2019-05-19 03:32:55 +03:00
alexey-milovidov
2254b171a7
Merge pull request #5313 from yandex/fix-external-query-in-with-single-element
Fix external queries with IN operator.
2019-05-19 03:12:57 +03:00
Danila Kutenin
876b5c3bbb style 2019-05-19 02:21:29 +03:00
Alexey Milovidov
648d2bdb25 Fixed test 2019-05-19 01:19:24 +03:00
alexey-milovidov
e73fc1bd0f
Merge pull request #5320 from sundy-li/feature/funnel64
Make windowFunnel support other Unsigned Integer Types
2019-05-18 23:47:12 +03:00
Danila Kutenin
fca6e4fd38 constant string handling 2019-05-18 18:09:52 +03:00
Danila Kutenin
95cd3e5bb8 style 2019-05-18 16:38:03 +03:00
Danila Kutenin
1c6707526a style 2019-05-18 16:21:48 +03:00
Danila Kutenin
59f26b7569 some optimizations 2019-05-18 15:56:26 +03:00
Danila Kutenin
a49ee5efd6 some optimizations 2019-05-18 15:52:33 +03:00
Danila Kutenin
84b04dc8ea format function added 2019-05-18 15:29:10 +03:00
Danila Kutenin
4e3a607267 format function added 2019-05-18 14:30:36 +03:00
alexey-milovidov
24b16da9fd
Merge pull request #5235 from vitlibar/improve-new-json-functions
Improve new json functions
2019-05-18 12:51:41 +03:00
alexey-milovidov
c2132880f6
Update WriteBufferFromVector.h 2019-05-18 12:43:43 +03:00
alexey-milovidov
7985ad10ef
Update IStorage.h 2019-05-18 12:31:51 +03:00
sundy-li
dcfdc09003 fix style 2019-05-18 09:34:55 +08:00
alexey-milovidov
fa4a7eb3d1
Merge branch 'master' into merge-itable-istorage 2019-05-18 00:37:12 +03:00
alexey-milovidov
8bf48de9c9
Merge pull request #5308 from abyss7/issue-5100
Add setting to regulate Kafka committing policy
2019-05-18 00:27:19 +03:00
alexey-milovidov
8b9b305a5f
Merge pull request #5325 from abyss7/issue-5286
Allow to shadow virtual column '_table' in Merge engine
2019-05-18 00:17:34 +03:00
alexey-milovidov
34f36e2891
Merge pull request #5304 from 4ertus2/funcs
Support quantile(s) and median for Decimal
2019-05-17 23:03:27 +03:00
Danila Kutenin
e0b90de474
Merge pull request #5322 from yandex/to_valid_utf8
toValidUTF8 function added
2019-05-17 22:48:32 +03:00
Ivan Lezhankin
dcff73c8d4 Fix build 2019-05-17 21:45:42 +03:00
Ivan Lezhankin
7b6c78402d Allow to shadow virtual column '_table' in Merge engine 2019-05-17 20:40:51 +03:00
Ivan Lezhankin
7f762aee88 Move some code from header to source file. 2019-05-17 17:48:03 +03:00
Ivan Lezhankin
0821d62516 Merge ITableDeclaration into IStorage.
Also a couple of massive include-refactorings with better forwarding
2019-05-17 17:34:25 +03:00
Vitaly Baranov
095fc7b454 Optimization by using implementation-specific JSONParser::sizeOfArray(), JSONParser::sizeOfObject(). 2019-05-17 17:24:13 +03:00
Danila Kutenin
64913c4778 better names 2019-05-17 16:00:29 +03:00
Yuriy
4a14eac00b fixed memory leak and changed logging levels 2019-05-17 16:00:09 +03:00
Danila Kutenin
0d3422fa8a toValidUTF8 function added 2019-05-17 15:55:21 +03:00
sundy-li
cbaca96926 remove spaces 2019-05-17 19:41:18 +08:00
sundy-li
4c95b9d007 modify createAggregateFunctionWindowFunnel 2019-05-17 19:31:29 +08:00
sundy-li
d3c4c1c255 modify createAggregateFunctionWindowFunnel 2019-05-17 19:30:09 +08:00
sundy-li
760bc5708d support unsigned integer type in windowFunnel Aggregate function 2019-05-17 19:17:52 +08:00
Artem Zuikov
4eee10d788
Merge pull request #5271 from 4ertus2/some
Cache ExpressionBlockInputStream header
2019-05-17 13:14:22 +03:00
alexey-milovidov
1707cd79c8
Merge pull request #5297 from github1youlc/xid_equal_to_close_xid_deadlock_fix
fix deadlock when xid equal to close_xid
2019-05-17 11:45:35 +03:00
Alexey Milovidov
09073e1229 More tests 2019-05-17 01:55:29 +03:00