Commit Graph

15380 Commits

Author SHA1 Message Date
Maksim Kita
c73d53dda4
Merge pull request #26094 from zxc111/issue-9390
hex/bin functions support AggregateFunction states.
2021-07-09 16:41:07 +03:00
alesapin
60b22aaac8 Better message 2021-07-09 16:03:23 +03:00
alesapin
b2fb551bd4 Fix several bugs in ZooKeeper snapshots deserialization 2021-07-09 16:00:50 +03:00
zxc111
0ec402ff64 castColumn instead of execute toString function 2021-07-09 18:35:26 +08:00
Maksim Kita
581e79ced9
Merge pull request #26114 from ClickHouse/dargejs-compatibility
Make graph pipeline rendering compatible with Dagre.JS
2021-07-09 12:17:33 +03:00
vdimir
95f8ca4e03
Do not use default impl for low cardinality for joinGet 2021-07-09 12:16:03 +03:00
Vladimir
bf0695ff84
Merge pull request #25589 from TszKitLo40/support-distinct-on 2021-07-09 09:50:45 +03:00
alexey-milovidov
b7ca78f219
Merge pull request #26087 from ianton-ru/directory_iterator_path_exception
Fix throwing exception when iterate over non existing remote directory
2021-07-09 06:52:54 +03:00
alexey-milovidov
0bad945392
Update PolygonUtils.h 2021-07-09 06:49:08 +03:00
Vitaly Baranov
3fb0567887
Merge pull request #26075 from vitlibar/pad-functions
Pad functions
2021-07-09 06:46:23 +03:00
Alexey Milovidov
b264c3f192 Make graph pipeline rendering compatible with Dagre.JS 2021-07-09 06:26:35 +03:00
alexey-milovidov
eafce775c9
Merge pull request #25452 from amosbird/jsonextractrawstring
JSONExtract String or Raw
2021-07-09 06:17:13 +03:00
alexey-milovidov
09c20d5d08
Update geoToH3.cpp 2021-07-09 06:15:53 +03:00
mergify[bot]
5814742656
Merge branch 'master' into update-h3 2021-07-09 03:13:19 +00:00
Alexey Milovidov
9290d6f112 Fix UBSan report in pointInPolygon 2021-07-09 06:06:21 +03:00
mergify[bot]
bbde9e2efd
Merge branch 'master' into dev-map-bug 2021-07-09 02:52:53 +00:00
alexey-milovidov
7c17e2526d
Merge pull request #25634 from vdimir/join-materialized-columns
Support materialized and aliased columns in joins
2021-07-09 03:18:49 +03:00
alexey-milovidov
c98e131a81
Merge pull request #26072 from vdimir/fix-offset-check-in-window-frame
Fix logical error with signed and unsigned offset in WindowFrame::checkValid
2021-07-09 03:06:15 +03:00
Vitaly Baranov
3dfdcf4604 Improve implementation of leftPadString(), rename to leftPad(). Add new functions rightPad(), leftPadUTF8(), rightPadUTF8(). Add a test. 2021-07-08 23:39:29 +03:00
alesapin
c34a769143
Merge pull request #26079 from ClickHouse/fix_abort
Fix abort in ZooKeeper client
2021-07-08 22:58:28 +03:00
Anton Popov
81a200e349
Merge pull request #26077 from CurtizJ/cleanup-code
Remove unused code
2021-07-08 20:50:57 +03:00
zxc111
e4b1e0619c hex/bin functions support AggregateFunction states. 2021-07-09 00:41:44 +08:00
Anton Ivashkin
ac68d5ea71 Fix path concatenation 2021-07-08 18:39:41 +03:00
Anton Ivashkin
88bc3995e0 Fix throwing exception when iterate over non existing remote directory 2021-07-08 17:54:59 +03:00
alexey-milovidov
9c2aad6c17
Merge pull request #25962 from ClickHouse/network-instrumentation
More instrumentation for network interaction: add counters for recv/send bytes; add gauges for recvs/sends.
2021-07-08 17:20:16 +03:00
alexey-milovidov
f068defdd8
Merge pull request #26052 from vdimir/fix-join-max-parallel-streams
Fix max parallel streams for joined pipelines
2021-07-08 17:18:12 +03:00
alesapin
e621fb644d Fix abort in ZooKeeper client 2021-07-08 16:57:55 +03:00
Anton Popov
9f1ffa777f remove unused code 2021-07-08 15:06:33 +03:00
vdimir
d4256a8583
Minor style changes in JoinedTables 2021-07-08 13:49:13 +03:00
vdimir
5d7fc61bd5
Merge branch 'master' into join-materialized-columns 2021-07-08 12:30:00 +03:00
vdimir
2304f6a31b
Remove dots from exception message in WindowDescription.cpp 2021-07-08 12:24:37 +03:00
vdimir
71d0682a2b
Use FieldVisitor to compare offsets in WindowFrame::checkValid 2021-07-08 12:24:08 +03:00
vdimir
39de7f8a2a
Fix logical error with signed and unsinged offset in WindowFrame::checkValid 2021-07-08 11:16:57 +03:00
Alexey Milovidov
ee1b3696a2 Fix error in AsynchronousMetrics 2021-07-08 06:15:30 +03:00
Maksim Kita
39c5ba40f7
Merge pull request #26055 from kitaisreal/clickhouse-dictionary-source-secure-setting-added-documentation
ClickHouse dictionary source secure setting added documentation
2021-07-07 23:49:42 +03:00
Anton Popov
e89f701c58
Merge pull request #26048 from CurtizJ/fix-map-type-json
Proper fix of serialization of type Map to JSON
2021-07-07 23:20:39 +03:00
Maksim Kita
9d0c2f83f8 ClickHouse dictionary source secure setting added documentation 2021-07-07 22:14:30 +03:00
vdimir
9b09f215c4
Fix max parallel stream for joined pipeline 2021-07-07 20:44:30 +03:00
Anton Popov
31e0e5cec7 pass buffers explicitly 2021-07-07 16:22:15 +03:00
Anton Popov
a24686d300 fix serialization of type Map to JSON 2021-07-07 15:04:07 +03:00
alesapin
e231f6ce5c
Merge pull request #26034 from nvartolomei/nv/zk-watch-metric-drift
Fix for ZK watch metric drift in rare conditions
2021-07-07 14:26:34 +03:00
Vladimir
35ca8b97ac
Set distinct_on_expression_list to null white transforming to limit_by 2021-07-07 12:48:39 +03:00
Raúl Marín
d87607b160 AsynchronousMetrics: Don't assume temperature is always positive 2021-07-07 11:09:38 +02:00
alesapin
4c85dae572
Merge pull request #25743 from ClickHouse/fix_aggregation_ttl
Fix bug in execution of TTL GROUP BY
2021-07-07 10:49:16 +03:00
alesapin
0d8844c510
Merge pull request #25884 from ClickHouse/fix_drop_part_in_queue
Relax `DROP PART` guarantees and turn on checks in ReplicationQueue.
2021-07-07 10:48:48 +03:00
Azat Khuzhin
5bc0533712 Add a note for padded to 8 bytes keys in StringHashTable 2021-07-07 10:42:33 +03:00
Azat Khuzhin
5e120b8d37 Fix stack-buffer-overflow in custom TLDs due to StringHashTable copy 8 bytes at a time
ASan reports [1]:

    ==164==ERROR: AddressSanitizer: stack-buffer-overflow on address 0x7f0209dd4abf at pc 0x00000b75b7c5 bp 0x7f0209dd4760 sp 0x7f0209dd4758
    READ of size 8 at 0x7f0209dd4abf thread T4 (TCPHandler)
        0 0xb75b7c4 in auto StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::dispatch<StringHashTable<StringHashSetSubMaps<Allocator<true, true> > > const, StringRef const&, StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::FindCallable>(StringHashTable<StringHashSetSubMaps<Allocator<true, true> > > const&, StringRef const&, StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::FindCallable&&) obj-x86_64-linux-gnu/../src/Common/HashTable/StringHashTable.h:283:21
        1 0xb75b7c4 in StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::has(StringRef const&, unsigned long) const obj-x86_64-linux-gnu/../src/Common/HashTable/StringHashTable.h:365:16
        2 0xb75b7c4 in DB::TLDList::has(StringRef const&) const obj-x86_64-linux-gnu/../src/Common/TLDListsHolder.cpp:31:26
        3 0x1c4a6046 in void DB::ExtractFirstSignificantSubdomain<true>::executeCustom<DB::FirstSignificantSubdomainCustomLookup>(DB::FirstSignificantSubdomainCustomLookup const&, char const*, unsigned long, char const*&, unsigned long&, char const**) (/usr/bin/clickhouse+0x1c4a6046)
        4 0x1c4a3586 in DB::FunctionCutToFirstSignificantSubdomainCustomImpl<DB::CutToFirstSignificantSubdomainCustom<true>, DB::NameCutToFirstSignificantSubdomainCustom>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x1c4a3586)
        5 0x10d96e34 in DB::IFunction::executeImplDryRun(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x10d96e34)
        6 0x10d9648b in DB::FunctionToExecutableFunctionAdaptor::executeDryRunImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x10d9648b)
        7 0x200ed79b in DB::IExecutableFunction::executeWithoutLowCardinalityColumns(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const obj-x86_64-linux-gnu/../src/Functions/IFunction.cpp:212:15
        8 0x200ee436 in DB::IExecutableFunction::execute(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long, bool) const obj-x86_64-linux-gnu/../src/Functions/IFunction.cpp:257:22
        9 0x20cd6f6f in DB::ActionsDAG::addFunction(std::__1::shared_ptr<DB::IFunctionOverloadResolver> const&, std::__1::vector<DB::ActionsDAG::Node const*, std::__1::allocator<DB::ActionsDAG::Node const*> >, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) obj-x86_64-linux-gnu/../src/Interpreters/ActionsDAG.cpp:214:37
        10 0x2124c8a7 in DB::ScopeStack::addFunction(std::__1::shared_ptr<DB::IFunctionOverloadResolver> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) obj-x86_64-linux-gnu/../src/Interpreters/ActionsVisitor.cpp:570:51
        11 0x2125c80d in DB::ActionsMatcher::Data::addFunction(std::__1::shared_ptr<DB::IFunctionOverloadResolver> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >) obj-x86_64-linux-gnu/../src/Interpreters/ActionsVisitor.h:169:27
        12 0x2125c80d in DB::ActionsMatcher::visit(DB::ASTFunction const&, std::__1::shared_ptr<DB::IAST> const&, DB::ActionsMatcher::Data&) obj-x86_64-linux-gnu/../src/Interpreters/ActionsVisitor.cpp:1061:14
        13 0x212522fb in DB::ActionsMatcher::visit(DB::ASTFunction const&, std::__1::shared_ptr<DB::IAST> const&, DB::ActionsMatcher::Data&) obj-x86_64-linux-gnu/../src/Interpreters/ActionsVisitor.cpp:971:17
        14 0x2121354e in DB::InDepthNodeVisitor<DB::ActionsMatcher, true, std::__1::shared_ptr<DB::IAST> const>::visit(std::__1::shared_ptr<DB::IAST> const&) obj-x86_64-linux-gnu/../src/Interpreters/InDepthNodeVisitor.h:34:13
        15 0x211e17c7 in DB::ExpressionAnalyzer::getRootActions(std::__1::shared_ptr<DB::IAST> const&, bool, std::__1::shared_ptr<DB::ActionsDAG>&, bool) obj-x86_64-linux-gnu/../src/Interpreters/ExpressionAnalyzer.cpp:421:48
        16 0x21204024 in DB::ExpressionAnalyzer::getConstActions(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&) obj-x86_64-linux-gnu/../src/Interpreters/ExpressionAnalyzer.cpp:1423:5
        17 0x230f7216 in DB::KeyCondition::getBlockWithConstants(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::TreeRewriterResult const> const&, std::__1::shared_ptr<DB::Context const>) obj-x86_64-linux-gnu/../src/Storages/MergeTree/KeyCondition.cpp:385:103
        18 0x22877f9e in DB::(anonymous namespace)::replaceConstantExpressions(std::__1::shared_ptr<DB::IAST>&, std::__1::shared_ptr<DB::Context const>, DB::NamesAndTypesList const&, std::__1::shared_ptr<DB::IStorage const>, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&) obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:280:34
        19 0x22877f9e in DB::StorageDistributed::skipUnusedShards(std::__1::shared_ptr<DB::Cluster>, std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::__1::shared_ptr<DB::Context const>) const obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:1091:5
        20 0x2285d215 in DB::StorageDistributed::getOptimizedCluster(std::__1::shared_ptr<DB::Context const>, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, std::__1::shared_ptr<DB::IAST> const&) const obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:1015:32
        21 0x2285a9c4 in DB::StorageDistributed::getQueryProcessingStage(std::__1::shared_ptr<DB::Context const>, DB::QueryProcessingStage::Enum, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&, DB::SelectQueryInfo&) const obj-x86_64-linux-gnu/../src/Storages/StorageDistributed.cpp:500:40
        22 0x2183a4b2 in DB::InterpreterSelectQuery::getSampleBlockImpl() obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:616:31
        23 0x21828db4 in DB::InterpreterSelectQuery::InterpreterSelectQuery(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, std::__1::shared_ptr<DB::IBlockInputStream> const&, std::__1::optional<DB::Pipe>, std::__1::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&)::$_1::operator()(bool) const obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:506:25
        24 0x2181b652 in DB::InterpreterSelectQuery::InterpreterSelectQuery(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, std::__1::shared_ptr<DB::IBlockInputStream> const&, std::__1::optional<DB::Pipe>, std::__1::shared_ptr<DB::IStorage> const&, DB::SelectQueryOptions const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&, std::__1::shared_ptr<DB::StorageInMemoryMetadata const> const&) obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:509:5
        25 0x21817cbe in DB::InterpreterSelectQuery::InterpreterSelectQuery(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, DB::SelectQueryOptions const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectQuery.cpp:161:7
        26 0x21dd0eb5 in std::__1::__unique_if<DB::InterpreterSelectQuery>::__unique_single std::__1::make_unique<DB::InterpreterSelectQuery, std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context>&, DB::SelectQueryOptions&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&>(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context>&, DB::SelectQueryOptions&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2068:32
        27 0x21dd0eb5 in DB::InterpreterSelectWithUnionQuery::buildCurrentChildInterpreter(std::__1::shared_ptr<DB::IAST> const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectWithUnionQuery.cpp:212:16
        28 0x21dcd0e7 in DB::InterpreterSelectWithUnionQuery::InterpreterSelectWithUnionQuery(std::__1::shared_ptr<DB::IAST> const&, std::__1::shared_ptr<DB::Context const>, DB::SelectQueryOptions const&, std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) obj-x86_64-linux-gnu/../src/Interpreters/InterpreterSelectWithUnionQuery.cpp:134:13
        29 0x211afe79 in std::__1::__unique_if<DB::InterpreterSelectWithUnionQuery>::__unique_single std::__1::make_unique<DB::InterpreterSelectWithUnionQuery, std::__1::shared_ptr<DB::IAST>&, std::__1::shared_ptr<DB::Context>&, DB::SelectQueryOptions const&>(std::__1::shared_ptr<DB::IAST>&, std::__1::shared_ptr<DB::Context>&, DB::SelectQueryOptions const&) obj-x86_64-linux-gnu/../contrib/libcxx/include/memory:2068:32
        30 0x211afe79 in DB::InterpreterFactory::get(std::__1::shared_ptr<DB::IAST>&, std::__1::shared_ptr<DB::Context>, DB::SelectQueryOptions const&) obj-x86_64-linux-gnu/../src/Interpreters/InterpreterFactory.cpp:110:16
        31 0x22273f97 in DB::executeQueryImpl(char const*, char const*, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, bool, DB::ReadBuffer*) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:524:28
        32 0x22270ce2 in DB::executeQuery(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::shared_ptr<DB::Context>, bool, DB::QueryProcessingStage::Enum, bool) obj-x86_64-linux-gnu/../src/Interpreters/executeQuery.cpp:913:30
        33 0x23905879 in DB::TCPHandler::runImpl() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:312:24
        34 0x2392b81c in DB::TCPHandler::run() obj-x86_64-linux-gnu/../src/Server/TCPHandler.cpp:1622:9
        35 0x2ab1fd8e in Poco::Net::TCPServerConnection::start() obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerConnection.cpp:43:3
        36 0x2ab20952 in Poco::Net::TCPServerDispatcher::run() obj-x86_64-linux-gnu/../contrib/poco/Net/src/TCPServerDispatcher.cpp:115:20
        37 0x2adfa3f4 in Poco::PooledThread::run() obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:199:14
        38 0x2adf4716 in Poco::ThreadImpl::runnableEntry(void*) obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:345:27
        39 0x7f02e66f2608 in start_thread (/lib/x86_64-linux-gnu/libpthread.so.0+0x9608)
        40 0x7f02e6619292 in clone (/lib/x86_64-linux-gnu/libc.so.6+0x122292)

    Address 0x7f0209dd4abf is located in stack of thread T4 (TCPHandler) at offset 447 in frame
        0 0x1c4a2c6f in DB::FunctionCutToFirstSignificantSubdomainCustomImpl<DB::CutToFirstSignificantSubdomainCustom<true>, DB::NameCutToFirstSignificantSubdomainCustom>::executeImpl(std::__1::vector<DB::ColumnWithTypeAndName, std::__1::allocator<DB::ColumnWithTypeAndName> > const&, std::__1::shared_ptr<DB::IDataType const> const&, unsigned long) const (/usr/bin/clickhouse+0x1c4a2c6f)

      This frame has 16 object(s):
        [32, 40) 'ref.tmp.i168'
        [64, 72) 'tmp_data.i.i'
        [96, 104) 'tmp_length.i.i'
        [128, 136) 'domain_end.i.i'
        [160, 216) 'ref.tmp.i132'
        [256, 312) 'ref.tmp.i'
        [352, 360) 'tld_lookup'
        [384, 408) 'ref.tmp'
        [448, 472) 'ref.tmp11' <== Memory access at offset 447 partially underflows this variable
        [512, 536) 'ref.tmp14'
        [576, 632) 'ref.tmp20'
        [672, 696) 'ref.tmp65'
        [736, 760) 'ref.tmp66'
        [800, 824) 'ref.tmp67'
        [864, 888) 'ref.tmp68'
        [928, 952) 'ref.tmp78'
    HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork
          (longjmp and C++ exceptions *are* supported)
    Thread T4 (TCPHandler) created by T0 here:
        0 0xb51940a in pthread_create (/usr/bin/clickhouse+0xb51940a)
        1 0x2adf3a9f in Poco::ThreadImpl::startImpl(Poco::SharedPtr<Poco::Runnable, Poco::ReferenceCounter, Poco::ReleasePolicy<Poco::Runnable> >) obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread_POSIX.cpp:202:6
        2 0x2adf699a in Poco::Thread::start(Poco::Runnable&) obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/Thread.cpp:128:2
        3 0x2adfa998 in Poco::PooledThread::start() obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:85:10
        4 0x2adfa998 in Poco::ThreadPool::ThreadPool(int, int, int, int) obj-x86_64-linux-gnu/../contrib/poco/Foundation/src/ThreadPool.cpp:252:12
        5 0xb582c25 in DB::Server::main(std::__1::vector<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >, std::__1::allocator<std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > > > const&) obj-x86_64-linux-gnu/../programs/server/Server.cpp:915:22
        6 0x2ab511a5 in Poco::Util::Application::run() obj-x86_64-linux-gnu/../contrib/poco/Util/src/Application.cpp:334:8
        7 0xb56a89c in DB::Server::run() obj-x86_64-linux-gnu/../programs/server/Server.cpp:392:25
        8 0x2ab956f7 in Poco::Util::ServerApplication::run(int, char**) obj-x86_64-linux-gnu/../contrib/poco/Util/src/ServerApplication.cpp:611:9
        9 0xb566519 in mainEntryClickHouseServer(int, char**) obj-x86_64-linux-gnu/../programs/server/Server.cpp:171:20
        10 0xb56224a in main obj-x86_64-linux-gnu/../programs/main.cpp:366:12
        11 0x7f02e651e0b2 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x270b2)

    SUMMARY: AddressSanitizer: stack-buffer-overflow obj-x86_64-linux-gnu/../src/Common/HashTable/StringHashTable.h:283:21 in auto StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::dispatch<StringHashTable<StringHashSetSubMaps<Allocator<true, true> > > const, StringRef const&, StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::FindCallable>(StringHashTable<StringHashSetSubMaps<Allocator<true, true> > > const&, StringRef const&, StringHashTable<StringHashSetSubMaps<Allocator<true, true> > >::FindCallable&&)
    Shadow bytes around the buggy address:
      0x0fe0c13b2900: 00 00 f3 f3 00 00 00 00 00 00 00 00 00 00 00 00
      0x0fe0c13b2910: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
      0x0fe0c13b2920: f1 f1 f1 f1 f8 f2 f2 f2 00 f2 f2 f2 00 f2 f2 f2
      0x0fe0c13b2930: 00 f2 f2 f2 f8 f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 f2
      0x0fe0c13b2940: f8 f8 f8 f8 f8 f8 f8 f2 f2 f2 f2 f2 00 f2 f2 f2
    =>0x0fe0c13b2950: f8 f8 f8 f2 f2 f2 f2[f2]00 00 00 f2 f2 f2 f2 f2
      0x0fe0c13b2960: 00 00 00 f2 f2 f2 f2 f2 f8 f8 f8 f8 f8 f8 f8 f2
      0x0fe0c13b2970: f2 f2 f2 f2 f8 f8 f8 f2 f2 f2 f2 f2 f8 f8 f8 f2
      0x0fe0c13b2980: f2 f2 f2 f2 f8 f8 f8 f2 f2 f2 f2 f2 f8 f8 f8 f2
      0x0fe0c13b2990: f2 f2 f2 f2 f8 f8 f8 f3 f3 f3 f3 f3 00 00 00 00
      0x0fe0c13b29a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
    Shadow byte legend (one shadow byte represents 8 application bytes):
      Addressable:           00
      Partially addressable: 01 02 03 04 05 06 07
      Heap left redzone:       fa
      Freed heap region:       fd
      Stack left redzone:      f1
      Stack mid redzone:       f2
      Stack right redzone:     f3
      Stack after return:      f5
      Stack use after scope:   f8
      Global redzone:          f9
      Global init order:       f6
      Poisoned by user:        f7
      Container overflow:      fc
      Array cookie:            ac
      Intra object redzone:    bb
      ASan internal:           fe
      Left alloca redzone:     ca
      Right alloca redzone:    cb
      Shadow gap:              cc
    ==164==ABORTING

  [1]: https://clickhouse-test-reports.s3.yandex.net/26041/42a844546229e56c51a3ec986467ced52e4ed972/functional_stateless_tests_flaky_check_(address)/stderr.log

v2: Replace String with string_view in custom TLD for scalar
v3: use ColumnString::getDataAt()
2021-07-07 10:38:45 +03:00
mergify[bot]
d9195c6f4a
Merge branch 'master' into support-distinct-on 2021-07-07 06:42:33 +00:00
Vladimir
b46ac3dfd1
Merge pull request #25609 from zxc111/master 2021-07-07 09:36:55 +03:00
alexey-milovidov
80eaf85301
Merge pull request #24416 from elevankoff/system-metrics
Common system metrics collection
2021-07-07 03:21:49 +03:00
Azat Khuzhin
42a8445462 Fix constness of custom TLDs
Before this patch the functions below returns incorrect type for consts,
and hence optimize_skip_unused_shards does not work:

- cutToFirstSignificantSubdomainCustom()
- cutToFirstSignificantSubdomainCustomWithWWW()
- firstSignificantSubdomainCustom()
2021-07-07 01:27:31 +03:00
alesapin
7b004fb828
Merge pull request #25995 from CurtizJ/fix-merge-tree-settings-change
Fix alter of settings in `MergeTree` tables
2021-07-06 22:12:38 +03:00
Kseniia Sumarokova
7a7b774ba3
Merge pull request #25550 from kssenii/truncate
Allow truncate in storages s3/hdfs
2021-07-06 22:07:53 +03:00
alesapin
3dee74df54 Comment 2021-07-06 19:53:54 +03:00
alesapin
a8fdc41193 Fix bug and add more trash to test 2021-07-06 19:51:23 +03:00
vdimir
b44bd174cc
Change error code for DISTINCT ON and LIMIT BY, finally 2021-07-06 19:14:22 +03:00
Nicolae Vartolomei
24f5ad8920 Subtract number of watch callbacks as this is what we actually count 2021-07-06 17:13:30 +01:00
Nicolae Vartolomei
9b3ceda57c Increment ZooKeeperWatch metric only if the callback is registered 2021-07-06 17:10:29 +01:00
vdimir
c6e13e6e2e
Add leading zeros in function bin 2021-07-06 15:19:42 +03:00
mergify[bot]
7ff8ac51a9
Merge branch 'master' into fix-merge-tree-settings-change 2021-07-06 12:14:33 +00:00
alesapin
75e26b93d0 Review bug fixes 2021-07-06 15:05:58 +03:00
dankondr
869a41ffb9 Add leftPadString() function 2021-07-06 14:40:34 +03:00
mergify[bot]
e9df8cc96c
Merge branch 'master' into support-distinct-on 2021-07-06 11:28:07 +00:00
alesapin
e9540f0621 Remove debug logs 2021-07-06 14:13:35 +03:00
mergify[bot]
8dd378f7c2
Merge branch 'master' into fix_drop_part_in_queue 2021-07-06 11:00:04 +00:00
alesapin
53b23775a9 Fix drop part 2021-07-06 13:58:53 +03:00
Maksim Kita
cd89138d3e FunctionsLogical const result for non const arguments fix 2021-07-06 13:49:16 +03:00
Maksim Kita
4812116929 FunctionSQLJSON ContextPtr build fix 2021-07-06 13:08:09 +03:00
vdimir
3cef256f79
Errorcode DISTINCT_ON_AND_LIMIT_BY_TOGETHER -> UNSUPPORTED_METHOD 2021-07-06 12:22:08 +03:00
vdimir
9665d41092
Force parentheses for DISTINCT ON 2021-07-06 12:17:26 +03:00
alesapin
2600922786 Followup fix 2021-07-06 11:36:39 +03:00
Maksim Kita
20b7fab7af
Merge pull request #26014 from ClickHouse/remove-old-code
Remove old code
2021-07-06 11:08:04 +03:00
Maksim Kita
2afdb744bb
Merge pull request #25989 from kitaisreal/compile-aggregate-functions-perf-tests-fix
Compile aggregate functions perf tests fix
2021-07-06 11:04:11 +03:00
Kseniia Sumarokova
d2141ff53b
Merge pull request #24148 from l1tsolaiki/jsonpath
Jsonpath
2021-07-06 10:43:29 +03:00
Alexey Milovidov
504d2c0c56 Remove old code 2021-07-06 05:31:09 +03:00
mergify[bot]
720660e9e9
Merge branch 'master' into network-instrumentation 2021-07-06 00:54:34 +00:00
alexey-milovidov
b724138541
Merge pull request #25786 from kssenii/inconsisteny
Fix inconsistent behaviour of GROUP BY constant on empty set
2021-07-06 03:36:50 +03:00
Alexey Milovidov
2e41419e3b Fix build 2021-07-06 03:34:27 +03:00
Alexey Milovidov
94a024c7c8 Fix warning 2021-07-06 01:12:49 +03:00
Alexey Milovidov
9875adc00b Make it even worse 2021-07-06 01:09:39 +03:00
l1tsolaiki
1bbfbff003 Regenerate ya.make 2021-07-06 01:04:09 +03:00
Alexey Milovidov
6d3d724cd4 Fix error 2021-07-05 23:20:25 +03:00
Alexey Milovidov
8fae774e85 Fix error 2021-07-05 23:18:13 +03:00
Alexey Milovidov
f29eb11e6c Fix error 2021-07-05 23:17:53 +03:00
Alexey Milovidov
21fb6ddea5 Remove AIO for sequential reads 2021-07-05 23:02:24 +03:00
alesapin
f7e1cfdb24 Some partially working code 2021-07-05 22:58:55 +03:00
Alexey Milovidov
945b54441d Comments 2021-07-05 22:41:50 +03:00
Alexey Milovidov
ac1baaf6d4 Comments 2021-07-05 22:37:12 +03:00
Alexey Milovidov
1fde0e13cc A check just in case 2021-07-05 22:32:33 +03:00
Alexey Milovidov
22ba93789b Fix warning 2021-07-05 22:29:36 +03:00
Alexey Milovidov
ce9c9c5e16 Merge remote-tracking branch 'origin/master' into system-metrics 2021-07-05 22:08:55 +03:00
Maksim Kita
f3d74c84fe
Merge pull request #25982 from CurtizJ/fix-map-json-format
Fix formatting of type `Map` with integer keys to `JSON`
2021-07-05 21:54:31 +03:00
Kseniia Sumarokova
8b075e34e7
Merge pull request #25984 from kssenii/add-drops-in-tests
Correct test
2021-07-05 18:35:53 +03:00
Anton Popov
9071ecd428 fix alter of settings in MergeTree 2021-07-05 15:44:58 +03:00
vdimir
f5b5f601f4
Merge branch 'master' into support-distinct-on 2021-07-05 15:44:20 +03:00
vdimir
dd06866fa8
Fix unbin for corner cases 2021-07-05 14:56:39 +03:00
vdimir
231740f2d6
Function bin for uint uses writeBinByte, correct for single zero 2021-07-05 14:44:50 +03:00
Kseniia Sumarokova
c72a1be0be
Merge pull request #25064 from ucasfl/merge
Database argument for StorageMerge support regular expression.
2021-07-05 14:14:44 +03:00
Anton Popov
237b834629 fix clang-tidy 2021-07-05 13:29:36 +03:00
vdimir
cc13787888
Minor style changes for (un)bin/hex 2021-07-05 13:22:44 +03:00