Commit Graph

44148 Commits

Author SHA1 Message Date
Mikhail Filimonov
6e599533a7 Add missing query context for system logs
Needed to allow attaching materialized views with joins or with
subqueries to system.logs.
2020-07-03 19:19:32 +02:00
Nikita Mikhaylov
5c97106ea3 Merge branch 'master' of github.com:ClickHouse/ClickHouse into Avogar_orc_output_format 2020-07-03 18:00:28 +03:00
Nikita Mikhaylov
fba02badcb fix test with UBSan 2020-07-03 17:53:54 +03:00
Ilya Yatsishin
5a4d9fb9ae
Merge pull request #12070 from ClickHouse/filimonov-max_rows_to_read-threads
max_rows_to_read remove note about 'applied on each thread separately'
2020-07-03 17:45:47 +03:00
Vitaly Baranov
929d652297
Merge pull request #12083 from vitlibar/improve-revoke-command
Improve REVOKE command
2020-07-03 17:17:36 +03:00
Nikolai Kochetov
8349afa4ad Try fix tests. 2020-07-03 16:38:35 +03:00
alesapin
cd9a71b19c
Update clickhouse-test 2020-07-03 16:01:02 +03:00
Alexander Kuzmenkov
e7e4d29a54 more fuzzing 2020-07-03 15:52:16 +03:00
alexey-milovidov
66227d8f20
Merge pull request #12102 from ClickHouse/anchore-analysis
Dockerfile security check for `clickhouse-server`
2020-07-03 15:51:24 +03:00
alexey-milovidov
d4d9de2dff
Merge pull request #12101 from ClickHouse/codeql-analysis
Enable CodeQL security scanner
2020-07-03 15:50:51 +03:00
Anton Ivashkin
23b44ca6fe Add type column in system.disks 2020-07-03 15:45:54 +03:00
Guillaume Tassery
027c6b705f Create initializeAggregation to initialize an aggregation function based on a value 2020-07-03 19:18:47 +07:00
Nikolai Kochetov
8ec70c2c3c Added test. 2020-07-03 14:45:57 +03:00
alesapin
5098df8d0b Make skip-list optional 2020-07-03 14:15:30 +03:00
alesapin
07cbb427a8 More verbose message about skip 2020-07-03 14:05:27 +03:00
Nikolai Kochetov
6d08b7b45a Remove LC converting to Arrow. 2020-07-03 14:04:36 +03:00
alesapin
d015a4d646 Move skip lists to clickhouse-test 2020-07-03 13:57:16 +03:00
Nikolai Kochetov
3d37a63247 Remove LC converting to Arrow. 2020-07-03 13:37:55 +03:00
Nikolai Kochetov
b3f1842035 Remove LC converting to Arrow. 2020-07-03 13:35:44 +03:00
alesapin
0a6f3ca9fd Add unbundled mode flag 2020-07-03 13:11:16 +03:00
Mikhail Filimonov
0ce2d48af6 Test for a fixed issue #10668, related to input_format_allow_errors_num in CSV 2020-07-03 11:24:03 +02:00
alesapin
b3ec449e35
Fix test (#12088) 2020-07-03 12:18:59 +03:00
Ivan Blinkov
e7acda7642
Update README.md 2020-07-03 12:16:44 +03:00
Nikolai Kochetov
c9a41ba4ba
Update CHANGELOG.md 2020-07-03 12:09:27 +03:00
Alexander Kuzmenkov
2577d71ed5 Changelog for 20.5 2020-07-03 11:57:38 +03:00
Alexander Kuzmenkov
e27e509667
Update polymorphic_parts_l.xml 2020-07-03 11:46:48 +03:00
Alexander Kuzmenkov
02ee988d80
Update polymorphic_parts_m.xml 2020-07-03 11:46:29 +03:00
Alexander Kuzmenkov
1ffc4ad88a
Update polymorphic_parts_s.xml 2020-07-03 11:46:10 +03:00
Nikolai Kochetov
8cfe5f137a Added test. 2020-07-03 11:22:21 +03:00
Nikolai Kochetov
5e8d5bc8c0 Fix overlimiting the nuber of threads for union. 2020-07-03 11:10:52 +03:00
Ivan Blinkov
d962fd931b
Create anchore-analysis.yml 2020-07-03 11:10:05 +03:00
alesapin
c57edd2018 Tiny fixes 2020-07-03 11:02:35 +03:00
Ivan Blinkov
d5732d3972
Create codeql-analysis.yml 2020-07-03 10:57:22 +03:00
Nikolai Kochetov
17c89f3fe0
Merge pull request #12085 from ClickHouse/fix-11937
Fix limiting the number of threads for VIEW.
2020-07-03 10:35:04 +03:00
Nikolai Kochetov
3c717d4aca Added test. 2020-07-03 10:34:08 +03:00
Azat Khuzhin
bd5e5e9462 kafka: remove outdated comment
As stated by @filimonov it is not relevant (after #11599)
2020-07-03 09:23:39 +03:00
Azat Khuzhin
de8bc99d48 kafka: avoid superior polling after DROP/DETACH TABLE
Before this patch isStalled() was checked before polledDataUnusable(),
and after DROP TABLE isStalled() == true (although this looks tricky).
2020-07-03 09:23:39 +03:00
Azat Khuzhin
8508200020 kafka: improve logging during engine shutdown
This will help with tracking possible issues, when you need to know was
buffer released or not.
2020-07-03 09:23:39 +03:00
Azat Khuzhin
e7179c402c kafka: check that the data is still usable after parsing 2020-07-03 09:23:38 +03:00
Azat Khuzhin
6104872cae kafka: fix SIGSEGV on DROP TABLE
After #11599 it is possible that messages of the
ReadBufferFromKafkaConsumer will be cleaned-up right in
read_kafka_message callback (from KafkaBlockInputStream) if the stop
flag isset (i.e. DROP TABLE is waiting the consumer), and if
read_kafka_message already processed some rows it will not return 0 and
the loop after will try to get current topic from the buffer, which uses
messages in the underlying and this will got SIGSEGV:

    12:14:56.173262 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Debug> executeQuery: (from 0.0.0.0:0, user: ) DROP TABLE IF EXISTS data.queue
    12:14:56.173285 [ 55421 ] {f7930856-d478-4e41-af56-24ce7b693e95} <Trace> StorageKafka (newly_queue): Waiting for cleanup
    12:14:56.180016 [ 55390 ] {} <Trace> BaseDaemon: Received signal 11
    12:14:56.180267 [ 4914 ] {} <Fatal> BaseDaemon: ########################################
    12:14:56.181879 [ 4914 ] {} <Fatal> BaseDaemon: (version 20.6.1.1, build id: 4CE0298F08583658) (from thread 55468) (no query) Received signal Segmentation fault (11)
    12:14:56.181900 [ 4914 ] {} <Fatal> BaseDaemon: Address: 0x8 Access: read. Address not mapped to object.
    12:14:56.181909 [ 4914 ] {} <Fatal> BaseDaemon: Stack trace:
    12:14:56.184676 [ 4914 ] {} <Fatal> BaseDaemon: 3. /ch/contrib/cppkafka/include/cppkafka/message.h:111: DB::KafkaBlockInputStream::readImpl() @ 0xe343f1c in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.185553 [ 4914 ] {} <Fatal> BaseDaemon: 4. /ch/contrib/libcxx/include/vector:1003: DB::IBlockInputStream::read() @ 0xd9d95bd in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.188238 [ 4914 ] {} <Fatal> BaseDaemon: 5. /ch/src/DataStreams/copyData.cpp:26: DB::copyData() @ 0xd9f712a in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.188780 [ 4914 ] {} <Fatal> BaseDaemon: 6. /ch/contrib/libcxx/include/vector:1532: DB::StorageKafka::streamToViews() @ 0xe335e73 in /usr/lib/debug/usr/bin/clickhouse
    12:14:56.189331 [ 4914 ] {} <Fatal> BaseDaemon: 7. /ch/src/Storages/Kafka/StorageKafka.cpp:491: DB::StorageKafka::threadFunc() @ 0xe336738 in /usr/lib/debug/usr/bin/clickhouse

55421 thread (shows that it still waiting for deactivation):

    5  std::__1::lock_guard<>::lock_guard () at ../contrib/libcxx/include/__mutex_base:90
    6  DB::BackgroundSchedulePoolTaskInfo::deactivate (this=0x7fc7e4465f20) at ../src/Core/BackgroundSchedulePool.cpp:59
    7  DB::StorageKafka::shutdown (this=0x7fc7e45e4600) at ../contrib/libcxx/include/memory:3821

And just in case thread where read_kafka_message is called:

    0  DB::ReadBufferFromKafkaConsumer::nextImpl (this=0x7fd4901d4118) at ../contrib/libcxx/include/atomic:1491
    1  DB::ReadBuffer::next (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:59
    2  DB::ReadBuffer::eof (this=0x7fd4901d4118) at ../src/IO/ReadBuffer.h:81
    3  DB::skipWhitespaceIfAny (buf=...) at ../src/IO/ReadHelpers.h:945
    4  DB::JSONEachRowRowInputFormat::readRow (ext=..., columns=..., this=0x7fd499a7a020) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:222
    5  DB::JSONEachRowRowInputFormat::readRow (this=0x7fd499a7a020, columns=..., ext=...) at ../src/Processors/Formats/Impl/JSONEachRowRowInputFormat.cpp:218
    6  DB::IRowInputFormat::generate (this=0x7fd499a7a020) at ../src/Processors/Formats/IRowInputFormat.cpp:64
    7  DB::ISource::work (this=0x7fd499a7a020) at ../src/Processors/ISource.cpp:48
    8  DB::KafkaBlockInputStream::<lambda()>::operator()(void) const () at ../contrib/libcxx/include/memory:3826
    9  DB::KafkaBlockInputStream::readImpl (this=0x7fd46e718820) at ../contrib/libcxx/include/new:340

Cc: @filimonov
2020-07-03 09:22:44 +03:00
Alexander Kuzmenkov
03becdbae4
Update polymorphic_parts_s.xml 2020-07-03 09:12:15 +03:00
Alexander Kuzmenkov
d1a93523b6
Update polymorphic_parts_m.xml 2020-07-03 09:11:46 +03:00
Alexander Kuzmenkov
68ca587a71
Update polymorphic_parts_l.xml 2020-07-03 09:11:17 +03:00
manmitya
457f56be0c
(typo) in doc (#12099) 2020-07-03 08:04:42 +03:00
Alexey Milovidov
4c751bf8be Added results for AWS Lightsail 2020-07-03 03:58:57 +03:00
Azat Khuzhin
0700a705bc Rewrite curl dependency in a more ch compatible way
- add support of unbundled curl
- add CURL::libcurl libraries
- avoid explicit linkage of daemon with curl (added with sentry)
- set CACHE variables for non-direct users:
  - mariadb-connector-c
  - aws-s3-cmake
  - sentry-native

Cc: @alexey-milovidov
Cc: @alesapin (requires docker image update)
Cc: @abyss7

Refs: #11300
Refs: #8011
Refs: #8905

v2: replace cmake/find/curl.cmake with proper contrib/curl-cmake (as
pointed by @abyss7, cmake/find/*.cmake is deprecated)
2020-07-03 00:57:08 +03:00
BayoNet
3435328465
DOCS-522: max_parser_depth (#12097)
* asiana21-DOCSUP-925-max_parser_depth (#132)

* docs(max_parser_depth): added the setting description

* docs(max_parser_depth): some changes

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* Update docs/en/operations/settings/settings.md

Co-authored-by: BayoNet <da-daos@yandex.ru>

* docs(max_parser_depth): added ru translation

* docs(max_parser_depth): removed quotation marks

Co-authored-by: asiana21 <asiana21@yandex-team.ru>
Co-authored-by: BayoNet <da-daos@yandex.ru>

* CLICKHOUSEDOCS-522: Fixed the link.

Co-authored-by: AsiaKorushkina <43650329+AsiaKorushkina@users.noreply.github.com>
Co-authored-by: asiana21 <asiana21@yandex-team.ru>
Co-authored-by: Sergei Shtykov <bayonet@yandex-team.ru>
2020-07-03 00:26:55 +03:00
Ivan Blinkov
b81c66a031
[docker] install ca-certificates before the first apt-get update (#12095)
* [docker] install ca-certificates before first apt-get update

* Update Dockerfile
2020-07-02 22:16:21 +03:00
Vitaliy Zakaznikov
3f9dd7f62b Fix small typo. 2020-07-02 21:02:15 +02:00
Vitaliy Zakaznikov
464eb70ca4 Removing unnecessary text. 2020-07-02 20:52:17 +02:00