Commit Graph

4166 Commits

Author SHA1 Message Date
alexey-milovidov
4dd66385b5
Merge pull request #7789 from zhang2014/fix/ISSUES-7784
ISSUES-7784 disabled predicate optimize for WITH FILL expression
2019-11-17 23:36:42 +03:00
Nikolai Kochetov
5cc14e6d66
Merge pull request #7777 from ClickHouse/fix-array-intersect-overflow
Fix array intersect overflow
2019-11-16 18:43:16 +03:00
zhang2014
15b20e0b96 ISSUES-7784 disabled predicate optimize for WITH FILL expression 2019-11-15 22:10:36 +08:00
Alexander Kuzmenkov
7f34c0089c Merge remote-tracking branch 'origin/master' into HEAD 2019-11-14 18:53:36 +03:00
Nikolai Kochetov
fa6ec1a39d Update tests. 2019-11-14 16:40:07 +03:00
chertus
d70904d7ee better column to table matching: check if table has qualified column 2019-11-13 18:00:21 +03:00
CurtizJ
f6b601cb9c fix order by with pk optimization 2019-11-13 17:57:45 +03:00
Nikita Mikhaylov
c8bfa6db59 done 2019-11-13 15:43:55 +03:00
hcz
08f8bbf52e Update tests 2019-11-13 11:00:08 +08:00
chertus
a8a283ffdc add missing array functions for Decimals 2019-11-11 23:46:36 +03:00
Alexey Milovidov
7cd8831eb8 Added a test of javaHashUTF16LE for non BMP code points 2019-11-11 21:55:53 +03:00
Nikolai Kochetov
28b195a0f1
Merge pull request #7672 from ClickHouse/processors-4-tmp
Processors 4
2019-11-11 21:22:06 +03:00
chertus
03933a1039 gather utils for Decimals (no scale checks) 2019-11-11 19:18:37 +03:00
alesapin
c71e874a8c
Merge pull request #7709 from ClickHouse/fix_storage_odbc_parsing
Fix use of destroyed variable captured in lambda for storage XDBC
2019-11-11 15:39:54 +03:00
Alexey Milovidov
013435bded Updated test #7703 2019-11-11 11:55:07 +03:00
alesapin
c74538153f Fix use of destroyed variable captured in lambda 2019-11-11 11:40:00 +03:00
Alexey Milovidov
f47415b7fa Allowed non-constant negative "size" argument for function "substring" 2019-11-11 04:45:03 +03:00
Nikolai Kochetov
86894c9570 Updated test. 2019-11-09 00:37:33 +03:00
Nikolai Kochetov
032e8c8aff Try fix test. 2019-11-08 20:44:55 +03:00
alesapin
40a5cf4bb9 Forbidden to use column name more than once in insert query. 2019-11-08 12:57:32 +03:00
alexey-milovidov
0fefebae1b
Merge pull request #7518 from sundy-li/improve_range
Improve range
2019-11-08 00:59:05 +03:00
alexey-milovidov
034d6ce729
Merge pull request #7355 from millb/decimal_hex_function
Decimal hex function
2019-11-08 00:56:59 +03:00
alexey-milovidov
7f01fd13b3
Merge pull request #7624 from azat/_shard_num
[RFC] Add _shard_num virtual column for the Distributed engine
2019-11-08 00:55:41 +03:00
alexey-milovidov
a2e79cc427
Merge pull request #7574 from ClickHouse/processors-4
Fix tests for processors
2019-11-08 00:46:30 +03:00
alesapin
4f6fa013e5 Merge branch 'master' into fix_scope_of_interpreter_select_query_in_mutations 2019-11-07 11:18:35 +03:00
alesapin
8152fc3c15
Merge pull request #7601 from azat/view-query-sigsegv
Fix scope of the InterpreterSelectQuery for views with query
2019-11-07 11:07:28 +03:00
alexey-milovidov
31aff291e6
Merge pull request #7651 from achimbab/javaHashUTF16LE
Implemented javaHashUTF16LE()
2019-11-06 22:58:48 +03:00
Nikolai Kochetov
da07018a1a Update memory limit for external aggregation test. 2019-11-06 21:11:06 +03:00
Azat Khuzhin
0677ae048c Wrap _shard_num with toUInt32 for simpler JOIN with system.clusters.shard_num 2019-11-06 21:02:42 +03:00
Azat Khuzhin
f58f1517e0 Regression test for InterpreterSelectQuery scope in PushingToViewsBlockOutputStream
It is too complex, so I'm not sure that it is worth it.
2019-11-06 20:39:23 +03:00
alesapin
8c7deaa70d More safier, but still ugly mutations interpreter 2019-11-06 20:28:03 +03:00
Nikolai Kochetov
3f8cc216a8 Update memory limit for external aggregation test. 2019-11-06 19:50:19 +03:00
Mikhail Korotov
29747b5511 Merge branch 'decimal_hex_function' of https://github.com/millb/ClickHouse into decimal_hex_function 2019-11-06 16:11:27 +03:00
Azat Khuzhin
81aeff2d2a Add _shard_num virtual column for the Distributed engine
With JOIN from system.clusters one can figure out from which server data
came.

TODO:
- optimization to avoid communicating with unrelated shards (for queries
  like "AND _shard_num = n")
- fix aliases (see tests with serverError expected)

v0: AddingConstColumnBlockInputStream
v2: VirtualColumnUtils::rewriteEntityInAst
v3: fix remote(Distributed) by appending _shard_num only if has been requested
2019-11-06 15:26:12 +03:00
philip.han
68a82f78b4 Implemented javaHashUTF16LE() 2019-11-06 19:46:37 +09:00
alexey-milovidov
33edb0929b
Merge pull request #7641 from 4ertus2/joins
Support RIGHT | FULL JOIN with expressions in ON section
2019-11-06 11:17:52 +03:00
millb
5c478dfe02 Merge branch 'master' into decimal_hex_function 2019-11-06 09:43:30 +03:00
alexey-milovidov
687be5f7af
Merge pull request #7618 from excitoon-favorites/looks-like-wrong-copy-paste
Fixed exception in case of using 1 argument while defining S3, URL and HDFS storages
2019-11-06 02:11:38 +03:00
chertus
950e95c178 support JOIN ON expression 2019-11-05 23:22:20 +03:00
alexey-milovidov
56c89349d3
Merge pull request #7639 from CurtizJ/final_mark_without_primary_key
Fix final mark with empty primary key.
2019-11-05 22:53:52 +03:00
alexey-milovidov
8fc84e93ff
Merge pull request #7635 from ClickHouse/fix_concat_return_data_type
Now concat always return string column
2019-11-05 21:39:48 +03:00
alexey-milovidov
40a8216294
Merge pull request #7625 from ClickHouse/array-compact-improve
Improvement of arrayCompact function.
2019-11-05 21:39:06 +03:00
alexey-milovidov
eb6add45ea
Merge pull request #7626 from ClickHouse/char-test-utf8
Added a test for function "char" that proves that it's applicable for non-ASCII.
2019-11-05 21:38:37 +03:00
Alexey Milovidov
c6ac30e450 Added another test case by Sundy-Li request 2019-11-05 21:38:16 +03:00
CurtizJ
c958662c6e add test for empty primaty key 2019-11-05 21:21:49 +03:00
alesapin
2d7ae27232 Now concat always return string column 2019-11-05 16:23:09 +03:00
Nikita Mikhaylov
817b52314e Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-11-05 12:32:26 +03:00
alexey-milovidov
6a871f579f
Merge pull request #7598 from infinivision/bitmap_replace
added bitmapTransform
2019-11-05 02:23:50 +03:00
Alexey Milovidov
4f83b56c14 Added another test case 2019-11-05 01:47:46 +03:00
Vladimir Chebotarev
8556b2cee3 Added tests to check that ClickHouse don't crash on insufficient arguments of S3, URL and HDFS storages. 2019-11-05 01:47:26 +03:00
Alexey Milovidov
0a3b7068fd Added a test for function "char" 2019-11-05 01:45:51 +03:00
alexey-milovidov
7d2a16ee39
Merge pull request #7486 from sundy-li/char_function
functions: add char function
2019-11-05 01:40:18 +03:00
Alexey Milovidov
92824e14e7 Added a test 2019-11-05 01:18:59 +03:00
alexey-milovidov
fbed472018
Update 00076_ip_coding_functions.sql 2019-11-05 00:53:35 +03:00
alexey-milovidov
81e33ca817
Merge pull request #7586 from 4ertus2/joins
Rewrite NonJoinedBlockInputStream
2019-11-04 14:49:47 +03:00
Zhichang Yu
da2d05802c added bitmapTransform 2019-11-04 14:55:31 +08:00
alexey-milovidov
a8d6843723
Merge pull request #7599 from azat/__getScalar-fix
Check column for __getScalar() (avoids assertion)
2019-11-04 02:28:42 +03:00
Azat Khuzhin
920572915e Add regression test for the __getScalar() 2019-11-04 00:31:10 +03:00
alexey-milovidov
d9c02b652f
Merge pull request #7594 from amosbird/fix20
early constant folding improvement
2019-11-04 00:30:16 +03:00
chertus
d4e1468022 fix Join.saved_block_sample columns' nullability 2019-11-03 22:33:59 +03:00
Amos Bird
f0b3c1f7c7
early constant folding improvement 2019-11-03 21:17:46 +08:00
alexey-milovidov
d08bfbd3e1
Merge pull request #7328 from Joeywzr/arrayCompact
implement arrayCompact
2019-11-03 01:07:19 +03:00
alexey-milovidov
fa0274e223
Merge pull request #7380 from hczhcz/patch-1018
Add function arrayFill and arrayReverseFill
2019-11-03 01:06:41 +03:00
alexey-milovidov
dea9220e3c
Merge pull request #7542 from hczhcz/patch-1030
Fix "create as select" parsing
2019-11-02 00:58:09 +03:00
alexey-milovidov
ad01f7b1ac
Merge pull request #7552 from azat/do-not-account-memory-for-Buffer-in-max_memory_usage
[RFC] Do not account memory for Buffer engine in max_memory_usage limit
2019-11-02 00:57:24 +03:00
alexey-milovidov
dda93e2275
Merge pull request #7561 from ClickHouse/achimbab-master
Merge for #7363
2019-11-02 00:57:13 +03:00
chertus
334b91f351 revrite NonJoinedBlockInputStream (in progress) 2019-11-01 20:41:07 +03:00
alexey-milovidov
4081b0be90
Merge pull request #7497 from amosbird/countopt
Early constant folding.
2019-11-01 16:54:02 +03:00
Amos Bird
5333258e7e
Complement to tuple parser 2019-11-01 10:48:15 +08:00
Azat Khuzhin
dbe45800d9 Do not account memory for Buffer engine in max_memory_usage limit
Since background flush will not be accounted there, and it can be too
tricky to calclulate this limit, in case you have multiple materialized
views with Buffer engine.

v2: test adjustment
2019-10-31 22:26:50 +03:00
Amos Bird
e04cdd4ebb
Early constant folding. 2019-10-31 23:54:32 +08:00
Amos Bird
4aff9a20c6
Better parser 2019-10-31 23:22:48 +08:00
alexey-milovidov
417c008700
Update 01021_create_as_select.sql 2019-10-31 11:29:30 +03:00
hcz
4c7a54113d Add tests 2019-10-31 11:33:23 +08:00
alexey-milovidov
0d2a2c332f
Merge pull request #7366 from achimbab/fixbug_inop
Made IN operator support Array(LowCardinality(Nullable(String)))
2019-10-31 00:26:22 +03:00
alexey-milovidov
bb75c7469a
Merge pull request #7545 from ClickHouse/fix_only_tuple_columns
Fix only tuple columns in table.
2019-10-30 23:34:23 +03:00
alexey-milovidov
ddb58eeb8b
Merge pull request #7510 from amosbird/smartcount
Instant count() for MergeTree
2019-10-30 20:42:00 +03:00
alesapin
7f4e982d13 Add tests 2019-10-30 17:51:30 +03:00
chertus
deb2406b30 fix JOIN right table keys nullability 2019-10-29 22:39:42 +03:00
Nikita Mikhaylov
08f1930e76 Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-29 20:04:32 +03:00
Amos Bird
1eb44c6837
Add missing tests 2019-10-29 22:26:43 +08:00
Amos Bird
2c75a51d4f
Instant count() for MergeTree
Use (Replicated)MergeTree's metadata to do trivial count()
2019-10-29 17:45:47 +08:00
sundy-li
00389a67a0 add more tests 2019-10-29 14:55:59 +08:00
sundy-li
dbd3227e5a fixup partial const column 2019-10-29 11:51:27 +08:00
Alexander Kuzmenkov
6e2af3db41
Merge pull request #7480 from azat/crc-v3
Add CRC32IEEE()/CRC64() support
2019-10-28 16:16:37 +03:00
Nikita Mikhaylov
756a10707d Merge branch 'master' of github.com:ClickHouse/ClickHouse into parallel_parsing 2019-10-28 13:51:52 +03:00
sundy-li
538b77c123 functions: add char function as mysql behavior 2019-10-28 10:44:56 +08:00
Nikolai Kochetov
43c8d13de6
Merge pull request #7496 from amosbird/fix15
Fix HAVING without GROUP BY
2019-10-28 02:44:24 +03:00
Amos Bird
77bdfb3350
Fix HAVING without GROUP BY 2019-10-27 22:10:54 +08:00
Nikita Mikhaylov
4fe0dda453 add cancel test 2019-10-25 21:03:38 +03:00
Azat Khuzhin
2d2e738085 Add CRC32IEEE()/CRC64() support
zlib's implementation uses CRC-32-IEEE 802.3 polynomial (0xedb88320) but
with starting value 0xffffffff, so introduce another crc32
implementation - CRC32IEEE that has starting value - 0

Also add CRC64 with ECMA polynomial.

v2: s/crc*_data./crc*_data./ to avoid conflicts with other crc32.h in contrib
v3: join with existing CRC32()
2019-10-25 15:52:41 +03:00
Nikita Mikhaylov
60ee52cb8d remove unrelated changes in tests 2019-10-25 15:28:52 +03:00
alesapin
04ca163518 Merge branch 'master' into dictionaries_ddl_loader 2019-10-25 10:58:04 +03:00
chertus
f2028e901d review related changes 2019-10-24 16:04:50 +03:00
chertus
12cd21f3c3 Merge branch 'master' into ast 2019-10-24 15:20:09 +03:00
Alexander Kuzmenkov
29052b6a37
Merge pull request #7377 from azat/INSERT-Distributed-MATERIALIZED-cols
* Fix INSERT into Distributed non local node with MATERIALIZED columns

Previous patch e527def18a ("Fix INSERT
into Distributed() table with MATERIALIZED column") fixes it only for
cases when the node is local, i.e. direct insert.

This patch address the problem when the node is not local
(`is_local == false`), by erasing materialized columns on INSERT into
Distributed.

And this patch fixes two cases, depends on `insert_distributed_sync`
setting:

- `insert_distributed_sync=0`

    ```
    Not found column value in block. There are only columns: date. Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5d6cf6 DB::Block::getByName(...) dbms/src/Core/Block.cpp:187
    4. 0x7fffec2fe067 DB::NativeBlockInputStream::readImpl() dbms/src/DataStreams/NativeBlockInputStream.cpp:159
    5. 0x7fffec2d223f DB::IBlockInputStream::read() dbms/src/DataStreams/IBlockInputStream.cpp:61
    6. 0x7ffff7c6d40d DB::TCPHandler::receiveData() dbms/programs/server/TCPHandler.cpp:971
    7. 0x7ffff7c6cc1d DB::TCPHandler::receivePacket() dbms/programs/server/TCPHandler.cpp:855
    8. 0x7ffff7c6a1ef DB::TCPHandler::readDataNext(unsigned long const&, int const&) dbms/programs/server/TCPHandler.cpp:406
    9. 0x7ffff7c6a41b DB::TCPHandler::readData(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:437
    10. 0x7ffff7c6a5d9 DB::TCPHandler::processInsertQuery(DB::Settings const&) dbms/programs/server/TCPHandler.cpp:464
    11. 0x7ffff7c687b5 DB::TCPHandler::runImpl() dbms/programs/server/TCPHandler.cpp:257
    ```

- `insert_distributed_sync=1`

    ```
    2019.10.18 13:23:22.114578 [ 44 ] {a78f669f-0b08-4337-abf8-d31e958f6d12} <Error> executeQuery: Code: 171, e.displayText() = DB::Exception: Block structure mismatch in RemoteBlockOutputStream stream: different number of columns:
    date Date UInt16(size = 1), value Date UInt16(size = 1)
    date Date UInt16(size = 0): Insertion status:
    Wrote 1 blocks and 0 rows on shard 0 replica 0, 127.0.0.1:59000 (average 0 ms per block)
    Wrote 0 blocks and 0 rows on shard 1 replica 0, 127.0.0.2:59000 (average 2 ms per block)
     (version 19.16.1.1) (from [::1]:3624) (in query: INSERT INTO distributed_00952 VALUES ), Stack trace:

    2. 0x7ffff7be92e0 DB::Exception::Exception() dbms/src/Common/Exception.h:27
    3. 0x7fffec5da4e9 DB::checkBlockStructure<void>(...)::{...}::operator()(...) const dbms/src/Core/Block.cpp:460
    4. 0x7fffec5da671 void DB::checkBlockStructure<void>(...) dbms/src/Core/Block.cpp:467
    5. 0x7fffec5d8d58 DB::assertBlocksHaveEqualStructure(...) dbms/src/Core/Block.cpp:515
    6. 0x7fffec326630 DB::RemoteBlockOutputStream::write(DB::Block const&) dbms/src/DataStreams/RemoteBlockOutputStream.cpp:68
    7. 0x7fffe98bd154 DB::DistributedBlockOutputStream::runWritingJob(DB::DistributedBlockOutputStream::JobReplica&, DB::Block const&)::{lambda()#1}::operator()() const dbms/src/Storages/Distributed/DistributedBlockOutputStream.cpp:280
    <snip>
    ````

Fixes: #7365
Fixes: #5429
Refs: #6891

* Cover INSERT into Distributed with MATERIALIZED columns and !is_local node

I guess that adding new cluster into server-test.xml is not required,
but it won't harm.

* Update DistributedBlockOutputStream.cpp
2019-10-24 12:35:09 +03:00
alesapin
a6199b7e69 Merge with master 2019-10-24 12:33:40 +03:00
Azat Khuzhin
80cf86f100 Cover INSERT into Distributed with MATERIALIZED columns and !is_local node
I guess that adding new cluster into server-test.xml is not required,
but it won't harm.
2019-10-23 21:55:08 +03:00
Artem Zuikov
bb1c1d0ed9
Merge pull request #7431 from arenadata/master
fix aggregation (avg and quantiles) over empty decimal columns.
2019-10-23 20:28:35 +03:00
alesapin
c3519ff376 Better check of dictionary lifetime for updates 2019-10-23 16:02:40 +03:00