Alexander Gololobov
7df137e460
Replaced asserts with logical errors
2022-12-29 14:33:11 +01:00
Alexander Gololobov
059ec6f747
Cleanups
2022-12-29 01:22:47 +01:00
Alexander Gololobov
10a058d138
More cleanups in the logic of applying current step filter and final filter
2022-12-28 18:07:36 +01:00
Alexander Gololobov
fd5d328fae
Test accumulating filters ignoring prewhere_info->need_filter flag
2022-12-28 18:07:36 +01:00
Alexander Gololobov
a7adc0a91b
Cleanups
2022-12-28 18:07:36 +01:00
Alexander Gololobov
b22711baa3
Reset need_filter flag when filter is applied
2022-12-28 18:07:36 +01:00
Alexander Gololobov
ada6422985
Restored old logic for filling _part_offset
2022-12-28 18:07:36 +01:00
Alexander Gololobov
4cebc6f3a4
Cleanups
2022-12-28 18:07:36 +01:00
Alexander Gololobov
13e457c754
Cleanups
2022-12-28 18:07:36 +01:00
Alexander Gololobov
a1cdad4815
Fix for reading _part_offset along with newly added column that has only default value
2022-12-28 18:07:35 +01:00
Alexander Gololobov
ac1549f6b3
Skip filtering if there are no rows after optimize()
2022-12-28 18:07:35 +01:00
Alexander Gololobov
f273f8712d
Avoid filtering same column in block_before_prewhere if it is present in the result
2022-12-28 18:07:35 +01:00
Alexander Gololobov
f3646248c5
Avoid unneeded work if all rows were filtered
2022-12-28 18:07:35 +01:00
Alexander Gololobov
75152ddabb
Apply filter only if needed
2022-12-28 18:07:35 +01:00
Alexander Gololobov
a18850458c
Test applying current filter at each step
2022-12-28 18:07:35 +01:00
Alexander Gololobov
29b5c4af07
Test dirty intermediate changes
2022-12-28 18:07:35 +01:00
Alexander Gololobov
c561acb774
Properly handle low cardinality column as prewhere filter
2022-12-28 18:07:35 +01:00
Alexander Gololobov
aa276b230b
Don't need to save filter and rows_per_granule from previous step
2022-12-28 18:07:35 +01:00
Alexander Gololobov
c4a01cbd5b
Fix for propely cleaning rows_per_granule_original between prewhere steps
2022-12-28 18:07:35 +01:00
Alexander Gololobov
abbb58107c
Fix for "out of bound" in ColumnVector::insertRangeFrom called from shrink()
2022-12-28 18:07:35 +01:00
Alexander Gololobov
79874e8733
Fix for "Invalid number of rows in Chunk"
2022-12-28 18:07:35 +01:00
Alexander Gololobov
bdf51545f7
Added FilterWithCachedCount class instead of caching counts in filter_bytes_map
2022-12-28 18:07:35 +01:00
Azat Khuzhin
31a88d4eae
Fix PREWHERE with row-level filters (when row filter is always true/false)
...
In case of row-level filters optimized out, i.e. converted to
always true/false, it is possible for MergeTreeRangeReader to reuse
incorrect statistics for the filter (countBytesInResultFilter()), and
because of this it simply does not apply other filters, since it assume
that this filter does not need to filter anything.
Fixes : #40956
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2022-12-28 18:07:35 +01:00
Alexander Gololobov
d44392b366
Checking the fix for "Invalid number of rows in Chunk"
2022-12-28 18:07:35 +01:00
Alexey Milovidov
bfe895975e
Merge pull request #44575 from ClickHouse/minimal-changes
...
Non-significant changes
2022-12-27 15:34:27 +03:00
Alexey Milovidov
464a513f0e
Merge pull request #44615 from ClickHouse/projection-grouping-sets
...
Disable projections in presense of any grouping sets, including WITH ROLLUP, WITH CUBE and WITH TOTALS
2022-12-27 15:31:03 +03:00
Alexey Milovidov
1b21cc018e
Merge pull request #44342 from ClickHouse/add-test-29883
...
Add a test for #29883
2022-12-27 14:55:14 +03:00
Alexey Milovidov
593675a7c5
Disable projections in presense of any grouping sets, including WITH ROLLUP, WITH CUBE and WITH TOTALS
2022-12-26 22:31:41 +01:00
Alexey Milovidov
52b306d544
Improve variable name
2022-12-26 18:00:18 +01:00
alesapin
d8924f0b0e
Merge pull request #44578 from ClickHouse/check-bad-index-granularity
...
Check for bad index granularity
2022-12-26 15:20:36 +01:00
Yakov Olkhovskiy
280e14456f
Merge pull request #44026 from ClickHouse/bug-ephemeral-default
...
Support expression for EPHEMERAL (currently only literal is supported)
2022-12-25 18:59:38 -05:00
Alexey Milovidov
71850f6913
Check for bad index_granularity
2022-12-25 16:06:34 +01:00
Alexey Milovidov
f22fc35900
Minimal changes
2022-12-25 14:18:05 +01:00
alesapin
2fecf420cb
Merge pull request #44513 from ClickHouse/small_polishing
...
Minor code polishing
2022-12-23 13:47:26 +01:00
Vladimir C
7482ea54ab
Merge pull request #43972 from ClickHouse/vdimir/tmp-data-in-fs-cache-2
2022-12-23 11:59:27 +01:00
Kseniia Sumarokova
068f2f329b
Merge pull request #44517 from kssenii/better-error-message
...
Better error message if named collection does not exist
2022-12-23 11:39:06 +01:00
Dmitry Novik
6c23721255
Merge pull request #43761 from ClickHouse/refector-function-node
...
Refactor FunctionNode
2022-12-22 23:53:27 +01:00
alesapin
a32fab90d5
Merge pull request #44436 from ClickHouse/fix_bug_with_max_task_count_update
...
Fix bug with merge/mutate pool size increase
2022-12-22 23:48:54 +01:00
Dmitry Novik
d3502937c7
Update MergeTreeIndexSet
2022-12-22 22:17:18 +00:00
Dmitry Novik
cff882d506
Merge remote-tracking branch 'origin/master' into refector-function-node
2022-12-22 21:34:29 +00:00
alesapin
8d0ad4bbcd
Strange why I have to supress in .cpp
2022-12-22 16:14:19 +01:00
kssenii
11c0aa189a
Better error message
2022-12-22 15:29:35 +01:00
alesapin
fa467b3398
Minor code polishing
2022-12-22 14:31:42 +01:00
Nikolai Kochetov
773de7a8a6
Merge pull request #44472 from CurtizJ/fix-mutations
...
Fix mutations with setting `max_streams_for_merge_tree_reading`
2022-12-22 14:05:20 +01:00
alesapin
049103c550
Merge pull request #44495 from azat/mergetree/static-storage-fix
...
Do not try to remove WAL/move broken parts for static storage
2022-12-22 12:27:08 +01:00
vdimir
88008726d8
Merge branch 'master' into vdimir/tmp-data-in-fs-cache-2
2022-12-22 10:58:39 +00:00
alesapin
380c6cebe4
Merge pull request #44393 from ClickHouse/small_improvement
...
Lock table for share during startup for database ordinary
2022-12-22 11:42:42 +01:00
alesapin
bf188c46a4
Merge branch 'master' into fix_bug_with_max_task_count_update
2022-12-22 11:40:08 +01:00
Maksim Kita
e5ebf20044
Merge pull request #44097 from kitaisreal/analyzer-support-set-index
...
Analyzer support Set index
2022-12-22 13:30:15 +03:00
vdimir
d30d25dbbe
Temporary files evict fs cache
2022-12-22 10:22:49 +00:00
