Commit Graph

147556 Commits

Author SHA1 Message Date
Haydn
5ea81366a7 Fix generateSnowflakeID function to handle invalid inputs gracefully and avoid output for invalid cases 2024-07-14 10:55:57 -07:00
Haydn
92b2a7d33d Updated generateSnowflakeID tests and reference outputs 2024-07-14 10:34:39 -07:00
Max K
5bce8086a8 CI: Create release workflow updates 2024-07-14 19:02:20 +02:00
Haydn
27273be84f Removed Duplicte args specifications 2024-07-14 09:51:13 -07:00
Haydn
ace4aa36bf Fixed generateSnowflakeID function and tests according
Update uuid-functions.md

Adjust comments in unit tests
2024-07-14 09:48:32 -07:00
alesapin
6a322b5357
Merge pull request #66249 from nauu/rename-to-avoid-ambiguity
Rename FilesystemCacheFailToReserveSpaceBecauseOfLockContention to FilesystemCacheFailToReserveSpaceBecauseOfCacheResize
2024-07-14 14:04:17 +00:00
Nikita Mikhaylov
451e99dcbc
Merge pull request #66482 from ClickHouse/add-test-37557
Add a test for #37557
2024-07-14 13:29:14 +00:00
Robert Schulze
3c39c4f514
Merge remote-tracking branch 'ClickHouse/master' into docs_partitionID 2024-07-14 12:40:05 +00:00
Max K
c889205d52
Merge pull request #66490 from ClickHouse/ci_fix_job_filter_prs
CI: Fix for job filtering in PRs
2024-07-14 12:37:00 +00:00
Max K
9dabf205e6 CI: Fix for await to always await for builds 2024-07-14 14:01:10 +02:00
Max K
f374cdfe69 CI: Fix for job filtering in PRs 2024-07-14 13:53:20 +02:00
Robert Schulze
ad86e3060a
OpenSSL: Follow-up to #66064
More commits were added to the upstream fix after #66064 has been merged
in ClickHouse. This PR adds these commits to keep things in-sync.
2024-07-14 11:48:13 +00:00
Max K
cff67cc0ee
Merge pull request #66488 from ClickHouse/ci_gh_retry
CI: Add retry for GH set_status_comment call
2024-07-14 11:06:24 +00:00
Robert Schulze
0b7ff4c3ee
Merge pull request #63186 from cucumber95/change_date
Add `changeDate*` functions
2024-07-14 10:46:56 +00:00
Max K
379706d2d5 fix for job filtering 2024-07-14 12:08:53 +02:00
Robert Schulze
ab2509fdd3
Merge remote-tracking branch 'ClickHouse/master' into 66010-add-machine-id-to-snowflakeid-clean 2024-07-14 10:05:17 +00:00
Max K
80c8511004 CI: Add retry for GH set_comment_status call 2024-07-14 11:39:31 +02:00
Azat Khuzhin
669ce7cd40 Enable jemalloc heap profiler by default for debug builds as well
Since the issue with jemalloc assertion is clear, let's revert that
workaround

Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-14 08:21:13 +02:00
Azat Khuzhin
22611781b0 Fix jemalloc assertion due to non-monotonic CLOCK_MONOTONIC_COARSE
Recently one tricky assertion of jemalloc had been discovered [1]:

    Failed assertion: "nstime_compare(&decay->epoch, new_time) <= 0"

  [1]: https://github.com/ClickHouse/ClickHouse/issues/66193

And as it turns out it is really possible for CLOCK_MONOTONIC_COARSE to
go backwards, in a nutshell it can be done with ADJ_FREQUENCY, you can
find example here [2]. And I can't trigger this issue for non-coarse
clocks.

  [2]: https://gist.github.com/azat/7ea7f50ed75591b1af2d675a240ea94c?permalink_comment_id=5119222#gistcomment-5119222

But, jemalloc do not call clock_gettime() that frequently (I've verified
it), so it can use non-coarse version - CLOCK_MONOTONIC

I've also measured the latency of CLOCK_MONOTONIC and
CLOCK_MONOTONIC_COARSE, and it is 20ns vs 4ns per call [3], so make this
change affect performance you need really frequently calls of
clock_gettime.

  [3]: https://gist.github.com/azat/622fa1f9a5d8e7d546ee9d294501961d?permalink_comment_id=5119245#gistcomment-5119245

Interesting, that this bug started to appears only after jemalloc heap
profiler had been enabled by default [4], no clue why (I would believe
more in a more frequent calls to clock_adjtime(ADJ_FREQUENCY), but I
can't verify this)

  [4]: https://github.com/ClickHouse/ClickHouse/pull/65702

To be continued...

Fixes: https://github.com/ClickHouse/ClickHouse/issues/66193
Signed-off-by: Azat Khuzhin <a.khuzhin@semrush.com>
2024-07-14 08:21:13 +02:00
Shaun Struwig
5daac46d8c
Merge branch 'ClickHouse:master' into docs_partitionID 2024-07-14 05:34:01 +02:00
Alexey Milovidov
045a7f4b8f Merge branch 'master' of github.com:ClickHouse/ClickHouse into add-test-37557 2024-07-14 01:10:39 +02:00
Alexey Milovidov
4237912d4e Merge branch 'master' into add-test-37557 2024-07-14 01:10:29 +02:00
Haydn
6ed138b1a4 Fix syntax error in generateSnowflakeID.cpp 2024-07-13 16:06:31 -07:00
Alexey Milovidov
ce37be3ab1
Merge branch 'master' into signal_handlers_in_client 2024-07-14 00:54:30 +02:00
Haydn
5826f1f073 [ClickHouse-66010] Add machine_id parameter to generateSnowflakeID function and update tests 2024-07-13 15:39:48 -07:00
Shaun Struwig
a90e10c438 add alias partitionI, update tests, and docs 2024-07-13 22:38:28 +00:00
Alexey Milovidov
860db03d13
Merge pull request #66460 from ClickHouse/tavplubix-patch-10
Update 00992_system_parts_race_condition_zookeeper_long.sh
2024-07-13 22:21:00 +00:00
Robert Schulze
dfb831f861
Try to fix an msan issue 2024-07-13 22:07:46 +00:00
Alexey Milovidov
a8219d3848
Merge pull request #66233 from arthurpassos/remove_concurrent_auth_storm
Remove host regexp concurrent integration test
2024-07-13 21:37:58 +00:00
Alexey Milovidov
e3a2a2e487
Merge pull request #66353 from ClickHouse/collect-minio-logs
Collect logs from `minio` in stateless and statefull tests
2024-07-13 21:34:50 +00:00
Alexey Milovidov
6ba7765b81
Update 03203_multiif_and_where_2_conditions_old_analyzer_bug.sql 2024-07-13 23:33:29 +02:00
Alexey Milovidov
e71f0fe385
Merge pull request #66375 from azat/dist-fix-log
Fix "Sending a batch of X files to Y (0.00 rows, 0.00 B bytes)." in case of batch restoring
2024-07-13 21:32:21 +00:00
Alexey Milovidov
d320528f04
Merge pull request #66376 from azat/tests/03030_system_flush_distributed_settings
Fix 03030_system_flush_distributed_settings flakiness
2024-07-13 21:31:15 +00:00
Alexey Milovidov
c322c6b423
Merge pull request #66398 from azat/play-elapsed
Add query elapsed time for non-default format in play UI
2024-07-13 21:30:56 +00:00
Haydn
08cce45258 Fix handling of machine_id in generateSnowflakeID to read conditionally and assign efficiently 2024-07-13 14:25:42 -07:00
Haydn
0925830f2e Refactored generateSnowflakeID function implementation and added comprehensive SQL tests 2024-07-13 14:01:03 -07:00
Alexey Milovidov
b7465016cb
Merge pull request #66406 from ClickHouse/remove-noisy-message
Remove noisy message
2024-07-13 20:55:39 +00:00
Alexey Milovidov
62dac875b8
Merge pull request #66435 from ClickHouse/limit_linker_jobs_on_aarch
Limit number of linker jobs on arm to avoid OOM during build
2024-07-13 20:50:49 +00:00
Alexey Milovidov
f037e01620
Merge pull request #66461 from yariks5s/fix_logical_error_npy
Fix logical error in npy data format
2024-07-13 20:49:26 +00:00
Alexey Milovidov
b123659702 Merge branch 'master' into tavplubix-patch-10 2024-07-13 22:48:20 +02:00
Alexey Milovidov
e1aac19630 Fix test 2024-07-13 22:43:30 +02:00
Alexey Milovidov
1220361390 Merge branch 'master' into group_array_intersect_merge_fix 2024-07-13 22:28:29 +02:00
Alexey Milovidov
6f08e78514
Update 03198_group_array_intersect.sql 2024-07-13 22:27:16 +02:00
Robert Schulze
2f913f193c
Fixup docs 2024-07-13 20:25:58 +00:00
Alexey Milovidov
7b4e7b6ae8 Merge branch 'master' into uninteresting-changes 2024-07-13 22:25:11 +02:00
Alexey Milovidov
11647c2382
Merge pull request #65973 from ClickHouse/named-collections-in-clickhouse-local
Named collections in clickhouse-local
2024-07-13 20:22:27 +00:00
Alexey Milovidov
4ebd88f64a
Merge pull request #66477 from ClickHouse/ci_strict_job_check
CI: Check job's exit status and report if killed
2024-07-13 20:22:08 +00:00
Robert Schulze
eb9a629868
Revert "remove partitionID function, update tests and remove from documentation"
This reverts commit c3b72386a2.
2024-07-13 20:06:37 +00:00
Robert Schulze
cef13cfa72
Revert "Update 02415_all_new_functions_must_be_documented.reference"
This reverts commit ee4162f5ec.
2024-07-13 20:06:19 +00:00
Robert Schulze
9b87a1469b
Revert "Fix integration tests"
This reverts commit 85f5fe832a.
2024-07-13 20:06:12 +00:00